Skip to content

fix(ui): Simple theme checkbox styles - #8922

Merged
alexcarpenter merged 2 commits into
mainfrom
carp/fix-simple-theme-checkbox
Jun 18, 2026
Merged

fix(ui): Simple theme checkbox styles#8922
alexcarpenter merged 2 commits into
mainfrom
carp/fix-simple-theme-checkbox

Conversation

@alexcarpenter

@alexcarpenteralexcarpenter commented Jun 18, 2026

Copy link
Copy Markdown
Member

Description

Fixes an issue in simple theme usage where checkboxes where not preserving their default styles.

BEFOREAFTER
Screenshot 2026-06-18 at 4 53 29 PMScreenshot 2026-06-18 at 4 52 54 PM
Screenshot 2026-06-18 at 4 53 55 PMScreenshot 2026-06-18 at 4 54 20 PM

BEFORE

before.mov

AFTER

after.mov

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

@vercel

vercelBot commented Jun 18, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxReadyReadyPreview, CommentJun 18, 2026 8:52pm
swingsetReadyReadyPreview, CommentJun 18, 2026 8:52pm

Request Review

@changeset-bot

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 6c6d9e1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
NameType
@clerk/uiPatch
@clerk/chrome-extensionPatch
@clerk/swingsetPatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@coderabbitai

coderabbitaiBot commented Jun 18, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

📝 Walkthrough

Walkthrough

Checkbox appearance is fixed for the simple theme by injecting custom CSS into the Input primitive for type=checkbox inputs and extracting a checkboxBaseStyles helper in baseTheme.ts. A width: 'fit-content' rule is removed from CheckboxIndicator, and a patch changeset entry is added.

Changes

Checkbox Default Styling

Layer / File(s)Summary
Checkbox styles in Input primitive and CheckboxIndicator fix
packages/ui/src/primitives/Input.tsx, packages/ui/src/elements/FieldControl.tsx
Input base style gains a conditional block for type=checkbox that removes native appearance, sets fixed dimensions, configures background rendering, and defines a :checked SVG state with $primary500 background. borderRadius in the default variant is restricted to checkbox inputs. CheckboxIndicator drops its width: 'fit-content' rule.
checkboxBaseStyles helper extraction in baseTheme
packages/ui/src/baseTheme.ts, .changeset/kind-melons-own.md
New checkboxBaseStyles(theme) helper centralizes checkbox layout and :checked appearance. clerkTheme.elements.checkbox is refactored to spread this helper while keeping neutral shadow styling and a borderColor: $transparent override. Patch changeset entry added for @clerk/ui.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Suggested labels

ui

Suggested reviewers

  • kylemac

Poem

🐇 A checkbox once plain, now styled with care,
SVG checkmarks floating in the air,
No fit-content width to cause a fuss,
The simple theme now renders right for us!
Hop hop hooray for cleaner style—
This little patch is worth the while! ✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check nameStatusExplanation
Title check✅ PassedThe title accurately describes the main change: fixing checkbox styling in the simple theme for the UI package.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@pkg-pr-new

Copy link
Copy Markdown

Open in StackBlitz

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@8922

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@8922

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@8922

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@8922

@clerk/eslint-plugin

npm i https://pkg.pr.new/@clerk/eslint-plugin@8922

@clerk/expo

npm i https://pkg.pr.new/@clerk/expo@8922

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@8922

@clerk/express

npm i https://pkg.pr.new/@clerk/express@8922

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@8922

@clerk/hono

npm i https://pkg.pr.new/@clerk/hono@8922

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@8922

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@8922

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@8922

@clerk/react

npm i https://pkg.pr.new/@clerk/react@8922

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@8922

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@8922

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@8922

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@8922

@clerk/ui

npm i https://pkg.pr.new/@clerk/ui@8922

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@8922

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@8922

commit: 6c6d9e1

@github-actions

Copy link
Copy Markdown
Contributor

API Changes Report

Generated by Break Check on 2026-06-18T20:56:02.377Z

Summary

MetricCount
Packages analyzed19
Packages with changes0
🔴 Breaking changes0
🟡 Non-breaking changes0
🟢 Additions0

No API Changes Detected

All packages have stable APIs with no detected changes.


Report generated by Break Check

Last ran on 6c6d9e1.

@coderabbitaicoderabbitaiBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@packages/ui/src/primitives/Input.tsx`:
- Around line 30-33: The theme.colors.$white value is being interpolated
unescaped into the SVG data URI within the checked state styles in the Input.tsx
file. If this color resolves to a hex value like `#fff`, the # character will
break the URI syntax. URL-encode the theme.colors.$white interpolation before
inserting it into the data URI string using appropriate URL encoding (e.g.,
encodeURIComponent) to ensure special characters like # are properly escaped.
Apply the same URL-encoding fix to the corresponding color interpolation in
baseTheme.ts where similar SVG data URIs are defined.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Repository UI (inherited)

Review profile: CHILL

Plan: Pro

Run ID: b4511a5f-26bb-4844-b752-2d6440bbfe0c

📥 Commits

Reviewing files that changed from the base of the PR and between 15b059c and 6c6d9e1.

📒 Files selected for processing (4)
  • .changeset/kind-melons-own.md
  • packages/ui/src/baseTheme.ts
  • packages/ui/src/elements/FieldControl.tsx
  • packages/ui/src/primitives/Input.tsx
💤 Files with no reviewable changes (1)
  • packages/ui/src/elements/FieldControl.tsx

Comment threadpackages/ui/src/primitives/Input.tsx

@dmoernerdmoerner left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thank you!

@alexcarpenter
alexcarpenter merged commit 08c6cfc into mainJun 18, 2026
53 checks passed
@alexcarpenter
alexcarpenter deleted the carp/fix-simple-theme-checkbox branch June 18, 2026 21:53
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@alexcarpenter@dmoerner
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
fix(ui): Simple theme checkbox styles by alexcarpenter · Pull Request #8922 · clerk/javascript · GitHub
Skip to content

fix(ui): Simple theme checkbox styles - #8922

Merged
alexcarpenter merged 2 commits into
mainfrom
carp/fix-simple-theme-checkbox
Jun 18, 2026
Merged

fix(ui): Simple theme checkbox styles#8922
alexcarpenter merged 2 commits into
mainfrom
carp/fix-simple-theme-checkbox

Conversation

@alexcarpenter

@alexcarpenteralexcarpenter commented Jun 18, 2026

Copy link
Copy Markdown
Member

Description

Fixes an issue in simple theme usage where checkboxes where not preserving their default styles.

BEFOREAFTER
Screenshot 2026-06-18 at 4 53 29 PMScreenshot 2026-06-18 at 4 52 54 PM
Screenshot 2026-06-18 at 4 53 55 PMScreenshot 2026-06-18 at 4 54 20 PM

BEFORE

before.mov

AFTER

after.mov

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

@vercel

vercelBot commented Jun 18, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxReadyReadyPreview, CommentJun 18, 2026 8:52pm
swingsetReadyReadyPreview, CommentJun 18, 2026 8:52pm

Request Review

@changeset-bot

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 6c6d9e1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
NameType
@clerk/uiPatch
@clerk/chrome-extensionPatch
@clerk/swingsetPatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@coderabbitai

coderabbitaiBot commented Jun 18, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

📝 Walkthrough

Walkthrough

Checkbox appearance is fixed for the simple theme by injecting custom CSS into the Input primitive for type=checkbox inputs and extracting a checkboxBaseStyles helper in baseTheme.ts. A width: 'fit-content' rule is removed from CheckboxIndicator, and a patch changeset entry is added.

Changes

Checkbox Default Styling

Layer / File(s)Summary
Checkbox styles in Input primitive and CheckboxIndicator fix
packages/ui/src/primitives/Input.tsx, packages/ui/src/elements/FieldControl.tsx
Input base style gains a conditional block for type=checkbox that removes native appearance, sets fixed dimensions, configures background rendering, and defines a :checked SVG state with $primary500 background. borderRadius in the default variant is restricted to checkbox inputs. CheckboxIndicator drops its width: 'fit-content' rule.
checkboxBaseStyles helper extraction in baseTheme
packages/ui/src/baseTheme.ts, .changeset/kind-melons-own.md
New checkboxBaseStyles(theme) helper centralizes checkbox layout and :checked appearance. clerkTheme.elements.checkbox is refactored to spread this helper while keeping neutral shadow styling and a borderColor: $transparent override. Patch changeset entry added for @clerk/ui.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Suggested labels

ui

Suggested reviewers

  • kylemac

Poem

🐇 A checkbox once plain, now styled with care,
SVG checkmarks floating in the air,
No fit-content width to cause a fuss,
The simple theme now renders right for us!
Hop hop hooray for cleaner style—
This little patch is worth the while! ✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check nameStatusExplanation
Title check✅ PassedThe title accurately describes the main change: fixing checkbox styling in the simple theme for the UI package.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@pkg-pr-new

Copy link
Copy Markdown

Open in StackBlitz

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@8922

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@8922

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@8922

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@8922

@clerk/eslint-plugin

npm i https://pkg.pr.new/@clerk/eslint-plugin@8922

@clerk/expo

npm i https://pkg.pr.new/@clerk/expo@8922

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@8922

@clerk/express

npm i https://pkg.pr.new/@clerk/express@8922

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@8922

@clerk/hono

npm i https://pkg.pr.new/@clerk/hono@8922

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@8922

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@8922

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@8922

@clerk/react

npm i https://pkg.pr.new/@clerk/react@8922

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@8922

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@8922

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@8922

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@8922

@clerk/ui

npm i https://pkg.pr.new/@clerk/ui@8922

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@8922

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@8922

commit: 6c6d9e1

@github-actions

Copy link
Copy Markdown
Contributor

API Changes Report

Generated by Break Check on 2026-06-18T20:56:02.377Z

Summary

MetricCount
Packages analyzed19
Packages with changes0
🔴 Breaking changes0
🟡 Non-breaking changes0
🟢 Additions0

No API Changes Detected

All packages have stable APIs with no detected changes.


Report generated by Break Check

Last ran on 6c6d9e1.

@coderabbitaicoderabbitaiBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@packages/ui/src/primitives/Input.tsx`:
- Around line 30-33: The theme.colors.$white value is being interpolated
unescaped into the SVG data URI within the checked state styles in the Input.tsx
file. If this color resolves to a hex value like `#fff`, the # character will
break the URI syntax. URL-encode the theme.colors.$white interpolation before
inserting it into the data URI string using appropriate URL encoding (e.g.,
encodeURIComponent) to ensure special characters like # are properly escaped.
Apply the same URL-encoding fix to the corresponding color interpolation in
baseTheme.ts where similar SVG data URIs are defined.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Repository UI (inherited)

Review profile: CHILL

Plan: Pro

Run ID: b4511a5f-26bb-4844-b752-2d6440bbfe0c

📥 Commits

Reviewing files that changed from the base of the PR and between 15b059c and 6c6d9e1.

📒 Files selected for processing (4)
  • .changeset/kind-melons-own.md
  • packages/ui/src/baseTheme.ts
  • packages/ui/src/elements/FieldControl.tsx
  • packages/ui/src/primitives/Input.tsx
💤 Files with no reviewable changes (1)
  • packages/ui/src/elements/FieldControl.tsx

Comment threadpackages/ui/src/primitives/Input.tsx

@dmoernerdmoerner left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thank you!

@alexcarpenter
alexcarpenter merged commit 08c6cfc into mainJun 18, 2026
53 checks passed
@alexcarpenter
alexcarpenter deleted the carp/fix-simple-theme-checkbox branch June 18, 2026 21:53
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@alexcarpenter@dmoerner
, 'i'); if (__m === '*' || __re.test(location.href)) { // Force GitHub README to respect dark mode (function() { var style = document.createElement('style'); style.textContent = ' .markdown-body { color-scheme: dark light; } .markdown-body pre { background: #161b22 !important; } .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; } .markdown-body table th, .markdown-body table td { border-color: #30363d !important; } .markdown-body img { background: #0d1117; } .markdown-body blockquote { border-left-color: #8b949e; } .markdown-body hr { border-color: #30363d; } '; document.head.appendChild(style); })(); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' fix(ui): Simple theme checkbox styles by alexcarpenter · Pull Request #8922 · clerk/javascript · GitHub
Skip to content

fix(ui): Simple theme checkbox styles - #8922

Merged
alexcarpenter merged 2 commits into
mainfrom
carp/fix-simple-theme-checkbox
Jun 18, 2026
Merged

fix(ui): Simple theme checkbox styles#8922
alexcarpenter merged 2 commits into
mainfrom
carp/fix-simple-theme-checkbox

Conversation

@alexcarpenter

@alexcarpenteralexcarpenter commented Jun 18, 2026

Copy link
Copy Markdown
Member

Description

Fixes an issue in simple theme usage where checkboxes where not preserving their default styles.

BEFOREAFTER
Screenshot 2026-06-18 at 4 53 29 PMScreenshot 2026-06-18 at 4 52 54 PM
Screenshot 2026-06-18 at 4 53 55 PMScreenshot 2026-06-18 at 4 54 20 PM

BEFORE

before.mov

AFTER

after.mov

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

@vercel

vercelBot commented Jun 18, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxReadyReadyPreview, CommentJun 18, 2026 8:52pm
swingsetReadyReadyPreview, CommentJun 18, 2026 8:52pm

Request Review

@changeset-bot

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 6c6d9e1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
NameType
@clerk/uiPatch
@clerk/chrome-extensionPatch
@clerk/swingsetPatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@coderabbitai

coderabbitaiBot commented Jun 18, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

📝 Walkthrough

Walkthrough

Checkbox appearance is fixed for the simple theme by injecting custom CSS into the Input primitive for type=checkbox inputs and extracting a checkboxBaseStyles helper in baseTheme.ts. A width: 'fit-content' rule is removed from CheckboxIndicator, and a patch changeset entry is added.

Changes

Checkbox Default Styling

Layer / File(s)Summary
Checkbox styles in Input primitive and CheckboxIndicator fix
packages/ui/src/primitives/Input.tsx, packages/ui/src/elements/FieldControl.tsx
Input base style gains a conditional block for type=checkbox that removes native appearance, sets fixed dimensions, configures background rendering, and defines a :checked SVG state with $primary500 background. borderRadius in the default variant is restricted to checkbox inputs. CheckboxIndicator drops its width: 'fit-content' rule.
checkboxBaseStyles helper extraction in baseTheme
packages/ui/src/baseTheme.ts, .changeset/kind-melons-own.md
New checkboxBaseStyles(theme) helper centralizes checkbox layout and :checked appearance. clerkTheme.elements.checkbox is refactored to spread this helper while keeping neutral shadow styling and a borderColor: $transparent override. Patch changeset entry added for @clerk/ui.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Suggested labels

ui

Suggested reviewers

  • kylemac

Poem

🐇 A checkbox once plain, now styled with care,
SVG checkmarks floating in the air,
No fit-content width to cause a fuss,
The simple theme now renders right for us!
Hop hop hooray for cleaner style—
This little patch is worth the while! ✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check nameStatusExplanation
Title check✅ PassedThe title accurately describes the main change: fixing checkbox styling in the simple theme for the UI package.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@pkg-pr-new

Copy link
Copy Markdown

Open in StackBlitz

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@8922

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@8922

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@8922

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@8922

@clerk/eslint-plugin

npm i https://pkg.pr.new/@clerk/eslint-plugin@8922

@clerk/expo

npm i https://pkg.pr.new/@clerk/expo@8922

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@8922

@clerk/express

npm i https://pkg.pr.new/@clerk/express@8922

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@8922

@clerk/hono

npm i https://pkg.pr.new/@clerk/hono@8922

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@8922

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@8922

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@8922

@clerk/react

npm i https://pkg.pr.new/@clerk/react@8922

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@8922

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@8922

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@8922

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@8922

@clerk/ui

npm i https://pkg.pr.new/@clerk/ui@8922

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@8922

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@8922

commit: 6c6d9e1

@github-actions

Copy link
Copy Markdown
Contributor

API Changes Report

Generated by Break Check on 2026-06-18T20:56:02.377Z

Summary

MetricCount
Packages analyzed19
Packages with changes0
🔴 Breaking changes0
🟡 Non-breaking changes0
🟢 Additions0

No API Changes Detected

All packages have stable APIs with no detected changes.


Report generated by Break Check

Last ran on 6c6d9e1.

@coderabbitaicoderabbitaiBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@packages/ui/src/primitives/Input.tsx`:
- Around line 30-33: The theme.colors.$white value is being interpolated
unescaped into the SVG data URI within the checked state styles in the Input.tsx
file. If this color resolves to a hex value like `#fff`, the # character will
break the URI syntax. URL-encode the theme.colors.$white interpolation before
inserting it into the data URI string using appropriate URL encoding (e.g.,
encodeURIComponent) to ensure special characters like # are properly escaped.
Apply the same URL-encoding fix to the corresponding color interpolation in
baseTheme.ts where similar SVG data URIs are defined.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Repository UI (inherited)

Review profile: CHILL

Plan: Pro

Run ID: b4511a5f-26bb-4844-b752-2d6440bbfe0c

📥 Commits

Reviewing files that changed from the base of the PR and between 15b059c and 6c6d9e1.

📒 Files selected for processing (4)
  • .changeset/kind-melons-own.md
  • packages/ui/src/baseTheme.ts
  • packages/ui/src/elements/FieldControl.tsx
  • packages/ui/src/primitives/Input.tsx
💤 Files with no reviewable changes (1)
  • packages/ui/src/elements/FieldControl.tsx

Comment threadpackages/ui/src/primitives/Input.tsx

@dmoernerdmoerner left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thank you!

@alexcarpenter
alexcarpenter merged commit 08c6cfc into mainJun 18, 2026
53 checks passed
@alexcarpenter
alexcarpenter deleted the carp/fix-simple-theme-checkbox branch June 18, 2026 21:53
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@alexcarpenter@dmoerner
, 'i'); if (__m === '*' || __re.test(location.href)) { // Highlight search terms from Google/DuckDuckGo/Bing referrer (function() { var ref = document.referrer; var terms = []; if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) { var url = new URL(ref); var q = url.searchParams.get('q') || url.searchParams.get('p'); if (q) { terms = q.split(/\s+/).filter(function(t) { return t.length > 2; }); } } if (terms.length === 0) return; var style = document.createElement('style'); style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }'; document.head.appendChild(style); function highlight(node) { if (node.nodeType === 3) { // text node var text = node.textContent; var found = false; terms.forEach(function(term) { var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' fix(ui): Simple theme checkbox styles by alexcarpenter · Pull Request #8922 · clerk/javascript · GitHub
Skip to content

fix(ui): Simple theme checkbox styles - #8922

Merged
alexcarpenter merged 2 commits into
mainfrom
carp/fix-simple-theme-checkbox
Jun 18, 2026
Merged

fix(ui): Simple theme checkbox styles#8922
alexcarpenter merged 2 commits into
mainfrom
carp/fix-simple-theme-checkbox

Conversation

@alexcarpenter

@alexcarpenteralexcarpenter commented Jun 18, 2026

Copy link
Copy Markdown
Member

Description

Fixes an issue in simple theme usage where checkboxes where not preserving their default styles.

BEFOREAFTER
Screenshot 2026-06-18 at 4 53 29 PMScreenshot 2026-06-18 at 4 52 54 PM
Screenshot 2026-06-18 at 4 53 55 PMScreenshot 2026-06-18 at 4 54 20 PM

BEFORE

before.mov

AFTER

after.mov

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

@vercel

vercelBot commented Jun 18, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxReadyReadyPreview, CommentJun 18, 2026 8:52pm
swingsetReadyReadyPreview, CommentJun 18, 2026 8:52pm

Request Review

@changeset-bot

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 6c6d9e1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
NameType
@clerk/uiPatch
@clerk/chrome-extensionPatch
@clerk/swingsetPatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@coderabbitai

coderabbitaiBot commented Jun 18, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

📝 Walkthrough

Walkthrough

Checkbox appearance is fixed for the simple theme by injecting custom CSS into the Input primitive for type=checkbox inputs and extracting a checkboxBaseStyles helper in baseTheme.ts. A width: 'fit-content' rule is removed from CheckboxIndicator, and a patch changeset entry is added.

Changes

Checkbox Default Styling

Layer / File(s)Summary
Checkbox styles in Input primitive and CheckboxIndicator fix
packages/ui/src/primitives/Input.tsx, packages/ui/src/elements/FieldControl.tsx
Input base style gains a conditional block for type=checkbox that removes native appearance, sets fixed dimensions, configures background rendering, and defines a :checked SVG state with $primary500 background. borderRadius in the default variant is restricted to checkbox inputs. CheckboxIndicator drops its width: 'fit-content' rule.
checkboxBaseStyles helper extraction in baseTheme
packages/ui/src/baseTheme.ts, .changeset/kind-melons-own.md
New checkboxBaseStyles(theme) helper centralizes checkbox layout and :checked appearance. clerkTheme.elements.checkbox is refactored to spread this helper while keeping neutral shadow styling and a borderColor: $transparent override. Patch changeset entry added for @clerk/ui.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Suggested labels

ui

Suggested reviewers

  • kylemac

Poem

🐇 A checkbox once plain, now styled with care,
SVG checkmarks floating in the air,
No fit-content width to cause a fuss,
The simple theme now renders right for us!
Hop hop hooray for cleaner style—
This little patch is worth the while! ✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check nameStatusExplanation
Title check✅ PassedThe title accurately describes the main change: fixing checkbox styling in the simple theme for the UI package.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@pkg-pr-new

Copy link
Copy Markdown

Open in StackBlitz

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@8922

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@8922

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@8922

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@8922

@clerk/eslint-plugin

npm i https://pkg.pr.new/@clerk/eslint-plugin@8922

@clerk/expo

npm i https://pkg.pr.new/@clerk/expo@8922

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@8922

@clerk/express

npm i https://pkg.pr.new/@clerk/express@8922

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@8922

@clerk/hono

npm i https://pkg.pr.new/@clerk/hono@8922

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@8922

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@8922

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@8922

@clerk/react

npm i https://pkg.pr.new/@clerk/react@8922

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@8922

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@8922

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@8922

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@8922

@clerk/ui

npm i https://pkg.pr.new/@clerk/ui@8922

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@8922

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@8922

commit: 6c6d9e1

@github-actions

Copy link
Copy Markdown
Contributor

API Changes Report

Generated by Break Check on 2026-06-18T20:56:02.377Z

Summary

MetricCount
Packages analyzed19
Packages with changes0
🔴 Breaking changes0
🟡 Non-breaking changes0
🟢 Additions0

No API Changes Detected

All packages have stable APIs with no detected changes.


Report generated by Break Check

Last ran on 6c6d9e1.

@coderabbitaicoderabbitaiBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@packages/ui/src/primitives/Input.tsx`:
- Around line 30-33: The theme.colors.$white value is being interpolated
unescaped into the SVG data URI within the checked state styles in the Input.tsx
file. If this color resolves to a hex value like `#fff`, the # character will
break the URI syntax. URL-encode the theme.colors.$white interpolation before
inserting it into the data URI string using appropriate URL encoding (e.g.,
encodeURIComponent) to ensure special characters like # are properly escaped.
Apply the same URL-encoding fix to the corresponding color interpolation in
baseTheme.ts where similar SVG data URIs are defined.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Repository UI (inherited)

Review profile: CHILL

Plan: Pro

Run ID: b4511a5f-26bb-4844-b752-2d6440bbfe0c

📥 Commits

Reviewing files that changed from the base of the PR and between 15b059c and 6c6d9e1.

📒 Files selected for processing (4)
  • .changeset/kind-melons-own.md
  • packages/ui/src/baseTheme.ts
  • packages/ui/src/elements/FieldControl.tsx
  • packages/ui/src/primitives/Input.tsx
💤 Files with no reviewable changes (1)
  • packages/ui/src/elements/FieldControl.tsx

Comment threadpackages/ui/src/primitives/Input.tsx

@dmoernerdmoerner left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thank you!

@alexcarpenter
alexcarpenter merged commit 08c6cfc into mainJun 18, 2026
53 checks passed
@alexcarpenter
alexcarpenter deleted the carp/fix-simple-theme-checkbox branch June 18, 2026 21:53
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@alexcarpenter@dmoerner
, 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ' fix(ui): Simple theme checkbox styles by alexcarpenter · Pull Request #8922 · clerk/javascript · GitHub
Skip to content

fix(ui): Simple theme checkbox styles - #8922

Merged
alexcarpenter merged 2 commits into
mainfrom
carp/fix-simple-theme-checkbox
Jun 18, 2026
Merged

fix(ui): Simple theme checkbox styles#8922
alexcarpenter merged 2 commits into
mainfrom
carp/fix-simple-theme-checkbox

Conversation

@alexcarpenter

@alexcarpenteralexcarpenter commented Jun 18, 2026

Copy link
Copy Markdown
Member

Description

Fixes an issue in simple theme usage where checkboxes where not preserving their default styles.

BEFOREAFTER
Screenshot 2026-06-18 at 4 53 29 PMScreenshot 2026-06-18 at 4 52 54 PM
Screenshot 2026-06-18 at 4 53 55 PMScreenshot 2026-06-18 at 4 54 20 PM

BEFORE

before.mov

AFTER

after.mov

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

@vercel

vercelBot commented Jun 18, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxReadyReadyPreview, CommentJun 18, 2026 8:52pm
swingsetReadyReadyPreview, CommentJun 18, 2026 8:52pm

Request Review

@changeset-bot

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 6c6d9e1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
NameType
@clerk/uiPatch
@clerk/chrome-extensionPatch
@clerk/swingsetPatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@coderabbitai

coderabbitaiBot commented Jun 18, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

📝 Walkthrough

Walkthrough

Checkbox appearance is fixed for the simple theme by injecting custom CSS into the Input primitive for type=checkbox inputs and extracting a checkboxBaseStyles helper in baseTheme.ts. A width: 'fit-content' rule is removed from CheckboxIndicator, and a patch changeset entry is added.

Changes

Checkbox Default Styling

Layer / File(s)Summary
Checkbox styles in Input primitive and CheckboxIndicator fix
packages/ui/src/primitives/Input.tsx, packages/ui/src/elements/FieldControl.tsx
Input base style gains a conditional block for type=checkbox that removes native appearance, sets fixed dimensions, configures background rendering, and defines a :checked SVG state with $primary500 background. borderRadius in the default variant is restricted to checkbox inputs. CheckboxIndicator drops its width: 'fit-content' rule.
checkboxBaseStyles helper extraction in baseTheme
packages/ui/src/baseTheme.ts, .changeset/kind-melons-own.md
New checkboxBaseStyles(theme) helper centralizes checkbox layout and :checked appearance. clerkTheme.elements.checkbox is refactored to spread this helper while keeping neutral shadow styling and a borderColor: $transparent override. Patch changeset entry added for @clerk/ui.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Suggested labels

ui

Suggested reviewers

  • kylemac

Poem

🐇 A checkbox once plain, now styled with care,
SVG checkmarks floating in the air,
No fit-content width to cause a fuss,
The simple theme now renders right for us!
Hop hop hooray for cleaner style—
This little patch is worth the while! ✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check nameStatusExplanation
Title check✅ PassedThe title accurately describes the main change: fixing checkbox styling in the simple theme for the UI package.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@pkg-pr-new

Copy link
Copy Markdown

Open in StackBlitz

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@8922

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@8922

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@8922

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@8922

@clerk/eslint-plugin

npm i https://pkg.pr.new/@clerk/eslint-plugin@8922

@clerk/expo

npm i https://pkg.pr.new/@clerk/expo@8922

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@8922

@clerk/express

npm i https://pkg.pr.new/@clerk/express@8922

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@8922

@clerk/hono

npm i https://pkg.pr.new/@clerk/hono@8922

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@8922

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@8922

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@8922

@clerk/react

npm i https://pkg.pr.new/@clerk/react@8922

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@8922

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@8922

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@8922

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@8922

@clerk/ui

npm i https://pkg.pr.new/@clerk/ui@8922

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@8922

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@8922

commit: 6c6d9e1

@github-actions

Copy link
Copy Markdown
Contributor

API Changes Report

Generated by Break Check on 2026-06-18T20:56:02.377Z

Summary

MetricCount
Packages analyzed19
Packages with changes0
🔴 Breaking changes0
🟡 Non-breaking changes0
🟢 Additions0

No API Changes Detected

All packages have stable APIs with no detected changes.


Report generated by Break Check

Last ran on 6c6d9e1.

@coderabbitaicoderabbitaiBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@packages/ui/src/primitives/Input.tsx`:
- Around line 30-33: The theme.colors.$white value is being interpolated
unescaped into the SVG data URI within the checked state styles in the Input.tsx
file. If this color resolves to a hex value like `#fff`, the # character will
break the URI syntax. URL-encode the theme.colors.$white interpolation before
inserting it into the data URI string using appropriate URL encoding (e.g.,
encodeURIComponent) to ensure special characters like # are properly escaped.
Apply the same URL-encoding fix to the corresponding color interpolation in
baseTheme.ts where similar SVG data URIs are defined.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Repository UI (inherited)

Review profile: CHILL

Plan: Pro

Run ID: b4511a5f-26bb-4844-b752-2d6440bbfe0c

📥 Commits

Reviewing files that changed from the base of the PR and between 15b059c and 6c6d9e1.

📒 Files selected for processing (4)
  • .changeset/kind-melons-own.md
  • packages/ui/src/baseTheme.ts
  • packages/ui/src/elements/FieldControl.tsx
  • packages/ui/src/primitives/Input.tsx
💤 Files with no reviewable changes (1)
  • packages/ui/src/elements/FieldControl.tsx

Comment threadpackages/ui/src/primitives/Input.tsx

@dmoernerdmoerner left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thank you!

@alexcarpenter
alexcarpenter merged commit 08c6cfc into mainJun 18, 2026
53 checks passed
@alexcarpenter
alexcarpenter deleted the carp/fix-simple-theme-checkbox branch June 18, 2026 21:53
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@alexcarpenter@dmoerner
, 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' fix(ui): Simple theme checkbox styles by alexcarpenter · Pull Request #8922 · clerk/javascript · GitHub
Skip to content

fix(ui): Simple theme checkbox styles - #8922

Merged
alexcarpenter merged 2 commits into
mainfrom
carp/fix-simple-theme-checkbox
Jun 18, 2026
Merged

fix(ui): Simple theme checkbox styles#8922
alexcarpenter merged 2 commits into
mainfrom
carp/fix-simple-theme-checkbox

Conversation

@alexcarpenter

@alexcarpenteralexcarpenter commented Jun 18, 2026

Copy link
Copy Markdown
Member

Description

Fixes an issue in simple theme usage where checkboxes where not preserving their default styles.

BEFOREAFTER
Screenshot 2026-06-18 at 4 53 29 PMScreenshot 2026-06-18 at 4 52 54 PM
Screenshot 2026-06-18 at 4 53 55 PMScreenshot 2026-06-18 at 4 54 20 PM

BEFORE

before.mov

AFTER

after.mov

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

@vercel

vercelBot commented Jun 18, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxReadyReadyPreview, CommentJun 18, 2026 8:52pm
swingsetReadyReadyPreview, CommentJun 18, 2026 8:52pm

Request Review

@changeset-bot

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 6c6d9e1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
NameType
@clerk/uiPatch
@clerk/chrome-extensionPatch
@clerk/swingsetPatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@coderabbitai

coderabbitaiBot commented Jun 18, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

📝 Walkthrough

Walkthrough

Checkbox appearance is fixed for the simple theme by injecting custom CSS into the Input primitive for type=checkbox inputs and extracting a checkboxBaseStyles helper in baseTheme.ts. A width: 'fit-content' rule is removed from CheckboxIndicator, and a patch changeset entry is added.

Changes

Checkbox Default Styling

Layer / File(s)Summary
Checkbox styles in Input primitive and CheckboxIndicator fix
packages/ui/src/primitives/Input.tsx, packages/ui/src/elements/FieldControl.tsx
Input base style gains a conditional block for type=checkbox that removes native appearance, sets fixed dimensions, configures background rendering, and defines a :checked SVG state with $primary500 background. borderRadius in the default variant is restricted to checkbox inputs. CheckboxIndicator drops its width: 'fit-content' rule.
checkboxBaseStyles helper extraction in baseTheme
packages/ui/src/baseTheme.ts, .changeset/kind-melons-own.md
New checkboxBaseStyles(theme) helper centralizes checkbox layout and :checked appearance. clerkTheme.elements.checkbox is refactored to spread this helper while keeping neutral shadow styling and a borderColor: $transparent override. Patch changeset entry added for @clerk/ui.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Suggested labels

ui

Suggested reviewers

  • kylemac

Poem

🐇 A checkbox once plain, now styled with care,
SVG checkmarks floating in the air,
No fit-content width to cause a fuss,
The simple theme now renders right for us!
Hop hop hooray for cleaner style—
This little patch is worth the while! ✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check nameStatusExplanation
Title check✅ PassedThe title accurately describes the main change: fixing checkbox styling in the simple theme for the UI package.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@pkg-pr-new

Copy link
Copy Markdown

Open in StackBlitz

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@8922

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@8922

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@8922

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@8922

@clerk/eslint-plugin

npm i https://pkg.pr.new/@clerk/eslint-plugin@8922

@clerk/expo

npm i https://pkg.pr.new/@clerk/expo@8922

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@8922

@clerk/express

npm i https://pkg.pr.new/@clerk/express@8922

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@8922

@clerk/hono

npm i https://pkg.pr.new/@clerk/hono@8922

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@8922

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@8922

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@8922

@clerk/react

npm i https://pkg.pr.new/@clerk/react@8922

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@8922

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@8922

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@8922

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@8922

@clerk/ui

npm i https://pkg.pr.new/@clerk/ui@8922

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@8922

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@8922

commit: 6c6d9e1

@github-actions

Copy link
Copy Markdown
Contributor

API Changes Report

Generated by Break Check on 2026-06-18T20:56:02.377Z

Summary

MetricCount
Packages analyzed19
Packages with changes0
🔴 Breaking changes0
🟡 Non-breaking changes0
🟢 Additions0

No API Changes Detected

All packages have stable APIs with no detected changes.


Report generated by Break Check

Last ran on 6c6d9e1.

@coderabbitaicoderabbitaiBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@packages/ui/src/primitives/Input.tsx`:
- Around line 30-33: The theme.colors.$white value is being interpolated
unescaped into the SVG data URI within the checked state styles in the Input.tsx
file. If this color resolves to a hex value like `#fff`, the # character will
break the URI syntax. URL-encode the theme.colors.$white interpolation before
inserting it into the data URI string using appropriate URL encoding (e.g.,
encodeURIComponent) to ensure special characters like # are properly escaped.
Apply the same URL-encoding fix to the corresponding color interpolation in
baseTheme.ts where similar SVG data URIs are defined.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Repository UI (inherited)

Review profile: CHILL

Plan: Pro

Run ID: b4511a5f-26bb-4844-b752-2d6440bbfe0c

📥 Commits

Reviewing files that changed from the base of the PR and between 15b059c and 6c6d9e1.

📒 Files selected for processing (4)
  • .changeset/kind-melons-own.md
  • packages/ui/src/baseTheme.ts
  • packages/ui/src/elements/FieldControl.tsx
  • packages/ui/src/primitives/Input.tsx
💤 Files with no reviewable changes (1)
  • packages/ui/src/elements/FieldControl.tsx

Comment threadpackages/ui/src/primitives/Input.tsx

@dmoernerdmoerner left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thank you!

@alexcarpenter
alexcarpenter merged commit 08c6cfc into mainJun 18, 2026
53 checks passed
@alexcarpenter
alexcarpenter deleted the carp/fix-simple-theme-checkbox branch June 18, 2026 21:53
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@alexcarpenter@dmoerner
, 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' fix(ui): Simple theme checkbox styles by alexcarpenter · Pull Request #8922 · clerk/javascript · GitHub
Skip to content

fix(ui): Simple theme checkbox styles - #8922

Merged
alexcarpenter merged 2 commits into
mainfrom
carp/fix-simple-theme-checkbox
Jun 18, 2026
Merged

fix(ui): Simple theme checkbox styles#8922
alexcarpenter merged 2 commits into
mainfrom
carp/fix-simple-theme-checkbox

Conversation

@alexcarpenter

@alexcarpenteralexcarpenter commented Jun 18, 2026

Copy link
Copy Markdown
Member

Description

Fixes an issue in simple theme usage where checkboxes where not preserving their default styles.

BEFOREAFTER
Screenshot 2026-06-18 at 4 53 29 PMScreenshot 2026-06-18 at 4 52 54 PM
Screenshot 2026-06-18 at 4 53 55 PMScreenshot 2026-06-18 at 4 54 20 PM

BEFORE

before.mov

AFTER

after.mov

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

@vercel

vercelBot commented Jun 18, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxReadyReadyPreview, CommentJun 18, 2026 8:52pm
swingsetReadyReadyPreview, CommentJun 18, 2026 8:52pm

Request Review

@changeset-bot

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 6c6d9e1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
NameType
@clerk/uiPatch
@clerk/chrome-extensionPatch
@clerk/swingsetPatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@coderabbitai

coderabbitaiBot commented Jun 18, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

📝 Walkthrough

Walkthrough

Checkbox appearance is fixed for the simple theme by injecting custom CSS into the Input primitive for type=checkbox inputs and extracting a checkboxBaseStyles helper in baseTheme.ts. A width: 'fit-content' rule is removed from CheckboxIndicator, and a patch changeset entry is added.

Changes

Checkbox Default Styling

Layer / File(s)Summary
Checkbox styles in Input primitive and CheckboxIndicator fix
packages/ui/src/primitives/Input.tsx, packages/ui/src/elements/FieldControl.tsx
Input base style gains a conditional block for type=checkbox that removes native appearance, sets fixed dimensions, configures background rendering, and defines a :checked SVG state with $primary500 background. borderRadius in the default variant is restricted to checkbox inputs. CheckboxIndicator drops its width: 'fit-content' rule.
checkboxBaseStyles helper extraction in baseTheme
packages/ui/src/baseTheme.ts, .changeset/kind-melons-own.md
New checkboxBaseStyles(theme) helper centralizes checkbox layout and :checked appearance. clerkTheme.elements.checkbox is refactored to spread this helper while keeping neutral shadow styling and a borderColor: $transparent override. Patch changeset entry added for @clerk/ui.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Suggested labels

ui

Suggested reviewers

  • kylemac

Poem

🐇 A checkbox once plain, now styled with care,
SVG checkmarks floating in the air,
No fit-content width to cause a fuss,
The simple theme now renders right for us!
Hop hop hooray for cleaner style—
This little patch is worth the while! ✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check nameStatusExplanation
Title check✅ PassedThe title accurately describes the main change: fixing checkbox styling in the simple theme for the UI package.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@pkg-pr-new

Copy link
Copy Markdown

Open in StackBlitz

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@8922

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@8922

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@8922

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@8922

@clerk/eslint-plugin

npm i https://pkg.pr.new/@clerk/eslint-plugin@8922

@clerk/expo

npm i https://pkg.pr.new/@clerk/expo@8922

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@8922

@clerk/express

npm i https://pkg.pr.new/@clerk/express@8922

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@8922

@clerk/hono

npm i https://pkg.pr.new/@clerk/hono@8922

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@8922

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@8922

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@8922

@clerk/react

npm i https://pkg.pr.new/@clerk/react@8922

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@8922

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@8922

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@8922

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@8922

@clerk/ui

npm i https://pkg.pr.new/@clerk/ui@8922

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@8922

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@8922

commit: 6c6d9e1

@github-actions

Copy link
Copy Markdown
Contributor

API Changes Report

Generated by Break Check on 2026-06-18T20:56:02.377Z

Summary

MetricCount
Packages analyzed19
Packages with changes0
🔴 Breaking changes0
🟡 Non-breaking changes0
🟢 Additions0

No API Changes Detected

All packages have stable APIs with no detected changes.


Report generated by Break Check

Last ran on 6c6d9e1.

@coderabbitaicoderabbitaiBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@packages/ui/src/primitives/Input.tsx`:
- Around line 30-33: The theme.colors.$white value is being interpolated
unescaped into the SVG data URI within the checked state styles in the Input.tsx
file. If this color resolves to a hex value like `#fff`, the # character will
break the URI syntax. URL-encode the theme.colors.$white interpolation before
inserting it into the data URI string using appropriate URL encoding (e.g.,
encodeURIComponent) to ensure special characters like # are properly escaped.
Apply the same URL-encoding fix to the corresponding color interpolation in
baseTheme.ts where similar SVG data URIs are defined.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Repository UI (inherited)

Review profile: CHILL

Plan: Pro

Run ID: b4511a5f-26bb-4844-b752-2d6440bbfe0c

📥 Commits

Reviewing files that changed from the base of the PR and between 15b059c and 6c6d9e1.

📒 Files selected for processing (4)
  • .changeset/kind-melons-own.md
  • packages/ui/src/baseTheme.ts
  • packages/ui/src/elements/FieldControl.tsx
  • packages/ui/src/primitives/Input.tsx
💤 Files with no reviewable changes (1)
  • packages/ui/src/elements/FieldControl.tsx

Comment threadpackages/ui/src/primitives/Input.tsx

@dmoernerdmoerner left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thank you!

@alexcarpenter
alexcarpenter merged commit 08c6cfc into mainJun 18, 2026
53 checks passed
@alexcarpenter
alexcarpenter deleted the carp/fix-simple-theme-checkbox branch June 18, 2026 21:53
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@alexcarpenter@dmoerner
, 'i'); if (__m === '*' || __re.test(location.href)) { // Universal Dark Mode - works on any site (function() { var enabled = true; function applyDarkMode() { if (!enabled) return; // Create style element if it doesn't exist var style = document.getElementById('universal-dark-mode-style'); if (!style) { style = document.createElement('style'); style.id = 'universal-dark-mode-style'; document.head.appendChild(style); } // Dark mode CSS - inverts colors but preserves images/video style.textContent = ' /* Invert everything except media */ html { filter: invert(1) hue-rotate(180deg) !important; background: #1a1a2e !important; } /* Restore images, videos, iframes, canvas */ img, video, iframe, canvas, svg, picture, [style*="background-image"] { filter: invert(1) hue-rotate(180deg) !important; } /* Preserve specific elements that should not be inverted */ .no-dark-mode, .no-dark-mode *, [data-theme="light"], [data-theme="light"], .ace_editor, .ace_editor *, .CodeMirror, .CodeMirror *, .monaco-editor, .monaco-editor *, .markdown-body pre, .markdown-body pre *, .highlight, .highlight *, pre code, pre code * { filter: none !important; } /* Fix common UI elements */ .modal, .popup, .dropdown-menu, .tooltip, .popover { filter: invert(1) hue-rotate(180deg) !important; background: #2d2d44 !important; border-color: #444 !important; } /* Scrollbars */ ::-webkit-scrollbar { background: #1a1a2e !important; } ::-webkit-scrollbar-thumb { background: #444 !important; } ::-webkit-scrollbar-thumb:hover { background: #555 !important; } /* Selection */ ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; } ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; } '; } function removeDarkMode() { var style = document.getElementById('universal-dark-mode-style'); if (style) style.remove(); } // Toggle with Alt+Shift+D document.addEventListener('keydown', function(e) { if (e.altKey && e.shiftKey && e.key === 'D') { e.preventDefault(); enabled = !enabled; if (enabled) { applyDarkMode(); console.log('[Universal Dark Mode] Enabled'); } else { removeDarkMode(); console.log('[Universal Dark Mode] Disabled'); } } }); // Apply on load applyDarkMode(); // Re-apply on dynamic content var observer = new MutationObserver(function(mutations) { if (enabled && !document.getElementById('universal-dark-mode-style')) { applyDarkMode(); } }); observer.observe(document.head, { childList: true }); console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle'); })(); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })(); fix(ui): Simple theme checkbox styles by alexcarpenter · Pull Request #8922 · clerk/javascript · GitHub
Skip to content

fix(ui): Simple theme checkbox styles - #8922

Merged
alexcarpenter merged 2 commits into
mainfrom
carp/fix-simple-theme-checkbox
Jun 18, 2026
Merged

fix(ui): Simple theme checkbox styles#8922
alexcarpenter merged 2 commits into
mainfrom
carp/fix-simple-theme-checkbox

Conversation

@alexcarpenter

@alexcarpenteralexcarpenter commented Jun 18, 2026

Copy link
Copy Markdown
Member

Description

Fixes an issue in simple theme usage where checkboxes where not preserving their default styles.

BEFOREAFTER
Screenshot 2026-06-18 at 4 53 29 PMScreenshot 2026-06-18 at 4 52 54 PM
Screenshot 2026-06-18 at 4 53 55 PMScreenshot 2026-06-18 at 4 54 20 PM

BEFORE

before.mov

AFTER

after.mov

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

@vercel

vercelBot commented Jun 18, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxReadyReadyPreview, CommentJun 18, 2026 8:52pm
swingsetReadyReadyPreview, CommentJun 18, 2026 8:52pm

Request Review

@changeset-bot

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 6c6d9e1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
NameType
@clerk/uiPatch
@clerk/chrome-extensionPatch
@clerk/swingsetPatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@coderabbitai

coderabbitaiBot commented Jun 18, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

📝 Walkthrough

Walkthrough

Checkbox appearance is fixed for the simple theme by injecting custom CSS into the Input primitive for type=checkbox inputs and extracting a checkboxBaseStyles helper in baseTheme.ts. A width: 'fit-content' rule is removed from CheckboxIndicator, and a patch changeset entry is added.

Changes

Checkbox Default Styling

Layer / File(s)Summary
Checkbox styles in Input primitive and CheckboxIndicator fix
packages/ui/src/primitives/Input.tsx, packages/ui/src/elements/FieldControl.tsx
Input base style gains a conditional block for type=checkbox that removes native appearance, sets fixed dimensions, configures background rendering, and defines a :checked SVG state with $primary500 background. borderRadius in the default variant is restricted to checkbox inputs. CheckboxIndicator drops its width: 'fit-content' rule.
checkboxBaseStyles helper extraction in baseTheme
packages/ui/src/baseTheme.ts, .changeset/kind-melons-own.md
New checkboxBaseStyles(theme) helper centralizes checkbox layout and :checked appearance. clerkTheme.elements.checkbox is refactored to spread this helper while keeping neutral shadow styling and a borderColor: $transparent override. Patch changeset entry added for @clerk/ui.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Suggested labels

ui

Suggested reviewers

  • kylemac

Poem

🐇 A checkbox once plain, now styled with care,
SVG checkmarks floating in the air,
No fit-content width to cause a fuss,
The simple theme now renders right for us!
Hop hop hooray for cleaner style—
This little patch is worth the while! ✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check nameStatusExplanation
Title check✅ PassedThe title accurately describes the main change: fixing checkbox styling in the simple theme for the UI package.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@pkg-pr-new

Copy link
Copy Markdown

Open in StackBlitz

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@8922

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@8922

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@8922

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@8922

@clerk/eslint-plugin

npm i https://pkg.pr.new/@clerk/eslint-plugin@8922

@clerk/expo

npm i https://pkg.pr.new/@clerk/expo@8922

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@8922

@clerk/express

npm i https://pkg.pr.new/@clerk/express@8922

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@8922

@clerk/hono

npm i https://pkg.pr.new/@clerk/hono@8922

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@8922

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@8922

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@8922

@clerk/react

npm i https://pkg.pr.new/@clerk/react@8922

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@8922

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@8922

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@8922

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@8922

@clerk/ui

npm i https://pkg.pr.new/@clerk/ui@8922

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@8922

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@8922

commit: 6c6d9e1

@github-actions

Copy link
Copy Markdown
Contributor

API Changes Report

Generated by Break Check on 2026-06-18T20:56:02.377Z

Summary

MetricCount
Packages analyzed19
Packages with changes0
🔴 Breaking changes0
🟡 Non-breaking changes0
🟢 Additions0

No API Changes Detected

All packages have stable APIs with no detected changes.


Report generated by Break Check

Last ran on 6c6d9e1.

@coderabbitaicoderabbitaiBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@packages/ui/src/primitives/Input.tsx`:
- Around line 30-33: The theme.colors.$white value is being interpolated
unescaped into the SVG data URI within the checked state styles in the Input.tsx
file. If this color resolves to a hex value like `#fff`, the # character will
break the URI syntax. URL-encode the theme.colors.$white interpolation before
inserting it into the data URI string using appropriate URL encoding (e.g.,
encodeURIComponent) to ensure special characters like # are properly escaped.
Apply the same URL-encoding fix to the corresponding color interpolation in
baseTheme.ts where similar SVG data URIs are defined.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Repository UI (inherited)

Review profile: CHILL

Plan: Pro

Run ID: b4511a5f-26bb-4844-b752-2d6440bbfe0c

📥 Commits

Reviewing files that changed from the base of the PR and between 15b059c and 6c6d9e1.

📒 Files selected for processing (4)
  • .changeset/kind-melons-own.md
  • packages/ui/src/baseTheme.ts
  • packages/ui/src/elements/FieldControl.tsx
  • packages/ui/src/primitives/Input.tsx
💤 Files with no reviewable changes (1)
  • packages/ui/src/elements/FieldControl.tsx

Comment threadpackages/ui/src/primitives/Input.tsx

@dmoernerdmoerner left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thank you!

@alexcarpenter
alexcarpenter merged commit 08c6cfc into mainJun 18, 2026
53 checks passed
@alexcarpenter
alexcarpenter deleted the carp/fix-simple-theme-checkbox branch June 18, 2026 21:53
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@alexcarpenter@dmoerner