Skip to content

chore(electron): Fix cjs/esm exports - #8959

Merged
wobsoriano merged 11 commits into
mainfrom
rob/fix-cjs-esm-issue-electron
Jun 23, 2026
Merged

chore(electron): Fix cjs/esm exports#8959
wobsoriano merged 11 commits into
mainfrom
rob/fix-cjs-esm-issue-electron

Conversation

@wobsoriano

@wobsorianowobsoriano commented Jun 22, 2026•
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Member

Description

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

Summary by CodeRabbit

  • Bug Fixes
    • Fixed Electron SDK exports to properly support both ESM and CommonJS module systems with correct type declarations.

@changeset-bot

changeset-botBot commented Jun 22, 2026•
edited
Loading

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 4807231

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 0 packages

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel

vercelBot commented Jun 22, 2026•
edited
Loading

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxReadyReadyPreview, CommentJun 23, 2026 8:04pm
swingsetReadyReadyPreview, CommentJun 23, 2026 8:04pm

Request Review

@coderabbitai

coderabbitaiBot commented Jun 22, 2026•
edited
Loading

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Repository UI (inherited)

Review profile: CHILL

Plan: Pro

Run ID: b8aa1ea6-f27b-4152-a4cb-115413297ff1

📥 Commits

Reviewing files that changed from the base of the PR and between 7661e55 and 4807231.

📒 Files selected for processing (1)
  • .changeset/quiet-ducks-wonder.md
💤 Files with no reviewable changes (1)
  • .changeset/quiet-ducks-wonder.md
📝 Walkthrough

Walkthrough

The @clerk/electron package build is restructured to produce separate ESM (dist/esm) and CJS (dist/cjs) outputs via two distinct tsdown targets. A new tsconfig.declarations.json emits type declarations to dist/types. The package.json exports, main, module, and types fields are updated to reference these new output locations. A patch changeset is included.

Changes

Electron SDK ESM/CJS build restructure

Layer / File(s)Summary
ESM/CJS split and declaration-only tsconfig
packages/electron/tsconfig.declarations.json, packages/electron/tsdown.config.mts		Adds tsconfig.declarations.json to emit .d.ts files to dist/types. Refactors tsdown.config.mts to produce separate esm and cjs option objects with dts: false, wired via runAfterLast to run pnpm build:declarations then optionally pkglab pub --ping.
Package entrypoints and changeset
packages/electron/package.json, .changeset/quiet-ducks-wonder.md		Updates all exports subpaths to route import.default → dist/esm, require.default → dist/cjs, and types → dist/types/.../index.d.ts. Updates top-level main, module, types, and adds the build:declarations script. Adds a patch changeset for the export fix.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

  • clerk/javascript#8786: Initial @clerk/electron SDK scaffold that established the original package.json entrypoints and build config this PR is directly updating.

Suggested reviewers

  • dstaley

Poem

🐇 Hop hop, the bundles split in two,
ESM and CJS, each path is true!
dist/types holds the declarations neat,
runAfterLast makes the pipeline complete.
No more mixed-up exports to untangle —
The Electron SDK shines from every angle! ✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title accurately describes the main change: restructuring Electron package exports to properly separate CommonJS and ESM entrypoints with corresponding type definitions.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

Comment @coderabbitai help to get the list of available commands.

@pkg-pr-new

pkg-pr-newBot commented Jun 22, 2026•
edited
Loading

Copy link
Copy Markdown

Open in StackBlitz

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@8959

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@8959

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@8959

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@8959

@clerk/electron

npm i https://pkg.pr.new/@clerk/electron@8959

@clerk/electron-passkeys

npm i https://pkg.pr.new/@clerk/electron-passkeys@8959

@clerk/eslint-plugin

npm i https://pkg.pr.new/@clerk/eslint-plugin@8959

@clerk/expo

npm i https://pkg.pr.new/@clerk/expo@8959

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@8959

@clerk/express

npm i https://pkg.pr.new/@clerk/express@8959

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@8959

@clerk/hono

npm i https://pkg.pr.new/@clerk/hono@8959

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@8959

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@8959

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@8959

@clerk/react

npm i https://pkg.pr.new/@clerk/react@8959

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@8959

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@8959

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@8959

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@8959

@clerk/ui

npm i https://pkg.pr.new/@clerk/ui@8959

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@8959

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@8959

commit: 4807231

@wobsoriano

wobsoriano commented Jun 22, 2026

Copy link
Copy Markdown
MemberAuthor

!snapshot

coderabbitai[bot]
coderabbitaiBot reviewed Jun 22, 2026
View reviewed changes

@coderabbitaicoderabbitaiBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🧹 Nitpick comments (1)
packages/electron/tsdown.config.mts (1)

9-10: 🩺 Stability & Availability | 🔵 Trivial

Consider explicit type checking for the publish flag to prevent accidental publish runs if the env value is ever passed as a string.

!!overrideOptions.env?.publish relies on JavaScript truthiness, which can coerce non-empty strings (like "false") to true. While the current pattern uses --env.publish as a boolean, explicit type checking would be more robust if the configuration ever receives string values.

Suggested improvement
- const shouldPublish = !!overrideOptions.env?.publish;+ const publishEnv = overrideOptions.env?.publish;+ const shouldPublish =+ publishEnv === true ||+ (typeof publishEnv === 'string' && ['1', 'true', 'yes'].includes(publishEnv.toLowerCase()));
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@packages/electron/tsdown.config.mts` around lines 9 - 10, The shouldPublish
constant uses JavaScript truthiness coercion on overrideOptions.env?.publish,
which will incorrectly evaluate string values like "false" as true. Replace the
double negation operator truthiness check with explicit type checking that
compares overrideOptions.env?.publish to the string "true" or validates it as a
boolean true value, ensuring that string-based configuration values are handled
correctly and accidental publish runs are prevented.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@scripts/common.mjs`:
- Around line 20-23: The second find command for native packages in the
packages/electron-passkeys/npm directory is using .nothrow() to suppress all
errors without checking the exitCode or stderr, which can mask real discovery
failures and exclude packages from workflows. Remove the .nothrow() call from
the nativeResult assignment to match the error handling behavior of the first
find command, or if .nothrow() must be kept, add explicit checks for
nativeResult.exitCode and nativeResult.stderr to differentiate between missing
directories (acceptable) and actual errors (which should be thrown or logged).
---
Nitpick comments:
In `@packages/electron/tsdown.config.mts`:
- Around line 9-10: The shouldPublish constant uses JavaScript truthiness
coercion on overrideOptions.env?.publish, which will incorrectly evaluate string
values like "false" as true. Replace the double negation operator truthiness
check with explicit type checking that compares overrideOptions.env?.publish to
the string "true" or validates it as a boolean true value, ensuring that
string-based configuration values are handled correctly and accidental publish
runs are prevented.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Repository UI (inherited)

Review profile: CHILL

Plan: Pro

Run ID: 02e2d0a8-1ca2-4c70-bf47-4db67ea0e0a3

📥 Commits

Reviewing files that changed from the base of the PR and between 52d310c and 5b61a0a.

📒 Files selected for processing (9)
  • packages/electron-passkeys/.gitignore
  • packages/electron-passkeys/npm/darwin-arm64/electron-passkeys.darwin-arm64.node
  • packages/electron-passkeys/npm/darwin-x64/electron-passkeys.darwin-x64.node
  • packages/electron-passkeys/npm/win32-arm64-msvc/electron-passkeys.win32-arm64-msvc.node
  • packages/electron-passkeys/npm/win32-x64-msvc/electron-passkeys.win32-x64-msvc.node
  • packages/electron/package.json
  • packages/electron/tsconfig.declarations.json
  • packages/electron/tsdown.config.mts
  • scripts/common.mjs

Comment threadscripts/common.mjs Outdated
@wobsoriano

wobsoriano commented Jun 22, 2026

Copy link
Copy Markdown
MemberAuthor

!snapshot

@wobsoriano

wobsoriano commented Jun 22, 2026

Copy link
Copy Markdown
MemberAuthor

!snapshot

@github-actions

github-actionsBot commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

Hey @wobsoriano - the snapshot version command generated the following package versions:

PackageVersion
@clerk/astro3.4.7-snapshot.v20260622234151
@clerk/backend3.8.3-snapshot.v20260622234151
@clerk/chrome-extension3.1.42-snapshot.v20260622234151
@clerk/clerk-js6.21.0-snapshot.v20260622234151
@clerk/electron0.0.2-snapshot.v20260622234151
@clerk/electron-passkeys0.0.2-snapshot.v20260622234151
@clerk/eslint-plugin0.1.1-snapshot.v20260622234151
@clerk/expo3.5.3-snapshot.v20260622234151
@clerk/expo-passkeys1.1.9-snapshot.v20260622234151
@clerk/express2.1.31-snapshot.v20260622234151
@clerk/fastify3.1.41-snapshot.v20260622234151
@clerk/headless0.0.3-snapshot.v20260622234151
@clerk/hono0.1.41-snapshot.v20260622234151
@clerk/localizations4.9.3-snapshot.v20260622234151
@clerk/msw0.0.39-snapshot.v20260622234151
@clerk/nextjs7.5.8-snapshot.v20260622234151
@clerk/nuxt2.6.7-snapshot.v20260622234151
@clerk/react6.11.0-snapshot.v20260622234151
@clerk/react-router3.4.8-snapshot.v20260622234151
@clerk/shared4.21.0-snapshot.v20260622234151
@clerk/swingset0.0.8-snapshot.v20260622234151
@clerk/tanstack-react-start1.4.8-snapshot.v20260622234151
@clerk/testing2.1.6-snapshot.v20260622234151
@clerk/ui1.20.1-snapshot.v20260622234151
@clerk/upgrade2.0.5-snapshot.v20260622234151
@clerk/vue2.4.7-snapshot.v20260622234151

Tip: Use the snippet copy button below to quickly install the required packages.
@clerk/astro

npm i @clerk/astro@3.4.7-snapshot.v20260622234151 --save-exact

@clerk/backend

npm i @clerk/backend@3.8.3-snapshot.v20260622234151 --save-exact

@clerk/chrome-extension

npm i @clerk/chrome-extension@3.1.42-snapshot.v20260622234151 --save-exact

@clerk/clerk-js

npm i @clerk/clerk-js@6.21.0-snapshot.v20260622234151 --save-exact

@clerk/electron

npm i @clerk/electron@0.0.2-snapshot.v20260622234151 --save-exact

@clerk/electron-passkeys

npm i @clerk/electron-passkeys@0.0.2-snapshot.v20260622234151 --save-exact

@clerk/eslint-plugin

npm i @clerk/eslint-plugin@0.1.1-snapshot.v20260622234151 --save-exact

@clerk/expo

npm i @clerk/expo@3.5.3-snapshot.v20260622234151 --save-exact

@clerk/expo-passkeys

npm i @clerk/expo-passkeys@1.1.9-snapshot.v20260622234151 --save-exact

@clerk/express

npm i @clerk/express@2.1.31-snapshot.v20260622234151 --save-exact

@clerk/fastify

npm i @clerk/fastify@3.1.41-snapshot.v20260622234151 --save-exact

@clerk/headless

npm i @clerk/headless@0.0.3-snapshot.v20260622234151 --save-exact

@clerk/hono

npm i @clerk/hono@0.1.41-snapshot.v20260622234151 --save-exact

@clerk/localizations

npm i @clerk/localizations@4.9.3-snapshot.v20260622234151 --save-exact

@clerk/msw

npm i @clerk/msw@0.0.39-snapshot.v20260622234151 --save-exact

@clerk/nextjs

npm i @clerk/nextjs@7.5.8-snapshot.v20260622234151 --save-exact

@clerk/nuxt

npm i @clerk/nuxt@2.6.7-snapshot.v20260622234151 --save-exact

@clerk/react

npm i @clerk/react@6.11.0-snapshot.v20260622234151 --save-exact

@clerk/react-router

npm i @clerk/react-router@3.4.8-snapshot.v20260622234151 --save-exact

@clerk/shared

npm i @clerk/shared@4.21.0-snapshot.v20260622234151 --save-exact

@clerk/swingset

npm i @clerk/swingset@0.0.8-snapshot.v20260622234151 --save-exact

@clerk/tanstack-react-start

npm i @clerk/tanstack-react-start@1.4.8-snapshot.v20260622234151 --save-exact

@clerk/testing

npm i @clerk/testing@2.1.6-snapshot.v20260622234151 --save-exact

@clerk/ui

npm i @clerk/ui@1.20.1-snapshot.v20260622234151 --save-exact

@clerk/upgrade

npm i @clerk/upgrade@2.0.5-snapshot.v20260622234151 --save-exact

@clerk/vue

npm i @clerk/vue@2.4.7-snapshot.v20260622234151 --save-exact

@wobsoriano
wobsoriano marked this pull request as draft June 22, 2026 23:55
@wobsorianowobsoriano changed the title chore(electron): Fix exportschore(electron): Fix cjs/esm exportsJun 23, 2026
@wobsoriano
wobsoriano marked this pull request as ready for review June 23, 2026 20:02
jeremy-clerk
jeremy-clerk approved these changes Jun 23, 2026
View reviewed changes

@jeremy-clerkjeremy-clerk left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@wobsoriano
wobsoriano merged commit 11cb740 into mainJun 23, 2026
48 checks passed
@wobsoriano
wobsoriano deleted the rob/fix-cjs-esm-issue-electron branch June 23, 2026 20:08
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@coderabbitaicoderabbitai[bot]coderabbitai[bot] left review comments
@jeremy-clerkjeremy-clerkjeremy-clerk approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@wobsoriano@jeremy-clerk
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
chore(electron): Fix cjs/esm exports by wobsoriano · Pull Request #8959 · clerk/javascript · GitHub
Skip to content
chore(electron): Fix cjs/esm exports - #8959
Merged
wobsoriano merged 11 commits into
mainfrom 
rob/fix-cjs-esm-issue-electron
Jun 23, 2026
Merged
chore(electron): Fix cjs/esm exports#8959
wobsoriano merged 11 commits into
mainfrom 
rob/fix-cjs-esm-issue-electron
Conversation
@wobsoriano
@wobsorianowobsoriano
commented
Jun 22, 2026•

edited by coderabbitai
Bot
Loading

Copy link


Copy Markdown

Member
Description
Checklist
  • pnpm test runs as expected.
  • pnpm build runs as expected.
  •  (If applicable) JSDoc comments have been added or updated for any package exports
  •  (If applicable) Documentation has been updated
Type of change
  •  🐛 Bug fix
  •  🌟 New feature
  •  🔨 Breaking change
  •  📖 Refactoring / dependency upgrade / documentation
  •  other:
Summary by CodeRabbit
  • Bug Fixes
    • Fixed Electron SDK exports to properly support both ESM and CommonJS module systems with correct type declarations.
@changeset-bot
changeset-botBot
commented
Jun 22, 2026•

edited

Loading

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: 4807231
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 0 packages
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@vercel
vercelBot
commented
Jun 22, 2026•

edited

Loading

Copy link


Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.
ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxReadyReadyPreview, CommentJun 23, 2026 8:04pm
swingsetReadyReadyPreview, CommentJun 23, 2026 8:04pm
Request Review
@coderabbitai
coderabbitaiBot
commented
Jun 22, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Review Change Stack
No actionable comments were generated in the recent review. 🎉
ℹ️ Recent review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Repository UI (inherited)
Review profile: CHILL
Plan: Pro
Run ID: b8aa1ea6-f27b-4152-a4cb-115413297ff1
📥 Commits
Reviewing files that changed from the base of the PR and between 7661e55 and 4807231.
📒 Files selected for processing (1)
  • .changeset/quiet-ducks-wonder.md
💤 Files with no reviewable changes (1)
  • .changeset/quiet-ducks-wonder.md
📝 Walkthrough
Walkthrough
The @clerk/electron package build is restructured to produce separate ESM (dist/esm) and CJS (dist/cjs) outputs via two distinct tsdown targets. A new tsconfig.declarations.json emits type declarations to dist/types. The package.json exports, main, module, and types fields are updated to reference these new output locations. A patch changeset is included.
Changes
Electron SDK ESM/CJS build restructure
Layer / File(s)Summary
ESM/CJS split and declaration-only tsconfig
packages/electron/tsconfig.declarations.json, packages/electron/tsdown.config.mts		Adds tsconfig.declarations.json to emit .d.ts files to dist/types. Refactors tsdown.config.mts to produce separate esm and cjs option objects with dts: false, wired via runAfterLast to run pnpm build:declarations then optionally pkglab pub --ping.
Package entrypoints and changeset
packages/electron/package.json, .changeset/quiet-ducks-wonder.md		Updates all exports subpaths to route import.default → dist/esm, require.default → dist/cjs, and types → dist/types/.../index.d.ts. Updates top-level main, module, types, and adds the build:declarations script. Adds a patch changeset for the export fix.
Estimated code review effort
🎯 2 (Simple) | ⏱️ ~10 minutes
Possibly related PRs
  • clerk/javascript#8786: Initial @clerk/electron SDK scaffold that established the original package.json entrypoints and build config this PR is directly updating.
Suggested reviewers
  • dstaley
Poem
🐇 Hop hop, the bundles split in two,

ESM and CJS, each path is true!
dist/types holds the declarations neat,
runAfterLast makes the pipeline complete.

No more mixed-up exports to untangle —

The Electron SDK shines from every angle! ✨
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title accurately describes the main change: restructuring Electron package exports to properly separate CommonJS and ESM entrypoints with corresponding type definitions.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
✏️ Tip: You can configure your own custom pre-merge checks in the settings.
Comment @coderabbitai help to get the list of available commands.
@pkg-pr-new
pkg-pr-newBot
commented
Jun 22, 2026•

edited

Loading

Copy link


Copy Markdown

Open in StackBlitz
@clerk/astro
npm i https://pkg.pr.new/@clerk/astro@8959

@clerk/backend
npm i https://pkg.pr.new/@clerk/backend@8959

@clerk/chrome-extension
npm i https://pkg.pr.new/@clerk/chrome-extension@8959

@clerk/clerk-js
npm i https://pkg.pr.new/@clerk/clerk-js@8959

@clerk/electron
npm i https://pkg.pr.new/@clerk/electron@8959

@clerk/electron-passkeys
npm i https://pkg.pr.new/@clerk/electron-passkeys@8959

@clerk/eslint-plugin
npm i https://pkg.pr.new/@clerk/eslint-plugin@8959

@clerk/expo
npm i https://pkg.pr.new/@clerk/expo@8959

@clerk/expo-passkeys
npm i https://pkg.pr.new/@clerk/expo-passkeys@8959

@clerk/express
npm i https://pkg.pr.new/@clerk/express@8959

@clerk/fastify
npm i https://pkg.pr.new/@clerk/fastify@8959

@clerk/hono
npm i https://pkg.pr.new/@clerk/hono@8959

@clerk/localizations
npm i https://pkg.pr.new/@clerk/localizations@8959

@clerk/nextjs
npm i https://pkg.pr.new/@clerk/nextjs@8959

@clerk/nuxt
npm i https://pkg.pr.new/@clerk/nuxt@8959

@clerk/react
npm i https://pkg.pr.new/@clerk/react@8959

@clerk/react-router
npm i https://pkg.pr.new/@clerk/react-router@8959

@clerk/shared
npm i https://pkg.pr.new/@clerk/shared@8959

@clerk/tanstack-react-start
npm i https://pkg.pr.new/@clerk/tanstack-react-start@8959

@clerk/testing
npm i https://pkg.pr.new/@clerk/testing@8959

@clerk/ui
npm i https://pkg.pr.new/@clerk/ui@8959

@clerk/upgrade
npm i https://pkg.pr.new/@clerk/upgrade@8959

@clerk/vue
npm i https://pkg.pr.new/@clerk/vue@8959

commit: 4807231
@wobsoriano
wobsoriano
commented
Jun 22, 2026

Copy link


Copy Markdown

MemberAuthor
!snapshot
coderabbitai[bot]
coderabbitaiBot
reviewed
Jun 22, 2026
View reviewed changes
@coderabbitaicoderabbitaiBot
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1
🧹 Nitpick comments (1)
packages/electron/tsdown.config.mts (1)
9-10: 🩺 Stability & Availability | 🔵 Trivial
Consider explicit type checking for the publish flag to prevent accidental publish runs if the env value is ever passed as a string.
!!overrideOptions.env?.publish relies on JavaScript truthiness, which can coerce non-empty strings (like "false") to true. While the current pattern uses --env.publish as a boolean, explicit type checking would be more robust if the configuration ever receives string values.
Suggested improvement
- const shouldPublish = !!overrideOptions.env?.publish;+ const publishEnv = overrideOptions.env?.publish;+ const shouldPublish =+ publishEnv === true ||+ (typeof publishEnv === 'string' && ['1', 'true', 'yes'].includes(publishEnv.toLowerCase()));
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@packages/electron/tsdown.config.mts` around lines 9 - 10, The shouldPublish
constant uses JavaScript truthiness coercion on overrideOptions.env?.publish,
which will incorrectly evaluate string values like "false" as true. Replace the
double negation operator truthiness check with explicit type checking that
compares overrideOptions.env?.publish to the string "true" or validates it as a
boolean true value, ensuring that string-based configuration values are handled
correctly and accidental publish runs are prevented.

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@scripts/common.mjs`:
- Around line 20-23: The second find command for native packages in the
packages/electron-passkeys/npm directory is using .nothrow() to suppress all
errors without checking the exitCode or stderr, which can mask real discovery
failures and exclude packages from workflows. Remove the .nothrow() call from
the nativeResult assignment to match the error handling behavior of the first
find command, or if .nothrow() must be kept, add explicit checks for
nativeResult.exitCode and nativeResult.stderr to differentiate between missing
directories (acceptable) and actual errors (which should be thrown or logged).
---
Nitpick comments:
In `@packages/electron/tsdown.config.mts`:
- Around line 9-10: The shouldPublish constant uses JavaScript truthiness
coercion on overrideOptions.env?.publish, which will incorrectly evaluate string
values like "false" as true. Replace the double negation operator truthiness
check with explicit type checking that compares overrideOptions.env?.publish to
the string "true" or validates it as a boolean true value, ensuring that
string-based configuration values are handled correctly and accidental publish
runs are prevented.

🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
  •  Push a commit to this branch (recommended)
  •  Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Repository UI (inherited)
Review profile: CHILL
Plan: Pro
Run ID: 02e2d0a8-1ca2-4c70-bf47-4db67ea0e0a3
📥 Commits
Reviewing files that changed from the base of the PR and between 52d310c and 5b61a0a.
📒 Files selected for processing (9)
  • packages/electron-passkeys/.gitignore
  • packages/electron-passkeys/npm/darwin-arm64/electron-passkeys.darwin-arm64.node
  • packages/electron-passkeys/npm/darwin-x64/electron-passkeys.darwin-x64.node
  • packages/electron-passkeys/npm/win32-arm64-msvc/electron-passkeys.win32-arm64-msvc.node
  • packages/electron-passkeys/npm/win32-x64-msvc/electron-passkeys.win32-x64-msvc.node
  • packages/electron/package.json
  • packages/electron/tsconfig.declarations.json
  • packages/electron/tsdown.config.mts
  • scripts/common.mjs
Comment threadscripts/common.mjs
Outdated

@wobsoriano
wobsoriano
commented
Jun 22, 2026

Copy link


Copy Markdown

MemberAuthor
!snapshot
@wobsoriano
wobsoriano
commented
Jun 22, 2026

Copy link


Copy Markdown

MemberAuthor
!snapshot
@github-actions
github-actionsBot
commented
Jun 22, 2026

Copy link


Copy Markdown

Contributor
Hey @wobsoriano - the snapshot version command generated the following package versions:
PackageVersion
@clerk/astro3.4.7-snapshot.v20260622234151
@clerk/backend3.8.3-snapshot.v20260622234151
@clerk/chrome-extension3.1.42-snapshot.v20260622234151
@clerk/clerk-js6.21.0-snapshot.v20260622234151
@clerk/electron0.0.2-snapshot.v20260622234151
@clerk/electron-passkeys0.0.2-snapshot.v20260622234151
@clerk/eslint-plugin0.1.1-snapshot.v20260622234151
@clerk/expo3.5.3-snapshot.v20260622234151
@clerk/expo-passkeys1.1.9-snapshot.v20260622234151
@clerk/express2.1.31-snapshot.v20260622234151
@clerk/fastify3.1.41-snapshot.v20260622234151
@clerk/headless0.0.3-snapshot.v20260622234151
@clerk/hono0.1.41-snapshot.v20260622234151
@clerk/localizations4.9.3-snapshot.v20260622234151
@clerk/msw0.0.39-snapshot.v20260622234151
@clerk/nextjs7.5.8-snapshot.v20260622234151
@clerk/nuxt2.6.7-snapshot.v20260622234151
@clerk/react6.11.0-snapshot.v20260622234151
@clerk/react-router3.4.8-snapshot.v20260622234151
@clerk/shared4.21.0-snapshot.v20260622234151
@clerk/swingset0.0.8-snapshot.v20260622234151
@clerk/tanstack-react-start1.4.8-snapshot.v20260622234151
@clerk/testing2.1.6-snapshot.v20260622234151
@clerk/ui1.20.1-snapshot.v20260622234151
@clerk/upgrade2.0.5-snapshot.v20260622234151
@clerk/vue2.4.7-snapshot.v20260622234151
Tip: Use the snippet copy button below to quickly install the required packages.
@clerk/astro
npm i @clerk/astro@3.4.7-snapshot.v20260622234151 --save-exact
@clerk/backend
npm i @clerk/backend@3.8.3-snapshot.v20260622234151 --save-exact
@clerk/chrome-extension
npm i @clerk/chrome-extension@3.1.42-snapshot.v20260622234151 --save-exact
@clerk/clerk-js
npm i @clerk/clerk-js@6.21.0-snapshot.v20260622234151 --save-exact
@clerk/electron
npm i @clerk/electron@0.0.2-snapshot.v20260622234151 --save-exact
@clerk/electron-passkeys
npm i @clerk/electron-passkeys@0.0.2-snapshot.v20260622234151 --save-exact
@clerk/eslint-plugin
npm i @clerk/eslint-plugin@0.1.1-snapshot.v20260622234151 --save-exact
@clerk/expo
npm i @clerk/expo@3.5.3-snapshot.v20260622234151 --save-exact
@clerk/expo-passkeys
npm i @clerk/expo-passkeys@1.1.9-snapshot.v20260622234151 --save-exact
@clerk/express
npm i @clerk/express@2.1.31-snapshot.v20260622234151 --save-exact
@clerk/fastify
npm i @clerk/fastify@3.1.41-snapshot.v20260622234151 --save-exact
@clerk/headless
npm i @clerk/headless@0.0.3-snapshot.v20260622234151 --save-exact
@clerk/hono
npm i @clerk/hono@0.1.41-snapshot.v20260622234151 --save-exact
@clerk/localizations
npm i @clerk/localizations@4.9.3-snapshot.v20260622234151 --save-exact
@clerk/msw
npm i @clerk/msw@0.0.39-snapshot.v20260622234151 --save-exact
@clerk/nextjs
npm i @clerk/nextjs@7.5.8-snapshot.v20260622234151 --save-exact
@clerk/nuxt
npm i @clerk/nuxt@2.6.7-snapshot.v20260622234151 --save-exact
@clerk/react
npm i @clerk/react@6.11.0-snapshot.v20260622234151 --save-exact
@clerk/react-router
npm i @clerk/react-router@3.4.8-snapshot.v20260622234151 --save-exact
@clerk/shared
npm i @clerk/shared@4.21.0-snapshot.v20260622234151 --save-exact
@clerk/swingset
npm i @clerk/swingset@0.0.8-snapshot.v20260622234151 --save-exact
@clerk/tanstack-react-start
npm i @clerk/tanstack-react-start@1.4.8-snapshot.v20260622234151 --save-exact
@clerk/testing
npm i @clerk/testing@2.1.6-snapshot.v20260622234151 --save-exact
@clerk/ui
npm i @clerk/ui@1.20.1-snapshot.v20260622234151 --save-exact
@clerk/upgrade
npm i @clerk/upgrade@2.0.5-snapshot.v20260622234151 --save-exact
@clerk/vue
npm i @clerk/vue@2.4.7-snapshot.v20260622234151 --save-exact
@wobsoriano
wobsoriano
marked this pull request as draft
June 22, 2026 23:55
@wobsorianowobsoriano
changed the title
chore(electron): Fix exportschore(electron): Fix cjs/esm exportsJun 23, 2026
@wobsoriano
wobsoriano
marked this pull request as ready for review
June 23, 2026 20:02
jeremy-clerk
jeremy-clerk
approved these changes
Jun 23, 2026
View reviewed changes
@jeremy-clerkjeremy-clerk
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍
@wobsoriano
wobsoriano
merged commit 11cb740
into
mainJun 23, 2026

48 checks passed

@wobsoriano
wobsoriano
deleted the

rob/fix-cjs-esm-issue-electron

branch
June 23, 2026 20:08
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@coderabbitaicoderabbitai[bot]coderabbitai[bot] left review comments
@jeremy-clerkjeremy-clerkjeremy-clerk approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@wobsoriano@jeremy-clerk

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
chore(electron): Fix cjs/esm exports by wobsoriano · Pull Request #8959 · clerk/javascript · GitHub
Skip to content
chore(electron): Fix cjs/esm exports - #8959
Merged
wobsoriano merged 11 commits into
mainfrom 
rob/fix-cjs-esm-issue-electron
Jun 23, 2026
Merged
chore(electron): Fix cjs/esm exports#8959
wobsoriano merged 11 commits into
mainfrom 
rob/fix-cjs-esm-issue-electron
Conversation
@wobsoriano
@wobsorianowobsoriano
commented
Jun 22, 2026•

edited by coderabbitai
Bot
Loading

Copy link


Copy Markdown

Member
Description
Checklist
  • pnpm test runs as expected.
  • pnpm build runs as expected.
  •  (If applicable) JSDoc comments have been added or updated for any package exports
  •  (If applicable) Documentation has been updated
Type of change
  •  🐛 Bug fix
  •  🌟 New feature
  •  🔨 Breaking change
  •  📖 Refactoring / dependency upgrade / documentation
  •  other:
Summary by CodeRabbit
  • Bug Fixes
    • Fixed Electron SDK exports to properly support both ESM and CommonJS module systems with correct type declarations.
@changeset-bot
changeset-botBot
commented
Jun 22, 2026•

edited

Loading

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: 4807231
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 0 packages
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@vercel
vercelBot
commented
Jun 22, 2026•

edited

Loading

Copy link


Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.
ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxReadyReadyPreview, CommentJun 23, 2026 8:04pm
swingsetReadyReadyPreview, CommentJun 23, 2026 8:04pm
Request Review
@coderabbitai
coderabbitaiBot
commented
Jun 22, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Review Change Stack
No actionable comments were generated in the recent review. 🎉
ℹ️ Recent review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Repository UI (inherited)
Review profile: CHILL
Plan: Pro
Run ID: b8aa1ea6-f27b-4152-a4cb-115413297ff1
📥 Commits
Reviewing files that changed from the base of the PR and between 7661e55 and 4807231.
📒 Files selected for processing (1)
  • .changeset/quiet-ducks-wonder.md
💤 Files with no reviewable changes (1)
  • .changeset/quiet-ducks-wonder.md
📝 Walkthrough
Walkthrough
The @clerk/electron package build is restructured to produce separate ESM (dist/esm) and CJS (dist/cjs) outputs via two distinct tsdown targets. A new tsconfig.declarations.json emits type declarations to dist/types. The package.json exports, main, module, and types fields are updated to reference these new output locations. A patch changeset is included.
Changes
Electron SDK ESM/CJS build restructure
Layer / File(s)Summary
ESM/CJS split and declaration-only tsconfig
packages/electron/tsconfig.declarations.json, packages/electron/tsdown.config.mts		Adds tsconfig.declarations.json to emit .d.ts files to dist/types. Refactors tsdown.config.mts to produce separate esm and cjs option objects with dts: false, wired via runAfterLast to run pnpm build:declarations then optionally pkglab pub --ping.
Package entrypoints and changeset
packages/electron/package.json, .changeset/quiet-ducks-wonder.md		Updates all exports subpaths to route import.default → dist/esm, require.default → dist/cjs, and types → dist/types/.../index.d.ts. Updates top-level main, module, types, and adds the build:declarations script. Adds a patch changeset for the export fix.
Estimated code review effort
🎯 2 (Simple) | ⏱️ ~10 minutes
Possibly related PRs
  • clerk/javascript#8786: Initial @clerk/electron SDK scaffold that established the original package.json entrypoints and build config this PR is directly updating.
Suggested reviewers
  • dstaley
Poem
🐇 Hop hop, the bundles split in two,

ESM and CJS, each path is true!
dist/types holds the declarations neat,
runAfterLast makes the pipeline complete.

No more mixed-up exports to untangle —

The Electron SDK shines from every angle! ✨
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title accurately describes the main change: restructuring Electron package exports to properly separate CommonJS and ESM entrypoints with corresponding type definitions.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
✏️ Tip: You can configure your own custom pre-merge checks in the settings.
Comment @coderabbitai help to get the list of available commands.
@pkg-pr-new
pkg-pr-newBot
commented
Jun 22, 2026•

edited

Loading

Copy link


Copy Markdown

Open in StackBlitz
@clerk/astro
npm i https://pkg.pr.new/@clerk/astro@8959

@clerk/backend
npm i https://pkg.pr.new/@clerk/backend@8959

@clerk/chrome-extension
npm i https://pkg.pr.new/@clerk/chrome-extension@8959

@clerk/clerk-js
npm i https://pkg.pr.new/@clerk/clerk-js@8959

@clerk/electron
npm i https://pkg.pr.new/@clerk/electron@8959

@clerk/electron-passkeys
npm i https://pkg.pr.new/@clerk/electron-passkeys@8959

@clerk/eslint-plugin
npm i https://pkg.pr.new/@clerk/eslint-plugin@8959

@clerk/expo
npm i https://pkg.pr.new/@clerk/expo@8959

@clerk/expo-passkeys
npm i https://pkg.pr.new/@clerk/expo-passkeys@8959

@clerk/express
npm i https://pkg.pr.new/@clerk/express@8959

@clerk/fastify
npm i https://pkg.pr.new/@clerk/fastify@8959

@clerk/hono
npm i https://pkg.pr.new/@clerk/hono@8959

@clerk/localizations
npm i https://pkg.pr.new/@clerk/localizations@8959

@clerk/nextjs
npm i https://pkg.pr.new/@clerk/nextjs@8959

@clerk/nuxt
npm i https://pkg.pr.new/@clerk/nuxt@8959

@clerk/react
npm i https://pkg.pr.new/@clerk/react@8959

@clerk/react-router
npm i https://pkg.pr.new/@clerk/react-router@8959

@clerk/shared
npm i https://pkg.pr.new/@clerk/shared@8959

@clerk/tanstack-react-start
npm i https://pkg.pr.new/@clerk/tanstack-react-start@8959

@clerk/testing
npm i https://pkg.pr.new/@clerk/testing@8959

@clerk/ui
npm i https://pkg.pr.new/@clerk/ui@8959

@clerk/upgrade
npm i https://pkg.pr.new/@clerk/upgrade@8959

@clerk/vue
npm i https://pkg.pr.new/@clerk/vue@8959

commit: 4807231
@wobsoriano
wobsoriano
commented
Jun 22, 2026

Copy link


Copy Markdown

MemberAuthor
!snapshot
coderabbitai[bot]
coderabbitaiBot
reviewed
Jun 22, 2026
View reviewed changes
@coderabbitaicoderabbitaiBot
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1
🧹 Nitpick comments (1)
packages/electron/tsdown.config.mts (1)
9-10: 🩺 Stability & Availability | 🔵 Trivial
Consider explicit type checking for the publish flag to prevent accidental publish runs if the env value is ever passed as a string.
!!overrideOptions.env?.publish relies on JavaScript truthiness, which can coerce non-empty strings (like "false") to true. While the current pattern uses --env.publish as a boolean, explicit type checking would be more robust if the configuration ever receives string values.
Suggested improvement
- const shouldPublish = !!overrideOptions.env?.publish;+ const publishEnv = overrideOptions.env?.publish;+ const shouldPublish =+ publishEnv === true ||+ (typeof publishEnv === 'string' && ['1', 'true', 'yes'].includes(publishEnv.toLowerCase()));
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@packages/electron/tsdown.config.mts` around lines 9 - 10, The shouldPublish
constant uses JavaScript truthiness coercion on overrideOptions.env?.publish,
which will incorrectly evaluate string values like "false" as true. Replace the
double negation operator truthiness check with explicit type checking that
compares overrideOptions.env?.publish to the string "true" or validates it as a
boolean true value, ensuring that string-based configuration values are handled
correctly and accidental publish runs are prevented.

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@scripts/common.mjs`:
- Around line 20-23: The second find command for native packages in the
packages/electron-passkeys/npm directory is using .nothrow() to suppress all
errors without checking the exitCode or stderr, which can mask real discovery
failures and exclude packages from workflows. Remove the .nothrow() call from
the nativeResult assignment to match the error handling behavior of the first
find command, or if .nothrow() must be kept, add explicit checks for
nativeResult.exitCode and nativeResult.stderr to differentiate between missing
directories (acceptable) and actual errors (which should be thrown or logged).
---
Nitpick comments:
In `@packages/electron/tsdown.config.mts`:
- Around line 9-10: The shouldPublish constant uses JavaScript truthiness
coercion on overrideOptions.env?.publish, which will incorrectly evaluate string
values like "false" as true. Replace the double negation operator truthiness
check with explicit type checking that compares overrideOptions.env?.publish to
the string "true" or validates it as a boolean true value, ensuring that
string-based configuration values are handled correctly and accidental publish
runs are prevented.

🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
  •  Push a commit to this branch (recommended)
  •  Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Repository UI (inherited)
Review profile: CHILL
Plan: Pro
Run ID: 02e2d0a8-1ca2-4c70-bf47-4db67ea0e0a3
📥 Commits
Reviewing files that changed from the base of the PR and between 52d310c and 5b61a0a.
📒 Files selected for processing (9)
  • packages/electron-passkeys/.gitignore
  • packages/electron-passkeys/npm/darwin-arm64/electron-passkeys.darwin-arm64.node
  • packages/electron-passkeys/npm/darwin-x64/electron-passkeys.darwin-x64.node
  • packages/electron-passkeys/npm/win32-arm64-msvc/electron-passkeys.win32-arm64-msvc.node
  • packages/electron-passkeys/npm/win32-x64-msvc/electron-passkeys.win32-x64-msvc.node
  • packages/electron/package.json
  • packages/electron/tsconfig.declarations.json
  • packages/electron/tsdown.config.mts
  • scripts/common.mjs
Comment threadscripts/common.mjs
Outdated

@wobsoriano
wobsoriano
commented
Jun 22, 2026

Copy link


Copy Markdown

MemberAuthor
!snapshot
@wobsoriano
wobsoriano
commented
Jun 22, 2026

Copy link


Copy Markdown

MemberAuthor
!snapshot
@github-actions
github-actionsBot
commented
Jun 22, 2026

Copy link


Copy Markdown

Contributor
Hey @wobsoriano - the snapshot version command generated the following package versions:
PackageVersion
@clerk/astro3.4.7-snapshot.v20260622234151
@clerk/backend3.8.3-snapshot.v20260622234151
@clerk/chrome-extension3.1.42-snapshot.v20260622234151
@clerk/clerk-js6.21.0-snapshot.v20260622234151
@clerk/electron0.0.2-snapshot.v20260622234151
@clerk/electron-passkeys0.0.2-snapshot.v20260622234151
@clerk/eslint-plugin0.1.1-snapshot.v20260622234151
@clerk/expo3.5.3-snapshot.v20260622234151
@clerk/expo-passkeys1.1.9-snapshot.v20260622234151
@clerk/express2.1.31-snapshot.v20260622234151
@clerk/fastify3.1.41-snapshot.v20260622234151
@clerk/headless0.0.3-snapshot.v20260622234151
@clerk/hono0.1.41-snapshot.v20260622234151
@clerk/localizations4.9.3-snapshot.v20260622234151
@clerk/msw0.0.39-snapshot.v20260622234151
@clerk/nextjs7.5.8-snapshot.v20260622234151
@clerk/nuxt2.6.7-snapshot.v20260622234151
@clerk/react6.11.0-snapshot.v20260622234151
@clerk/react-router3.4.8-snapshot.v20260622234151
@clerk/shared4.21.0-snapshot.v20260622234151
@clerk/swingset0.0.8-snapshot.v20260622234151
@clerk/tanstack-react-start1.4.8-snapshot.v20260622234151
@clerk/testing2.1.6-snapshot.v20260622234151
@clerk/ui1.20.1-snapshot.v20260622234151
@clerk/upgrade2.0.5-snapshot.v20260622234151
@clerk/vue2.4.7-snapshot.v20260622234151
Tip: Use the snippet copy button below to quickly install the required packages.
@clerk/astro
npm i @clerk/astro@3.4.7-snapshot.v20260622234151 --save-exact
@clerk/backend
npm i @clerk/backend@3.8.3-snapshot.v20260622234151 --save-exact
@clerk/chrome-extension
npm i @clerk/chrome-extension@3.1.42-snapshot.v20260622234151 --save-exact
@clerk/clerk-js
npm i @clerk/clerk-js@6.21.0-snapshot.v20260622234151 --save-exact
@clerk/electron
npm i @clerk/electron@0.0.2-snapshot.v20260622234151 --save-exact
@clerk/electron-passkeys
npm i @clerk/electron-passkeys@0.0.2-snapshot.v20260622234151 --save-exact
@clerk/eslint-plugin
npm i @clerk/eslint-plugin@0.1.1-snapshot.v20260622234151 --save-exact
@clerk/expo
npm i @clerk/expo@3.5.3-snapshot.v20260622234151 --save-exact
@clerk/expo-passkeys
npm i @clerk/expo-passkeys@1.1.9-snapshot.v20260622234151 --save-exact
@clerk/express
npm i @clerk/express@2.1.31-snapshot.v20260622234151 --save-exact
@clerk/fastify
npm i @clerk/fastify@3.1.41-snapshot.v20260622234151 --save-exact
@clerk/headless
npm i @clerk/headless@0.0.3-snapshot.v20260622234151 --save-exact
@clerk/hono
npm i @clerk/hono@0.1.41-snapshot.v20260622234151 --save-exact
@clerk/localizations
npm i @clerk/localizations@4.9.3-snapshot.v20260622234151 --save-exact
@clerk/msw
npm i @clerk/msw@0.0.39-snapshot.v20260622234151 --save-exact
@clerk/nextjs
npm i @clerk/nextjs@7.5.8-snapshot.v20260622234151 --save-exact
@clerk/nuxt
npm i @clerk/nuxt@2.6.7-snapshot.v20260622234151 --save-exact
@clerk/react
npm i @clerk/react@6.11.0-snapshot.v20260622234151 --save-exact
@clerk/react-router
npm i @clerk/react-router@3.4.8-snapshot.v20260622234151 --save-exact
@clerk/shared
npm i @clerk/shared@4.21.0-snapshot.v20260622234151 --save-exact
@clerk/swingset
npm i @clerk/swingset@0.0.8-snapshot.v20260622234151 --save-exact
@clerk/tanstack-react-start
npm i @clerk/tanstack-react-start@1.4.8-snapshot.v20260622234151 --save-exact
@clerk/testing
npm i @clerk/testing@2.1.6-snapshot.v20260622234151 --save-exact
@clerk/ui
npm i @clerk/ui@1.20.1-snapshot.v20260622234151 --save-exact
@clerk/upgrade
npm i @clerk/upgrade@2.0.5-snapshot.v20260622234151 --save-exact
@clerk/vue
npm i @clerk/vue@2.4.7-snapshot.v20260622234151 --save-exact
@wobsoriano
wobsoriano
marked this pull request as draft
June 22, 2026 23:55
@wobsorianowobsoriano
changed the title
chore(electron): Fix exportschore(electron): Fix cjs/esm exportsJun 23, 2026
@wobsoriano
wobsoriano
marked this pull request as ready for review
June 23, 2026 20:02
jeremy-clerk
jeremy-clerk
approved these changes
Jun 23, 2026
View reviewed changes
@jeremy-clerkjeremy-clerk
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍
@wobsoriano
wobsoriano
merged commit 11cb740
into
mainJun 23, 2026

48 checks passed

@wobsoriano
wobsoriano
deleted the

rob/fix-cjs-esm-issue-electron

branch
June 23, 2026 20:08
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@coderabbitaicoderabbitai[bot]coderabbitai[bot] left review comments
@jeremy-clerkjeremy-clerkjeremy-clerk approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@wobsoriano@jeremy-clerk

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
chore(electron): Fix cjs/esm exports by wobsoriano · Pull Request #8959 · clerk/javascript · GitHub
Skip to content
chore(electron): Fix cjs/esm exports - #8959
Merged
wobsoriano merged 11 commits into
mainfrom 
rob/fix-cjs-esm-issue-electron
Jun 23, 2026
Merged
chore(electron): Fix cjs/esm exports#8959
wobsoriano merged 11 commits into
mainfrom 
rob/fix-cjs-esm-issue-electron
Conversation
@wobsoriano
@wobsorianowobsoriano
commented
Jun 22, 2026•

edited by coderabbitai
Bot
Loading

Copy link


Copy Markdown

Member
Description
Checklist
  • pnpm test runs as expected.
  • pnpm build runs as expected.
  •  (If applicable) JSDoc comments have been added or updated for any package exports
  •  (If applicable) Documentation has been updated
Type of change
  •  🐛 Bug fix
  •  🌟 New feature
  •  🔨 Breaking change
  •  📖 Refactoring / dependency upgrade / documentation
  •  other:
Summary by CodeRabbit
  • Bug Fixes
    • Fixed Electron SDK exports to properly support both ESM and CommonJS module systems with correct type declarations.
@changeset-bot
changeset-botBot
commented
Jun 22, 2026•

edited

Loading

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: 4807231
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 0 packages
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@vercel
vercelBot
commented
Jun 22, 2026•

edited

Loading

Copy link


Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.
ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxReadyReadyPreview, CommentJun 23, 2026 8:04pm
swingsetReadyReadyPreview, CommentJun 23, 2026 8:04pm
Request Review
@coderabbitai
coderabbitaiBot
commented
Jun 22, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Review Change Stack
No actionable comments were generated in the recent review. 🎉
ℹ️ Recent review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Repository UI (inherited)
Review profile: CHILL
Plan: Pro
Run ID: b8aa1ea6-f27b-4152-a4cb-115413297ff1
📥 Commits
Reviewing files that changed from the base of the PR and between 7661e55 and 4807231.
📒 Files selected for processing (1)
  • .changeset/quiet-ducks-wonder.md
💤 Files with no reviewable changes (1)
  • .changeset/quiet-ducks-wonder.md
📝 Walkthrough
Walkthrough
The @clerk/electron package build is restructured to produce separate ESM (dist/esm) and CJS (dist/cjs) outputs via two distinct tsdown targets. A new tsconfig.declarations.json emits type declarations to dist/types. The package.json exports, main, module, and types fields are updated to reference these new output locations. A patch changeset is included.
Changes
Electron SDK ESM/CJS build restructure
Layer / File(s)Summary
ESM/CJS split and declaration-only tsconfig
packages/electron/tsconfig.declarations.json, packages/electron/tsdown.config.mts		Adds tsconfig.declarations.json to emit .d.ts files to dist/types. Refactors tsdown.config.mts to produce separate esm and cjs option objects with dts: false, wired via runAfterLast to run pnpm build:declarations then optionally pkglab pub --ping.
Package entrypoints and changeset
packages/electron/package.json, .changeset/quiet-ducks-wonder.md		Updates all exports subpaths to route import.default → dist/esm, require.default → dist/cjs, and types → dist/types/.../index.d.ts. Updates top-level main, module, types, and adds the build:declarations script. Adds a patch changeset for the export fix.
Estimated code review effort
🎯 2 (Simple) | ⏱️ ~10 minutes
Possibly related PRs
  • clerk/javascript#8786: Initial @clerk/electron SDK scaffold that established the original package.json entrypoints and build config this PR is directly updating.
Suggested reviewers
  • dstaley
Poem
🐇 Hop hop, the bundles split in two,

ESM and CJS, each path is true!
dist/types holds the declarations neat,
runAfterLast makes the pipeline complete.

No more mixed-up exports to untangle —

The Electron SDK shines from every angle! ✨
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title accurately describes the main change: restructuring Electron package exports to properly separate CommonJS and ESM entrypoints with corresponding type definitions.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
✏️ Tip: You can configure your own custom pre-merge checks in the settings.
Comment @coderabbitai help to get the list of available commands.
@pkg-pr-new
pkg-pr-newBot
commented
Jun 22, 2026•

edited

Loading

Copy link


Copy Markdown

Open in StackBlitz
@clerk/astro
npm i https://pkg.pr.new/@clerk/astro@8959

@clerk/backend
npm i https://pkg.pr.new/@clerk/backend@8959

@clerk/chrome-extension
npm i https://pkg.pr.new/@clerk/chrome-extension@8959

@clerk/clerk-js
npm i https://pkg.pr.new/@clerk/clerk-js@8959

@clerk/electron
npm i https://pkg.pr.new/@clerk/electron@8959

@clerk/electron-passkeys
npm i https://pkg.pr.new/@clerk/electron-passkeys@8959

@clerk/eslint-plugin
npm i https://pkg.pr.new/@clerk/eslint-plugin@8959

@clerk/expo
npm i https://pkg.pr.new/@clerk/expo@8959

@clerk/expo-passkeys
npm i https://pkg.pr.new/@clerk/expo-passkeys@8959

@clerk/express
npm i https://pkg.pr.new/@clerk/express@8959

@clerk/fastify
npm i https://pkg.pr.new/@clerk/fastify@8959

@clerk/hono
npm i https://pkg.pr.new/@clerk/hono@8959

@clerk/localizations
npm i https://pkg.pr.new/@clerk/localizations@8959

@clerk/nextjs
npm i https://pkg.pr.new/@clerk/nextjs@8959

@clerk/nuxt
npm i https://pkg.pr.new/@clerk/nuxt@8959

@clerk/react
npm i https://pkg.pr.new/@clerk/react@8959

@clerk/react-router
npm i https://pkg.pr.new/@clerk/react-router@8959

@clerk/shared
npm i https://pkg.pr.new/@clerk/shared@8959

@clerk/tanstack-react-start
npm i https://pkg.pr.new/@clerk/tanstack-react-start@8959

@clerk/testing
npm i https://pkg.pr.new/@clerk/testing@8959

@clerk/ui
npm i https://pkg.pr.new/@clerk/ui@8959

@clerk/upgrade
npm i https://pkg.pr.new/@clerk/upgrade@8959

@clerk/vue
npm i https://pkg.pr.new/@clerk/vue@8959

commit: 4807231
@wobsoriano
wobsoriano
commented
Jun 22, 2026

Copy link


Copy Markdown

MemberAuthor
!snapshot
coderabbitai[bot]
coderabbitaiBot
reviewed
Jun 22, 2026
View reviewed changes
@coderabbitaicoderabbitaiBot
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1
🧹 Nitpick comments (1)
packages/electron/tsdown.config.mts (1)
9-10: 🩺 Stability & Availability | 🔵 Trivial
Consider explicit type checking for the publish flag to prevent accidental publish runs if the env value is ever passed as a string.
!!overrideOptions.env?.publish relies on JavaScript truthiness, which can coerce non-empty strings (like "false") to true. While the current pattern uses --env.publish as a boolean, explicit type checking would be more robust if the configuration ever receives string values.
Suggested improvement
- const shouldPublish = !!overrideOptions.env?.publish;+ const publishEnv = overrideOptions.env?.publish;+ const shouldPublish =+ publishEnv === true ||+ (typeof publishEnv === 'string' && ['1', 'true', 'yes'].includes(publishEnv.toLowerCase()));
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@packages/electron/tsdown.config.mts` around lines 9 - 10, The shouldPublish
constant uses JavaScript truthiness coercion on overrideOptions.env?.publish,
which will incorrectly evaluate string values like "false" as true. Replace the
double negation operator truthiness check with explicit type checking that
compares overrideOptions.env?.publish to the string "true" or validates it as a
boolean true value, ensuring that string-based configuration values are handled
correctly and accidental publish runs are prevented.

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@scripts/common.mjs`:
- Around line 20-23: The second find command for native packages in the
packages/electron-passkeys/npm directory is using .nothrow() to suppress all
errors without checking the exitCode or stderr, which can mask real discovery
failures and exclude packages from workflows. Remove the .nothrow() call from
the nativeResult assignment to match the error handling behavior of the first
find command, or if .nothrow() must be kept, add explicit checks for
nativeResult.exitCode and nativeResult.stderr to differentiate between missing
directories (acceptable) and actual errors (which should be thrown or logged).
---
Nitpick comments:
In `@packages/electron/tsdown.config.mts`:
- Around line 9-10: The shouldPublish constant uses JavaScript truthiness
coercion on overrideOptions.env?.publish, which will incorrectly evaluate string
values like "false" as true. Replace the double negation operator truthiness
check with explicit type checking that compares overrideOptions.env?.publish to
the string "true" or validates it as a boolean true value, ensuring that
string-based configuration values are handled correctly and accidental publish
runs are prevented.

🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
  •  Push a commit to this branch (recommended)
  •  Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Repository UI (inherited)
Review profile: CHILL
Plan: Pro
Run ID: 02e2d0a8-1ca2-4c70-bf47-4db67ea0e0a3
📥 Commits
Reviewing files that changed from the base of the PR and between 52d310c and 5b61a0a.
📒 Files selected for processing (9)
  • packages/electron-passkeys/.gitignore
  • packages/electron-passkeys/npm/darwin-arm64/electron-passkeys.darwin-arm64.node
  • packages/electron-passkeys/npm/darwin-x64/electron-passkeys.darwin-x64.node
  • packages/electron-passkeys/npm/win32-arm64-msvc/electron-passkeys.win32-arm64-msvc.node
  • packages/electron-passkeys/npm/win32-x64-msvc/electron-passkeys.win32-x64-msvc.node
  • packages/electron/package.json
  • packages/electron/tsconfig.declarations.json
  • packages/electron/tsdown.config.mts
  • scripts/common.mjs
Comment threadscripts/common.mjs
Outdated

@wobsoriano
wobsoriano
commented
Jun 22, 2026

Copy link


Copy Markdown

MemberAuthor
!snapshot
@wobsoriano
wobsoriano
commented
Jun 22, 2026

Copy link


Copy Markdown

MemberAuthor
!snapshot
@github-actions
github-actionsBot
commented
Jun 22, 2026

Copy link


Copy Markdown

Contributor
Hey @wobsoriano - the snapshot version command generated the following package versions:
PackageVersion
@clerk/astro3.4.7-snapshot.v20260622234151
@clerk/backend3.8.3-snapshot.v20260622234151
@clerk/chrome-extension3.1.42-snapshot.v20260622234151
@clerk/clerk-js6.21.0-snapshot.v20260622234151
@clerk/electron0.0.2-snapshot.v20260622234151
@clerk/electron-passkeys0.0.2-snapshot.v20260622234151
@clerk/eslint-plugin0.1.1-snapshot.v20260622234151
@clerk/expo3.5.3-snapshot.v20260622234151
@clerk/expo-passkeys1.1.9-snapshot.v20260622234151
@clerk/express2.1.31-snapshot.v20260622234151
@clerk/fastify3.1.41-snapshot.v20260622234151
@clerk/headless0.0.3-snapshot.v20260622234151
@clerk/hono0.1.41-snapshot.v20260622234151
@clerk/localizations4.9.3-snapshot.v20260622234151
@clerk/msw0.0.39-snapshot.v20260622234151
@clerk/nextjs7.5.8-snapshot.v20260622234151
@clerk/nuxt2.6.7-snapshot.v20260622234151
@clerk/react6.11.0-snapshot.v20260622234151
@clerk/react-router3.4.8-snapshot.v20260622234151
@clerk/shared4.21.0-snapshot.v20260622234151
@clerk/swingset0.0.8-snapshot.v20260622234151
@clerk/tanstack-react-start1.4.8-snapshot.v20260622234151
@clerk/testing2.1.6-snapshot.v20260622234151
@clerk/ui1.20.1-snapshot.v20260622234151
@clerk/upgrade2.0.5-snapshot.v20260622234151
@clerk/vue2.4.7-snapshot.v20260622234151
Tip: Use the snippet copy button below to quickly install the required packages.
@clerk/astro
npm i @clerk/astro@3.4.7-snapshot.v20260622234151 --save-exact
@clerk/backend
npm i @clerk/backend@3.8.3-snapshot.v20260622234151 --save-exact
@clerk/chrome-extension
npm i @clerk/chrome-extension@3.1.42-snapshot.v20260622234151 --save-exact
@clerk/clerk-js
npm i @clerk/clerk-js@6.21.0-snapshot.v20260622234151 --save-exact
@clerk/electron
npm i @clerk/electron@0.0.2-snapshot.v20260622234151 --save-exact
@clerk/electron-passkeys
npm i @clerk/electron-passkeys@0.0.2-snapshot.v20260622234151 --save-exact
@clerk/eslint-plugin
npm i @clerk/eslint-plugin@0.1.1-snapshot.v20260622234151 --save-exact
@clerk/expo
npm i @clerk/expo@3.5.3-snapshot.v20260622234151 --save-exact
@clerk/expo-passkeys
npm i @clerk/expo-passkeys@1.1.9-snapshot.v20260622234151 --save-exact
@clerk/express
npm i @clerk/express@2.1.31-snapshot.v20260622234151 --save-exact
@clerk/fastify
npm i @clerk/fastify@3.1.41-snapshot.v20260622234151 --save-exact
@clerk/headless
npm i @clerk/headless@0.0.3-snapshot.v20260622234151 --save-exact
@clerk/hono
npm i @clerk/hono@0.1.41-snapshot.v20260622234151 --save-exact
@clerk/localizations
npm i @clerk/localizations@4.9.3-snapshot.v20260622234151 --save-exact
@clerk/msw
npm i @clerk/msw@0.0.39-snapshot.v20260622234151 --save-exact
@clerk/nextjs
npm i @clerk/nextjs@7.5.8-snapshot.v20260622234151 --save-exact
@clerk/nuxt
npm i @clerk/nuxt@2.6.7-snapshot.v20260622234151 --save-exact
@clerk/react
npm i @clerk/react@6.11.0-snapshot.v20260622234151 --save-exact
@clerk/react-router
npm i @clerk/react-router@3.4.8-snapshot.v20260622234151 --save-exact
@clerk/shared
npm i @clerk/shared@4.21.0-snapshot.v20260622234151 --save-exact
@clerk/swingset
npm i @clerk/swingset@0.0.8-snapshot.v20260622234151 --save-exact
@clerk/tanstack-react-start
npm i @clerk/tanstack-react-start@1.4.8-snapshot.v20260622234151 --save-exact
@clerk/testing
npm i @clerk/testing@2.1.6-snapshot.v20260622234151 --save-exact
@clerk/ui
npm i @clerk/ui@1.20.1-snapshot.v20260622234151 --save-exact
@clerk/upgrade
npm i @clerk/upgrade@2.0.5-snapshot.v20260622234151 --save-exact
@clerk/vue
npm i @clerk/vue@2.4.7-snapshot.v20260622234151 --save-exact
@wobsoriano
wobsoriano
marked this pull request as draft
June 22, 2026 23:55
@wobsorianowobsoriano
changed the title
chore(electron): Fix exportschore(electron): Fix cjs/esm exportsJun 23, 2026
@wobsoriano
wobsoriano
marked this pull request as ready for review
June 23, 2026 20:02
jeremy-clerk
jeremy-clerk
approved these changes
Jun 23, 2026
View reviewed changes
@jeremy-clerkjeremy-clerk
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍
@wobsoriano
wobsoriano
merged commit 11cb740
into
mainJun 23, 2026

48 checks passed

@wobsoriano
wobsoriano
deleted the

rob/fix-cjs-esm-issue-electron

branch
June 23, 2026 20:08
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@coderabbitaicoderabbitai[bot]coderabbitai[bot] left review comments
@jeremy-clerkjeremy-clerkjeremy-clerk approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@wobsoriano@jeremy-clerk

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '
chore(electron): Fix cjs/esm exports by wobsoriano · Pull Request #8959 · clerk/javascript · GitHub
Skip to content
chore(electron): Fix cjs/esm exports - #8959
Merged
wobsoriano merged 11 commits into
mainfrom 
rob/fix-cjs-esm-issue-electron
Jun 23, 2026
Merged
chore(electron): Fix cjs/esm exports#8959
wobsoriano merged 11 commits into
mainfrom 
rob/fix-cjs-esm-issue-electron
Conversation
@wobsoriano
@wobsorianowobsoriano
commented
Jun 22, 2026•

edited by coderabbitai
Bot
Loading

Copy link


Copy Markdown

Member
Description
Checklist
  • pnpm test runs as expected.
  • pnpm build runs as expected.
  •  (If applicable) JSDoc comments have been added or updated for any package exports
  •  (If applicable) Documentation has been updated
Type of change
  •  🐛 Bug fix
  •  🌟 New feature
  •  🔨 Breaking change
  •  📖 Refactoring / dependency upgrade / documentation
  •  other:
Summary by CodeRabbit
  • Bug Fixes
    • Fixed Electron SDK exports to properly support both ESM and CommonJS module systems with correct type declarations.
@changeset-bot
changeset-botBot
commented
Jun 22, 2026•

edited

Loading

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: 4807231
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 0 packages
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@vercel
vercelBot
commented
Jun 22, 2026•

edited

Loading

Copy link


Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.
ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxReadyReadyPreview, CommentJun 23, 2026 8:04pm
swingsetReadyReadyPreview, CommentJun 23, 2026 8:04pm
Request Review
@coderabbitai
coderabbitaiBot
commented
Jun 22, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Review Change Stack
No actionable comments were generated in the recent review. 🎉
ℹ️ Recent review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Repository UI (inherited)
Review profile: CHILL
Plan: Pro
Run ID: b8aa1ea6-f27b-4152-a4cb-115413297ff1
📥 Commits
Reviewing files that changed from the base of the PR and between 7661e55 and 4807231.
📒 Files selected for processing (1)
  • .changeset/quiet-ducks-wonder.md
💤 Files with no reviewable changes (1)
  • .changeset/quiet-ducks-wonder.md
📝 Walkthrough
Walkthrough
The @clerk/electron package build is restructured to produce separate ESM (dist/esm) and CJS (dist/cjs) outputs via two distinct tsdown targets. A new tsconfig.declarations.json emits type declarations to dist/types. The package.json exports, main, module, and types fields are updated to reference these new output locations. A patch changeset is included.
Changes
Electron SDK ESM/CJS build restructure
Layer / File(s)Summary
ESM/CJS split and declaration-only tsconfig
packages/electron/tsconfig.declarations.json, packages/electron/tsdown.config.mts		Adds tsconfig.declarations.json to emit .d.ts files to dist/types. Refactors tsdown.config.mts to produce separate esm and cjs option objects with dts: false, wired via runAfterLast to run pnpm build:declarations then optionally pkglab pub --ping.
Package entrypoints and changeset
packages/electron/package.json, .changeset/quiet-ducks-wonder.md		Updates all exports subpaths to route import.default → dist/esm, require.default → dist/cjs, and types → dist/types/.../index.d.ts. Updates top-level main, module, types, and adds the build:declarations script. Adds a patch changeset for the export fix.
Estimated code review effort
🎯 2 (Simple) | ⏱️ ~10 minutes
Possibly related PRs
  • clerk/javascript#8786: Initial @clerk/electron SDK scaffold that established the original package.json entrypoints and build config this PR is directly updating.
Suggested reviewers
  • dstaley
Poem
🐇 Hop hop, the bundles split in two,

ESM and CJS, each path is true!
dist/types holds the declarations neat,
runAfterLast makes the pipeline complete.

No more mixed-up exports to untangle —

The Electron SDK shines from every angle! ✨
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title accurately describes the main change: restructuring Electron package exports to properly separate CommonJS and ESM entrypoints with corresponding type definitions.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
✏️ Tip: You can configure your own custom pre-merge checks in the settings.
Comment @coderabbitai help to get the list of available commands.
@pkg-pr-new
pkg-pr-newBot
commented
Jun 22, 2026•

edited

Loading

Copy link


Copy Markdown

Open in StackBlitz
@clerk/astro
npm i https://pkg.pr.new/@clerk/astro@8959

@clerk/backend
npm i https://pkg.pr.new/@clerk/backend@8959

@clerk/chrome-extension
npm i https://pkg.pr.new/@clerk/chrome-extension@8959

@clerk/clerk-js
npm i https://pkg.pr.new/@clerk/clerk-js@8959

@clerk/electron
npm i https://pkg.pr.new/@clerk/electron@8959

@clerk/electron-passkeys
npm i https://pkg.pr.new/@clerk/electron-passkeys@8959

@clerk/eslint-plugin
npm i https://pkg.pr.new/@clerk/eslint-plugin@8959

@clerk/expo
npm i https://pkg.pr.new/@clerk/expo@8959

@clerk/expo-passkeys
npm i https://pkg.pr.new/@clerk/expo-passkeys@8959

@clerk/express
npm i https://pkg.pr.new/@clerk/express@8959

@clerk/fastify
npm i https://pkg.pr.new/@clerk/fastify@8959

@clerk/hono
npm i https://pkg.pr.new/@clerk/hono@8959

@clerk/localizations
npm i https://pkg.pr.new/@clerk/localizations@8959

@clerk/nextjs
npm i https://pkg.pr.new/@clerk/nextjs@8959

@clerk/nuxt
npm i https://pkg.pr.new/@clerk/nuxt@8959

@clerk/react
npm i https://pkg.pr.new/@clerk/react@8959

@clerk/react-router
npm i https://pkg.pr.new/@clerk/react-router@8959

@clerk/shared
npm i https://pkg.pr.new/@clerk/shared@8959

@clerk/tanstack-react-start
npm i https://pkg.pr.new/@clerk/tanstack-react-start@8959

@clerk/testing
npm i https://pkg.pr.new/@clerk/testing@8959

@clerk/ui
npm i https://pkg.pr.new/@clerk/ui@8959

@clerk/upgrade
npm i https://pkg.pr.new/@clerk/upgrade@8959

@clerk/vue
npm i https://pkg.pr.new/@clerk/vue@8959

commit: 4807231
@wobsoriano
wobsoriano
commented
Jun 22, 2026

Copy link


Copy Markdown

MemberAuthor
!snapshot
coderabbitai[bot]
coderabbitaiBot
reviewed
Jun 22, 2026
View reviewed changes
@coderabbitaicoderabbitaiBot
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1
🧹 Nitpick comments (1)
packages/electron/tsdown.config.mts (1)
9-10: 🩺 Stability & Availability | 🔵 Trivial
Consider explicit type checking for the publish flag to prevent accidental publish runs if the env value is ever passed as a string.
!!overrideOptions.env?.publish relies on JavaScript truthiness, which can coerce non-empty strings (like "false") to true. While the current pattern uses --env.publish as a boolean, explicit type checking would be more robust if the configuration ever receives string values.
Suggested improvement
- const shouldPublish = !!overrideOptions.env?.publish;+ const publishEnv = overrideOptions.env?.publish;+ const shouldPublish =+ publishEnv === true ||+ (typeof publishEnv === 'string' && ['1', 'true', 'yes'].includes(publishEnv.toLowerCase()));
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@packages/electron/tsdown.config.mts` around lines 9 - 10, The shouldPublish
constant uses JavaScript truthiness coercion on overrideOptions.env?.publish,
which will incorrectly evaluate string values like "false" as true. Replace the
double negation operator truthiness check with explicit type checking that
compares overrideOptions.env?.publish to the string "true" or validates it as a
boolean true value, ensuring that string-based configuration values are handled
correctly and accidental publish runs are prevented.

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@scripts/common.mjs`:
- Around line 20-23: The second find command for native packages in the
packages/electron-passkeys/npm directory is using .nothrow() to suppress all
errors without checking the exitCode or stderr, which can mask real discovery
failures and exclude packages from workflows. Remove the .nothrow() call from
the nativeResult assignment to match the error handling behavior of the first
find command, or if .nothrow() must be kept, add explicit checks for
nativeResult.exitCode and nativeResult.stderr to differentiate between missing
directories (acceptable) and actual errors (which should be thrown or logged).
---
Nitpick comments:
In `@packages/electron/tsdown.config.mts`:
- Around line 9-10: The shouldPublish constant uses JavaScript truthiness
coercion on overrideOptions.env?.publish, which will incorrectly evaluate string
values like "false" as true. Replace the double negation operator truthiness
check with explicit type checking that compares overrideOptions.env?.publish to
the string "true" or validates it as a boolean true value, ensuring that
string-based configuration values are handled correctly and accidental publish
runs are prevented.

🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
  •  Push a commit to this branch (recommended)
  •  Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Repository UI (inherited)
Review profile: CHILL
Plan: Pro
Run ID: 02e2d0a8-1ca2-4c70-bf47-4db67ea0e0a3
📥 Commits
Reviewing files that changed from the base of the PR and between 52d310c and 5b61a0a.
📒 Files selected for processing (9)
  • packages/electron-passkeys/.gitignore
  • packages/electron-passkeys/npm/darwin-arm64/electron-passkeys.darwin-arm64.node
  • packages/electron-passkeys/npm/darwin-x64/electron-passkeys.darwin-x64.node
  • packages/electron-passkeys/npm/win32-arm64-msvc/electron-passkeys.win32-arm64-msvc.node
  • packages/electron-passkeys/npm/win32-x64-msvc/electron-passkeys.win32-x64-msvc.node
  • packages/electron/package.json
  • packages/electron/tsconfig.declarations.json
  • packages/electron/tsdown.config.mts
  • scripts/common.mjs
Comment threadscripts/common.mjs
Outdated

@wobsoriano
wobsoriano
commented
Jun 22, 2026

Copy link


Copy Markdown

MemberAuthor
!snapshot
@wobsoriano
wobsoriano
commented
Jun 22, 2026

Copy link


Copy Markdown

MemberAuthor
!snapshot
@github-actions
github-actionsBot
commented
Jun 22, 2026

Copy link


Copy Markdown

Contributor
Hey @wobsoriano - the snapshot version command generated the following package versions:
PackageVersion
@clerk/astro3.4.7-snapshot.v20260622234151
@clerk/backend3.8.3-snapshot.v20260622234151
@clerk/chrome-extension3.1.42-snapshot.v20260622234151
@clerk/clerk-js6.21.0-snapshot.v20260622234151
@clerk/electron0.0.2-snapshot.v20260622234151
@clerk/electron-passkeys0.0.2-snapshot.v20260622234151
@clerk/eslint-plugin0.1.1-snapshot.v20260622234151
@clerk/expo3.5.3-snapshot.v20260622234151
@clerk/expo-passkeys1.1.9-snapshot.v20260622234151
@clerk/express2.1.31-snapshot.v20260622234151
@clerk/fastify3.1.41-snapshot.v20260622234151
@clerk/headless0.0.3-snapshot.v20260622234151
@clerk/hono0.1.41-snapshot.v20260622234151
@clerk/localizations4.9.3-snapshot.v20260622234151
@clerk/msw0.0.39-snapshot.v20260622234151
@clerk/nextjs7.5.8-snapshot.v20260622234151
@clerk/nuxt2.6.7-snapshot.v20260622234151
@clerk/react6.11.0-snapshot.v20260622234151
@clerk/react-router3.4.8-snapshot.v20260622234151
@clerk/shared4.21.0-snapshot.v20260622234151
@clerk/swingset0.0.8-snapshot.v20260622234151
@clerk/tanstack-react-start1.4.8-snapshot.v20260622234151
@clerk/testing2.1.6-snapshot.v20260622234151
@clerk/ui1.20.1-snapshot.v20260622234151
@clerk/upgrade2.0.5-snapshot.v20260622234151
@clerk/vue2.4.7-snapshot.v20260622234151
Tip: Use the snippet copy button below to quickly install the required packages.
@clerk/astro
npm i @clerk/astro@3.4.7-snapshot.v20260622234151 --save-exact
@clerk/backend
npm i @clerk/backend@3.8.3-snapshot.v20260622234151 --save-exact
@clerk/chrome-extension
npm i @clerk/chrome-extension@3.1.42-snapshot.v20260622234151 --save-exact
@clerk/clerk-js
npm i @clerk/clerk-js@6.21.0-snapshot.v20260622234151 --save-exact
@clerk/electron
npm i @clerk/electron@0.0.2-snapshot.v20260622234151 --save-exact
@clerk/electron-passkeys
npm i @clerk/electron-passkeys@0.0.2-snapshot.v20260622234151 --save-exact
@clerk/eslint-plugin
npm i @clerk/eslint-plugin@0.1.1-snapshot.v20260622234151 --save-exact
@clerk/expo
npm i @clerk/expo@3.5.3-snapshot.v20260622234151 --save-exact
@clerk/expo-passkeys
npm i @clerk/expo-passkeys@1.1.9-snapshot.v20260622234151 --save-exact
@clerk/express
npm i @clerk/express@2.1.31-snapshot.v20260622234151 --save-exact
@clerk/fastify
npm i @clerk/fastify@3.1.41-snapshot.v20260622234151 --save-exact
@clerk/headless
npm i @clerk/headless@0.0.3-snapshot.v20260622234151 --save-exact
@clerk/hono
npm i @clerk/hono@0.1.41-snapshot.v20260622234151 --save-exact
@clerk/localizations
npm i @clerk/localizations@4.9.3-snapshot.v20260622234151 --save-exact
@clerk/msw
npm i @clerk/msw@0.0.39-snapshot.v20260622234151 --save-exact
@clerk/nextjs
npm i @clerk/nextjs@7.5.8-snapshot.v20260622234151 --save-exact
@clerk/nuxt
npm i @clerk/nuxt@2.6.7-snapshot.v20260622234151 --save-exact
@clerk/react
npm i @clerk/react@6.11.0-snapshot.v20260622234151 --save-exact
@clerk/react-router
npm i @clerk/react-router@3.4.8-snapshot.v20260622234151 --save-exact
@clerk/shared
npm i @clerk/shared@4.21.0-snapshot.v20260622234151 --save-exact
@clerk/swingset
npm i @clerk/swingset@0.0.8-snapshot.v20260622234151 --save-exact
@clerk/tanstack-react-start
npm i @clerk/tanstack-react-start@1.4.8-snapshot.v20260622234151 --save-exact
@clerk/testing
npm i @clerk/testing@2.1.6-snapshot.v20260622234151 --save-exact
@clerk/ui
npm i @clerk/ui@1.20.1-snapshot.v20260622234151 --save-exact
@clerk/upgrade
npm i @clerk/upgrade@2.0.5-snapshot.v20260622234151 --save-exact
@clerk/vue
npm i @clerk/vue@2.4.7-snapshot.v20260622234151 --save-exact
@wobsoriano
wobsoriano
marked this pull request as draft
June 22, 2026 23:55
@wobsorianowobsoriano
changed the title
chore(electron): Fix exportschore(electron): Fix cjs/esm exportsJun 23, 2026
@wobsoriano
wobsoriano
marked this pull request as ready for review
June 23, 2026 20:02
jeremy-clerk
jeremy-clerk
approved these changes
Jun 23, 2026
View reviewed changes
@jeremy-clerkjeremy-clerk
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍
@wobsoriano
wobsoriano
merged commit 11cb740
into
mainJun 23, 2026

48 checks passed

@wobsoriano
wobsoriano
deleted the

rob/fix-cjs-esm-issue-electron

branch
June 23, 2026 20:08
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@coderabbitaicoderabbitai[bot]coderabbitai[bot] left review comments
@jeremy-clerkjeremy-clerkjeremy-clerk approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@wobsoriano@jeremy-clerk

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
chore(electron): Fix cjs/esm exports by wobsoriano · Pull Request #8959 · clerk/javascript · GitHub
Skip to content
chore(electron): Fix cjs/esm exports - #8959
Merged
wobsoriano merged 11 commits into
mainfrom 
rob/fix-cjs-esm-issue-electron
Jun 23, 2026
Merged
chore(electron): Fix cjs/esm exports#8959
wobsoriano merged 11 commits into
mainfrom 
rob/fix-cjs-esm-issue-electron
Conversation
@wobsoriano
@wobsorianowobsoriano
commented
Jun 22, 2026•

edited by coderabbitai
Bot
Loading

Copy link


Copy Markdown

Member
Description
Checklist
  • pnpm test runs as expected.
  • pnpm build runs as expected.
  •  (If applicable) JSDoc comments have been added or updated for any package exports
  •  (If applicable) Documentation has been updated
Type of change
  •  🐛 Bug fix
  •  🌟 New feature
  •  🔨 Breaking change
  •  📖 Refactoring / dependency upgrade / documentation
  •  other:
Summary by CodeRabbit
  • Bug Fixes
    • Fixed Electron SDK exports to properly support both ESM and CommonJS module systems with correct type declarations.
@changeset-bot
changeset-botBot
commented
Jun 22, 2026•

edited

Loading

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: 4807231
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 0 packages
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@vercel
vercelBot
commented
Jun 22, 2026•

edited

Loading

Copy link


Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.
ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxReadyReadyPreview, CommentJun 23, 2026 8:04pm
swingsetReadyReadyPreview, CommentJun 23, 2026 8:04pm
Request Review
@coderabbitai
coderabbitaiBot
commented
Jun 22, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Review Change Stack
No actionable comments were generated in the recent review. 🎉
ℹ️ Recent review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Repository UI (inherited)
Review profile: CHILL
Plan: Pro
Run ID: b8aa1ea6-f27b-4152-a4cb-115413297ff1
📥 Commits
Reviewing files that changed from the base of the PR and between 7661e55 and 4807231.
📒 Files selected for processing (1)
  • .changeset/quiet-ducks-wonder.md
💤 Files with no reviewable changes (1)
  • .changeset/quiet-ducks-wonder.md
📝 Walkthrough
Walkthrough
The @clerk/electron package build is restructured to produce separate ESM (dist/esm) and CJS (dist/cjs) outputs via two distinct tsdown targets. A new tsconfig.declarations.json emits type declarations to dist/types. The package.json exports, main, module, and types fields are updated to reference these new output locations. A patch changeset is included.
Changes
Electron SDK ESM/CJS build restructure
Layer / File(s)Summary
ESM/CJS split and declaration-only tsconfig
packages/electron/tsconfig.declarations.json, packages/electron/tsdown.config.mts		Adds tsconfig.declarations.json to emit .d.ts files to dist/types. Refactors tsdown.config.mts to produce separate esm and cjs option objects with dts: false, wired via runAfterLast to run pnpm build:declarations then optionally pkglab pub --ping.
Package entrypoints and changeset
packages/electron/package.json, .changeset/quiet-ducks-wonder.md		Updates all exports subpaths to route import.default → dist/esm, require.default → dist/cjs, and types → dist/types/.../index.d.ts. Updates top-level main, module, types, and adds the build:declarations script. Adds a patch changeset for the export fix.
Estimated code review effort
🎯 2 (Simple) | ⏱️ ~10 minutes
Possibly related PRs
  • clerk/javascript#8786: Initial @clerk/electron SDK scaffold that established the original package.json entrypoints and build config this PR is directly updating.
Suggested reviewers
  • dstaley
Poem
🐇 Hop hop, the bundles split in two,

ESM and CJS, each path is true!
dist/types holds the declarations neat,
runAfterLast makes the pipeline complete.

No more mixed-up exports to untangle —

The Electron SDK shines from every angle! ✨
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title accurately describes the main change: restructuring Electron package exports to properly separate CommonJS and ESM entrypoints with corresponding type definitions.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
✏️ Tip: You can configure your own custom pre-merge checks in the settings.
Comment @coderabbitai help to get the list of available commands.
@pkg-pr-new
pkg-pr-newBot
commented
Jun 22, 2026•

edited

Loading

Copy link


Copy Markdown

Open in StackBlitz
@clerk/astro
npm i https://pkg.pr.new/@clerk/astro@8959

@clerk/backend
npm i https://pkg.pr.new/@clerk/backend@8959

@clerk/chrome-extension
npm i https://pkg.pr.new/@clerk/chrome-extension@8959

@clerk/clerk-js
npm i https://pkg.pr.new/@clerk/clerk-js@8959

@clerk/electron
npm i https://pkg.pr.new/@clerk/electron@8959

@clerk/electron-passkeys
npm i https://pkg.pr.new/@clerk/electron-passkeys@8959

@clerk/eslint-plugin
npm i https://pkg.pr.new/@clerk/eslint-plugin@8959

@clerk/expo
npm i https://pkg.pr.new/@clerk/expo@8959

@clerk/expo-passkeys
npm i https://pkg.pr.new/@clerk/expo-passkeys@8959

@clerk/express
npm i https://pkg.pr.new/@clerk/express@8959

@clerk/fastify
npm i https://pkg.pr.new/@clerk/fastify@8959

@clerk/hono
npm i https://pkg.pr.new/@clerk/hono@8959

@clerk/localizations
npm i https://pkg.pr.new/@clerk/localizations@8959

@clerk/nextjs
npm i https://pkg.pr.new/@clerk/nextjs@8959

@clerk/nuxt
npm i https://pkg.pr.new/@clerk/nuxt@8959

@clerk/react
npm i https://pkg.pr.new/@clerk/react@8959

@clerk/react-router
npm i https://pkg.pr.new/@clerk/react-router@8959

@clerk/shared
npm i https://pkg.pr.new/@clerk/shared@8959

@clerk/tanstack-react-start
npm i https://pkg.pr.new/@clerk/tanstack-react-start@8959

@clerk/testing
npm i https://pkg.pr.new/@clerk/testing@8959

@clerk/ui
npm i https://pkg.pr.new/@clerk/ui@8959

@clerk/upgrade
npm i https://pkg.pr.new/@clerk/upgrade@8959

@clerk/vue
npm i https://pkg.pr.new/@clerk/vue@8959

commit: 4807231
@wobsoriano
wobsoriano
commented
Jun 22, 2026

Copy link


Copy Markdown

MemberAuthor
!snapshot
coderabbitai[bot]
coderabbitaiBot
reviewed
Jun 22, 2026
View reviewed changes
@coderabbitaicoderabbitaiBot
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1
🧹 Nitpick comments (1)
packages/electron/tsdown.config.mts (1)
9-10: 🩺 Stability & Availability | 🔵 Trivial
Consider explicit type checking for the publish flag to prevent accidental publish runs if the env value is ever passed as a string.
!!overrideOptions.env?.publish relies on JavaScript truthiness, which can coerce non-empty strings (like "false") to true. While the current pattern uses --env.publish as a boolean, explicit type checking would be more robust if the configuration ever receives string values.
Suggested improvement
- const shouldPublish = !!overrideOptions.env?.publish;+ const publishEnv = overrideOptions.env?.publish;+ const shouldPublish =+ publishEnv === true ||+ (typeof publishEnv === 'string' && ['1', 'true', 'yes'].includes(publishEnv.toLowerCase()));
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@packages/electron/tsdown.config.mts` around lines 9 - 10, The shouldPublish
constant uses JavaScript truthiness coercion on overrideOptions.env?.publish,
which will incorrectly evaluate string values like "false" as true. Replace the
double negation operator truthiness check with explicit type checking that
compares overrideOptions.env?.publish to the string "true" or validates it as a
boolean true value, ensuring that string-based configuration values are handled
correctly and accidental publish runs are prevented.

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@scripts/common.mjs`:
- Around line 20-23: The second find command for native packages in the
packages/electron-passkeys/npm directory is using .nothrow() to suppress all
errors without checking the exitCode or stderr, which can mask real discovery
failures and exclude packages from workflows. Remove the .nothrow() call from
the nativeResult assignment to match the error handling behavior of the first
find command, or if .nothrow() must be kept, add explicit checks for
nativeResult.exitCode and nativeResult.stderr to differentiate between missing
directories (acceptable) and actual errors (which should be thrown or logged).
---
Nitpick comments:
In `@packages/electron/tsdown.config.mts`:
- Around line 9-10: The shouldPublish constant uses JavaScript truthiness
coercion on overrideOptions.env?.publish, which will incorrectly evaluate string
values like "false" as true. Replace the double negation operator truthiness
check with explicit type checking that compares overrideOptions.env?.publish to
the string "true" or validates it as a boolean true value, ensuring that
string-based configuration values are handled correctly and accidental publish
runs are prevented.

🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
  •  Push a commit to this branch (recommended)
  •  Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Repository UI (inherited)
Review profile: CHILL
Plan: Pro
Run ID: 02e2d0a8-1ca2-4c70-bf47-4db67ea0e0a3
📥 Commits
Reviewing files that changed from the base of the PR and between 52d310c and 5b61a0a.
📒 Files selected for processing (9)
  • packages/electron-passkeys/.gitignore
  • packages/electron-passkeys/npm/darwin-arm64/electron-passkeys.darwin-arm64.node
  • packages/electron-passkeys/npm/darwin-x64/electron-passkeys.darwin-x64.node
  • packages/electron-passkeys/npm/win32-arm64-msvc/electron-passkeys.win32-arm64-msvc.node
  • packages/electron-passkeys/npm/win32-x64-msvc/electron-passkeys.win32-x64-msvc.node
  • packages/electron/package.json
  • packages/electron/tsconfig.declarations.json
  • packages/electron/tsdown.config.mts
  • scripts/common.mjs
Comment threadscripts/common.mjs
Outdated

@wobsoriano
wobsoriano
commented
Jun 22, 2026

Copy link


Copy Markdown

MemberAuthor
!snapshot
@wobsoriano
wobsoriano
commented
Jun 22, 2026

Copy link


Copy Markdown

MemberAuthor
!snapshot
@github-actions
github-actionsBot
commented
Jun 22, 2026

Copy link


Copy Markdown

Contributor
Hey @wobsoriano - the snapshot version command generated the following package versions:
PackageVersion
@clerk/astro3.4.7-snapshot.v20260622234151
@clerk/backend3.8.3-snapshot.v20260622234151
@clerk/chrome-extension3.1.42-snapshot.v20260622234151
@clerk/clerk-js6.21.0-snapshot.v20260622234151
@clerk/electron0.0.2-snapshot.v20260622234151
@clerk/electron-passkeys0.0.2-snapshot.v20260622234151
@clerk/eslint-plugin0.1.1-snapshot.v20260622234151
@clerk/expo3.5.3-snapshot.v20260622234151
@clerk/expo-passkeys1.1.9-snapshot.v20260622234151
@clerk/express2.1.31-snapshot.v20260622234151
@clerk/fastify3.1.41-snapshot.v20260622234151
@clerk/headless0.0.3-snapshot.v20260622234151
@clerk/hono0.1.41-snapshot.v20260622234151
@clerk/localizations4.9.3-snapshot.v20260622234151
@clerk/msw0.0.39-snapshot.v20260622234151
@clerk/nextjs7.5.8-snapshot.v20260622234151
@clerk/nuxt2.6.7-snapshot.v20260622234151
@clerk/react6.11.0-snapshot.v20260622234151
@clerk/react-router3.4.8-snapshot.v20260622234151
@clerk/shared4.21.0-snapshot.v20260622234151
@clerk/swingset0.0.8-snapshot.v20260622234151
@clerk/tanstack-react-start1.4.8-snapshot.v20260622234151
@clerk/testing2.1.6-snapshot.v20260622234151
@clerk/ui1.20.1-snapshot.v20260622234151
@clerk/upgrade2.0.5-snapshot.v20260622234151
@clerk/vue2.4.7-snapshot.v20260622234151
Tip: Use the snippet copy button below to quickly install the required packages.
@clerk/astro
npm i @clerk/astro@3.4.7-snapshot.v20260622234151 --save-exact
@clerk/backend
npm i @clerk/backend@3.8.3-snapshot.v20260622234151 --save-exact
@clerk/chrome-extension
npm i @clerk/chrome-extension@3.1.42-snapshot.v20260622234151 --save-exact
@clerk/clerk-js
npm i @clerk/clerk-js@6.21.0-snapshot.v20260622234151 --save-exact
@clerk/electron
npm i @clerk/electron@0.0.2-snapshot.v20260622234151 --save-exact
@clerk/electron-passkeys
npm i @clerk/electron-passkeys@0.0.2-snapshot.v20260622234151 --save-exact
@clerk/eslint-plugin
npm i @clerk/eslint-plugin@0.1.1-snapshot.v20260622234151 --save-exact
@clerk/expo
npm i @clerk/expo@3.5.3-snapshot.v20260622234151 --save-exact
@clerk/expo-passkeys
npm i @clerk/expo-passkeys@1.1.9-snapshot.v20260622234151 --save-exact
@clerk/express
npm i @clerk/express@2.1.31-snapshot.v20260622234151 --save-exact
@clerk/fastify
npm i @clerk/fastify@3.1.41-snapshot.v20260622234151 --save-exact
@clerk/headless
npm i @clerk/headless@0.0.3-snapshot.v20260622234151 --save-exact
@clerk/hono
npm i @clerk/hono@0.1.41-snapshot.v20260622234151 --save-exact
@clerk/localizations
npm i @clerk/localizations@4.9.3-snapshot.v20260622234151 --save-exact
@clerk/msw
npm i @clerk/msw@0.0.39-snapshot.v20260622234151 --save-exact
@clerk/nextjs
npm i @clerk/nextjs@7.5.8-snapshot.v20260622234151 --save-exact
@clerk/nuxt
npm i @clerk/nuxt@2.6.7-snapshot.v20260622234151 --save-exact
@clerk/react
npm i @clerk/react@6.11.0-snapshot.v20260622234151 --save-exact
@clerk/react-router
npm i @clerk/react-router@3.4.8-snapshot.v20260622234151 --save-exact
@clerk/shared
npm i @clerk/shared@4.21.0-snapshot.v20260622234151 --save-exact
@clerk/swingset
npm i @clerk/swingset@0.0.8-snapshot.v20260622234151 --save-exact
@clerk/tanstack-react-start
npm i @clerk/tanstack-react-start@1.4.8-snapshot.v20260622234151 --save-exact
@clerk/testing
npm i @clerk/testing@2.1.6-snapshot.v20260622234151 --save-exact
@clerk/ui
npm i @clerk/ui@1.20.1-snapshot.v20260622234151 --save-exact
@clerk/upgrade
npm i @clerk/upgrade@2.0.5-snapshot.v20260622234151 --save-exact
@clerk/vue
npm i @clerk/vue@2.4.7-snapshot.v20260622234151 --save-exact
@wobsoriano
wobsoriano
marked this pull request as draft
June 22, 2026 23:55
@wobsorianowobsoriano
changed the title
chore(electron): Fix exportschore(electron): Fix cjs/esm exportsJun 23, 2026
@wobsoriano
wobsoriano
marked this pull request as ready for review
June 23, 2026 20:02
jeremy-clerk
jeremy-clerk
approved these changes
Jun 23, 2026
View reviewed changes
@jeremy-clerkjeremy-clerk
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍
@wobsoriano
wobsoriano
merged commit 11cb740
into
mainJun 23, 2026

48 checks passed

@wobsoriano
wobsoriano
deleted the

rob/fix-cjs-esm-issue-electron

branch
June 23, 2026 20:08
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@coderabbitaicoderabbitai[bot]coderabbitai[bot] left review comments
@jeremy-clerkjeremy-clerkjeremy-clerk approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@wobsoriano@jeremy-clerk

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
chore(electron): Fix cjs/esm exports by wobsoriano · Pull Request #8959 · clerk/javascript · GitHub
Skip to content
chore(electron): Fix cjs/esm exports - #8959
Merged
wobsoriano merged 11 commits into
mainfrom 
rob/fix-cjs-esm-issue-electron
Jun 23, 2026
Merged
chore(electron): Fix cjs/esm exports#8959
wobsoriano merged 11 commits into
mainfrom 
rob/fix-cjs-esm-issue-electron
Conversation
@wobsoriano
@wobsorianowobsoriano
commented
Jun 22, 2026•

edited by coderabbitai
Bot
Loading

Copy link


Copy Markdown

Member
Description
Checklist
  • pnpm test runs as expected.
  • pnpm build runs as expected.
  •  (If applicable) JSDoc comments have been added or updated for any package exports
  •  (If applicable) Documentation has been updated
Type of change
  •  🐛 Bug fix
  •  🌟 New feature
  •  🔨 Breaking change
  •  📖 Refactoring / dependency upgrade / documentation
  •  other:
Summary by CodeRabbit
  • Bug Fixes
    • Fixed Electron SDK exports to properly support both ESM and CommonJS module systems with correct type declarations.
@changeset-bot
changeset-botBot
commented
Jun 22, 2026•

edited

Loading

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: 4807231
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 0 packages
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@vercel
vercelBot
commented
Jun 22, 2026•

edited

Loading

Copy link


Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.
ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxReadyReadyPreview, CommentJun 23, 2026 8:04pm
swingsetReadyReadyPreview, CommentJun 23, 2026 8:04pm
Request Review
@coderabbitai
coderabbitaiBot
commented
Jun 22, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Review Change Stack
No actionable comments were generated in the recent review. 🎉
ℹ️ Recent review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Repository UI (inherited)
Review profile: CHILL
Plan: Pro
Run ID: b8aa1ea6-f27b-4152-a4cb-115413297ff1
📥 Commits
Reviewing files that changed from the base of the PR and between 7661e55 and 4807231.
📒 Files selected for processing (1)
  • .changeset/quiet-ducks-wonder.md
💤 Files with no reviewable changes (1)
  • .changeset/quiet-ducks-wonder.md
📝 Walkthrough
Walkthrough
The @clerk/electron package build is restructured to produce separate ESM (dist/esm) and CJS (dist/cjs) outputs via two distinct tsdown targets. A new tsconfig.declarations.json emits type declarations to dist/types. The package.json exports, main, module, and types fields are updated to reference these new output locations. A patch changeset is included.
Changes
Electron SDK ESM/CJS build restructure
Layer / File(s)Summary
ESM/CJS split and declaration-only tsconfig
packages/electron/tsconfig.declarations.json, packages/electron/tsdown.config.mts		Adds tsconfig.declarations.json to emit .d.ts files to dist/types. Refactors tsdown.config.mts to produce separate esm and cjs option objects with dts: false, wired via runAfterLast to run pnpm build:declarations then optionally pkglab pub --ping.
Package entrypoints and changeset
packages/electron/package.json, .changeset/quiet-ducks-wonder.md		Updates all exports subpaths to route import.default → dist/esm, require.default → dist/cjs, and types → dist/types/.../index.d.ts. Updates top-level main, module, types, and adds the build:declarations script. Adds a patch changeset for the export fix.
Estimated code review effort
🎯 2 (Simple) | ⏱️ ~10 minutes
Possibly related PRs
  • clerk/javascript#8786: Initial @clerk/electron SDK scaffold that established the original package.json entrypoints and build config this PR is directly updating.
Suggested reviewers
  • dstaley
Poem
🐇 Hop hop, the bundles split in two,

ESM and CJS, each path is true!
dist/types holds the declarations neat,
runAfterLast makes the pipeline complete.

No more mixed-up exports to untangle —

The Electron SDK shines from every angle! ✨
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title accurately describes the main change: restructuring Electron package exports to properly separate CommonJS and ESM entrypoints with corresponding type definitions.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
✏️ Tip: You can configure your own custom pre-merge checks in the settings.
Comment @coderabbitai help to get the list of available commands.
@pkg-pr-new
pkg-pr-newBot
commented
Jun 22, 2026•

edited

Loading

Copy link


Copy Markdown

Open in StackBlitz
@clerk/astro
npm i https://pkg.pr.new/@clerk/astro@8959

@clerk/backend
npm i https://pkg.pr.new/@clerk/backend@8959

@clerk/chrome-extension
npm i https://pkg.pr.new/@clerk/chrome-extension@8959

@clerk/clerk-js
npm i https://pkg.pr.new/@clerk/clerk-js@8959

@clerk/electron
npm i https://pkg.pr.new/@clerk/electron@8959

@clerk/electron-passkeys
npm i https://pkg.pr.new/@clerk/electron-passkeys@8959

@clerk/eslint-plugin
npm i https://pkg.pr.new/@clerk/eslint-plugin@8959

@clerk/expo
npm i https://pkg.pr.new/@clerk/expo@8959

@clerk/expo-passkeys
npm i https://pkg.pr.new/@clerk/expo-passkeys@8959

@clerk/express
npm i https://pkg.pr.new/@clerk/express@8959

@clerk/fastify
npm i https://pkg.pr.new/@clerk/fastify@8959

@clerk/hono
npm i https://pkg.pr.new/@clerk/hono@8959

@clerk/localizations
npm i https://pkg.pr.new/@clerk/localizations@8959

@clerk/nextjs
npm i https://pkg.pr.new/@clerk/nextjs@8959

@clerk/nuxt
npm i https://pkg.pr.new/@clerk/nuxt@8959

@clerk/react
npm i https://pkg.pr.new/@clerk/react@8959

@clerk/react-router
npm i https://pkg.pr.new/@clerk/react-router@8959

@clerk/shared
npm i https://pkg.pr.new/@clerk/shared@8959

@clerk/tanstack-react-start
npm i https://pkg.pr.new/@clerk/tanstack-react-start@8959

@clerk/testing
npm i https://pkg.pr.new/@clerk/testing@8959

@clerk/ui
npm i https://pkg.pr.new/@clerk/ui@8959

@clerk/upgrade
npm i https://pkg.pr.new/@clerk/upgrade@8959

@clerk/vue
npm i https://pkg.pr.new/@clerk/vue@8959

commit: 4807231
@wobsoriano
wobsoriano
commented
Jun 22, 2026

Copy link


Copy Markdown

MemberAuthor
!snapshot
coderabbitai[bot]
coderabbitaiBot
reviewed
Jun 22, 2026
View reviewed changes
@coderabbitaicoderabbitaiBot
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1
🧹 Nitpick comments (1)
packages/electron/tsdown.config.mts (1)
9-10: 🩺 Stability & Availability | 🔵 Trivial
Consider explicit type checking for the publish flag to prevent accidental publish runs if the env value is ever passed as a string.
!!overrideOptions.env?.publish relies on JavaScript truthiness, which can coerce non-empty strings (like "false") to true. While the current pattern uses --env.publish as a boolean, explicit type checking would be more robust if the configuration ever receives string values.
Suggested improvement
- const shouldPublish = !!overrideOptions.env?.publish;+ const publishEnv = overrideOptions.env?.publish;+ const shouldPublish =+ publishEnv === true ||+ (typeof publishEnv === 'string' && ['1', 'true', 'yes'].includes(publishEnv.toLowerCase()));
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@packages/electron/tsdown.config.mts` around lines 9 - 10, The shouldPublish
constant uses JavaScript truthiness coercion on overrideOptions.env?.publish,
which will incorrectly evaluate string values like "false" as true. Replace the
double negation operator truthiness check with explicit type checking that
compares overrideOptions.env?.publish to the string "true" or validates it as a
boolean true value, ensuring that string-based configuration values are handled
correctly and accidental publish runs are prevented.

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@scripts/common.mjs`:
- Around line 20-23: The second find command for native packages in the
packages/electron-passkeys/npm directory is using .nothrow() to suppress all
errors without checking the exitCode or stderr, which can mask real discovery
failures and exclude packages from workflows. Remove the .nothrow() call from
the nativeResult assignment to match the error handling behavior of the first
find command, or if .nothrow() must be kept, add explicit checks for
nativeResult.exitCode and nativeResult.stderr to differentiate between missing
directories (acceptable) and actual errors (which should be thrown or logged).
---
Nitpick comments:
In `@packages/electron/tsdown.config.mts`:
- Around line 9-10: The shouldPublish constant uses JavaScript truthiness
coercion on overrideOptions.env?.publish, which will incorrectly evaluate string
values like "false" as true. Replace the double negation operator truthiness
check with explicit type checking that compares overrideOptions.env?.publish to
the string "true" or validates it as a boolean true value, ensuring that
string-based configuration values are handled correctly and accidental publish
runs are prevented.

🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
  •  Push a commit to this branch (recommended)
  •  Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Repository UI (inherited)
Review profile: CHILL
Plan: Pro
Run ID: 02e2d0a8-1ca2-4c70-bf47-4db67ea0e0a3
📥 Commits
Reviewing files that changed from the base of the PR and between 52d310c and 5b61a0a.
📒 Files selected for processing (9)
  • packages/electron-passkeys/.gitignore
  • packages/electron-passkeys/npm/darwin-arm64/electron-passkeys.darwin-arm64.node
  • packages/electron-passkeys/npm/darwin-x64/electron-passkeys.darwin-x64.node
  • packages/electron-passkeys/npm/win32-arm64-msvc/electron-passkeys.win32-arm64-msvc.node
  • packages/electron-passkeys/npm/win32-x64-msvc/electron-passkeys.win32-x64-msvc.node
  • packages/electron/package.json
  • packages/electron/tsconfig.declarations.json
  • packages/electron/tsdown.config.mts
  • scripts/common.mjs
Comment threadscripts/common.mjs
Outdated

@wobsoriano
wobsoriano
commented
Jun 22, 2026

Copy link


Copy Markdown

MemberAuthor
!snapshot
@wobsoriano
wobsoriano
commented
Jun 22, 2026

Copy link


Copy Markdown

MemberAuthor
!snapshot
@github-actions
github-actionsBot
commented
Jun 22, 2026

Copy link


Copy Markdown

Contributor
Hey @wobsoriano - the snapshot version command generated the following package versions:
PackageVersion
@clerk/astro3.4.7-snapshot.v20260622234151
@clerk/backend3.8.3-snapshot.v20260622234151
@clerk/chrome-extension3.1.42-snapshot.v20260622234151
@clerk/clerk-js6.21.0-snapshot.v20260622234151
@clerk/electron0.0.2-snapshot.v20260622234151
@clerk/electron-passkeys0.0.2-snapshot.v20260622234151
@clerk/eslint-plugin0.1.1-snapshot.v20260622234151
@clerk/expo3.5.3-snapshot.v20260622234151
@clerk/expo-passkeys1.1.9-snapshot.v20260622234151
@clerk/express2.1.31-snapshot.v20260622234151
@clerk/fastify3.1.41-snapshot.v20260622234151
@clerk/headless0.0.3-snapshot.v20260622234151
@clerk/hono0.1.41-snapshot.v20260622234151
@clerk/localizations4.9.3-snapshot.v20260622234151
@clerk/msw0.0.39-snapshot.v20260622234151
@clerk/nextjs7.5.8-snapshot.v20260622234151
@clerk/nuxt2.6.7-snapshot.v20260622234151
@clerk/react6.11.0-snapshot.v20260622234151
@clerk/react-router3.4.8-snapshot.v20260622234151
@clerk/shared4.21.0-snapshot.v20260622234151
@clerk/swingset0.0.8-snapshot.v20260622234151
@clerk/tanstack-react-start1.4.8-snapshot.v20260622234151
@clerk/testing2.1.6-snapshot.v20260622234151
@clerk/ui1.20.1-snapshot.v20260622234151
@clerk/upgrade2.0.5-snapshot.v20260622234151
@clerk/vue2.4.7-snapshot.v20260622234151
Tip: Use the snippet copy button below to quickly install the required packages.
@clerk/astro
npm i @clerk/astro@3.4.7-snapshot.v20260622234151 --save-exact
@clerk/backend
npm i @clerk/backend@3.8.3-snapshot.v20260622234151 --save-exact
@clerk/chrome-extension
npm i @clerk/chrome-extension@3.1.42-snapshot.v20260622234151 --save-exact
@clerk/clerk-js
npm i @clerk/clerk-js@6.21.0-snapshot.v20260622234151 --save-exact
@clerk/electron
npm i @clerk/electron@0.0.2-snapshot.v20260622234151 --save-exact
@clerk/electron-passkeys
npm i @clerk/electron-passkeys@0.0.2-snapshot.v20260622234151 --save-exact
@clerk/eslint-plugin
npm i @clerk/eslint-plugin@0.1.1-snapshot.v20260622234151 --save-exact
@clerk/expo
npm i @clerk/expo@3.5.3-snapshot.v20260622234151 --save-exact
@clerk/expo-passkeys
npm i @clerk/expo-passkeys@1.1.9-snapshot.v20260622234151 --save-exact
@clerk/express
npm i @clerk/express@2.1.31-snapshot.v20260622234151 --save-exact
@clerk/fastify
npm i @clerk/fastify@3.1.41-snapshot.v20260622234151 --save-exact
@clerk/headless
npm i @clerk/headless@0.0.3-snapshot.v20260622234151 --save-exact
@clerk/hono
npm i @clerk/hono@0.1.41-snapshot.v20260622234151 --save-exact
@clerk/localizations
npm i @clerk/localizations@4.9.3-snapshot.v20260622234151 --save-exact
@clerk/msw
npm i @clerk/msw@0.0.39-snapshot.v20260622234151 --save-exact
@clerk/nextjs
npm i @clerk/nextjs@7.5.8-snapshot.v20260622234151 --save-exact
@clerk/nuxt
npm i @clerk/nuxt@2.6.7-snapshot.v20260622234151 --save-exact
@clerk/react
npm i @clerk/react@6.11.0-snapshot.v20260622234151 --save-exact
@clerk/react-router
npm i @clerk/react-router@3.4.8-snapshot.v20260622234151 --save-exact
@clerk/shared
npm i @clerk/shared@4.21.0-snapshot.v20260622234151 --save-exact
@clerk/swingset
npm i @clerk/swingset@0.0.8-snapshot.v20260622234151 --save-exact
@clerk/tanstack-react-start
npm i @clerk/tanstack-react-start@1.4.8-snapshot.v20260622234151 --save-exact
@clerk/testing
npm i @clerk/testing@2.1.6-snapshot.v20260622234151 --save-exact
@clerk/ui
npm i @clerk/ui@1.20.1-snapshot.v20260622234151 --save-exact
@clerk/upgrade
npm i @clerk/upgrade@2.0.5-snapshot.v20260622234151 --save-exact
@clerk/vue
npm i @clerk/vue@2.4.7-snapshot.v20260622234151 --save-exact
@wobsoriano
wobsoriano
marked this pull request as draft
June 22, 2026 23:55
@wobsorianowobsoriano
changed the title
chore(electron): Fix exportschore(electron): Fix cjs/esm exportsJun 23, 2026
@wobsoriano
wobsoriano
marked this pull request as ready for review
June 23, 2026 20:02
jeremy-clerk
jeremy-clerk
approved these changes
Jun 23, 2026
View reviewed changes
@jeremy-clerkjeremy-clerk
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍
@wobsoriano
wobsoriano
merged commit 11cb740
into
mainJun 23, 2026

48 checks passed

@wobsoriano
wobsoriano
deleted the

rob/fix-cjs-esm-issue-electron

branch
June 23, 2026 20:08
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@coderabbitaicoderabbitai[bot]coderabbitai[bot] left review comments
@jeremy-clerkjeremy-clerkjeremy-clerk approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@wobsoriano@jeremy-clerk

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Universal Dark Mode - works on any site
(function() {
var enabled = true;
function applyDarkMode() {
if (!enabled) return;
// Create style element if it doesn't exist
var style = document.getElementById('universal-dark-mode-style');
if (!style) {
style = document.createElement('style');
style.id = 'universal-dark-mode-style';
document.head.appendChild(style);
}
// Dark mode CSS - inverts colors but preserves images/video
style.textContent = '
/* Invert everything except media */
html {
filter: invert(1) hue-rotate(180deg) !important;
background: #1a1a2e !important;
}
/* Restore images, videos, iframes, canvas */
img, video, iframe, canvas, svg, picture, [style*="background-image"] {
filter: invert(1) hue-rotate(180deg) !important;
}
/* Preserve specific elements that should not be inverted */
.no-dark-mode, .no-dark-mode *,
[data-theme="light"], [data-theme="light"],
.ace_editor, .ace_editor *,
.CodeMirror, .CodeMirror *,
.monaco-editor, .monaco-editor *,
.markdown-body pre, .markdown-body pre *,
.highlight, .highlight *,
pre code, pre code * {
filter: none !important;
}
/* Fix common UI elements */
.modal, .popup, .dropdown-menu, .tooltip, .popover {
filter: invert(1) hue-rotate(180deg) !important;
background: #2d2d44 !important;
border-color: #444 !important;
}
/* Scrollbars */
::-webkit-scrollbar { background: #1a1a2e !important; }
::-webkit-scrollbar-thumb { background: #444 !important; }
::-webkit-scrollbar-thumb:hover { background: #555 !important; }
/* Selection */
::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
';
}
function removeDarkMode() {
var style = document.getElementById('universal-dark-mode-style');
if (style) style.remove();
}
// Toggle with Alt+Shift+D
document.addEventListener('keydown', function(e) {
if (e.altKey && e.shiftKey && e.key === 'D') {
e.preventDefault();
enabled = !enabled;
if (enabled) {
applyDarkMode();
console.log('[Universal Dark Mode] Enabled');
} else {
removeDarkMode();
console.log('[Universal Dark Mode] Disabled');
}
}
});
// Apply on load
applyDarkMode();
// Re-apply on dynamic content
var observer = new MutationObserver(function(mutations) {
if (enabled && !document.getElementById('universal-dark-mode-style')) {
applyDarkMode();
}
});
observer.observe(document.head, { childList: true });
console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');
})();
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();
chore(electron): Fix cjs/esm exports by wobsoriano · Pull Request #8959 · clerk/javascript · GitHub
Skip to content
chore(electron): Fix cjs/esm exports - #8959
Merged
wobsoriano merged 11 commits into
mainfrom 
rob/fix-cjs-esm-issue-electron
Jun 23, 2026
Merged
chore(electron): Fix cjs/esm exports#8959
wobsoriano merged 11 commits into
mainfrom 
rob/fix-cjs-esm-issue-electron
Conversation
@wobsoriano
@wobsorianowobsoriano
commented
Jun 22, 2026•

edited by coderabbitai
Bot
Loading

Copy link


Copy Markdown

Member
Description
Checklist
  • pnpm test runs as expected.
  • pnpm build runs as expected.
  •  (If applicable) JSDoc comments have been added or updated for any package exports
  •  (If applicable) Documentation has been updated
Type of change
  •  🐛 Bug fix
  •  🌟 New feature
  •  🔨 Breaking change
  •  📖 Refactoring / dependency upgrade / documentation
  •  other:
Summary by CodeRabbit
  • Bug Fixes
    • Fixed Electron SDK exports to properly support both ESM and CommonJS module systems with correct type declarations.
@changeset-bot
changeset-botBot
commented
Jun 22, 2026•

edited

Loading

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: 4807231
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 0 packages
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@vercel
vercelBot
commented
Jun 22, 2026•

edited

Loading

Copy link


Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.
ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxReadyReadyPreview, CommentJun 23, 2026 8:04pm
swingsetReadyReadyPreview, CommentJun 23, 2026 8:04pm
Request Review
@coderabbitai
coderabbitaiBot
commented
Jun 22, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Review Change Stack
No actionable comments were generated in the recent review. 🎉
ℹ️ Recent review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Repository UI (inherited)
Review profile: CHILL
Plan: Pro
Run ID: b8aa1ea6-f27b-4152-a4cb-115413297ff1
📥 Commits
Reviewing files that changed from the base of the PR and between 7661e55 and 4807231.
📒 Files selected for processing (1)
  • .changeset/quiet-ducks-wonder.md
💤 Files with no reviewable changes (1)
  • .changeset/quiet-ducks-wonder.md
📝 Walkthrough
Walkthrough
The @clerk/electron package build is restructured to produce separate ESM (dist/esm) and CJS (dist/cjs) outputs via two distinct tsdown targets. A new tsconfig.declarations.json emits type declarations to dist/types. The package.json exports, main, module, and types fields are updated to reference these new output locations. A patch changeset is included.
Changes
Electron SDK ESM/CJS build restructure
Layer / File(s)Summary
ESM/CJS split and declaration-only tsconfig
packages/electron/tsconfig.declarations.json, packages/electron/tsdown.config.mts		Adds tsconfig.declarations.json to emit .d.ts files to dist/types. Refactors tsdown.config.mts to produce separate esm and cjs option objects with dts: false, wired via runAfterLast to run pnpm build:declarations then optionally pkglab pub --ping.
Package entrypoints and changeset
packages/electron/package.json, .changeset/quiet-ducks-wonder.md		Updates all exports subpaths to route import.default → dist/esm, require.default → dist/cjs, and types → dist/types/.../index.d.ts. Updates top-level main, module, types, and adds the build:declarations script. Adds a patch changeset for the export fix.
Estimated code review effort
🎯 2 (Simple) | ⏱️ ~10 minutes
Possibly related PRs
  • clerk/javascript#8786: Initial @clerk/electron SDK scaffold that established the original package.json entrypoints and build config this PR is directly updating.
Suggested reviewers
  • dstaley
Poem
🐇 Hop hop, the bundles split in two,

ESM and CJS, each path is true!
dist/types holds the declarations neat,
runAfterLast makes the pipeline complete.

No more mixed-up exports to untangle —

The Electron SDK shines from every angle! ✨
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title accurately describes the main change: restructuring Electron package exports to properly separate CommonJS and ESM entrypoints with corresponding type definitions.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
✏️ Tip: You can configure your own custom pre-merge checks in the settings.
Comment @coderabbitai help to get the list of available commands.
@pkg-pr-new
pkg-pr-newBot
commented
Jun 22, 2026•

edited

Loading

Copy link


Copy Markdown

Open in StackBlitz
@clerk/astro
npm i https://pkg.pr.new/@clerk/astro@8959

@clerk/backend
npm i https://pkg.pr.new/@clerk/backend@8959

@clerk/chrome-extension
npm i https://pkg.pr.new/@clerk/chrome-extension@8959

@clerk/clerk-js
npm i https://pkg.pr.new/@clerk/clerk-js@8959

@clerk/electron
npm i https://pkg.pr.new/@clerk/electron@8959

@clerk/electron-passkeys
npm i https://pkg.pr.new/@clerk/electron-passkeys@8959

@clerk/eslint-plugin
npm i https://pkg.pr.new/@clerk/eslint-plugin@8959

@clerk/expo
npm i https://pkg.pr.new/@clerk/expo@8959

@clerk/expo-passkeys
npm i https://pkg.pr.new/@clerk/expo-passkeys@8959

@clerk/express
npm i https://pkg.pr.new/@clerk/express@8959

@clerk/fastify
npm i https://pkg.pr.new/@clerk/fastify@8959

@clerk/hono
npm i https://pkg.pr.new/@clerk/hono@8959

@clerk/localizations
npm i https://pkg.pr.new/@clerk/localizations@8959

@clerk/nextjs
npm i https://pkg.pr.new/@clerk/nextjs@8959

@clerk/nuxt
npm i https://pkg.pr.new/@clerk/nuxt@8959

@clerk/react
npm i https://pkg.pr.new/@clerk/react@8959

@clerk/react-router
npm i https://pkg.pr.new/@clerk/react-router@8959

@clerk/shared
npm i https://pkg.pr.new/@clerk/shared@8959

@clerk/tanstack-react-start
npm i https://pkg.pr.new/@clerk/tanstack-react-start@8959

@clerk/testing
npm i https://pkg.pr.new/@clerk/testing@8959

@clerk/ui
npm i https://pkg.pr.new/@clerk/ui@8959

@clerk/upgrade
npm i https://pkg.pr.new/@clerk/upgrade@8959

@clerk/vue
npm i https://pkg.pr.new/@clerk/vue@8959

commit: 4807231
@wobsoriano
wobsoriano
commented
Jun 22, 2026

Copy link


Copy Markdown

MemberAuthor
!snapshot
coderabbitai[bot]
coderabbitaiBot
reviewed
Jun 22, 2026
View reviewed changes
@coderabbitaicoderabbitaiBot
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1
🧹 Nitpick comments (1)
packages/electron/tsdown.config.mts (1)
9-10: 🩺 Stability & Availability | 🔵 Trivial
Consider explicit type checking for the publish flag to prevent accidental publish runs if the env value is ever passed as a string.
!!overrideOptions.env?.publish relies on JavaScript truthiness, which can coerce non-empty strings (like "false") to true. While the current pattern uses --env.publish as a boolean, explicit type checking would be more robust if the configuration ever receives string values.
Suggested improvement
- const shouldPublish = !!overrideOptions.env?.publish;+ const publishEnv = overrideOptions.env?.publish;+ const shouldPublish =+ publishEnv === true ||+ (typeof publishEnv === 'string' && ['1', 'true', 'yes'].includes(publishEnv.toLowerCase()));
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@packages/electron/tsdown.config.mts` around lines 9 - 10, The shouldPublish
constant uses JavaScript truthiness coercion on overrideOptions.env?.publish,
which will incorrectly evaluate string values like "false" as true. Replace the
double negation operator truthiness check with explicit type checking that
compares overrideOptions.env?.publish to the string "true" or validates it as a
boolean true value, ensuring that string-based configuration values are handled
correctly and accidental publish runs are prevented.

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@scripts/common.mjs`:
- Around line 20-23: The second find command for native packages in the
packages/electron-passkeys/npm directory is using .nothrow() to suppress all
errors without checking the exitCode or stderr, which can mask real discovery
failures and exclude packages from workflows. Remove the .nothrow() call from
the nativeResult assignment to match the error handling behavior of the first
find command, or if .nothrow() must be kept, add explicit checks for
nativeResult.exitCode and nativeResult.stderr to differentiate between missing
directories (acceptable) and actual errors (which should be thrown or logged).
---
Nitpick comments:
In `@packages/electron/tsdown.config.mts`:
- Around line 9-10: The shouldPublish constant uses JavaScript truthiness
coercion on overrideOptions.env?.publish, which will incorrectly evaluate string
values like "false" as true. Replace the double negation operator truthiness
check with explicit type checking that compares overrideOptions.env?.publish to
the string "true" or validates it as a boolean true value, ensuring that
string-based configuration values are handled correctly and accidental publish
runs are prevented.

🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
  •  Push a commit to this branch (recommended)
  •  Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Repository UI (inherited)
Review profile: CHILL
Plan: Pro
Run ID: 02e2d0a8-1ca2-4c70-bf47-4db67ea0e0a3
📥 Commits
Reviewing files that changed from the base of the PR and between 52d310c and 5b61a0a.
📒 Files selected for processing (9)
  • packages/electron-passkeys/.gitignore
  • packages/electron-passkeys/npm/darwin-arm64/electron-passkeys.darwin-arm64.node
  • packages/electron-passkeys/npm/darwin-x64/electron-passkeys.darwin-x64.node
  • packages/electron-passkeys/npm/win32-arm64-msvc/electron-passkeys.win32-arm64-msvc.node
  • packages/electron-passkeys/npm/win32-x64-msvc/electron-passkeys.win32-x64-msvc.node
  • packages/electron/package.json
  • packages/electron/tsconfig.declarations.json
  • packages/electron/tsdown.config.mts
  • scripts/common.mjs
Comment threadscripts/common.mjs
Outdated

@wobsoriano
wobsoriano
commented
Jun 22, 2026

Copy link


Copy Markdown

MemberAuthor
!snapshot
@wobsoriano
wobsoriano
commented
Jun 22, 2026

Copy link


Copy Markdown

MemberAuthor
!snapshot
@github-actions
github-actionsBot
commented
Jun 22, 2026

Copy link


Copy Markdown

Contributor
Hey @wobsoriano - the snapshot version command generated the following package versions:
PackageVersion
@clerk/astro3.4.7-snapshot.v20260622234151
@clerk/backend3.8.3-snapshot.v20260622234151
@clerk/chrome-extension3.1.42-snapshot.v20260622234151
@clerk/clerk-js6.21.0-snapshot.v20260622234151
@clerk/electron0.0.2-snapshot.v20260622234151
@clerk/electron-passkeys0.0.2-snapshot.v20260622234151
@clerk/eslint-plugin0.1.1-snapshot.v20260622234151
@clerk/expo3.5.3-snapshot.v20260622234151
@clerk/expo-passkeys1.1.9-snapshot.v20260622234151
@clerk/express2.1.31-snapshot.v20260622234151
@clerk/fastify3.1.41-snapshot.v20260622234151
@clerk/headless0.0.3-snapshot.v20260622234151
@clerk/hono0.1.41-snapshot.v20260622234151
@clerk/localizations4.9.3-snapshot.v20260622234151
@clerk/msw0.0.39-snapshot.v20260622234151
@clerk/nextjs7.5.8-snapshot.v20260622234151
@clerk/nuxt2.6.7-snapshot.v20260622234151
@clerk/react6.11.0-snapshot.v20260622234151
@clerk/react-router3.4.8-snapshot.v20260622234151
@clerk/shared4.21.0-snapshot.v20260622234151
@clerk/swingset0.0.8-snapshot.v20260622234151
@clerk/tanstack-react-start1.4.8-snapshot.v20260622234151
@clerk/testing2.1.6-snapshot.v20260622234151
@clerk/ui1.20.1-snapshot.v20260622234151
@clerk/upgrade2.0.5-snapshot.v20260622234151
@clerk/vue2.4.7-snapshot.v20260622234151
Tip: Use the snippet copy button below to quickly install the required packages.
@clerk/astro
npm i @clerk/astro@3.4.7-snapshot.v20260622234151 --save-exact
@clerk/backend
npm i @clerk/backend@3.8.3-snapshot.v20260622234151 --save-exact
@clerk/chrome-extension
npm i @clerk/chrome-extension@3.1.42-snapshot.v20260622234151 --save-exact
@clerk/clerk-js
npm i @clerk/clerk-js@6.21.0-snapshot.v20260622234151 --save-exact
@clerk/electron
npm i @clerk/electron@0.0.2-snapshot.v20260622234151 --save-exact
@clerk/electron-passkeys
npm i @clerk/electron-passkeys@0.0.2-snapshot.v20260622234151 --save-exact
@clerk/eslint-plugin
npm i @clerk/eslint-plugin@0.1.1-snapshot.v20260622234151 --save-exact
@clerk/expo
npm i @clerk/expo@3.5.3-snapshot.v20260622234151 --save-exact
@clerk/expo-passkeys
npm i @clerk/expo-passkeys@1.1.9-snapshot.v20260622234151 --save-exact
@clerk/express
npm i @clerk/express@2.1.31-snapshot.v20260622234151 --save-exact
@clerk/fastify
npm i @clerk/fastify@3.1.41-snapshot.v20260622234151 --save-exact
@clerk/headless
npm i @clerk/headless@0.0.3-snapshot.v20260622234151 --save-exact
@clerk/hono
npm i @clerk/hono@0.1.41-snapshot.v20260622234151 --save-exact
@clerk/localizations
npm i @clerk/localizations@4.9.3-snapshot.v20260622234151 --save-exact
@clerk/msw
npm i @clerk/msw@0.0.39-snapshot.v20260622234151 --save-exact
@clerk/nextjs
npm i @clerk/nextjs@7.5.8-snapshot.v20260622234151 --save-exact
@clerk/nuxt
npm i @clerk/nuxt@2.6.7-snapshot.v20260622234151 --save-exact
@clerk/react
npm i @clerk/react@6.11.0-snapshot.v20260622234151 --save-exact
@clerk/react-router
npm i @clerk/react-router@3.4.8-snapshot.v20260622234151 --save-exact
@clerk/shared
npm i @clerk/shared@4.21.0-snapshot.v20260622234151 --save-exact
@clerk/swingset
npm i @clerk/swingset@0.0.8-snapshot.v20260622234151 --save-exact
@clerk/tanstack-react-start
npm i @clerk/tanstack-react-start@1.4.8-snapshot.v20260622234151 --save-exact
@clerk/testing
npm i @clerk/testing@2.1.6-snapshot.v20260622234151 --save-exact
@clerk/ui
npm i @clerk/ui@1.20.1-snapshot.v20260622234151 --save-exact
@clerk/upgrade
npm i @clerk/upgrade@2.0.5-snapshot.v20260622234151 --save-exact
@clerk/vue
npm i @clerk/vue@2.4.7-snapshot.v20260622234151 --save-exact
@wobsoriano
wobsoriano
marked this pull request as draft
June 22, 2026 23:55
@wobsorianowobsoriano
changed the title
chore(electron): Fix exportschore(electron): Fix cjs/esm exportsJun 23, 2026
@wobsoriano
wobsoriano
marked this pull request as ready for review
June 23, 2026 20:02
jeremy-clerk
jeremy-clerk
approved these changes
Jun 23, 2026
View reviewed changes
@jeremy-clerkjeremy-clerk
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍
@wobsoriano
wobsoriano
merged commit 11cb740
into
mainJun 23, 2026

48 checks passed

@wobsoriano
wobsoriano
deleted the

rob/fix-cjs-esm-issue-electron

branch
June 23, 2026 20:08
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@coderabbitaicoderabbitai[bot]coderabbitai[bot] left review comments
@jeremy-clerkjeremy-clerkjeremy-clerk approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@wobsoriano@jeremy-clerk