Skip to content

chore(expo): Record useSignInWithGoogle usage - #9012

Merged
wobsoriano merged 3 commits into
mainfrom
rob/collect-google-sign-in-hook-usage
Jun 26, 2026
Merged

chore(expo): Record useSignInWithGoogle usage#9012
wobsoriano merged 3 commits into
mainfrom
rob/collect-google-sign-in-hook-usage

Conversation

@wobsoriano

@wobsorianowobsoriano commented Jun 26, 2026

Copy link
Copy Markdown
Member

Description

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

Summary by CodeRabbit

  • Chores
    • Published a patch update for the Expo package.
  • Analytics / Telemetry
    • Added usage tracking for the Google sign-in hook.

@changeset-bot

changeset-botBot commented Jun 26, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: f89edc8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
NameType
@clerk/expoPatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel

vercelBot commented Jun 26, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxReadyReadyPreview, CommentJun 26, 2026 1:58am
swingsetReadyReadyPreview, CommentJun 26, 2026 1:58am

Request Review

@coderabbitai

coderabbitaiBot commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Repository UI (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: a3da36e1-9d07-4193-8b5f-7583ab4f6e83

📥 Commits

Reviewing files that changed from the base of the PR and between e74a4e6 and f89edc8.

📒 Files selected for processing (1)
  • packages/expo/src/hooks/useSignInWithGoogle.shared.ts
🚧 Files skipped from review as they are similar to previous changes (1)
  • packages/expo/src/hooks/useSignInWithGoogle.shared.ts

📝 Walkthrough

Walkthrough

useSignInWithGoogle now records a telemetry event when called, and the Expo package includes a changeset entry for a patch release with that note.

Changes

Expo Google sign-in telemetry

Layer / File(s)Summary
Hook invocation telemetry and release note
packages/expo/src/hooks/useSignInWithGoogle.shared.ts, .changeset/free-ads-fail.md
useSignInWithGoogle imports eventMethodCalled, records a telemetry event through clerk.telemetry?.record(...), and the changeset adds the @clerk/expo patch entry with the usage note.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

Possibly related PRs

  • clerk/javascript#8991: Both PRs modify packages/expo/src/hooks/useSignInWithGoogle.shared.ts inside createUseSignInWithGoogle(...).useSignInWithGoogle().

Suggested reviewers

  • mikepitre

Poem

A bunny hops through sign-in glows,
And whispers where the telemetry flows.
One tiny note, one gentle trace,
A patchy carrot finds its place.
🐇✨

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check nameStatusExplanationResolution
Docstring Coverage⚠️ WarningDocstring coverage is 50.00% which is insufficient. The required threshold is 80.00%.Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title accurately summarizes the main change: tracking useSignInWithGoogle usage in the Expo package.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch

Comment @coderabbitai help to get the list of available commands.

@pkg-pr-new

pkg-pr-newBot commented Jun 26, 2026

Copy link
Copy Markdown

Open in StackBlitz

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@9012

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@9012

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@9012

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@9012

@clerk/electron

npm i https://pkg.pr.new/@clerk/electron@9012

@clerk/electron-passkeys

npm i https://pkg.pr.new/@clerk/electron-passkeys@9012

@clerk/eslint-plugin

npm i https://pkg.pr.new/@clerk/eslint-plugin@9012

@clerk/expo

npm i https://pkg.pr.new/@clerk/expo@9012

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@9012

@clerk/express

npm i https://pkg.pr.new/@clerk/express@9012

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@9012

@clerk/hono

npm i https://pkg.pr.new/@clerk/hono@9012

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@9012

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@9012

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@9012

@clerk/react

npm i https://pkg.pr.new/@clerk/react@9012

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@9012

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@9012

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@9012

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@9012

@clerk/ui

npm i https://pkg.pr.new/@clerk/ui@9012

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@9012

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@9012

commit: f89edc8

@github-actions

github-actionsBot commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

API Changes Report

Generated by Break Check on 2026-06-26T01:59:22.531Z

Summary

MetricCount
Packages analyzed19
Packages with changes0
🔴 Breaking changes0
🟡 Non-breaking changes0
🟢 Additions0

No API Changes Detected

All packages have stable APIs with no detected changes.


Report generated by Break Check

Last ran on f89edc8.

@coderabbitaicoderabbitaiBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@packages/expo/src/hooks/useSignInWithGoogle.shared.ts`:
- Around line 80-81: The telemetry call in useSignInWithGoogle is currently
inside the hook body, so it fires on every render and can duplicate events. Move
clerk.telemetry?.record(eventMethodCalled('useSignInWithGoogle')) into a
one-time mount path for the hook instance, such as a dedicated effect or guarded
initialization, so it only records once per hook usage.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Repository UI (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: a55ef42a-9a77-479e-9403-7ce2166a3d98

📥 Commits

Reviewing files that changed from the base of the PR and between 41e37be and e74a4e6.

📒 Files selected for processing (2)
  • .changeset/free-ads-fail.md
  • packages/expo/src/hooks/useSignInWithGoogle.shared.ts

Comment threadpackages/expo/src/hooks/useSignInWithGoogle.shared.ts
@wobsoriano
wobsoriano merged commit 08157f8 into mainJun 26, 2026
56 checks passed
@wobsoriano
wobsoriano deleted the rob/collect-google-sign-in-hook-usage branch June 26, 2026 02:46
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@wobsoriano@mikepitre
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
chore(expo): Record useSignInWithGoogle usage by wobsoriano · Pull Request #9012 · clerk/javascript · GitHub
Skip to content

chore(expo): Record useSignInWithGoogle usage - #9012

Merged
wobsoriano merged 3 commits into
mainfrom
rob/collect-google-sign-in-hook-usage
Jun 26, 2026
Merged

chore(expo): Record useSignInWithGoogle usage#9012
wobsoriano merged 3 commits into
mainfrom
rob/collect-google-sign-in-hook-usage

Conversation

@wobsoriano

@wobsorianowobsoriano commented Jun 26, 2026

Copy link
Copy Markdown
Member

Description

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

Summary by CodeRabbit

  • Chores
    • Published a patch update for the Expo package.
  • Analytics / Telemetry
    • Added usage tracking for the Google sign-in hook.

@changeset-bot

changeset-botBot commented Jun 26, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: f89edc8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
NameType
@clerk/expoPatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel

vercelBot commented Jun 26, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxReadyReadyPreview, CommentJun 26, 2026 1:58am
swingsetReadyReadyPreview, CommentJun 26, 2026 1:58am

Request Review

@coderabbitai

coderabbitaiBot commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Repository UI (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: a3da36e1-9d07-4193-8b5f-7583ab4f6e83

📥 Commits

Reviewing files that changed from the base of the PR and between e74a4e6 and f89edc8.

📒 Files selected for processing (1)
  • packages/expo/src/hooks/useSignInWithGoogle.shared.ts
🚧 Files skipped from review as they are similar to previous changes (1)
  • packages/expo/src/hooks/useSignInWithGoogle.shared.ts

📝 Walkthrough

Walkthrough

useSignInWithGoogle now records a telemetry event when called, and the Expo package includes a changeset entry for a patch release with that note.

Changes

Expo Google sign-in telemetry

Layer / File(s)Summary
Hook invocation telemetry and release note
packages/expo/src/hooks/useSignInWithGoogle.shared.ts, .changeset/free-ads-fail.md
useSignInWithGoogle imports eventMethodCalled, records a telemetry event through clerk.telemetry?.record(...), and the changeset adds the @clerk/expo patch entry with the usage note.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

Possibly related PRs

  • clerk/javascript#8991: Both PRs modify packages/expo/src/hooks/useSignInWithGoogle.shared.ts inside createUseSignInWithGoogle(...).useSignInWithGoogle().

Suggested reviewers

  • mikepitre

Poem

A bunny hops through sign-in glows,
And whispers where the telemetry flows.
One tiny note, one gentle trace,
A patchy carrot finds its place.
🐇✨

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check nameStatusExplanationResolution
Docstring Coverage⚠️ WarningDocstring coverage is 50.00% which is insufficient. The required threshold is 80.00%.Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title accurately summarizes the main change: tracking useSignInWithGoogle usage in the Expo package.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch

Comment @coderabbitai help to get the list of available commands.

@pkg-pr-new

pkg-pr-newBot commented Jun 26, 2026

Copy link
Copy Markdown

Open in StackBlitz

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@9012

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@9012

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@9012

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@9012

@clerk/electron

npm i https://pkg.pr.new/@clerk/electron@9012

@clerk/electron-passkeys

npm i https://pkg.pr.new/@clerk/electron-passkeys@9012

@clerk/eslint-plugin

npm i https://pkg.pr.new/@clerk/eslint-plugin@9012

@clerk/expo

npm i https://pkg.pr.new/@clerk/expo@9012

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@9012

@clerk/express

npm i https://pkg.pr.new/@clerk/express@9012

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@9012

@clerk/hono

npm i https://pkg.pr.new/@clerk/hono@9012

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@9012

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@9012

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@9012

@clerk/react

npm i https://pkg.pr.new/@clerk/react@9012

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@9012

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@9012

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@9012

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@9012

@clerk/ui

npm i https://pkg.pr.new/@clerk/ui@9012

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@9012

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@9012

commit: f89edc8

@github-actions

github-actionsBot commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

API Changes Report

Generated by Break Check on 2026-06-26T01:59:22.531Z

Summary

MetricCount
Packages analyzed19
Packages with changes0
🔴 Breaking changes0
🟡 Non-breaking changes0
🟢 Additions0

No API Changes Detected

All packages have stable APIs with no detected changes.


Report generated by Break Check

Last ran on f89edc8.

@coderabbitaicoderabbitaiBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@packages/expo/src/hooks/useSignInWithGoogle.shared.ts`:
- Around line 80-81: The telemetry call in useSignInWithGoogle is currently
inside the hook body, so it fires on every render and can duplicate events. Move
clerk.telemetry?.record(eventMethodCalled('useSignInWithGoogle')) into a
one-time mount path for the hook instance, such as a dedicated effect or guarded
initialization, so it only records once per hook usage.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Repository UI (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: a55ef42a-9a77-479e-9403-7ce2166a3d98

📥 Commits

Reviewing files that changed from the base of the PR and between 41e37be and e74a4e6.

📒 Files selected for processing (2)
  • .changeset/free-ads-fail.md
  • packages/expo/src/hooks/useSignInWithGoogle.shared.ts

Comment threadpackages/expo/src/hooks/useSignInWithGoogle.shared.ts
@wobsoriano
wobsoriano merged commit 08157f8 into mainJun 26, 2026
56 checks passed
@wobsoriano
wobsoriano deleted the rob/collect-google-sign-in-hook-usage branch June 26, 2026 02:46
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@wobsoriano@mikepitre
, 'i'); if (__m === '*' || __re.test(location.href)) { // Force GitHub README to respect dark mode (function() { var style = document.createElement('style'); style.textContent = ' .markdown-body { color-scheme: dark light; } .markdown-body pre { background: #161b22 !important; } .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; } .markdown-body table th, .markdown-body table td { border-color: #30363d !important; } .markdown-body img { background: #0d1117; } .markdown-body blockquote { border-left-color: #8b949e; } .markdown-body hr { border-color: #30363d; } '; document.head.appendChild(style); })(); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' chore(expo): Record useSignInWithGoogle usage by wobsoriano · Pull Request #9012 · clerk/javascript · GitHub
Skip to content

chore(expo): Record useSignInWithGoogle usage - #9012

Merged
wobsoriano merged 3 commits into
mainfrom
rob/collect-google-sign-in-hook-usage
Jun 26, 2026
Merged

chore(expo): Record useSignInWithGoogle usage#9012
wobsoriano merged 3 commits into
mainfrom
rob/collect-google-sign-in-hook-usage

Conversation

@wobsoriano

@wobsorianowobsoriano commented Jun 26, 2026

Copy link
Copy Markdown
Member

Description

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

Summary by CodeRabbit

  • Chores
    • Published a patch update for the Expo package.
  • Analytics / Telemetry
    • Added usage tracking for the Google sign-in hook.

@changeset-bot

changeset-botBot commented Jun 26, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: f89edc8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
NameType
@clerk/expoPatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel

vercelBot commented Jun 26, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxReadyReadyPreview, CommentJun 26, 2026 1:58am
swingsetReadyReadyPreview, CommentJun 26, 2026 1:58am

Request Review

@coderabbitai

coderabbitaiBot commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Repository UI (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: a3da36e1-9d07-4193-8b5f-7583ab4f6e83

📥 Commits

Reviewing files that changed from the base of the PR and between e74a4e6 and f89edc8.

📒 Files selected for processing (1)
  • packages/expo/src/hooks/useSignInWithGoogle.shared.ts
🚧 Files skipped from review as they are similar to previous changes (1)
  • packages/expo/src/hooks/useSignInWithGoogle.shared.ts

📝 Walkthrough

Walkthrough

useSignInWithGoogle now records a telemetry event when called, and the Expo package includes a changeset entry for a patch release with that note.

Changes

Expo Google sign-in telemetry

Layer / File(s)Summary
Hook invocation telemetry and release note
packages/expo/src/hooks/useSignInWithGoogle.shared.ts, .changeset/free-ads-fail.md
useSignInWithGoogle imports eventMethodCalled, records a telemetry event through clerk.telemetry?.record(...), and the changeset adds the @clerk/expo patch entry with the usage note.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

Possibly related PRs

  • clerk/javascript#8991: Both PRs modify packages/expo/src/hooks/useSignInWithGoogle.shared.ts inside createUseSignInWithGoogle(...).useSignInWithGoogle().

Suggested reviewers

  • mikepitre

Poem

A bunny hops through sign-in glows,
And whispers where the telemetry flows.
One tiny note, one gentle trace,
A patchy carrot finds its place.
🐇✨

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check nameStatusExplanationResolution
Docstring Coverage⚠️ WarningDocstring coverage is 50.00% which is insufficient. The required threshold is 80.00%.Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title accurately summarizes the main change: tracking useSignInWithGoogle usage in the Expo package.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch

Comment @coderabbitai help to get the list of available commands.

@pkg-pr-new

pkg-pr-newBot commented Jun 26, 2026

Copy link
Copy Markdown

Open in StackBlitz

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@9012

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@9012

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@9012

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@9012

@clerk/electron

npm i https://pkg.pr.new/@clerk/electron@9012

@clerk/electron-passkeys

npm i https://pkg.pr.new/@clerk/electron-passkeys@9012

@clerk/eslint-plugin

npm i https://pkg.pr.new/@clerk/eslint-plugin@9012

@clerk/expo

npm i https://pkg.pr.new/@clerk/expo@9012

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@9012

@clerk/express

npm i https://pkg.pr.new/@clerk/express@9012

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@9012

@clerk/hono

npm i https://pkg.pr.new/@clerk/hono@9012

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@9012

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@9012

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@9012

@clerk/react

npm i https://pkg.pr.new/@clerk/react@9012

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@9012

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@9012

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@9012

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@9012

@clerk/ui

npm i https://pkg.pr.new/@clerk/ui@9012

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@9012

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@9012

commit: f89edc8

@github-actions

github-actionsBot commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

API Changes Report

Generated by Break Check on 2026-06-26T01:59:22.531Z

Summary

MetricCount
Packages analyzed19
Packages with changes0
🔴 Breaking changes0
🟡 Non-breaking changes0
🟢 Additions0

No API Changes Detected

All packages have stable APIs with no detected changes.


Report generated by Break Check

Last ran on f89edc8.

@coderabbitaicoderabbitaiBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@packages/expo/src/hooks/useSignInWithGoogle.shared.ts`:
- Around line 80-81: The telemetry call in useSignInWithGoogle is currently
inside the hook body, so it fires on every render and can duplicate events. Move
clerk.telemetry?.record(eventMethodCalled('useSignInWithGoogle')) into a
one-time mount path for the hook instance, such as a dedicated effect or guarded
initialization, so it only records once per hook usage.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Repository UI (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: a55ef42a-9a77-479e-9403-7ce2166a3d98

📥 Commits

Reviewing files that changed from the base of the PR and between 41e37be and e74a4e6.

📒 Files selected for processing (2)
  • .changeset/free-ads-fail.md
  • packages/expo/src/hooks/useSignInWithGoogle.shared.ts

Comment threadpackages/expo/src/hooks/useSignInWithGoogle.shared.ts
@wobsoriano
wobsoriano merged commit 08157f8 into mainJun 26, 2026
56 checks passed
@wobsoriano
wobsoriano deleted the rob/collect-google-sign-in-hook-usage branch June 26, 2026 02:46
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@wobsoriano@mikepitre
, 'i'); if (__m === '*' || __re.test(location.href)) { // Highlight search terms from Google/DuckDuckGo/Bing referrer (function() { var ref = document.referrer; var terms = []; if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) { var url = new URL(ref); var q = url.searchParams.get('q') || url.searchParams.get('p'); if (q) { terms = q.split(/\s+/).filter(function(t) { return t.length > 2; }); } } if (terms.length === 0) return; var style = document.createElement('style'); style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }'; document.head.appendChild(style); function highlight(node) { if (node.nodeType === 3) { // text node var text = node.textContent; var found = false; terms.forEach(function(term) { var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' chore(expo): Record useSignInWithGoogle usage by wobsoriano · Pull Request #9012 · clerk/javascript · GitHub
Skip to content

chore(expo): Record useSignInWithGoogle usage - #9012

Merged
wobsoriano merged 3 commits into
mainfrom
rob/collect-google-sign-in-hook-usage
Jun 26, 2026
Merged

chore(expo): Record useSignInWithGoogle usage#9012
wobsoriano merged 3 commits into
mainfrom
rob/collect-google-sign-in-hook-usage

Conversation

@wobsoriano

@wobsorianowobsoriano commented Jun 26, 2026

Copy link
Copy Markdown
Member

Description

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

Summary by CodeRabbit

  • Chores
    • Published a patch update for the Expo package.
  • Analytics / Telemetry
    • Added usage tracking for the Google sign-in hook.

@changeset-bot

changeset-botBot commented Jun 26, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: f89edc8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
NameType
@clerk/expoPatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel

vercelBot commented Jun 26, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxReadyReadyPreview, CommentJun 26, 2026 1:58am
swingsetReadyReadyPreview, CommentJun 26, 2026 1:58am

Request Review

@coderabbitai

coderabbitaiBot commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Repository UI (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: a3da36e1-9d07-4193-8b5f-7583ab4f6e83

📥 Commits

Reviewing files that changed from the base of the PR and between e74a4e6 and f89edc8.

📒 Files selected for processing (1)
  • packages/expo/src/hooks/useSignInWithGoogle.shared.ts
🚧 Files skipped from review as they are similar to previous changes (1)
  • packages/expo/src/hooks/useSignInWithGoogle.shared.ts

📝 Walkthrough

Walkthrough

useSignInWithGoogle now records a telemetry event when called, and the Expo package includes a changeset entry for a patch release with that note.

Changes

Expo Google sign-in telemetry

Layer / File(s)Summary
Hook invocation telemetry and release note
packages/expo/src/hooks/useSignInWithGoogle.shared.ts, .changeset/free-ads-fail.md
useSignInWithGoogle imports eventMethodCalled, records a telemetry event through clerk.telemetry?.record(...), and the changeset adds the @clerk/expo patch entry with the usage note.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

Possibly related PRs

  • clerk/javascript#8991: Both PRs modify packages/expo/src/hooks/useSignInWithGoogle.shared.ts inside createUseSignInWithGoogle(...).useSignInWithGoogle().

Suggested reviewers

  • mikepitre

Poem

A bunny hops through sign-in glows,
And whispers where the telemetry flows.
One tiny note, one gentle trace,
A patchy carrot finds its place.
🐇✨

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check nameStatusExplanationResolution
Docstring Coverage⚠️ WarningDocstring coverage is 50.00% which is insufficient. The required threshold is 80.00%.Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title accurately summarizes the main change: tracking useSignInWithGoogle usage in the Expo package.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch

Comment @coderabbitai help to get the list of available commands.

@pkg-pr-new

pkg-pr-newBot commented Jun 26, 2026

Copy link
Copy Markdown

Open in StackBlitz

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@9012

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@9012

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@9012

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@9012

@clerk/electron

npm i https://pkg.pr.new/@clerk/electron@9012

@clerk/electron-passkeys

npm i https://pkg.pr.new/@clerk/electron-passkeys@9012

@clerk/eslint-plugin

npm i https://pkg.pr.new/@clerk/eslint-plugin@9012

@clerk/expo

npm i https://pkg.pr.new/@clerk/expo@9012

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@9012

@clerk/express

npm i https://pkg.pr.new/@clerk/express@9012

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@9012

@clerk/hono

npm i https://pkg.pr.new/@clerk/hono@9012

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@9012

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@9012

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@9012

@clerk/react

npm i https://pkg.pr.new/@clerk/react@9012

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@9012

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@9012

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@9012

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@9012

@clerk/ui

npm i https://pkg.pr.new/@clerk/ui@9012

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@9012

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@9012

commit: f89edc8

@github-actions

github-actionsBot commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

API Changes Report

Generated by Break Check on 2026-06-26T01:59:22.531Z

Summary

MetricCount
Packages analyzed19
Packages with changes0
🔴 Breaking changes0
🟡 Non-breaking changes0
🟢 Additions0

No API Changes Detected

All packages have stable APIs with no detected changes.


Report generated by Break Check

Last ran on f89edc8.

@coderabbitaicoderabbitaiBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@packages/expo/src/hooks/useSignInWithGoogle.shared.ts`:
- Around line 80-81: The telemetry call in useSignInWithGoogle is currently
inside the hook body, so it fires on every render and can duplicate events. Move
clerk.telemetry?.record(eventMethodCalled('useSignInWithGoogle')) into a
one-time mount path for the hook instance, such as a dedicated effect or guarded
initialization, so it only records once per hook usage.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Repository UI (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: a55ef42a-9a77-479e-9403-7ce2166a3d98

📥 Commits

Reviewing files that changed from the base of the PR and between 41e37be and e74a4e6.

📒 Files selected for processing (2)
  • .changeset/free-ads-fail.md
  • packages/expo/src/hooks/useSignInWithGoogle.shared.ts

Comment threadpackages/expo/src/hooks/useSignInWithGoogle.shared.ts
@wobsoriano
wobsoriano merged commit 08157f8 into mainJun 26, 2026
56 checks passed
@wobsoriano
wobsoriano deleted the rob/collect-google-sign-in-hook-usage branch June 26, 2026 02:46
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@wobsoriano@mikepitre
, 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ' chore(expo): Record useSignInWithGoogle usage by wobsoriano · Pull Request #9012 · clerk/javascript · GitHub
Skip to content

chore(expo): Record useSignInWithGoogle usage - #9012

Merged
wobsoriano merged 3 commits into
mainfrom
rob/collect-google-sign-in-hook-usage
Jun 26, 2026
Merged

chore(expo): Record useSignInWithGoogle usage#9012
wobsoriano merged 3 commits into
mainfrom
rob/collect-google-sign-in-hook-usage

Conversation

@wobsoriano

@wobsorianowobsoriano commented Jun 26, 2026

Copy link
Copy Markdown
Member

Description

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

Summary by CodeRabbit

  • Chores
    • Published a patch update for the Expo package.
  • Analytics / Telemetry
    • Added usage tracking for the Google sign-in hook.

@changeset-bot

changeset-botBot commented Jun 26, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: f89edc8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
NameType
@clerk/expoPatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel

vercelBot commented Jun 26, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxReadyReadyPreview, CommentJun 26, 2026 1:58am
swingsetReadyReadyPreview, CommentJun 26, 2026 1:58am

Request Review

@coderabbitai

coderabbitaiBot commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Repository UI (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: a3da36e1-9d07-4193-8b5f-7583ab4f6e83

📥 Commits

Reviewing files that changed from the base of the PR and between e74a4e6 and f89edc8.

📒 Files selected for processing (1)
  • packages/expo/src/hooks/useSignInWithGoogle.shared.ts
🚧 Files skipped from review as they are similar to previous changes (1)
  • packages/expo/src/hooks/useSignInWithGoogle.shared.ts

📝 Walkthrough

Walkthrough

useSignInWithGoogle now records a telemetry event when called, and the Expo package includes a changeset entry for a patch release with that note.

Changes

Expo Google sign-in telemetry

Layer / File(s)Summary
Hook invocation telemetry and release note
packages/expo/src/hooks/useSignInWithGoogle.shared.ts, .changeset/free-ads-fail.md
useSignInWithGoogle imports eventMethodCalled, records a telemetry event through clerk.telemetry?.record(...), and the changeset adds the @clerk/expo patch entry with the usage note.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

Possibly related PRs

  • clerk/javascript#8991: Both PRs modify packages/expo/src/hooks/useSignInWithGoogle.shared.ts inside createUseSignInWithGoogle(...).useSignInWithGoogle().

Suggested reviewers

  • mikepitre

Poem

A bunny hops through sign-in glows,
And whispers where the telemetry flows.
One tiny note, one gentle trace,
A patchy carrot finds its place.
🐇✨

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check nameStatusExplanationResolution
Docstring Coverage⚠️ WarningDocstring coverage is 50.00% which is insufficient. The required threshold is 80.00%.Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title accurately summarizes the main change: tracking useSignInWithGoogle usage in the Expo package.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch

Comment @coderabbitai help to get the list of available commands.

@pkg-pr-new

pkg-pr-newBot commented Jun 26, 2026

Copy link
Copy Markdown

Open in StackBlitz

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@9012

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@9012

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@9012

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@9012

@clerk/electron

npm i https://pkg.pr.new/@clerk/electron@9012

@clerk/electron-passkeys

npm i https://pkg.pr.new/@clerk/electron-passkeys@9012

@clerk/eslint-plugin

npm i https://pkg.pr.new/@clerk/eslint-plugin@9012

@clerk/expo

npm i https://pkg.pr.new/@clerk/expo@9012

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@9012

@clerk/express

npm i https://pkg.pr.new/@clerk/express@9012

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@9012

@clerk/hono

npm i https://pkg.pr.new/@clerk/hono@9012

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@9012

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@9012

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@9012

@clerk/react

npm i https://pkg.pr.new/@clerk/react@9012

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@9012

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@9012

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@9012

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@9012

@clerk/ui

npm i https://pkg.pr.new/@clerk/ui@9012

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@9012

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@9012

commit: f89edc8

@github-actions

github-actionsBot commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

API Changes Report

Generated by Break Check on 2026-06-26T01:59:22.531Z

Summary

MetricCount
Packages analyzed19
Packages with changes0
🔴 Breaking changes0
🟡 Non-breaking changes0
🟢 Additions0

No API Changes Detected

All packages have stable APIs with no detected changes.


Report generated by Break Check

Last ran on f89edc8.

@coderabbitaicoderabbitaiBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@packages/expo/src/hooks/useSignInWithGoogle.shared.ts`:
- Around line 80-81: The telemetry call in useSignInWithGoogle is currently
inside the hook body, so it fires on every render and can duplicate events. Move
clerk.telemetry?.record(eventMethodCalled('useSignInWithGoogle')) into a
one-time mount path for the hook instance, such as a dedicated effect or guarded
initialization, so it only records once per hook usage.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Repository UI (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: a55ef42a-9a77-479e-9403-7ce2166a3d98

📥 Commits

Reviewing files that changed from the base of the PR and between 41e37be and e74a4e6.

📒 Files selected for processing (2)
  • .changeset/free-ads-fail.md
  • packages/expo/src/hooks/useSignInWithGoogle.shared.ts

Comment threadpackages/expo/src/hooks/useSignInWithGoogle.shared.ts
@wobsoriano
wobsoriano merged commit 08157f8 into mainJun 26, 2026
56 checks passed
@wobsoriano
wobsoriano deleted the rob/collect-google-sign-in-hook-usage branch June 26, 2026 02:46
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@wobsoriano@mikepitre
, 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' chore(expo): Record useSignInWithGoogle usage by wobsoriano · Pull Request #9012 · clerk/javascript · GitHub
Skip to content

chore(expo): Record useSignInWithGoogle usage - #9012

Merged
wobsoriano merged 3 commits into
mainfrom
rob/collect-google-sign-in-hook-usage
Jun 26, 2026
Merged

chore(expo): Record useSignInWithGoogle usage#9012
wobsoriano merged 3 commits into
mainfrom
rob/collect-google-sign-in-hook-usage

Conversation

@wobsoriano

@wobsorianowobsoriano commented Jun 26, 2026

Copy link
Copy Markdown
Member

Description

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

Summary by CodeRabbit

  • Chores
    • Published a patch update for the Expo package.
  • Analytics / Telemetry
    • Added usage tracking for the Google sign-in hook.

@changeset-bot

changeset-botBot commented Jun 26, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: f89edc8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
NameType
@clerk/expoPatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel

vercelBot commented Jun 26, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxReadyReadyPreview, CommentJun 26, 2026 1:58am
swingsetReadyReadyPreview, CommentJun 26, 2026 1:58am

Request Review

@coderabbitai

coderabbitaiBot commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Repository UI (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: a3da36e1-9d07-4193-8b5f-7583ab4f6e83

📥 Commits

Reviewing files that changed from the base of the PR and between e74a4e6 and f89edc8.

📒 Files selected for processing (1)
  • packages/expo/src/hooks/useSignInWithGoogle.shared.ts
🚧 Files skipped from review as they are similar to previous changes (1)
  • packages/expo/src/hooks/useSignInWithGoogle.shared.ts

📝 Walkthrough

Walkthrough

useSignInWithGoogle now records a telemetry event when called, and the Expo package includes a changeset entry for a patch release with that note.

Changes

Expo Google sign-in telemetry

Layer / File(s)Summary
Hook invocation telemetry and release note
packages/expo/src/hooks/useSignInWithGoogle.shared.ts, .changeset/free-ads-fail.md
useSignInWithGoogle imports eventMethodCalled, records a telemetry event through clerk.telemetry?.record(...), and the changeset adds the @clerk/expo patch entry with the usage note.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

Possibly related PRs

  • clerk/javascript#8991: Both PRs modify packages/expo/src/hooks/useSignInWithGoogle.shared.ts inside createUseSignInWithGoogle(...).useSignInWithGoogle().

Suggested reviewers

  • mikepitre

Poem

A bunny hops through sign-in glows,
And whispers where the telemetry flows.
One tiny note, one gentle trace,
A patchy carrot finds its place.
🐇✨

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check nameStatusExplanationResolution
Docstring Coverage⚠️ WarningDocstring coverage is 50.00% which is insufficient. The required threshold is 80.00%.Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title accurately summarizes the main change: tracking useSignInWithGoogle usage in the Expo package.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch

Comment @coderabbitai help to get the list of available commands.

@pkg-pr-new

pkg-pr-newBot commented Jun 26, 2026

Copy link
Copy Markdown

Open in StackBlitz

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@9012

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@9012

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@9012

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@9012

@clerk/electron

npm i https://pkg.pr.new/@clerk/electron@9012

@clerk/electron-passkeys

npm i https://pkg.pr.new/@clerk/electron-passkeys@9012

@clerk/eslint-plugin

npm i https://pkg.pr.new/@clerk/eslint-plugin@9012

@clerk/expo

npm i https://pkg.pr.new/@clerk/expo@9012

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@9012

@clerk/express

npm i https://pkg.pr.new/@clerk/express@9012

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@9012

@clerk/hono

npm i https://pkg.pr.new/@clerk/hono@9012

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@9012

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@9012

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@9012

@clerk/react

npm i https://pkg.pr.new/@clerk/react@9012

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@9012

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@9012

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@9012

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@9012

@clerk/ui

npm i https://pkg.pr.new/@clerk/ui@9012

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@9012

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@9012

commit: f89edc8

@github-actions

github-actionsBot commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

API Changes Report

Generated by Break Check on 2026-06-26T01:59:22.531Z

Summary

MetricCount
Packages analyzed19
Packages with changes0
🔴 Breaking changes0
🟡 Non-breaking changes0
🟢 Additions0

No API Changes Detected

All packages have stable APIs with no detected changes.


Report generated by Break Check

Last ran on f89edc8.

@coderabbitaicoderabbitaiBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@packages/expo/src/hooks/useSignInWithGoogle.shared.ts`:
- Around line 80-81: The telemetry call in useSignInWithGoogle is currently
inside the hook body, so it fires on every render and can duplicate events. Move
clerk.telemetry?.record(eventMethodCalled('useSignInWithGoogle')) into a
one-time mount path for the hook instance, such as a dedicated effect or guarded
initialization, so it only records once per hook usage.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Repository UI (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: a55ef42a-9a77-479e-9403-7ce2166a3d98

📥 Commits

Reviewing files that changed from the base of the PR and between 41e37be and e74a4e6.

📒 Files selected for processing (2)
  • .changeset/free-ads-fail.md
  • packages/expo/src/hooks/useSignInWithGoogle.shared.ts

Comment threadpackages/expo/src/hooks/useSignInWithGoogle.shared.ts
@wobsoriano
wobsoriano merged commit 08157f8 into mainJun 26, 2026
56 checks passed
@wobsoriano
wobsoriano deleted the rob/collect-google-sign-in-hook-usage branch June 26, 2026 02:46
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@wobsoriano@mikepitre
, 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' chore(expo): Record useSignInWithGoogle usage by wobsoriano · Pull Request #9012 · clerk/javascript · GitHub
Skip to content

chore(expo): Record useSignInWithGoogle usage - #9012

Merged
wobsoriano merged 3 commits into
mainfrom
rob/collect-google-sign-in-hook-usage
Jun 26, 2026
Merged

chore(expo): Record useSignInWithGoogle usage#9012
wobsoriano merged 3 commits into
mainfrom
rob/collect-google-sign-in-hook-usage

Conversation

@wobsoriano

@wobsorianowobsoriano commented Jun 26, 2026

Copy link
Copy Markdown
Member

Description

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

Summary by CodeRabbit

  • Chores
    • Published a patch update for the Expo package.
  • Analytics / Telemetry
    • Added usage tracking for the Google sign-in hook.

@changeset-bot

changeset-botBot commented Jun 26, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: f89edc8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
NameType
@clerk/expoPatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel

vercelBot commented Jun 26, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxReadyReadyPreview, CommentJun 26, 2026 1:58am
swingsetReadyReadyPreview, CommentJun 26, 2026 1:58am

Request Review

@coderabbitai

coderabbitaiBot commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Repository UI (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: a3da36e1-9d07-4193-8b5f-7583ab4f6e83

📥 Commits

Reviewing files that changed from the base of the PR and between e74a4e6 and f89edc8.

📒 Files selected for processing (1)
  • packages/expo/src/hooks/useSignInWithGoogle.shared.ts
🚧 Files skipped from review as they are similar to previous changes (1)
  • packages/expo/src/hooks/useSignInWithGoogle.shared.ts

📝 Walkthrough

Walkthrough

useSignInWithGoogle now records a telemetry event when called, and the Expo package includes a changeset entry for a patch release with that note.

Changes

Expo Google sign-in telemetry

Layer / File(s)Summary
Hook invocation telemetry and release note
packages/expo/src/hooks/useSignInWithGoogle.shared.ts, .changeset/free-ads-fail.md
useSignInWithGoogle imports eventMethodCalled, records a telemetry event through clerk.telemetry?.record(...), and the changeset adds the @clerk/expo patch entry with the usage note.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

Possibly related PRs

  • clerk/javascript#8991: Both PRs modify packages/expo/src/hooks/useSignInWithGoogle.shared.ts inside createUseSignInWithGoogle(...).useSignInWithGoogle().

Suggested reviewers

  • mikepitre

Poem

A bunny hops through sign-in glows,
And whispers where the telemetry flows.
One tiny note, one gentle trace,
A patchy carrot finds its place.
🐇✨

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check nameStatusExplanationResolution
Docstring Coverage⚠️ WarningDocstring coverage is 50.00% which is insufficient. The required threshold is 80.00%.Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title accurately summarizes the main change: tracking useSignInWithGoogle usage in the Expo package.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch

Comment @coderabbitai help to get the list of available commands.

@pkg-pr-new

pkg-pr-newBot commented Jun 26, 2026

Copy link
Copy Markdown

Open in StackBlitz

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@9012

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@9012

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@9012

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@9012

@clerk/electron

npm i https://pkg.pr.new/@clerk/electron@9012

@clerk/electron-passkeys

npm i https://pkg.pr.new/@clerk/electron-passkeys@9012

@clerk/eslint-plugin

npm i https://pkg.pr.new/@clerk/eslint-plugin@9012

@clerk/expo

npm i https://pkg.pr.new/@clerk/expo@9012

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@9012

@clerk/express

npm i https://pkg.pr.new/@clerk/express@9012

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@9012

@clerk/hono

npm i https://pkg.pr.new/@clerk/hono@9012

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@9012

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@9012

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@9012

@clerk/react

npm i https://pkg.pr.new/@clerk/react@9012

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@9012

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@9012

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@9012

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@9012

@clerk/ui

npm i https://pkg.pr.new/@clerk/ui@9012

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@9012

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@9012

commit: f89edc8

@github-actions

github-actionsBot commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

API Changes Report

Generated by Break Check on 2026-06-26T01:59:22.531Z

Summary

MetricCount
Packages analyzed19
Packages with changes0
🔴 Breaking changes0
🟡 Non-breaking changes0
🟢 Additions0

No API Changes Detected

All packages have stable APIs with no detected changes.


Report generated by Break Check

Last ran on f89edc8.

@coderabbitaicoderabbitaiBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@packages/expo/src/hooks/useSignInWithGoogle.shared.ts`:
- Around line 80-81: The telemetry call in useSignInWithGoogle is currently
inside the hook body, so it fires on every render and can duplicate events. Move
clerk.telemetry?.record(eventMethodCalled('useSignInWithGoogle')) into a
one-time mount path for the hook instance, such as a dedicated effect or guarded
initialization, so it only records once per hook usage.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Repository UI (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: a55ef42a-9a77-479e-9403-7ce2166a3d98

📥 Commits

Reviewing files that changed from the base of the PR and between 41e37be and e74a4e6.

📒 Files selected for processing (2)
  • .changeset/free-ads-fail.md
  • packages/expo/src/hooks/useSignInWithGoogle.shared.ts

Comment threadpackages/expo/src/hooks/useSignInWithGoogle.shared.ts
@wobsoriano
wobsoriano merged commit 08157f8 into mainJun 26, 2026
56 checks passed
@wobsoriano
wobsoriano deleted the rob/collect-google-sign-in-hook-usage branch June 26, 2026 02:46
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@wobsoriano@mikepitre
, 'i'); if (__m === '*' || __re.test(location.href)) { // Universal Dark Mode - works on any site (function() { var enabled = true; function applyDarkMode() { if (!enabled) return; // Create style element if it doesn't exist var style = document.getElementById('universal-dark-mode-style'); if (!style) { style = document.createElement('style'); style.id = 'universal-dark-mode-style'; document.head.appendChild(style); } // Dark mode CSS - inverts colors but preserves images/video style.textContent = ' /* Invert everything except media */ html { filter: invert(1) hue-rotate(180deg) !important; background: #1a1a2e !important; } /* Restore images, videos, iframes, canvas */ img, video, iframe, canvas, svg, picture, [style*="background-image"] { filter: invert(1) hue-rotate(180deg) !important; } /* Preserve specific elements that should not be inverted */ .no-dark-mode, .no-dark-mode *, [data-theme="light"], [data-theme="light"], .ace_editor, .ace_editor *, .CodeMirror, .CodeMirror *, .monaco-editor, .monaco-editor *, .markdown-body pre, .markdown-body pre *, .highlight, .highlight *, pre code, pre code * { filter: none !important; } /* Fix common UI elements */ .modal, .popup, .dropdown-menu, .tooltip, .popover { filter: invert(1) hue-rotate(180deg) !important; background: #2d2d44 !important; border-color: #444 !important; } /* Scrollbars */ ::-webkit-scrollbar { background: #1a1a2e !important; } ::-webkit-scrollbar-thumb { background: #444 !important; } ::-webkit-scrollbar-thumb:hover { background: #555 !important; } /* Selection */ ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; } ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; } '; } function removeDarkMode() { var style = document.getElementById('universal-dark-mode-style'); if (style) style.remove(); } // Toggle with Alt+Shift+D document.addEventListener('keydown', function(e) { if (e.altKey && e.shiftKey && e.key === 'D') { e.preventDefault(); enabled = !enabled; if (enabled) { applyDarkMode(); console.log('[Universal Dark Mode] Enabled'); } else { removeDarkMode(); console.log('[Universal Dark Mode] Disabled'); } } }); // Apply on load applyDarkMode(); // Re-apply on dynamic content var observer = new MutationObserver(function(mutations) { if (enabled && !document.getElementById('universal-dark-mode-style')) { applyDarkMode(); } }); observer.observe(document.head, { childList: true }); console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle'); })(); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })(); chore(expo): Record useSignInWithGoogle usage by wobsoriano · Pull Request #9012 · clerk/javascript · GitHub
Skip to content

chore(expo): Record useSignInWithGoogle usage - #9012

Merged
wobsoriano merged 3 commits into
mainfrom
rob/collect-google-sign-in-hook-usage
Jun 26, 2026
Merged

chore(expo): Record useSignInWithGoogle usage#9012
wobsoriano merged 3 commits into
mainfrom
rob/collect-google-sign-in-hook-usage

Conversation

@wobsoriano

@wobsorianowobsoriano commented Jun 26, 2026

Copy link
Copy Markdown
Member

Description

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

Summary by CodeRabbit

  • Chores
    • Published a patch update for the Expo package.
  • Analytics / Telemetry
    • Added usage tracking for the Google sign-in hook.

@changeset-bot

changeset-botBot commented Jun 26, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: f89edc8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
NameType
@clerk/expoPatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel

vercelBot commented Jun 26, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxReadyReadyPreview, CommentJun 26, 2026 1:58am
swingsetReadyReadyPreview, CommentJun 26, 2026 1:58am

Request Review

@coderabbitai

coderabbitaiBot commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Repository UI (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: a3da36e1-9d07-4193-8b5f-7583ab4f6e83

📥 Commits

Reviewing files that changed from the base of the PR and between e74a4e6 and f89edc8.

📒 Files selected for processing (1)
  • packages/expo/src/hooks/useSignInWithGoogle.shared.ts
🚧 Files skipped from review as they are similar to previous changes (1)
  • packages/expo/src/hooks/useSignInWithGoogle.shared.ts

📝 Walkthrough

Walkthrough

useSignInWithGoogle now records a telemetry event when called, and the Expo package includes a changeset entry for a patch release with that note.

Changes

Expo Google sign-in telemetry

Layer / File(s)Summary
Hook invocation telemetry and release note
packages/expo/src/hooks/useSignInWithGoogle.shared.ts, .changeset/free-ads-fail.md
useSignInWithGoogle imports eventMethodCalled, records a telemetry event through clerk.telemetry?.record(...), and the changeset adds the @clerk/expo patch entry with the usage note.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

Possibly related PRs

  • clerk/javascript#8991: Both PRs modify packages/expo/src/hooks/useSignInWithGoogle.shared.ts inside createUseSignInWithGoogle(...).useSignInWithGoogle().

Suggested reviewers

  • mikepitre

Poem

A bunny hops through sign-in glows,
And whispers where the telemetry flows.
One tiny note, one gentle trace,
A patchy carrot finds its place.
🐇✨

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check nameStatusExplanationResolution
Docstring Coverage⚠️ WarningDocstring coverage is 50.00% which is insufficient. The required threshold is 80.00%.Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title accurately summarizes the main change: tracking useSignInWithGoogle usage in the Expo package.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch

Comment @coderabbitai help to get the list of available commands.

@pkg-pr-new

pkg-pr-newBot commented Jun 26, 2026

Copy link
Copy Markdown

Open in StackBlitz

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@9012

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@9012

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@9012

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@9012

@clerk/electron

npm i https://pkg.pr.new/@clerk/electron@9012

@clerk/electron-passkeys

npm i https://pkg.pr.new/@clerk/electron-passkeys@9012

@clerk/eslint-plugin

npm i https://pkg.pr.new/@clerk/eslint-plugin@9012

@clerk/expo

npm i https://pkg.pr.new/@clerk/expo@9012

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@9012

@clerk/express

npm i https://pkg.pr.new/@clerk/express@9012

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@9012

@clerk/hono

npm i https://pkg.pr.new/@clerk/hono@9012

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@9012

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@9012

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@9012

@clerk/react

npm i https://pkg.pr.new/@clerk/react@9012

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@9012

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@9012

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@9012

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@9012

@clerk/ui

npm i https://pkg.pr.new/@clerk/ui@9012

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@9012

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@9012

commit: f89edc8

@github-actions

github-actionsBot commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

API Changes Report

Generated by Break Check on 2026-06-26T01:59:22.531Z

Summary

MetricCount
Packages analyzed19
Packages with changes0
🔴 Breaking changes0
🟡 Non-breaking changes0
🟢 Additions0

No API Changes Detected

All packages have stable APIs with no detected changes.


Report generated by Break Check

Last ran on f89edc8.

@coderabbitaicoderabbitaiBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@packages/expo/src/hooks/useSignInWithGoogle.shared.ts`:
- Around line 80-81: The telemetry call in useSignInWithGoogle is currently
inside the hook body, so it fires on every render and can duplicate events. Move
clerk.telemetry?.record(eventMethodCalled('useSignInWithGoogle')) into a
one-time mount path for the hook instance, such as a dedicated effect or guarded
initialization, so it only records once per hook usage.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Repository UI (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: a55ef42a-9a77-479e-9403-7ce2166a3d98

📥 Commits

Reviewing files that changed from the base of the PR and between 41e37be and e74a4e6.

📒 Files selected for processing (2)
  • .changeset/free-ads-fail.md
  • packages/expo/src/hooks/useSignInWithGoogle.shared.ts

Comment threadpackages/expo/src/hooks/useSignInWithGoogle.shared.ts
@wobsoriano
wobsoriano merged commit 08157f8 into mainJun 26, 2026
56 checks passed
@wobsoriano
wobsoriano deleted the rob/collect-google-sign-in-hook-usage branch June 26, 2026 02:46
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@wobsoriano@mikepitre