Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .changeset/mosaic-org-section-gating.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
---
---
Comment thread
alexcarpenter marked this conversation as resolved.
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
/** @jsxImportSource @emotion/react */
import { useMachine } from '@clerk/ui/mosaic/machine/useMachine';
import { deleteOrgMachine } from '@clerk/ui/mosaic/sections/delete-organization-machine';
import { DeleteOrganizationView } from '@clerk/ui/mosaic/sections/delete-organization-view';
import { deleteOrgMachine } from '@clerk/ui/mosaic/sections/delete-organization.machine';
import { DeleteOrganizationView } from '@clerk/ui/mosaic/sections/delete-organization.view';

import type { StoryMeta } from '@/lib/types';

Expand Down
4 changes: 2 additions & 2 deletions packages/swingset/src/stories/leave-organization.stories.tsx
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
/** @jsxImportSource @emotion/react */
import { useMachine } from '@clerk/ui/mosaic/machine/useMachine';
import { leaveOrgMachine } from '@clerk/ui/mosaic/sections/leave-organization-machine';
import { LeaveOrganizationView } from '@clerk/ui/mosaic/sections/leave-organization-view';
import { leaveOrgMachine } from '@clerk/ui/mosaic/sections/leave-organization.machine';
import { LeaveOrganizationView } from '@clerk/ui/mosaic/sections/leave-organization.view';

import type { StoryMeta } from '@/lib/types';

Expand Down
Original file line numberDiff line numberDiff line change
@@ -1,29 +1,38 @@
import { act, fireEvent, render, screen } from '@testing-library/react';
import React from 'react';
import { afterEach, beforeEach, describe, expect, it, vi } from 'vitest';

import { deferred } from '../../machines/__tests__/test-utils';
import { useDeleteOrganizationController } from '../delete-organization-controller';
import { useDeleteOrganizationController } from '../delete-organization.controller';

const ORG_NAME = 'Acme Inc';

let destroy: ReturnType<typeof vi.fn>;
let revalidate: ReturnType<typeof vi.fn>;
let organization: { id: string; name: string; destroy: () => Promise<void> } | null;
let checkAuthorization: ReturnType<typeof vi.fn>;
let isLoaded: boolean;
let isSessionLoaded: boolean;
let organization: { id: string; name: string; destroy: () => Promise<void>; adminDeleteEnabled: boolean } | null;

vi.mock('@clerk/shared/react', async importOriginal => {
const actual = await importOriginal<typeof import('@clerk/shared/react')>();
return {
...actual,
useOrganization: () => ({ isLoaded: true, organization, membership: null }),
useOrganization: () => ({ isLoaded, organization, membership: null }),
useOrganizationList: () => ({ userMemberships: { revalidate } }),
useSession: () => ({
isLoaded: isSessionLoaded,
session: isSessionLoaded ? { id: 'sess_1', checkAuthorization } : undefined,
}),
};
});

beforeEach(() => {
destroy = vi.fn();
revalidate = vi.fn().mockResolvedValue(undefined);
organization = { id: 'org_1', name: ORG_NAME, destroy };
checkAuthorization = vi.fn().mockReturnValue(true);
isLoaded = true;
isSessionLoaded = true;
organization = { id: 'org_1', name: ORG_NAME, destroy, adminDeleteEnabled: true };
});

afterEach(() => {
Expand All@@ -33,7 +42,7 @@ afterEach(() => {
function Harness() {
const controller = useDeleteOrganizationController();
if (controller.status !== 'ready') {
return <output data-testid='state'>loading</output>;
return <output data-testid='state'>{controller.status}</output>;
}
return (
<div>
Expand All@@ -53,6 +62,46 @@ function openAndConfirm() {
}

describe('useDeleteOrganizationController', () => {
it('is loading until useOrganization is loaded', () => {
isLoaded = false;

render(<Harness />);

expect(screen.getByTestId('state')).toHaveTextContent('loading');
});

it('is loading until the session is loaded', () => {
isSessionLoaded = false;

render(<Harness />);

expect(screen.getByTestId('state')).toHaveTextContent('loading');
expect(checkAuthorization).not.toHaveBeenCalled();
});

it('is ready when the user can delete and admin delete is enabled', () => {
render(<Harness />);

expect(screen.getByTestId('state')).toHaveTextContent('idle');
expect(checkAuthorization).toHaveBeenCalledWith({ permission: 'org:sys_profile:delete' });
});

it('is hidden when the user lacks the delete permission', () => {
checkAuthorization.mockReturnValue(false);

render(<Harness />);

expect(screen.getByTestId('state')).toHaveTextContent('hidden');
});

it('is hidden when admin delete is disabled', () => {
organization = { id: 'org_1', name: ORG_NAME, destroy, adminDeleteEnabled: false };

render(<Harness />);

expect(screen.getByTestId('state')).toHaveTextContent('hidden');
});

it('drives CONFIRM → deleting → resolve → deleted', async () => {
const gate = deferred<void>();
destroy.mockReturnValue(gate.promise);
Expand Down
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
import { describe, expect, it, vi } from 'vitest';

import { createActor } from '../../machine/createActor';
import { deleteOrgMachine } from '../delete-organization-machine';
import { deleteOrgMachine } from '../delete-organization.machine';

const tick = () => new Promise<void>(resolve => setTimeout(resolve, 0));

Expand Down
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,10 @@
import { fireEvent, render, screen } from '@testing-library/react';
import { describe, expect, it, vi } from 'vitest';

import { MosaicProvider } from '../../MosaicProvider';
import type { Snapshot } from '../../machine/types';
import type { DeleteOrgContext } from '../delete-organization-machine';
import { DeleteOrganizationView } from '../delete-organization-view';
import { MosaicProvider } from '../../MosaicProvider';
import type { DeleteOrgContext } from '../delete-organization.machine';
import { DeleteOrganizationView } from '../delete-organization.view';

function renderView(snapshot: Snapshot<DeleteOrgContext>, send = vi.fn(), canSubmit = false) {
render(
Expand Down
Original file line numberDiff line numberDiff line change
@@ -1,29 +1,30 @@
import { act, fireEvent, render, screen } from '@testing-library/react';
import React from 'react';
import { afterEach, beforeEach, describe, expect, it, vi } from 'vitest';

import { deferred } from '../../machines/__tests__/test-utils';
import { useLeaveOrganizationController } from '../leave-organization-controller';
import { useLeaveOrganizationController } from '../leave-organization.controller';

const ORG_NAME = 'Acme Inc';

let destroy: ReturnType<typeof vi.fn>;
let revalidate: ReturnType<typeof vi.fn>;
let isLoaded: boolean;
let organization: { id: string; name: string } | null;
let membership: { id: string; destroy: () => Promise<void> } | null;
let membership: { id: string; destroy: () => Promise<void> } | null | undefined;

vi.mock('@clerk/shared/react', async importOriginal => {
const actual = await importOriginal<typeof import('@clerk/shared/react')>();
return {
...actual,
useOrganization: () => ({ isLoaded: true, organization, membership }),
useOrganization: () => ({ isLoaded, organization, membership }),
useOrganizationList: () => ({ userMemberships: { revalidate } }),
};
});

beforeEach(() => {
destroy = vi.fn();
revalidate = vi.fn().mockResolvedValue(undefined);
isLoaded = true;
organization = { id: 'org_1', name: ORG_NAME };
membership = { id: 'mem_1', destroy };
});
Expand All@@ -35,7 +36,7 @@ afterEach(() => {
function Harness() {
const controller = useLeaveOrganizationController();
if (controller.status !== 'ready') {
return <output data-testid='state'>loading</output>;
return <output data-testid='state'>{controller.status}</output>;
}
return (
<div>
Expand All@@ -55,6 +56,38 @@ function openAndConfirm() {
}

describe('useLeaveOrganizationController', () => {
it('is loading until useOrganization is loaded', () => {
isLoaded = false;

render(<Harness />);

expect(screen.getByTestId('state')).toHaveTextContent('loading');
});

it('is loading while membership is still resolving', () => {
membership = undefined;

render(<Harness />);

expect(screen.getByTestId('state')).toHaveTextContent('loading');
});

it('is hidden when there is no active organization', () => {
organization = null;

render(<Harness />);

expect(screen.getByTestId('state')).toHaveTextContent('hidden');
});

it('is hidden when there is no membership', () => {
membership = null;

render(<Harness />);

expect(screen.getByTestId('state')).toHaveTextContent('hidden');
});

it('drives CONFIRM → leaving → resolve → left', async () => {
const gate = deferred<void>();
destroy.mockReturnValue(gate.promise);
Expand Down
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
import { describe, expect, it, vi } from 'vitest';

import { createActor } from '../../machine/createActor';
import { leaveOrgMachine } from '../leave-organization-machine';
import { leaveOrgMachine } from '../leave-organization.machine';

const tick = () => new Promise<void>(resolve => setTimeout(resolve, 0));

Expand Down
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,10 @@
import { fireEvent, render, screen } from '@testing-library/react';
import { describe, expect, it, vi } from 'vitest';

import { MosaicProvider } from '../../MosaicProvider';
import type { Snapshot } from '../../machine/types';
import type { LeaveOrgContext } from '../leave-organization-machine';
import { LeaveOrganizationView } from '../leave-organization-view';
import { MosaicProvider } from '../../MosaicProvider';
import type { LeaveOrgContext } from '../leave-organization.machine';
import { LeaveOrganizationView } from '../leave-organization.view';

function renderView(snapshot: Snapshot<LeaveOrgContext>, send = vi.fn(), canSubmit = false) {
render(
Expand Down

This file was deleted.

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,55 @@
import { useOrganization, useOrganizationList, useSession } from '@clerk/shared/react';

import type { Snapshot } from '../machine/types';
import { useMachine } from '../machine/useMachine';
import type { DeleteOrgContext, DeleteOrgEvent } from './delete-organization.machine';
import { deleteOrgMachine } from './delete-organization.machine';

type DeleteOrganizationController =
| { status: 'loading' }
| { status: 'hidden' }
| {
status: 'ready';
snapshot: Snapshot<DeleteOrgContext>;
send: (event: DeleteOrgEvent) => void;
canSubmit: boolean;
};

export function useDeleteOrganizationController(): DeleteOrganizationController {
const { isLoaded: isOrganizationLoaded, organization } = useOrganization();
const { isLoaded: isSessionLoaded, session } = useSession();
const { userMemberships } = useOrganizationList({ userMemberships: true });

const [snapshot, send, actor] = useMachine(deleteOrgMachine, {
context: {
organizationName: organization?.name ?? '',
destroyOrganization: async () => {
await organization?.destroy();
// Refresh org lists elsewhere (e.g. the switcher). Not awaited: a stale
// list must not make a successful delete look like it failed.
void userMemberships.revalidate?.();
// TODO(mosaic): navigate away from the deleted org's profile once the flow
// has router context, mirroring legacy navigateAfterLeaveOrganization.
},
},
});

// The permission check needs both the organization and the session resolved.
// Treat either still loading as 'loading' so a not-yet-known session is never
// collapsed into a definitive 'hidden'.
if (!isOrganizationLoaded || !isSessionLoaded) {
return { status: 'loading' };
}

const canDelete = session?.checkAuthorization({ permission: 'org:sys_profile:delete' }) ?? false;
if (!organization || !canDelete || !organization.adminDeleteEnabled) {
return { status: 'hidden' };
}

return {
status: 'ready',
snapshot,
send,
canSubmit: actor.can({ type: 'CONFIRM' }),
};
}
9 changes: 5 additions & 4 deletions packages/ui/src/mosaic/sections/delete-organization.tsx
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,11 @@
import { SectionSkeleton } from '../components/section-skeleton';
import { useDeleteOrganizationController } from './delete-organization-controller';
import { DeleteOrganizationView } from './delete-organization-view';
import { useDeleteOrganizationController } from './delete-organization.controller';
import { DeleteOrganizationView } from './delete-organization.view';

export function DeleteOrganization() {
const controller = useDeleteOrganizationController();
if (controller.status === 'loading') return <SectionSkeleton />;
if (controller.status !== 'ready') {
return null;
}
return (
<DeleteOrganizationView
snapshot={controller.snapshot}
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -2,7 +2,7 @@ import { Destructive } from '../block/destructive';
import { Box } from '../components/box';
import { Button } from '../components/button';
import type { Snapshot } from '../machine/types';
import type { DeleteOrgContext, DeleteOrgEvent } from './delete-organization-machine';
import type { DeleteOrgContext, DeleteOrgEvent } from './delete-organization.machine';

interface DeleteOrganizationViewProps {
snapshot: Snapshot<DeleteOrgContext>;
Expand Down
Loading
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .changeset/mosaic-org-section-gating.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
---
---
Comment thread
alexcarpenter marked this conversation as resolved.
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
/** @jsxImportSource @emotion/react */
import { useMachine } from '@clerk/ui/mosaic/machine/useMachine';
import { deleteOrgMachine } from '@clerk/ui/mosaic/sections/delete-organization-machine';
import { DeleteOrganizationView } from '@clerk/ui/mosaic/sections/delete-organization-view';
import { deleteOrgMachine } from '@clerk/ui/mosaic/sections/delete-organization.machine';
import { DeleteOrganizationView } from '@clerk/ui/mosaic/sections/delete-organization.view';

import type { StoryMeta } from '@/lib/types';

Expand Down
4 changes: 2 additions & 2 deletions packages/swingset/src/stories/leave-organization.stories.tsx
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
/** @jsxImportSource @emotion/react */
import { useMachine } from '@clerk/ui/mosaic/machine/useMachine';
import { leaveOrgMachine } from '@clerk/ui/mosaic/sections/leave-organization-machine';
import { LeaveOrganizationView } from '@clerk/ui/mosaic/sections/leave-organization-view';
import { leaveOrgMachine } from '@clerk/ui/mosaic/sections/leave-organization.machine';
import { LeaveOrganizationView } from '@clerk/ui/mosaic/sections/leave-organization.view';

import type { StoryMeta } from '@/lib/types';

Expand Down
Original file line numberDiff line numberDiff line change
@@ -1,29 +1,38 @@
import { act, fireEvent, render, screen } from '@testing-library/react';
import React from 'react';
import { afterEach, beforeEach, describe, expect, it, vi } from 'vitest';

import { deferred } from '../../machines/__tests__/test-utils';
import { useDeleteOrganizationController } from '../delete-organization-controller';
import { useDeleteOrganizationController } from '../delete-organization.controller';

const ORG_NAME = 'Acme Inc';

let destroy: ReturnType<typeof vi.fn>;
let revalidate: ReturnType<typeof vi.fn>;
let organization: { id: string; name: string; destroy: () => Promise<void> } | null;
let checkAuthorization: ReturnType<typeof vi.fn>;
let isLoaded: boolean;
let isSessionLoaded: boolean;
let organization: { id: string; name: string; destroy: () => Promise<void>; adminDeleteEnabled: boolean } | null;

vi.mock('@clerk/shared/react', async importOriginal => {
const actual = await importOriginal<typeof import('@clerk/shared/react')>();
return {
...actual,
useOrganization: () => ({ isLoaded: true, organization, membership: null }),
useOrganization: () => ({ isLoaded, organization, membership: null }),
useOrganizationList: () => ({ userMemberships: { revalidate } }),
useSession: () => ({
isLoaded: isSessionLoaded,
session: isSessionLoaded ? { id: 'sess_1', checkAuthorization } : undefined,
}),
};
});

beforeEach(() => {
destroy = vi.fn();
revalidate = vi.fn().mockResolvedValue(undefined);
organization = { id: 'org_1', name: ORG_NAME, destroy };
checkAuthorization = vi.fn().mockReturnValue(true);
isLoaded = true;
isSessionLoaded = true;
organization = { id: 'org_1', name: ORG_NAME, destroy, adminDeleteEnabled: true };
});

afterEach(() => {
Expand All@@ -33,7 +42,7 @@ afterEach(() => {
function Harness() {
const controller = useDeleteOrganizationController();
if (controller.status !== 'ready') {
return <output data-testid='state'>loading</output>;
return <output data-testid='state'>{controller.status}</output>;
}
return (
<div>
Expand All@@ -53,6 +62,46 @@ function openAndConfirm() {
}

describe('useDeleteOrganizationController', () => {
it('is loading until useOrganization is loaded', () => {
isLoaded = false;

render(<Harness />);

expect(screen.getByTestId('state')).toHaveTextContent('loading');
});

it('is loading until the session is loaded', () => {
isSessionLoaded = false;

render(<Harness />);

expect(screen.getByTestId('state')).toHaveTextContent('loading');
expect(checkAuthorization).not.toHaveBeenCalled();
});

it('is ready when the user can delete and admin delete is enabled', () => {
render(<Harness />);

expect(screen.getByTestId('state')).toHaveTextContent('idle');
expect(checkAuthorization).toHaveBeenCalledWith({ permission: 'org:sys_profile:delete' });
});

it('is hidden when the user lacks the delete permission', () => {
checkAuthorization.mockReturnValue(false);

render(<Harness />);

expect(screen.getByTestId('state')).toHaveTextContent('hidden');
});

it('is hidden when admin delete is disabled', () => {
organization = { id: 'org_1', name: ORG_NAME, destroy, adminDeleteEnabled: false };

render(<Harness />);

expect(screen.getByTestId('state')).toHaveTextContent('hidden');
});

it('drives CONFIRM → deleting → resolve → deleted', async () => {
const gate = deferred<void>();
destroy.mockReturnValue(gate.promise);
Expand Down
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
import { describe, expect, it, vi } from 'vitest';

import { createActor } from '../../machine/createActor';
import { deleteOrgMachine } from '../delete-organization-machine';
import { deleteOrgMachine } from '../delete-organization.machine';

const tick = () => new Promise<void>(resolve => setTimeout(resolve, 0));

Expand Down
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,10 @@
import { fireEvent, render, screen } from '@testing-library/react';
import { describe, expect, it, vi } from 'vitest';

import { MosaicProvider } from '../../MosaicProvider';
import type { Snapshot } from '../../machine/types';
import type { DeleteOrgContext } from '../delete-organization-machine';
import { DeleteOrganizationView } from '../delete-organization-view';
import { MosaicProvider } from '../../MosaicProvider';
import type { DeleteOrgContext } from '../delete-organization.machine';
import { DeleteOrganizationView } from '../delete-organization.view';

function renderView(snapshot: Snapshot<DeleteOrgContext>, send = vi.fn(), canSubmit = false) {
render(
Expand Down
Original file line numberDiff line numberDiff line change
@@ -1,29 +1,30 @@
import { act, fireEvent, render, screen } from '@testing-library/react';
import React from 'react';
import { afterEach, beforeEach, describe, expect, it, vi } from 'vitest';

import { deferred } from '../../machines/__tests__/test-utils';
import { useLeaveOrganizationController } from '../leave-organization-controller';
import { useLeaveOrganizationController } from '../leave-organization.controller';

const ORG_NAME = 'Acme Inc';

let destroy: ReturnType<typeof vi.fn>;
let revalidate: ReturnType<typeof vi.fn>;
let isLoaded: boolean;
let organization: { id: string; name: string } | null;
let membership: { id: string; destroy: () => Promise<void> } | null;
let membership: { id: string; destroy: () => Promise<void> } | null | undefined;

vi.mock('@clerk/shared/react', async importOriginal => {
const actual = await importOriginal<typeof import('@clerk/shared/react')>();
return {
...actual,
useOrganization: () => ({ isLoaded: true, organization, membership }),
useOrganization: () => ({ isLoaded, organization, membership }),
useOrganizationList: () => ({ userMemberships: { revalidate } }),
};
});

beforeEach(() => {
destroy = vi.fn();
revalidate = vi.fn().mockResolvedValue(undefined);
isLoaded = true;
organization = { id: 'org_1', name: ORG_NAME };
membership = { id: 'mem_1', destroy };
});
Expand All@@ -35,7 +36,7 @@ afterEach(() => {
function Harness() {
const controller = useLeaveOrganizationController();
if (controller.status !== 'ready') {
return <output data-testid='state'>loading</output>;
return <output data-testid='state'>{controller.status}</output>;
}
return (
<div>
Expand All@@ -55,6 +56,38 @@ function openAndConfirm() {
}

describe('useLeaveOrganizationController', () => {
it('is loading until useOrganization is loaded', () => {
isLoaded = false;

render(<Harness />);

expect(screen.getByTestId('state')).toHaveTextContent('loading');
});

it('is loading while membership is still resolving', () => {
membership = undefined;

render(<Harness />);

expect(screen.getByTestId('state')).toHaveTextContent('loading');
});

it('is hidden when there is no active organization', () => {
organization = null;

render(<Harness />);

expect(screen.getByTestId('state')).toHaveTextContent('hidden');
});

it('is hidden when there is no membership', () => {
membership = null;

render(<Harness />);

expect(screen.getByTestId('state')).toHaveTextContent('hidden');
});

it('drives CONFIRM → leaving → resolve → left', async () => {
const gate = deferred<void>();
destroy.mockReturnValue(gate.promise);
Expand Down
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
import { describe, expect, it, vi } from 'vitest';

import { createActor } from '../../machine/createActor';
import { leaveOrgMachine } from '../leave-organization-machine';
import { leaveOrgMachine } from '../leave-organization.machine';

const tick = () => new Promise<void>(resolve => setTimeout(resolve, 0));

Expand Down
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,10 @@
import { fireEvent, render, screen } from '@testing-library/react';
import { describe, expect, it, vi } from 'vitest';

import { MosaicProvider } from '../../MosaicProvider';
import type { Snapshot } from '../../machine/types';
import type { LeaveOrgContext } from '../leave-organization-machine';
import { LeaveOrganizationView } from '../leave-organization-view';
import { MosaicProvider } from '../../MosaicProvider';
import type { LeaveOrgContext } from '../leave-organization.machine';
import { LeaveOrganizationView } from '../leave-organization.view';

function renderView(snapshot: Snapshot<LeaveOrgContext>, send = vi.fn(), canSubmit = false) {
render(
Expand Down

This file was deleted.

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,55 @@
import { useOrganization, useOrganizationList, useSession } from '@clerk/shared/react';

import type { Snapshot } from '../machine/types';
import { useMachine } from '../machine/useMachine';
import type { DeleteOrgContext, DeleteOrgEvent } from './delete-organization.machine';
import { deleteOrgMachine } from './delete-organization.machine';

type DeleteOrganizationController =
| { status: 'loading' }
| { status: 'hidden' }
| {
status: 'ready';
snapshot: Snapshot<DeleteOrgContext>;
send: (event: DeleteOrgEvent) => void;
canSubmit: boolean;
};

export function useDeleteOrganizationController(): DeleteOrganizationController {
const { isLoaded: isOrganizationLoaded, organization } = useOrganization();
const { isLoaded: isSessionLoaded, session } = useSession();
const { userMemberships } = useOrganizationList({ userMemberships: true });

const [snapshot, send, actor] = useMachine(deleteOrgMachine, {
context: {
organizationName: organization?.name ?? '',
destroyOrganization: async () => {
await organization?.destroy();
// Refresh org lists elsewhere (e.g. the switcher). Not awaited: a stale
// list must not make a successful delete look like it failed.
void userMemberships.revalidate?.();
// TODO(mosaic): navigate away from the deleted org's profile once the flow
// has router context, mirroring legacy navigateAfterLeaveOrganization.
},
},
});

// The permission check needs both the organization and the session resolved.
// Treat either still loading as 'loading' so a not-yet-known session is never
// collapsed into a definitive 'hidden'.
if (!isOrganizationLoaded || !isSessionLoaded) {
return { status: 'loading' };
}

const canDelete = session?.checkAuthorization({ permission: 'org:sys_profile:delete' }) ?? false;
if (!organization || !canDelete || !organization.adminDeleteEnabled) {
return { status: 'hidden' };
}

return {
status: 'ready',
snapshot,
send,
canSubmit: actor.can({ type: 'CONFIRM' }),
};
}
9 changes: 5 additions & 4 deletions packages/ui/src/mosaic/sections/delete-organization.tsx
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,11 @@
import { SectionSkeleton } from '../components/section-skeleton';
import { useDeleteOrganizationController } from './delete-organization-controller';
import { DeleteOrganizationView } from './delete-organization-view';
import { useDeleteOrganizationController } from './delete-organization.controller';
import { DeleteOrganizationView } from './delete-organization.view';

export function DeleteOrganization() {
const controller = useDeleteOrganizationController();
if (controller.status === 'loading') return <SectionSkeleton />;
if (controller.status !== 'ready') {
return null;
}
return (
<DeleteOrganizationView
snapshot={controller.snapshot}
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -2,7 +2,7 @@ import { Destructive } from '../block/destructive';
import { Box } from '../components/box';
import { Button } from '../components/button';
import type { Snapshot } from '../machine/types';
import type { DeleteOrgContext, DeleteOrgEvent } from './delete-organization-machine';
import type { DeleteOrgContext, DeleteOrgEvent } from './delete-organization.machine';

interface DeleteOrganizationViewProps {
snapshot: Snapshot<DeleteOrgContext>;
Expand Down
Loading
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix"); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .changeset/mosaic-org-section-gating.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
---
---
Comment thread
alexcarpenter marked this conversation as resolved.
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
/** @jsxImportSource @emotion/react */
import { useMachine } from '@clerk/ui/mosaic/machine/useMachine';
import { deleteOrgMachine } from '@clerk/ui/mosaic/sections/delete-organization-machine';
import { DeleteOrganizationView } from '@clerk/ui/mosaic/sections/delete-organization-view';
import { deleteOrgMachine } from '@clerk/ui/mosaic/sections/delete-organization.machine';
import { DeleteOrganizationView } from '@clerk/ui/mosaic/sections/delete-organization.view';

import type { StoryMeta } from '@/lib/types';

Expand Down
4 changes: 2 additions & 2 deletions packages/swingset/src/stories/leave-organization.stories.tsx
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
/** @jsxImportSource @emotion/react */
import { useMachine } from '@clerk/ui/mosaic/machine/useMachine';
import { leaveOrgMachine } from '@clerk/ui/mosaic/sections/leave-organization-machine';
import { LeaveOrganizationView } from '@clerk/ui/mosaic/sections/leave-organization-view';
import { leaveOrgMachine } from '@clerk/ui/mosaic/sections/leave-organization.machine';
import { LeaveOrganizationView } from '@clerk/ui/mosaic/sections/leave-organization.view';

import type { StoryMeta } from '@/lib/types';

Expand Down
Original file line numberDiff line numberDiff line change
@@ -1,29 +1,38 @@
import { act, fireEvent, render, screen } from '@testing-library/react';
import React from 'react';
import { afterEach, beforeEach, describe, expect, it, vi } from 'vitest';

import { deferred } from '../../machines/__tests__/test-utils';
import { useDeleteOrganizationController } from '../delete-organization-controller';
import { useDeleteOrganizationController } from '../delete-organization.controller';

const ORG_NAME = 'Acme Inc';

let destroy: ReturnType<typeof vi.fn>;
let revalidate: ReturnType<typeof vi.fn>;
let organization: { id: string; name: string; destroy: () => Promise<void> } | null;
let checkAuthorization: ReturnType<typeof vi.fn>;
let isLoaded: boolean;
let isSessionLoaded: boolean;
let organization: { id: string; name: string; destroy: () => Promise<void>; adminDeleteEnabled: boolean } | null;

vi.mock('@clerk/shared/react', async importOriginal => {
const actual = await importOriginal<typeof import('@clerk/shared/react')>();
return {
...actual,
useOrganization: () => ({ isLoaded: true, organization, membership: null }),
useOrganization: () => ({ isLoaded, organization, membership: null }),
useOrganizationList: () => ({ userMemberships: { revalidate } }),
useSession: () => ({
isLoaded: isSessionLoaded,
session: isSessionLoaded ? { id: 'sess_1', checkAuthorization } : undefined,
}),
};
});

beforeEach(() => {
destroy = vi.fn();
revalidate = vi.fn().mockResolvedValue(undefined);
organization = { id: 'org_1', name: ORG_NAME, destroy };
checkAuthorization = vi.fn().mockReturnValue(true);
isLoaded = true;
isSessionLoaded = true;
organization = { id: 'org_1', name: ORG_NAME, destroy, adminDeleteEnabled: true };
});

afterEach(() => {
Expand All@@ -33,7 +42,7 @@ afterEach(() => {
function Harness() {
const controller = useDeleteOrganizationController();
if (controller.status !== 'ready') {
return <output data-testid='state'>loading</output>;
return <output data-testid='state'>{controller.status}</output>;
}
return (
<div>
Expand All@@ -53,6 +62,46 @@ function openAndConfirm() {
}

describe('useDeleteOrganizationController', () => {
it('is loading until useOrganization is loaded', () => {
isLoaded = false;

render(<Harness />);

expect(screen.getByTestId('state')).toHaveTextContent('loading');
});

it('is loading until the session is loaded', () => {
isSessionLoaded = false;

render(<Harness />);

expect(screen.getByTestId('state')).toHaveTextContent('loading');
expect(checkAuthorization).not.toHaveBeenCalled();
});

it('is ready when the user can delete and admin delete is enabled', () => {
render(<Harness />);

expect(screen.getByTestId('state')).toHaveTextContent('idle');
expect(checkAuthorization).toHaveBeenCalledWith({ permission: 'org:sys_profile:delete' });
});

it('is hidden when the user lacks the delete permission', () => {
checkAuthorization.mockReturnValue(false);

render(<Harness />);

expect(screen.getByTestId('state')).toHaveTextContent('hidden');
});

it('is hidden when admin delete is disabled', () => {
organization = { id: 'org_1', name: ORG_NAME, destroy, adminDeleteEnabled: false };

render(<Harness />);

expect(screen.getByTestId('state')).toHaveTextContent('hidden');
});

it('drives CONFIRM → deleting → resolve → deleted', async () => {
const gate = deferred<void>();
destroy.mockReturnValue(gate.promise);
Expand Down
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
import { describe, expect, it, vi } from 'vitest';

import { createActor } from '../../machine/createActor';
import { deleteOrgMachine } from '../delete-organization-machine';
import { deleteOrgMachine } from '../delete-organization.machine';

const tick = () => new Promise<void>(resolve => setTimeout(resolve, 0));

Expand Down
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,10 @@
import { fireEvent, render, screen } from '@testing-library/react';
import { describe, expect, it, vi } from 'vitest';

import { MosaicProvider } from '../../MosaicProvider';
import type { Snapshot } from '../../machine/types';
import type { DeleteOrgContext } from '../delete-organization-machine';
import { DeleteOrganizationView } from '../delete-organization-view';
import { MosaicProvider } from '../../MosaicProvider';
import type { DeleteOrgContext } from '../delete-organization.machine';
import { DeleteOrganizationView } from '../delete-organization.view';

function renderView(snapshot: Snapshot<DeleteOrgContext>, send = vi.fn(), canSubmit = false) {
render(
Expand Down
Original file line numberDiff line numberDiff line change
@@ -1,29 +1,30 @@
import { act, fireEvent, render, screen } from '@testing-library/react';
import React from 'react';
import { afterEach, beforeEach, describe, expect, it, vi } from 'vitest';

import { deferred } from '../../machines/__tests__/test-utils';
import { useLeaveOrganizationController } from '../leave-organization-controller';
import { useLeaveOrganizationController } from '../leave-organization.controller';

const ORG_NAME = 'Acme Inc';

let destroy: ReturnType<typeof vi.fn>;
let revalidate: ReturnType<typeof vi.fn>;
let isLoaded: boolean;
let organization: { id: string; name: string } | null;
let membership: { id: string; destroy: () => Promise<void> } | null;
let membership: { id: string; destroy: () => Promise<void> } | null | undefined;

vi.mock('@clerk/shared/react', async importOriginal => {
const actual = await importOriginal<typeof import('@clerk/shared/react')>();
return {
...actual,
useOrganization: () => ({ isLoaded: true, organization, membership }),
useOrganization: () => ({ isLoaded, organization, membership }),
useOrganizationList: () => ({ userMemberships: { revalidate } }),
};
});

beforeEach(() => {
destroy = vi.fn();
revalidate = vi.fn().mockResolvedValue(undefined);
isLoaded = true;
organization = { id: 'org_1', name: ORG_NAME };
membership = { id: 'mem_1', destroy };
});
Expand All@@ -35,7 +36,7 @@ afterEach(() => {
function Harness() {
const controller = useLeaveOrganizationController();
if (controller.status !== 'ready') {
return <output data-testid='state'>loading</output>;
return <output data-testid='state'>{controller.status}</output>;
}
return (
<div>
Expand All@@ -55,6 +56,38 @@ function openAndConfirm() {
}

describe('useLeaveOrganizationController', () => {
it('is loading until useOrganization is loaded', () => {
isLoaded = false;

render(<Harness />);

expect(screen.getByTestId('state')).toHaveTextContent('loading');
});

it('is loading while membership is still resolving', () => {
membership = undefined;

render(<Harness />);

expect(screen.getByTestId('state')).toHaveTextContent('loading');
});

it('is hidden when there is no active organization', () => {
organization = null;

render(<Harness />);

expect(screen.getByTestId('state')).toHaveTextContent('hidden');
});

it('is hidden when there is no membership', () => {
membership = null;

render(<Harness />);

expect(screen.getByTestId('state')).toHaveTextContent('hidden');
});

it('drives CONFIRM → leaving → resolve → left', async () => {
const gate = deferred<void>();
destroy.mockReturnValue(gate.promise);
Expand Down
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
import { describe, expect, it, vi } from 'vitest';

import { createActor } from '../../machine/createActor';
import { leaveOrgMachine } from '../leave-organization-machine';
import { leaveOrgMachine } from '../leave-organization.machine';

const tick = () => new Promise<void>(resolve => setTimeout(resolve, 0));

Expand Down
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,10 @@
import { fireEvent, render, screen } from '@testing-library/react';
import { describe, expect, it, vi } from 'vitest';

import { MosaicProvider } from '../../MosaicProvider';
import type { Snapshot } from '../../machine/types';
import type { LeaveOrgContext } from '../leave-organization-machine';
import { LeaveOrganizationView } from '../leave-organization-view';
import { MosaicProvider } from '../../MosaicProvider';
import type { LeaveOrgContext } from '../leave-organization.machine';
import { LeaveOrganizationView } from '../leave-organization.view';

function renderView(snapshot: Snapshot<LeaveOrgContext>, send = vi.fn(), canSubmit = false) {
render(
Expand Down

This file was deleted.

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,55 @@
import { useOrganization, useOrganizationList, useSession } from '@clerk/shared/react';

import type { Snapshot } from '../machine/types';
import { useMachine } from '../machine/useMachine';
import type { DeleteOrgContext, DeleteOrgEvent } from './delete-organization.machine';
import { deleteOrgMachine } from './delete-organization.machine';

type DeleteOrganizationController =
| { status: 'loading' }
| { status: 'hidden' }
| {
status: 'ready';
snapshot: Snapshot<DeleteOrgContext>;
send: (event: DeleteOrgEvent) => void;
canSubmit: boolean;
};

export function useDeleteOrganizationController(): DeleteOrganizationController {
const { isLoaded: isOrganizationLoaded, organization } = useOrganization();
const { isLoaded: isSessionLoaded, session } = useSession();
const { userMemberships } = useOrganizationList({ userMemberships: true });

const [snapshot, send, actor] = useMachine(deleteOrgMachine, {
context: {
organizationName: organization?.name ?? '',
destroyOrganization: async () => {
await organization?.destroy();
// Refresh org lists elsewhere (e.g. the switcher). Not awaited: a stale
// list must not make a successful delete look like it failed.
void userMemberships.revalidate?.();
// TODO(mosaic): navigate away from the deleted org's profile once the flow
// has router context, mirroring legacy navigateAfterLeaveOrganization.
},
},
});

// The permission check needs both the organization and the session resolved.
// Treat either still loading as 'loading' so a not-yet-known session is never
// collapsed into a definitive 'hidden'.
if (!isOrganizationLoaded || !isSessionLoaded) {
return { status: 'loading' };
}

const canDelete = session?.checkAuthorization({ permission: 'org:sys_profile:delete' }) ?? false;
if (!organization || !canDelete || !organization.adminDeleteEnabled) {
return { status: 'hidden' };
}

return {
status: 'ready',
snapshot,
send,
canSubmit: actor.can({ type: 'CONFIRM' }),
};
}
9 changes: 5 additions & 4 deletions packages/ui/src/mosaic/sections/delete-organization.tsx
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,11 @@
import { SectionSkeleton } from '../components/section-skeleton';
import { useDeleteOrganizationController } from './delete-organization-controller';
import { DeleteOrganizationView } from './delete-organization-view';
import { useDeleteOrganizationController } from './delete-organization.controller';
import { DeleteOrganizationView } from './delete-organization.view';

export function DeleteOrganization() {
const controller = useDeleteOrganizationController();
if (controller.status === 'loading') return <SectionSkeleton />;
if (controller.status !== 'ready') {
return null;
}
return (
<DeleteOrganizationView
snapshot={controller.snapshot}
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -2,7 +2,7 @@ import { Destructive } from '../block/destructive';
import { Box } from '../components/box';
import { Button } from '../components/button';
import type { Snapshot } from '../machine/types';
import type { DeleteOrgContext, DeleteOrgEvent } from './delete-organization-machine';
import type { DeleteOrgContext, DeleteOrgEvent } from './delete-organization.machine';

interface DeleteOrganizationViewProps {
snapshot: Snapshot<DeleteOrgContext>;
Expand Down
Loading
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms"); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .changeset/mosaic-org-section-gating.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
---
---
Comment thread
alexcarpenter marked this conversation as resolved.
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
/** @jsxImportSource @emotion/react */
import { useMachine } from '@clerk/ui/mosaic/machine/useMachine';
import { deleteOrgMachine } from '@clerk/ui/mosaic/sections/delete-organization-machine';
import { DeleteOrganizationView } from '@clerk/ui/mosaic/sections/delete-organization-view';
import { deleteOrgMachine } from '@clerk/ui/mosaic/sections/delete-organization.machine';
import { DeleteOrganizationView } from '@clerk/ui/mosaic/sections/delete-organization.view';

import type { StoryMeta } from '@/lib/types';

Expand Down
4 changes: 2 additions & 2 deletions packages/swingset/src/stories/leave-organization.stories.tsx
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
/** @jsxImportSource @emotion/react */
import { useMachine } from '@clerk/ui/mosaic/machine/useMachine';
import { leaveOrgMachine } from '@clerk/ui/mosaic/sections/leave-organization-machine';
import { LeaveOrganizationView } from '@clerk/ui/mosaic/sections/leave-organization-view';
import { leaveOrgMachine } from '@clerk/ui/mosaic/sections/leave-organization.machine';
import { LeaveOrganizationView } from '@clerk/ui/mosaic/sections/leave-organization.view';

import type { StoryMeta } from '@/lib/types';

Expand Down
Original file line numberDiff line numberDiff line change
@@ -1,29 +1,38 @@
import { act, fireEvent, render, screen } from '@testing-library/react';
import React from 'react';
import { afterEach, beforeEach, describe, expect, it, vi } from 'vitest';

import { deferred } from '../../machines/__tests__/test-utils';
import { useDeleteOrganizationController } from '../delete-organization-controller';
import { useDeleteOrganizationController } from '../delete-organization.controller';

const ORG_NAME = 'Acme Inc';

let destroy: ReturnType<typeof vi.fn>;
let revalidate: ReturnType<typeof vi.fn>;
let organization: { id: string; name: string; destroy: () => Promise<void> } | null;
let checkAuthorization: ReturnType<typeof vi.fn>;
let isLoaded: boolean;
let isSessionLoaded: boolean;
let organization: { id: string; name: string; destroy: () => Promise<void>; adminDeleteEnabled: boolean } | null;

vi.mock('@clerk/shared/react', async importOriginal => {
const actual = await importOriginal<typeof import('@clerk/shared/react')>();
return {
...actual,
useOrganization: () => ({ isLoaded: true, organization, membership: null }),
useOrganization: () => ({ isLoaded, organization, membership: null }),
useOrganizationList: () => ({ userMemberships: { revalidate } }),
useSession: () => ({
isLoaded: isSessionLoaded,
session: isSessionLoaded ? { id: 'sess_1', checkAuthorization } : undefined,
}),
};
});

beforeEach(() => {
destroy = vi.fn();
revalidate = vi.fn().mockResolvedValue(undefined);
organization = { id: 'org_1', name: ORG_NAME, destroy };
checkAuthorization = vi.fn().mockReturnValue(true);
isLoaded = true;
isSessionLoaded = true;
organization = { id: 'org_1', name: ORG_NAME, destroy, adminDeleteEnabled: true };
});

afterEach(() => {
Expand All@@ -33,7 +42,7 @@ afterEach(() => {
function Harness() {
const controller = useDeleteOrganizationController();
if (controller.status !== 'ready') {
return <output data-testid='state'>loading</output>;
return <output data-testid='state'>{controller.status}</output>;
}
return (
<div>
Expand All@@ -53,6 +62,46 @@ function openAndConfirm() {
}

describe('useDeleteOrganizationController', () => {
it('is loading until useOrganization is loaded', () => {
isLoaded = false;

render(<Harness />);

expect(screen.getByTestId('state')).toHaveTextContent('loading');
});

it('is loading until the session is loaded', () => {
isSessionLoaded = false;

render(<Harness />);

expect(screen.getByTestId('state')).toHaveTextContent('loading');
expect(checkAuthorization).not.toHaveBeenCalled();
});

it('is ready when the user can delete and admin delete is enabled', () => {
render(<Harness />);

expect(screen.getByTestId('state')).toHaveTextContent('idle');
expect(checkAuthorization).toHaveBeenCalledWith({ permission: 'org:sys_profile:delete' });
});

it('is hidden when the user lacks the delete permission', () => {
checkAuthorization.mockReturnValue(false);

render(<Harness />);

expect(screen.getByTestId('state')).toHaveTextContent('hidden');
});

it('is hidden when admin delete is disabled', () => {
organization = { id: 'org_1', name: ORG_NAME, destroy, adminDeleteEnabled: false };

render(<Harness />);

expect(screen.getByTestId('state')).toHaveTextContent('hidden');
});

it('drives CONFIRM → deleting → resolve → deleted', async () => {
const gate = deferred<void>();
destroy.mockReturnValue(gate.promise);
Expand Down
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
import { describe, expect, it, vi } from 'vitest';

import { createActor } from '../../machine/createActor';
import { deleteOrgMachine } from '../delete-organization-machine';
import { deleteOrgMachine } from '../delete-organization.machine';

const tick = () => new Promise<void>(resolve => setTimeout(resolve, 0));

Expand Down
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,10 @@
import { fireEvent, render, screen } from '@testing-library/react';
import { describe, expect, it, vi } from 'vitest';

import { MosaicProvider } from '../../MosaicProvider';
import type { Snapshot } from '../../machine/types';
import type { DeleteOrgContext } from '../delete-organization-machine';
import { DeleteOrganizationView } from '../delete-organization-view';
import { MosaicProvider } from '../../MosaicProvider';
import type { DeleteOrgContext } from '../delete-organization.machine';
import { DeleteOrganizationView } from '../delete-organization.view';

function renderView(snapshot: Snapshot<DeleteOrgContext>, send = vi.fn(), canSubmit = false) {
render(
Expand Down
Original file line numberDiff line numberDiff line change
@@ -1,29 +1,30 @@
import { act, fireEvent, render, screen } from '@testing-library/react';
import React from 'react';
import { afterEach, beforeEach, describe, expect, it, vi } from 'vitest';

import { deferred } from '../../machines/__tests__/test-utils';
import { useLeaveOrganizationController } from '../leave-organization-controller';
import { useLeaveOrganizationController } from '../leave-organization.controller';

const ORG_NAME = 'Acme Inc';

let destroy: ReturnType<typeof vi.fn>;
let revalidate: ReturnType<typeof vi.fn>;
let isLoaded: boolean;
let organization: { id: string; name: string } | null;
let membership: { id: string; destroy: () => Promise<void> } | null;
let membership: { id: string; destroy: () => Promise<void> } | null | undefined;

vi.mock('@clerk/shared/react', async importOriginal => {
const actual = await importOriginal<typeof import('@clerk/shared/react')>();
return {
...actual,
useOrganization: () => ({ isLoaded: true, organization, membership }),
useOrganization: () => ({ isLoaded, organization, membership }),
useOrganizationList: () => ({ userMemberships: { revalidate } }),
};
});

beforeEach(() => {
destroy = vi.fn();
revalidate = vi.fn().mockResolvedValue(undefined);
isLoaded = true;
organization = { id: 'org_1', name: ORG_NAME };
membership = { id: 'mem_1', destroy };
});
Expand All@@ -35,7 +36,7 @@ afterEach(() => {
function Harness() {
const controller = useLeaveOrganizationController();
if (controller.status !== 'ready') {
return <output data-testid='state'>loading</output>;
return <output data-testid='state'>{controller.status}</output>;
}
return (
<div>
Expand All@@ -55,6 +56,38 @@ function openAndConfirm() {
}

describe('useLeaveOrganizationController', () => {
it('is loading until useOrganization is loaded', () => {
isLoaded = false;

render(<Harness />);

expect(screen.getByTestId('state')).toHaveTextContent('loading');
});

it('is loading while membership is still resolving', () => {
membership = undefined;

render(<Harness />);

expect(screen.getByTestId('state')).toHaveTextContent('loading');
});

it('is hidden when there is no active organization', () => {
organization = null;

render(<Harness />);

expect(screen.getByTestId('state')).toHaveTextContent('hidden');
});

it('is hidden when there is no membership', () => {
membership = null;

render(<Harness />);

expect(screen.getByTestId('state')).toHaveTextContent('hidden');
});

it('drives CONFIRM → leaving → resolve → left', async () => {
const gate = deferred<void>();
destroy.mockReturnValue(gate.promise);
Expand Down
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
import { describe, expect, it, vi } from 'vitest';

import { createActor } from '../../machine/createActor';
import { leaveOrgMachine } from '../leave-organization-machine';
import { leaveOrgMachine } from '../leave-organization.machine';

const tick = () => new Promise<void>(resolve => setTimeout(resolve, 0));

Expand Down
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,10 @@
import { fireEvent, render, screen } from '@testing-library/react';
import { describe, expect, it, vi } from 'vitest';

import { MosaicProvider } from '../../MosaicProvider';
import type { Snapshot } from '../../machine/types';
import type { LeaveOrgContext } from '../leave-organization-machine';
import { LeaveOrganizationView } from '../leave-organization-view';
import { MosaicProvider } from '../../MosaicProvider';
import type { LeaveOrgContext } from '../leave-organization.machine';
import { LeaveOrganizationView } from '../leave-organization.view';

function renderView(snapshot: Snapshot<LeaveOrgContext>, send = vi.fn(), canSubmit = false) {
render(
Expand Down

This file was deleted.

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,55 @@
import { useOrganization, useOrganizationList, useSession } from '@clerk/shared/react';

import type { Snapshot } from '../machine/types';
import { useMachine } from '../machine/useMachine';
import type { DeleteOrgContext, DeleteOrgEvent } from './delete-organization.machine';
import { deleteOrgMachine } from './delete-organization.machine';

type DeleteOrganizationController =
| { status: 'loading' }
| { status: 'hidden' }
| {
status: 'ready';
snapshot: Snapshot<DeleteOrgContext>;
send: (event: DeleteOrgEvent) => void;
canSubmit: boolean;
};

export function useDeleteOrganizationController(): DeleteOrganizationController {
const { isLoaded: isOrganizationLoaded, organization } = useOrganization();
const { isLoaded: isSessionLoaded, session } = useSession();
const { userMemberships } = useOrganizationList({ userMemberships: true });

const [snapshot, send, actor] = useMachine(deleteOrgMachine, {
context: {
organizationName: organization?.name ?? '',
destroyOrganization: async () => {
await organization?.destroy();
// Refresh org lists elsewhere (e.g. the switcher). Not awaited: a stale
// list must not make a successful delete look like it failed.
void userMemberships.revalidate?.();
// TODO(mosaic): navigate away from the deleted org's profile once the flow
// has router context, mirroring legacy navigateAfterLeaveOrganization.
},
},
});

// The permission check needs both the organization and the session resolved.
// Treat either still loading as 'loading' so a not-yet-known session is never
// collapsed into a definitive 'hidden'.
if (!isOrganizationLoaded || !isSessionLoaded) {
return { status: 'loading' };
}

const canDelete = session?.checkAuthorization({ permission: 'org:sys_profile:delete' }) ?? false;
if (!organization || !canDelete || !organization.adminDeleteEnabled) {
return { status: 'hidden' };
}

return {
status: 'ready',
snapshot,
send,
canSubmit: actor.can({ type: 'CONFIRM' }),
};
}
9 changes: 5 additions & 4 deletions packages/ui/src/mosaic/sections/delete-organization.tsx
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,11 @@
import { SectionSkeleton } from '../components/section-skeleton';
import { useDeleteOrganizationController } from './delete-organization-controller';
import { DeleteOrganizationView } from './delete-organization-view';
import { useDeleteOrganizationController } from './delete-organization.controller';
import { DeleteOrganizationView } from './delete-organization.view';

export function DeleteOrganization() {
const controller = useDeleteOrganizationController();
if (controller.status === 'loading') return <SectionSkeleton />;
if (controller.status !== 'ready') {
return null;
}
return (
<DeleteOrganizationView
snapshot={controller.snapshot}
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -2,7 +2,7 @@ import { Destructive } from '../block/destructive';
import { Box } from '../components/box';
import { Button } from '../components/button';
import type { Snapshot } from '../machine/types';
import type { DeleteOrgContext, DeleteOrgEvent } from './delete-organization-machine';
import type { DeleteOrgContext, DeleteOrgEvent } from './delete-organization.machine';

interface DeleteOrganizationViewProps {
snapshot: Snapshot<DeleteOrgContext>;
Expand Down
Loading
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links"); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .changeset/mosaic-org-section-gating.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
---
---
Comment thread
alexcarpenter marked this conversation as resolved.
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
/** @jsxImportSource @emotion/react */
import { useMachine } from '@clerk/ui/mosaic/machine/useMachine';
import { deleteOrgMachine } from '@clerk/ui/mosaic/sections/delete-organization-machine';
import { DeleteOrganizationView } from '@clerk/ui/mosaic/sections/delete-organization-view';
import { deleteOrgMachine } from '@clerk/ui/mosaic/sections/delete-organization.machine';
import { DeleteOrganizationView } from '@clerk/ui/mosaic/sections/delete-organization.view';

import type { StoryMeta } from '@/lib/types';

Expand Down
4 changes: 2 additions & 2 deletions packages/swingset/src/stories/leave-organization.stories.tsx
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
/** @jsxImportSource @emotion/react */
import { useMachine } from '@clerk/ui/mosaic/machine/useMachine';
import { leaveOrgMachine } from '@clerk/ui/mosaic/sections/leave-organization-machine';
import { LeaveOrganizationView } from '@clerk/ui/mosaic/sections/leave-organization-view';
import { leaveOrgMachine } from '@clerk/ui/mosaic/sections/leave-organization.machine';
import { LeaveOrganizationView } from '@clerk/ui/mosaic/sections/leave-organization.view';

import type { StoryMeta } from '@/lib/types';

Expand Down
Original file line numberDiff line numberDiff line change
@@ -1,29 +1,38 @@
import { act, fireEvent, render, screen } from '@testing-library/react';
import React from 'react';
import { afterEach, beforeEach, describe, expect, it, vi } from 'vitest';

import { deferred } from '../../machines/__tests__/test-utils';
import { useDeleteOrganizationController } from '../delete-organization-controller';
import { useDeleteOrganizationController } from '../delete-organization.controller';

const ORG_NAME = 'Acme Inc';

let destroy: ReturnType<typeof vi.fn>;
let revalidate: ReturnType<typeof vi.fn>;
let organization: { id: string; name: string; destroy: () => Promise<void> } | null;
let checkAuthorization: ReturnType<typeof vi.fn>;
let isLoaded: boolean;
let isSessionLoaded: boolean;
let organization: { id: string; name: string; destroy: () => Promise<void>; adminDeleteEnabled: boolean } | null;

vi.mock('@clerk/shared/react', async importOriginal => {
const actual = await importOriginal<typeof import('@clerk/shared/react')>();
return {
...actual,
useOrganization: () => ({ isLoaded: true, organization, membership: null }),
useOrganization: () => ({ isLoaded, organization, membership: null }),
useOrganizationList: () => ({ userMemberships: { revalidate } }),
useSession: () => ({
isLoaded: isSessionLoaded,
session: isSessionLoaded ? { id: 'sess_1', checkAuthorization } : undefined,
}),
};
});

beforeEach(() => {
destroy = vi.fn();
revalidate = vi.fn().mockResolvedValue(undefined);
organization = { id: 'org_1', name: ORG_NAME, destroy };
checkAuthorization = vi.fn().mockReturnValue(true);
isLoaded = true;
isSessionLoaded = true;
organization = { id: 'org_1', name: ORG_NAME, destroy, adminDeleteEnabled: true };
});

afterEach(() => {
Expand All@@ -33,7 +42,7 @@ afterEach(() => {
function Harness() {
const controller = useDeleteOrganizationController();
if (controller.status !== 'ready') {
return <output data-testid='state'>loading</output>;
return <output data-testid='state'>{controller.status}</output>;
}
return (
<div>
Expand All@@ -53,6 +62,46 @@ function openAndConfirm() {
}

describe('useDeleteOrganizationController', () => {
it('is loading until useOrganization is loaded', () => {
isLoaded = false;

render(<Harness />);

expect(screen.getByTestId('state')).toHaveTextContent('loading');
});

it('is loading until the session is loaded', () => {
isSessionLoaded = false;

render(<Harness />);

expect(screen.getByTestId('state')).toHaveTextContent('loading');
expect(checkAuthorization).not.toHaveBeenCalled();
});

it('is ready when the user can delete and admin delete is enabled', () => {
render(<Harness />);

expect(screen.getByTestId('state')).toHaveTextContent('idle');
expect(checkAuthorization).toHaveBeenCalledWith({ permission: 'org:sys_profile:delete' });
});

it('is hidden when the user lacks the delete permission', () => {
checkAuthorization.mockReturnValue(false);

render(<Harness />);

expect(screen.getByTestId('state')).toHaveTextContent('hidden');
});

it('is hidden when admin delete is disabled', () => {
organization = { id: 'org_1', name: ORG_NAME, destroy, adminDeleteEnabled: false };

render(<Harness />);

expect(screen.getByTestId('state')).toHaveTextContent('hidden');
});

it('drives CONFIRM → deleting → resolve → deleted', async () => {
const gate = deferred<void>();
destroy.mockReturnValue(gate.promise);
Expand Down
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
import { describe, expect, it, vi } from 'vitest';

import { createActor } from '../../machine/createActor';
import { deleteOrgMachine } from '../delete-organization-machine';
import { deleteOrgMachine } from '../delete-organization.machine';

const tick = () => new Promise<void>(resolve => setTimeout(resolve, 0));

Expand Down
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,10 @@
import { fireEvent, render, screen } from '@testing-library/react';
import { describe, expect, it, vi } from 'vitest';

import { MosaicProvider } from '../../MosaicProvider';
import type { Snapshot } from '../../machine/types';
import type { DeleteOrgContext } from '../delete-organization-machine';
import { DeleteOrganizationView } from '../delete-organization-view';
import { MosaicProvider } from '../../MosaicProvider';
import type { DeleteOrgContext } from '../delete-organization.machine';
import { DeleteOrganizationView } from '../delete-organization.view';

function renderView(snapshot: Snapshot<DeleteOrgContext>, send = vi.fn(), canSubmit = false) {
render(
Expand Down
Original file line numberDiff line numberDiff line change
@@ -1,29 +1,30 @@
import { act, fireEvent, render, screen } from '@testing-library/react';
import React from 'react';
import { afterEach, beforeEach, describe, expect, it, vi } from 'vitest';

import { deferred } from '../../machines/__tests__/test-utils';
import { useLeaveOrganizationController } from '../leave-organization-controller';
import { useLeaveOrganizationController } from '../leave-organization.controller';

const ORG_NAME = 'Acme Inc';

let destroy: ReturnType<typeof vi.fn>;
let revalidate: ReturnType<typeof vi.fn>;
let isLoaded: boolean;
let organization: { id: string; name: string } | null;
let membership: { id: string; destroy: () => Promise<void> } | null;
let membership: { id: string; destroy: () => Promise<void> } | null | undefined;

vi.mock('@clerk/shared/react', async importOriginal => {
const actual = await importOriginal<typeof import('@clerk/shared/react')>();
return {
...actual,
useOrganization: () => ({ isLoaded: true, organization, membership }),
useOrganization: () => ({ isLoaded, organization, membership }),
useOrganizationList: () => ({ userMemberships: { revalidate } }),
};
});

beforeEach(() => {
destroy = vi.fn();
revalidate = vi.fn().mockResolvedValue(undefined);
isLoaded = true;
organization = { id: 'org_1', name: ORG_NAME };
membership = { id: 'mem_1', destroy };
});
Expand All@@ -35,7 +36,7 @@ afterEach(() => {
function Harness() {
const controller = useLeaveOrganizationController();
if (controller.status !== 'ready') {
return <output data-testid='state'>loading</output>;
return <output data-testid='state'>{controller.status}</output>;
}
return (
<div>
Expand All@@ -55,6 +56,38 @@ function openAndConfirm() {
}

describe('useLeaveOrganizationController', () => {
it('is loading until useOrganization is loaded', () => {
isLoaded = false;

render(<Harness />);

expect(screen.getByTestId('state')).toHaveTextContent('loading');
});

it('is loading while membership is still resolving', () => {
membership = undefined;

render(<Harness />);

expect(screen.getByTestId('state')).toHaveTextContent('loading');
});

it('is hidden when there is no active organization', () => {
organization = null;

render(<Harness />);

expect(screen.getByTestId('state')).toHaveTextContent('hidden');
});

it('is hidden when there is no membership', () => {
membership = null;

render(<Harness />);

expect(screen.getByTestId('state')).toHaveTextContent('hidden');
});

it('drives CONFIRM → leaving → resolve → left', async () => {
const gate = deferred<void>();
destroy.mockReturnValue(gate.promise);
Expand Down
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
import { describe, expect, it, vi } from 'vitest';

import { createActor } from '../../machine/createActor';
import { leaveOrgMachine } from '../leave-organization-machine';
import { leaveOrgMachine } from '../leave-organization.machine';

const tick = () => new Promise<void>(resolve => setTimeout(resolve, 0));

Expand Down
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,10 @@
import { fireEvent, render, screen } from '@testing-library/react';
import { describe, expect, it, vi } from 'vitest';

import { MosaicProvider } from '../../MosaicProvider';
import type { Snapshot } from '../../machine/types';
import type { LeaveOrgContext } from '../leave-organization-machine';
import { LeaveOrganizationView } from '../leave-organization-view';
import { MosaicProvider } from '../../MosaicProvider';
import type { LeaveOrgContext } from '../leave-organization.machine';
import { LeaveOrganizationView } from '../leave-organization.view';

function renderView(snapshot: Snapshot<LeaveOrgContext>, send = vi.fn(), canSubmit = false) {
render(
Expand Down

This file was deleted.

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,55 @@
import { useOrganization, useOrganizationList, useSession } from '@clerk/shared/react';

import type { Snapshot } from '../machine/types';
import { useMachine } from '../machine/useMachine';
import type { DeleteOrgContext, DeleteOrgEvent } from './delete-organization.machine';
import { deleteOrgMachine } from './delete-organization.machine';

type DeleteOrganizationController =
| { status: 'loading' }
| { status: 'hidden' }
| {
status: 'ready';
snapshot: Snapshot<DeleteOrgContext>;
send: (event: DeleteOrgEvent) => void;
canSubmit: boolean;
};

export function useDeleteOrganizationController(): DeleteOrganizationController {
const { isLoaded: isOrganizationLoaded, organization } = useOrganization();
const { isLoaded: isSessionLoaded, session } = useSession();
const { userMemberships } = useOrganizationList({ userMemberships: true });

const [snapshot, send, actor] = useMachine(deleteOrgMachine, {
context: {
organizationName: organization?.name ?? '',
destroyOrganization: async () => {
await organization?.destroy();
// Refresh org lists elsewhere (e.g. the switcher). Not awaited: a stale
// list must not make a successful delete look like it failed.
void userMemberships.revalidate?.();
// TODO(mosaic): navigate away from the deleted org's profile once the flow
// has router context, mirroring legacy navigateAfterLeaveOrganization.
},
},
});

// The permission check needs both the organization and the session resolved.
// Treat either still loading as 'loading' so a not-yet-known session is never
// collapsed into a definitive 'hidden'.
if (!isOrganizationLoaded || !isSessionLoaded) {
return { status: 'loading' };
}

const canDelete = session?.checkAuthorization({ permission: 'org:sys_profile:delete' }) ?? false;
if (!organization || !canDelete || !organization.adminDeleteEnabled) {
return { status: 'hidden' };
}

return {
status: 'ready',
snapshot,
send,
canSubmit: actor.can({ type: 'CONFIRM' }),
};
}
9 changes: 5 additions & 4 deletions packages/ui/src/mosaic/sections/delete-organization.tsx
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,11 @@
import { SectionSkeleton } from '../components/section-skeleton';
import { useDeleteOrganizationController } from './delete-organization-controller';
import { DeleteOrganizationView } from './delete-organization-view';
import { useDeleteOrganizationController } from './delete-organization.controller';
import { DeleteOrganizationView } from './delete-organization.view';

export function DeleteOrganization() {
const controller = useDeleteOrganizationController();
if (controller.status === 'loading') return <SectionSkeleton />;
if (controller.status !== 'ready') {
return null;
}
return (
<DeleteOrganizationView
snapshot={controller.snapshot}
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -2,7 +2,7 @@ import { Destructive } from '../block/destructive';
import { Box } from '../components/box';
import { Button } from '../components/button';
import type { Snapshot } from '../machine/types';
import type { DeleteOrgContext, DeleteOrgEvent } from './delete-organization-machine';
import type { DeleteOrgContext, DeleteOrgEvent } from './delete-organization.machine';

interface DeleteOrganizationViewProps {
snapshot: Snapshot<DeleteOrgContext>;
Expand Down
Loading
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default"); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .changeset/mosaic-org-section-gating.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
---
---
Comment thread
alexcarpenter marked this conversation as resolved.
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
/** @jsxImportSource @emotion/react */
import { useMachine } from '@clerk/ui/mosaic/machine/useMachine';
import { deleteOrgMachine } from '@clerk/ui/mosaic/sections/delete-organization-machine';
import { DeleteOrganizationView } from '@clerk/ui/mosaic/sections/delete-organization-view';
import { deleteOrgMachine } from '@clerk/ui/mosaic/sections/delete-organization.machine';
import { DeleteOrganizationView } from '@clerk/ui/mosaic/sections/delete-organization.view';

import type { StoryMeta } from '@/lib/types';

Expand Down
4 changes: 2 additions & 2 deletions packages/swingset/src/stories/leave-organization.stories.tsx
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
/** @jsxImportSource @emotion/react */
import { useMachine } from '@clerk/ui/mosaic/machine/useMachine';
import { leaveOrgMachine } from '@clerk/ui/mosaic/sections/leave-organization-machine';
import { LeaveOrganizationView } from '@clerk/ui/mosaic/sections/leave-organization-view';
import { leaveOrgMachine } from '@clerk/ui/mosaic/sections/leave-organization.machine';
import { LeaveOrganizationView } from '@clerk/ui/mosaic/sections/leave-organization.view';

import type { StoryMeta } from '@/lib/types';

Expand Down
Original file line numberDiff line numberDiff line change
@@ -1,29 +1,38 @@
import { act, fireEvent, render, screen } from '@testing-library/react';
import React from 'react';
import { afterEach, beforeEach, describe, expect, it, vi } from 'vitest';

import { deferred } from '../../machines/__tests__/test-utils';
import { useDeleteOrganizationController } from '../delete-organization-controller';
import { useDeleteOrganizationController } from '../delete-organization.controller';

const ORG_NAME = 'Acme Inc';

let destroy: ReturnType<typeof vi.fn>;
let revalidate: ReturnType<typeof vi.fn>;
let organization: { id: string; name: string; destroy: () => Promise<void> } | null;
let checkAuthorization: ReturnType<typeof vi.fn>;
let isLoaded: boolean;
let isSessionLoaded: boolean;
let organization: { id: string; name: string; destroy: () => Promise<void>; adminDeleteEnabled: boolean } | null;

vi.mock('@clerk/shared/react', async importOriginal => {
const actual = await importOriginal<typeof import('@clerk/shared/react')>();
return {
...actual,
useOrganization: () => ({ isLoaded: true, organization, membership: null }),
useOrganization: () => ({ isLoaded, organization, membership: null }),
useOrganizationList: () => ({ userMemberships: { revalidate } }),
useSession: () => ({
isLoaded: isSessionLoaded,
session: isSessionLoaded ? { id: 'sess_1', checkAuthorization } : undefined,
}),
};
});

beforeEach(() => {
destroy = vi.fn();
revalidate = vi.fn().mockResolvedValue(undefined);
organization = { id: 'org_1', name: ORG_NAME, destroy };
checkAuthorization = vi.fn().mockReturnValue(true);
isLoaded = true;
isSessionLoaded = true;
organization = { id: 'org_1', name: ORG_NAME, destroy, adminDeleteEnabled: true };
});

afterEach(() => {
Expand All@@ -33,7 +42,7 @@ afterEach(() => {
function Harness() {
const controller = useDeleteOrganizationController();
if (controller.status !== 'ready') {
return <output data-testid='state'>loading</output>;
return <output data-testid='state'>{controller.status}</output>;
}
return (
<div>
Expand All@@ -53,6 +62,46 @@ function openAndConfirm() {
}

describe('useDeleteOrganizationController', () => {
it('is loading until useOrganization is loaded', () => {
isLoaded = false;

render(<Harness />);

expect(screen.getByTestId('state')).toHaveTextContent('loading');
});

it('is loading until the session is loaded', () => {
isSessionLoaded = false;

render(<Harness />);

expect(screen.getByTestId('state')).toHaveTextContent('loading');
expect(checkAuthorization).not.toHaveBeenCalled();
});

it('is ready when the user can delete and admin delete is enabled', () => {
render(<Harness />);

expect(screen.getByTestId('state')).toHaveTextContent('idle');
expect(checkAuthorization).toHaveBeenCalledWith({ permission: 'org:sys_profile:delete' });
});

it('is hidden when the user lacks the delete permission', () => {
checkAuthorization.mockReturnValue(false);

render(<Harness />);

expect(screen.getByTestId('state')).toHaveTextContent('hidden');
});

it('is hidden when admin delete is disabled', () => {
organization = { id: 'org_1', name: ORG_NAME, destroy, adminDeleteEnabled: false };

render(<Harness />);

expect(screen.getByTestId('state')).toHaveTextContent('hidden');
});

it('drives CONFIRM → deleting → resolve → deleted', async () => {
const gate = deferred<void>();
destroy.mockReturnValue(gate.promise);
Expand Down
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
import { describe, expect, it, vi } from 'vitest';

import { createActor } from '../../machine/createActor';
import { deleteOrgMachine } from '../delete-organization-machine';
import { deleteOrgMachine } from '../delete-organization.machine';

const tick = () => new Promise<void>(resolve => setTimeout(resolve, 0));

Expand Down
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,10 @@
import { fireEvent, render, screen } from '@testing-library/react';
import { describe, expect, it, vi } from 'vitest';

import { MosaicProvider } from '../../MosaicProvider';
import type { Snapshot } from '../../machine/types';
import type { DeleteOrgContext } from '../delete-organization-machine';
import { DeleteOrganizationView } from '../delete-organization-view';
import { MosaicProvider } from '../../MosaicProvider';
import type { DeleteOrgContext } from '../delete-organization.machine';
import { DeleteOrganizationView } from '../delete-organization.view';

function renderView(snapshot: Snapshot<DeleteOrgContext>, send = vi.fn(), canSubmit = false) {
render(
Expand Down
Original file line numberDiff line numberDiff line change
@@ -1,29 +1,30 @@
import { act, fireEvent, render, screen } from '@testing-library/react';
import React from 'react';
import { afterEach, beforeEach, describe, expect, it, vi } from 'vitest';

import { deferred } from '../../machines/__tests__/test-utils';
import { useLeaveOrganizationController } from '../leave-organization-controller';
import { useLeaveOrganizationController } from '../leave-organization.controller';

const ORG_NAME = 'Acme Inc';

let destroy: ReturnType<typeof vi.fn>;
let revalidate: ReturnType<typeof vi.fn>;
let isLoaded: boolean;
let organization: { id: string; name: string } | null;
let membership: { id: string; destroy: () => Promise<void> } | null;
let membership: { id: string; destroy: () => Promise<void> } | null | undefined;

vi.mock('@clerk/shared/react', async importOriginal => {
const actual = await importOriginal<typeof import('@clerk/shared/react')>();
return {
...actual,
useOrganization: () => ({ isLoaded: true, organization, membership }),
useOrganization: () => ({ isLoaded, organization, membership }),
useOrganizationList: () => ({ userMemberships: { revalidate } }),
};
});

beforeEach(() => {
destroy = vi.fn();
revalidate = vi.fn().mockResolvedValue(undefined);
isLoaded = true;
organization = { id: 'org_1', name: ORG_NAME };
membership = { id: 'mem_1', destroy };
});
Expand All@@ -35,7 +36,7 @@ afterEach(() => {
function Harness() {
const controller = useLeaveOrganizationController();
if (controller.status !== 'ready') {
return <output data-testid='state'>loading</output>;
return <output data-testid='state'>{controller.status}</output>;
}
return (
<div>
Expand All@@ -55,6 +56,38 @@ function openAndConfirm() {
}

describe('useLeaveOrganizationController', () => {
it('is loading until useOrganization is loaded', () => {
isLoaded = false;

render(<Harness />);

expect(screen.getByTestId('state')).toHaveTextContent('loading');
});

it('is loading while membership is still resolving', () => {
membership = undefined;

render(<Harness />);

expect(screen.getByTestId('state')).toHaveTextContent('loading');
});

it('is hidden when there is no active organization', () => {
organization = null;

render(<Harness />);

expect(screen.getByTestId('state')).toHaveTextContent('hidden');
});

it('is hidden when there is no membership', () => {
membership = null;

render(<Harness />);

expect(screen.getByTestId('state')).toHaveTextContent('hidden');
});

it('drives CONFIRM → leaving → resolve → left', async () => {
const gate = deferred<void>();
destroy.mockReturnValue(gate.promise);
Expand Down
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
import { describe, expect, it, vi } from 'vitest';

import { createActor } from '../../machine/createActor';
import { leaveOrgMachine } from '../leave-organization-machine';
import { leaveOrgMachine } from '../leave-organization.machine';

const tick = () => new Promise<void>(resolve => setTimeout(resolve, 0));

Expand Down
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,10 @@
import { fireEvent, render, screen } from '@testing-library/react';
import { describe, expect, it, vi } from 'vitest';

import { MosaicProvider } from '../../MosaicProvider';
import type { Snapshot } from '../../machine/types';
import type { LeaveOrgContext } from '../leave-organization-machine';
import { LeaveOrganizationView } from '../leave-organization-view';
import { MosaicProvider } from '../../MosaicProvider';
import type { LeaveOrgContext } from '../leave-organization.machine';
import { LeaveOrganizationView } from '../leave-organization.view';

function renderView(snapshot: Snapshot<LeaveOrgContext>, send = vi.fn(), canSubmit = false) {
render(
Expand Down

This file was deleted.

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,55 @@
import { useOrganization, useOrganizationList, useSession } from '@clerk/shared/react';

import type { Snapshot } from '../machine/types';
import { useMachine } from '../machine/useMachine';
import type { DeleteOrgContext, DeleteOrgEvent } from './delete-organization.machine';
import { deleteOrgMachine } from './delete-organization.machine';

type DeleteOrganizationController =
| { status: 'loading' }
| { status: 'hidden' }
| {
status: 'ready';
snapshot: Snapshot<DeleteOrgContext>;
send: (event: DeleteOrgEvent) => void;
canSubmit: boolean;
};

export function useDeleteOrganizationController(): DeleteOrganizationController {
const { isLoaded: isOrganizationLoaded, organization } = useOrganization();
const { isLoaded: isSessionLoaded, session } = useSession();
const { userMemberships } = useOrganizationList({ userMemberships: true });

const [snapshot, send, actor] = useMachine(deleteOrgMachine, {
context: {
organizationName: organization?.name ?? '',
destroyOrganization: async () => {
await organization?.destroy();
// Refresh org lists elsewhere (e.g. the switcher). Not awaited: a stale
// list must not make a successful delete look like it failed.
void userMemberships.revalidate?.();
// TODO(mosaic): navigate away from the deleted org's profile once the flow
// has router context, mirroring legacy navigateAfterLeaveOrganization.
},
},
});

// The permission check needs both the organization and the session resolved.
// Treat either still loading as 'loading' so a not-yet-known session is never
// collapsed into a definitive 'hidden'.
if (!isOrganizationLoaded || !isSessionLoaded) {
return { status: 'loading' };
}

const canDelete = session?.checkAuthorization({ permission: 'org:sys_profile:delete' }) ?? false;
if (!organization || !canDelete || !organization.adminDeleteEnabled) {
return { status: 'hidden' };
}

return {
status: 'ready',
snapshot,
send,
canSubmit: actor.can({ type: 'CONFIRM' }),
};
}
9 changes: 5 additions & 4 deletions packages/ui/src/mosaic/sections/delete-organization.tsx
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,11 @@
import { SectionSkeleton } from '../components/section-skeleton';
import { useDeleteOrganizationController } from './delete-organization-controller';
import { DeleteOrganizationView } from './delete-organization-view';
import { useDeleteOrganizationController } from './delete-organization.controller';
import { DeleteOrganizationView } from './delete-organization.view';

export function DeleteOrganization() {
const controller = useDeleteOrganizationController();
if (controller.status === 'loading') return <SectionSkeleton />;
if (controller.status !== 'ready') {
return null;
}
return (
<DeleteOrganizationView
snapshot={controller.snapshot}
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -2,7 +2,7 @@ import { Destructive } from '../block/destructive';
import { Box } from '../components/box';
import { Button } from '../components/button';
import type { Snapshot } from '../machine/types';
import type { DeleteOrgContext, DeleteOrgEvent } from './delete-organization-machine';
import type { DeleteOrgContext, DeleteOrgEvent } from './delete-organization.machine';

interface DeleteOrganizationViewProps {
snapshot: Snapshot<DeleteOrgContext>;
Expand Down
Loading
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers"); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .changeset/mosaic-org-section-gating.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
---
---
Comment thread
alexcarpenter marked this conversation as resolved.
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
/** @jsxImportSource @emotion/react */
import { useMachine } from '@clerk/ui/mosaic/machine/useMachine';
import { deleteOrgMachine } from '@clerk/ui/mosaic/sections/delete-organization-machine';
import { DeleteOrganizationView } from '@clerk/ui/mosaic/sections/delete-organization-view';
import { deleteOrgMachine } from '@clerk/ui/mosaic/sections/delete-organization.machine';
import { DeleteOrganizationView } from '@clerk/ui/mosaic/sections/delete-organization.view';

import type { StoryMeta } from '@/lib/types';

Expand Down
4 changes: 2 additions & 2 deletions packages/swingset/src/stories/leave-organization.stories.tsx
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
/** @jsxImportSource @emotion/react */
import { useMachine } from '@clerk/ui/mosaic/machine/useMachine';
import { leaveOrgMachine } from '@clerk/ui/mosaic/sections/leave-organization-machine';
import { LeaveOrganizationView } from '@clerk/ui/mosaic/sections/leave-organization-view';
import { leaveOrgMachine } from '@clerk/ui/mosaic/sections/leave-organization.machine';
import { LeaveOrganizationView } from '@clerk/ui/mosaic/sections/leave-organization.view';

import type { StoryMeta } from '@/lib/types';

Expand Down
Original file line numberDiff line numberDiff line change
@@ -1,29 +1,38 @@
import { act, fireEvent, render, screen } from '@testing-library/react';
import React from 'react';
import { afterEach, beforeEach, describe, expect, it, vi } from 'vitest';

import { deferred } from '../../machines/__tests__/test-utils';
import { useDeleteOrganizationController } from '../delete-organization-controller';
import { useDeleteOrganizationController } from '../delete-organization.controller';

const ORG_NAME = 'Acme Inc';

let destroy: ReturnType<typeof vi.fn>;
let revalidate: ReturnType<typeof vi.fn>;
let organization: { id: string; name: string; destroy: () => Promise<void> } | null;
let checkAuthorization: ReturnType<typeof vi.fn>;
let isLoaded: boolean;
let isSessionLoaded: boolean;
let organization: { id: string; name: string; destroy: () => Promise<void>; adminDeleteEnabled: boolean } | null;

vi.mock('@clerk/shared/react', async importOriginal => {
const actual = await importOriginal<typeof import('@clerk/shared/react')>();
return {
...actual,
useOrganization: () => ({ isLoaded: true, organization, membership: null }),
useOrganization: () => ({ isLoaded, organization, membership: null }),
useOrganizationList: () => ({ userMemberships: { revalidate } }),
useSession: () => ({
isLoaded: isSessionLoaded,
session: isSessionLoaded ? { id: 'sess_1', checkAuthorization } : undefined,
}),
};
});

beforeEach(() => {
destroy = vi.fn();
revalidate = vi.fn().mockResolvedValue(undefined);
organization = { id: 'org_1', name: ORG_NAME, destroy };
checkAuthorization = vi.fn().mockReturnValue(true);
isLoaded = true;
isSessionLoaded = true;
organization = { id: 'org_1', name: ORG_NAME, destroy, adminDeleteEnabled: true };
});

afterEach(() => {
Expand All@@ -33,7 +42,7 @@ afterEach(() => {
function Harness() {
const controller = useDeleteOrganizationController();
if (controller.status !== 'ready') {
return <output data-testid='state'>loading</output>;
return <output data-testid='state'>{controller.status}</output>;
}
return (
<div>
Expand All@@ -53,6 +62,46 @@ function openAndConfirm() {
}

describe('useDeleteOrganizationController', () => {
it('is loading until useOrganization is loaded', () => {
isLoaded = false;

render(<Harness />);

expect(screen.getByTestId('state')).toHaveTextContent('loading');
});

it('is loading until the session is loaded', () => {
isSessionLoaded = false;

render(<Harness />);

expect(screen.getByTestId('state')).toHaveTextContent('loading');
expect(checkAuthorization).not.toHaveBeenCalled();
});

it('is ready when the user can delete and admin delete is enabled', () => {
render(<Harness />);

expect(screen.getByTestId('state')).toHaveTextContent('idle');
expect(checkAuthorization).toHaveBeenCalledWith({ permission: 'org:sys_profile:delete' });
});

it('is hidden when the user lacks the delete permission', () => {
checkAuthorization.mockReturnValue(false);

render(<Harness />);

expect(screen.getByTestId('state')).toHaveTextContent('hidden');
});

it('is hidden when admin delete is disabled', () => {
organization = { id: 'org_1', name: ORG_NAME, destroy, adminDeleteEnabled: false };

render(<Harness />);

expect(screen.getByTestId('state')).toHaveTextContent('hidden');
});

it('drives CONFIRM → deleting → resolve → deleted', async () => {
const gate = deferred<void>();
destroy.mockReturnValue(gate.promise);
Expand Down
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
import { describe, expect, it, vi } from 'vitest';

import { createActor } from '../../machine/createActor';
import { deleteOrgMachine } from '../delete-organization-machine';
import { deleteOrgMachine } from '../delete-organization.machine';

const tick = () => new Promise<void>(resolve => setTimeout(resolve, 0));

Expand Down
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,10 @@
import { fireEvent, render, screen } from '@testing-library/react';
import { describe, expect, it, vi } from 'vitest';

import { MosaicProvider } from '../../MosaicProvider';
import type { Snapshot } from '../../machine/types';
import type { DeleteOrgContext } from '../delete-organization-machine';
import { DeleteOrganizationView } from '../delete-organization-view';
import { MosaicProvider } from '../../MosaicProvider';
import type { DeleteOrgContext } from '../delete-organization.machine';
import { DeleteOrganizationView } from '../delete-organization.view';

function renderView(snapshot: Snapshot<DeleteOrgContext>, send = vi.fn(), canSubmit = false) {
render(
Expand Down
Original file line numberDiff line numberDiff line change
@@ -1,29 +1,30 @@
import { act, fireEvent, render, screen } from '@testing-library/react';
import React from 'react';
import { afterEach, beforeEach, describe, expect, it, vi } from 'vitest';

import { deferred } from '../../machines/__tests__/test-utils';
import { useLeaveOrganizationController } from '../leave-organization-controller';
import { useLeaveOrganizationController } from '../leave-organization.controller';

const ORG_NAME = 'Acme Inc';

let destroy: ReturnType<typeof vi.fn>;
let revalidate: ReturnType<typeof vi.fn>;
let isLoaded: boolean;
let organization: { id: string; name: string } | null;
let membership: { id: string; destroy: () => Promise<void> } | null;
let membership: { id: string; destroy: () => Promise<void> } | null | undefined;

vi.mock('@clerk/shared/react', async importOriginal => {
const actual = await importOriginal<typeof import('@clerk/shared/react')>();
return {
...actual,
useOrganization: () => ({ isLoaded: true, organization, membership }),
useOrganization: () => ({ isLoaded, organization, membership }),
useOrganizationList: () => ({ userMemberships: { revalidate } }),
};
});

beforeEach(() => {
destroy = vi.fn();
revalidate = vi.fn().mockResolvedValue(undefined);
isLoaded = true;
organization = { id: 'org_1', name: ORG_NAME };
membership = { id: 'mem_1', destroy };
});
Expand All@@ -35,7 +36,7 @@ afterEach(() => {
function Harness() {
const controller = useLeaveOrganizationController();
if (controller.status !== 'ready') {
return <output data-testid='state'>loading</output>;
return <output data-testid='state'>{controller.status}</output>;
}
return (
<div>
Expand All@@ -55,6 +56,38 @@ function openAndConfirm() {
}

describe('useLeaveOrganizationController', () => {
it('is loading until useOrganization is loaded', () => {
isLoaded = false;

render(<Harness />);

expect(screen.getByTestId('state')).toHaveTextContent('loading');
});

it('is loading while membership is still resolving', () => {
membership = undefined;

render(<Harness />);

expect(screen.getByTestId('state')).toHaveTextContent('loading');
});

it('is hidden when there is no active organization', () => {
organization = null;

render(<Harness />);

expect(screen.getByTestId('state')).toHaveTextContent('hidden');
});

it('is hidden when there is no membership', () => {
membership = null;

render(<Harness />);

expect(screen.getByTestId('state')).toHaveTextContent('hidden');
});

it('drives CONFIRM → leaving → resolve → left', async () => {
const gate = deferred<void>();
destroy.mockReturnValue(gate.promise);
Expand Down
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
import { describe, expect, it, vi } from 'vitest';

import { createActor } from '../../machine/createActor';
import { leaveOrgMachine } from '../leave-organization-machine';
import { leaveOrgMachine } from '../leave-organization.machine';

const tick = () => new Promise<void>(resolve => setTimeout(resolve, 0));

Expand Down
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,10 @@
import { fireEvent, render, screen } from '@testing-library/react';
import { describe, expect, it, vi } from 'vitest';

import { MosaicProvider } from '../../MosaicProvider';
import type { Snapshot } from '../../machine/types';
import type { LeaveOrgContext } from '../leave-organization-machine';
import { LeaveOrganizationView } from '../leave-organization-view';
import { MosaicProvider } from '../../MosaicProvider';
import type { LeaveOrgContext } from '../leave-organization.machine';
import { LeaveOrganizationView } from '../leave-organization.view';

function renderView(snapshot: Snapshot<LeaveOrgContext>, send = vi.fn(), canSubmit = false) {
render(
Expand Down

This file was deleted.

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,55 @@
import { useOrganization, useOrganizationList, useSession } from '@clerk/shared/react';

import type { Snapshot } from '../machine/types';
import { useMachine } from '../machine/useMachine';
import type { DeleteOrgContext, DeleteOrgEvent } from './delete-organization.machine';
import { deleteOrgMachine } from './delete-organization.machine';

type DeleteOrganizationController =
| { status: 'loading' }
| { status: 'hidden' }
| {
status: 'ready';
snapshot: Snapshot<DeleteOrgContext>;
send: (event: DeleteOrgEvent) => void;
canSubmit: boolean;
};

export function useDeleteOrganizationController(): DeleteOrganizationController {
const { isLoaded: isOrganizationLoaded, organization } = useOrganization();
const { isLoaded: isSessionLoaded, session } = useSession();
const { userMemberships } = useOrganizationList({ userMemberships: true });

const [snapshot, send, actor] = useMachine(deleteOrgMachine, {
context: {
organizationName: organization?.name ?? '',
destroyOrganization: async () => {
await organization?.destroy();
// Refresh org lists elsewhere (e.g. the switcher). Not awaited: a stale
// list must not make a successful delete look like it failed.
void userMemberships.revalidate?.();
// TODO(mosaic): navigate away from the deleted org's profile once the flow
// has router context, mirroring legacy navigateAfterLeaveOrganization.
},
},
});

// The permission check needs both the organization and the session resolved.
// Treat either still loading as 'loading' so a not-yet-known session is never
// collapsed into a definitive 'hidden'.
if (!isOrganizationLoaded || !isSessionLoaded) {
return { status: 'loading' };
}

const canDelete = session?.checkAuthorization({ permission: 'org:sys_profile:delete' }) ?? false;
if (!organization || !canDelete || !organization.adminDeleteEnabled) {
return { status: 'hidden' };
}

return {
status: 'ready',
snapshot,
send,
canSubmit: actor.can({ type: 'CONFIRM' }),
};
}
9 changes: 5 additions & 4 deletions packages/ui/src/mosaic/sections/delete-organization.tsx
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,11 @@
import { SectionSkeleton } from '../components/section-skeleton';
import { useDeleteOrganizationController } from './delete-organization-controller';
import { DeleteOrganizationView } from './delete-organization-view';
import { useDeleteOrganizationController } from './delete-organization.controller';
import { DeleteOrganizationView } from './delete-organization.view';

export function DeleteOrganization() {
const controller = useDeleteOrganizationController();
if (controller.status === 'loading') return <SectionSkeleton />;
if (controller.status !== 'ready') {
return null;
}
return (
<DeleteOrganizationView
snapshot={controller.snapshot}
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -2,7 +2,7 @@ import { Destructive } from '../block/destructive';
import { Box } from '../components/box';
import { Button } from '../components/button';
import type { Snapshot } from '../machine/types';
import type { DeleteOrgContext, DeleteOrgEvent } from './delete-organization-machine';
import type { DeleteOrgContext, DeleteOrgEvent } from './delete-organization.machine';

interface DeleteOrganizationViewProps {
snapshot: Snapshot<DeleteOrgContext>;
Expand Down
Loading
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode"); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })();
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .changeset/mosaic-org-section-gating.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
---
---
Comment thread
alexcarpenter marked this conversation as resolved.
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
/** @jsxImportSource @emotion/react */
import { useMachine } from '@clerk/ui/mosaic/machine/useMachine';
import { deleteOrgMachine } from '@clerk/ui/mosaic/sections/delete-organization-machine';
import { DeleteOrganizationView } from '@clerk/ui/mosaic/sections/delete-organization-view';
import { deleteOrgMachine } from '@clerk/ui/mosaic/sections/delete-organization.machine';
import { DeleteOrganizationView } from '@clerk/ui/mosaic/sections/delete-organization.view';

import type { StoryMeta } from '@/lib/types';

Expand Down
4 changes: 2 additions & 2 deletions packages/swingset/src/stories/leave-organization.stories.tsx
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
/** @jsxImportSource @emotion/react */
import { useMachine } from '@clerk/ui/mosaic/machine/useMachine';
import { leaveOrgMachine } from '@clerk/ui/mosaic/sections/leave-organization-machine';
import { LeaveOrganizationView } from '@clerk/ui/mosaic/sections/leave-organization-view';
import { leaveOrgMachine } from '@clerk/ui/mosaic/sections/leave-organization.machine';
import { LeaveOrganizationView } from '@clerk/ui/mosaic/sections/leave-organization.view';

import type { StoryMeta } from '@/lib/types';

Expand Down
Original file line numberDiff line numberDiff line change
@@ -1,29 +1,38 @@
import { act, fireEvent, render, screen } from '@testing-library/react';
import React from 'react';
import { afterEach, beforeEach, describe, expect, it, vi } from 'vitest';

import { deferred } from '../../machines/__tests__/test-utils';
import { useDeleteOrganizationController } from '../delete-organization-controller';
import { useDeleteOrganizationController } from '../delete-organization.controller';

const ORG_NAME = 'Acme Inc';

let destroy: ReturnType<typeof vi.fn>;
let revalidate: ReturnType<typeof vi.fn>;
let organization: { id: string; name: string; destroy: () => Promise<void> } | null;
let checkAuthorization: ReturnType<typeof vi.fn>;
let isLoaded: boolean;
let isSessionLoaded: boolean;
let organization: { id: string; name: string; destroy: () => Promise<void>; adminDeleteEnabled: boolean } | null;

vi.mock('@clerk/shared/react', async importOriginal => {
const actual = await importOriginal<typeof import('@clerk/shared/react')>();
return {
...actual,
useOrganization: () => ({ isLoaded: true, organization, membership: null }),
useOrganization: () => ({ isLoaded, organization, membership: null }),
useOrganizationList: () => ({ userMemberships: { revalidate } }),
useSession: () => ({
isLoaded: isSessionLoaded,
session: isSessionLoaded ? { id: 'sess_1', checkAuthorization } : undefined,
}),
};
});

beforeEach(() => {
destroy = vi.fn();
revalidate = vi.fn().mockResolvedValue(undefined);
organization = { id: 'org_1', name: ORG_NAME, destroy };
checkAuthorization = vi.fn().mockReturnValue(true);
isLoaded = true;
isSessionLoaded = true;
organization = { id: 'org_1', name: ORG_NAME, destroy, adminDeleteEnabled: true };
});

afterEach(() => {
Expand All@@ -33,7 +42,7 @@ afterEach(() => {
function Harness() {
const controller = useDeleteOrganizationController();
if (controller.status !== 'ready') {
return <output data-testid='state'>loading</output>;
return <output data-testid='state'>{controller.status}</output>;
}
return (
<div>
Expand All@@ -53,6 +62,46 @@ function openAndConfirm() {
}

describe('useDeleteOrganizationController', () => {
it('is loading until useOrganization is loaded', () => {
isLoaded = false;

render(<Harness />);

expect(screen.getByTestId('state')).toHaveTextContent('loading');
});

it('is loading until the session is loaded', () => {
isSessionLoaded = false;

render(<Harness />);

expect(screen.getByTestId('state')).toHaveTextContent('loading');
expect(checkAuthorization).not.toHaveBeenCalled();
});

it('is ready when the user can delete and admin delete is enabled', () => {
render(<Harness />);

expect(screen.getByTestId('state')).toHaveTextContent('idle');
expect(checkAuthorization).toHaveBeenCalledWith({ permission: 'org:sys_profile:delete' });
});

it('is hidden when the user lacks the delete permission', () => {
checkAuthorization.mockReturnValue(false);

render(<Harness />);

expect(screen.getByTestId('state')).toHaveTextContent('hidden');
});

it('is hidden when admin delete is disabled', () => {
organization = { id: 'org_1', name: ORG_NAME, destroy, adminDeleteEnabled: false };

render(<Harness />);

expect(screen.getByTestId('state')).toHaveTextContent('hidden');
});

it('drives CONFIRM → deleting → resolve → deleted', async () => {
const gate = deferred<void>();
destroy.mockReturnValue(gate.promise);
Expand Down
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
import { describe, expect, it, vi } from 'vitest';

import { createActor } from '../../machine/createActor';
import { deleteOrgMachine } from '../delete-organization-machine';
import { deleteOrgMachine } from '../delete-organization.machine';

const tick = () => new Promise<void>(resolve => setTimeout(resolve, 0));

Expand Down
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,10 @@
import { fireEvent, render, screen } from '@testing-library/react';
import { describe, expect, it, vi } from 'vitest';

import { MosaicProvider } from '../../MosaicProvider';
import type { Snapshot } from '../../machine/types';
import type { DeleteOrgContext } from '../delete-organization-machine';
import { DeleteOrganizationView } from '../delete-organization-view';
import { MosaicProvider } from '../../MosaicProvider';
import type { DeleteOrgContext } from '../delete-organization.machine';
import { DeleteOrganizationView } from '../delete-organization.view';

function renderView(snapshot: Snapshot<DeleteOrgContext>, send = vi.fn(), canSubmit = false) {
render(
Expand Down
Original file line numberDiff line numberDiff line change
@@ -1,29 +1,30 @@
import { act, fireEvent, render, screen } from '@testing-library/react';
import React from 'react';
import { afterEach, beforeEach, describe, expect, it, vi } from 'vitest';

import { deferred } from '../../machines/__tests__/test-utils';
import { useLeaveOrganizationController } from '../leave-organization-controller';
import { useLeaveOrganizationController } from '../leave-organization.controller';

const ORG_NAME = 'Acme Inc';

let destroy: ReturnType<typeof vi.fn>;
let revalidate: ReturnType<typeof vi.fn>;
let isLoaded: boolean;
let organization: { id: string; name: string } | null;
let membership: { id: string; destroy: () => Promise<void> } | null;
let membership: { id: string; destroy: () => Promise<void> } | null | undefined;

vi.mock('@clerk/shared/react', async importOriginal => {
const actual = await importOriginal<typeof import('@clerk/shared/react')>();
return {
...actual,
useOrganization: () => ({ isLoaded: true, organization, membership }),
useOrganization: () => ({ isLoaded, organization, membership }),
useOrganizationList: () => ({ userMemberships: { revalidate } }),
};
});

beforeEach(() => {
destroy = vi.fn();
revalidate = vi.fn().mockResolvedValue(undefined);
isLoaded = true;
organization = { id: 'org_1', name: ORG_NAME };
membership = { id: 'mem_1', destroy };
});
Expand All@@ -35,7 +36,7 @@ afterEach(() => {
function Harness() {
const controller = useLeaveOrganizationController();
if (controller.status !== 'ready') {
return <output data-testid='state'>loading</output>;
return <output data-testid='state'>{controller.status}</output>;
}
return (
<div>
Expand All@@ -55,6 +56,38 @@ function openAndConfirm() {
}

describe('useLeaveOrganizationController', () => {
it('is loading until useOrganization is loaded', () => {
isLoaded = false;

render(<Harness />);

expect(screen.getByTestId('state')).toHaveTextContent('loading');
});

it('is loading while membership is still resolving', () => {
membership = undefined;

render(<Harness />);

expect(screen.getByTestId('state')).toHaveTextContent('loading');
});

it('is hidden when there is no active organization', () => {
organization = null;

render(<Harness />);

expect(screen.getByTestId('state')).toHaveTextContent('hidden');
});

it('is hidden when there is no membership', () => {
membership = null;

render(<Harness />);

expect(screen.getByTestId('state')).toHaveTextContent('hidden');
});

it('drives CONFIRM → leaving → resolve → left', async () => {
const gate = deferred<void>();
destroy.mockReturnValue(gate.promise);
Expand Down
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
import { describe, expect, it, vi } from 'vitest';

import { createActor } from '../../machine/createActor';
import { leaveOrgMachine } from '../leave-organization-machine';
import { leaveOrgMachine } from '../leave-organization.machine';

const tick = () => new Promise<void>(resolve => setTimeout(resolve, 0));

Expand Down
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,10 @@
import { fireEvent, render, screen } from '@testing-library/react';
import { describe, expect, it, vi } from 'vitest';

import { MosaicProvider } from '../../MosaicProvider';
import type { Snapshot } from '../../machine/types';
import type { LeaveOrgContext } from '../leave-organization-machine';
import { LeaveOrganizationView } from '../leave-organization-view';
import { MosaicProvider } from '../../MosaicProvider';
import type { LeaveOrgContext } from '../leave-organization.machine';
import { LeaveOrganizationView } from '../leave-organization.view';

function renderView(snapshot: Snapshot<LeaveOrgContext>, send = vi.fn(), canSubmit = false) {
render(
Expand Down

This file was deleted.

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,55 @@
import { useOrganization, useOrganizationList, useSession } from '@clerk/shared/react';

import type { Snapshot } from '../machine/types';
import { useMachine } from '../machine/useMachine';
import type { DeleteOrgContext, DeleteOrgEvent } from './delete-organization.machine';
import { deleteOrgMachine } from './delete-organization.machine';

type DeleteOrganizationController =
| { status: 'loading' }
| { status: 'hidden' }
| {
status: 'ready';
snapshot: Snapshot<DeleteOrgContext>;
send: (event: DeleteOrgEvent) => void;
canSubmit: boolean;
};

export function useDeleteOrganizationController(): DeleteOrganizationController {
const { isLoaded: isOrganizationLoaded, organization } = useOrganization();
const { isLoaded: isSessionLoaded, session } = useSession();
const { userMemberships } = useOrganizationList({ userMemberships: true });

const [snapshot, send, actor] = useMachine(deleteOrgMachine, {
context: {
organizationName: organization?.name ?? '',
destroyOrganization: async () => {
await organization?.destroy();
// Refresh org lists elsewhere (e.g. the switcher). Not awaited: a stale
// list must not make a successful delete look like it failed.
void userMemberships.revalidate?.();
// TODO(mosaic): navigate away from the deleted org's profile once the flow
// has router context, mirroring legacy navigateAfterLeaveOrganization.
},
},
});

// The permission check needs both the organization and the session resolved.
// Treat either still loading as 'loading' so a not-yet-known session is never
// collapsed into a definitive 'hidden'.
if (!isOrganizationLoaded || !isSessionLoaded) {
return { status: 'loading' };
}

const canDelete = session?.checkAuthorization({ permission: 'org:sys_profile:delete' }) ?? false;
if (!organization || !canDelete || !organization.adminDeleteEnabled) {
return { status: 'hidden' };
}

return {
status: 'ready',
snapshot,
send,
canSubmit: actor.can({ type: 'CONFIRM' }),
};
}
9 changes: 5 additions & 4 deletions packages/ui/src/mosaic/sections/delete-organization.tsx
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,11 @@
import { SectionSkeleton } from '../components/section-skeleton';
import { useDeleteOrganizationController } from './delete-organization-controller';
import { DeleteOrganizationView } from './delete-organization-view';
import { useDeleteOrganizationController } from './delete-organization.controller';
import { DeleteOrganizationView } from './delete-organization.view';

export function DeleteOrganization() {
const controller = useDeleteOrganizationController();
if (controller.status === 'loading') return <SectionSkeleton />;
if (controller.status !== 'ready') {
return null;
}
return (
<DeleteOrganizationView
snapshot={controller.snapshot}
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -2,7 +2,7 @@ import { Destructive } from '../block/destructive';
import { Box } from '../components/box';
import { Button } from '../components/button';
import type { Snapshot } from '../machine/types';
import type { DeleteOrgContext, DeleteOrgEvent } from './delete-organization-machine';
import type { DeleteOrgContext, DeleteOrgEvent } from './delete-organization.machine';

interface DeleteOrganizationViewProps {
snapshot: Snapshot<DeleteOrgContext>;
Expand Down
Loading
Loading