Skip to content

fix(electron): default allowedRedirectProtocols to the renderer scheme - #9043

Merged
nicolas-angelo merged 4 commits into
mainfrom
fix/electron-redirect-protocol-from-scheme
Jun 30, 2026
Merged

fix(electron): default allowedRedirectProtocols to the renderer scheme#9043
nicolas-angelo merged 4 commits into
mainfrom
fix/electron-redirect-protocol-from-scheme

Conversation

@nicolas-angelo

@nicolas-angelonicolas-angelo commented Jun 30, 2026•
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Contributor

Description

Small DX win: today apps have to manually set allowedRedirectProtocols={['<scheme>:']} on <ClerkProvider> so Clerk's prebuilt-UI cross-links aren't rejected (i.e. the sign-up link on the SignIn component and the sign-in link on the SignUp component).

This PR makes it zero-config by deriving the scheme from the renderer's own origin (window.location.protocol, i.e. the scheme registered via createClerkBridge) and appending it to allowedRedirectProtocols internally by default.

The only exception to this new behavior is honoring explicit values (including []) which will override.

Testing: drop allowedRedirectProtocols from <ClerkProvider> and confirm in-app cross-links (sign-in ↔ sign-up) on auth components work properly.

Note on changeset level: scoped as a patch because the current default (no custom scheme in the allowlist) leaves the SDK's cross-links broken out of the box - so this feels more like a fix.

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • JSDoc comments have been added for the new behavior.
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation

Summary by CodeRabbit

  • New Features
    • Electron apps now automatically allow the renderer’s own custom protocol for redirect flows when applicable (e.g., clerk:).
    • You can still explicitly control redirect protocols via an allowedRedirectProtocols setting, including setting it to none.
  • Bug Fixes
    • Improved default redirect handling so custom renderer schemes work with no extra configuration.
    • file: renderers remain unchanged (not auto-allowed), and https: defaults are not added automatically.
  • Tests
    • Added coverage for defaulting and override behavior of redirect protocols.

@changeset-bot

changeset-botBot commented Jun 30, 2026•
edited
Loading

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 74d00ce

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
NameType
@clerk/electronPatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel

vercelBot commented Jun 30, 2026•
edited
Loading

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxReadyReadyPreview, CommentJun 30, 2026 8:37pm
swingsetReadyReadyPreview, CommentJun 30, 2026 8:37pm

Request Review

@coderabbitai

coderabbitaiBot commented Jun 30, 2026•
edited
Loading

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Repository UI (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: b7f9ca99-c862-4c14-a4ce-48f3dc49ebf4

📥 Commits

Reviewing files that changed from the base of the PR and between c5be752 and 74d00ce.

📒 Files selected for processing (1)
  • packages/electron/src/react/__tests__/ClerkProvider.test.tsx
🚧 Files skipped from review as they are similar to previous changes (1)
  • packages/electron/src/react/tests/ClerkProvider.test.tsx
📝 Walkthrough

Walkthrough

ClerkProvider in the Electron package now derives a default allowedRedirectProtocols value from window.location.protocol for custom renderer schemes, forwards it to ReactClerkProvider, and preserves any explicit prop value, including an empty array. Tests and release notes cover the new behavior.

Auto allowedRedirectProtocols for Electron renderer

Layer / File(s)Summary
Helper and provider wiring
packages/electron/src/react/index.tsx		defaultAllowedRedirectProtocols() reads window.location.protocol, returns a single custom scheme when appropriate, and ClerkProvider passes either the explicit prop or the derived default into ReactClerkProvider.
Behavior tests and changeset
packages/electron/src/react/__tests__/ClerkProvider.test.tsx, .changeset/electron-auto-allowed-redirect-protocols.md		Tests cover custom-scheme defaulting, https: and file: omission, and explicit overrides; the changeset documents the renderer protocol behavior.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Poem

🐇 Hop, hop, through the redirect gate,
clerk: joins the list at just the right rate.
https and file stay out of the cart,
explicit arrays still play their part.
Tiny hops, tidy paths, a protocol art ✨

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check nameStatusExplanationResolution
Docstring Coverage⚠️ WarningDocstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title clearly and concisely summarizes the main Electron change: defaulting allowedRedirectProtocols to the renderer scheme.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch

Comment @coderabbitai help to get the list of available commands.

@pkg-pr-new

pkg-pr-newBot commented Jun 30, 2026•
edited
Loading

Copy link
Copy Markdown

Open in StackBlitz

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@9043

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@9043

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@9043

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@9043

@clerk/electron

npm i https://pkg.pr.new/@clerk/electron@9043

@clerk/electron-passkeys

npm i https://pkg.pr.new/@clerk/electron-passkeys@9043

@clerk/eslint-plugin

npm i https://pkg.pr.new/@clerk/eslint-plugin@9043

@clerk/expo

npm i https://pkg.pr.new/@clerk/expo@9043

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@9043

@clerk/express

npm i https://pkg.pr.new/@clerk/express@9043

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@9043

@clerk/hono

npm i https://pkg.pr.new/@clerk/hono@9043

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@9043

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@9043

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@9043

@clerk/react

npm i https://pkg.pr.new/@clerk/react@9043

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@9043

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@9043

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@9043

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@9043

@clerk/ui

npm i https://pkg.pr.new/@clerk/ui@9043

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@9043

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@9043

commit: 74d00ce

wobsoriano
wobsoriano approved these changes Jun 30, 2026
View reviewed changes

@wobsorianowobsoriano left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, thanks!

@nicolas-angelo
nicolas-angelo merged commit d4bafb4 into mainJun 30, 2026
51 checks passed
@nicolas-angelo
nicolas-angelo deleted the fix/electron-redirect-protocol-from-scheme branch June 30, 2026 20:41
@clerk-cookieclerk-cookie mentioned this pull request Jun 30, 2026
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wobsorianowobsorianowobsoriano approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@nicolas-angelo@wobsoriano
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
fix(electron): default allowedRedirectProtocols to the renderer scheme by nicolas-angelo · Pull Request #9043 · clerk/javascript · GitHub
Skip to content
fix(electron): default allowedRedirectProtocols to the renderer scheme - #9043
Merged
nicolas-angelo merged 4 commits into
mainfrom 
fix/electron-redirect-protocol-from-scheme
Jun 30, 2026
Merged
fix(electron): default allowedRedirectProtocols to the renderer scheme#9043
nicolas-angelo merged 4 commits into
mainfrom 
fix/electron-redirect-protocol-from-scheme
Conversation
@nicolas-angelo
@nicolas-angelonicolas-angelo
commented
Jun 30, 2026•

edited by coderabbitai
Bot
Loading

Copy link


Copy Markdown

Contributor
Description
Small DX win: today apps have to manually set allowedRedirectProtocols={['<scheme>:']} on <ClerkProvider> so Clerk's prebuilt-UI cross-links aren't rejected (i.e. the sign-up link on the SignIn component and the sign-in link on the SignUp component).
This PR makes it zero-config by deriving the scheme from the renderer's own origin (window.location.protocol, i.e. the scheme registered via createClerkBridge) and appending it to allowedRedirectProtocols internally by default.
The only exception to this new behavior is honoring explicit values (including []) which will override.
Testing: drop allowedRedirectProtocols from <ClerkProvider> and confirm in-app cross-links (sign-in ↔ sign-up) on auth components work properly.
Note on changeset level: scoped as a patch because the current default (no custom scheme in the allowlist) leaves the SDK's cross-links broken out of the box - so this feels more like a fix.
Checklist
  • pnpm test runs as expected.
  • pnpm build runs as expected.
  •  JSDoc comments have been added for the new behavior.
  •  (If applicable) Documentation has been updated
Type of change
  •  🐛 Bug fix
  •  🌟 New feature
  •  🔨 Breaking change
  •  📖 Refactoring / dependency upgrade / documentation
Summary by CodeRabbit
  • New Features
    • Electron apps now automatically allow the renderer’s own custom protocol for redirect flows when applicable (e.g., clerk:).
    • You can still explicitly control redirect protocols via an allowedRedirectProtocols setting, including setting it to none.
  • Bug Fixes
    • Improved default redirect handling so custom renderer schemes work with no extra configuration.
    • file: renderers remain unchanged (not auto-allowed), and https: defaults are not added automatically.
  • Tests
    • Added coverage for defaulting and override behavior of redirect protocols.
@changeset-bot
changeset-botBot
commented
Jun 30, 2026•

edited

Loading

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: 74d00ce
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 1 package
NameType
@clerk/electronPatch
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@vercel
vercelBot
commented
Jun 30, 2026•

edited

Loading

Copy link


Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.
ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxReadyReadyPreview, CommentJun 30, 2026 8:37pm
swingsetReadyReadyPreview, CommentJun 30, 2026 8:37pm
Request Review
@coderabbitai
coderabbitaiBot
commented
Jun 30, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Review Change Stack
No actionable comments were generated in the recent review. 🎉
ℹ️ Recent review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Repository UI (inherited)
Review profile: CHILL
Plan: Pro Plus
Run ID: b7f9ca99-c862-4c14-a4ce-48f3dc49ebf4
📥 Commits
Reviewing files that changed from the base of the PR and between c5be752 and 74d00ce.
📒 Files selected for processing (1)
  • packages/electron/src/react/__tests__/ClerkProvider.test.tsx
🚧 Files skipped from review as they are similar to previous changes (1)
  • packages/electron/src/react/tests/ClerkProvider.test.tsx
📝 Walkthrough
Walkthrough
ClerkProvider in the Electron package now derives a default allowedRedirectProtocols value from window.location.protocol for custom renderer schemes, forwards it to ReactClerkProvider, and preserves any explicit prop value, including an empty array. Tests and release notes cover the new behavior.
Auto allowedRedirectProtocols for Electron renderer
Layer / File(s)Summary
Helper and provider wiring
packages/electron/src/react/index.tsx		defaultAllowedRedirectProtocols() reads window.location.protocol, returns a single custom scheme when appropriate, and ClerkProvider passes either the explicit prop or the derived default into ReactClerkProvider.
Behavior tests and changeset
packages/electron/src/react/__tests__/ClerkProvider.test.tsx, .changeset/electron-auto-allowed-redirect-protocols.md		Tests cover custom-scheme defaulting, https: and file: omission, and explicit overrides; the changeset documents the renderer protocol behavior.
Estimated code review effort
🎯 2 (Simple) | ⏱️ ~8 minutes
Poem
🐇 Hop, hop, through the redirect gate,
clerk: joins the list at just the right rate.
https and file stay out of the cart,

explicit arrays still play their part.

Tiny hops, tidy paths, a protocol art ✨
🚥 Pre-merge checks | ✅ 4 | ❌ 1
❌ Failed checks (1 warning)
Check nameStatusExplanationResolution
Docstring Coverage⚠️ WarningDocstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title clearly and concisely summarizes the main Electron change: defaulting allowedRedirectProtocols to the renderer scheme.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  •  Create stacked PR
  •  Commit on current branch
Comment @coderabbitai help to get the list of available commands.
@pkg-pr-new
pkg-pr-newBot
commented
Jun 30, 2026•

edited

Loading

Copy link


Copy Markdown

Open in StackBlitz
@clerk/astro
npm i https://pkg.pr.new/@clerk/astro@9043

@clerk/backend
npm i https://pkg.pr.new/@clerk/backend@9043

@clerk/chrome-extension
npm i https://pkg.pr.new/@clerk/chrome-extension@9043

@clerk/clerk-js
npm i https://pkg.pr.new/@clerk/clerk-js@9043

@clerk/electron
npm i https://pkg.pr.new/@clerk/electron@9043

@clerk/electron-passkeys
npm i https://pkg.pr.new/@clerk/electron-passkeys@9043

@clerk/eslint-plugin
npm i https://pkg.pr.new/@clerk/eslint-plugin@9043

@clerk/expo
npm i https://pkg.pr.new/@clerk/expo@9043

@clerk/expo-passkeys
npm i https://pkg.pr.new/@clerk/expo-passkeys@9043

@clerk/express
npm i https://pkg.pr.new/@clerk/express@9043

@clerk/fastify
npm i https://pkg.pr.new/@clerk/fastify@9043

@clerk/hono
npm i https://pkg.pr.new/@clerk/hono@9043

@clerk/localizations
npm i https://pkg.pr.new/@clerk/localizations@9043

@clerk/nextjs
npm i https://pkg.pr.new/@clerk/nextjs@9043

@clerk/nuxt
npm i https://pkg.pr.new/@clerk/nuxt@9043

@clerk/react
npm i https://pkg.pr.new/@clerk/react@9043

@clerk/react-router
npm i https://pkg.pr.new/@clerk/react-router@9043

@clerk/shared
npm i https://pkg.pr.new/@clerk/shared@9043

@clerk/tanstack-react-start
npm i https://pkg.pr.new/@clerk/tanstack-react-start@9043

@clerk/testing
npm i https://pkg.pr.new/@clerk/testing@9043

@clerk/ui
npm i https://pkg.pr.new/@clerk/ui@9043

@clerk/upgrade
npm i https://pkg.pr.new/@clerk/upgrade@9043

@clerk/vue
npm i https://pkg.pr.new/@clerk/vue@9043

commit: 74d00ce
wobsoriano
wobsoriano
approved these changes
Jun 30, 2026
View reviewed changes
@wobsorianowobsoriano
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, thanks!
@nicolas-angelo
nicolas-angelo
merged commit d4bafb4
into
mainJun 30, 2026

51 checks passed

@nicolas-angelo
nicolas-angelo
deleted the

fix/electron-redirect-protocol-from-scheme

branch
June 30, 2026 20:41
@clerk-cookieclerk-cookie
mentioned this pull request
Jun 30, 2026
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@wobsorianowobsorianowobsoriano approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@nicolas-angelo@wobsoriano

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
fix(electron): default allowedRedirectProtocols to the renderer scheme by nicolas-angelo · Pull Request #9043 · clerk/javascript · GitHub
Skip to content
fix(electron): default allowedRedirectProtocols to the renderer scheme - #9043
Merged
nicolas-angelo merged 4 commits into
mainfrom 
fix/electron-redirect-protocol-from-scheme
Jun 30, 2026
Merged
fix(electron): default allowedRedirectProtocols to the renderer scheme#9043
nicolas-angelo merged 4 commits into
mainfrom 
fix/electron-redirect-protocol-from-scheme
Conversation
@nicolas-angelo
@nicolas-angelonicolas-angelo
commented
Jun 30, 2026•

edited by coderabbitai
Bot
Loading

Copy link


Copy Markdown

Contributor
Description
Small DX win: today apps have to manually set allowedRedirectProtocols={['<scheme>:']} on <ClerkProvider> so Clerk's prebuilt-UI cross-links aren't rejected (i.e. the sign-up link on the SignIn component and the sign-in link on the SignUp component).
This PR makes it zero-config by deriving the scheme from the renderer's own origin (window.location.protocol, i.e. the scheme registered via createClerkBridge) and appending it to allowedRedirectProtocols internally by default.
The only exception to this new behavior is honoring explicit values (including []) which will override.
Testing: drop allowedRedirectProtocols from <ClerkProvider> and confirm in-app cross-links (sign-in ↔ sign-up) on auth components work properly.
Note on changeset level: scoped as a patch because the current default (no custom scheme in the allowlist) leaves the SDK's cross-links broken out of the box - so this feels more like a fix.
Checklist
  • pnpm test runs as expected.
  • pnpm build runs as expected.
  •  JSDoc comments have been added for the new behavior.
  •  (If applicable) Documentation has been updated
Type of change
  •  🐛 Bug fix
  •  🌟 New feature
  •  🔨 Breaking change
  •  📖 Refactoring / dependency upgrade / documentation
Summary by CodeRabbit
  • New Features
    • Electron apps now automatically allow the renderer’s own custom protocol for redirect flows when applicable (e.g., clerk:).
    • You can still explicitly control redirect protocols via an allowedRedirectProtocols setting, including setting it to none.
  • Bug Fixes
    • Improved default redirect handling so custom renderer schemes work with no extra configuration.
    • file: renderers remain unchanged (not auto-allowed), and https: defaults are not added automatically.
  • Tests
    • Added coverage for defaulting and override behavior of redirect protocols.
@changeset-bot
changeset-botBot
commented
Jun 30, 2026•

edited

Loading

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: 74d00ce
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 1 package
NameType
@clerk/electronPatch
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@vercel
vercelBot
commented
Jun 30, 2026•

edited

Loading

Copy link


Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.
ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxReadyReadyPreview, CommentJun 30, 2026 8:37pm
swingsetReadyReadyPreview, CommentJun 30, 2026 8:37pm
Request Review
@coderabbitai
coderabbitaiBot
commented
Jun 30, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Review Change Stack
No actionable comments were generated in the recent review. 🎉
ℹ️ Recent review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Repository UI (inherited)
Review profile: CHILL
Plan: Pro Plus
Run ID: b7f9ca99-c862-4c14-a4ce-48f3dc49ebf4
📥 Commits
Reviewing files that changed from the base of the PR and between c5be752 and 74d00ce.
📒 Files selected for processing (1)
  • packages/electron/src/react/__tests__/ClerkProvider.test.tsx
🚧 Files skipped from review as they are similar to previous changes (1)
  • packages/electron/src/react/tests/ClerkProvider.test.tsx
📝 Walkthrough
Walkthrough
ClerkProvider in the Electron package now derives a default allowedRedirectProtocols value from window.location.protocol for custom renderer schemes, forwards it to ReactClerkProvider, and preserves any explicit prop value, including an empty array. Tests and release notes cover the new behavior.
Auto allowedRedirectProtocols for Electron renderer
Layer / File(s)Summary
Helper and provider wiring
packages/electron/src/react/index.tsx		defaultAllowedRedirectProtocols() reads window.location.protocol, returns a single custom scheme when appropriate, and ClerkProvider passes either the explicit prop or the derived default into ReactClerkProvider.
Behavior tests and changeset
packages/electron/src/react/__tests__/ClerkProvider.test.tsx, .changeset/electron-auto-allowed-redirect-protocols.md		Tests cover custom-scheme defaulting, https: and file: omission, and explicit overrides; the changeset documents the renderer protocol behavior.
Estimated code review effort
🎯 2 (Simple) | ⏱️ ~8 minutes
Poem
🐇 Hop, hop, through the redirect gate,
clerk: joins the list at just the right rate.
https and file stay out of the cart,

explicit arrays still play their part.

Tiny hops, tidy paths, a protocol art ✨
🚥 Pre-merge checks | ✅ 4 | ❌ 1
❌ Failed checks (1 warning)
Check nameStatusExplanationResolution
Docstring Coverage⚠️ WarningDocstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title clearly and concisely summarizes the main Electron change: defaulting allowedRedirectProtocols to the renderer scheme.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  •  Create stacked PR
  •  Commit on current branch
Comment @coderabbitai help to get the list of available commands.
@pkg-pr-new
pkg-pr-newBot
commented
Jun 30, 2026•

edited

Loading

Copy link


Copy Markdown

Open in StackBlitz
@clerk/astro
npm i https://pkg.pr.new/@clerk/astro@9043

@clerk/backend
npm i https://pkg.pr.new/@clerk/backend@9043

@clerk/chrome-extension
npm i https://pkg.pr.new/@clerk/chrome-extension@9043

@clerk/clerk-js
npm i https://pkg.pr.new/@clerk/clerk-js@9043

@clerk/electron
npm i https://pkg.pr.new/@clerk/electron@9043

@clerk/electron-passkeys
npm i https://pkg.pr.new/@clerk/electron-passkeys@9043

@clerk/eslint-plugin
npm i https://pkg.pr.new/@clerk/eslint-plugin@9043

@clerk/expo
npm i https://pkg.pr.new/@clerk/expo@9043

@clerk/expo-passkeys
npm i https://pkg.pr.new/@clerk/expo-passkeys@9043

@clerk/express
npm i https://pkg.pr.new/@clerk/express@9043

@clerk/fastify
npm i https://pkg.pr.new/@clerk/fastify@9043

@clerk/hono
npm i https://pkg.pr.new/@clerk/hono@9043

@clerk/localizations
npm i https://pkg.pr.new/@clerk/localizations@9043

@clerk/nextjs
npm i https://pkg.pr.new/@clerk/nextjs@9043

@clerk/nuxt
npm i https://pkg.pr.new/@clerk/nuxt@9043

@clerk/react
npm i https://pkg.pr.new/@clerk/react@9043

@clerk/react-router
npm i https://pkg.pr.new/@clerk/react-router@9043

@clerk/shared
npm i https://pkg.pr.new/@clerk/shared@9043

@clerk/tanstack-react-start
npm i https://pkg.pr.new/@clerk/tanstack-react-start@9043

@clerk/testing
npm i https://pkg.pr.new/@clerk/testing@9043

@clerk/ui
npm i https://pkg.pr.new/@clerk/ui@9043

@clerk/upgrade
npm i https://pkg.pr.new/@clerk/upgrade@9043

@clerk/vue
npm i https://pkg.pr.new/@clerk/vue@9043

commit: 74d00ce
wobsoriano
wobsoriano
approved these changes
Jun 30, 2026
View reviewed changes
@wobsorianowobsoriano
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, thanks!
@nicolas-angelo
nicolas-angelo
merged commit d4bafb4
into
mainJun 30, 2026

51 checks passed

@nicolas-angelo
nicolas-angelo
deleted the

fix/electron-redirect-protocol-from-scheme

branch
June 30, 2026 20:41
@clerk-cookieclerk-cookie
mentioned this pull request
Jun 30, 2026
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@wobsorianowobsorianowobsoriano approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@nicolas-angelo@wobsoriano

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
fix(electron): default allowedRedirectProtocols to the renderer scheme by nicolas-angelo · Pull Request #9043 · clerk/javascript · GitHub
Skip to content
fix(electron): default allowedRedirectProtocols to the renderer scheme - #9043
Merged
nicolas-angelo merged 4 commits into
mainfrom 
fix/electron-redirect-protocol-from-scheme
Jun 30, 2026
Merged
fix(electron): default allowedRedirectProtocols to the renderer scheme#9043
nicolas-angelo merged 4 commits into
mainfrom 
fix/electron-redirect-protocol-from-scheme
Conversation
@nicolas-angelo
@nicolas-angelonicolas-angelo
commented
Jun 30, 2026•

edited by coderabbitai
Bot
Loading

Copy link


Copy Markdown

Contributor
Description
Small DX win: today apps have to manually set allowedRedirectProtocols={['<scheme>:']} on <ClerkProvider> so Clerk's prebuilt-UI cross-links aren't rejected (i.e. the sign-up link on the SignIn component and the sign-in link on the SignUp component).
This PR makes it zero-config by deriving the scheme from the renderer's own origin (window.location.protocol, i.e. the scheme registered via createClerkBridge) and appending it to allowedRedirectProtocols internally by default.
The only exception to this new behavior is honoring explicit values (including []) which will override.
Testing: drop allowedRedirectProtocols from <ClerkProvider> and confirm in-app cross-links (sign-in ↔ sign-up) on auth components work properly.
Note on changeset level: scoped as a patch because the current default (no custom scheme in the allowlist) leaves the SDK's cross-links broken out of the box - so this feels more like a fix.
Checklist
  • pnpm test runs as expected.
  • pnpm build runs as expected.
  •  JSDoc comments have been added for the new behavior.
  •  (If applicable) Documentation has been updated
Type of change
  •  🐛 Bug fix
  •  🌟 New feature
  •  🔨 Breaking change
  •  📖 Refactoring / dependency upgrade / documentation
Summary by CodeRabbit
  • New Features
    • Electron apps now automatically allow the renderer’s own custom protocol for redirect flows when applicable (e.g., clerk:).
    • You can still explicitly control redirect protocols via an allowedRedirectProtocols setting, including setting it to none.
  • Bug Fixes
    • Improved default redirect handling so custom renderer schemes work with no extra configuration.
    • file: renderers remain unchanged (not auto-allowed), and https: defaults are not added automatically.
  • Tests
    • Added coverage for defaulting and override behavior of redirect protocols.
@changeset-bot
changeset-botBot
commented
Jun 30, 2026•

edited

Loading

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: 74d00ce
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 1 package
NameType
@clerk/electronPatch
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@vercel
vercelBot
commented
Jun 30, 2026•

edited

Loading

Copy link


Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.
ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxReadyReadyPreview, CommentJun 30, 2026 8:37pm
swingsetReadyReadyPreview, CommentJun 30, 2026 8:37pm
Request Review
@coderabbitai
coderabbitaiBot
commented
Jun 30, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Review Change Stack
No actionable comments were generated in the recent review. 🎉
ℹ️ Recent review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Repository UI (inherited)
Review profile: CHILL
Plan: Pro Plus
Run ID: b7f9ca99-c862-4c14-a4ce-48f3dc49ebf4
📥 Commits
Reviewing files that changed from the base of the PR and between c5be752 and 74d00ce.
📒 Files selected for processing (1)
  • packages/electron/src/react/__tests__/ClerkProvider.test.tsx
🚧 Files skipped from review as they are similar to previous changes (1)
  • packages/electron/src/react/tests/ClerkProvider.test.tsx
📝 Walkthrough
Walkthrough
ClerkProvider in the Electron package now derives a default allowedRedirectProtocols value from window.location.protocol for custom renderer schemes, forwards it to ReactClerkProvider, and preserves any explicit prop value, including an empty array. Tests and release notes cover the new behavior.
Auto allowedRedirectProtocols for Electron renderer
Layer / File(s)Summary
Helper and provider wiring
packages/electron/src/react/index.tsx		defaultAllowedRedirectProtocols() reads window.location.protocol, returns a single custom scheme when appropriate, and ClerkProvider passes either the explicit prop or the derived default into ReactClerkProvider.
Behavior tests and changeset
packages/electron/src/react/__tests__/ClerkProvider.test.tsx, .changeset/electron-auto-allowed-redirect-protocols.md		Tests cover custom-scheme defaulting, https: and file: omission, and explicit overrides; the changeset documents the renderer protocol behavior.
Estimated code review effort
🎯 2 (Simple) | ⏱️ ~8 minutes
Poem
🐇 Hop, hop, through the redirect gate,
clerk: joins the list at just the right rate.
https and file stay out of the cart,

explicit arrays still play their part.

Tiny hops, tidy paths, a protocol art ✨
🚥 Pre-merge checks | ✅ 4 | ❌ 1
❌ Failed checks (1 warning)
Check nameStatusExplanationResolution
Docstring Coverage⚠️ WarningDocstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title clearly and concisely summarizes the main Electron change: defaulting allowedRedirectProtocols to the renderer scheme.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  •  Create stacked PR
  •  Commit on current branch
Comment @coderabbitai help to get the list of available commands.
@pkg-pr-new
pkg-pr-newBot
commented
Jun 30, 2026•

edited

Loading

Copy link


Copy Markdown

Open in StackBlitz
@clerk/astro
npm i https://pkg.pr.new/@clerk/astro@9043

@clerk/backend
npm i https://pkg.pr.new/@clerk/backend@9043

@clerk/chrome-extension
npm i https://pkg.pr.new/@clerk/chrome-extension@9043

@clerk/clerk-js
npm i https://pkg.pr.new/@clerk/clerk-js@9043

@clerk/electron
npm i https://pkg.pr.new/@clerk/electron@9043

@clerk/electron-passkeys
npm i https://pkg.pr.new/@clerk/electron-passkeys@9043

@clerk/eslint-plugin
npm i https://pkg.pr.new/@clerk/eslint-plugin@9043

@clerk/expo
npm i https://pkg.pr.new/@clerk/expo@9043

@clerk/expo-passkeys
npm i https://pkg.pr.new/@clerk/expo-passkeys@9043

@clerk/express
npm i https://pkg.pr.new/@clerk/express@9043

@clerk/fastify
npm i https://pkg.pr.new/@clerk/fastify@9043

@clerk/hono
npm i https://pkg.pr.new/@clerk/hono@9043

@clerk/localizations
npm i https://pkg.pr.new/@clerk/localizations@9043

@clerk/nextjs
npm i https://pkg.pr.new/@clerk/nextjs@9043

@clerk/nuxt
npm i https://pkg.pr.new/@clerk/nuxt@9043

@clerk/react
npm i https://pkg.pr.new/@clerk/react@9043

@clerk/react-router
npm i https://pkg.pr.new/@clerk/react-router@9043

@clerk/shared
npm i https://pkg.pr.new/@clerk/shared@9043

@clerk/tanstack-react-start
npm i https://pkg.pr.new/@clerk/tanstack-react-start@9043

@clerk/testing
npm i https://pkg.pr.new/@clerk/testing@9043

@clerk/ui
npm i https://pkg.pr.new/@clerk/ui@9043

@clerk/upgrade
npm i https://pkg.pr.new/@clerk/upgrade@9043

@clerk/vue
npm i https://pkg.pr.new/@clerk/vue@9043

commit: 74d00ce
wobsoriano
wobsoriano
approved these changes
Jun 30, 2026
View reviewed changes
@wobsorianowobsoriano
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, thanks!
@nicolas-angelo
nicolas-angelo
merged commit d4bafb4
into
mainJun 30, 2026

51 checks passed

@nicolas-angelo
nicolas-angelo
deleted the

fix/electron-redirect-protocol-from-scheme

branch
June 30, 2026 20:41
@clerk-cookieclerk-cookie
mentioned this pull request
Jun 30, 2026
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@wobsorianowobsorianowobsoriano approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@nicolas-angelo@wobsoriano

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '
fix(electron): default allowedRedirectProtocols to the renderer scheme by nicolas-angelo · Pull Request #9043 · clerk/javascript · GitHub
Skip to content
fix(electron): default allowedRedirectProtocols to the renderer scheme - #9043
Merged
nicolas-angelo merged 4 commits into
mainfrom 
fix/electron-redirect-protocol-from-scheme
Jun 30, 2026
Merged
fix(electron): default allowedRedirectProtocols to the renderer scheme#9043
nicolas-angelo merged 4 commits into
mainfrom 
fix/electron-redirect-protocol-from-scheme
Conversation
@nicolas-angelo
@nicolas-angelonicolas-angelo
commented
Jun 30, 2026•

edited by coderabbitai
Bot
Loading

Copy link


Copy Markdown

Contributor
Description
Small DX win: today apps have to manually set allowedRedirectProtocols={['<scheme>:']} on <ClerkProvider> so Clerk's prebuilt-UI cross-links aren't rejected (i.e. the sign-up link on the SignIn component and the sign-in link on the SignUp component).
This PR makes it zero-config by deriving the scheme from the renderer's own origin (window.location.protocol, i.e. the scheme registered via createClerkBridge) and appending it to allowedRedirectProtocols internally by default.
The only exception to this new behavior is honoring explicit values (including []) which will override.
Testing: drop allowedRedirectProtocols from <ClerkProvider> and confirm in-app cross-links (sign-in ↔ sign-up) on auth components work properly.
Note on changeset level: scoped as a patch because the current default (no custom scheme in the allowlist) leaves the SDK's cross-links broken out of the box - so this feels more like a fix.
Checklist
  • pnpm test runs as expected.
  • pnpm build runs as expected.
  •  JSDoc comments have been added for the new behavior.
  •  (If applicable) Documentation has been updated
Type of change
  •  🐛 Bug fix
  •  🌟 New feature
  •  🔨 Breaking change
  •  📖 Refactoring / dependency upgrade / documentation
Summary by CodeRabbit
  • New Features
    • Electron apps now automatically allow the renderer’s own custom protocol for redirect flows when applicable (e.g., clerk:).
    • You can still explicitly control redirect protocols via an allowedRedirectProtocols setting, including setting it to none.
  • Bug Fixes
    • Improved default redirect handling so custom renderer schemes work with no extra configuration.
    • file: renderers remain unchanged (not auto-allowed), and https: defaults are not added automatically.
  • Tests
    • Added coverage for defaulting and override behavior of redirect protocols.
@changeset-bot
changeset-botBot
commented
Jun 30, 2026•

edited

Loading

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: 74d00ce
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 1 package
NameType
@clerk/electronPatch
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@vercel
vercelBot
commented
Jun 30, 2026•

edited

Loading

Copy link


Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.
ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxReadyReadyPreview, CommentJun 30, 2026 8:37pm
swingsetReadyReadyPreview, CommentJun 30, 2026 8:37pm
Request Review
@coderabbitai
coderabbitaiBot
commented
Jun 30, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Review Change Stack
No actionable comments were generated in the recent review. 🎉
ℹ️ Recent review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Repository UI (inherited)
Review profile: CHILL
Plan: Pro Plus
Run ID: b7f9ca99-c862-4c14-a4ce-48f3dc49ebf4
📥 Commits
Reviewing files that changed from the base of the PR and between c5be752 and 74d00ce.
📒 Files selected for processing (1)
  • packages/electron/src/react/__tests__/ClerkProvider.test.tsx
🚧 Files skipped from review as they are similar to previous changes (1)
  • packages/electron/src/react/tests/ClerkProvider.test.tsx
📝 Walkthrough
Walkthrough
ClerkProvider in the Electron package now derives a default allowedRedirectProtocols value from window.location.protocol for custom renderer schemes, forwards it to ReactClerkProvider, and preserves any explicit prop value, including an empty array. Tests and release notes cover the new behavior.
Auto allowedRedirectProtocols for Electron renderer
Layer / File(s)Summary
Helper and provider wiring
packages/electron/src/react/index.tsx		defaultAllowedRedirectProtocols() reads window.location.protocol, returns a single custom scheme when appropriate, and ClerkProvider passes either the explicit prop or the derived default into ReactClerkProvider.
Behavior tests and changeset
packages/electron/src/react/__tests__/ClerkProvider.test.tsx, .changeset/electron-auto-allowed-redirect-protocols.md		Tests cover custom-scheme defaulting, https: and file: omission, and explicit overrides; the changeset documents the renderer protocol behavior.
Estimated code review effort
🎯 2 (Simple) | ⏱️ ~8 minutes
Poem
🐇 Hop, hop, through the redirect gate,
clerk: joins the list at just the right rate.
https and file stay out of the cart,

explicit arrays still play their part.

Tiny hops, tidy paths, a protocol art ✨
🚥 Pre-merge checks | ✅ 4 | ❌ 1
❌ Failed checks (1 warning)
Check nameStatusExplanationResolution
Docstring Coverage⚠️ WarningDocstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title clearly and concisely summarizes the main Electron change: defaulting allowedRedirectProtocols to the renderer scheme.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  •  Create stacked PR
  •  Commit on current branch
Comment @coderabbitai help to get the list of available commands.
@pkg-pr-new
pkg-pr-newBot
commented
Jun 30, 2026•

edited

Loading

Copy link


Copy Markdown

Open in StackBlitz
@clerk/astro
npm i https://pkg.pr.new/@clerk/astro@9043

@clerk/backend
npm i https://pkg.pr.new/@clerk/backend@9043

@clerk/chrome-extension
npm i https://pkg.pr.new/@clerk/chrome-extension@9043

@clerk/clerk-js
npm i https://pkg.pr.new/@clerk/clerk-js@9043

@clerk/electron
npm i https://pkg.pr.new/@clerk/electron@9043

@clerk/electron-passkeys
npm i https://pkg.pr.new/@clerk/electron-passkeys@9043

@clerk/eslint-plugin
npm i https://pkg.pr.new/@clerk/eslint-plugin@9043

@clerk/expo
npm i https://pkg.pr.new/@clerk/expo@9043

@clerk/expo-passkeys
npm i https://pkg.pr.new/@clerk/expo-passkeys@9043

@clerk/express
npm i https://pkg.pr.new/@clerk/express@9043

@clerk/fastify
npm i https://pkg.pr.new/@clerk/fastify@9043

@clerk/hono
npm i https://pkg.pr.new/@clerk/hono@9043

@clerk/localizations
npm i https://pkg.pr.new/@clerk/localizations@9043

@clerk/nextjs
npm i https://pkg.pr.new/@clerk/nextjs@9043

@clerk/nuxt
npm i https://pkg.pr.new/@clerk/nuxt@9043

@clerk/react
npm i https://pkg.pr.new/@clerk/react@9043

@clerk/react-router
npm i https://pkg.pr.new/@clerk/react-router@9043

@clerk/shared
npm i https://pkg.pr.new/@clerk/shared@9043

@clerk/tanstack-react-start
npm i https://pkg.pr.new/@clerk/tanstack-react-start@9043

@clerk/testing
npm i https://pkg.pr.new/@clerk/testing@9043

@clerk/ui
npm i https://pkg.pr.new/@clerk/ui@9043

@clerk/upgrade
npm i https://pkg.pr.new/@clerk/upgrade@9043

@clerk/vue
npm i https://pkg.pr.new/@clerk/vue@9043

commit: 74d00ce
wobsoriano
wobsoriano
approved these changes
Jun 30, 2026
View reviewed changes
@wobsorianowobsoriano
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, thanks!
@nicolas-angelo
nicolas-angelo
merged commit d4bafb4
into
mainJun 30, 2026

51 checks passed

@nicolas-angelo
nicolas-angelo
deleted the

fix/electron-redirect-protocol-from-scheme

branch
June 30, 2026 20:41
@clerk-cookieclerk-cookie
mentioned this pull request
Jun 30, 2026
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@wobsorianowobsorianowobsoriano approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@nicolas-angelo@wobsoriano

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
fix(electron): default allowedRedirectProtocols to the renderer scheme by nicolas-angelo · Pull Request #9043 · clerk/javascript · GitHub
Skip to content
fix(electron): default allowedRedirectProtocols to the renderer scheme - #9043
Merged
nicolas-angelo merged 4 commits into
mainfrom 
fix/electron-redirect-protocol-from-scheme
Jun 30, 2026
Merged
fix(electron): default allowedRedirectProtocols to the renderer scheme#9043
nicolas-angelo merged 4 commits into
mainfrom 
fix/electron-redirect-protocol-from-scheme
Conversation
@nicolas-angelo
@nicolas-angelonicolas-angelo
commented
Jun 30, 2026•

edited by coderabbitai
Bot
Loading

Copy link


Copy Markdown

Contributor
Description
Small DX win: today apps have to manually set allowedRedirectProtocols={['<scheme>:']} on <ClerkProvider> so Clerk's prebuilt-UI cross-links aren't rejected (i.e. the sign-up link on the SignIn component and the sign-in link on the SignUp component).
This PR makes it zero-config by deriving the scheme from the renderer's own origin (window.location.protocol, i.e. the scheme registered via createClerkBridge) and appending it to allowedRedirectProtocols internally by default.
The only exception to this new behavior is honoring explicit values (including []) which will override.
Testing: drop allowedRedirectProtocols from <ClerkProvider> and confirm in-app cross-links (sign-in ↔ sign-up) on auth components work properly.
Note on changeset level: scoped as a patch because the current default (no custom scheme in the allowlist) leaves the SDK's cross-links broken out of the box - so this feels more like a fix.
Checklist
  • pnpm test runs as expected.
  • pnpm build runs as expected.
  •  JSDoc comments have been added for the new behavior.
  •  (If applicable) Documentation has been updated
Type of change
  •  🐛 Bug fix
  •  🌟 New feature
  •  🔨 Breaking change
  •  📖 Refactoring / dependency upgrade / documentation
Summary by CodeRabbit
  • New Features
    • Electron apps now automatically allow the renderer’s own custom protocol for redirect flows when applicable (e.g., clerk:).
    • You can still explicitly control redirect protocols via an allowedRedirectProtocols setting, including setting it to none.
  • Bug Fixes
    • Improved default redirect handling so custom renderer schemes work with no extra configuration.
    • file: renderers remain unchanged (not auto-allowed), and https: defaults are not added automatically.
  • Tests
    • Added coverage for defaulting and override behavior of redirect protocols.
@changeset-bot
changeset-botBot
commented
Jun 30, 2026•

edited

Loading

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: 74d00ce
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 1 package
NameType
@clerk/electronPatch
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@vercel
vercelBot
commented
Jun 30, 2026•

edited

Loading

Copy link


Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.
ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxReadyReadyPreview, CommentJun 30, 2026 8:37pm
swingsetReadyReadyPreview, CommentJun 30, 2026 8:37pm
Request Review
@coderabbitai
coderabbitaiBot
commented
Jun 30, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Review Change Stack
No actionable comments were generated in the recent review. 🎉
ℹ️ Recent review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Repository UI (inherited)
Review profile: CHILL
Plan: Pro Plus
Run ID: b7f9ca99-c862-4c14-a4ce-48f3dc49ebf4
📥 Commits
Reviewing files that changed from the base of the PR and between c5be752 and 74d00ce.
📒 Files selected for processing (1)
  • packages/electron/src/react/__tests__/ClerkProvider.test.tsx
🚧 Files skipped from review as they are similar to previous changes (1)
  • packages/electron/src/react/tests/ClerkProvider.test.tsx
📝 Walkthrough
Walkthrough
ClerkProvider in the Electron package now derives a default allowedRedirectProtocols value from window.location.protocol for custom renderer schemes, forwards it to ReactClerkProvider, and preserves any explicit prop value, including an empty array. Tests and release notes cover the new behavior.
Auto allowedRedirectProtocols for Electron renderer
Layer / File(s)Summary
Helper and provider wiring
packages/electron/src/react/index.tsx		defaultAllowedRedirectProtocols() reads window.location.protocol, returns a single custom scheme when appropriate, and ClerkProvider passes either the explicit prop or the derived default into ReactClerkProvider.
Behavior tests and changeset
packages/electron/src/react/__tests__/ClerkProvider.test.tsx, .changeset/electron-auto-allowed-redirect-protocols.md		Tests cover custom-scheme defaulting, https: and file: omission, and explicit overrides; the changeset documents the renderer protocol behavior.
Estimated code review effort
🎯 2 (Simple) | ⏱️ ~8 minutes
Poem
🐇 Hop, hop, through the redirect gate,
clerk: joins the list at just the right rate.
https and file stay out of the cart,

explicit arrays still play their part.

Tiny hops, tidy paths, a protocol art ✨
🚥 Pre-merge checks | ✅ 4 | ❌ 1
❌ Failed checks (1 warning)
Check nameStatusExplanationResolution
Docstring Coverage⚠️ WarningDocstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title clearly and concisely summarizes the main Electron change: defaulting allowedRedirectProtocols to the renderer scheme.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  •  Create stacked PR
  •  Commit on current branch
Comment @coderabbitai help to get the list of available commands.
@pkg-pr-new
pkg-pr-newBot
commented
Jun 30, 2026•

edited

Loading

Copy link


Copy Markdown

Open in StackBlitz
@clerk/astro
npm i https://pkg.pr.new/@clerk/astro@9043

@clerk/backend
npm i https://pkg.pr.new/@clerk/backend@9043

@clerk/chrome-extension
npm i https://pkg.pr.new/@clerk/chrome-extension@9043

@clerk/clerk-js
npm i https://pkg.pr.new/@clerk/clerk-js@9043

@clerk/electron
npm i https://pkg.pr.new/@clerk/electron@9043

@clerk/electron-passkeys
npm i https://pkg.pr.new/@clerk/electron-passkeys@9043

@clerk/eslint-plugin
npm i https://pkg.pr.new/@clerk/eslint-plugin@9043

@clerk/expo
npm i https://pkg.pr.new/@clerk/expo@9043

@clerk/expo-passkeys
npm i https://pkg.pr.new/@clerk/expo-passkeys@9043

@clerk/express
npm i https://pkg.pr.new/@clerk/express@9043

@clerk/fastify
npm i https://pkg.pr.new/@clerk/fastify@9043

@clerk/hono
npm i https://pkg.pr.new/@clerk/hono@9043

@clerk/localizations
npm i https://pkg.pr.new/@clerk/localizations@9043

@clerk/nextjs
npm i https://pkg.pr.new/@clerk/nextjs@9043

@clerk/nuxt
npm i https://pkg.pr.new/@clerk/nuxt@9043

@clerk/react
npm i https://pkg.pr.new/@clerk/react@9043

@clerk/react-router
npm i https://pkg.pr.new/@clerk/react-router@9043

@clerk/shared
npm i https://pkg.pr.new/@clerk/shared@9043

@clerk/tanstack-react-start
npm i https://pkg.pr.new/@clerk/tanstack-react-start@9043

@clerk/testing
npm i https://pkg.pr.new/@clerk/testing@9043

@clerk/ui
npm i https://pkg.pr.new/@clerk/ui@9043

@clerk/upgrade
npm i https://pkg.pr.new/@clerk/upgrade@9043

@clerk/vue
npm i https://pkg.pr.new/@clerk/vue@9043

commit: 74d00ce
wobsoriano
wobsoriano
approved these changes
Jun 30, 2026
View reviewed changes
@wobsorianowobsoriano
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, thanks!
@nicolas-angelo
nicolas-angelo
merged commit d4bafb4
into
mainJun 30, 2026

51 checks passed

@nicolas-angelo
nicolas-angelo
deleted the

fix/electron-redirect-protocol-from-scheme

branch
June 30, 2026 20:41
@clerk-cookieclerk-cookie
mentioned this pull request
Jun 30, 2026
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@wobsorianowobsorianowobsoriano approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@nicolas-angelo@wobsoriano

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
fix(electron): default allowedRedirectProtocols to the renderer scheme by nicolas-angelo · Pull Request #9043 · clerk/javascript · GitHub
Skip to content
fix(electron): default allowedRedirectProtocols to the renderer scheme - #9043
Merged
nicolas-angelo merged 4 commits into
mainfrom 
fix/electron-redirect-protocol-from-scheme
Jun 30, 2026
Merged
fix(electron): default allowedRedirectProtocols to the renderer scheme#9043
nicolas-angelo merged 4 commits into
mainfrom 
fix/electron-redirect-protocol-from-scheme
Conversation
@nicolas-angelo
@nicolas-angelonicolas-angelo
commented
Jun 30, 2026•

edited by coderabbitai
Bot
Loading

Copy link


Copy Markdown

Contributor
Description
Small DX win: today apps have to manually set allowedRedirectProtocols={['<scheme>:']} on <ClerkProvider> so Clerk's prebuilt-UI cross-links aren't rejected (i.e. the sign-up link on the SignIn component and the sign-in link on the SignUp component).
This PR makes it zero-config by deriving the scheme from the renderer's own origin (window.location.protocol, i.e. the scheme registered via createClerkBridge) and appending it to allowedRedirectProtocols internally by default.
The only exception to this new behavior is honoring explicit values (including []) which will override.
Testing: drop allowedRedirectProtocols from <ClerkProvider> and confirm in-app cross-links (sign-in ↔ sign-up) on auth components work properly.
Note on changeset level: scoped as a patch because the current default (no custom scheme in the allowlist) leaves the SDK's cross-links broken out of the box - so this feels more like a fix.
Checklist
  • pnpm test runs as expected.
  • pnpm build runs as expected.
  •  JSDoc comments have been added for the new behavior.
  •  (If applicable) Documentation has been updated
Type of change
  •  🐛 Bug fix
  •  🌟 New feature
  •  🔨 Breaking change
  •  📖 Refactoring / dependency upgrade / documentation
Summary by CodeRabbit
  • New Features
    • Electron apps now automatically allow the renderer’s own custom protocol for redirect flows when applicable (e.g., clerk:).
    • You can still explicitly control redirect protocols via an allowedRedirectProtocols setting, including setting it to none.
  • Bug Fixes
    • Improved default redirect handling so custom renderer schemes work with no extra configuration.
    • file: renderers remain unchanged (not auto-allowed), and https: defaults are not added automatically.
  • Tests
    • Added coverage for defaulting and override behavior of redirect protocols.
@changeset-bot
changeset-botBot
commented
Jun 30, 2026•

edited

Loading

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: 74d00ce
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 1 package
NameType
@clerk/electronPatch
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@vercel
vercelBot
commented
Jun 30, 2026•

edited

Loading

Copy link


Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.
ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxReadyReadyPreview, CommentJun 30, 2026 8:37pm
swingsetReadyReadyPreview, CommentJun 30, 2026 8:37pm
Request Review
@coderabbitai
coderabbitaiBot
commented
Jun 30, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Review Change Stack
No actionable comments were generated in the recent review. 🎉
ℹ️ Recent review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Repository UI (inherited)
Review profile: CHILL
Plan: Pro Plus
Run ID: b7f9ca99-c862-4c14-a4ce-48f3dc49ebf4
📥 Commits
Reviewing files that changed from the base of the PR and between c5be752 and 74d00ce.
📒 Files selected for processing (1)
  • packages/electron/src/react/__tests__/ClerkProvider.test.tsx
🚧 Files skipped from review as they are similar to previous changes (1)
  • packages/electron/src/react/tests/ClerkProvider.test.tsx
📝 Walkthrough
Walkthrough
ClerkProvider in the Electron package now derives a default allowedRedirectProtocols value from window.location.protocol for custom renderer schemes, forwards it to ReactClerkProvider, and preserves any explicit prop value, including an empty array. Tests and release notes cover the new behavior.
Auto allowedRedirectProtocols for Electron renderer
Layer / File(s)Summary
Helper and provider wiring
packages/electron/src/react/index.tsx		defaultAllowedRedirectProtocols() reads window.location.protocol, returns a single custom scheme when appropriate, and ClerkProvider passes either the explicit prop or the derived default into ReactClerkProvider.
Behavior tests and changeset
packages/electron/src/react/__tests__/ClerkProvider.test.tsx, .changeset/electron-auto-allowed-redirect-protocols.md		Tests cover custom-scheme defaulting, https: and file: omission, and explicit overrides; the changeset documents the renderer protocol behavior.
Estimated code review effort
🎯 2 (Simple) | ⏱️ ~8 minutes
Poem
🐇 Hop, hop, through the redirect gate,
clerk: joins the list at just the right rate.
https and file stay out of the cart,

explicit arrays still play their part.

Tiny hops, tidy paths, a protocol art ✨
🚥 Pre-merge checks | ✅ 4 | ❌ 1
❌ Failed checks (1 warning)
Check nameStatusExplanationResolution
Docstring Coverage⚠️ WarningDocstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title clearly and concisely summarizes the main Electron change: defaulting allowedRedirectProtocols to the renderer scheme.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  •  Create stacked PR
  •  Commit on current branch
Comment @coderabbitai help to get the list of available commands.
@pkg-pr-new
pkg-pr-newBot
commented
Jun 30, 2026•

edited

Loading

Copy link


Copy Markdown

Open in StackBlitz
@clerk/astro
npm i https://pkg.pr.new/@clerk/astro@9043

@clerk/backend
npm i https://pkg.pr.new/@clerk/backend@9043

@clerk/chrome-extension
npm i https://pkg.pr.new/@clerk/chrome-extension@9043

@clerk/clerk-js
npm i https://pkg.pr.new/@clerk/clerk-js@9043

@clerk/electron
npm i https://pkg.pr.new/@clerk/electron@9043

@clerk/electron-passkeys
npm i https://pkg.pr.new/@clerk/electron-passkeys@9043

@clerk/eslint-plugin
npm i https://pkg.pr.new/@clerk/eslint-plugin@9043

@clerk/expo
npm i https://pkg.pr.new/@clerk/expo@9043

@clerk/expo-passkeys
npm i https://pkg.pr.new/@clerk/expo-passkeys@9043

@clerk/express
npm i https://pkg.pr.new/@clerk/express@9043

@clerk/fastify
npm i https://pkg.pr.new/@clerk/fastify@9043

@clerk/hono
npm i https://pkg.pr.new/@clerk/hono@9043

@clerk/localizations
npm i https://pkg.pr.new/@clerk/localizations@9043

@clerk/nextjs
npm i https://pkg.pr.new/@clerk/nextjs@9043

@clerk/nuxt
npm i https://pkg.pr.new/@clerk/nuxt@9043

@clerk/react
npm i https://pkg.pr.new/@clerk/react@9043

@clerk/react-router
npm i https://pkg.pr.new/@clerk/react-router@9043

@clerk/shared
npm i https://pkg.pr.new/@clerk/shared@9043

@clerk/tanstack-react-start
npm i https://pkg.pr.new/@clerk/tanstack-react-start@9043

@clerk/testing
npm i https://pkg.pr.new/@clerk/testing@9043

@clerk/ui
npm i https://pkg.pr.new/@clerk/ui@9043

@clerk/upgrade
npm i https://pkg.pr.new/@clerk/upgrade@9043

@clerk/vue
npm i https://pkg.pr.new/@clerk/vue@9043

commit: 74d00ce
wobsoriano
wobsoriano
approved these changes
Jun 30, 2026
View reviewed changes
@wobsorianowobsoriano
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, thanks!
@nicolas-angelo
nicolas-angelo
merged commit d4bafb4
into
mainJun 30, 2026

51 checks passed

@nicolas-angelo
nicolas-angelo
deleted the

fix/electron-redirect-protocol-from-scheme

branch
June 30, 2026 20:41
@clerk-cookieclerk-cookie
mentioned this pull request
Jun 30, 2026
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@wobsorianowobsorianowobsoriano approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@nicolas-angelo@wobsoriano

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Universal Dark Mode - works on any site
(function() {
var enabled = true;
function applyDarkMode() {
if (!enabled) return;
// Create style element if it doesn't exist
var style = document.getElementById('universal-dark-mode-style');
if (!style) {
style = document.createElement('style');
style.id = 'universal-dark-mode-style';
document.head.appendChild(style);
}
// Dark mode CSS - inverts colors but preserves images/video
style.textContent = '
/* Invert everything except media */
html {
filter: invert(1) hue-rotate(180deg) !important;
background: #1a1a2e !important;
}
/* Restore images, videos, iframes, canvas */
img, video, iframe, canvas, svg, picture, [style*="background-image"] {
filter: invert(1) hue-rotate(180deg) !important;
}
/* Preserve specific elements that should not be inverted */
.no-dark-mode, .no-dark-mode *,
[data-theme="light"], [data-theme="light"],
.ace_editor, .ace_editor *,
.CodeMirror, .CodeMirror *,
.monaco-editor, .monaco-editor *,
.markdown-body pre, .markdown-body pre *,
.highlight, .highlight *,
pre code, pre code * {
filter: none !important;
}
/* Fix common UI elements */
.modal, .popup, .dropdown-menu, .tooltip, .popover {
filter: invert(1) hue-rotate(180deg) !important;
background: #2d2d44 !important;
border-color: #444 !important;
}
/* Scrollbars */
::-webkit-scrollbar { background: #1a1a2e !important; }
::-webkit-scrollbar-thumb { background: #444 !important; }
::-webkit-scrollbar-thumb:hover { background: #555 !important; }
/* Selection */
::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
';
}
function removeDarkMode() {
var style = document.getElementById('universal-dark-mode-style');
if (style) style.remove();
}
// Toggle with Alt+Shift+D
document.addEventListener('keydown', function(e) {
if (e.altKey && e.shiftKey && e.key === 'D') {
e.preventDefault();
enabled = !enabled;
if (enabled) {
applyDarkMode();
console.log('[Universal Dark Mode] Enabled');
} else {
removeDarkMode();
console.log('[Universal Dark Mode] Disabled');
}
}
});
// Apply on load
applyDarkMode();
// Re-apply on dynamic content
var observer = new MutationObserver(function(mutations) {
if (enabled && !document.getElementById('universal-dark-mode-style')) {
applyDarkMode();
}
});
observer.observe(document.head, { childList: true });
console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');
})();
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();
fix(electron): default allowedRedirectProtocols to the renderer scheme by nicolas-angelo · Pull Request #9043 · clerk/javascript · GitHub
Skip to content
fix(electron): default allowedRedirectProtocols to the renderer scheme - #9043
Merged
nicolas-angelo merged 4 commits into
mainfrom 
fix/electron-redirect-protocol-from-scheme
Jun 30, 2026
Merged
fix(electron): default allowedRedirectProtocols to the renderer scheme#9043
nicolas-angelo merged 4 commits into
mainfrom 
fix/electron-redirect-protocol-from-scheme
Conversation
@nicolas-angelo
@nicolas-angelonicolas-angelo
commented
Jun 30, 2026•

edited by coderabbitai
Bot
Loading

Copy link


Copy Markdown

Contributor
Description
Small DX win: today apps have to manually set allowedRedirectProtocols={['<scheme>:']} on <ClerkProvider> so Clerk's prebuilt-UI cross-links aren't rejected (i.e. the sign-up link on the SignIn component and the sign-in link on the SignUp component).
This PR makes it zero-config by deriving the scheme from the renderer's own origin (window.location.protocol, i.e. the scheme registered via createClerkBridge) and appending it to allowedRedirectProtocols internally by default.
The only exception to this new behavior is honoring explicit values (including []) which will override.
Testing: drop allowedRedirectProtocols from <ClerkProvider> and confirm in-app cross-links (sign-in ↔ sign-up) on auth components work properly.
Note on changeset level: scoped as a patch because the current default (no custom scheme in the allowlist) leaves the SDK's cross-links broken out of the box - so this feels more like a fix.
Checklist
  • pnpm test runs as expected.
  • pnpm build runs as expected.
  •  JSDoc comments have been added for the new behavior.
  •  (If applicable) Documentation has been updated
Type of change
  •  🐛 Bug fix
  •  🌟 New feature
  •  🔨 Breaking change
  •  📖 Refactoring / dependency upgrade / documentation
Summary by CodeRabbit
  • New Features
    • Electron apps now automatically allow the renderer’s own custom protocol for redirect flows when applicable (e.g., clerk:).
    • You can still explicitly control redirect protocols via an allowedRedirectProtocols setting, including setting it to none.
  • Bug Fixes
    • Improved default redirect handling so custom renderer schemes work with no extra configuration.
    • file: renderers remain unchanged (not auto-allowed), and https: defaults are not added automatically.
  • Tests
    • Added coverage for defaulting and override behavior of redirect protocols.
@changeset-bot
changeset-botBot
commented
Jun 30, 2026•

edited

Loading

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: 74d00ce
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 1 package
NameType
@clerk/electronPatch
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@vercel
vercelBot
commented
Jun 30, 2026•

edited

Loading

Copy link


Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.
ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxReadyReadyPreview, CommentJun 30, 2026 8:37pm
swingsetReadyReadyPreview, CommentJun 30, 2026 8:37pm
Request Review
@coderabbitai
coderabbitaiBot
commented
Jun 30, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Review Change Stack
No actionable comments were generated in the recent review. 🎉
ℹ️ Recent review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Repository UI (inherited)
Review profile: CHILL
Plan: Pro Plus
Run ID: b7f9ca99-c862-4c14-a4ce-48f3dc49ebf4
📥 Commits
Reviewing files that changed from the base of the PR and between c5be752 and 74d00ce.
📒 Files selected for processing (1)
  • packages/electron/src/react/__tests__/ClerkProvider.test.tsx
🚧 Files skipped from review as they are similar to previous changes (1)
  • packages/electron/src/react/tests/ClerkProvider.test.tsx
📝 Walkthrough
Walkthrough
ClerkProvider in the Electron package now derives a default allowedRedirectProtocols value from window.location.protocol for custom renderer schemes, forwards it to ReactClerkProvider, and preserves any explicit prop value, including an empty array. Tests and release notes cover the new behavior.
Auto allowedRedirectProtocols for Electron renderer
Layer / File(s)Summary
Helper and provider wiring
packages/electron/src/react/index.tsx		defaultAllowedRedirectProtocols() reads window.location.protocol, returns a single custom scheme when appropriate, and ClerkProvider passes either the explicit prop or the derived default into ReactClerkProvider.
Behavior tests and changeset
packages/electron/src/react/__tests__/ClerkProvider.test.tsx, .changeset/electron-auto-allowed-redirect-protocols.md		Tests cover custom-scheme defaulting, https: and file: omission, and explicit overrides; the changeset documents the renderer protocol behavior.
Estimated code review effort
🎯 2 (Simple) | ⏱️ ~8 minutes
Poem
🐇 Hop, hop, through the redirect gate,
clerk: joins the list at just the right rate.
https and file stay out of the cart,

explicit arrays still play their part.

Tiny hops, tidy paths, a protocol art ✨
🚥 Pre-merge checks | ✅ 4 | ❌ 1
❌ Failed checks (1 warning)
Check nameStatusExplanationResolution
Docstring Coverage⚠️ WarningDocstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title clearly and concisely summarizes the main Electron change: defaulting allowedRedirectProtocols to the renderer scheme.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  •  Create stacked PR
  •  Commit on current branch
Comment @coderabbitai help to get the list of available commands.
@pkg-pr-new
pkg-pr-newBot
commented
Jun 30, 2026•

edited

Loading

Copy link


Copy Markdown

Open in StackBlitz
@clerk/astro
npm i https://pkg.pr.new/@clerk/astro@9043

@clerk/backend
npm i https://pkg.pr.new/@clerk/backend@9043

@clerk/chrome-extension
npm i https://pkg.pr.new/@clerk/chrome-extension@9043

@clerk/clerk-js
npm i https://pkg.pr.new/@clerk/clerk-js@9043

@clerk/electron
npm i https://pkg.pr.new/@clerk/electron@9043

@clerk/electron-passkeys
npm i https://pkg.pr.new/@clerk/electron-passkeys@9043

@clerk/eslint-plugin
npm i https://pkg.pr.new/@clerk/eslint-plugin@9043

@clerk/expo
npm i https://pkg.pr.new/@clerk/expo@9043

@clerk/expo-passkeys
npm i https://pkg.pr.new/@clerk/expo-passkeys@9043

@clerk/express
npm i https://pkg.pr.new/@clerk/express@9043

@clerk/fastify
npm i https://pkg.pr.new/@clerk/fastify@9043

@clerk/hono
npm i https://pkg.pr.new/@clerk/hono@9043

@clerk/localizations
npm i https://pkg.pr.new/@clerk/localizations@9043

@clerk/nextjs
npm i https://pkg.pr.new/@clerk/nextjs@9043

@clerk/nuxt
npm i https://pkg.pr.new/@clerk/nuxt@9043

@clerk/react
npm i https://pkg.pr.new/@clerk/react@9043

@clerk/react-router
npm i https://pkg.pr.new/@clerk/react-router@9043

@clerk/shared
npm i https://pkg.pr.new/@clerk/shared@9043

@clerk/tanstack-react-start
npm i https://pkg.pr.new/@clerk/tanstack-react-start@9043

@clerk/testing
npm i https://pkg.pr.new/@clerk/testing@9043

@clerk/ui
npm i https://pkg.pr.new/@clerk/ui@9043

@clerk/upgrade
npm i https://pkg.pr.new/@clerk/upgrade@9043

@clerk/vue
npm i https://pkg.pr.new/@clerk/vue@9043

commit: 74d00ce
wobsoriano
wobsoriano
approved these changes
Jun 30, 2026
View reviewed changes
@wobsorianowobsoriano
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, thanks!
@nicolas-angelo
nicolas-angelo
merged commit d4bafb4
into
mainJun 30, 2026

51 checks passed

@nicolas-angelo
nicolas-angelo
deleted the

fix/electron-redirect-protocol-from-scheme

branch
June 30, 2026 20:41
@clerk-cookieclerk-cookie
mentioned this pull request
Jun 30, 2026
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@wobsorianowobsorianowobsoriano approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@nicolas-angelo@wobsoriano