fix(ui): keep truncateWithEndVisible code-point-safe in short-width fallback - #9047

Merged
wobsoriano merged 1 commit into
mainfrom
create-pr-surrogate-truncate
Jul 1, 2026
Merged

fix(ui): keep truncateWithEndVisible code-point-safe in short-width fallback#9047
wobsoriano merged 1 commit into
mainfrom
create-pr-surrogate-truncate

Conversation

@alexcarpenter

@alexcarpenteralexcarpenter commented Jun 30, 2026•
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Member

truncateWithEndVisible keeps the start and end of a string and puts an ellipsis in the middle. The main path builds the result from Array.from(str), so it slices on code points and never breaks a character. The short-width fallback (taken when maxLength <= endChars + 3) instead returned ELLIPSIS + str.slice(-endChars), which slices on UTF-16 code units.

For characters outside the BMP (CJK Extension B kanji, emoji) each character is a surrogate pair of two code units, so str.slice(-endChars) can cut one in half and leave a lone surrogate:

truncateWithEndVisible('𠮷𠮷𠮷𠮷𠮷',8,5)// before: '...\uDFB7𠮷𠮷' (broken leading character)// after: '...𠮷𠮷𠮷𠮷𠮷'

The fallback now slices by code point, the same way the main path already does. ASCII inputs are unaffected and the existing tests still pass. Added a test covering the fallback with astral characters.

Re-creates #9029 from a branch in this repo so CI runs with the necessary secrets. Authored by @greymoth-jp; original commit authorship is preserved in git history.

Summary by CodeRabbit

  • Bug Fixes
    • Improved text truncation so very short widths no longer split emoji or other non-BMP characters into broken symbols.
    • Made character counting and fallback truncation behave consistently with Unicode code points, preserving readable output.
    • Added coverage for Unicode edge cases to prevent regressions.

@changeset-bot

changeset-botBot commented Jun 30, 2026•
edited
Loading

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 931e3cf

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
NameType
@clerk/uiPatch
@clerk/chrome-extensionPatch
@clerk/swingsetPatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel

vercelBot commented Jun 30, 2026•
edited
Loading

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxReadyReadyPreview, CommentJun 30, 2026 5:52pm
swingsetReadyReadyPreview, CommentJun 30, 2026 5:52pm

Request Review

@alexcarpenter
alexcarpenterforce-pushed the create-pr-surrogate-truncate branch from effb3f1 to 931e3cfCompareJune 30, 2026 17:50
@alexcarpenteralexcarpenter mentioned this pull request Jun 30, 2026
Closed
@pkg-pr-new

pkg-pr-newBot commented Jun 30, 2026

Copy link
Copy Markdown

Open in StackBlitz

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@9047

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@9047

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@9047

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@9047

@clerk/electron

npm i https://pkg.pr.new/@clerk/electron@9047

@clerk/electron-passkeys

npm i https://pkg.pr.new/@clerk/electron-passkeys@9047

@clerk/eslint-plugin

npm i https://pkg.pr.new/@clerk/eslint-plugin@9047

@clerk/expo

npm i https://pkg.pr.new/@clerk/expo@9047

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@9047

@clerk/express

npm i https://pkg.pr.new/@clerk/express@9047

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@9047

@clerk/hono

npm i https://pkg.pr.new/@clerk/hono@9047

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@9047

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@9047

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@9047

@clerk/react

npm i https://pkg.pr.new/@clerk/react@9047

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@9047

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@9047

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@9047

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@9047

@clerk/ui

npm i https://pkg.pr.new/@clerk/ui@9047

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@9047

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@9047

commit: 931e3cf

@github-actions

github-actionsBot commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

API Changes Report

Generated by Break Check on 2026-06-30T17:54:25.979Z

Summary

MetricCount
Packages analyzed19
Packages with changes0
🔴 Breaking changes0
🟡 Non-breaking changes0
🟢 Additions0

No API Changes Detected

All packages have stable APIs with no detected changes.

Report generated by Break Check

Last ran on 931e3cf.

@coderabbitai

coderabbitaiBot commented Jun 30, 2026•
edited
Loading

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Repository UI (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: f1944d7e-e579-4eff-a3c5-86fe95ea5b82

📥 Commits

Reviewing files that changed from the base of the PR and between 4306146 and 931e3cf.

📒 Files selected for processing (3)
  • .changeset/truncate-surrogate-safe.md
  • packages/ui/src/utils/__tests__/truncateTextWithEndVisible.test.ts
  • packages/ui/src/utils/truncateTextWithEndVisible.ts
📝 Walkthrough

Walkthrough

truncateWithEndVisible is updated to use Array.from(str) for code-point-aware length checks and slicing, fixing broken surrogate pairs when truncating strings containing out-of-BMP characters. Two new test cases and a patch changeset entry are added.

Changes

Surrogate-safe truncation fix

Layer / File(s)Summary
Fix and test for surrogate-safe fallback
packages/ui/src/utils/truncateTextWithEndVisible.ts, packages/ui/src/utils/__tests__/truncateTextWithEndVisible.test.ts, .changeset/truncate-surrogate-safe.md		Splits the falsy-string guard from the length check, converts the string to a chars array via Array.from, uses that array for both the "no truncation needed" check and the short-maxLength branch. Adds tests for CJK Extension B and emoji inputs, and a patch changeset entry.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

Poem

🐇 A rabbit once sliced through a CJK glyph,
And broke it in two — quite a Unicode cliff!
Now Array.from guards every code point,
No surrogate halves left out of joint.
Hop hop, the fix lands without a mishap! ✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title clearly summarizes the main fix: making the short-width fallback of truncateWithEndVisible code-point-safe.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch

Comment @coderabbitai help to get the list of available commands.

wobsoriano
wobsoriano approved these changes Jul 1, 2026
View reviewed changes

@wobsorianowobsoriano left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼

@wobsoriano
wobsoriano merged commit 5a51943 into mainJul 1, 2026
53 checks passed
@wobsoriano
wobsoriano deleted the create-pr-surrogate-truncate branch July 1, 2026 17:07
@clerk-cookieclerk-cookie mentioned this pull request Jul 1, 2026
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wobsorianowobsorianowobsoriano approved these changes

Assignees

No one assigned

Labels

ui

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@alexcarpenter@wobsoriano@mahirhir
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
fix(ui): keep truncateWithEndVisible code-point-safe in short-width fallback - #9047
Merged
wobsoriano merged 1 commit into
mainfrom 
create-pr-surrogate-truncate
Jul 1, 2026
Merged
fix(ui): keep truncateWithEndVisible code-point-safe in short-width fallback#9047
wobsoriano merged 1 commit into
mainfrom 
create-pr-surrogate-truncate
Conversation
@alexcarpenter
@alexcarpenteralexcarpenter
commented
Jun 30, 2026•

edited by coderabbitai
Bot
Loading

Copy link


Copy Markdown

Member
truncateWithEndVisible keeps the start and end of a string and puts an ellipsis in the middle. The main path builds the result from Array.from(str), so it slices on code points and never breaks a character. The short-width fallback (taken when maxLength <= endChars + 3) instead returned ELLIPSIS + str.slice(-endChars), which slices on UTF-16 code units.
For characters outside the BMP (CJK Extension B kanji, emoji) each character is a surrogate pair of two code units, so str.slice(-endChars) can cut one in half and leave a lone surrogate:
truncateWithEndVisible('𠮷𠮷𠮷𠮷𠮷',8,5)// before: '...\uDFB7𠮷𠮷' (broken leading character)// after: '...𠮷𠮷𠮷𠮷𠮷'
The fallback now slices by code point, the same way the main path already does. ASCII inputs are unaffected and the existing tests still pass. Added a test covering the fallback with astral characters.
Re-creates #9029 from a branch in this repo so CI runs with the necessary secrets. Authored by @greymoth-jp; original commit authorship is preserved in git history.
Summary by CodeRabbit
  • Bug Fixes
    • Improved text truncation so very short widths no longer split emoji or other non-BMP characters into broken symbols.
    • Made character counting and fallback truncation behave consistently with Unicode code points, preserving readable output.
    • Added coverage for Unicode edge cases to prevent regressions.
@changeset-bot
changeset-botBot
commented
Jun 30, 2026•

edited

Loading

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: 931e3cf
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 3 packages
NameType
@clerk/uiPatch
@clerk/chrome-extensionPatch
@clerk/swingsetPatch
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@vercel
vercelBot
commented
Jun 30, 2026•

edited

Loading

Copy link


Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.
ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxReadyReadyPreview, CommentJun 30, 2026 5:52pm
swingsetReadyReadyPreview, CommentJun 30, 2026 5:52pm
Request Review
@alexcarpenter
alexcarpenterforce-pushed
the
create-pr-surrogate-truncate
branch
from
effb3f1 to
931e3cfCompareJune 30, 2026 17:50
@alexcarpenteralexcarpenter
mentioned this pull request
Jun 30, 2026
 Closed

@pkg-pr-new
pkg-pr-newBot
commented
Jun 30, 2026

Copy link


Copy Markdown

Open in StackBlitz
@clerk/astro
npm i https://pkg.pr.new/@clerk/astro@9047

@clerk/backend
npm i https://pkg.pr.new/@clerk/backend@9047

@clerk/chrome-extension
npm i https://pkg.pr.new/@clerk/chrome-extension@9047

@clerk/clerk-js
npm i https://pkg.pr.new/@clerk/clerk-js@9047

@clerk/electron
npm i https://pkg.pr.new/@clerk/electron@9047

@clerk/electron-passkeys
npm i https://pkg.pr.new/@clerk/electron-passkeys@9047

@clerk/eslint-plugin
npm i https://pkg.pr.new/@clerk/eslint-plugin@9047

@clerk/expo
npm i https://pkg.pr.new/@clerk/expo@9047

@clerk/expo-passkeys
npm i https://pkg.pr.new/@clerk/expo-passkeys@9047

@clerk/express
npm i https://pkg.pr.new/@clerk/express@9047

@clerk/fastify
npm i https://pkg.pr.new/@clerk/fastify@9047

@clerk/hono
npm i https://pkg.pr.new/@clerk/hono@9047

@clerk/localizations
npm i https://pkg.pr.new/@clerk/localizations@9047

@clerk/nextjs
npm i https://pkg.pr.new/@clerk/nextjs@9047

@clerk/nuxt
npm i https://pkg.pr.new/@clerk/nuxt@9047

@clerk/react
npm i https://pkg.pr.new/@clerk/react@9047

@clerk/react-router
npm i https://pkg.pr.new/@clerk/react-router@9047

@clerk/shared
npm i https://pkg.pr.new/@clerk/shared@9047

@clerk/tanstack-react-start
npm i https://pkg.pr.new/@clerk/tanstack-react-start@9047

@clerk/testing
npm i https://pkg.pr.new/@clerk/testing@9047

@clerk/ui
npm i https://pkg.pr.new/@clerk/ui@9047

@clerk/upgrade
npm i https://pkg.pr.new/@clerk/upgrade@9047

@clerk/vue
npm i https://pkg.pr.new/@clerk/vue@9047

commit: 931e3cf
@github-actions
github-actionsBot
commented
Jun 30, 2026

Copy link


Copy Markdown

Contributor
API Changes Report
Generated by Break Check on 2026-06-30T17:54:25.979Z
Summary
MetricCount
Packages analyzed19
Packages with changes0
🔴 Breaking changes0
🟡 Non-breaking changes0
🟢 Additions0
No API Changes Detected
All packages have stable APIs with no detected changes.
Report generated by Break Check
Last ran on 931e3cf.
@coderabbitai
coderabbitaiBot
commented
Jun 30, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Review Change Stack
No actionable comments were generated in the recent review. 🎉
ℹ️ Recent review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Repository UI (inherited)
Review profile: CHILL
Plan: Pro Plus
Run ID: f1944d7e-e579-4eff-a3c5-86fe95ea5b82
📥 Commits
Reviewing files that changed from the base of the PR and between 4306146 and 931e3cf.
📒 Files selected for processing (3)
  • .changeset/truncate-surrogate-safe.md
  • packages/ui/src/utils/__tests__/truncateTextWithEndVisible.test.ts
  • packages/ui/src/utils/truncateTextWithEndVisible.ts
📝 Walkthrough
Walkthrough
truncateWithEndVisible is updated to use Array.from(str) for code-point-aware length checks and slicing, fixing broken surrogate pairs when truncating strings containing out-of-BMP characters. Two new test cases and a patch changeset entry are added.
Changes
Surrogate-safe truncation fix
Layer / File(s)Summary
Fix and test for surrogate-safe fallback
packages/ui/src/utils/truncateTextWithEndVisible.ts, packages/ui/src/utils/__tests__/truncateTextWithEndVisible.test.ts, .changeset/truncate-surrogate-safe.md		Splits the falsy-string guard from the length check, converts the string to a chars array via Array.from, uses that array for both the "no truncation needed" check and the short-maxLength branch. Adds tests for CJK Extension B and emoji inputs, and a patch changeset entry.
Estimated code review effort
🎯 1 (Trivial) | ⏱️ ~5 minutes
Poem
🐇 A rabbit once sliced through a CJK glyph,

And broke it in two — quite a Unicode cliff!

Now Array.from guards every code point,

No surrogate halves left out of joint.

Hop hop, the fix lands without a mishap! ✨
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title clearly summarizes the main fix: making the short-width fallback of truncateWithEndVisible code-point-safe.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  •  Create stacked PR
  •  Commit on current branch
Comment @coderabbitai help to get the list of available commands.
wobsoriano
wobsoriano
approved these changes
Jul 1, 2026
View reviewed changes
@wobsorianowobsoriano
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼
@wobsoriano
wobsoriano
merged commit 5a51943
into
mainJul 1, 2026

53 checks passed

@wobsoriano
wobsoriano
deleted the

create-pr-surrogate-truncate

branch
July 1, 2026 17:07
@clerk-cookieclerk-cookie
mentioned this pull request
Jul 1, 2026
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@wobsorianowobsorianowobsoriano approved these changes

Assignees


No one assigned


Labels

ui

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@alexcarpenter@wobsoriano@mahirhir

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
fix(ui): keep truncateWithEndVisible code-point-safe in short-width fallback - #9047
Merged
wobsoriano merged 1 commit into
mainfrom 
create-pr-surrogate-truncate
Jul 1, 2026
Merged
fix(ui): keep truncateWithEndVisible code-point-safe in short-width fallback#9047
wobsoriano merged 1 commit into
mainfrom 
create-pr-surrogate-truncate
Conversation
@alexcarpenter
@alexcarpenteralexcarpenter
commented
Jun 30, 2026•

edited by coderabbitai
Bot
Loading

Copy link


Copy Markdown

Member
truncateWithEndVisible keeps the start and end of a string and puts an ellipsis in the middle. The main path builds the result from Array.from(str), so it slices on code points and never breaks a character. The short-width fallback (taken when maxLength <= endChars + 3) instead returned ELLIPSIS + str.slice(-endChars), which slices on UTF-16 code units.
For characters outside the BMP (CJK Extension B kanji, emoji) each character is a surrogate pair of two code units, so str.slice(-endChars) can cut one in half and leave a lone surrogate:
truncateWithEndVisible('𠮷𠮷𠮷𠮷𠮷',8,5)// before: '...\uDFB7𠮷𠮷' (broken leading character)// after: '...𠮷𠮷𠮷𠮷𠮷'
The fallback now slices by code point, the same way the main path already does. ASCII inputs are unaffected and the existing tests still pass. Added a test covering the fallback with astral characters.
Re-creates #9029 from a branch in this repo so CI runs with the necessary secrets. Authored by @greymoth-jp; original commit authorship is preserved in git history.
Summary by CodeRabbit
  • Bug Fixes
    • Improved text truncation so very short widths no longer split emoji or other non-BMP characters into broken symbols.
    • Made character counting and fallback truncation behave consistently with Unicode code points, preserving readable output.
    • Added coverage for Unicode edge cases to prevent regressions.
@changeset-bot
changeset-botBot
commented
Jun 30, 2026•

edited

Loading

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: 931e3cf
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 3 packages
NameType
@clerk/uiPatch
@clerk/chrome-extensionPatch
@clerk/swingsetPatch
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@vercel
vercelBot
commented
Jun 30, 2026•

edited

Loading

Copy link


Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.
ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxReadyReadyPreview, CommentJun 30, 2026 5:52pm
swingsetReadyReadyPreview, CommentJun 30, 2026 5:52pm
Request Review
@alexcarpenter
alexcarpenterforce-pushed
the
create-pr-surrogate-truncate
branch
from
effb3f1 to
931e3cfCompareJune 30, 2026 17:50
@alexcarpenteralexcarpenter
mentioned this pull request
Jun 30, 2026
 Closed

@pkg-pr-new
pkg-pr-newBot
commented
Jun 30, 2026

Copy link


Copy Markdown

Open in StackBlitz
@clerk/astro
npm i https://pkg.pr.new/@clerk/astro@9047

@clerk/backend
npm i https://pkg.pr.new/@clerk/backend@9047

@clerk/chrome-extension
npm i https://pkg.pr.new/@clerk/chrome-extension@9047

@clerk/clerk-js
npm i https://pkg.pr.new/@clerk/clerk-js@9047

@clerk/electron
npm i https://pkg.pr.new/@clerk/electron@9047

@clerk/electron-passkeys
npm i https://pkg.pr.new/@clerk/electron-passkeys@9047

@clerk/eslint-plugin
npm i https://pkg.pr.new/@clerk/eslint-plugin@9047

@clerk/expo
npm i https://pkg.pr.new/@clerk/expo@9047

@clerk/expo-passkeys
npm i https://pkg.pr.new/@clerk/expo-passkeys@9047

@clerk/express
npm i https://pkg.pr.new/@clerk/express@9047

@clerk/fastify
npm i https://pkg.pr.new/@clerk/fastify@9047

@clerk/hono
npm i https://pkg.pr.new/@clerk/hono@9047

@clerk/localizations
npm i https://pkg.pr.new/@clerk/localizations@9047

@clerk/nextjs
npm i https://pkg.pr.new/@clerk/nextjs@9047

@clerk/nuxt
npm i https://pkg.pr.new/@clerk/nuxt@9047

@clerk/react
npm i https://pkg.pr.new/@clerk/react@9047

@clerk/react-router
npm i https://pkg.pr.new/@clerk/react-router@9047

@clerk/shared
npm i https://pkg.pr.new/@clerk/shared@9047

@clerk/tanstack-react-start
npm i https://pkg.pr.new/@clerk/tanstack-react-start@9047

@clerk/testing
npm i https://pkg.pr.new/@clerk/testing@9047

@clerk/ui
npm i https://pkg.pr.new/@clerk/ui@9047

@clerk/upgrade
npm i https://pkg.pr.new/@clerk/upgrade@9047

@clerk/vue
npm i https://pkg.pr.new/@clerk/vue@9047

commit: 931e3cf
@github-actions
github-actionsBot
commented
Jun 30, 2026

Copy link


Copy Markdown

Contributor
API Changes Report
Generated by Break Check on 2026-06-30T17:54:25.979Z
Summary
MetricCount
Packages analyzed19
Packages with changes0
🔴 Breaking changes0
🟡 Non-breaking changes0
🟢 Additions0
No API Changes Detected
All packages have stable APIs with no detected changes.
Report generated by Break Check
Last ran on 931e3cf.
@coderabbitai
coderabbitaiBot
commented
Jun 30, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Review Change Stack
No actionable comments were generated in the recent review. 🎉
ℹ️ Recent review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Repository UI (inherited)
Review profile: CHILL
Plan: Pro Plus
Run ID: f1944d7e-e579-4eff-a3c5-86fe95ea5b82
📥 Commits
Reviewing files that changed from the base of the PR and between 4306146 and 931e3cf.
📒 Files selected for processing (3)
  • .changeset/truncate-surrogate-safe.md
  • packages/ui/src/utils/__tests__/truncateTextWithEndVisible.test.ts
  • packages/ui/src/utils/truncateTextWithEndVisible.ts
📝 Walkthrough
Walkthrough
truncateWithEndVisible is updated to use Array.from(str) for code-point-aware length checks and slicing, fixing broken surrogate pairs when truncating strings containing out-of-BMP characters. Two new test cases and a patch changeset entry are added.
Changes
Surrogate-safe truncation fix
Layer / File(s)Summary
Fix and test for surrogate-safe fallback
packages/ui/src/utils/truncateTextWithEndVisible.ts, packages/ui/src/utils/__tests__/truncateTextWithEndVisible.test.ts, .changeset/truncate-surrogate-safe.md		Splits the falsy-string guard from the length check, converts the string to a chars array via Array.from, uses that array for both the "no truncation needed" check and the short-maxLength branch. Adds tests for CJK Extension B and emoji inputs, and a patch changeset entry.
Estimated code review effort
🎯 1 (Trivial) | ⏱️ ~5 minutes
Poem
🐇 A rabbit once sliced through a CJK glyph,

And broke it in two — quite a Unicode cliff!

Now Array.from guards every code point,

No surrogate halves left out of joint.

Hop hop, the fix lands without a mishap! ✨
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title clearly summarizes the main fix: making the short-width fallback of truncateWithEndVisible code-point-safe.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  •  Create stacked PR
  •  Commit on current branch
Comment @coderabbitai help to get the list of available commands.
wobsoriano
wobsoriano
approved these changes
Jul 1, 2026
View reviewed changes
@wobsorianowobsoriano
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼
@wobsoriano
wobsoriano
merged commit 5a51943
into
mainJul 1, 2026

53 checks passed

@wobsoriano
wobsoriano
deleted the

create-pr-surrogate-truncate

branch
July 1, 2026 17:07
@clerk-cookieclerk-cookie
mentioned this pull request
Jul 1, 2026
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@wobsorianowobsorianowobsoriano approved these changes

Assignees


No one assigned


Labels

ui

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@alexcarpenter@wobsoriano@mahirhir

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
fix(ui): keep truncateWithEndVisible code-point-safe in short-width fallback - #9047
Merged
wobsoriano merged 1 commit into
mainfrom 
create-pr-surrogate-truncate
Jul 1, 2026
Merged
fix(ui): keep truncateWithEndVisible code-point-safe in short-width fallback#9047
wobsoriano merged 1 commit into
mainfrom 
create-pr-surrogate-truncate
Conversation
@alexcarpenter
@alexcarpenteralexcarpenter
commented
Jun 30, 2026•

edited by coderabbitai
Bot
Loading

Copy link


Copy Markdown

Member
truncateWithEndVisible keeps the start and end of a string and puts an ellipsis in the middle. The main path builds the result from Array.from(str), so it slices on code points and never breaks a character. The short-width fallback (taken when maxLength <= endChars + 3) instead returned ELLIPSIS + str.slice(-endChars), which slices on UTF-16 code units.
For characters outside the BMP (CJK Extension B kanji, emoji) each character is a surrogate pair of two code units, so str.slice(-endChars) can cut one in half and leave a lone surrogate:
truncateWithEndVisible('𠮷𠮷𠮷𠮷𠮷',8,5)// before: '...\uDFB7𠮷𠮷' (broken leading character)// after: '...𠮷𠮷𠮷𠮷𠮷'
The fallback now slices by code point, the same way the main path already does. ASCII inputs are unaffected and the existing tests still pass. Added a test covering the fallback with astral characters.
Re-creates #9029 from a branch in this repo so CI runs with the necessary secrets. Authored by @greymoth-jp; original commit authorship is preserved in git history.
Summary by CodeRabbit
  • Bug Fixes
    • Improved text truncation so very short widths no longer split emoji or other non-BMP characters into broken symbols.
    • Made character counting and fallback truncation behave consistently with Unicode code points, preserving readable output.
    • Added coverage for Unicode edge cases to prevent regressions.
@changeset-bot
changeset-botBot
commented
Jun 30, 2026•

edited

Loading

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: 931e3cf
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 3 packages
NameType
@clerk/uiPatch
@clerk/chrome-extensionPatch
@clerk/swingsetPatch
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@vercel
vercelBot
commented
Jun 30, 2026•

edited

Loading

Copy link


Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.
ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxReadyReadyPreview, CommentJun 30, 2026 5:52pm
swingsetReadyReadyPreview, CommentJun 30, 2026 5:52pm
Request Review
@alexcarpenter
alexcarpenterforce-pushed
the
create-pr-surrogate-truncate
branch
from
effb3f1 to
931e3cfCompareJune 30, 2026 17:50
@alexcarpenteralexcarpenter
mentioned this pull request
Jun 30, 2026
 Closed

@pkg-pr-new
pkg-pr-newBot
commented
Jun 30, 2026

Copy link


Copy Markdown

Open in StackBlitz
@clerk/astro
npm i https://pkg.pr.new/@clerk/astro@9047

@clerk/backend
npm i https://pkg.pr.new/@clerk/backend@9047

@clerk/chrome-extension
npm i https://pkg.pr.new/@clerk/chrome-extension@9047

@clerk/clerk-js
npm i https://pkg.pr.new/@clerk/clerk-js@9047

@clerk/electron
npm i https://pkg.pr.new/@clerk/electron@9047

@clerk/electron-passkeys
npm i https://pkg.pr.new/@clerk/electron-passkeys@9047

@clerk/eslint-plugin
npm i https://pkg.pr.new/@clerk/eslint-plugin@9047

@clerk/expo
npm i https://pkg.pr.new/@clerk/expo@9047

@clerk/expo-passkeys
npm i https://pkg.pr.new/@clerk/expo-passkeys@9047

@clerk/express
npm i https://pkg.pr.new/@clerk/express@9047

@clerk/fastify
npm i https://pkg.pr.new/@clerk/fastify@9047

@clerk/hono
npm i https://pkg.pr.new/@clerk/hono@9047

@clerk/localizations
npm i https://pkg.pr.new/@clerk/localizations@9047

@clerk/nextjs
npm i https://pkg.pr.new/@clerk/nextjs@9047

@clerk/nuxt
npm i https://pkg.pr.new/@clerk/nuxt@9047

@clerk/react
npm i https://pkg.pr.new/@clerk/react@9047

@clerk/react-router
npm i https://pkg.pr.new/@clerk/react-router@9047

@clerk/shared
npm i https://pkg.pr.new/@clerk/shared@9047

@clerk/tanstack-react-start
npm i https://pkg.pr.new/@clerk/tanstack-react-start@9047

@clerk/testing
npm i https://pkg.pr.new/@clerk/testing@9047

@clerk/ui
npm i https://pkg.pr.new/@clerk/ui@9047

@clerk/upgrade
npm i https://pkg.pr.new/@clerk/upgrade@9047

@clerk/vue
npm i https://pkg.pr.new/@clerk/vue@9047

commit: 931e3cf
@github-actions
github-actionsBot
commented
Jun 30, 2026

Copy link


Copy Markdown

Contributor
API Changes Report
Generated by Break Check on 2026-06-30T17:54:25.979Z
Summary
MetricCount
Packages analyzed19
Packages with changes0
🔴 Breaking changes0
🟡 Non-breaking changes0
🟢 Additions0
No API Changes Detected
All packages have stable APIs with no detected changes.
Report generated by Break Check
Last ran on 931e3cf.
@coderabbitai
coderabbitaiBot
commented
Jun 30, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Review Change Stack
No actionable comments were generated in the recent review. 🎉
ℹ️ Recent review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Repository UI (inherited)
Review profile: CHILL
Plan: Pro Plus
Run ID: f1944d7e-e579-4eff-a3c5-86fe95ea5b82
📥 Commits
Reviewing files that changed from the base of the PR and between 4306146 and 931e3cf.
📒 Files selected for processing (3)
  • .changeset/truncate-surrogate-safe.md
  • packages/ui/src/utils/__tests__/truncateTextWithEndVisible.test.ts
  • packages/ui/src/utils/truncateTextWithEndVisible.ts
📝 Walkthrough
Walkthrough
truncateWithEndVisible is updated to use Array.from(str) for code-point-aware length checks and slicing, fixing broken surrogate pairs when truncating strings containing out-of-BMP characters. Two new test cases and a patch changeset entry are added.
Changes
Surrogate-safe truncation fix
Layer / File(s)Summary
Fix and test for surrogate-safe fallback
packages/ui/src/utils/truncateTextWithEndVisible.ts, packages/ui/src/utils/__tests__/truncateTextWithEndVisible.test.ts, .changeset/truncate-surrogate-safe.md		Splits the falsy-string guard from the length check, converts the string to a chars array via Array.from, uses that array for both the "no truncation needed" check and the short-maxLength branch. Adds tests for CJK Extension B and emoji inputs, and a patch changeset entry.
Estimated code review effort
🎯 1 (Trivial) | ⏱️ ~5 minutes
Poem
🐇 A rabbit once sliced through a CJK glyph,

And broke it in two — quite a Unicode cliff!

Now Array.from guards every code point,

No surrogate halves left out of joint.

Hop hop, the fix lands without a mishap! ✨
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title clearly summarizes the main fix: making the short-width fallback of truncateWithEndVisible code-point-safe.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  •  Create stacked PR
  •  Commit on current branch
Comment @coderabbitai help to get the list of available commands.
wobsoriano
wobsoriano
approved these changes
Jul 1, 2026
View reviewed changes
@wobsorianowobsoriano
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼
@wobsoriano
wobsoriano
merged commit 5a51943
into
mainJul 1, 2026

53 checks passed

@wobsoriano
wobsoriano
deleted the

create-pr-surrogate-truncate

branch
July 1, 2026 17:07
@clerk-cookieclerk-cookie
mentioned this pull request
Jul 1, 2026
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@wobsorianowobsorianowobsoriano approved these changes

Assignees


No one assigned


Labels

ui

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@alexcarpenter@wobsoriano@mahirhir

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
fix(ui): keep truncateWithEndVisible code-point-safe in short-width fallback - #9047
Merged
wobsoriano merged 1 commit into
mainfrom 
create-pr-surrogate-truncate
Jul 1, 2026
Merged
fix(ui): keep truncateWithEndVisible code-point-safe in short-width fallback#9047
wobsoriano merged 1 commit into
mainfrom 
create-pr-surrogate-truncate
Conversation
@alexcarpenter
@alexcarpenteralexcarpenter
commented
Jun 30, 2026•

edited by coderabbitai
Bot
Loading

Copy link


Copy Markdown

Member
truncateWithEndVisible keeps the start and end of a string and puts an ellipsis in the middle. The main path builds the result from Array.from(str), so it slices on code points and never breaks a character. The short-width fallback (taken when maxLength <= endChars + 3) instead returned ELLIPSIS + str.slice(-endChars), which slices on UTF-16 code units.
For characters outside the BMP (CJK Extension B kanji, emoji) each character is a surrogate pair of two code units, so str.slice(-endChars) can cut one in half and leave a lone surrogate:
truncateWithEndVisible('𠮷𠮷𠮷𠮷𠮷',8,5)// before: '...\uDFB7𠮷𠮷' (broken leading character)// after: '...𠮷𠮷𠮷𠮷𠮷'
The fallback now slices by code point, the same way the main path already does. ASCII inputs are unaffected and the existing tests still pass. Added a test covering the fallback with astral characters.
Re-creates #9029 from a branch in this repo so CI runs with the necessary secrets. Authored by @greymoth-jp; original commit authorship is preserved in git history.
Summary by CodeRabbit
  • Bug Fixes
    • Improved text truncation so very short widths no longer split emoji or other non-BMP characters into broken symbols.
    • Made character counting and fallback truncation behave consistently with Unicode code points, preserving readable output.
    • Added coverage for Unicode edge cases to prevent regressions.
@changeset-bot
changeset-botBot
commented
Jun 30, 2026•

edited

Loading

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: 931e3cf
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 3 packages
NameType
@clerk/uiPatch
@clerk/chrome-extensionPatch
@clerk/swingsetPatch
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@vercel
vercelBot
commented
Jun 30, 2026•

edited

Loading

Copy link


Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.
ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxReadyReadyPreview, CommentJun 30, 2026 5:52pm
swingsetReadyReadyPreview, CommentJun 30, 2026 5:52pm
Request Review
@alexcarpenter
alexcarpenterforce-pushed
the
create-pr-surrogate-truncate
branch
from
effb3f1 to
931e3cfCompareJune 30, 2026 17:50
@alexcarpenteralexcarpenter
mentioned this pull request
Jun 30, 2026
 Closed

@pkg-pr-new
pkg-pr-newBot
commented
Jun 30, 2026

Copy link


Copy Markdown

Open in StackBlitz
@clerk/astro
npm i https://pkg.pr.new/@clerk/astro@9047

@clerk/backend
npm i https://pkg.pr.new/@clerk/backend@9047

@clerk/chrome-extension
npm i https://pkg.pr.new/@clerk/chrome-extension@9047

@clerk/clerk-js
npm i https://pkg.pr.new/@clerk/clerk-js@9047

@clerk/electron
npm i https://pkg.pr.new/@clerk/electron@9047

@clerk/electron-passkeys
npm i https://pkg.pr.new/@clerk/electron-passkeys@9047

@clerk/eslint-plugin
npm i https://pkg.pr.new/@clerk/eslint-plugin@9047

@clerk/expo
npm i https://pkg.pr.new/@clerk/expo@9047

@clerk/expo-passkeys
npm i https://pkg.pr.new/@clerk/expo-passkeys@9047

@clerk/express
npm i https://pkg.pr.new/@clerk/express@9047

@clerk/fastify
npm i https://pkg.pr.new/@clerk/fastify@9047

@clerk/hono
npm i https://pkg.pr.new/@clerk/hono@9047

@clerk/localizations
npm i https://pkg.pr.new/@clerk/localizations@9047

@clerk/nextjs
npm i https://pkg.pr.new/@clerk/nextjs@9047

@clerk/nuxt
npm i https://pkg.pr.new/@clerk/nuxt@9047

@clerk/react
npm i https://pkg.pr.new/@clerk/react@9047

@clerk/react-router
npm i https://pkg.pr.new/@clerk/react-router@9047

@clerk/shared
npm i https://pkg.pr.new/@clerk/shared@9047

@clerk/tanstack-react-start
npm i https://pkg.pr.new/@clerk/tanstack-react-start@9047

@clerk/testing
npm i https://pkg.pr.new/@clerk/testing@9047

@clerk/ui
npm i https://pkg.pr.new/@clerk/ui@9047

@clerk/upgrade
npm i https://pkg.pr.new/@clerk/upgrade@9047

@clerk/vue
npm i https://pkg.pr.new/@clerk/vue@9047

commit: 931e3cf
@github-actions
github-actionsBot
commented
Jun 30, 2026

Copy link


Copy Markdown

Contributor
API Changes Report
Generated by Break Check on 2026-06-30T17:54:25.979Z
Summary
MetricCount
Packages analyzed19
Packages with changes0
🔴 Breaking changes0
🟡 Non-breaking changes0
🟢 Additions0
No API Changes Detected
All packages have stable APIs with no detected changes.
Report generated by Break Check
Last ran on 931e3cf.
@coderabbitai
coderabbitaiBot
commented
Jun 30, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Review Change Stack
No actionable comments were generated in the recent review. 🎉
ℹ️ Recent review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Repository UI (inherited)
Review profile: CHILL
Plan: Pro Plus
Run ID: f1944d7e-e579-4eff-a3c5-86fe95ea5b82
📥 Commits
Reviewing files that changed from the base of the PR and between 4306146 and 931e3cf.
📒 Files selected for processing (3)
  • .changeset/truncate-surrogate-safe.md
  • packages/ui/src/utils/__tests__/truncateTextWithEndVisible.test.ts
  • packages/ui/src/utils/truncateTextWithEndVisible.ts
📝 Walkthrough
Walkthrough
truncateWithEndVisible is updated to use Array.from(str) for code-point-aware length checks and slicing, fixing broken surrogate pairs when truncating strings containing out-of-BMP characters. Two new test cases and a patch changeset entry are added.
Changes
Surrogate-safe truncation fix
Layer / File(s)Summary
Fix and test for surrogate-safe fallback
packages/ui/src/utils/truncateTextWithEndVisible.ts, packages/ui/src/utils/__tests__/truncateTextWithEndVisible.test.ts, .changeset/truncate-surrogate-safe.md		Splits the falsy-string guard from the length check, converts the string to a chars array via Array.from, uses that array for both the "no truncation needed" check and the short-maxLength branch. Adds tests for CJK Extension B and emoji inputs, and a patch changeset entry.
Estimated code review effort
🎯 1 (Trivial) | ⏱️ ~5 minutes
Poem
🐇 A rabbit once sliced through a CJK glyph,

And broke it in two — quite a Unicode cliff!

Now Array.from guards every code point,

No surrogate halves left out of joint.

Hop hop, the fix lands without a mishap! ✨
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title clearly summarizes the main fix: making the short-width fallback of truncateWithEndVisible code-point-safe.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  •  Create stacked PR
  •  Commit on current branch
Comment @coderabbitai help to get the list of available commands.
wobsoriano
wobsoriano
approved these changes
Jul 1, 2026
View reviewed changes
@wobsorianowobsoriano
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼
@wobsoriano
wobsoriano
merged commit 5a51943
into
mainJul 1, 2026

53 checks passed

@wobsoriano
wobsoriano
deleted the

create-pr-surrogate-truncate

branch
July 1, 2026 17:07
@clerk-cookieclerk-cookie
mentioned this pull request
Jul 1, 2026
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@wobsorianowobsorianowobsoriano approved these changes

Assignees


No one assigned


Labels

ui

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@alexcarpenter@wobsoriano@mahirhir

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
fix(ui): keep truncateWithEndVisible code-point-safe in short-width fallback - #9047
Merged
wobsoriano merged 1 commit into
mainfrom 
create-pr-surrogate-truncate
Jul 1, 2026
Merged
fix(ui): keep truncateWithEndVisible code-point-safe in short-width fallback#9047
wobsoriano merged 1 commit into
mainfrom 
create-pr-surrogate-truncate
Conversation
@alexcarpenter
@alexcarpenteralexcarpenter
commented
Jun 30, 2026•

edited by coderabbitai
Bot
Loading

Copy link


Copy Markdown

Member
truncateWithEndVisible keeps the start and end of a string and puts an ellipsis in the middle. The main path builds the result from Array.from(str), so it slices on code points and never breaks a character. The short-width fallback (taken when maxLength <= endChars + 3) instead returned ELLIPSIS + str.slice(-endChars), which slices on UTF-16 code units.
For characters outside the BMP (CJK Extension B kanji, emoji) each character is a surrogate pair of two code units, so str.slice(-endChars) can cut one in half and leave a lone surrogate:
truncateWithEndVisible('𠮷𠮷𠮷𠮷𠮷',8,5)// before: '...\uDFB7𠮷𠮷' (broken leading character)// after: '...𠮷𠮷𠮷𠮷𠮷'
The fallback now slices by code point, the same way the main path already does. ASCII inputs are unaffected and the existing tests still pass. Added a test covering the fallback with astral characters.
Re-creates #9029 from a branch in this repo so CI runs with the necessary secrets. Authored by @greymoth-jp; original commit authorship is preserved in git history.
Summary by CodeRabbit
  • Bug Fixes
    • Improved text truncation so very short widths no longer split emoji or other non-BMP characters into broken symbols.
    • Made character counting and fallback truncation behave consistently with Unicode code points, preserving readable output.
    • Added coverage for Unicode edge cases to prevent regressions.
@changeset-bot
changeset-botBot
commented
Jun 30, 2026•

edited

Loading

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: 931e3cf
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 3 packages
NameType
@clerk/uiPatch
@clerk/chrome-extensionPatch
@clerk/swingsetPatch
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@vercel
vercelBot
commented
Jun 30, 2026•

edited

Loading

Copy link


Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.
ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxReadyReadyPreview, CommentJun 30, 2026 5:52pm
swingsetReadyReadyPreview, CommentJun 30, 2026 5:52pm
Request Review
@alexcarpenter
alexcarpenterforce-pushed
the
create-pr-surrogate-truncate
branch
from
effb3f1 to
931e3cfCompareJune 30, 2026 17:50
@alexcarpenteralexcarpenter
mentioned this pull request
Jun 30, 2026
 Closed

@pkg-pr-new
pkg-pr-newBot
commented
Jun 30, 2026

Copy link


Copy Markdown

Open in StackBlitz
@clerk/astro
npm i https://pkg.pr.new/@clerk/astro@9047

@clerk/backend
npm i https://pkg.pr.new/@clerk/backend@9047

@clerk/chrome-extension
npm i https://pkg.pr.new/@clerk/chrome-extension@9047

@clerk/clerk-js
npm i https://pkg.pr.new/@clerk/clerk-js@9047

@clerk/electron
npm i https://pkg.pr.new/@clerk/electron@9047

@clerk/electron-passkeys
npm i https://pkg.pr.new/@clerk/electron-passkeys@9047

@clerk/eslint-plugin
npm i https://pkg.pr.new/@clerk/eslint-plugin@9047

@clerk/expo
npm i https://pkg.pr.new/@clerk/expo@9047

@clerk/expo-passkeys
npm i https://pkg.pr.new/@clerk/expo-passkeys@9047

@clerk/express
npm i https://pkg.pr.new/@clerk/express@9047

@clerk/fastify
npm i https://pkg.pr.new/@clerk/fastify@9047

@clerk/hono
npm i https://pkg.pr.new/@clerk/hono@9047

@clerk/localizations
npm i https://pkg.pr.new/@clerk/localizations@9047

@clerk/nextjs
npm i https://pkg.pr.new/@clerk/nextjs@9047

@clerk/nuxt
npm i https://pkg.pr.new/@clerk/nuxt@9047

@clerk/react
npm i https://pkg.pr.new/@clerk/react@9047

@clerk/react-router
npm i https://pkg.pr.new/@clerk/react-router@9047

@clerk/shared
npm i https://pkg.pr.new/@clerk/shared@9047

@clerk/tanstack-react-start
npm i https://pkg.pr.new/@clerk/tanstack-react-start@9047

@clerk/testing
npm i https://pkg.pr.new/@clerk/testing@9047

@clerk/ui
npm i https://pkg.pr.new/@clerk/ui@9047

@clerk/upgrade
npm i https://pkg.pr.new/@clerk/upgrade@9047

@clerk/vue
npm i https://pkg.pr.new/@clerk/vue@9047

commit: 931e3cf
@github-actions
github-actionsBot
commented
Jun 30, 2026

Copy link


Copy Markdown

Contributor
API Changes Report
Generated by Break Check on 2026-06-30T17:54:25.979Z
Summary
MetricCount
Packages analyzed19
Packages with changes0
🔴 Breaking changes0
🟡 Non-breaking changes0
🟢 Additions0
No API Changes Detected
All packages have stable APIs with no detected changes.
Report generated by Break Check
Last ran on 931e3cf.
@coderabbitai
coderabbitaiBot
commented
Jun 30, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Review Change Stack
No actionable comments were generated in the recent review. 🎉
ℹ️ Recent review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Repository UI (inherited)
Review profile: CHILL
Plan: Pro Plus
Run ID: f1944d7e-e579-4eff-a3c5-86fe95ea5b82
📥 Commits
Reviewing files that changed from the base of the PR and between 4306146 and 931e3cf.
📒 Files selected for processing (3)
  • .changeset/truncate-surrogate-safe.md
  • packages/ui/src/utils/__tests__/truncateTextWithEndVisible.test.ts
  • packages/ui/src/utils/truncateTextWithEndVisible.ts
📝 Walkthrough
Walkthrough
truncateWithEndVisible is updated to use Array.from(str) for code-point-aware length checks and slicing, fixing broken surrogate pairs when truncating strings containing out-of-BMP characters. Two new test cases and a patch changeset entry are added.
Changes
Surrogate-safe truncation fix
Layer / File(s)Summary
Fix and test for surrogate-safe fallback
packages/ui/src/utils/truncateTextWithEndVisible.ts, packages/ui/src/utils/__tests__/truncateTextWithEndVisible.test.ts, .changeset/truncate-surrogate-safe.md		Splits the falsy-string guard from the length check, converts the string to a chars array via Array.from, uses that array for both the "no truncation needed" check and the short-maxLength branch. Adds tests for CJK Extension B and emoji inputs, and a patch changeset entry.
Estimated code review effort
🎯 1 (Trivial) | ⏱️ ~5 minutes
Poem
🐇 A rabbit once sliced through a CJK glyph,

And broke it in two — quite a Unicode cliff!

Now Array.from guards every code point,

No surrogate halves left out of joint.

Hop hop, the fix lands without a mishap! ✨
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title clearly summarizes the main fix: making the short-width fallback of truncateWithEndVisible code-point-safe.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  •  Create stacked PR
  •  Commit on current branch
Comment @coderabbitai help to get the list of available commands.
wobsoriano
wobsoriano
approved these changes
Jul 1, 2026
View reviewed changes
@wobsorianowobsoriano
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼
@wobsoriano
wobsoriano
merged commit 5a51943
into
mainJul 1, 2026

53 checks passed

@wobsoriano
wobsoriano
deleted the

create-pr-surrogate-truncate

branch
July 1, 2026 17:07
@clerk-cookieclerk-cookie
mentioned this pull request
Jul 1, 2026
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@wobsorianowobsorianowobsoriano approved these changes

Assignees


No one assigned


Labels

ui

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@alexcarpenter@wobsoriano@mahirhir

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
fix(ui): keep truncateWithEndVisible code-point-safe in short-width fallback - #9047
Merged
wobsoriano merged 1 commit into
mainfrom 
create-pr-surrogate-truncate
Jul 1, 2026
Merged
fix(ui): keep truncateWithEndVisible code-point-safe in short-width fallback#9047
wobsoriano merged 1 commit into
mainfrom 
create-pr-surrogate-truncate
Conversation
@alexcarpenter
@alexcarpenteralexcarpenter
commented
Jun 30, 2026•

edited by coderabbitai
Bot
Loading

Copy link


Copy Markdown

Member
truncateWithEndVisible keeps the start and end of a string and puts an ellipsis in the middle. The main path builds the result from Array.from(str), so it slices on code points and never breaks a character. The short-width fallback (taken when maxLength <= endChars + 3) instead returned ELLIPSIS + str.slice(-endChars), which slices on UTF-16 code units.
For characters outside the BMP (CJK Extension B kanji, emoji) each character is a surrogate pair of two code units, so str.slice(-endChars) can cut one in half and leave a lone surrogate:
truncateWithEndVisible('𠮷𠮷𠮷𠮷𠮷',8,5)// before: '...\uDFB7𠮷𠮷' (broken leading character)// after: '...𠮷𠮷𠮷𠮷𠮷'
The fallback now slices by code point, the same way the main path already does. ASCII inputs are unaffected and the existing tests still pass. Added a test covering the fallback with astral characters.
Re-creates #9029 from a branch in this repo so CI runs with the necessary secrets. Authored by @greymoth-jp; original commit authorship is preserved in git history.
Summary by CodeRabbit
  • Bug Fixes
    • Improved text truncation so very short widths no longer split emoji or other non-BMP characters into broken symbols.
    • Made character counting and fallback truncation behave consistently with Unicode code points, preserving readable output.
    • Added coverage for Unicode edge cases to prevent regressions.
@changeset-bot
changeset-botBot
commented
Jun 30, 2026•

edited

Loading

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: 931e3cf
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 3 packages
NameType
@clerk/uiPatch
@clerk/chrome-extensionPatch
@clerk/swingsetPatch
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@vercel
vercelBot
commented
Jun 30, 2026•

edited

Loading

Copy link


Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.
ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxReadyReadyPreview, CommentJun 30, 2026 5:52pm
swingsetReadyReadyPreview, CommentJun 30, 2026 5:52pm
Request Review
@alexcarpenter
alexcarpenterforce-pushed
the
create-pr-surrogate-truncate
branch
from
effb3f1 to
931e3cfCompareJune 30, 2026 17:50
@alexcarpenteralexcarpenter
mentioned this pull request
Jun 30, 2026
 Closed

@pkg-pr-new
pkg-pr-newBot
commented
Jun 30, 2026

Copy link


Copy Markdown

Open in StackBlitz
@clerk/astro
npm i https://pkg.pr.new/@clerk/astro@9047

@clerk/backend
npm i https://pkg.pr.new/@clerk/backend@9047

@clerk/chrome-extension
npm i https://pkg.pr.new/@clerk/chrome-extension@9047

@clerk/clerk-js
npm i https://pkg.pr.new/@clerk/clerk-js@9047

@clerk/electron
npm i https://pkg.pr.new/@clerk/electron@9047

@clerk/electron-passkeys
npm i https://pkg.pr.new/@clerk/electron-passkeys@9047

@clerk/eslint-plugin
npm i https://pkg.pr.new/@clerk/eslint-plugin@9047

@clerk/expo
npm i https://pkg.pr.new/@clerk/expo@9047

@clerk/expo-passkeys
npm i https://pkg.pr.new/@clerk/expo-passkeys@9047

@clerk/express
npm i https://pkg.pr.new/@clerk/express@9047

@clerk/fastify
npm i https://pkg.pr.new/@clerk/fastify@9047

@clerk/hono
npm i https://pkg.pr.new/@clerk/hono@9047

@clerk/localizations
npm i https://pkg.pr.new/@clerk/localizations@9047

@clerk/nextjs
npm i https://pkg.pr.new/@clerk/nextjs@9047

@clerk/nuxt
npm i https://pkg.pr.new/@clerk/nuxt@9047

@clerk/react
npm i https://pkg.pr.new/@clerk/react@9047

@clerk/react-router
npm i https://pkg.pr.new/@clerk/react-router@9047

@clerk/shared
npm i https://pkg.pr.new/@clerk/shared@9047

@clerk/tanstack-react-start
npm i https://pkg.pr.new/@clerk/tanstack-react-start@9047

@clerk/testing
npm i https://pkg.pr.new/@clerk/testing@9047

@clerk/ui
npm i https://pkg.pr.new/@clerk/ui@9047

@clerk/upgrade
npm i https://pkg.pr.new/@clerk/upgrade@9047

@clerk/vue
npm i https://pkg.pr.new/@clerk/vue@9047

commit: 931e3cf
@github-actions
github-actionsBot
commented
Jun 30, 2026

Copy link


Copy Markdown

Contributor
API Changes Report
Generated by Break Check on 2026-06-30T17:54:25.979Z
Summary
MetricCount
Packages analyzed19
Packages with changes0
🔴 Breaking changes0
🟡 Non-breaking changes0
🟢 Additions0
No API Changes Detected
All packages have stable APIs with no detected changes.
Report generated by Break Check
Last ran on 931e3cf.
@coderabbitai
coderabbitaiBot
commented
Jun 30, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Review Change Stack
No actionable comments were generated in the recent review. 🎉
ℹ️ Recent review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Repository UI (inherited)
Review profile: CHILL
Plan: Pro Plus
Run ID: f1944d7e-e579-4eff-a3c5-86fe95ea5b82
📥 Commits
Reviewing files that changed from the base of the PR and between 4306146 and 931e3cf.
📒 Files selected for processing (3)
  • .changeset/truncate-surrogate-safe.md
  • packages/ui/src/utils/__tests__/truncateTextWithEndVisible.test.ts
  • packages/ui/src/utils/truncateTextWithEndVisible.ts
📝 Walkthrough
Walkthrough
truncateWithEndVisible is updated to use Array.from(str) for code-point-aware length checks and slicing, fixing broken surrogate pairs when truncating strings containing out-of-BMP characters. Two new test cases and a patch changeset entry are added.
Changes
Surrogate-safe truncation fix
Layer / File(s)Summary
Fix and test for surrogate-safe fallback
packages/ui/src/utils/truncateTextWithEndVisible.ts, packages/ui/src/utils/__tests__/truncateTextWithEndVisible.test.ts, .changeset/truncate-surrogate-safe.md		Splits the falsy-string guard from the length check, converts the string to a chars array via Array.from, uses that array for both the "no truncation needed" check and the short-maxLength branch. Adds tests for CJK Extension B and emoji inputs, and a patch changeset entry.
Estimated code review effort
🎯 1 (Trivial) | ⏱️ ~5 minutes
Poem
🐇 A rabbit once sliced through a CJK glyph,

And broke it in two — quite a Unicode cliff!

Now Array.from guards every code point,

No surrogate halves left out of joint.

Hop hop, the fix lands without a mishap! ✨
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title clearly summarizes the main fix: making the short-width fallback of truncateWithEndVisible code-point-safe.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  •  Create stacked PR
  •  Commit on current branch
Comment @coderabbitai help to get the list of available commands.
wobsoriano
wobsoriano
approved these changes
Jul 1, 2026
View reviewed changes
@wobsorianowobsoriano
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼
@wobsoriano
wobsoriano
merged commit 5a51943
into
mainJul 1, 2026

53 checks passed

@wobsoriano
wobsoriano
deleted the

create-pr-surrogate-truncate

branch
July 1, 2026 17:07
@clerk-cookieclerk-cookie
mentioned this pull request
Jul 1, 2026
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@wobsorianowobsorianowobsoriano approved these changes

Assignees


No one assigned


Labels

ui

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@alexcarpenter@wobsoriano@mahirhir

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Universal Dark Mode - works on any site
(function() {
var enabled = true;
function applyDarkMode() {
if (!enabled) return;
// Create style element if it doesn't exist
var style = document.getElementById('universal-dark-mode-style');
if (!style) {
style = document.createElement('style');
style.id = 'universal-dark-mode-style';
document.head.appendChild(style);
}
// Dark mode CSS - inverts colors but preserves images/video
style.textContent = '
/* Invert everything except media */
html {
filter: invert(1) hue-rotate(180deg) !important;
background: #1a1a2e !important;
}
/* Restore images, videos, iframes, canvas */
img, video, iframe, canvas, svg, picture, [style*="background-image"] {
filter: invert(1) hue-rotate(180deg) !important;
}
/* Preserve specific elements that should not be inverted */
.no-dark-mode, .no-dark-mode *,
[data-theme="light"], [data-theme="light"],
.ace_editor, .ace_editor *,
.CodeMirror, .CodeMirror *,
.monaco-editor, .monaco-editor *,
.markdown-body pre, .markdown-body pre *,
.highlight, .highlight *,
pre code, pre code * {
filter: none !important;
}
/* Fix common UI elements */
.modal, .popup, .dropdown-menu, .tooltip, .popover {
filter: invert(1) hue-rotate(180deg) !important;
background: #2d2d44 !important;
border-color: #444 !important;
}
/* Scrollbars */
::-webkit-scrollbar { background: #1a1a2e !important; }
::-webkit-scrollbar-thumb { background: #444 !important; }
::-webkit-scrollbar-thumb:hover { background: #555 !important; }
/* Selection */
::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
';
}
function removeDarkMode() {
var style = document.getElementById('universal-dark-mode-style');
if (style) style.remove();
}
// Toggle with Alt+Shift+D
document.addEventListener('keydown', function(e) {
if (e.altKey && e.shiftKey && e.key === 'D') {
e.preventDefault();
enabled = !enabled;
if (enabled) {
applyDarkMode();
console.log('[Universal Dark Mode] Enabled');
} else {
removeDarkMode();
console.log('[Universal Dark Mode] Disabled');
}
}
});
// Apply on load
applyDarkMode();
// Re-apply on dynamic content
var observer = new MutationObserver(function(mutations) {
if (enabled && !document.getElementById('universal-dark-mode-style')) {
applyDarkMode();
}
});
observer.observe(document.head, { childList: true });
console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');
})();
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
fix(ui): keep truncateWithEndVisible code-point-safe in short-width fallback - #9047
Merged
wobsoriano merged 1 commit into
mainfrom 
create-pr-surrogate-truncate
Jul 1, 2026
Merged
fix(ui): keep truncateWithEndVisible code-point-safe in short-width fallback#9047
wobsoriano merged 1 commit into
mainfrom 
create-pr-surrogate-truncate
Conversation
@alexcarpenter
@alexcarpenteralexcarpenter
commented
Jun 30, 2026•

edited by coderabbitai
Bot
Loading

Copy link


Copy Markdown

Member
truncateWithEndVisible keeps the start and end of a string and puts an ellipsis in the middle. The main path builds the result from Array.from(str), so it slices on code points and never breaks a character. The short-width fallback (taken when maxLength <= endChars + 3) instead returned ELLIPSIS + str.slice(-endChars), which slices on UTF-16 code units.
For characters outside the BMP (CJK Extension B kanji, emoji) each character is a surrogate pair of two code units, so str.slice(-endChars) can cut one in half and leave a lone surrogate:
truncateWithEndVisible('𠮷𠮷𠮷𠮷𠮷',8,5)// before: '...\uDFB7𠮷𠮷' (broken leading character)// after: '...𠮷𠮷𠮷𠮷𠮷'
The fallback now slices by code point, the same way the main path already does. ASCII inputs are unaffected and the existing tests still pass. Added a test covering the fallback with astral characters.
Re-creates #9029 from a branch in this repo so CI runs with the necessary secrets. Authored by @greymoth-jp; original commit authorship is preserved in git history.
Summary by CodeRabbit
  • Bug Fixes
    • Improved text truncation so very short widths no longer split emoji or other non-BMP characters into broken symbols.
    • Made character counting and fallback truncation behave consistently with Unicode code points, preserving readable output.
    • Added coverage for Unicode edge cases to prevent regressions.
@changeset-bot
changeset-botBot
commented
Jun 30, 2026•

edited

Loading

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: 931e3cf
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 3 packages
NameType
@clerk/uiPatch
@clerk/chrome-extensionPatch
@clerk/swingsetPatch
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@vercel
vercelBot
commented
Jun 30, 2026•

edited

Loading

Copy link


Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.
ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxReadyReadyPreview, CommentJun 30, 2026 5:52pm
swingsetReadyReadyPreview, CommentJun 30, 2026 5:52pm
Request Review
@alexcarpenter
alexcarpenterforce-pushed
the
create-pr-surrogate-truncate
branch
from
effb3f1 to
931e3cfCompareJune 30, 2026 17:50
@alexcarpenteralexcarpenter
mentioned this pull request
Jun 30, 2026
 Closed

@pkg-pr-new
pkg-pr-newBot
commented
Jun 30, 2026

Copy link


Copy Markdown

Open in StackBlitz
@clerk/astro
npm i https://pkg.pr.new/@clerk/astro@9047

@clerk/backend
npm i https://pkg.pr.new/@clerk/backend@9047

@clerk/chrome-extension
npm i https://pkg.pr.new/@clerk/chrome-extension@9047

@clerk/clerk-js
npm i https://pkg.pr.new/@clerk/clerk-js@9047

@clerk/electron
npm i https://pkg.pr.new/@clerk/electron@9047

@clerk/electron-passkeys
npm i https://pkg.pr.new/@clerk/electron-passkeys@9047

@clerk/eslint-plugin
npm i https://pkg.pr.new/@clerk/eslint-plugin@9047

@clerk/expo
npm i https://pkg.pr.new/@clerk/expo@9047

@clerk/expo-passkeys
npm i https://pkg.pr.new/@clerk/expo-passkeys@9047

@clerk/express
npm i https://pkg.pr.new/@clerk/express@9047

@clerk/fastify
npm i https://pkg.pr.new/@clerk/fastify@9047

@clerk/hono
npm i https://pkg.pr.new/@clerk/hono@9047

@clerk/localizations
npm i https://pkg.pr.new/@clerk/localizations@9047

@clerk/nextjs
npm i https://pkg.pr.new/@clerk/nextjs@9047

@clerk/nuxt
npm i https://pkg.pr.new/@clerk/nuxt@9047

@clerk/react
npm i https://pkg.pr.new/@clerk/react@9047

@clerk/react-router
npm i https://pkg.pr.new/@clerk/react-router@9047

@clerk/shared
npm i https://pkg.pr.new/@clerk/shared@9047

@clerk/tanstack-react-start
npm i https://pkg.pr.new/@clerk/tanstack-react-start@9047

@clerk/testing
npm i https://pkg.pr.new/@clerk/testing@9047

@clerk/ui
npm i https://pkg.pr.new/@clerk/ui@9047

@clerk/upgrade
npm i https://pkg.pr.new/@clerk/upgrade@9047

@clerk/vue
npm i https://pkg.pr.new/@clerk/vue@9047

commit: 931e3cf
@github-actions
github-actionsBot
commented
Jun 30, 2026

Copy link


Copy Markdown

Contributor
API Changes Report
Generated by Break Check on 2026-06-30T17:54:25.979Z
Summary
MetricCount
Packages analyzed19
Packages with changes0
🔴 Breaking changes0
🟡 Non-breaking changes0
🟢 Additions0
No API Changes Detected
All packages have stable APIs with no detected changes.
Report generated by Break Check
Last ran on 931e3cf.
@coderabbitai
coderabbitaiBot
commented
Jun 30, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Review Change Stack
No actionable comments were generated in the recent review. 🎉
ℹ️ Recent review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Repository UI (inherited)
Review profile: CHILL
Plan: Pro Plus
Run ID: f1944d7e-e579-4eff-a3c5-86fe95ea5b82
📥 Commits
Reviewing files that changed from the base of the PR and between 4306146 and 931e3cf.
📒 Files selected for processing (3)
  • .changeset/truncate-surrogate-safe.md
  • packages/ui/src/utils/__tests__/truncateTextWithEndVisible.test.ts
  • packages/ui/src/utils/truncateTextWithEndVisible.ts
📝 Walkthrough
Walkthrough
truncateWithEndVisible is updated to use Array.from(str) for code-point-aware length checks and slicing, fixing broken surrogate pairs when truncating strings containing out-of-BMP characters. Two new test cases and a patch changeset entry are added.
Changes
Surrogate-safe truncation fix
Layer / File(s)Summary
Fix and test for surrogate-safe fallback
packages/ui/src/utils/truncateTextWithEndVisible.ts, packages/ui/src/utils/__tests__/truncateTextWithEndVisible.test.ts, .changeset/truncate-surrogate-safe.md		Splits the falsy-string guard from the length check, converts the string to a chars array via Array.from, uses that array for both the "no truncation needed" check and the short-maxLength branch. Adds tests for CJK Extension B and emoji inputs, and a patch changeset entry.
Estimated code review effort
🎯 1 (Trivial) | ⏱️ ~5 minutes
Poem
🐇 A rabbit once sliced through a CJK glyph,

And broke it in two — quite a Unicode cliff!

Now Array.from guards every code point,

No surrogate halves left out of joint.

Hop hop, the fix lands without a mishap! ✨
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title clearly summarizes the main fix: making the short-width fallback of truncateWithEndVisible code-point-safe.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  •  Create stacked PR
  •  Commit on current branch
Comment @coderabbitai help to get the list of available commands.
wobsoriano
wobsoriano
approved these changes
Jul 1, 2026
View reviewed changes
@wobsorianowobsoriano
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼
@wobsoriano
wobsoriano
merged commit 5a51943
into
mainJul 1, 2026

53 checks passed

@wobsoriano
wobsoriano
deleted the

create-pr-surrogate-truncate

branch
July 1, 2026 17:07
@clerk-cookieclerk-cookie
mentioned this pull request
Jul 1, 2026
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@wobsorianowobsorianowobsoriano approved these changes

Assignees


No one assigned


Labels

ui

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@alexcarpenter@wobsoriano@mahirhir