Uh oh!
There was an error while loading. Please reload this page.
fix(ui): stop mid-flow test-run refetches from gating the security page loading - #9049
fix(ui): stop mid-flow test-run refetches from gating the security page loading#9049iagodahlem wants to merge 2 commits into
Conversation
…ge loading The enterprise-connection hook folded test-runs loading into the page-level loading flag whenever a connection existed at first load. That latch never expired, so re-fetching test runs mid-session (e.g. after a reconfigure) re-raised the whole page skeleton instead of staying a table-level load. Gate the test-runs term on a "first settle" latch so it only contributes during the genuine initial page load. The status badge is still correct on first paint — an existing connection still gates the initial skeleton on its test-runs probe — but later test-run loads no longer flip the page-level flag.
The latest updates on your projects. Learn more about Vercel for GitHub.
|
🦋 Changeset detectedLatest commit: 01428ab The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository YAML (base), Repository UI (inherited) Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
@clerk/astro@clerk/backend@clerk/chrome-extension@clerk/clerk-js@clerk/electron@clerk/electron-passkeys@clerk/eslint-plugin@clerk/expo@clerk/expo-passkeys@clerk/express@clerk/fastify@clerk/hono@clerk/localizations@clerk/nextjs@clerk/nuxt@clerk/react@clerk/react-router@clerk/shared@clerk/tanstack-react-start@clerk/testing@clerk/ui@clerk/upgrade@clerk/vuecommit: |
What
Decouple test-run loading from the page-level loading state on the
<OrganizationProfile />Security page.useOrganizationEnterpriseConnection'sisLoadingfolded in test-run loading via a session-longhadInitialConnectionlatch, so a test-run cold-load after the initial page load (e.g. configuring a connection mid-flow) could re-raise the page-level loading state. This adds an initial-settle latch (hasSettledRef) so test-run loading only gates the first page load; afterward it stays strictly table-level (the Test step's own loading), never the page skeleton.Follow-up to #9046 (the related ORGS-1701 Continue behavior). The user-facing wizard-unmount impact of this loading coupling was already fixed in #8999; this is the architectural cleanup of the
isLoadingderivation itself.Tests
Initial load with a connection still gates
isLoadingon the test-run probe; a later test-run cold-load no longer raises page-levelisLoading(stays table-level).