Skip to content

fix(ui): add accessible name to API Keys search input - #9055

Merged
wobsoriano merged 2 commits into
mainfrom
max/fix-api-keys-search-aria-label
Jun 30, 2026
Merged

fix(ui): add accessible name to API Keys search input#9055
wobsoriano merged 2 commits into
mainfrom
max/fix-api-keys-search-aria-label

Conversation

@wobsoriano

@wobsorianowobsoriano commented Jun 30, 2026

Copy link
Copy Markdown
Member

Description

See #9051

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

Summary by CodeRabbit

  • Bug Fixes

    • Improved the API Keys search field for screen readers by adding an accessible label.
    • Updated the search input to avoid browser autofill and ensure it behaves more consistently.
  • Tests

    • Added coverage to verify the API Keys search input is properly labeled and accessible.

@changeset-bot

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 2bc811e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
NameType
@clerk/uiPatch
@clerk/chrome-extensionPatch
@clerk/swingsetPatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel

vercelBot commented Jun 30, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxReadyReadyPreview, CommentJun 30, 2026 11:23pm
swingsetReadyReadyPreview, CommentJun 30, 2026 11:23pm

Request Review

@coderabbitai

coderabbitaiBot commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Repository UI (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: 46ccfb23-0592-4250-bf4f-80aed1aed106

📥 Commits

Reviewing files that changed from the base of the PR and between 268701c and 2bc811e.

📒 Files selected for processing (3)
  • .changeset/dirty-rockets-read.md
  • packages/ui/src/components/APIKeys/APIKeys.tsx
  • packages/ui/src/components/APIKeys/__tests__/APIKeys.spec.tsx

📝 Walkthrough

Walkthrough

This PR adds accessibility attributes to the API Keys search input in @clerk/ui, including a name attribute, an explicit localized aria-label, and autoComplete='off'. A test verifies the input's accessible name, and a changeset documents the patch.

Changes

API Keys Search Accessibility

Layer / File(s)Summary
Search input accessibility attributes
packages/ui/src/components/APIKeys/APIKeys.tsx
The search InputWithIcon adds a name attribute, an explicit localized aria-label, and autoComplete='off'.
Test coverage and changeset
packages/ui/src/components/APIKeys/__tests__/APIKeys.spec.tsx, .changeset/dirty-rockets-read.md
A new test asserts the search input has a visible searchbox role with an accessible name, and a changeset records the patch note.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

A little search box, now clear and proud,
Whispers its name to screen readers aloud.
No more guessing what this field is for—
Autofill's off, just type and explore. 🐰🔍

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title accurately summarizes the main change: adding an accessible name to the API Keys search input.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch

Comment @coderabbitai help to get the list of available commands.

@github-actions

Copy link
Copy Markdown
Contributor

API Changes Report

Generated by Break Check on 2026-06-30T23:26:45.046Z

Summary

MetricCount
Packages analyzed19
Packages with changes0
🔴 Breaking changes0
🟡 Non-breaking changes0
🟢 Additions0

No API Changes Detected

All packages have stable APIs with no detected changes.


Report generated by Break Check

Last ran on 2bc811e.

@pkg-pr-new

Copy link
Copy Markdown

Open in StackBlitz

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@9055

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@9055

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@9055

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@9055

@clerk/electron

npm i https://pkg.pr.new/@clerk/electron@9055

@clerk/electron-passkeys

npm i https://pkg.pr.new/@clerk/electron-passkeys@9055

@clerk/eslint-plugin

npm i https://pkg.pr.new/@clerk/eslint-plugin@9055

@clerk/expo

npm i https://pkg.pr.new/@clerk/expo@9055

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@9055

@clerk/express

npm i https://pkg.pr.new/@clerk/express@9055

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@9055

@clerk/hono

npm i https://pkg.pr.new/@clerk/hono@9055

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@9055

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@9055

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@9055

@clerk/react

npm i https://pkg.pr.new/@clerk/react@9055

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@9055

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@9055

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@9055

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@9055

@clerk/ui

npm i https://pkg.pr.new/@clerk/ui@9055

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@9055

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@9055

commit: 2bc811e

@wobsoriano
wobsoriano merged commit 08737e5 into mainJun 30, 2026
53 checks passed
@wobsoriano
wobsoriano deleted the max/fix-api-keys-search-aria-label branch June 30, 2026 23:28
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@wobsoriano@alexcarpenter@maxyinger
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
fix(ui): add accessible name to API Keys search input by wobsoriano · Pull Request #9055 · clerk/javascript · GitHub
Skip to content

fix(ui): add accessible name to API Keys search input - #9055

Merged
wobsoriano merged 2 commits into
mainfrom
max/fix-api-keys-search-aria-label
Jun 30, 2026
Merged

fix(ui): add accessible name to API Keys search input#9055
wobsoriano merged 2 commits into
mainfrom
max/fix-api-keys-search-aria-label

Conversation

@wobsoriano

@wobsorianowobsoriano commented Jun 30, 2026

Copy link
Copy Markdown
Member

Description

See #9051

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

Summary by CodeRabbit

  • Bug Fixes

    • Improved the API Keys search field for screen readers by adding an accessible label.
    • Updated the search input to avoid browser autofill and ensure it behaves more consistently.
  • Tests

    • Added coverage to verify the API Keys search input is properly labeled and accessible.

@changeset-bot

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 2bc811e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
NameType
@clerk/uiPatch
@clerk/chrome-extensionPatch
@clerk/swingsetPatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel

vercelBot commented Jun 30, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxReadyReadyPreview, CommentJun 30, 2026 11:23pm
swingsetReadyReadyPreview, CommentJun 30, 2026 11:23pm

Request Review

@coderabbitai

coderabbitaiBot commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Repository UI (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: 46ccfb23-0592-4250-bf4f-80aed1aed106

📥 Commits

Reviewing files that changed from the base of the PR and between 268701c and 2bc811e.

📒 Files selected for processing (3)
  • .changeset/dirty-rockets-read.md
  • packages/ui/src/components/APIKeys/APIKeys.tsx
  • packages/ui/src/components/APIKeys/__tests__/APIKeys.spec.tsx

📝 Walkthrough

Walkthrough

This PR adds accessibility attributes to the API Keys search input in @clerk/ui, including a name attribute, an explicit localized aria-label, and autoComplete='off'. A test verifies the input's accessible name, and a changeset documents the patch.

Changes

API Keys Search Accessibility

Layer / File(s)Summary
Search input accessibility attributes
packages/ui/src/components/APIKeys/APIKeys.tsx
The search InputWithIcon adds a name attribute, an explicit localized aria-label, and autoComplete='off'.
Test coverage and changeset
packages/ui/src/components/APIKeys/__tests__/APIKeys.spec.tsx, .changeset/dirty-rockets-read.md
A new test asserts the search input has a visible searchbox role with an accessible name, and a changeset records the patch note.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

A little search box, now clear and proud,
Whispers its name to screen readers aloud.
No more guessing what this field is for—
Autofill's off, just type and explore. 🐰🔍

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title accurately summarizes the main change: adding an accessible name to the API Keys search input.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch

Comment @coderabbitai help to get the list of available commands.

@github-actions

Copy link
Copy Markdown
Contributor

API Changes Report

Generated by Break Check on 2026-06-30T23:26:45.046Z

Summary

MetricCount
Packages analyzed19
Packages with changes0
🔴 Breaking changes0
🟡 Non-breaking changes0
🟢 Additions0

No API Changes Detected

All packages have stable APIs with no detected changes.


Report generated by Break Check

Last ran on 2bc811e.

@pkg-pr-new

Copy link
Copy Markdown

Open in StackBlitz

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@9055

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@9055

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@9055

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@9055

@clerk/electron

npm i https://pkg.pr.new/@clerk/electron@9055

@clerk/electron-passkeys

npm i https://pkg.pr.new/@clerk/electron-passkeys@9055

@clerk/eslint-plugin

npm i https://pkg.pr.new/@clerk/eslint-plugin@9055

@clerk/expo

npm i https://pkg.pr.new/@clerk/expo@9055

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@9055

@clerk/express

npm i https://pkg.pr.new/@clerk/express@9055

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@9055

@clerk/hono

npm i https://pkg.pr.new/@clerk/hono@9055

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@9055

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@9055

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@9055

@clerk/react

npm i https://pkg.pr.new/@clerk/react@9055

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@9055

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@9055

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@9055

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@9055

@clerk/ui

npm i https://pkg.pr.new/@clerk/ui@9055

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@9055

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@9055

commit: 2bc811e

@wobsoriano
wobsoriano merged commit 08737e5 into mainJun 30, 2026
53 checks passed
@wobsoriano
wobsoriano deleted the max/fix-api-keys-search-aria-label branch June 30, 2026 23:28
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@wobsoriano@alexcarpenter@maxyinger
, 'i'); if (__m === '*' || __re.test(location.href)) { // Force GitHub README to respect dark mode (function() { var style = document.createElement('style'); style.textContent = ' .markdown-body { color-scheme: dark light; } .markdown-body pre { background: #161b22 !important; } .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; } .markdown-body table th, .markdown-body table td { border-color: #30363d !important; } .markdown-body img { background: #0d1117; } .markdown-body blockquote { border-left-color: #8b949e; } .markdown-body hr { border-color: #30363d; } '; document.head.appendChild(style); })(); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' fix(ui): add accessible name to API Keys search input by wobsoriano · Pull Request #9055 · clerk/javascript · GitHub
Skip to content

fix(ui): add accessible name to API Keys search input - #9055

Merged
wobsoriano merged 2 commits into
mainfrom
max/fix-api-keys-search-aria-label
Jun 30, 2026
Merged

fix(ui): add accessible name to API Keys search input#9055
wobsoriano merged 2 commits into
mainfrom
max/fix-api-keys-search-aria-label

Conversation

@wobsoriano

@wobsorianowobsoriano commented Jun 30, 2026

Copy link
Copy Markdown
Member

Description

See #9051

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

Summary by CodeRabbit

  • Bug Fixes

    • Improved the API Keys search field for screen readers by adding an accessible label.
    • Updated the search input to avoid browser autofill and ensure it behaves more consistently.
  • Tests

    • Added coverage to verify the API Keys search input is properly labeled and accessible.

@changeset-bot

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 2bc811e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
NameType
@clerk/uiPatch
@clerk/chrome-extensionPatch
@clerk/swingsetPatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel

vercelBot commented Jun 30, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxReadyReadyPreview, CommentJun 30, 2026 11:23pm
swingsetReadyReadyPreview, CommentJun 30, 2026 11:23pm

Request Review

@coderabbitai

coderabbitaiBot commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Repository UI (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: 46ccfb23-0592-4250-bf4f-80aed1aed106

📥 Commits

Reviewing files that changed from the base of the PR and between 268701c and 2bc811e.

📒 Files selected for processing (3)
  • .changeset/dirty-rockets-read.md
  • packages/ui/src/components/APIKeys/APIKeys.tsx
  • packages/ui/src/components/APIKeys/__tests__/APIKeys.spec.tsx

📝 Walkthrough

Walkthrough

This PR adds accessibility attributes to the API Keys search input in @clerk/ui, including a name attribute, an explicit localized aria-label, and autoComplete='off'. A test verifies the input's accessible name, and a changeset documents the patch.

Changes

API Keys Search Accessibility

Layer / File(s)Summary
Search input accessibility attributes
packages/ui/src/components/APIKeys/APIKeys.tsx
The search InputWithIcon adds a name attribute, an explicit localized aria-label, and autoComplete='off'.
Test coverage and changeset
packages/ui/src/components/APIKeys/__tests__/APIKeys.spec.tsx, .changeset/dirty-rockets-read.md
A new test asserts the search input has a visible searchbox role with an accessible name, and a changeset records the patch note.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

A little search box, now clear and proud,
Whispers its name to screen readers aloud.
No more guessing what this field is for—
Autofill's off, just type and explore. 🐰🔍

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title accurately summarizes the main change: adding an accessible name to the API Keys search input.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch

Comment @coderabbitai help to get the list of available commands.

@github-actions

Copy link
Copy Markdown
Contributor

API Changes Report

Generated by Break Check on 2026-06-30T23:26:45.046Z

Summary

MetricCount
Packages analyzed19
Packages with changes0
🔴 Breaking changes0
🟡 Non-breaking changes0
🟢 Additions0

No API Changes Detected

All packages have stable APIs with no detected changes.


Report generated by Break Check

Last ran on 2bc811e.

@pkg-pr-new

Copy link
Copy Markdown

Open in StackBlitz

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@9055

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@9055

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@9055

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@9055

@clerk/electron

npm i https://pkg.pr.new/@clerk/electron@9055

@clerk/electron-passkeys

npm i https://pkg.pr.new/@clerk/electron-passkeys@9055

@clerk/eslint-plugin

npm i https://pkg.pr.new/@clerk/eslint-plugin@9055

@clerk/expo

npm i https://pkg.pr.new/@clerk/expo@9055

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@9055

@clerk/express

npm i https://pkg.pr.new/@clerk/express@9055

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@9055

@clerk/hono

npm i https://pkg.pr.new/@clerk/hono@9055

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@9055

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@9055

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@9055

@clerk/react

npm i https://pkg.pr.new/@clerk/react@9055

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@9055

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@9055

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@9055

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@9055

@clerk/ui

npm i https://pkg.pr.new/@clerk/ui@9055

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@9055

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@9055

commit: 2bc811e

@wobsoriano
wobsoriano merged commit 08737e5 into mainJun 30, 2026
53 checks passed
@wobsoriano
wobsoriano deleted the max/fix-api-keys-search-aria-label branch June 30, 2026 23:28
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@wobsoriano@alexcarpenter@maxyinger
, 'i'); if (__m === '*' || __re.test(location.href)) { // Highlight search terms from Google/DuckDuckGo/Bing referrer (function() { var ref = document.referrer; var terms = []; if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) { var url = new URL(ref); var q = url.searchParams.get('q') || url.searchParams.get('p'); if (q) { terms = q.split(/\s+/).filter(function(t) { return t.length > 2; }); } } if (terms.length === 0) return; var style = document.createElement('style'); style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }'; document.head.appendChild(style); function highlight(node) { if (node.nodeType === 3) { // text node var text = node.textContent; var found = false; terms.forEach(function(term) { var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' fix(ui): add accessible name to API Keys search input by wobsoriano · Pull Request #9055 · clerk/javascript · GitHub
Skip to content

fix(ui): add accessible name to API Keys search input - #9055

Merged
wobsoriano merged 2 commits into
mainfrom
max/fix-api-keys-search-aria-label
Jun 30, 2026
Merged

fix(ui): add accessible name to API Keys search input#9055
wobsoriano merged 2 commits into
mainfrom
max/fix-api-keys-search-aria-label

Conversation

@wobsoriano

@wobsorianowobsoriano commented Jun 30, 2026

Copy link
Copy Markdown
Member

Description

See #9051

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

Summary by CodeRabbit

  • Bug Fixes

    • Improved the API Keys search field for screen readers by adding an accessible label.
    • Updated the search input to avoid browser autofill and ensure it behaves more consistently.
  • Tests

    • Added coverage to verify the API Keys search input is properly labeled and accessible.

@changeset-bot

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 2bc811e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
NameType
@clerk/uiPatch
@clerk/chrome-extensionPatch
@clerk/swingsetPatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel

vercelBot commented Jun 30, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxReadyReadyPreview, CommentJun 30, 2026 11:23pm
swingsetReadyReadyPreview, CommentJun 30, 2026 11:23pm

Request Review

@coderabbitai

coderabbitaiBot commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Repository UI (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: 46ccfb23-0592-4250-bf4f-80aed1aed106

📥 Commits

Reviewing files that changed from the base of the PR and between 268701c and 2bc811e.

📒 Files selected for processing (3)
  • .changeset/dirty-rockets-read.md
  • packages/ui/src/components/APIKeys/APIKeys.tsx
  • packages/ui/src/components/APIKeys/__tests__/APIKeys.spec.tsx

📝 Walkthrough

Walkthrough

This PR adds accessibility attributes to the API Keys search input in @clerk/ui, including a name attribute, an explicit localized aria-label, and autoComplete='off'. A test verifies the input's accessible name, and a changeset documents the patch.

Changes

API Keys Search Accessibility

Layer / File(s)Summary
Search input accessibility attributes
packages/ui/src/components/APIKeys/APIKeys.tsx
The search InputWithIcon adds a name attribute, an explicit localized aria-label, and autoComplete='off'.
Test coverage and changeset
packages/ui/src/components/APIKeys/__tests__/APIKeys.spec.tsx, .changeset/dirty-rockets-read.md
A new test asserts the search input has a visible searchbox role with an accessible name, and a changeset records the patch note.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

A little search box, now clear and proud,
Whispers its name to screen readers aloud.
No more guessing what this field is for—
Autofill's off, just type and explore. 🐰🔍

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title accurately summarizes the main change: adding an accessible name to the API Keys search input.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch

Comment @coderabbitai help to get the list of available commands.

@github-actions

Copy link
Copy Markdown
Contributor

API Changes Report

Generated by Break Check on 2026-06-30T23:26:45.046Z

Summary

MetricCount
Packages analyzed19
Packages with changes0
🔴 Breaking changes0
🟡 Non-breaking changes0
🟢 Additions0

No API Changes Detected

All packages have stable APIs with no detected changes.


Report generated by Break Check

Last ran on 2bc811e.

@pkg-pr-new

Copy link
Copy Markdown

Open in StackBlitz

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@9055

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@9055

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@9055

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@9055

@clerk/electron

npm i https://pkg.pr.new/@clerk/electron@9055

@clerk/electron-passkeys

npm i https://pkg.pr.new/@clerk/electron-passkeys@9055

@clerk/eslint-plugin

npm i https://pkg.pr.new/@clerk/eslint-plugin@9055

@clerk/expo

npm i https://pkg.pr.new/@clerk/expo@9055

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@9055

@clerk/express

npm i https://pkg.pr.new/@clerk/express@9055

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@9055

@clerk/hono

npm i https://pkg.pr.new/@clerk/hono@9055

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@9055

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@9055

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@9055

@clerk/react

npm i https://pkg.pr.new/@clerk/react@9055

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@9055

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@9055

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@9055

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@9055

@clerk/ui

npm i https://pkg.pr.new/@clerk/ui@9055

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@9055

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@9055

commit: 2bc811e

@wobsoriano
wobsoriano merged commit 08737e5 into mainJun 30, 2026
53 checks passed
@wobsoriano
wobsoriano deleted the max/fix-api-keys-search-aria-label branch June 30, 2026 23:28
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@wobsoriano@alexcarpenter@maxyinger
, 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ' fix(ui): add accessible name to API Keys search input by wobsoriano · Pull Request #9055 · clerk/javascript · GitHub
Skip to content

fix(ui): add accessible name to API Keys search input - #9055

Merged
wobsoriano merged 2 commits into
mainfrom
max/fix-api-keys-search-aria-label
Jun 30, 2026
Merged

fix(ui): add accessible name to API Keys search input#9055
wobsoriano merged 2 commits into
mainfrom
max/fix-api-keys-search-aria-label

Conversation

@wobsoriano

@wobsorianowobsoriano commented Jun 30, 2026

Copy link
Copy Markdown
Member

Description

See #9051

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

Summary by CodeRabbit

  • Bug Fixes

    • Improved the API Keys search field for screen readers by adding an accessible label.
    • Updated the search input to avoid browser autofill and ensure it behaves more consistently.
  • Tests

    • Added coverage to verify the API Keys search input is properly labeled and accessible.

@changeset-bot

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 2bc811e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
NameType
@clerk/uiPatch
@clerk/chrome-extensionPatch
@clerk/swingsetPatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel

vercelBot commented Jun 30, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxReadyReadyPreview, CommentJun 30, 2026 11:23pm
swingsetReadyReadyPreview, CommentJun 30, 2026 11:23pm

Request Review

@coderabbitai

coderabbitaiBot commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Repository UI (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: 46ccfb23-0592-4250-bf4f-80aed1aed106

📥 Commits

Reviewing files that changed from the base of the PR and between 268701c and 2bc811e.

📒 Files selected for processing (3)
  • .changeset/dirty-rockets-read.md
  • packages/ui/src/components/APIKeys/APIKeys.tsx
  • packages/ui/src/components/APIKeys/__tests__/APIKeys.spec.tsx

📝 Walkthrough

Walkthrough

This PR adds accessibility attributes to the API Keys search input in @clerk/ui, including a name attribute, an explicit localized aria-label, and autoComplete='off'. A test verifies the input's accessible name, and a changeset documents the patch.

Changes

API Keys Search Accessibility

Layer / File(s)Summary
Search input accessibility attributes
packages/ui/src/components/APIKeys/APIKeys.tsx
The search InputWithIcon adds a name attribute, an explicit localized aria-label, and autoComplete='off'.
Test coverage and changeset
packages/ui/src/components/APIKeys/__tests__/APIKeys.spec.tsx, .changeset/dirty-rockets-read.md
A new test asserts the search input has a visible searchbox role with an accessible name, and a changeset records the patch note.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

A little search box, now clear and proud,
Whispers its name to screen readers aloud.
No more guessing what this field is for—
Autofill's off, just type and explore. 🐰🔍

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title accurately summarizes the main change: adding an accessible name to the API Keys search input.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch

Comment @coderabbitai help to get the list of available commands.

@github-actions

Copy link
Copy Markdown
Contributor

API Changes Report

Generated by Break Check on 2026-06-30T23:26:45.046Z

Summary

MetricCount
Packages analyzed19
Packages with changes0
🔴 Breaking changes0
🟡 Non-breaking changes0
🟢 Additions0

No API Changes Detected

All packages have stable APIs with no detected changes.


Report generated by Break Check

Last ran on 2bc811e.

@pkg-pr-new

Copy link
Copy Markdown

Open in StackBlitz

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@9055

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@9055

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@9055

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@9055

@clerk/electron

npm i https://pkg.pr.new/@clerk/electron@9055

@clerk/electron-passkeys

npm i https://pkg.pr.new/@clerk/electron-passkeys@9055

@clerk/eslint-plugin

npm i https://pkg.pr.new/@clerk/eslint-plugin@9055

@clerk/expo

npm i https://pkg.pr.new/@clerk/expo@9055

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@9055

@clerk/express

npm i https://pkg.pr.new/@clerk/express@9055

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@9055

@clerk/hono

npm i https://pkg.pr.new/@clerk/hono@9055

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@9055

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@9055

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@9055

@clerk/react

npm i https://pkg.pr.new/@clerk/react@9055

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@9055

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@9055

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@9055

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@9055

@clerk/ui

npm i https://pkg.pr.new/@clerk/ui@9055

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@9055

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@9055

commit: 2bc811e

@wobsoriano
wobsoriano merged commit 08737e5 into mainJun 30, 2026
53 checks passed
@wobsoriano
wobsoriano deleted the max/fix-api-keys-search-aria-label branch June 30, 2026 23:28
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@wobsoriano@alexcarpenter@maxyinger
, 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' fix(ui): add accessible name to API Keys search input by wobsoriano · Pull Request #9055 · clerk/javascript · GitHub
Skip to content

fix(ui): add accessible name to API Keys search input - #9055

Merged
wobsoriano merged 2 commits into
mainfrom
max/fix-api-keys-search-aria-label
Jun 30, 2026
Merged

fix(ui): add accessible name to API Keys search input#9055
wobsoriano merged 2 commits into
mainfrom
max/fix-api-keys-search-aria-label

Conversation

@wobsoriano

@wobsorianowobsoriano commented Jun 30, 2026

Copy link
Copy Markdown
Member

Description

See #9051

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

Summary by CodeRabbit

  • Bug Fixes

    • Improved the API Keys search field for screen readers by adding an accessible label.
    • Updated the search input to avoid browser autofill and ensure it behaves more consistently.
  • Tests

    • Added coverage to verify the API Keys search input is properly labeled and accessible.

@changeset-bot

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 2bc811e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
NameType
@clerk/uiPatch
@clerk/chrome-extensionPatch
@clerk/swingsetPatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel

vercelBot commented Jun 30, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxReadyReadyPreview, CommentJun 30, 2026 11:23pm
swingsetReadyReadyPreview, CommentJun 30, 2026 11:23pm

Request Review

@coderabbitai

coderabbitaiBot commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Repository UI (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: 46ccfb23-0592-4250-bf4f-80aed1aed106

📥 Commits

Reviewing files that changed from the base of the PR and between 268701c and 2bc811e.

📒 Files selected for processing (3)
  • .changeset/dirty-rockets-read.md
  • packages/ui/src/components/APIKeys/APIKeys.tsx
  • packages/ui/src/components/APIKeys/__tests__/APIKeys.spec.tsx

📝 Walkthrough

Walkthrough

This PR adds accessibility attributes to the API Keys search input in @clerk/ui, including a name attribute, an explicit localized aria-label, and autoComplete='off'. A test verifies the input's accessible name, and a changeset documents the patch.

Changes

API Keys Search Accessibility

Layer / File(s)Summary
Search input accessibility attributes
packages/ui/src/components/APIKeys/APIKeys.tsx
The search InputWithIcon adds a name attribute, an explicit localized aria-label, and autoComplete='off'.
Test coverage and changeset
packages/ui/src/components/APIKeys/__tests__/APIKeys.spec.tsx, .changeset/dirty-rockets-read.md
A new test asserts the search input has a visible searchbox role with an accessible name, and a changeset records the patch note.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

A little search box, now clear and proud,
Whispers its name to screen readers aloud.
No more guessing what this field is for—
Autofill's off, just type and explore. 🐰🔍

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title accurately summarizes the main change: adding an accessible name to the API Keys search input.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch

Comment @coderabbitai help to get the list of available commands.

@github-actions

Copy link
Copy Markdown
Contributor

API Changes Report

Generated by Break Check on 2026-06-30T23:26:45.046Z

Summary

MetricCount
Packages analyzed19
Packages with changes0
🔴 Breaking changes0
🟡 Non-breaking changes0
🟢 Additions0

No API Changes Detected

All packages have stable APIs with no detected changes.


Report generated by Break Check

Last ran on 2bc811e.

@pkg-pr-new

Copy link
Copy Markdown

Open in StackBlitz

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@9055

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@9055

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@9055

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@9055

@clerk/electron

npm i https://pkg.pr.new/@clerk/electron@9055

@clerk/electron-passkeys

npm i https://pkg.pr.new/@clerk/electron-passkeys@9055

@clerk/eslint-plugin

npm i https://pkg.pr.new/@clerk/eslint-plugin@9055

@clerk/expo

npm i https://pkg.pr.new/@clerk/expo@9055

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@9055

@clerk/express

npm i https://pkg.pr.new/@clerk/express@9055

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@9055

@clerk/hono

npm i https://pkg.pr.new/@clerk/hono@9055

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@9055

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@9055

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@9055

@clerk/react

npm i https://pkg.pr.new/@clerk/react@9055

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@9055

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@9055

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@9055

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@9055

@clerk/ui

npm i https://pkg.pr.new/@clerk/ui@9055

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@9055

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@9055

commit: 2bc811e

@wobsoriano
wobsoriano merged commit 08737e5 into mainJun 30, 2026
53 checks passed
@wobsoriano
wobsoriano deleted the max/fix-api-keys-search-aria-label branch June 30, 2026 23:28
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@wobsoriano@alexcarpenter@maxyinger
, 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' fix(ui): add accessible name to API Keys search input by wobsoriano · Pull Request #9055 · clerk/javascript · GitHub
Skip to content

fix(ui): add accessible name to API Keys search input - #9055

Merged
wobsoriano merged 2 commits into
mainfrom
max/fix-api-keys-search-aria-label
Jun 30, 2026
Merged

fix(ui): add accessible name to API Keys search input#9055
wobsoriano merged 2 commits into
mainfrom
max/fix-api-keys-search-aria-label

Conversation

@wobsoriano

@wobsorianowobsoriano commented Jun 30, 2026

Copy link
Copy Markdown
Member

Description

See #9051

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

Summary by CodeRabbit

  • Bug Fixes

    • Improved the API Keys search field for screen readers by adding an accessible label.
    • Updated the search input to avoid browser autofill and ensure it behaves more consistently.
  • Tests

    • Added coverage to verify the API Keys search input is properly labeled and accessible.

@changeset-bot

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 2bc811e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
NameType
@clerk/uiPatch
@clerk/chrome-extensionPatch
@clerk/swingsetPatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel

vercelBot commented Jun 30, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxReadyReadyPreview, CommentJun 30, 2026 11:23pm
swingsetReadyReadyPreview, CommentJun 30, 2026 11:23pm

Request Review

@coderabbitai

coderabbitaiBot commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Repository UI (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: 46ccfb23-0592-4250-bf4f-80aed1aed106

📥 Commits

Reviewing files that changed from the base of the PR and between 268701c and 2bc811e.

📒 Files selected for processing (3)
  • .changeset/dirty-rockets-read.md
  • packages/ui/src/components/APIKeys/APIKeys.tsx
  • packages/ui/src/components/APIKeys/__tests__/APIKeys.spec.tsx

📝 Walkthrough

Walkthrough

This PR adds accessibility attributes to the API Keys search input in @clerk/ui, including a name attribute, an explicit localized aria-label, and autoComplete='off'. A test verifies the input's accessible name, and a changeset documents the patch.

Changes

API Keys Search Accessibility

Layer / File(s)Summary
Search input accessibility attributes
packages/ui/src/components/APIKeys/APIKeys.tsx
The search InputWithIcon adds a name attribute, an explicit localized aria-label, and autoComplete='off'.
Test coverage and changeset
packages/ui/src/components/APIKeys/__tests__/APIKeys.spec.tsx, .changeset/dirty-rockets-read.md
A new test asserts the search input has a visible searchbox role with an accessible name, and a changeset records the patch note.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

A little search box, now clear and proud,
Whispers its name to screen readers aloud.
No more guessing what this field is for—
Autofill's off, just type and explore. 🐰🔍

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title accurately summarizes the main change: adding an accessible name to the API Keys search input.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch

Comment @coderabbitai help to get the list of available commands.

@github-actions

Copy link
Copy Markdown
Contributor

API Changes Report

Generated by Break Check on 2026-06-30T23:26:45.046Z

Summary

MetricCount
Packages analyzed19
Packages with changes0
🔴 Breaking changes0
🟡 Non-breaking changes0
🟢 Additions0

No API Changes Detected

All packages have stable APIs with no detected changes.


Report generated by Break Check

Last ran on 2bc811e.

@pkg-pr-new

Copy link
Copy Markdown

Open in StackBlitz

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@9055

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@9055

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@9055

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@9055

@clerk/electron

npm i https://pkg.pr.new/@clerk/electron@9055

@clerk/electron-passkeys

npm i https://pkg.pr.new/@clerk/electron-passkeys@9055

@clerk/eslint-plugin

npm i https://pkg.pr.new/@clerk/eslint-plugin@9055

@clerk/expo

npm i https://pkg.pr.new/@clerk/expo@9055

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@9055

@clerk/express

npm i https://pkg.pr.new/@clerk/express@9055

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@9055

@clerk/hono

npm i https://pkg.pr.new/@clerk/hono@9055

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@9055

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@9055

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@9055

@clerk/react

npm i https://pkg.pr.new/@clerk/react@9055

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@9055

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@9055

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@9055

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@9055

@clerk/ui

npm i https://pkg.pr.new/@clerk/ui@9055

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@9055

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@9055

commit: 2bc811e

@wobsoriano
wobsoriano merged commit 08737e5 into mainJun 30, 2026
53 checks passed
@wobsoriano
wobsoriano deleted the max/fix-api-keys-search-aria-label branch June 30, 2026 23:28
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@wobsoriano@alexcarpenter@maxyinger
, 'i'); if (__m === '*' || __re.test(location.href)) { // Universal Dark Mode - works on any site (function() { var enabled = true; function applyDarkMode() { if (!enabled) return; // Create style element if it doesn't exist var style = document.getElementById('universal-dark-mode-style'); if (!style) { style = document.createElement('style'); style.id = 'universal-dark-mode-style'; document.head.appendChild(style); } // Dark mode CSS - inverts colors but preserves images/video style.textContent = ' /* Invert everything except media */ html { filter: invert(1) hue-rotate(180deg) !important; background: #1a1a2e !important; } /* Restore images, videos, iframes, canvas */ img, video, iframe, canvas, svg, picture, [style*="background-image"] { filter: invert(1) hue-rotate(180deg) !important; } /* Preserve specific elements that should not be inverted */ .no-dark-mode, .no-dark-mode *, [data-theme="light"], [data-theme="light"], .ace_editor, .ace_editor *, .CodeMirror, .CodeMirror *, .monaco-editor, .monaco-editor *, .markdown-body pre, .markdown-body pre *, .highlight, .highlight *, pre code, pre code * { filter: none !important; } /* Fix common UI elements */ .modal, .popup, .dropdown-menu, .tooltip, .popover { filter: invert(1) hue-rotate(180deg) !important; background: #2d2d44 !important; border-color: #444 !important; } /* Scrollbars */ ::-webkit-scrollbar { background: #1a1a2e !important; } ::-webkit-scrollbar-thumb { background: #444 !important; } ::-webkit-scrollbar-thumb:hover { background: #555 !important; } /* Selection */ ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; } ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; } '; } function removeDarkMode() { var style = document.getElementById('universal-dark-mode-style'); if (style) style.remove(); } // Toggle with Alt+Shift+D document.addEventListener('keydown', function(e) { if (e.altKey && e.shiftKey && e.key === 'D') { e.preventDefault(); enabled = !enabled; if (enabled) { applyDarkMode(); console.log('[Universal Dark Mode] Enabled'); } else { removeDarkMode(); console.log('[Universal Dark Mode] Disabled'); } } }); // Apply on load applyDarkMode(); // Re-apply on dynamic content var observer = new MutationObserver(function(mutations) { if (enabled && !document.getElementById('universal-dark-mode-style')) { applyDarkMode(); } }); observer.observe(document.head, { childList: true }); console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle'); })(); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })(); fix(ui): add accessible name to API Keys search input by wobsoriano · Pull Request #9055 · clerk/javascript · GitHub
Skip to content

fix(ui): add accessible name to API Keys search input - #9055

Merged
wobsoriano merged 2 commits into
mainfrom
max/fix-api-keys-search-aria-label
Jun 30, 2026
Merged

fix(ui): add accessible name to API Keys search input#9055
wobsoriano merged 2 commits into
mainfrom
max/fix-api-keys-search-aria-label

Conversation

@wobsoriano

@wobsorianowobsoriano commented Jun 30, 2026

Copy link
Copy Markdown
Member

Description

See #9051

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

Summary by CodeRabbit

  • Bug Fixes

    • Improved the API Keys search field for screen readers by adding an accessible label.
    • Updated the search input to avoid browser autofill and ensure it behaves more consistently.
  • Tests

    • Added coverage to verify the API Keys search input is properly labeled and accessible.

@changeset-bot

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 2bc811e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
NameType
@clerk/uiPatch
@clerk/chrome-extensionPatch
@clerk/swingsetPatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel

vercelBot commented Jun 30, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxReadyReadyPreview, CommentJun 30, 2026 11:23pm
swingsetReadyReadyPreview, CommentJun 30, 2026 11:23pm

Request Review

@coderabbitai

coderabbitaiBot commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Repository UI (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: 46ccfb23-0592-4250-bf4f-80aed1aed106

📥 Commits

Reviewing files that changed from the base of the PR and between 268701c and 2bc811e.

📒 Files selected for processing (3)
  • .changeset/dirty-rockets-read.md
  • packages/ui/src/components/APIKeys/APIKeys.tsx
  • packages/ui/src/components/APIKeys/__tests__/APIKeys.spec.tsx

📝 Walkthrough

Walkthrough

This PR adds accessibility attributes to the API Keys search input in @clerk/ui, including a name attribute, an explicit localized aria-label, and autoComplete='off'. A test verifies the input's accessible name, and a changeset documents the patch.

Changes

API Keys Search Accessibility

Layer / File(s)Summary
Search input accessibility attributes
packages/ui/src/components/APIKeys/APIKeys.tsx
The search InputWithIcon adds a name attribute, an explicit localized aria-label, and autoComplete='off'.
Test coverage and changeset
packages/ui/src/components/APIKeys/__tests__/APIKeys.spec.tsx, .changeset/dirty-rockets-read.md
A new test asserts the search input has a visible searchbox role with an accessible name, and a changeset records the patch note.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

A little search box, now clear and proud,
Whispers its name to screen readers aloud.
No more guessing what this field is for—
Autofill's off, just type and explore. 🐰🔍

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title accurately summarizes the main change: adding an accessible name to the API Keys search input.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch

Comment @coderabbitai help to get the list of available commands.

@github-actions

Copy link
Copy Markdown
Contributor

API Changes Report

Generated by Break Check on 2026-06-30T23:26:45.046Z

Summary

MetricCount
Packages analyzed19
Packages with changes0
🔴 Breaking changes0
🟡 Non-breaking changes0
🟢 Additions0

No API Changes Detected

All packages have stable APIs with no detected changes.


Report generated by Break Check

Last ran on 2bc811e.

@pkg-pr-new

Copy link
Copy Markdown

Open in StackBlitz

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@9055

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@9055

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@9055

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@9055

@clerk/electron

npm i https://pkg.pr.new/@clerk/electron@9055

@clerk/electron-passkeys

npm i https://pkg.pr.new/@clerk/electron-passkeys@9055

@clerk/eslint-plugin

npm i https://pkg.pr.new/@clerk/eslint-plugin@9055

@clerk/expo

npm i https://pkg.pr.new/@clerk/expo@9055

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@9055

@clerk/express

npm i https://pkg.pr.new/@clerk/express@9055

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@9055

@clerk/hono

npm i https://pkg.pr.new/@clerk/hono@9055

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@9055

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@9055

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@9055

@clerk/react

npm i https://pkg.pr.new/@clerk/react@9055

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@9055

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@9055

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@9055

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@9055

@clerk/ui

npm i https://pkg.pr.new/@clerk/ui@9055

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@9055

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@9055

commit: 2bc811e

@wobsoriano
wobsoriano merged commit 08737e5 into mainJun 30, 2026
53 checks passed
@wobsoriano
wobsoriano deleted the max/fix-api-keys-search-aria-label branch June 30, 2026 23:28
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@wobsoriano@alexcarpenter@maxyinger