fix(e2e): update e2e negative value rendering - #9076

Merged
dstaley merged 1 commit into
mainfrom
ds.fix/e2e-negatives
Jul 2, 2026
Merged

fix(e2e): update e2e negative value rendering#9076
dstaley merged 1 commit into
mainfrom
ds.fix/e2e-negatives

Conversation

@dstaley

@dstaleydstaley commented Jul 2, 2026•
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Member

Description

This PR updates an e2e test assertion to match the new way that negative monetary amounts are rendered.

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

Summary by CodeRabbit

  • Bug Fixes
    • Adjusted the displayed discount format during checkout to remove the extra space before the negative price.
  • Chores
    • Added a changeset entry to track this update.

@changeset-bot

changeset-botBot commented Jul 2, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 3ab3ccf

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 0 packages

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel

vercelBot commented Jul 2, 2026•
edited
Loading

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxReadyReadyPreview, CommentJul 2, 2026 6:44pm
swingsetReadyReadyPreview, CommentJul 2, 2026 6:44pm

Request Review

@coderabbitai

coderabbitaiBot commented Jul 2, 2026•
edited
Loading

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Repository UI (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: d6c9b73c-23ff-4a49-9b93-9f4dde8a08a2

📥 Commits

Reviewing files that changed from the base of the PR and between 2f73bdd and 3ab3ccf.

📒 Files selected for processing (2)
  • .changeset/cool-hotels-ring.md
  • integration/tests/pricing-table.test.ts
📝 Walkthrough

Walkthrough

Updated an integration test assertion for the checkout discount display to expect "-$9.99" without a space, replacing the previous "- $9.99" format. Added a changeset file documenting the change.

Changes

Discount Formatting Test Update

Layer / File(s)Summary
Assertion and changeset update
integration/tests/pricing-table.test.ts, .changeset/cool-hotels-ring.md		Updated the expected discount text assertion to remove the space before the dollar amount, and added a changeset entry.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related PRs

  • clerk/javascript#9064: Updated negative-amount formatting (removing the space after the minus) in UI billing line items/tests, matching this PR's discount text change.

Suggested reviewers:mauricioabreu

Poem

A dash and a dollar, so close now they hop,
No space between them, the format won't stop!
A tiny fix hopped through the code with delight,
Changeset in tow, the tests now feel right. 🐇💰

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title clearly matches the main change: updating e2e negative value rendering expectations.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch

Comment @coderabbitai help to get the list of available commands.

@pkg-pr-new

pkg-pr-newBot commented Jul 2, 2026

Copy link
Copy Markdown

Open in StackBlitz

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@9076

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@9076

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@9076

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@9076

@clerk/electron

npm i https://pkg.pr.new/@clerk/electron@9076

@clerk/electron-passkeys

npm i https://pkg.pr.new/@clerk/electron-passkeys@9076

@clerk/eslint-plugin

npm i https://pkg.pr.new/@clerk/eslint-plugin@9076

@clerk/expo

npm i https://pkg.pr.new/@clerk/expo@9076

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@9076

@clerk/express

npm i https://pkg.pr.new/@clerk/express@9076

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@9076

@clerk/hono

npm i https://pkg.pr.new/@clerk/hono@9076

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@9076

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@9076

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@9076

@clerk/react

npm i https://pkg.pr.new/@clerk/react@9076

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@9076

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@9076

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@9076

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@9076

@clerk/ui

npm i https://pkg.pr.new/@clerk/ui@9076

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@9076

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@9076

commit: 3ab3ccf

@dstaley
dstaley merged commit b61c894 into mainJul 2, 2026
51 checks passed
@dstaley
dstaley deleted the ds.fix/e2e-negatives branch July 2, 2026 18:57
@jacekradkojacekradko mentioned this pull request Jul 3, 2026
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wobsorianowobsorianowobsoriano approved these changes

Assignees

No one assigned

Labels

integration

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dstaley@wobsoriano
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
fix(e2e): update e2e negative value rendering - #9076
Merged
dstaley merged 1 commit into
mainfrom 
ds.fix/e2e-negatives
Jul 2, 2026
Merged
fix(e2e): update e2e negative value rendering#9076
dstaley merged 1 commit into
mainfrom 
ds.fix/e2e-negatives
Conversation
@dstaley
@dstaleydstaley
commented
Jul 2, 2026•

edited by coderabbitai
Bot
Loading

Copy link


Copy Markdown

Member
Description
This PR updates an e2e test assertion to match the new way that negative monetary amounts are rendered.
Checklist
  • pnpm test runs as expected.
  • pnpm build runs as expected.
  •  (If applicable) JSDoc comments have been added or updated for any package exports
  •  (If applicable) Documentation has been updated
Type of change
  •  🐛 Bug fix
  •  🌟 New feature
  •  🔨 Breaking change
  •  📖 Refactoring / dependency upgrade / documentation
  •  other:
Summary by CodeRabbit
  • Bug Fixes
    • Adjusted the displayed discount format during checkout to remove the extra space before the negative price.
  • Chores
    • Added a changeset entry to track this update.
@changeset-bot
changeset-botBot
commented
Jul 2, 2026

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: 3ab3ccf
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 0 packages
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@vercel
vercelBot
commented
Jul 2, 2026•

edited

Loading

Copy link


Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.
ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxReadyReadyPreview, CommentJul 2, 2026 6:44pm
swingsetReadyReadyPreview, CommentJul 2, 2026 6:44pm
Request Review
@coderabbitai
coderabbitaiBot
commented
Jul 2, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Review Change Stack
No actionable comments were generated in the recent review. 🎉
ℹ️ Recent review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Repository UI (inherited)
Review profile: CHILL
Plan: Pro Plus
Run ID: d6c9b73c-23ff-4a49-9b93-9f4dde8a08a2
📥 Commits
Reviewing files that changed from the base of the PR and between 2f73bdd and 3ab3ccf.
📒 Files selected for processing (2)
  • .changeset/cool-hotels-ring.md
  • integration/tests/pricing-table.test.ts
📝 Walkthrough
Walkthrough
Updated an integration test assertion for the checkout discount display to expect "-$9.99" without a space, replacing the previous "- $9.99" format. Added a changeset file documenting the change.
Changes
Discount Formatting Test Update
Layer / File(s)Summary
Assertion and changeset update
integration/tests/pricing-table.test.ts, .changeset/cool-hotels-ring.md		Updated the expected discount text assertion to remove the space before the dollar amount, and added a changeset entry.
Estimated code review effort: 1 (Trivial) | ~2 minutes
Possibly related PRs
  • clerk/javascript#9064: Updated negative-amount formatting (removing the space after the minus) in UI billing line items/tests, matching this PR's discount text change.
Suggested reviewers:mauricioabreu
Poem
A dash and a dollar, so close now they hop,

No space between them, the format won't stop!

A tiny fix hopped through the code with delight,

Changeset in tow, the tests now feel right. 🐇💰
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title clearly matches the main change: updating e2e negative value rendering expectations.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  •  Create stacked PR
  •  Commit on current branch
Comment @coderabbitai help to get the list of available commands.
@pkg-pr-new
pkg-pr-newBot
commented
Jul 2, 2026

Copy link


Copy Markdown

Open in StackBlitz
@clerk/astro
npm i https://pkg.pr.new/@clerk/astro@9076

@clerk/backend
npm i https://pkg.pr.new/@clerk/backend@9076

@clerk/chrome-extension
npm i https://pkg.pr.new/@clerk/chrome-extension@9076

@clerk/clerk-js
npm i https://pkg.pr.new/@clerk/clerk-js@9076

@clerk/electron
npm i https://pkg.pr.new/@clerk/electron@9076

@clerk/electron-passkeys
npm i https://pkg.pr.new/@clerk/electron-passkeys@9076

@clerk/eslint-plugin
npm i https://pkg.pr.new/@clerk/eslint-plugin@9076

@clerk/expo
npm i https://pkg.pr.new/@clerk/expo@9076

@clerk/expo-passkeys
npm i https://pkg.pr.new/@clerk/expo-passkeys@9076

@clerk/express
npm i https://pkg.pr.new/@clerk/express@9076

@clerk/fastify
npm i https://pkg.pr.new/@clerk/fastify@9076

@clerk/hono
npm i https://pkg.pr.new/@clerk/hono@9076

@clerk/localizations
npm i https://pkg.pr.new/@clerk/localizations@9076

@clerk/nextjs
npm i https://pkg.pr.new/@clerk/nextjs@9076

@clerk/nuxt
npm i https://pkg.pr.new/@clerk/nuxt@9076

@clerk/react
npm i https://pkg.pr.new/@clerk/react@9076

@clerk/react-router
npm i https://pkg.pr.new/@clerk/react-router@9076

@clerk/shared
npm i https://pkg.pr.new/@clerk/shared@9076

@clerk/tanstack-react-start
npm i https://pkg.pr.new/@clerk/tanstack-react-start@9076

@clerk/testing
npm i https://pkg.pr.new/@clerk/testing@9076

@clerk/ui
npm i https://pkg.pr.new/@clerk/ui@9076

@clerk/upgrade
npm i https://pkg.pr.new/@clerk/upgrade@9076

@clerk/vue
npm i https://pkg.pr.new/@clerk/vue@9076

commit: 3ab3ccf
@dstaley
dstaley
merged commit b61c894
into
mainJul 2, 2026

51 checks passed

@dstaley
dstaley
deleted the

ds.fix/e2e-negatives

branch
July 2, 2026 18:57
@jacekradkojacekradko
mentioned this pull request
Jul 3, 2026
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@wobsorianowobsorianowobsoriano approved these changes

Assignees


No one assigned


Labels

integration

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@dstaley@wobsoriano

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
fix(e2e): update e2e negative value rendering - #9076
Merged
dstaley merged 1 commit into
mainfrom 
ds.fix/e2e-negatives
Jul 2, 2026
Merged
fix(e2e): update e2e negative value rendering#9076
dstaley merged 1 commit into
mainfrom 
ds.fix/e2e-negatives
Conversation
@dstaley
@dstaleydstaley
commented
Jul 2, 2026•

edited by coderabbitai
Bot
Loading

Copy link


Copy Markdown

Member
Description
This PR updates an e2e test assertion to match the new way that negative monetary amounts are rendered.
Checklist
  • pnpm test runs as expected.
  • pnpm build runs as expected.
  •  (If applicable) JSDoc comments have been added or updated for any package exports
  •  (If applicable) Documentation has been updated
Type of change
  •  🐛 Bug fix
  •  🌟 New feature
  •  🔨 Breaking change
  •  📖 Refactoring / dependency upgrade / documentation
  •  other:
Summary by CodeRabbit
  • Bug Fixes
    • Adjusted the displayed discount format during checkout to remove the extra space before the negative price.
  • Chores
    • Added a changeset entry to track this update.
@changeset-bot
changeset-botBot
commented
Jul 2, 2026

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: 3ab3ccf
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 0 packages
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@vercel
vercelBot
commented
Jul 2, 2026•

edited

Loading

Copy link


Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.
ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxReadyReadyPreview, CommentJul 2, 2026 6:44pm
swingsetReadyReadyPreview, CommentJul 2, 2026 6:44pm
Request Review
@coderabbitai
coderabbitaiBot
commented
Jul 2, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Review Change Stack
No actionable comments were generated in the recent review. 🎉
ℹ️ Recent review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Repository UI (inherited)
Review profile: CHILL
Plan: Pro Plus
Run ID: d6c9b73c-23ff-4a49-9b93-9f4dde8a08a2
📥 Commits
Reviewing files that changed from the base of the PR and between 2f73bdd and 3ab3ccf.
📒 Files selected for processing (2)
  • .changeset/cool-hotels-ring.md
  • integration/tests/pricing-table.test.ts
📝 Walkthrough
Walkthrough
Updated an integration test assertion for the checkout discount display to expect "-$9.99" without a space, replacing the previous "- $9.99" format. Added a changeset file documenting the change.
Changes
Discount Formatting Test Update
Layer / File(s)Summary
Assertion and changeset update
integration/tests/pricing-table.test.ts, .changeset/cool-hotels-ring.md		Updated the expected discount text assertion to remove the space before the dollar amount, and added a changeset entry.
Estimated code review effort: 1 (Trivial) | ~2 minutes
Possibly related PRs
  • clerk/javascript#9064: Updated negative-amount formatting (removing the space after the minus) in UI billing line items/tests, matching this PR's discount text change.
Suggested reviewers:mauricioabreu
Poem
A dash and a dollar, so close now they hop,

No space between them, the format won't stop!

A tiny fix hopped through the code with delight,

Changeset in tow, the tests now feel right. 🐇💰
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title clearly matches the main change: updating e2e negative value rendering expectations.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  •  Create stacked PR
  •  Commit on current branch
Comment @coderabbitai help to get the list of available commands.
@pkg-pr-new
pkg-pr-newBot
commented
Jul 2, 2026

Copy link


Copy Markdown

Open in StackBlitz
@clerk/astro
npm i https://pkg.pr.new/@clerk/astro@9076

@clerk/backend
npm i https://pkg.pr.new/@clerk/backend@9076

@clerk/chrome-extension
npm i https://pkg.pr.new/@clerk/chrome-extension@9076

@clerk/clerk-js
npm i https://pkg.pr.new/@clerk/clerk-js@9076

@clerk/electron
npm i https://pkg.pr.new/@clerk/electron@9076

@clerk/electron-passkeys
npm i https://pkg.pr.new/@clerk/electron-passkeys@9076

@clerk/eslint-plugin
npm i https://pkg.pr.new/@clerk/eslint-plugin@9076

@clerk/expo
npm i https://pkg.pr.new/@clerk/expo@9076

@clerk/expo-passkeys
npm i https://pkg.pr.new/@clerk/expo-passkeys@9076

@clerk/express
npm i https://pkg.pr.new/@clerk/express@9076

@clerk/fastify
npm i https://pkg.pr.new/@clerk/fastify@9076

@clerk/hono
npm i https://pkg.pr.new/@clerk/hono@9076

@clerk/localizations
npm i https://pkg.pr.new/@clerk/localizations@9076

@clerk/nextjs
npm i https://pkg.pr.new/@clerk/nextjs@9076

@clerk/nuxt
npm i https://pkg.pr.new/@clerk/nuxt@9076

@clerk/react
npm i https://pkg.pr.new/@clerk/react@9076

@clerk/react-router
npm i https://pkg.pr.new/@clerk/react-router@9076

@clerk/shared
npm i https://pkg.pr.new/@clerk/shared@9076

@clerk/tanstack-react-start
npm i https://pkg.pr.new/@clerk/tanstack-react-start@9076

@clerk/testing
npm i https://pkg.pr.new/@clerk/testing@9076

@clerk/ui
npm i https://pkg.pr.new/@clerk/ui@9076

@clerk/upgrade
npm i https://pkg.pr.new/@clerk/upgrade@9076

@clerk/vue
npm i https://pkg.pr.new/@clerk/vue@9076

commit: 3ab3ccf
@dstaley
dstaley
merged commit b61c894
into
mainJul 2, 2026

51 checks passed

@dstaley
dstaley
deleted the

ds.fix/e2e-negatives

branch
July 2, 2026 18:57
@jacekradkojacekradko
mentioned this pull request
Jul 3, 2026
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@wobsorianowobsorianowobsoriano approved these changes

Assignees


No one assigned


Labels

integration

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@dstaley@wobsoriano

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
fix(e2e): update e2e negative value rendering - #9076
Merged
dstaley merged 1 commit into
mainfrom 
ds.fix/e2e-negatives
Jul 2, 2026
Merged
fix(e2e): update e2e negative value rendering#9076
dstaley merged 1 commit into
mainfrom 
ds.fix/e2e-negatives
Conversation
@dstaley
@dstaleydstaley
commented
Jul 2, 2026•

edited by coderabbitai
Bot
Loading

Copy link


Copy Markdown

Member
Description
This PR updates an e2e test assertion to match the new way that negative monetary amounts are rendered.
Checklist
  • pnpm test runs as expected.
  • pnpm build runs as expected.
  •  (If applicable) JSDoc comments have been added or updated for any package exports
  •  (If applicable) Documentation has been updated
Type of change
  •  🐛 Bug fix
  •  🌟 New feature
  •  🔨 Breaking change
  •  📖 Refactoring / dependency upgrade / documentation
  •  other:
Summary by CodeRabbit
  • Bug Fixes
    • Adjusted the displayed discount format during checkout to remove the extra space before the negative price.
  • Chores
    • Added a changeset entry to track this update.
@changeset-bot
changeset-botBot
commented
Jul 2, 2026

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: 3ab3ccf
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 0 packages
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@vercel
vercelBot
commented
Jul 2, 2026•

edited

Loading

Copy link


Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.
ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxReadyReadyPreview, CommentJul 2, 2026 6:44pm
swingsetReadyReadyPreview, CommentJul 2, 2026 6:44pm
Request Review
@coderabbitai
coderabbitaiBot
commented
Jul 2, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Review Change Stack
No actionable comments were generated in the recent review. 🎉
ℹ️ Recent review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Repository UI (inherited)
Review profile: CHILL
Plan: Pro Plus
Run ID: d6c9b73c-23ff-4a49-9b93-9f4dde8a08a2
📥 Commits
Reviewing files that changed from the base of the PR and between 2f73bdd and 3ab3ccf.
📒 Files selected for processing (2)
  • .changeset/cool-hotels-ring.md
  • integration/tests/pricing-table.test.ts
📝 Walkthrough
Walkthrough
Updated an integration test assertion for the checkout discount display to expect "-$9.99" without a space, replacing the previous "- $9.99" format. Added a changeset file documenting the change.
Changes
Discount Formatting Test Update
Layer / File(s)Summary
Assertion and changeset update
integration/tests/pricing-table.test.ts, .changeset/cool-hotels-ring.md		Updated the expected discount text assertion to remove the space before the dollar amount, and added a changeset entry.
Estimated code review effort: 1 (Trivial) | ~2 minutes
Possibly related PRs
  • clerk/javascript#9064: Updated negative-amount formatting (removing the space after the minus) in UI billing line items/tests, matching this PR's discount text change.
Suggested reviewers:mauricioabreu
Poem
A dash and a dollar, so close now they hop,

No space between them, the format won't stop!

A tiny fix hopped through the code with delight,

Changeset in tow, the tests now feel right. 🐇💰
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title clearly matches the main change: updating e2e negative value rendering expectations.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  •  Create stacked PR
  •  Commit on current branch
Comment @coderabbitai help to get the list of available commands.
@pkg-pr-new
pkg-pr-newBot
commented
Jul 2, 2026

Copy link


Copy Markdown

Open in StackBlitz
@clerk/astro
npm i https://pkg.pr.new/@clerk/astro@9076

@clerk/backend
npm i https://pkg.pr.new/@clerk/backend@9076

@clerk/chrome-extension
npm i https://pkg.pr.new/@clerk/chrome-extension@9076

@clerk/clerk-js
npm i https://pkg.pr.new/@clerk/clerk-js@9076

@clerk/electron
npm i https://pkg.pr.new/@clerk/electron@9076

@clerk/electron-passkeys
npm i https://pkg.pr.new/@clerk/electron-passkeys@9076

@clerk/eslint-plugin
npm i https://pkg.pr.new/@clerk/eslint-plugin@9076

@clerk/expo
npm i https://pkg.pr.new/@clerk/expo@9076

@clerk/expo-passkeys
npm i https://pkg.pr.new/@clerk/expo-passkeys@9076

@clerk/express
npm i https://pkg.pr.new/@clerk/express@9076

@clerk/fastify
npm i https://pkg.pr.new/@clerk/fastify@9076

@clerk/hono
npm i https://pkg.pr.new/@clerk/hono@9076

@clerk/localizations
npm i https://pkg.pr.new/@clerk/localizations@9076

@clerk/nextjs
npm i https://pkg.pr.new/@clerk/nextjs@9076

@clerk/nuxt
npm i https://pkg.pr.new/@clerk/nuxt@9076

@clerk/react
npm i https://pkg.pr.new/@clerk/react@9076

@clerk/react-router
npm i https://pkg.pr.new/@clerk/react-router@9076

@clerk/shared
npm i https://pkg.pr.new/@clerk/shared@9076

@clerk/tanstack-react-start
npm i https://pkg.pr.new/@clerk/tanstack-react-start@9076

@clerk/testing
npm i https://pkg.pr.new/@clerk/testing@9076

@clerk/ui
npm i https://pkg.pr.new/@clerk/ui@9076

@clerk/upgrade
npm i https://pkg.pr.new/@clerk/upgrade@9076

@clerk/vue
npm i https://pkg.pr.new/@clerk/vue@9076

commit: 3ab3ccf
@dstaley
dstaley
merged commit b61c894
into
mainJul 2, 2026

51 checks passed

@dstaley
dstaley
deleted the

ds.fix/e2e-negatives

branch
July 2, 2026 18:57
@jacekradkojacekradko
mentioned this pull request
Jul 3, 2026
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@wobsorianowobsorianowobsoriano approved these changes

Assignees


No one assigned


Labels

integration

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@dstaley@wobsoriano

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
fix(e2e): update e2e negative value rendering - #9076
Merged
dstaley merged 1 commit into
mainfrom 
ds.fix/e2e-negatives
Jul 2, 2026
Merged
fix(e2e): update e2e negative value rendering#9076
dstaley merged 1 commit into
mainfrom 
ds.fix/e2e-negatives
Conversation
@dstaley
@dstaleydstaley
commented
Jul 2, 2026•

edited by coderabbitai
Bot
Loading

Copy link


Copy Markdown

Member
Description
This PR updates an e2e test assertion to match the new way that negative monetary amounts are rendered.
Checklist
  • pnpm test runs as expected.
  • pnpm build runs as expected.
  •  (If applicable) JSDoc comments have been added or updated for any package exports
  •  (If applicable) Documentation has been updated
Type of change
  •  🐛 Bug fix
  •  🌟 New feature
  •  🔨 Breaking change
  •  📖 Refactoring / dependency upgrade / documentation
  •  other:
Summary by CodeRabbit
  • Bug Fixes
    • Adjusted the displayed discount format during checkout to remove the extra space before the negative price.
  • Chores
    • Added a changeset entry to track this update.
@changeset-bot
changeset-botBot
commented
Jul 2, 2026

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: 3ab3ccf
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 0 packages
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@vercel
vercelBot
commented
Jul 2, 2026•

edited

Loading

Copy link


Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.
ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxReadyReadyPreview, CommentJul 2, 2026 6:44pm
swingsetReadyReadyPreview, CommentJul 2, 2026 6:44pm
Request Review
@coderabbitai
coderabbitaiBot
commented
Jul 2, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Review Change Stack
No actionable comments were generated in the recent review. 🎉
ℹ️ Recent review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Repository UI (inherited)
Review profile: CHILL
Plan: Pro Plus
Run ID: d6c9b73c-23ff-4a49-9b93-9f4dde8a08a2
📥 Commits
Reviewing files that changed from the base of the PR and between 2f73bdd and 3ab3ccf.
📒 Files selected for processing (2)
  • .changeset/cool-hotels-ring.md
  • integration/tests/pricing-table.test.ts
📝 Walkthrough
Walkthrough
Updated an integration test assertion for the checkout discount display to expect "-$9.99" without a space, replacing the previous "- $9.99" format. Added a changeset file documenting the change.
Changes
Discount Formatting Test Update
Layer / File(s)Summary
Assertion and changeset update
integration/tests/pricing-table.test.ts, .changeset/cool-hotels-ring.md		Updated the expected discount text assertion to remove the space before the dollar amount, and added a changeset entry.
Estimated code review effort: 1 (Trivial) | ~2 minutes
Possibly related PRs
  • clerk/javascript#9064: Updated negative-amount formatting (removing the space after the minus) in UI billing line items/tests, matching this PR's discount text change.
Suggested reviewers:mauricioabreu
Poem
A dash and a dollar, so close now they hop,

No space between them, the format won't stop!

A tiny fix hopped through the code with delight,

Changeset in tow, the tests now feel right. 🐇💰
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title clearly matches the main change: updating e2e negative value rendering expectations.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  •  Create stacked PR
  •  Commit on current branch
Comment @coderabbitai help to get the list of available commands.
@pkg-pr-new
pkg-pr-newBot
commented
Jul 2, 2026

Copy link


Copy Markdown

Open in StackBlitz
@clerk/astro
npm i https://pkg.pr.new/@clerk/astro@9076

@clerk/backend
npm i https://pkg.pr.new/@clerk/backend@9076

@clerk/chrome-extension
npm i https://pkg.pr.new/@clerk/chrome-extension@9076

@clerk/clerk-js
npm i https://pkg.pr.new/@clerk/clerk-js@9076

@clerk/electron
npm i https://pkg.pr.new/@clerk/electron@9076

@clerk/electron-passkeys
npm i https://pkg.pr.new/@clerk/electron-passkeys@9076

@clerk/eslint-plugin
npm i https://pkg.pr.new/@clerk/eslint-plugin@9076

@clerk/expo
npm i https://pkg.pr.new/@clerk/expo@9076

@clerk/expo-passkeys
npm i https://pkg.pr.new/@clerk/expo-passkeys@9076

@clerk/express
npm i https://pkg.pr.new/@clerk/express@9076

@clerk/fastify
npm i https://pkg.pr.new/@clerk/fastify@9076

@clerk/hono
npm i https://pkg.pr.new/@clerk/hono@9076

@clerk/localizations
npm i https://pkg.pr.new/@clerk/localizations@9076

@clerk/nextjs
npm i https://pkg.pr.new/@clerk/nextjs@9076

@clerk/nuxt
npm i https://pkg.pr.new/@clerk/nuxt@9076

@clerk/react
npm i https://pkg.pr.new/@clerk/react@9076

@clerk/react-router
npm i https://pkg.pr.new/@clerk/react-router@9076

@clerk/shared
npm i https://pkg.pr.new/@clerk/shared@9076

@clerk/tanstack-react-start
npm i https://pkg.pr.new/@clerk/tanstack-react-start@9076

@clerk/testing
npm i https://pkg.pr.new/@clerk/testing@9076

@clerk/ui
npm i https://pkg.pr.new/@clerk/ui@9076

@clerk/upgrade
npm i https://pkg.pr.new/@clerk/upgrade@9076

@clerk/vue
npm i https://pkg.pr.new/@clerk/vue@9076

commit: 3ab3ccf
@dstaley
dstaley
merged commit b61c894
into
mainJul 2, 2026

51 checks passed

@dstaley
dstaley
deleted the

ds.fix/e2e-negatives

branch
July 2, 2026 18:57
@jacekradkojacekradko
mentioned this pull request
Jul 3, 2026
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@wobsorianowobsorianowobsoriano approved these changes

Assignees


No one assigned


Labels

integration

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@dstaley@wobsoriano

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
fix(e2e): update e2e negative value rendering - #9076
Merged
dstaley merged 1 commit into
mainfrom 
ds.fix/e2e-negatives
Jul 2, 2026
Merged
fix(e2e): update e2e negative value rendering#9076
dstaley merged 1 commit into
mainfrom 
ds.fix/e2e-negatives
Conversation
@dstaley
@dstaleydstaley
commented
Jul 2, 2026•

edited by coderabbitai
Bot
Loading

Copy link


Copy Markdown

Member
Description
This PR updates an e2e test assertion to match the new way that negative monetary amounts are rendered.
Checklist
  • pnpm test runs as expected.
  • pnpm build runs as expected.
  •  (If applicable) JSDoc comments have been added or updated for any package exports
  •  (If applicable) Documentation has been updated
Type of change
  •  🐛 Bug fix
  •  🌟 New feature
  •  🔨 Breaking change
  •  📖 Refactoring / dependency upgrade / documentation
  •  other:
Summary by CodeRabbit
  • Bug Fixes
    • Adjusted the displayed discount format during checkout to remove the extra space before the negative price.
  • Chores
    • Added a changeset entry to track this update.
@changeset-bot
changeset-botBot
commented
Jul 2, 2026

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: 3ab3ccf
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 0 packages
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@vercel
vercelBot
commented
Jul 2, 2026•

edited

Loading

Copy link


Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.
ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxReadyReadyPreview, CommentJul 2, 2026 6:44pm
swingsetReadyReadyPreview, CommentJul 2, 2026 6:44pm
Request Review
@coderabbitai
coderabbitaiBot
commented
Jul 2, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Review Change Stack
No actionable comments were generated in the recent review. 🎉
ℹ️ Recent review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Repository UI (inherited)
Review profile: CHILL
Plan: Pro Plus
Run ID: d6c9b73c-23ff-4a49-9b93-9f4dde8a08a2
📥 Commits
Reviewing files that changed from the base of the PR and between 2f73bdd and 3ab3ccf.
📒 Files selected for processing (2)
  • .changeset/cool-hotels-ring.md
  • integration/tests/pricing-table.test.ts
📝 Walkthrough
Walkthrough
Updated an integration test assertion for the checkout discount display to expect "-$9.99" without a space, replacing the previous "- $9.99" format. Added a changeset file documenting the change.
Changes
Discount Formatting Test Update
Layer / File(s)Summary
Assertion and changeset update
integration/tests/pricing-table.test.ts, .changeset/cool-hotels-ring.md		Updated the expected discount text assertion to remove the space before the dollar amount, and added a changeset entry.
Estimated code review effort: 1 (Trivial) | ~2 minutes
Possibly related PRs
  • clerk/javascript#9064: Updated negative-amount formatting (removing the space after the minus) in UI billing line items/tests, matching this PR's discount text change.
Suggested reviewers:mauricioabreu
Poem
A dash and a dollar, so close now they hop,

No space between them, the format won't stop!

A tiny fix hopped through the code with delight,

Changeset in tow, the tests now feel right. 🐇💰
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title clearly matches the main change: updating e2e negative value rendering expectations.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  •  Create stacked PR
  •  Commit on current branch
Comment @coderabbitai help to get the list of available commands.
@pkg-pr-new
pkg-pr-newBot
commented
Jul 2, 2026

Copy link


Copy Markdown

Open in StackBlitz
@clerk/astro
npm i https://pkg.pr.new/@clerk/astro@9076

@clerk/backend
npm i https://pkg.pr.new/@clerk/backend@9076

@clerk/chrome-extension
npm i https://pkg.pr.new/@clerk/chrome-extension@9076

@clerk/clerk-js
npm i https://pkg.pr.new/@clerk/clerk-js@9076

@clerk/electron
npm i https://pkg.pr.new/@clerk/electron@9076

@clerk/electron-passkeys
npm i https://pkg.pr.new/@clerk/electron-passkeys@9076

@clerk/eslint-plugin
npm i https://pkg.pr.new/@clerk/eslint-plugin@9076

@clerk/expo
npm i https://pkg.pr.new/@clerk/expo@9076

@clerk/expo-passkeys
npm i https://pkg.pr.new/@clerk/expo-passkeys@9076

@clerk/express
npm i https://pkg.pr.new/@clerk/express@9076

@clerk/fastify
npm i https://pkg.pr.new/@clerk/fastify@9076

@clerk/hono
npm i https://pkg.pr.new/@clerk/hono@9076

@clerk/localizations
npm i https://pkg.pr.new/@clerk/localizations@9076

@clerk/nextjs
npm i https://pkg.pr.new/@clerk/nextjs@9076

@clerk/nuxt
npm i https://pkg.pr.new/@clerk/nuxt@9076

@clerk/react
npm i https://pkg.pr.new/@clerk/react@9076

@clerk/react-router
npm i https://pkg.pr.new/@clerk/react-router@9076

@clerk/shared
npm i https://pkg.pr.new/@clerk/shared@9076

@clerk/tanstack-react-start
npm i https://pkg.pr.new/@clerk/tanstack-react-start@9076

@clerk/testing
npm i https://pkg.pr.new/@clerk/testing@9076

@clerk/ui
npm i https://pkg.pr.new/@clerk/ui@9076

@clerk/upgrade
npm i https://pkg.pr.new/@clerk/upgrade@9076

@clerk/vue
npm i https://pkg.pr.new/@clerk/vue@9076

commit: 3ab3ccf
@dstaley
dstaley
merged commit b61c894
into
mainJul 2, 2026

51 checks passed

@dstaley
dstaley
deleted the

ds.fix/e2e-negatives

branch
July 2, 2026 18:57
@jacekradkojacekradko
mentioned this pull request
Jul 3, 2026
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@wobsorianowobsorianowobsoriano approved these changes

Assignees


No one assigned


Labels

integration

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@dstaley@wobsoriano

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
fix(e2e): update e2e negative value rendering - #9076
Merged
dstaley merged 1 commit into
mainfrom 
ds.fix/e2e-negatives
Jul 2, 2026
Merged
fix(e2e): update e2e negative value rendering#9076
dstaley merged 1 commit into
mainfrom 
ds.fix/e2e-negatives
Conversation
@dstaley
@dstaleydstaley
commented
Jul 2, 2026•

edited by coderabbitai
Bot
Loading

Copy link


Copy Markdown

Member
Description
This PR updates an e2e test assertion to match the new way that negative monetary amounts are rendered.
Checklist
  • pnpm test runs as expected.
  • pnpm build runs as expected.
  •  (If applicable) JSDoc comments have been added or updated for any package exports
  •  (If applicable) Documentation has been updated
Type of change
  •  🐛 Bug fix
  •  🌟 New feature
  •  🔨 Breaking change
  •  📖 Refactoring / dependency upgrade / documentation
  •  other:
Summary by CodeRabbit
  • Bug Fixes
    • Adjusted the displayed discount format during checkout to remove the extra space before the negative price.
  • Chores
    • Added a changeset entry to track this update.
@changeset-bot
changeset-botBot
commented
Jul 2, 2026

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: 3ab3ccf
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 0 packages
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@vercel
vercelBot
commented
Jul 2, 2026•

edited

Loading

Copy link


Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.
ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxReadyReadyPreview, CommentJul 2, 2026 6:44pm
swingsetReadyReadyPreview, CommentJul 2, 2026 6:44pm
Request Review
@coderabbitai
coderabbitaiBot
commented
Jul 2, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Review Change Stack
No actionable comments were generated in the recent review. 🎉
ℹ️ Recent review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Repository UI (inherited)
Review profile: CHILL
Plan: Pro Plus
Run ID: d6c9b73c-23ff-4a49-9b93-9f4dde8a08a2
📥 Commits
Reviewing files that changed from the base of the PR and between 2f73bdd and 3ab3ccf.
📒 Files selected for processing (2)
  • .changeset/cool-hotels-ring.md
  • integration/tests/pricing-table.test.ts
📝 Walkthrough
Walkthrough
Updated an integration test assertion for the checkout discount display to expect "-$9.99" without a space, replacing the previous "- $9.99" format. Added a changeset file documenting the change.
Changes
Discount Formatting Test Update
Layer / File(s)Summary
Assertion and changeset update
integration/tests/pricing-table.test.ts, .changeset/cool-hotels-ring.md		Updated the expected discount text assertion to remove the space before the dollar amount, and added a changeset entry.
Estimated code review effort: 1 (Trivial) | ~2 minutes
Possibly related PRs
  • clerk/javascript#9064: Updated negative-amount formatting (removing the space after the minus) in UI billing line items/tests, matching this PR's discount text change.
Suggested reviewers:mauricioabreu
Poem
A dash and a dollar, so close now they hop,

No space between them, the format won't stop!

A tiny fix hopped through the code with delight,

Changeset in tow, the tests now feel right. 🐇💰
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title clearly matches the main change: updating e2e negative value rendering expectations.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  •  Create stacked PR
  •  Commit on current branch
Comment @coderabbitai help to get the list of available commands.
@pkg-pr-new
pkg-pr-newBot
commented
Jul 2, 2026

Copy link


Copy Markdown

Open in StackBlitz
@clerk/astro
npm i https://pkg.pr.new/@clerk/astro@9076

@clerk/backend
npm i https://pkg.pr.new/@clerk/backend@9076

@clerk/chrome-extension
npm i https://pkg.pr.new/@clerk/chrome-extension@9076

@clerk/clerk-js
npm i https://pkg.pr.new/@clerk/clerk-js@9076

@clerk/electron
npm i https://pkg.pr.new/@clerk/electron@9076

@clerk/electron-passkeys
npm i https://pkg.pr.new/@clerk/electron-passkeys@9076

@clerk/eslint-plugin
npm i https://pkg.pr.new/@clerk/eslint-plugin@9076

@clerk/expo
npm i https://pkg.pr.new/@clerk/expo@9076

@clerk/expo-passkeys
npm i https://pkg.pr.new/@clerk/expo-passkeys@9076

@clerk/express
npm i https://pkg.pr.new/@clerk/express@9076

@clerk/fastify
npm i https://pkg.pr.new/@clerk/fastify@9076

@clerk/hono
npm i https://pkg.pr.new/@clerk/hono@9076

@clerk/localizations
npm i https://pkg.pr.new/@clerk/localizations@9076

@clerk/nextjs
npm i https://pkg.pr.new/@clerk/nextjs@9076

@clerk/nuxt
npm i https://pkg.pr.new/@clerk/nuxt@9076

@clerk/react
npm i https://pkg.pr.new/@clerk/react@9076

@clerk/react-router
npm i https://pkg.pr.new/@clerk/react-router@9076

@clerk/shared
npm i https://pkg.pr.new/@clerk/shared@9076

@clerk/tanstack-react-start
npm i https://pkg.pr.new/@clerk/tanstack-react-start@9076

@clerk/testing
npm i https://pkg.pr.new/@clerk/testing@9076

@clerk/ui
npm i https://pkg.pr.new/@clerk/ui@9076

@clerk/upgrade
npm i https://pkg.pr.new/@clerk/upgrade@9076

@clerk/vue
npm i https://pkg.pr.new/@clerk/vue@9076

commit: 3ab3ccf
@dstaley
dstaley
merged commit b61c894
into
mainJul 2, 2026

51 checks passed

@dstaley
dstaley
deleted the

ds.fix/e2e-negatives

branch
July 2, 2026 18:57
@jacekradkojacekradko
mentioned this pull request
Jul 3, 2026
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@wobsorianowobsorianowobsoriano approved these changes

Assignees


No one assigned


Labels

integration

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@dstaley@wobsoriano

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
fix(e2e): update e2e negative value rendering - #9076
Merged
dstaley merged 1 commit into
mainfrom 
ds.fix/e2e-negatives
Jul 2, 2026
Merged
fix(e2e): update e2e negative value rendering#9076
dstaley merged 1 commit into
mainfrom 
ds.fix/e2e-negatives
Conversation
@dstaley
@dstaleydstaley
commented
Jul 2, 2026•

edited by coderabbitai
Bot
Loading

Copy link


Copy Markdown

Member
Description
This PR updates an e2e test assertion to match the new way that negative monetary amounts are rendered.
Checklist
  • pnpm test runs as expected.
  • pnpm build runs as expected.
  •  (If applicable) JSDoc comments have been added or updated for any package exports
  •  (If applicable) Documentation has been updated
Type of change
  •  🐛 Bug fix
  •  🌟 New feature
  •  🔨 Breaking change
  •  📖 Refactoring / dependency upgrade / documentation
  •  other:
Summary by CodeRabbit
  • Bug Fixes
    • Adjusted the displayed discount format during checkout to remove the extra space before the negative price.
  • Chores
    • Added a changeset entry to track this update.
@changeset-bot
changeset-botBot
commented
Jul 2, 2026

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: 3ab3ccf
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 0 packages
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@vercel
vercelBot
commented
Jul 2, 2026•

edited

Loading

Copy link


Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.
ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxReadyReadyPreview, CommentJul 2, 2026 6:44pm
swingsetReadyReadyPreview, CommentJul 2, 2026 6:44pm
Request Review
@coderabbitai
coderabbitaiBot
commented
Jul 2, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Review Change Stack
No actionable comments were generated in the recent review. 🎉
ℹ️ Recent review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Repository UI (inherited)
Review profile: CHILL
Plan: Pro Plus
Run ID: d6c9b73c-23ff-4a49-9b93-9f4dde8a08a2
📥 Commits
Reviewing files that changed from the base of the PR and between 2f73bdd and 3ab3ccf.
📒 Files selected for processing (2)
  • .changeset/cool-hotels-ring.md
  • integration/tests/pricing-table.test.ts
📝 Walkthrough
Walkthrough
Updated an integration test assertion for the checkout discount display to expect "-$9.99" without a space, replacing the previous "- $9.99" format. Added a changeset file documenting the change.
Changes
Discount Formatting Test Update
Layer / File(s)Summary
Assertion and changeset update
integration/tests/pricing-table.test.ts, .changeset/cool-hotels-ring.md		Updated the expected discount text assertion to remove the space before the dollar amount, and added a changeset entry.
Estimated code review effort: 1 (Trivial) | ~2 minutes
Possibly related PRs
  • clerk/javascript#9064: Updated negative-amount formatting (removing the space after the minus) in UI billing line items/tests, matching this PR's discount text change.
Suggested reviewers:mauricioabreu
Poem
A dash and a dollar, so close now they hop,

No space between them, the format won't stop!

A tiny fix hopped through the code with delight,

Changeset in tow, the tests now feel right. 🐇💰
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title clearly matches the main change: updating e2e negative value rendering expectations.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  •  Create stacked PR
  •  Commit on current branch
Comment @coderabbitai help to get the list of available commands.
@pkg-pr-new
pkg-pr-newBot
commented
Jul 2, 2026

Copy link


Copy Markdown

Open in StackBlitz
@clerk/astro
npm i https://pkg.pr.new/@clerk/astro@9076

@clerk/backend
npm i https://pkg.pr.new/@clerk/backend@9076

@clerk/chrome-extension
npm i https://pkg.pr.new/@clerk/chrome-extension@9076

@clerk/clerk-js
npm i https://pkg.pr.new/@clerk/clerk-js@9076

@clerk/electron
npm i https://pkg.pr.new/@clerk/electron@9076

@clerk/electron-passkeys
npm i https://pkg.pr.new/@clerk/electron-passkeys@9076

@clerk/eslint-plugin
npm i https://pkg.pr.new/@clerk/eslint-plugin@9076

@clerk/expo
npm i https://pkg.pr.new/@clerk/expo@9076

@clerk/expo-passkeys
npm i https://pkg.pr.new/@clerk/expo-passkeys@9076

@clerk/express
npm i https://pkg.pr.new/@clerk/express@9076

@clerk/fastify
npm i https://pkg.pr.new/@clerk/fastify@9076

@clerk/hono
npm i https://pkg.pr.new/@clerk/hono@9076

@clerk/localizations
npm i https://pkg.pr.new/@clerk/localizations@9076

@clerk/nextjs
npm i https://pkg.pr.new/@clerk/nextjs@9076

@clerk/nuxt
npm i https://pkg.pr.new/@clerk/nuxt@9076

@clerk/react
npm i https://pkg.pr.new/@clerk/react@9076

@clerk/react-router
npm i https://pkg.pr.new/@clerk/react-router@9076

@clerk/shared
npm i https://pkg.pr.new/@clerk/shared@9076

@clerk/tanstack-react-start
npm i https://pkg.pr.new/@clerk/tanstack-react-start@9076

@clerk/testing
npm i https://pkg.pr.new/@clerk/testing@9076

@clerk/ui
npm i https://pkg.pr.new/@clerk/ui@9076

@clerk/upgrade
npm i https://pkg.pr.new/@clerk/upgrade@9076

@clerk/vue
npm i https://pkg.pr.new/@clerk/vue@9076

commit: 3ab3ccf
@dstaley
dstaley
merged commit b61c894
into
mainJul 2, 2026

51 checks passed

@dstaley
dstaley
deleted the

ds.fix/e2e-negatives

branch
July 2, 2026 18:57
@jacekradkojacekradko
mentioned this pull request
Jul 3, 2026
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@wobsorianowobsorianowobsoriano approved these changes

Assignees


No one assigned


Labels

integration

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@dstaley@wobsoriano