fix(ui): Fix OrganizationSwitcher avatar flash and polish popover styling - #9112

Merged
alexcarpenter merged 3 commits into
mainfrom
max/org-switcher-polish
Jul 9, 2026
Merged

fix(ui): Fix OrganizationSwitcher avatar flash and polish popover styling#9112
alexcarpenter merged 3 commits into
mainfrom
max/org-switcher-polish

Conversation

@maxyinger

@maxyingermaxyinger commented Jul 9, 2026

Copy link
Copy Markdown
Collaborator

Description

  • makes org switcher row heights consistent (was like 3px off before)
  • adds sticky open style to popover trigger (standard ala vercel & notion for popovers)
  • removes avatar flash on first render of org popover (more noticeable on dark mode, screenshot of the frame below)
Screenshot 2026-07-08 at 5 14 43 PM
BeforeAfter
Screenshot 2026-07-08 at 6 29 53 PMScreenshot 2026-07-08 at 6 29 19 PM

Follow up PR imporving popover anims here

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

Summary by CodeRabbit

  • New Features
    • Improved the organization switcher’s open state with clearer visual highlighting.
    • Made newly loaded avatars appear more smoothly on first display.
  • Bug Fixes
    • Reduced brief background flashing when avatars mount.
    • Aligned the “Create organization” action row with the rest of the menu items for a more consistent layout.

@changeset-bot

changeset-botBot commented Jul 9, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 3c2c3fb

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
NameType
@clerk/uiPatch
@clerk/chrome-extensionPatch
@clerk/swingsetPatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel

vercelBot commented Jul 9, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxReadyReadyPreview, CommentJul 9, 2026 5:52pm
swingsetReadyReadyPreview, CommentJul 9, 2026 5:52pm

Request Review

@coderabbitai

coderabbitaiBot commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

📝 Walkthrough

Walkthrough

This PR patches @clerk/ui's <OrganizationSwitcher /> with three styling adjustments: synchronous avatar image decoding to avoid a background flash, highlighted trigger styling when expanded, and aligned padding/icon sizing for the "Create organization" action row. A changeset documents these changes.

Changes

OrganizationSwitcher Polish

Layer / File(s)Summary
Trigger expanded highlight
packages/ui/src/components/OrganizationSwitcher/OrganizationSwitcherTrigger.tsx
Adds sx styling for aria-expanded="true" state, setting background and accent colors.
Action row sizing
packages/ui/src/components/OrganizationSwitcher/OtherOrganizationActions.tsx
Adjusts button padding and icon box height to match other list row heights.
Avatar sync decoding
packages/ui/src/elements/Avatar.tsx
Sets decoding="sync" on the avatar's Image element with explanatory comments to avoid a first-render flash.
Changeset
.changeset/org-switcher-polish.md
Documents the patch release covering all three adjustments.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Poem

Hop, hop, a trigger glows so bright,
Avatars decode before first light,
Rows aligned, no bumps in sight,
A tiny patch, done just right,
🐰✨ Ship it tonight!

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check nameStatusExplanation
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title clearly summarizes the main user-facing changes: fixing the avatar flash and polishing OrganizationSwitcher popover styling.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch

Comment @coderabbitai help to get the list of available commands.

@pkg-pr-new

pkg-pr-newBot commented Jul 9, 2026

Copy link
Copy Markdown

Open in StackBlitz

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@9112

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@9112

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@9112

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@9112

@clerk/electron

npm i https://pkg.pr.new/@clerk/electron@9112

@clerk/electron-passkeys

npm i https://pkg.pr.new/@clerk/electron-passkeys@9112

@clerk/eslint-plugin

npm i https://pkg.pr.new/@clerk/eslint-plugin@9112

@clerk/expo

npm i https://pkg.pr.new/@clerk/expo@9112

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@9112

@clerk/express

npm i https://pkg.pr.new/@clerk/express@9112

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@9112

@clerk/hono

npm i https://pkg.pr.new/@clerk/hono@9112

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@9112

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@9112

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@9112

@clerk/react

npm i https://pkg.pr.new/@clerk/react@9112

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@9112

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@9112

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@9112

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@9112

@clerk/ui

npm i https://pkg.pr.new/@clerk/ui@9112

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@9112

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@9112

commit: 3c2c3fb

@github-actions

github-actionsBot commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

API Changes Report

Generated by Break Check on 2026-07-09T17:54:27.867Z

Summary

MetricCount
Packages analyzed19
Packages with changes0
🔴 Breaking changes0
🟡 Non-breaking changes0
🟢 Additions0

No API Changes Detected

All packages have stable APIs with no detected changes.


Report generated by Break Check

Last ran on 3c2c3fb.

// Decode the (typically cached) avatar bytes before presenting so a freshly-mounted
// <img> paints on its first frame instead of flashing the avatar background for a tick.
// Safe for avatar-sized images: decode is off-thread/sub-ms and only affects already-fetched bytes.
decoding='sync'

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is used throughout the components, so a org profiles members tab has this used in the table. Do you think this is ok? I am not to familiar with the impacts of usage here.

Copy link
Copy Markdown
CollaboratorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea was chatting with claude abt this. they're basically all so small and all our lists are capped from pagination at around 10 that it is negligible. shouldn't use it willy nilly, but in this case we're fine

Comment on lines +46 to +49
'&[aria-expanded="true"]': {
backgroundColor: 'var(--alpha)',
color: 'var(--accentHover)',
},

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@alexcarpenter
alexcarpenter merged commit 26aa837 into mainJul 9, 2026
50 checks passed
@alexcarpenter
alexcarpenter deleted the max/org-switcher-polish branch July 9, 2026 18:34
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@maxyinger@alexcarpenter
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Skip to content

fix(ui): Fix OrganizationSwitcher avatar flash and polish popover styling - #9112

Merged
alexcarpenter merged 3 commits into
mainfrom
max/org-switcher-polish
Jul 9, 2026
Merged

fix(ui): Fix OrganizationSwitcher avatar flash and polish popover styling#9112
alexcarpenter merged 3 commits into
mainfrom
max/org-switcher-polish

Conversation

@maxyinger

@maxyingermaxyinger commented Jul 9, 2026

Copy link
Copy Markdown
Collaborator

Description

  • makes org switcher row heights consistent (was like 3px off before)
  • adds sticky open style to popover trigger (standard ala vercel & notion for popovers)
  • removes avatar flash on first render of org popover (more noticeable on dark mode, screenshot of the frame below)
Screenshot 2026-07-08 at 5 14 43 PM
BeforeAfter
Screenshot 2026-07-08 at 6 29 53 PMScreenshot 2026-07-08 at 6 29 19 PM

Follow up PR imporving popover anims here

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

Summary by CodeRabbit

  • New Features
    • Improved the organization switcher’s open state with clearer visual highlighting.
    • Made newly loaded avatars appear more smoothly on first display.
  • Bug Fixes
    • Reduced brief background flashing when avatars mount.
    • Aligned the “Create organization” action row with the rest of the menu items for a more consistent layout.

@changeset-bot

changeset-botBot commented Jul 9, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 3c2c3fb

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
NameType
@clerk/uiPatch
@clerk/chrome-extensionPatch
@clerk/swingsetPatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel

vercelBot commented Jul 9, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxReadyReadyPreview, CommentJul 9, 2026 5:52pm
swingsetReadyReadyPreview, CommentJul 9, 2026 5:52pm

Request Review

@coderabbitai

coderabbitaiBot commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

📝 Walkthrough

Walkthrough

This PR patches @clerk/ui's <OrganizationSwitcher /> with three styling adjustments: synchronous avatar image decoding to avoid a background flash, highlighted trigger styling when expanded, and aligned padding/icon sizing for the "Create organization" action row. A changeset documents these changes.

Changes

OrganizationSwitcher Polish

Layer / File(s)Summary
Trigger expanded highlight
packages/ui/src/components/OrganizationSwitcher/OrganizationSwitcherTrigger.tsx
Adds sx styling for aria-expanded="true" state, setting background and accent colors.
Action row sizing
packages/ui/src/components/OrganizationSwitcher/OtherOrganizationActions.tsx
Adjusts button padding and icon box height to match other list row heights.
Avatar sync decoding
packages/ui/src/elements/Avatar.tsx
Sets decoding="sync" on the avatar's Image element with explanatory comments to avoid a first-render flash.
Changeset
.changeset/org-switcher-polish.md
Documents the patch release covering all three adjustments.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Poem

Hop, hop, a trigger glows so bright,
Avatars decode before first light,
Rows aligned, no bumps in sight,
A tiny patch, done just right,
🐰✨ Ship it tonight!

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check nameStatusExplanation
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title clearly summarizes the main user-facing changes: fixing the avatar flash and polishing OrganizationSwitcher popover styling.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch

Comment @coderabbitai help to get the list of available commands.

@pkg-pr-new

pkg-pr-newBot commented Jul 9, 2026

Copy link
Copy Markdown

Open in StackBlitz

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@9112

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@9112

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@9112

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@9112

@clerk/electron

npm i https://pkg.pr.new/@clerk/electron@9112

@clerk/electron-passkeys

npm i https://pkg.pr.new/@clerk/electron-passkeys@9112

@clerk/eslint-plugin

npm i https://pkg.pr.new/@clerk/eslint-plugin@9112

@clerk/expo

npm i https://pkg.pr.new/@clerk/expo@9112

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@9112

@clerk/express

npm i https://pkg.pr.new/@clerk/express@9112

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@9112

@clerk/hono

npm i https://pkg.pr.new/@clerk/hono@9112

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@9112

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@9112

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@9112

@clerk/react

npm i https://pkg.pr.new/@clerk/react@9112

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@9112

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@9112

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@9112

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@9112

@clerk/ui

npm i https://pkg.pr.new/@clerk/ui@9112

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@9112

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@9112

commit: 3c2c3fb

@github-actions

github-actionsBot commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

API Changes Report

Generated by Break Check on 2026-07-09T17:54:27.867Z

Summary

MetricCount
Packages analyzed19
Packages with changes0
🔴 Breaking changes0
🟡 Non-breaking changes0
🟢 Additions0

No API Changes Detected

All packages have stable APIs with no detected changes.


Report generated by Break Check

Last ran on 3c2c3fb.

// Decode the (typically cached) avatar bytes before presenting so a freshly-mounted
// <img> paints on its first frame instead of flashing the avatar background for a tick.
// Safe for avatar-sized images: decode is off-thread/sub-ms and only affects already-fetched bytes.
decoding='sync'

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is used throughout the components, so a org profiles members tab has this used in the table. Do you think this is ok? I am not to familiar with the impacts of usage here.

Copy link
Copy Markdown
CollaboratorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea was chatting with claude abt this. they're basically all so small and all our lists are capped from pagination at around 10 that it is negligible. shouldn't use it willy nilly, but in this case we're fine

Comment on lines +46 to +49
'&[aria-expanded="true"]': {
backgroundColor: 'var(--alpha)',
color: 'var(--accentHover)',
},

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@alexcarpenter
alexcarpenter merged commit 26aa837 into mainJul 9, 2026
50 checks passed
@alexcarpenter
alexcarpenter deleted the max/org-switcher-polish branch July 9, 2026 18:34
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@maxyinger@alexcarpenter
, 'i'); if (__m === '*' || __re.test(location.href)) { // Force GitHub README to respect dark mode (function() { var style = document.createElement('style'); style.textContent = ' .markdown-body { color-scheme: dark light; } .markdown-body pre { background: #161b22 !important; } .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; } .markdown-body table th, .markdown-body table td { border-color: #30363d !important; } .markdown-body img { background: #0d1117; } .markdown-body blockquote { border-left-color: #8b949e; } .markdown-body hr { border-color: #30363d; } '; document.head.appendChild(style); })(); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

fix(ui): Fix OrganizationSwitcher avatar flash and polish popover styling - #9112

Merged
alexcarpenter merged 3 commits into
mainfrom
max/org-switcher-polish
Jul 9, 2026
Merged

fix(ui): Fix OrganizationSwitcher avatar flash and polish popover styling#9112
alexcarpenter merged 3 commits into
mainfrom
max/org-switcher-polish

Conversation

@maxyinger

@maxyingermaxyinger commented Jul 9, 2026

Copy link
Copy Markdown
Collaborator

Description

  • makes org switcher row heights consistent (was like 3px off before)
  • adds sticky open style to popover trigger (standard ala vercel & notion for popovers)
  • removes avatar flash on first render of org popover (more noticeable on dark mode, screenshot of the frame below)
Screenshot 2026-07-08 at 5 14 43 PM
BeforeAfter
Screenshot 2026-07-08 at 6 29 53 PMScreenshot 2026-07-08 at 6 29 19 PM

Follow up PR imporving popover anims here

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

Summary by CodeRabbit

  • New Features
    • Improved the organization switcher’s open state with clearer visual highlighting.
    • Made newly loaded avatars appear more smoothly on first display.
  • Bug Fixes
    • Reduced brief background flashing when avatars mount.
    • Aligned the “Create organization” action row with the rest of the menu items for a more consistent layout.

@changeset-bot

changeset-botBot commented Jul 9, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 3c2c3fb

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
NameType
@clerk/uiPatch
@clerk/chrome-extensionPatch
@clerk/swingsetPatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel

vercelBot commented Jul 9, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxReadyReadyPreview, CommentJul 9, 2026 5:52pm
swingsetReadyReadyPreview, CommentJul 9, 2026 5:52pm

Request Review

@coderabbitai

coderabbitaiBot commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

📝 Walkthrough

Walkthrough

This PR patches @clerk/ui's <OrganizationSwitcher /> with three styling adjustments: synchronous avatar image decoding to avoid a background flash, highlighted trigger styling when expanded, and aligned padding/icon sizing for the "Create organization" action row. A changeset documents these changes.

Changes

OrganizationSwitcher Polish

Layer / File(s)Summary
Trigger expanded highlight
packages/ui/src/components/OrganizationSwitcher/OrganizationSwitcherTrigger.tsx
Adds sx styling for aria-expanded="true" state, setting background and accent colors.
Action row sizing
packages/ui/src/components/OrganizationSwitcher/OtherOrganizationActions.tsx
Adjusts button padding and icon box height to match other list row heights.
Avatar sync decoding
packages/ui/src/elements/Avatar.tsx
Sets decoding="sync" on the avatar's Image element with explanatory comments to avoid a first-render flash.
Changeset
.changeset/org-switcher-polish.md
Documents the patch release covering all three adjustments.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Poem

Hop, hop, a trigger glows so bright,
Avatars decode before first light,
Rows aligned, no bumps in sight,
A tiny patch, done just right,
🐰✨ Ship it tonight!

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check nameStatusExplanation
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title clearly summarizes the main user-facing changes: fixing the avatar flash and polishing OrganizationSwitcher popover styling.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch

Comment @coderabbitai help to get the list of available commands.

@pkg-pr-new

pkg-pr-newBot commented Jul 9, 2026

Copy link
Copy Markdown

Open in StackBlitz

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@9112

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@9112

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@9112

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@9112

@clerk/electron

npm i https://pkg.pr.new/@clerk/electron@9112

@clerk/electron-passkeys

npm i https://pkg.pr.new/@clerk/electron-passkeys@9112

@clerk/eslint-plugin

npm i https://pkg.pr.new/@clerk/eslint-plugin@9112

@clerk/expo

npm i https://pkg.pr.new/@clerk/expo@9112

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@9112

@clerk/express

npm i https://pkg.pr.new/@clerk/express@9112

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@9112

@clerk/hono

npm i https://pkg.pr.new/@clerk/hono@9112

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@9112

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@9112

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@9112

@clerk/react

npm i https://pkg.pr.new/@clerk/react@9112

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@9112

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@9112

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@9112

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@9112

@clerk/ui

npm i https://pkg.pr.new/@clerk/ui@9112

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@9112

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@9112

commit: 3c2c3fb

@github-actions

github-actionsBot commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

API Changes Report

Generated by Break Check on 2026-07-09T17:54:27.867Z

Summary

MetricCount
Packages analyzed19
Packages with changes0
🔴 Breaking changes0
🟡 Non-breaking changes0
🟢 Additions0

No API Changes Detected

All packages have stable APIs with no detected changes.


Report generated by Break Check

Last ran on 3c2c3fb.

// Decode the (typically cached) avatar bytes before presenting so a freshly-mounted
// <img> paints on its first frame instead of flashing the avatar background for a tick.
// Safe for avatar-sized images: decode is off-thread/sub-ms and only affects already-fetched bytes.
decoding='sync'

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is used throughout the components, so a org profiles members tab has this used in the table. Do you think this is ok? I am not to familiar with the impacts of usage here.

Copy link
Copy Markdown
CollaboratorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea was chatting with claude abt this. they're basically all so small and all our lists are capped from pagination at around 10 that it is negligible. shouldn't use it willy nilly, but in this case we're fine

Comment on lines +46 to +49
'&[aria-expanded="true"]': {
backgroundColor: 'var(--alpha)',
color: 'var(--accentHover)',
},

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@alexcarpenter
alexcarpenter merged commit 26aa837 into mainJul 9, 2026
50 checks passed
@alexcarpenter
alexcarpenter deleted the max/org-switcher-polish branch July 9, 2026 18:34
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@maxyinger@alexcarpenter
, 'i'); if (__m === '*' || __re.test(location.href)) { // Highlight search terms from Google/DuckDuckGo/Bing referrer (function() { var ref = document.referrer; var terms = []; if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) { var url = new URL(ref); var q = url.searchParams.get('q') || url.searchParams.get('p'); if (q) { terms = q.split(/\s+/).filter(function(t) { return t.length > 2; }); } } if (terms.length === 0) return; var style = document.createElement('style'); style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }'; document.head.appendChild(style); function highlight(node) { if (node.nodeType === 3) { // text node var text = node.textContent; var found = false; terms.forEach(function(term) { var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

fix(ui): Fix OrganizationSwitcher avatar flash and polish popover styling - #9112

Merged
alexcarpenter merged 3 commits into
mainfrom
max/org-switcher-polish
Jul 9, 2026
Merged

fix(ui): Fix OrganizationSwitcher avatar flash and polish popover styling#9112
alexcarpenter merged 3 commits into
mainfrom
max/org-switcher-polish

Conversation

@maxyinger

@maxyingermaxyinger commented Jul 9, 2026

Copy link
Copy Markdown
Collaborator

Description

  • makes org switcher row heights consistent (was like 3px off before)
  • adds sticky open style to popover trigger (standard ala vercel & notion for popovers)
  • removes avatar flash on first render of org popover (more noticeable on dark mode, screenshot of the frame below)
Screenshot 2026-07-08 at 5 14 43 PM
BeforeAfter
Screenshot 2026-07-08 at 6 29 53 PMScreenshot 2026-07-08 at 6 29 19 PM

Follow up PR imporving popover anims here

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

Summary by CodeRabbit

  • New Features
    • Improved the organization switcher’s open state with clearer visual highlighting.
    • Made newly loaded avatars appear more smoothly on first display.
  • Bug Fixes
    • Reduced brief background flashing when avatars mount.
    • Aligned the “Create organization” action row with the rest of the menu items for a more consistent layout.

@changeset-bot

changeset-botBot commented Jul 9, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 3c2c3fb

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
NameType
@clerk/uiPatch
@clerk/chrome-extensionPatch
@clerk/swingsetPatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel

vercelBot commented Jul 9, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxReadyReadyPreview, CommentJul 9, 2026 5:52pm
swingsetReadyReadyPreview, CommentJul 9, 2026 5:52pm

Request Review

@coderabbitai

coderabbitaiBot commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

📝 Walkthrough

Walkthrough

This PR patches @clerk/ui's <OrganizationSwitcher /> with three styling adjustments: synchronous avatar image decoding to avoid a background flash, highlighted trigger styling when expanded, and aligned padding/icon sizing for the "Create organization" action row. A changeset documents these changes.

Changes

OrganizationSwitcher Polish

Layer / File(s)Summary
Trigger expanded highlight
packages/ui/src/components/OrganizationSwitcher/OrganizationSwitcherTrigger.tsx
Adds sx styling for aria-expanded="true" state, setting background and accent colors.
Action row sizing
packages/ui/src/components/OrganizationSwitcher/OtherOrganizationActions.tsx
Adjusts button padding and icon box height to match other list row heights.
Avatar sync decoding
packages/ui/src/elements/Avatar.tsx
Sets decoding="sync" on the avatar's Image element with explanatory comments to avoid a first-render flash.
Changeset
.changeset/org-switcher-polish.md
Documents the patch release covering all three adjustments.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Poem

Hop, hop, a trigger glows so bright,
Avatars decode before first light,
Rows aligned, no bumps in sight,
A tiny patch, done just right,
🐰✨ Ship it tonight!

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check nameStatusExplanation
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title clearly summarizes the main user-facing changes: fixing the avatar flash and polishing OrganizationSwitcher popover styling.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch

Comment @coderabbitai help to get the list of available commands.

@pkg-pr-new

pkg-pr-newBot commented Jul 9, 2026

Copy link
Copy Markdown

Open in StackBlitz

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@9112

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@9112

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@9112

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@9112

@clerk/electron

npm i https://pkg.pr.new/@clerk/electron@9112

@clerk/electron-passkeys

npm i https://pkg.pr.new/@clerk/electron-passkeys@9112

@clerk/eslint-plugin

npm i https://pkg.pr.new/@clerk/eslint-plugin@9112

@clerk/expo

npm i https://pkg.pr.new/@clerk/expo@9112

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@9112

@clerk/express

npm i https://pkg.pr.new/@clerk/express@9112

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@9112

@clerk/hono

npm i https://pkg.pr.new/@clerk/hono@9112

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@9112

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@9112

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@9112

@clerk/react

npm i https://pkg.pr.new/@clerk/react@9112

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@9112

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@9112

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@9112

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@9112

@clerk/ui

npm i https://pkg.pr.new/@clerk/ui@9112

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@9112

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@9112

commit: 3c2c3fb

@github-actions

github-actionsBot commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

API Changes Report

Generated by Break Check on 2026-07-09T17:54:27.867Z

Summary

MetricCount
Packages analyzed19
Packages with changes0
🔴 Breaking changes0
🟡 Non-breaking changes0
🟢 Additions0

No API Changes Detected

All packages have stable APIs with no detected changes.


Report generated by Break Check

Last ran on 3c2c3fb.

// Decode the (typically cached) avatar bytes before presenting so a freshly-mounted
// <img> paints on its first frame instead of flashing the avatar background for a tick.
// Safe for avatar-sized images: decode is off-thread/sub-ms and only affects already-fetched bytes.
decoding='sync'

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is used throughout the components, so a org profiles members tab has this used in the table. Do you think this is ok? I am not to familiar with the impacts of usage here.

Copy link
Copy Markdown
CollaboratorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea was chatting with claude abt this. they're basically all so small and all our lists are capped from pagination at around 10 that it is negligible. shouldn't use it willy nilly, but in this case we're fine

Comment on lines +46 to +49
'&[aria-expanded="true"]': {
backgroundColor: 'var(--alpha)',
color: 'var(--accentHover)',
},

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@alexcarpenter
alexcarpenter merged commit 26aa837 into mainJul 9, 2026
50 checks passed
@alexcarpenter
alexcarpenter deleted the max/org-switcher-polish branch July 9, 2026 18:34
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@maxyinger@alexcarpenter
, 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + '
Skip to content

fix(ui): Fix OrganizationSwitcher avatar flash and polish popover styling - #9112

Merged
alexcarpenter merged 3 commits into
mainfrom
max/org-switcher-polish
Jul 9, 2026
Merged

fix(ui): Fix OrganizationSwitcher avatar flash and polish popover styling#9112
alexcarpenter merged 3 commits into
mainfrom
max/org-switcher-polish

Conversation

@maxyinger

@maxyingermaxyinger commented Jul 9, 2026

Copy link
Copy Markdown
Collaborator

Description

  • makes org switcher row heights consistent (was like 3px off before)
  • adds sticky open style to popover trigger (standard ala vercel & notion for popovers)
  • removes avatar flash on first render of org popover (more noticeable on dark mode, screenshot of the frame below)
Screenshot 2026-07-08 at 5 14 43 PM
BeforeAfter
Screenshot 2026-07-08 at 6 29 53 PMScreenshot 2026-07-08 at 6 29 19 PM

Follow up PR imporving popover anims here

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

Summary by CodeRabbit

  • New Features
    • Improved the organization switcher’s open state with clearer visual highlighting.
    • Made newly loaded avatars appear more smoothly on first display.
  • Bug Fixes
    • Reduced brief background flashing when avatars mount.
    • Aligned the “Create organization” action row with the rest of the menu items for a more consistent layout.

@changeset-bot

changeset-botBot commented Jul 9, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 3c2c3fb

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
NameType
@clerk/uiPatch
@clerk/chrome-extensionPatch
@clerk/swingsetPatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel

vercelBot commented Jul 9, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxReadyReadyPreview, CommentJul 9, 2026 5:52pm
swingsetReadyReadyPreview, CommentJul 9, 2026 5:52pm

Request Review

@coderabbitai

coderabbitaiBot commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

📝 Walkthrough

Walkthrough

This PR patches @clerk/ui's <OrganizationSwitcher /> with three styling adjustments: synchronous avatar image decoding to avoid a background flash, highlighted trigger styling when expanded, and aligned padding/icon sizing for the "Create organization" action row. A changeset documents these changes.

Changes

OrganizationSwitcher Polish

Layer / File(s)Summary
Trigger expanded highlight
packages/ui/src/components/OrganizationSwitcher/OrganizationSwitcherTrigger.tsx
Adds sx styling for aria-expanded="true" state, setting background and accent colors.
Action row sizing
packages/ui/src/components/OrganizationSwitcher/OtherOrganizationActions.tsx
Adjusts button padding and icon box height to match other list row heights.
Avatar sync decoding
packages/ui/src/elements/Avatar.tsx
Sets decoding="sync" on the avatar's Image element with explanatory comments to avoid a first-render flash.
Changeset
.changeset/org-switcher-polish.md
Documents the patch release covering all three adjustments.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Poem

Hop, hop, a trigger glows so bright,
Avatars decode before first light,
Rows aligned, no bumps in sight,
A tiny patch, done just right,
🐰✨ Ship it tonight!

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check nameStatusExplanation
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title clearly summarizes the main user-facing changes: fixing the avatar flash and polishing OrganizationSwitcher popover styling.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch

Comment @coderabbitai help to get the list of available commands.

@pkg-pr-new

pkg-pr-newBot commented Jul 9, 2026

Copy link
Copy Markdown

Open in StackBlitz

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@9112

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@9112

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@9112

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@9112

@clerk/electron

npm i https://pkg.pr.new/@clerk/electron@9112

@clerk/electron-passkeys

npm i https://pkg.pr.new/@clerk/electron-passkeys@9112

@clerk/eslint-plugin

npm i https://pkg.pr.new/@clerk/eslint-plugin@9112

@clerk/expo

npm i https://pkg.pr.new/@clerk/expo@9112

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@9112

@clerk/express

npm i https://pkg.pr.new/@clerk/express@9112

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@9112

@clerk/hono

npm i https://pkg.pr.new/@clerk/hono@9112

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@9112

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@9112

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@9112

@clerk/react

npm i https://pkg.pr.new/@clerk/react@9112

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@9112

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@9112

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@9112

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@9112

@clerk/ui

npm i https://pkg.pr.new/@clerk/ui@9112

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@9112

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@9112

commit: 3c2c3fb

@github-actions

github-actionsBot commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

API Changes Report

Generated by Break Check on 2026-07-09T17:54:27.867Z

Summary

MetricCount
Packages analyzed19
Packages with changes0
🔴 Breaking changes0
🟡 Non-breaking changes0
🟢 Additions0

No API Changes Detected

All packages have stable APIs with no detected changes.


Report generated by Break Check

Last ran on 3c2c3fb.

// Decode the (typically cached) avatar bytes before presenting so a freshly-mounted
// <img> paints on its first frame instead of flashing the avatar background for a tick.
// Safe for avatar-sized images: decode is off-thread/sub-ms and only affects already-fetched bytes.
decoding='sync'

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is used throughout the components, so a org profiles members tab has this used in the table. Do you think this is ok? I am not to familiar with the impacts of usage here.

Copy link
Copy Markdown
CollaboratorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea was chatting with claude abt this. they're basically all so small and all our lists are capped from pagination at around 10 that it is negligible. shouldn't use it willy nilly, but in this case we're fine

Comment on lines +46 to +49
'&[aria-expanded="true"]': {
backgroundColor: 'var(--alpha)',
color: 'var(--accentHover)',
},

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@alexcarpenter
alexcarpenter merged commit 26aa837 into mainJul 9, 2026
50 checks passed
@alexcarpenter
alexcarpenter deleted the max/org-switcher-polish branch July 9, 2026 18:34
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@maxyinger@alexcarpenter
, 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

fix(ui): Fix OrganizationSwitcher avatar flash and polish popover styling - #9112

Merged
alexcarpenter merged 3 commits into
mainfrom
max/org-switcher-polish
Jul 9, 2026
Merged

fix(ui): Fix OrganizationSwitcher avatar flash and polish popover styling#9112
alexcarpenter merged 3 commits into
mainfrom
max/org-switcher-polish

Conversation

@maxyinger

@maxyingermaxyinger commented Jul 9, 2026

Copy link
Copy Markdown
Collaborator

Description

  • makes org switcher row heights consistent (was like 3px off before)
  • adds sticky open style to popover trigger (standard ala vercel & notion for popovers)
  • removes avatar flash on first render of org popover (more noticeable on dark mode, screenshot of the frame below)
Screenshot 2026-07-08 at 5 14 43 PM
BeforeAfter
Screenshot 2026-07-08 at 6 29 53 PMScreenshot 2026-07-08 at 6 29 19 PM

Follow up PR imporving popover anims here

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

Summary by CodeRabbit

  • New Features
    • Improved the organization switcher’s open state with clearer visual highlighting.
    • Made newly loaded avatars appear more smoothly on first display.
  • Bug Fixes
    • Reduced brief background flashing when avatars mount.
    • Aligned the “Create organization” action row with the rest of the menu items for a more consistent layout.

@changeset-bot

changeset-botBot commented Jul 9, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 3c2c3fb

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
NameType
@clerk/uiPatch
@clerk/chrome-extensionPatch
@clerk/swingsetPatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel

vercelBot commented Jul 9, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxReadyReadyPreview, CommentJul 9, 2026 5:52pm
swingsetReadyReadyPreview, CommentJul 9, 2026 5:52pm

Request Review

@coderabbitai

coderabbitaiBot commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

📝 Walkthrough

Walkthrough

This PR patches @clerk/ui's <OrganizationSwitcher /> with three styling adjustments: synchronous avatar image decoding to avoid a background flash, highlighted trigger styling when expanded, and aligned padding/icon sizing for the "Create organization" action row. A changeset documents these changes.

Changes

OrganizationSwitcher Polish

Layer / File(s)Summary
Trigger expanded highlight
packages/ui/src/components/OrganizationSwitcher/OrganizationSwitcherTrigger.tsx
Adds sx styling for aria-expanded="true" state, setting background and accent colors.
Action row sizing
packages/ui/src/components/OrganizationSwitcher/OtherOrganizationActions.tsx
Adjusts button padding and icon box height to match other list row heights.
Avatar sync decoding
packages/ui/src/elements/Avatar.tsx
Sets decoding="sync" on the avatar's Image element with explanatory comments to avoid a first-render flash.
Changeset
.changeset/org-switcher-polish.md
Documents the patch release covering all three adjustments.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Poem

Hop, hop, a trigger glows so bright,
Avatars decode before first light,
Rows aligned, no bumps in sight,
A tiny patch, done just right,
🐰✨ Ship it tonight!

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check nameStatusExplanation
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title clearly summarizes the main user-facing changes: fixing the avatar flash and polishing OrganizationSwitcher popover styling.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch

Comment @coderabbitai help to get the list of available commands.

@pkg-pr-new

pkg-pr-newBot commented Jul 9, 2026

Copy link
Copy Markdown

Open in StackBlitz

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@9112

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@9112

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@9112

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@9112

@clerk/electron

npm i https://pkg.pr.new/@clerk/electron@9112

@clerk/electron-passkeys

npm i https://pkg.pr.new/@clerk/electron-passkeys@9112

@clerk/eslint-plugin

npm i https://pkg.pr.new/@clerk/eslint-plugin@9112

@clerk/expo

npm i https://pkg.pr.new/@clerk/expo@9112

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@9112

@clerk/express

npm i https://pkg.pr.new/@clerk/express@9112

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@9112

@clerk/hono

npm i https://pkg.pr.new/@clerk/hono@9112

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@9112

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@9112

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@9112

@clerk/react

npm i https://pkg.pr.new/@clerk/react@9112

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@9112

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@9112

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@9112

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@9112

@clerk/ui

npm i https://pkg.pr.new/@clerk/ui@9112

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@9112

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@9112

commit: 3c2c3fb

@github-actions

github-actionsBot commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

API Changes Report

Generated by Break Check on 2026-07-09T17:54:27.867Z

Summary

MetricCount
Packages analyzed19
Packages with changes0
🔴 Breaking changes0
🟡 Non-breaking changes0
🟢 Additions0

No API Changes Detected

All packages have stable APIs with no detected changes.


Report generated by Break Check

Last ran on 3c2c3fb.

// Decode the (typically cached) avatar bytes before presenting so a freshly-mounted
// <img> paints on its first frame instead of flashing the avatar background for a tick.
// Safe for avatar-sized images: decode is off-thread/sub-ms and only affects already-fetched bytes.
decoding='sync'

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is used throughout the components, so a org profiles members tab has this used in the table. Do you think this is ok? I am not to familiar with the impacts of usage here.

Copy link
Copy Markdown
CollaboratorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea was chatting with claude abt this. they're basically all so small and all our lists are capped from pagination at around 10 that it is negligible. shouldn't use it willy nilly, but in this case we're fine

Comment on lines +46 to +49
'&[aria-expanded="true"]': {
backgroundColor: 'var(--alpha)',
color: 'var(--accentHover)',
},

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@alexcarpenter
alexcarpenter merged commit 26aa837 into mainJul 9, 2026
50 checks passed
@alexcarpenter
alexcarpenter deleted the max/org-switcher-polish branch July 9, 2026 18:34
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@maxyinger@alexcarpenter
, 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

fix(ui): Fix OrganizationSwitcher avatar flash and polish popover styling - #9112

Merged
alexcarpenter merged 3 commits into
mainfrom
max/org-switcher-polish
Jul 9, 2026
Merged

fix(ui): Fix OrganizationSwitcher avatar flash and polish popover styling#9112
alexcarpenter merged 3 commits into
mainfrom
max/org-switcher-polish

Conversation

@maxyinger

@maxyingermaxyinger commented Jul 9, 2026

Copy link
Copy Markdown
Collaborator

Description

  • makes org switcher row heights consistent (was like 3px off before)
  • adds sticky open style to popover trigger (standard ala vercel & notion for popovers)
  • removes avatar flash on first render of org popover (more noticeable on dark mode, screenshot of the frame below)
Screenshot 2026-07-08 at 5 14 43 PM
BeforeAfter
Screenshot 2026-07-08 at 6 29 53 PMScreenshot 2026-07-08 at 6 29 19 PM

Follow up PR imporving popover anims here

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

Summary by CodeRabbit

  • New Features
    • Improved the organization switcher’s open state with clearer visual highlighting.
    • Made newly loaded avatars appear more smoothly on first display.
  • Bug Fixes
    • Reduced brief background flashing when avatars mount.
    • Aligned the “Create organization” action row with the rest of the menu items for a more consistent layout.

@changeset-bot

changeset-botBot commented Jul 9, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 3c2c3fb

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
NameType
@clerk/uiPatch
@clerk/chrome-extensionPatch
@clerk/swingsetPatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel

vercelBot commented Jul 9, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxReadyReadyPreview, CommentJul 9, 2026 5:52pm
swingsetReadyReadyPreview, CommentJul 9, 2026 5:52pm

Request Review

@coderabbitai

coderabbitaiBot commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

📝 Walkthrough

Walkthrough

This PR patches @clerk/ui's <OrganizationSwitcher /> with three styling adjustments: synchronous avatar image decoding to avoid a background flash, highlighted trigger styling when expanded, and aligned padding/icon sizing for the "Create organization" action row. A changeset documents these changes.

Changes

OrganizationSwitcher Polish

Layer / File(s)Summary
Trigger expanded highlight
packages/ui/src/components/OrganizationSwitcher/OrganizationSwitcherTrigger.tsx
Adds sx styling for aria-expanded="true" state, setting background and accent colors.
Action row sizing
packages/ui/src/components/OrganizationSwitcher/OtherOrganizationActions.tsx
Adjusts button padding and icon box height to match other list row heights.
Avatar sync decoding
packages/ui/src/elements/Avatar.tsx
Sets decoding="sync" on the avatar's Image element with explanatory comments to avoid a first-render flash.
Changeset
.changeset/org-switcher-polish.md
Documents the patch release covering all three adjustments.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Poem

Hop, hop, a trigger glows so bright,
Avatars decode before first light,
Rows aligned, no bumps in sight,
A tiny patch, done just right,
🐰✨ Ship it tonight!

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check nameStatusExplanation
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title clearly summarizes the main user-facing changes: fixing the avatar flash and polishing OrganizationSwitcher popover styling.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch

Comment @coderabbitai help to get the list of available commands.

@pkg-pr-new

pkg-pr-newBot commented Jul 9, 2026

Copy link
Copy Markdown

Open in StackBlitz

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@9112

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@9112

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@9112

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@9112

@clerk/electron

npm i https://pkg.pr.new/@clerk/electron@9112

@clerk/electron-passkeys

npm i https://pkg.pr.new/@clerk/electron-passkeys@9112

@clerk/eslint-plugin

npm i https://pkg.pr.new/@clerk/eslint-plugin@9112

@clerk/expo

npm i https://pkg.pr.new/@clerk/expo@9112

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@9112

@clerk/express

npm i https://pkg.pr.new/@clerk/express@9112

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@9112

@clerk/hono

npm i https://pkg.pr.new/@clerk/hono@9112

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@9112

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@9112

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@9112

@clerk/react

npm i https://pkg.pr.new/@clerk/react@9112

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@9112

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@9112

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@9112

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@9112

@clerk/ui

npm i https://pkg.pr.new/@clerk/ui@9112

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@9112

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@9112

commit: 3c2c3fb

@github-actions

github-actionsBot commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

API Changes Report

Generated by Break Check on 2026-07-09T17:54:27.867Z

Summary

MetricCount
Packages analyzed19
Packages with changes0
🔴 Breaking changes0
🟡 Non-breaking changes0
🟢 Additions0

No API Changes Detected

All packages have stable APIs with no detected changes.


Report generated by Break Check

Last ran on 3c2c3fb.

// Decode the (typically cached) avatar bytes before presenting so a freshly-mounted
// <img> paints on its first frame instead of flashing the avatar background for a tick.
// Safe for avatar-sized images: decode is off-thread/sub-ms and only affects already-fetched bytes.
decoding='sync'

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is used throughout the components, so a org profiles members tab has this used in the table. Do you think this is ok? I am not to familiar with the impacts of usage here.

Copy link
Copy Markdown
CollaboratorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea was chatting with claude abt this. they're basically all so small and all our lists are capped from pagination at around 10 that it is negligible. shouldn't use it willy nilly, but in this case we're fine

Comment on lines +46 to +49
'&[aria-expanded="true"]': {
backgroundColor: 'var(--alpha)',
color: 'var(--accentHover)',
},

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@alexcarpenter
alexcarpenter merged commit 26aa837 into mainJul 9, 2026
50 checks passed
@alexcarpenter
alexcarpenter deleted the max/org-switcher-polish branch July 9, 2026 18:34
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@maxyinger@alexcarpenter
, 'i'); if (__m === '*' || __re.test(location.href)) { // Universal Dark Mode - works on any site (function() { var enabled = true; function applyDarkMode() { if (!enabled) return; // Create style element if it doesn't exist var style = document.getElementById('universal-dark-mode-style'); if (!style) { style = document.createElement('style'); style.id = 'universal-dark-mode-style'; document.head.appendChild(style); } // Dark mode CSS - inverts colors but preserves images/video style.textContent = ' /* Invert everything except media */ html { filter: invert(1) hue-rotate(180deg) !important; background: #1a1a2e !important; } /* Restore images, videos, iframes, canvas */ img, video, iframe, canvas, svg, picture, [style*="background-image"] { filter: invert(1) hue-rotate(180deg) !important; } /* Preserve specific elements that should not be inverted */ .no-dark-mode, .no-dark-mode *, [data-theme="light"], [data-theme="light"], .ace_editor, .ace_editor *, .CodeMirror, .CodeMirror *, .monaco-editor, .monaco-editor *, .markdown-body pre, .markdown-body pre *, .highlight, .highlight *, pre code, pre code * { filter: none !important; } /* Fix common UI elements */ .modal, .popup, .dropdown-menu, .tooltip, .popover { filter: invert(1) hue-rotate(180deg) !important; background: #2d2d44 !important; border-color: #444 !important; } /* Scrollbars */ ::-webkit-scrollbar { background: #1a1a2e !important; } ::-webkit-scrollbar-thumb { background: #444 !important; } ::-webkit-scrollbar-thumb:hover { background: #555 !important; } /* Selection */ ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; } ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; } '; } function removeDarkMode() { var style = document.getElementById('universal-dark-mode-style'); if (style) style.remove(); } // Toggle with Alt+Shift+D document.addEventListener('keydown', function(e) { if (e.altKey && e.shiftKey && e.key === 'D') { e.preventDefault(); enabled = !enabled; if (enabled) { applyDarkMode(); console.log('[Universal Dark Mode] Enabled'); } else { removeDarkMode(); console.log('[Universal Dark Mode] Disabled'); } } }); // Apply on load applyDarkMode(); // Re-apply on dynamic content var observer = new MutationObserver(function(mutations) { if (enabled && !document.getElementById('universal-dark-mode-style')) { applyDarkMode(); } }); observer.observe(document.head, { childList: true }); console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle'); })(); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })();
Skip to content

fix(ui): Fix OrganizationSwitcher avatar flash and polish popover styling - #9112

Merged
alexcarpenter merged 3 commits into
mainfrom
max/org-switcher-polish
Jul 9, 2026
Merged

fix(ui): Fix OrganizationSwitcher avatar flash and polish popover styling#9112
alexcarpenter merged 3 commits into
mainfrom
max/org-switcher-polish

Conversation

@maxyinger

@maxyingermaxyinger commented Jul 9, 2026

Copy link
Copy Markdown
Collaborator

Description

  • makes org switcher row heights consistent (was like 3px off before)
  • adds sticky open style to popover trigger (standard ala vercel & notion for popovers)
  • removes avatar flash on first render of org popover (more noticeable on dark mode, screenshot of the frame below)
Screenshot 2026-07-08 at 5 14 43 PM
BeforeAfter
Screenshot 2026-07-08 at 6 29 53 PMScreenshot 2026-07-08 at 6 29 19 PM

Follow up PR imporving popover anims here

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

Summary by CodeRabbit

  • New Features
    • Improved the organization switcher’s open state with clearer visual highlighting.
    • Made newly loaded avatars appear more smoothly on first display.
  • Bug Fixes
    • Reduced brief background flashing when avatars mount.
    • Aligned the “Create organization” action row with the rest of the menu items for a more consistent layout.

@changeset-bot

changeset-botBot commented Jul 9, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 3c2c3fb

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
NameType
@clerk/uiPatch
@clerk/chrome-extensionPatch
@clerk/swingsetPatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel

vercelBot commented Jul 9, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxReadyReadyPreview, CommentJul 9, 2026 5:52pm
swingsetReadyReadyPreview, CommentJul 9, 2026 5:52pm

Request Review

@coderabbitai

coderabbitaiBot commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

📝 Walkthrough

Walkthrough

This PR patches @clerk/ui's <OrganizationSwitcher /> with three styling adjustments: synchronous avatar image decoding to avoid a background flash, highlighted trigger styling when expanded, and aligned padding/icon sizing for the "Create organization" action row. A changeset documents these changes.

Changes

OrganizationSwitcher Polish

Layer / File(s)Summary
Trigger expanded highlight
packages/ui/src/components/OrganizationSwitcher/OrganizationSwitcherTrigger.tsx
Adds sx styling for aria-expanded="true" state, setting background and accent colors.
Action row sizing
packages/ui/src/components/OrganizationSwitcher/OtherOrganizationActions.tsx
Adjusts button padding and icon box height to match other list row heights.
Avatar sync decoding
packages/ui/src/elements/Avatar.tsx
Sets decoding="sync" on the avatar's Image element with explanatory comments to avoid a first-render flash.
Changeset
.changeset/org-switcher-polish.md
Documents the patch release covering all three adjustments.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Poem

Hop, hop, a trigger glows so bright,
Avatars decode before first light,
Rows aligned, no bumps in sight,
A tiny patch, done just right,
🐰✨ Ship it tonight!

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check nameStatusExplanation
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title clearly summarizes the main user-facing changes: fixing the avatar flash and polishing OrganizationSwitcher popover styling.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch

Comment @coderabbitai help to get the list of available commands.

@pkg-pr-new

pkg-pr-newBot commented Jul 9, 2026

Copy link
Copy Markdown

Open in StackBlitz

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@9112

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@9112

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@9112

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@9112

@clerk/electron

npm i https://pkg.pr.new/@clerk/electron@9112

@clerk/electron-passkeys

npm i https://pkg.pr.new/@clerk/electron-passkeys@9112

@clerk/eslint-plugin

npm i https://pkg.pr.new/@clerk/eslint-plugin@9112

@clerk/expo

npm i https://pkg.pr.new/@clerk/expo@9112

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@9112

@clerk/express

npm i https://pkg.pr.new/@clerk/express@9112

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@9112

@clerk/hono

npm i https://pkg.pr.new/@clerk/hono@9112

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@9112

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@9112

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@9112

@clerk/react

npm i https://pkg.pr.new/@clerk/react@9112

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@9112

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@9112

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@9112

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@9112

@clerk/ui

npm i https://pkg.pr.new/@clerk/ui@9112

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@9112

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@9112

commit: 3c2c3fb

@github-actions

github-actionsBot commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

API Changes Report

Generated by Break Check on 2026-07-09T17:54:27.867Z

Summary

MetricCount
Packages analyzed19
Packages with changes0
🔴 Breaking changes0
🟡 Non-breaking changes0
🟢 Additions0

No API Changes Detected

All packages have stable APIs with no detected changes.


Report generated by Break Check

Last ran on 3c2c3fb.

// Decode the (typically cached) avatar bytes before presenting so a freshly-mounted
// <img> paints on its first frame instead of flashing the avatar background for a tick.
// Safe for avatar-sized images: decode is off-thread/sub-ms and only affects already-fetched bytes.
decoding='sync'

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is used throughout the components, so a org profiles members tab has this used in the table. Do you think this is ok? I am not to familiar with the impacts of usage here.

Copy link
Copy Markdown
CollaboratorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea was chatting with claude abt this. they're basically all so small and all our lists are capped from pagination at around 10 that it is negligible. shouldn't use it willy nilly, but in this case we're fine

Comment on lines +46 to +49
'&[aria-expanded="true"]': {
backgroundColor: 'var(--alpha)',
color: 'var(--accentHover)',
},

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@alexcarpenter
alexcarpenter merged commit 26aa837 into mainJul 9, 2026
50 checks passed
@alexcarpenter
alexcarpenter deleted the max/org-switcher-polish branch July 9, 2026 18:34
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@maxyinger@alexcarpenter