[WIP] feat(ui): Origin-aware open/close animations for popover menus and selects#9113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
maxyinger wants to merge 8 commits into from
Closed

[WIP] feat(ui): Origin-aware open/close animations for popover menus and selects #9113

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
ad67576
snappier in. fade out. new new
maxyinger Jul 9, 2026
5857315
animation refinements
maxyinger Jul 9, 2026
3c7be4d
update origin, add select and menu transitions
maxyinger Jul 9, 2026
b9fd172
fix dropped prop and bump ui common cieling
maxyinger Jul 9, 2026
a934f08
fix unit tests
maxyinger Jul 9, 2026
f489835
fix integration tests
maxyinger Jul 9, 2026
bbe573c
cleanup
maxyinger Jul 9, 2026
ab7d076
more integration fixes
maxyinger Jul 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/popover-enter-exit-animations.md
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
---
'@clerk/ui': patch
---

Popover-based surfaces now open and close with an origin-aware scale-and-fade that grows from the edge nearest the trigger, replacing the previous entrance-only slide animation. This covers the `<OrganizationSwitcher />` / `<UserButton />` menus, the overflow (⋯) menus, and selects — menus keep a quick-in / soft-out feel while selects use a quicker exit. Motion is disabled when `appearance.animations` is `false` or the user prefers reduced motion.
14 changes: 14 additions & 0 deletions integration/tests/custom-pages.test.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -405,14 +405,19 @@ testAgainstRunningApps({ withPattern: ['react.vite.withEmailCodes'] })(
const notificationsButton = buttons[2];
const languageButton = buttons[3];

// Clicking an action closes the popover, which now plays an exit animation and stays
// mounted until it finishes — wait for it to fully close before re-opening, otherwise
// the re-open races the still-visible exiting popover.
// Test chat toggle
await chatButton.click();
await u.po.userButton.waitForPopoverClosed();
await u.po.userButton.toggleTrigger();
await u.po.userButton.waitForPopover();
await expect(chatButton).toHaveText('🌐Chat is ON');
await expect(languageButton).toHaveText('🌍Language: EN');

await notificationsButton.click();
await u.po.userButton.waitForPopoverClosed();
await u.po.userButton.toggleTrigger();
await u.po.userButton.waitForPopover();
await expect(notificationsButton).toHaveText('🌐Notifications 🔔 ON');
Expand DownExpand Up@@ -460,14 +465,19 @@ testAgainstRunningApps({ withPattern: ['react.vite.withEmailCodes'] })(
const languageButton = buttons[3];
const manageAccountButton = buttons[4];

// Clicking an action closes the popover, which now plays an exit animation and stays
// mounted until it finishes — wait for it to fully close before re-opening, otherwise
// the re-open races the still-visible exiting popover.
// Test chat toggle
await chatButton.click();
await u.po.userButton.waitForPopoverClosed();
await u.po.userButton.toggleTrigger();
await u.po.userButton.waitForPopover();
await expect(chatButton).toHaveText('🌐Chat is ON');
await expect(languageButton).toHaveText('🌍Language: EN');

await notificationsButton.click();
await u.po.userButton.waitForPopoverClosed();
await u.po.userButton.toggleTrigger();
await u.po.userButton.waitForPopover();
await expect(notificationsButton).toHaveText('🌐Notifications 🔔 ON');
Expand DownExpand Up@@ -508,6 +518,10 @@ testAgainstRunningApps({ withPattern: ['react.vite.withEmailCodes'] })(
await expect(toggleButton.locator('span')).toHaveText('🔔');
await toggleButton.click();

// The action closes the popover with an exit animation that keeps it mounted until it
// finishes; wait for the full close so the re-open doesn't race the exiting popover.
await u.po.userButton.waitForPopoverClosed();

// Re-open menu to see updated items
await u.po.userButton.toggleTrigger();
await u.po.userButton.waitForPopover();
Expand Down
5 changes: 4 additions & 1 deletion packages/testing/src/playwright/unstable/page-objects/apiKeys.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -61,7 +61,10 @@ export const createAPIKeysComponentPageObject = (testArgs: { page: EnhancedPage
return page.getByLabel(/Type "Revoke" to confirm/i).fill(value);
},
clickConfirmRevokeButton: () => {
return page.getByText(/Revoke key/i).click();
// Target the modal's submit button by its descriptor class rather than by text: the menu
// action that opens this modal is also labelled "Revoke key", and it now lingers through an
// exit animation, so a text locator transiently matches both (strict-mode violation).
return page.locator('.cl-apiKeysRevokeModal .cl-apiKeysRevokeModalSubmitButton').click();
},
};
return self;
Expand Down
2 changes: 1 addition & 1 deletion packages/ui/bundlewatch.config.json
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -5,7 +5,7 @@
{ "path": "./dist/ui.shared.browser.js", "maxSize": "40KB" },
{ "path": "./dist/framework*.js", "maxSize": "44KB" },
{ "path": "./dist/vendors*.js", "maxSize": "73KB" },
{ "path": "./dist/ui-common*.js", "maxSize": "130KB" },
{ "path": "./dist/ui-common*.js", "maxSize": "132KB" },
{ "path": "./dist/signin*.js", "maxSize": "17KB" },
{ "path": "./dist/signup*.js", "maxSize": "13KB" },
{ "path": "./dist/userprofile*.js", "maxSize": "16KB" },
Expand Down
2 changes: 0 additions & 2 deletions packages/ui/src/components/OrganizationSwitcher/OrganizationSwitcherPopover.tsx
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -23,7 +23,6 @@ export const OrganizationSwitcherPopover = React.forwardRef<HTMLDivElement, Orga
const { close: unsafeClose, ...rest } = props;
const close = () => unsafeClose?.(false);
const card = useCardState();
const { __experimental_asStandalone } = useOrganizationSwitcherContext();
const { openOrganizationProfile, openCreateOrganization } = useClerk();
const getContainer = usePortalRoot();
const { organization: currentOrg } = useOrganization();
Expand DownExpand Up@@ -138,7 +137,6 @@ export const OrganizationSwitcherPopover = React.forwardRef<HTMLDivElement, Orga
ref={ref}
role='dialog'
aria-label={`${currentOrg?.name} is active`}
shouldEntryAnimate={!__experimental_asStandalone}
{...rest}
>
<PopoverCard.Content elementDescriptor={descriptors.organizationSwitcherPopoverMain}>
Expand Down
2 changes: 1 addition & 1 deletion packages/ui/src/components/OrganizationSwitcher/index.tsx
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -42,7 +42,7 @@ const OrganizationSwitcherWithFloatingTree = withFloatingTree<{ children: ReactE
<Popover
nodeId={nodeId}
context={context}
isOpen={isOpen}
animateExit
order={['content']}
initialFocus={popoverRef}
>
Expand Down
2 changes: 0 additions & 2 deletions packages/ui/src/components/UserButton/UserButtonPopover.tsx
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -19,7 +19,6 @@ export const UserButtonPopover = React.forwardRef<HTMLDivElement, UserButtonPopo
const close = () => unsafeClose?.(false);
const { session } = useSession() as { session: SignedInSessionResource };
const userButtonContext = useUserButtonContext();
const { __experimental_asStandalone } = userButtonContext;
const { authConfig } = useEnvironment();
const { user } = useUser();
const { t } = useLocalizations();
Expand All@@ -40,7 +39,6 @@ export const UserButtonPopover = React.forwardRef<HTMLDivElement, UserButtonPopo
ref={ref}
role='dialog'
aria-label={t(localizationKeys('userButton.label__userButtonPopover'))}
shouldEntryAnimate={!__experimental_asStandalone}
{...rest}
>
<PopoverCard.Content elementDescriptor={descriptors.userButtonPopoverMain}>
Expand Down
2 changes: 1 addition & 1 deletion packages/ui/src/components/UserButton/index.tsx
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -41,7 +41,7 @@ const UserButtonWithFloatingTree = withFloatingTree<{ children: ReactElement }>(
<Popover
nodeId={nodeId}
context={context}
isOpen={isOpen}
animateExit
order={['content']}
initialFocus={popoverRef}
>
Expand Down
31 changes: 16 additions & 15 deletions packages/ui/src/elements/Menu.tsx
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -18,7 +18,6 @@ import { Col, descriptors, SimpleButton } from '../customizables';
import type { UsePopoverReturn } from '../hooks';
import { usePopover } from '../hooks';
import type { PropsOfComponent } from '../styledSystem';
import { animations } from '../styledSystem';
import { colors } from '../utils/colors';
import { withFloatingTree } from './contexts';
import { Popover } from './Popover';
Expand DownExpand Up@@ -124,20 +123,24 @@ type MenuListProps = PropsOfComponent<typeof Col> & {
export const MenuList = (props: MenuListProps) => {
const { sx, asPortal, ...rest } = props;
const { popoverCtx, elementId, getFloatingProps, elementsRef } = useMenuState();
const { floating, styles, isOpen, context, nodeId } = popoverCtx;
const { floating, styles, context, nodeId } = popoverCtx;
const containerRef = useRef<HTMLDivElement | null>(null);
const mergedRef = useMergeRefs([containerRef, floating]);

// `FloatingList` only provides list-navigation context (no DOM), so it wraps the `Popover`
// rather than nesting inside it — that keeps the `Col` as the `Popover`'s direct child, which is
// the element the `animateExit` transition (origin-aware scale + fade) is applied to.
return (
<Popover
context={context}
nodeId={nodeId}
isOpen={isOpen}
portal={asPortal}
order={['content']}
modal={false}
>
<FloatingList elementsRef={elementsRef}>
<FloatingList elementsRef={elementsRef}>
<Popover
context={context}
nodeId={nodeId}
animateExit
initialScale={0.88}
portal={asPortal}
order={['content']}
modal={false}
>
<Col
elementDescriptor={descriptors.menuList}
elementId={descriptors.menuList.setId(elementId)}
Expand All@@ -153,8 +156,6 @@ export const MenuList = (props: MenuListProps) => {
padding: t.space.$0x5,
overflow: 'hidden',
top: `calc(100% + ${t.space.$2})`,
animation: `${animations.dropdownSlideInScaleAndFade} ${t.transitionDuration.$slower} ${t.transitionTiming.$slowBezier}`,
transformOrigin: 'top center',
zIndex: t.zIndices.$dropdown,
gap: t.space.$0x5,
}),
Expand All@@ -164,8 +165,8 @@ export const MenuList = (props: MenuListProps) => {
{...getFloatingProps()}
{...rest}
/>
</FloatingList>
</Popover>
</Popover>
</FloatingList>
);
};

Expand Down
1 change: 1 addition & 0 deletions packages/ui/src/elements/PhoneInput/index.tsx
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -145,6 +145,7 @@ const PhoneInputBase = forwardRef<HTMLInputElement, PhoneInputProps & { feedback
</Text>
</SelectButton>
<SelectOptionList
initialScale={0.96}
sx={{ padding: '0 0' }}
containerSx={theme => ({
gap: 0,
Expand Down
93 changes: 88 additions & 5 deletions packages/ui/src/elements/Popover.tsx
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,38 @@
import { usePortalRoot } from '@clerk/shared/react';
import type { FloatingContext, ReferenceType } from '@floating-ui/react';
import { FloatingFocusManager, FloatingNode, FloatingPortal } from '@floating-ui/react';
import { FloatingFocusManager, FloatingNode, FloatingPortal, useTransitionStyles } from '@floating-ui/react';
import type { PropsWithChildren } from 'react';
import React from 'react';

import { useAppearance } from '../customizables';
import { transitionDurationValues, transitionTiming } from '../foundations/transitions';
import { useDirection, usePrefersReducedMotion } from '../hooks';

type PopoverProps = PropsWithChildren<{
context: FloatingContext<ReferenceType>;
nodeId?: string;
isOpen?: boolean;
initialFocus?: number | React.MutableRefObject<HTMLElement | null>;
/**
* When `true`, the popover animates in on mount with an origin-aware scale + fade and stays
* mounted through a matching fade-out on close, instead of appearing/unmounting instantly.
* Opt-in so other consumers keep their current instant behavior.
* @default false
*/
animateExit?: boolean;
/**
* When `animateExit` is set, exits quickly (`$faster`, matching the entrance) instead of the
* default soft exit (`$slower`). The entrance is always `$faster`.
* @default false
*/
exitFast?: boolean;
/**
* The scale the popover animates from on enter (and collapses to on exit) when `animateExit`
* is set. Scale is proportional, so compact surfaces travel fewer pixels — lower this
* (e.g. `0.92`) to give small popovers like menus a more pronounced motion.
* @default 0.96
*/
initialScale?: number;
/**
* Determines whether outside elements are inert when modal is enabled. This enables pointer modality without a backdrop.
* @default false
Expand All@@ -30,6 +54,27 @@ type PopoverProps = PropsWithChildren<{
root?: HTMLElement | React.MutableRefObject<HTMLElement | null>;
}>;

/**
* Maps a resolved Floating UI placement to a `transform-origin` so the popover grows from the
* point nearest its trigger. The primary axis anchors to the edge opposite the `side`; when the
* placement is aligned to a corner (`-start` / `-end`) the cross axis hugs that corner, otherwise
* it stays centered. Horizontal alignment is mirrored under RTL to match Floating UI's
* direction-aware resolved position.
*/
const getTransformOrigin = (placement: string, direction: 'ltr' | 'rtl'): string => {
const [side, alignment] = placement.split('-');
if (side === 'top' || side === 'bottom') {
const y = side === 'top' ? 'bottom' : 'top';
const start = direction === 'rtl' ? 'right' : 'left';
const end = direction === 'rtl' ? 'left' : 'right';
const x = alignment === 'start' ? start : alignment === 'end' ? end : 'center';
return `${x} ${y}`;
}
const x = side === 'left' ? 'right' : 'left';
const y = alignment === 'start' ? 'top' : alignment === 'end' ? 'bottom' : 'center';
return `${x} ${y}`;
};

export const Popover = (props: PopoverProps) => {
const {
context,
Expand All@@ -39,6 +84,9 @@ export const Popover = (props: PopoverProps) => {
modal = true,
nodeId,
isOpen,
animateExit = false,
exitFast = false,
initialScale = 0.96,
portal = true,
root,
children,
Expand All@@ -47,19 +95,53 @@ export const Popover = (props: PopoverProps) => {
const portalRoot = usePortalRoot();
const effectiveRoot = root ?? portalRoot?.() ?? undefined;

const prefersReducedMotion = usePrefersReducedMotion();
const direction = useDirection();
const { animations: layoutAnimations } = useAppearance().parsedOptions;
const isMotionSafe = !prefersReducedMotion && layoutAnimations === true;
const animate = animateExit && isMotionSafe;
const closeDuration = exitFast ? transitionDurationValues.faster : transitionDurationValues.slower;

// Animate in on mount and out on close with an origin-aware scale + fade. Keeping the element
// mounted through the close transition (via `isMounted`) is what makes the exit animation
// possible. `transformOrigin` is derived from the resolved placement so the popover grows from
// the point nearest its trigger — the aligned corner when present, otherwise the edge center.
const { isMounted, styles: transitionStyles } = useTransitionStyles(context, {
duration: {
open: animate ? transitionDurationValues.faster : 0,
close: animate ? closeDuration : 0,
},
common: ({ placement }) => ({
transformOrigin: getTransformOrigin(placement, direction),
transitionTimingFunction: transitionTiming.swiftOut,
}),
initial: { opacity: animate ? 0 : 1, transform: animate ? `scale(${initialScale})` : 'scale(1)' },
open: { opacity: 1, transform: 'scale(1)' },
close: { opacity: animate ? 0 : 1, transform: animate ? `scale(${initialScale})` : 'scale(1)' },
});

// Non-animating consumers keep the original synchronous `isOpen` unmount.
const shouldRender = animateExit ? isMounted : isOpen;
const content =
animateExit && React.isValidElement<{ style?: React.CSSProperties }>(children)
? React.cloneElement(children, {
style: { ...children.props.style, ...transitionStyles },
})
: children;

if (portal) {
return (
<FloatingNode id={nodeId}>
<FloatingPortal root={effectiveRoot}>
{isOpen && (
{shouldRender && (
<FloatingFocusManager
context={context}
initialFocus={initialFocus}
outsideElementsInert={outsideElementsInert}
order={order}
modal={modal}
>
<>{children}</>
<>{content}</>
</FloatingFocusManager>
)}
</FloatingPortal>
Expand All@@ -69,14 +151,15 @@ export const Popover = (props: PopoverProps) => {

return (
<FloatingNode id={nodeId}>
{isOpen && (
{shouldRender && (
<FloatingFocusManager
context={context}
initialFocus={initialFocus}
outsideElementsInert={outsideElementsInert}
order={order}
modal={modal}
>
<>{children}</>
<>{content}</>
Comment thread
maxyinger marked this conversation as resolved.
</FloatingFocusManager>
)}
</FloatingNode>
Expand Down
Loading
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
[WIP] feat(ui): Origin-aware open/close animations for popover menus and selects#9113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Closed

maxyinger
wants to merge
8
commits into

from

 Closed


[WIP] feat(ui): Origin-aware open/close animations for popover menus and selects
#9113
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


8 commits


Select commit
Hold shift + click to select a range
ad67576

snappier in. fade out. new new


maxyinger Jul 9, 2026
5857315

animation refinements


maxyinger Jul 9, 2026
3c7be4d

update origin, add select and menu transitions


maxyinger Jul 9, 2026
b9fd172

fix dropped prop and bump ui common cieling


maxyinger Jul 9, 2026
a934f08

fix unit tests


maxyinger Jul 9, 2026
f489835

fix integration tests


maxyinger Jul 9, 2026
bbe573c

cleanup


maxyinger Jul 9, 2026
ab7d076

more integration fixes


maxyinger Jul 9, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


5 changes: 5 additions & 0 deletions
.changeset/popover-enter-exit-animations.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
---
'@clerk/ui': patch
---

Popover-based surfaces now open and close with an origin-aware scale-and-fade that grows from the edge nearest the trigger, replacing the previous entrance-only slide animation. This covers the `<OrganizationSwitcher />` / `<UserButton />` menus, the overflow (⋯) menus, and selects — menus keep a quick-in / soft-out feel while selects use a quicker exit. Motion is disabled when `appearance.animations` is `false` or the user prefers reduced motion.

14 changes: 14 additions & 0 deletions
integration/tests/custom-pages.test.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -405,14 +405,19 @@ testAgainstRunningApps({ withPattern: ['react.vite.withEmailCodes'] })(
 const notificationsButton = buttons[2];
 const languageButton = buttons[3];

 // Clicking an action closes the popover, which now plays an exit animation and stays
 // mounted until it finishes — wait for it to fully close before re-opening, otherwise
 // the re-open races the still-visible exiting popover.
 // Test chat toggle
 await chatButton.click();
 await u.po.userButton.waitForPopoverClosed();
 await u.po.userButton.toggleTrigger();
 await u.po.userButton.waitForPopover();
 await expect(chatButton).toHaveText('🌐Chat is ON');
 await expect(languageButton).toHaveText('🌍Language: EN');

 await notificationsButton.click();
 await u.po.userButton.waitForPopoverClosed();
 await u.po.userButton.toggleTrigger();
 await u.po.userButton.waitForPopover();
 await expect(notificationsButton).toHaveText('🌐Notifications 🔔 ON');
Expand DownExpand Up@@ -460,14 +465,19 @@ testAgainstRunningApps({ withPattern: ['react.vite.withEmailCodes'] })(
 const languageButton = buttons[3];
 const manageAccountButton = buttons[4];

 // Clicking an action closes the popover, which now plays an exit animation and stays
 // mounted until it finishes — wait for it to fully close before re-opening, otherwise
 // the re-open races the still-visible exiting popover.
 // Test chat toggle
 await chatButton.click();
 await u.po.userButton.waitForPopoverClosed();
 await u.po.userButton.toggleTrigger();
 await u.po.userButton.waitForPopover();
 await expect(chatButton).toHaveText('🌐Chat is ON');
 await expect(languageButton).toHaveText('🌍Language: EN');

 await notificationsButton.click();
 await u.po.userButton.waitForPopoverClosed();
 await u.po.userButton.toggleTrigger();
 await u.po.userButton.waitForPopover();
 await expect(notificationsButton).toHaveText('🌐Notifications 🔔 ON');
Expand DownExpand Up@@ -508,6 +518,10 @@ testAgainstRunningApps({ withPattern: ['react.vite.withEmailCodes'] })(
 await expect(toggleButton.locator('span')).toHaveText('🔔');
 await toggleButton.click();

 // The action closes the popover with an exit animation that keeps it mounted until it
 // finishes; wait for the full close so the re-open doesn't race the exiting popover.
 await u.po.userButton.waitForPopoverClosed();

 // Re-open menu to see updated items
 await u.po.userButton.toggleTrigger();
 await u.po.userButton.waitForPopover();
Expand Down

5 changes: 4 additions & 1 deletion
packages/testing/src/playwright/unstable/page-objects/apiKeys.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -61,7 +61,10 @@ export const createAPIKeysComponentPageObject = (testArgs: { page: EnhancedPage
 return page.getByLabel(/Type "Revoke" to confirm/i).fill(value);
 },
 clickConfirmRevokeButton: () => {
 return page.getByText(/Revoke key/i).click();
 // Target the modal's submit button by its descriptor class rather than by text: the menu
 // action that opens this modal is also labelled "Revoke key", and it now lingers through an
 // exit animation, so a text locator transiently matches both (strict-mode violation).
 return page.locator('.cl-apiKeysRevokeModal .cl-apiKeysRevokeModalSubmitButton').click();
 },
 };
 return self;
Expand Down

2 changes: 1 addition & 1 deletion
packages/ui/bundlewatch.config.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -5,7 +5,7 @@
 { "path": "./dist/ui.shared.browser.js", "maxSize": "40KB" },
 { "path": "./dist/framework*.js", "maxSize": "44KB" },
 { "path": "./dist/vendors*.js", "maxSize": "73KB" },
 { "path": "./dist/ui-common*.js", "maxSize": "130KB" },
 { "path": "./dist/ui-common*.js", "maxSize": "132KB" },
 { "path": "./dist/signin*.js", "maxSize": "17KB" },
 { "path": "./dist/signup*.js", "maxSize": "13KB" },
 { "path": "./dist/userprofile*.js", "maxSize": "16KB" },
Expand Down

2 changes: 0 additions & 2 deletions
packages/ui/src/components/OrganizationSwitcher/OrganizationSwitcherPopover.tsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -23,7 +23,6 @@ export const OrganizationSwitcherPopover = React.forwardRef<HTMLDivElement, Orga
 const { close: unsafeClose, ...rest } = props;
 const close = () => unsafeClose?.(false);
 const card = useCardState();
 const { __experimental_asStandalone } = useOrganizationSwitcherContext();
 const { openOrganizationProfile, openCreateOrganization } = useClerk();
 const getContainer = usePortalRoot();
 const { organization: currentOrg } = useOrganization();
Expand DownExpand Up@@ -138,7 +137,6 @@ export const OrganizationSwitcherPopover = React.forwardRef<HTMLDivElement, Orga
 ref={ref}
 role='dialog'
 aria-label={`${currentOrg?.name} is active`}
 shouldEntryAnimate={!__experimental_asStandalone}
 {...rest}
 >
 <PopoverCard.Content elementDescriptor={descriptors.organizationSwitcherPopoverMain}>
Expand Down

2 changes: 1 addition & 1 deletion
packages/ui/src/components/OrganizationSwitcher/index.tsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -42,7 +42,7 @@ const OrganizationSwitcherWithFloatingTree = withFloatingTree<{ children: ReactE
 <Popover
 nodeId={nodeId}
 context={context}
isOpen={isOpen}
animateExit
 order={['content']}
 initialFocus={popoverRef}
 >
Expand Down

2 changes: 0 additions & 2 deletions
packages/ui/src/components/UserButton/UserButtonPopover.tsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -19,7 +19,6 @@ export const UserButtonPopover = React.forwardRef<HTMLDivElement, UserButtonPopo
 const close = () => unsafeClose?.(false);
 const { session } = useSession() as { session: SignedInSessionResource };
 const userButtonContext = useUserButtonContext();
 const { __experimental_asStandalone } = userButtonContext;
 const { authConfig } = useEnvironment();
 const { user } = useUser();
 const { t } = useLocalizations();
Expand All@@ -40,7 +39,6 @@ export const UserButtonPopover = React.forwardRef<HTMLDivElement, UserButtonPopo
 ref={ref}
 role='dialog'
 aria-label={t(localizationKeys('userButton.label__userButtonPopover'))}
 shouldEntryAnimate={!__experimental_asStandalone}
 {...rest}
 >
 <PopoverCard.Content elementDescriptor={descriptors.userButtonPopoverMain}>
Expand Down

2 changes: 1 addition & 1 deletion
packages/ui/src/components/UserButton/index.tsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -41,7 +41,7 @@ const UserButtonWithFloatingTree = withFloatingTree<{ children: ReactElement }>(
 <Popover
 nodeId={nodeId}
 context={context}
isOpen={isOpen}
animateExit
 order={['content']}
 initialFocus={popoverRef}
 >
Expand Down

31 changes: 16 additions & 15 deletions
packages/ui/src/elements/Menu.tsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -18,7 +18,6 @@ import { Col, descriptors, SimpleButton } from '../customizables';
import type { UsePopoverReturn } from '../hooks';
import { usePopover } from '../hooks';
import type { PropsOfComponent } from '../styledSystem';
import { animations } from '../styledSystem';
import { colors } from '../utils/colors';
import { withFloatingTree } from './contexts';
import { Popover } from './Popover';
Expand DownExpand Up@@ -124,20 +123,24 @@ type MenuListProps = PropsOfComponent<typeof Col> & {
export const MenuList = (props: MenuListProps) => {
 const { sx, asPortal, ...rest } = props;
 const { popoverCtx, elementId, getFloatingProps, elementsRef } = useMenuState();
 const { floating, styles, isOpen, context, nodeId } = popoverCtx;
 const { floating, styles, context, nodeId } = popoverCtx;
 const containerRef = useRef<HTMLDivElement | null>(null);
 const mergedRef = useMergeRefs([containerRef, floating]);

 // `FloatingList` only provides list-navigation context (no DOM), so it wraps the `Popover`
 // rather than nesting inside it — that keeps the `Col` as the `Popover`'s direct child, which is
 // the element the `animateExit` transition (origin-aware scale + fade) is applied to.
 return (
 <Popover
 context={context}
 nodeId={nodeId}
 isOpen={isOpen}
 portal={asPortal}
 order={['content']}
 modal={false}
 >
 <FloatingList elementsRef={elementsRef}>
 <FloatingList elementsRef={elementsRef}>
 <Popover
 context={context}
 nodeId={nodeId}
 animateExit
 initialScale={0.88}
 portal={asPortal}
 order={['content']}
 modal={false}
 >
 <Col
 elementDescriptor={descriptors.menuList}
 elementId={descriptors.menuList.setId(elementId)}
Expand All@@ -153,8 +156,6 @@ export const MenuList = (props: MenuListProps) => {
 padding: t.space.$0x5,
 overflow: 'hidden',
 top: `calc(100% + ${t.space.$2})`,
 animation: `${animations.dropdownSlideInScaleAndFade} ${t.transitionDuration.$slower} ${t.transitionTiming.$slowBezier}`,
 transformOrigin: 'top center',
 zIndex: t.zIndices.$dropdown,
 gap: t.space.$0x5,
 }),
Expand All@@ -164,8 +165,8 @@ export const MenuList = (props: MenuListProps) => {
 {...getFloatingProps()}
 {...rest}
 />
 </FloatingList>
 </Popover>
 </Popover>
 </FloatingList>
 );
};

Expand Down

1 change: 1 addition & 0 deletions
packages/ui/src/elements/PhoneInput/index.tsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -145,6 +145,7 @@ const PhoneInputBase = forwardRef<HTMLInputElement, PhoneInputProps & { feedback
 </Text>
 </SelectButton>
 <SelectOptionList
 initialScale={0.96}
 sx={{ padding: '0 0' }}
 containerSx={theme => ({
 gap: 0,
Expand Down

93 changes: 88 additions & 5 deletions
packages/ui/src/elements/Popover.tsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,14 +1,38 @@
import { usePortalRoot } from '@clerk/shared/react';
import type { FloatingContext, ReferenceType } from '@floating-ui/react';
import { FloatingFocusManager, FloatingNode, FloatingPortal } from '@floating-ui/react';
import { FloatingFocusManager, FloatingNode, FloatingPortal, useTransitionStyles } from '@floating-ui/react';
import type { PropsWithChildren } from 'react';
import React from 'react';

import { useAppearance } from '../customizables';
import { transitionDurationValues, transitionTiming } from '../foundations/transitions';
import { useDirection, usePrefersReducedMotion } from '../hooks';

type PopoverProps = PropsWithChildren<{
 context: FloatingContext<ReferenceType>;
 nodeId?: string;
 isOpen?: boolean;
 initialFocus?: number | React.MutableRefObject<HTMLElement | null>;
 /**
 * When `true`, the popover animates in on mount with an origin-aware scale + fade and stays
 * mounted through a matching fade-out on close, instead of appearing/unmounting instantly.
 * Opt-in so other consumers keep their current instant behavior.
 * @default false
 */
 animateExit?: boolean;
 /**
 * When `animateExit` is set, exits quickly (`$faster`, matching the entrance) instead of the
 * default soft exit (`$slower`). The entrance is always `$faster`.
 * @default false
 */
 exitFast?: boolean;
 /**
 * The scale the popover animates from on enter (and collapses to on exit) when `animateExit`
 * is set. Scale is proportional, so compact surfaces travel fewer pixels — lower this
 * (e.g. `0.92`) to give small popovers like menus a more pronounced motion.
 * @default 0.96
 */
 initialScale?: number;
 /**
 * Determines whether outside elements are inert when modal is enabled. This enables pointer modality without a backdrop.
 * @default false
Expand All@@ -30,6 +54,27 @@ type PopoverProps = PropsWithChildren<{
 root?: HTMLElement | React.MutableRefObject<HTMLElement | null>;
}>;

/**
 * Maps a resolved Floating UI placement to a `transform-origin` so the popover grows from the
 * point nearest its trigger. The primary axis anchors to the edge opposite the `side`; when the
 * placement is aligned to a corner (`-start` / `-end`) the cross axis hugs that corner, otherwise
 * it stays centered. Horizontal alignment is mirrored under RTL to match Floating UI's
 * direction-aware resolved position.
 */
const getTransformOrigin = (placement: string, direction: 'ltr' | 'rtl'): string => {
 const [side, alignment] = placement.split('-');
 if (side === 'top' || side === 'bottom') {
 const y = side === 'top' ? 'bottom' : 'top';
 const start = direction === 'rtl' ? 'right' : 'left';
 const end = direction === 'rtl' ? 'left' : 'right';
 const x = alignment === 'start' ? start : alignment === 'end' ? end : 'center';
 return `${x} ${y}`;
 }
 const x = side === 'left' ? 'right' : 'left';
 const y = alignment === 'start' ? 'top' : alignment === 'end' ? 'bottom' : 'center';
 return `${x} ${y}`;
};

export const Popover = (props: PopoverProps) => {
 const {
 context,
Expand All@@ -39,6 +84,9 @@ export const Popover = (props: PopoverProps) => {
 modal = true,
 nodeId,
 isOpen,
 animateExit = false,
 exitFast = false,
 initialScale = 0.96,
 portal = true,
 root,
 children,
Expand All@@ -47,19 +95,53 @@ export const Popover = (props: PopoverProps) => {
 const portalRoot = usePortalRoot();
 const effectiveRoot = root ?? portalRoot?.() ?? undefined;

 const prefersReducedMotion = usePrefersReducedMotion();
 const direction = useDirection();
 const { animations: layoutAnimations } = useAppearance().parsedOptions;
 const isMotionSafe = !prefersReducedMotion && layoutAnimations === true;
 const animate = animateExit && isMotionSafe;
 const closeDuration = exitFast ? transitionDurationValues.faster : transitionDurationValues.slower;

 // Animate in on mount and out on close with an origin-aware scale + fade. Keeping the element
 // mounted through the close transition (via `isMounted`) is what makes the exit animation
 // possible. `transformOrigin` is derived from the resolved placement so the popover grows from
 // the point nearest its trigger — the aligned corner when present, otherwise the edge center.
 const { isMounted, styles: transitionStyles } = useTransitionStyles(context, {
 duration: {
 open: animate ? transitionDurationValues.faster : 0,
 close: animate ? closeDuration : 0,
 },
 common: ({ placement }) => ({
 transformOrigin: getTransformOrigin(placement, direction),
 transitionTimingFunction: transitionTiming.swiftOut,
 }),
 initial: { opacity: animate ? 0 : 1, transform: animate ? `scale(${initialScale})` : 'scale(1)' },
 open: { opacity: 1, transform: 'scale(1)' },
 close: { opacity: animate ? 0 : 1, transform: animate ? `scale(${initialScale})` : 'scale(1)' },
 });

 // Non-animating consumers keep the original synchronous `isOpen` unmount.
 const shouldRender = animateExit ? isMounted : isOpen;
 const content =
 animateExit && React.isValidElement<{ style?: React.CSSProperties }>(children)
 ? React.cloneElement(children, {
 style: { ...children.props.style, ...transitionStyles },
 })
 : children;

 if (portal) {
 return (
 <FloatingNode id={nodeId}>
 <FloatingPortal root={effectiveRoot}>
 {isOpen && (
 {shouldRender && (
 <FloatingFocusManager
 context={context}
 initialFocus={initialFocus}
 outsideElementsInert={outsideElementsInert}
 order={order}
 modal={modal}
 >
 <>{children}</>
 <>{content}</>
 </FloatingFocusManager>
 )}
 </FloatingPortal>
Expand All@@ -69,14 +151,15 @@ export const Popover = (props: PopoverProps) => {

 return (
 <FloatingNode id={nodeId}>
 {isOpen && (
 {shouldRender && (
 <FloatingFocusManager
 context={context}
 initialFocus={initialFocus}
 outsideElementsInert={outsideElementsInert}
 order={order}
 modal={modal}
 >
 <>{children}</>
 <>{content}</>
Comment thread
maxyinger marked this conversation as resolved.

 </FloatingFocusManager>
 )}
 </FloatingNode>
Expand Down
Loading
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
[WIP] feat(ui): Origin-aware open/close animations for popover menus and selects#9113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Closed

maxyinger
wants to merge
8
commits into

from

 Closed


[WIP] feat(ui): Origin-aware open/close animations for popover menus and selects
#9113
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


8 commits


Select commit
Hold shift + click to select a range
ad67576

snappier in. fade out. new new


maxyinger Jul 9, 2026
5857315

animation refinements


maxyinger Jul 9, 2026
3c7be4d

update origin, add select and menu transitions


maxyinger Jul 9, 2026
b9fd172

fix dropped prop and bump ui common cieling


maxyinger Jul 9, 2026
a934f08

fix unit tests


maxyinger Jul 9, 2026
f489835

fix integration tests


maxyinger Jul 9, 2026
bbe573c

cleanup


maxyinger Jul 9, 2026
ab7d076

more integration fixes


maxyinger Jul 9, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


5 changes: 5 additions & 0 deletions
.changeset/popover-enter-exit-animations.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
---
'@clerk/ui': patch
---

Popover-based surfaces now open and close with an origin-aware scale-and-fade that grows from the edge nearest the trigger, replacing the previous entrance-only slide animation. This covers the `<OrganizationSwitcher />` / `<UserButton />` menus, the overflow (⋯) menus, and selects — menus keep a quick-in / soft-out feel while selects use a quicker exit. Motion is disabled when `appearance.animations` is `false` or the user prefers reduced motion.

14 changes: 14 additions & 0 deletions
integration/tests/custom-pages.test.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -405,14 +405,19 @@ testAgainstRunningApps({ withPattern: ['react.vite.withEmailCodes'] })(
 const notificationsButton = buttons[2];
 const languageButton = buttons[3];

 // Clicking an action closes the popover, which now plays an exit animation and stays
 // mounted until it finishes — wait for it to fully close before re-opening, otherwise
 // the re-open races the still-visible exiting popover.
 // Test chat toggle
 await chatButton.click();
 await u.po.userButton.waitForPopoverClosed();
 await u.po.userButton.toggleTrigger();
 await u.po.userButton.waitForPopover();
 await expect(chatButton).toHaveText('🌐Chat is ON');
 await expect(languageButton).toHaveText('🌍Language: EN');

 await notificationsButton.click();
 await u.po.userButton.waitForPopoverClosed();
 await u.po.userButton.toggleTrigger();
 await u.po.userButton.waitForPopover();
 await expect(notificationsButton).toHaveText('🌐Notifications 🔔 ON');
Expand DownExpand Up@@ -460,14 +465,19 @@ testAgainstRunningApps({ withPattern: ['react.vite.withEmailCodes'] })(
 const languageButton = buttons[3];
 const manageAccountButton = buttons[4];

 // Clicking an action closes the popover, which now plays an exit animation and stays
 // mounted until it finishes — wait for it to fully close before re-opening, otherwise
 // the re-open races the still-visible exiting popover.
 // Test chat toggle
 await chatButton.click();
 await u.po.userButton.waitForPopoverClosed();
 await u.po.userButton.toggleTrigger();
 await u.po.userButton.waitForPopover();
 await expect(chatButton).toHaveText('🌐Chat is ON');
 await expect(languageButton).toHaveText('🌍Language: EN');

 await notificationsButton.click();
 await u.po.userButton.waitForPopoverClosed();
 await u.po.userButton.toggleTrigger();
 await u.po.userButton.waitForPopover();
 await expect(notificationsButton).toHaveText('🌐Notifications 🔔 ON');
Expand DownExpand Up@@ -508,6 +518,10 @@ testAgainstRunningApps({ withPattern: ['react.vite.withEmailCodes'] })(
 await expect(toggleButton.locator('span')).toHaveText('🔔');
 await toggleButton.click();

 // The action closes the popover with an exit animation that keeps it mounted until it
 // finishes; wait for the full close so the re-open doesn't race the exiting popover.
 await u.po.userButton.waitForPopoverClosed();

 // Re-open menu to see updated items
 await u.po.userButton.toggleTrigger();
 await u.po.userButton.waitForPopover();
Expand Down

5 changes: 4 additions & 1 deletion
packages/testing/src/playwright/unstable/page-objects/apiKeys.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -61,7 +61,10 @@ export const createAPIKeysComponentPageObject = (testArgs: { page: EnhancedPage
 return page.getByLabel(/Type "Revoke" to confirm/i).fill(value);
 },
 clickConfirmRevokeButton: () => {
 return page.getByText(/Revoke key/i).click();
 // Target the modal's submit button by its descriptor class rather than by text: the menu
 // action that opens this modal is also labelled "Revoke key", and it now lingers through an
 // exit animation, so a text locator transiently matches both (strict-mode violation).
 return page.locator('.cl-apiKeysRevokeModal .cl-apiKeysRevokeModalSubmitButton').click();
 },
 };
 return self;
Expand Down

2 changes: 1 addition & 1 deletion
packages/ui/bundlewatch.config.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -5,7 +5,7 @@
 { "path": "./dist/ui.shared.browser.js", "maxSize": "40KB" },
 { "path": "./dist/framework*.js", "maxSize": "44KB" },
 { "path": "./dist/vendors*.js", "maxSize": "73KB" },
 { "path": "./dist/ui-common*.js", "maxSize": "130KB" },
 { "path": "./dist/ui-common*.js", "maxSize": "132KB" },
 { "path": "./dist/signin*.js", "maxSize": "17KB" },
 { "path": "./dist/signup*.js", "maxSize": "13KB" },
 { "path": "./dist/userprofile*.js", "maxSize": "16KB" },
Expand Down

2 changes: 0 additions & 2 deletions
packages/ui/src/components/OrganizationSwitcher/OrganizationSwitcherPopover.tsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -23,7 +23,6 @@ export const OrganizationSwitcherPopover = React.forwardRef<HTMLDivElement, Orga
 const { close: unsafeClose, ...rest } = props;
 const close = () => unsafeClose?.(false);
 const card = useCardState();
 const { __experimental_asStandalone } = useOrganizationSwitcherContext();
 const { openOrganizationProfile, openCreateOrganization } = useClerk();
 const getContainer = usePortalRoot();
 const { organization: currentOrg } = useOrganization();
Expand DownExpand Up@@ -138,7 +137,6 @@ export const OrganizationSwitcherPopover = React.forwardRef<HTMLDivElement, Orga
 ref={ref}
 role='dialog'
 aria-label={`${currentOrg?.name} is active`}
 shouldEntryAnimate={!__experimental_asStandalone}
 {...rest}
 >
 <PopoverCard.Content elementDescriptor={descriptors.organizationSwitcherPopoverMain}>
Expand Down

2 changes: 1 addition & 1 deletion
packages/ui/src/components/OrganizationSwitcher/index.tsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -42,7 +42,7 @@ const OrganizationSwitcherWithFloatingTree = withFloatingTree<{ children: ReactE
 <Popover
 nodeId={nodeId}
 context={context}
isOpen={isOpen}
animateExit
 order={['content']}
 initialFocus={popoverRef}
 >
Expand Down

2 changes: 0 additions & 2 deletions
packages/ui/src/components/UserButton/UserButtonPopover.tsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -19,7 +19,6 @@ export const UserButtonPopover = React.forwardRef<HTMLDivElement, UserButtonPopo
 const close = () => unsafeClose?.(false);
 const { session } = useSession() as { session: SignedInSessionResource };
 const userButtonContext = useUserButtonContext();
 const { __experimental_asStandalone } = userButtonContext;
 const { authConfig } = useEnvironment();
 const { user } = useUser();
 const { t } = useLocalizations();
Expand All@@ -40,7 +39,6 @@ export const UserButtonPopover = React.forwardRef<HTMLDivElement, UserButtonPopo
 ref={ref}
 role='dialog'
 aria-label={t(localizationKeys('userButton.label__userButtonPopover'))}
 shouldEntryAnimate={!__experimental_asStandalone}
 {...rest}
 >
 <PopoverCard.Content elementDescriptor={descriptors.userButtonPopoverMain}>
Expand Down

2 changes: 1 addition & 1 deletion
packages/ui/src/components/UserButton/index.tsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -41,7 +41,7 @@ const UserButtonWithFloatingTree = withFloatingTree<{ children: ReactElement }>(
 <Popover
 nodeId={nodeId}
 context={context}
isOpen={isOpen}
animateExit
 order={['content']}
 initialFocus={popoverRef}
 >
Expand Down

31 changes: 16 additions & 15 deletions
packages/ui/src/elements/Menu.tsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -18,7 +18,6 @@ import { Col, descriptors, SimpleButton } from '../customizables';
import type { UsePopoverReturn } from '../hooks';
import { usePopover } from '../hooks';
import type { PropsOfComponent } from '../styledSystem';
import { animations } from '../styledSystem';
import { colors } from '../utils/colors';
import { withFloatingTree } from './contexts';
import { Popover } from './Popover';
Expand DownExpand Up@@ -124,20 +123,24 @@ type MenuListProps = PropsOfComponent<typeof Col> & {
export const MenuList = (props: MenuListProps) => {
 const { sx, asPortal, ...rest } = props;
 const { popoverCtx, elementId, getFloatingProps, elementsRef } = useMenuState();
 const { floating, styles, isOpen, context, nodeId } = popoverCtx;
 const { floating, styles, context, nodeId } = popoverCtx;
 const containerRef = useRef<HTMLDivElement | null>(null);
 const mergedRef = useMergeRefs([containerRef, floating]);

 // `FloatingList` only provides list-navigation context (no DOM), so it wraps the `Popover`
 // rather than nesting inside it — that keeps the `Col` as the `Popover`'s direct child, which is
 // the element the `animateExit` transition (origin-aware scale + fade) is applied to.
 return (
 <Popover
 context={context}
 nodeId={nodeId}
 isOpen={isOpen}
 portal={asPortal}
 order={['content']}
 modal={false}
 >
 <FloatingList elementsRef={elementsRef}>
 <FloatingList elementsRef={elementsRef}>
 <Popover
 context={context}
 nodeId={nodeId}
 animateExit
 initialScale={0.88}
 portal={asPortal}
 order={['content']}
 modal={false}
 >
 <Col
 elementDescriptor={descriptors.menuList}
 elementId={descriptors.menuList.setId(elementId)}
Expand All@@ -153,8 +156,6 @@ export const MenuList = (props: MenuListProps) => {
 padding: t.space.$0x5,
 overflow: 'hidden',
 top: `calc(100% + ${t.space.$2})`,
 animation: `${animations.dropdownSlideInScaleAndFade} ${t.transitionDuration.$slower} ${t.transitionTiming.$slowBezier}`,
 transformOrigin: 'top center',
 zIndex: t.zIndices.$dropdown,
 gap: t.space.$0x5,
 }),
Expand All@@ -164,8 +165,8 @@ export const MenuList = (props: MenuListProps) => {
 {...getFloatingProps()}
 {...rest}
 />
 </FloatingList>
 </Popover>
 </Popover>
 </FloatingList>
 );
};

Expand Down

1 change: 1 addition & 0 deletions
packages/ui/src/elements/PhoneInput/index.tsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -145,6 +145,7 @@ const PhoneInputBase = forwardRef<HTMLInputElement, PhoneInputProps & { feedback
 </Text>
 </SelectButton>
 <SelectOptionList
 initialScale={0.96}
 sx={{ padding: '0 0' }}
 containerSx={theme => ({
 gap: 0,
Expand Down

93 changes: 88 additions & 5 deletions
packages/ui/src/elements/Popover.tsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,14 +1,38 @@
import { usePortalRoot } from '@clerk/shared/react';
import type { FloatingContext, ReferenceType } from '@floating-ui/react';
import { FloatingFocusManager, FloatingNode, FloatingPortal } from '@floating-ui/react';
import { FloatingFocusManager, FloatingNode, FloatingPortal, useTransitionStyles } from '@floating-ui/react';
import type { PropsWithChildren } from 'react';
import React from 'react';

import { useAppearance } from '../customizables';
import { transitionDurationValues, transitionTiming } from '../foundations/transitions';
import { useDirection, usePrefersReducedMotion } from '../hooks';

type PopoverProps = PropsWithChildren<{
 context: FloatingContext<ReferenceType>;
 nodeId?: string;
 isOpen?: boolean;
 initialFocus?: number | React.MutableRefObject<HTMLElement | null>;
 /**
 * When `true`, the popover animates in on mount with an origin-aware scale + fade and stays
 * mounted through a matching fade-out on close, instead of appearing/unmounting instantly.
 * Opt-in so other consumers keep their current instant behavior.
 * @default false
 */
 animateExit?: boolean;
 /**
 * When `animateExit` is set, exits quickly (`$faster`, matching the entrance) instead of the
 * default soft exit (`$slower`). The entrance is always `$faster`.
 * @default false
 */
 exitFast?: boolean;
 /**
 * The scale the popover animates from on enter (and collapses to on exit) when `animateExit`
 * is set. Scale is proportional, so compact surfaces travel fewer pixels — lower this
 * (e.g. `0.92`) to give small popovers like menus a more pronounced motion.
 * @default 0.96
 */
 initialScale?: number;
 /**
 * Determines whether outside elements are inert when modal is enabled. This enables pointer modality without a backdrop.
 * @default false
Expand All@@ -30,6 +54,27 @@ type PopoverProps = PropsWithChildren<{
 root?: HTMLElement | React.MutableRefObject<HTMLElement | null>;
}>;

/**
 * Maps a resolved Floating UI placement to a `transform-origin` so the popover grows from the
 * point nearest its trigger. The primary axis anchors to the edge opposite the `side`; when the
 * placement is aligned to a corner (`-start` / `-end`) the cross axis hugs that corner, otherwise
 * it stays centered. Horizontal alignment is mirrored under RTL to match Floating UI's
 * direction-aware resolved position.
 */
const getTransformOrigin = (placement: string, direction: 'ltr' | 'rtl'): string => {
 const [side, alignment] = placement.split('-');
 if (side === 'top' || side === 'bottom') {
 const y = side === 'top' ? 'bottom' : 'top';
 const start = direction === 'rtl' ? 'right' : 'left';
 const end = direction === 'rtl' ? 'left' : 'right';
 const x = alignment === 'start' ? start : alignment === 'end' ? end : 'center';
 return `${x} ${y}`;
 }
 const x = side === 'left' ? 'right' : 'left';
 const y = alignment === 'start' ? 'top' : alignment === 'end' ? 'bottom' : 'center';
 return `${x} ${y}`;
};

export const Popover = (props: PopoverProps) => {
 const {
 context,
Expand All@@ -39,6 +84,9 @@ export const Popover = (props: PopoverProps) => {
 modal = true,
 nodeId,
 isOpen,
 animateExit = false,
 exitFast = false,
 initialScale = 0.96,
 portal = true,
 root,
 children,
Expand All@@ -47,19 +95,53 @@ export const Popover = (props: PopoverProps) => {
 const portalRoot = usePortalRoot();
 const effectiveRoot = root ?? portalRoot?.() ?? undefined;

 const prefersReducedMotion = usePrefersReducedMotion();
 const direction = useDirection();
 const { animations: layoutAnimations } = useAppearance().parsedOptions;
 const isMotionSafe = !prefersReducedMotion && layoutAnimations === true;
 const animate = animateExit && isMotionSafe;
 const closeDuration = exitFast ? transitionDurationValues.faster : transitionDurationValues.slower;

 // Animate in on mount and out on close with an origin-aware scale + fade. Keeping the element
 // mounted through the close transition (via `isMounted`) is what makes the exit animation
 // possible. `transformOrigin` is derived from the resolved placement so the popover grows from
 // the point nearest its trigger — the aligned corner when present, otherwise the edge center.
 const { isMounted, styles: transitionStyles } = useTransitionStyles(context, {
 duration: {
 open: animate ? transitionDurationValues.faster : 0,
 close: animate ? closeDuration : 0,
 },
 common: ({ placement }) => ({
 transformOrigin: getTransformOrigin(placement, direction),
 transitionTimingFunction: transitionTiming.swiftOut,
 }),
 initial: { opacity: animate ? 0 : 1, transform: animate ? `scale(${initialScale})` : 'scale(1)' },
 open: { opacity: 1, transform: 'scale(1)' },
 close: { opacity: animate ? 0 : 1, transform: animate ? `scale(${initialScale})` : 'scale(1)' },
 });

 // Non-animating consumers keep the original synchronous `isOpen` unmount.
 const shouldRender = animateExit ? isMounted : isOpen;
 const content =
 animateExit && React.isValidElement<{ style?: React.CSSProperties }>(children)
 ? React.cloneElement(children, {
 style: { ...children.props.style, ...transitionStyles },
 })
 : children;

 if (portal) {
 return (
 <FloatingNode id={nodeId}>
 <FloatingPortal root={effectiveRoot}>
 {isOpen && (
 {shouldRender && (
 <FloatingFocusManager
 context={context}
 initialFocus={initialFocus}
 outsideElementsInert={outsideElementsInert}
 order={order}
 modal={modal}
 >
 <>{children}</>
 <>{content}</>
 </FloatingFocusManager>
 )}
 </FloatingPortal>
Expand All@@ -69,14 +151,15 @@ export const Popover = (props: PopoverProps) => {

 return (
 <FloatingNode id={nodeId}>
 {isOpen && (
 {shouldRender && (
 <FloatingFocusManager
 context={context}
 initialFocus={initialFocus}
 outsideElementsInert={outsideElementsInert}
 order={order}
 modal={modal}
 >
 <>{children}</>
 <>{content}</>
Comment thread
maxyinger marked this conversation as resolved.

 </FloatingFocusManager>
 )}
 </FloatingNode>
Expand Down
Loading
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
[WIP] feat(ui): Origin-aware open/close animations for popover menus and selects#9113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Closed

maxyinger
wants to merge
8
commits into

from

 Closed


[WIP] feat(ui): Origin-aware open/close animations for popover menus and selects
#9113
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


8 commits


Select commit
Hold shift + click to select a range
ad67576

snappier in. fade out. new new


maxyinger Jul 9, 2026
5857315

animation refinements


maxyinger Jul 9, 2026
3c7be4d

update origin, add select and menu transitions


maxyinger Jul 9, 2026
b9fd172

fix dropped prop and bump ui common cieling


maxyinger Jul 9, 2026
a934f08

fix unit tests


maxyinger Jul 9, 2026
f489835

fix integration tests


maxyinger Jul 9, 2026
bbe573c

cleanup


maxyinger Jul 9, 2026
ab7d076

more integration fixes


maxyinger Jul 9, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


5 changes: 5 additions & 0 deletions
.changeset/popover-enter-exit-animations.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
---
'@clerk/ui': patch
---

Popover-based surfaces now open and close with an origin-aware scale-and-fade that grows from the edge nearest the trigger, replacing the previous entrance-only slide animation. This covers the `<OrganizationSwitcher />` / `<UserButton />` menus, the overflow (⋯) menus, and selects — menus keep a quick-in / soft-out feel while selects use a quicker exit. Motion is disabled when `appearance.animations` is `false` or the user prefers reduced motion.

14 changes: 14 additions & 0 deletions
integration/tests/custom-pages.test.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -405,14 +405,19 @@ testAgainstRunningApps({ withPattern: ['react.vite.withEmailCodes'] })(
 const notificationsButton = buttons[2];
 const languageButton = buttons[3];

 // Clicking an action closes the popover, which now plays an exit animation and stays
 // mounted until it finishes — wait for it to fully close before re-opening, otherwise
 // the re-open races the still-visible exiting popover.
 // Test chat toggle
 await chatButton.click();
 await u.po.userButton.waitForPopoverClosed();
 await u.po.userButton.toggleTrigger();
 await u.po.userButton.waitForPopover();
 await expect(chatButton).toHaveText('🌐Chat is ON');
 await expect(languageButton).toHaveText('🌍Language: EN');

 await notificationsButton.click();
 await u.po.userButton.waitForPopoverClosed();
 await u.po.userButton.toggleTrigger();
 await u.po.userButton.waitForPopover();
 await expect(notificationsButton).toHaveText('🌐Notifications 🔔 ON');
Expand DownExpand Up@@ -460,14 +465,19 @@ testAgainstRunningApps({ withPattern: ['react.vite.withEmailCodes'] })(
 const languageButton = buttons[3];
 const manageAccountButton = buttons[4];

 // Clicking an action closes the popover, which now plays an exit animation and stays
 // mounted until it finishes — wait for it to fully close before re-opening, otherwise
 // the re-open races the still-visible exiting popover.
 // Test chat toggle
 await chatButton.click();
 await u.po.userButton.waitForPopoverClosed();
 await u.po.userButton.toggleTrigger();
 await u.po.userButton.waitForPopover();
 await expect(chatButton).toHaveText('🌐Chat is ON');
 await expect(languageButton).toHaveText('🌍Language: EN');

 await notificationsButton.click();
 await u.po.userButton.waitForPopoverClosed();
 await u.po.userButton.toggleTrigger();
 await u.po.userButton.waitForPopover();
 await expect(notificationsButton).toHaveText('🌐Notifications 🔔 ON');
Expand DownExpand Up@@ -508,6 +518,10 @@ testAgainstRunningApps({ withPattern: ['react.vite.withEmailCodes'] })(
 await expect(toggleButton.locator('span')).toHaveText('🔔');
 await toggleButton.click();

 // The action closes the popover with an exit animation that keeps it mounted until it
 // finishes; wait for the full close so the re-open doesn't race the exiting popover.
 await u.po.userButton.waitForPopoverClosed();

 // Re-open menu to see updated items
 await u.po.userButton.toggleTrigger();
 await u.po.userButton.waitForPopover();
Expand Down

5 changes: 4 additions & 1 deletion
packages/testing/src/playwright/unstable/page-objects/apiKeys.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -61,7 +61,10 @@ export const createAPIKeysComponentPageObject = (testArgs: { page: EnhancedPage
 return page.getByLabel(/Type "Revoke" to confirm/i).fill(value);
 },
 clickConfirmRevokeButton: () => {
 return page.getByText(/Revoke key/i).click();
 // Target the modal's submit button by its descriptor class rather than by text: the menu
 // action that opens this modal is also labelled "Revoke key", and it now lingers through an
 // exit animation, so a text locator transiently matches both (strict-mode violation).
 return page.locator('.cl-apiKeysRevokeModal .cl-apiKeysRevokeModalSubmitButton').click();
 },
 };
 return self;
Expand Down

2 changes: 1 addition & 1 deletion
packages/ui/bundlewatch.config.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -5,7 +5,7 @@
 { "path": "./dist/ui.shared.browser.js", "maxSize": "40KB" },
 { "path": "./dist/framework*.js", "maxSize": "44KB" },
 { "path": "./dist/vendors*.js", "maxSize": "73KB" },
 { "path": "./dist/ui-common*.js", "maxSize": "130KB" },
 { "path": "./dist/ui-common*.js", "maxSize": "132KB" },
 { "path": "./dist/signin*.js", "maxSize": "17KB" },
 { "path": "./dist/signup*.js", "maxSize": "13KB" },
 { "path": "./dist/userprofile*.js", "maxSize": "16KB" },
Expand Down

2 changes: 0 additions & 2 deletions
packages/ui/src/components/OrganizationSwitcher/OrganizationSwitcherPopover.tsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -23,7 +23,6 @@ export const OrganizationSwitcherPopover = React.forwardRef<HTMLDivElement, Orga
 const { close: unsafeClose, ...rest } = props;
 const close = () => unsafeClose?.(false);
 const card = useCardState();
 const { __experimental_asStandalone } = useOrganizationSwitcherContext();
 const { openOrganizationProfile, openCreateOrganization } = useClerk();
 const getContainer = usePortalRoot();
 const { organization: currentOrg } = useOrganization();
Expand DownExpand Up@@ -138,7 +137,6 @@ export const OrganizationSwitcherPopover = React.forwardRef<HTMLDivElement, Orga
 ref={ref}
 role='dialog'
 aria-label={`${currentOrg?.name} is active`}
 shouldEntryAnimate={!__experimental_asStandalone}
 {...rest}
 >
 <PopoverCard.Content elementDescriptor={descriptors.organizationSwitcherPopoverMain}>
Expand Down

2 changes: 1 addition & 1 deletion
packages/ui/src/components/OrganizationSwitcher/index.tsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -42,7 +42,7 @@ const OrganizationSwitcherWithFloatingTree = withFloatingTree<{ children: ReactE
 <Popover
 nodeId={nodeId}
 context={context}
isOpen={isOpen}
animateExit
 order={['content']}
 initialFocus={popoverRef}
 >
Expand Down

2 changes: 0 additions & 2 deletions
packages/ui/src/components/UserButton/UserButtonPopover.tsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -19,7 +19,6 @@ export const UserButtonPopover = React.forwardRef<HTMLDivElement, UserButtonPopo
 const close = () => unsafeClose?.(false);
 const { session } = useSession() as { session: SignedInSessionResource };
 const userButtonContext = useUserButtonContext();
 const { __experimental_asStandalone } = userButtonContext;
 const { authConfig } = useEnvironment();
 const { user } = useUser();
 const { t } = useLocalizations();
Expand All@@ -40,7 +39,6 @@ export const UserButtonPopover = React.forwardRef<HTMLDivElement, UserButtonPopo
 ref={ref}
 role='dialog'
 aria-label={t(localizationKeys('userButton.label__userButtonPopover'))}
 shouldEntryAnimate={!__experimental_asStandalone}
 {...rest}
 >
 <PopoverCard.Content elementDescriptor={descriptors.userButtonPopoverMain}>
Expand Down

2 changes: 1 addition & 1 deletion
packages/ui/src/components/UserButton/index.tsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -41,7 +41,7 @@ const UserButtonWithFloatingTree = withFloatingTree<{ children: ReactElement }>(
 <Popover
 nodeId={nodeId}
 context={context}
isOpen={isOpen}
animateExit
 order={['content']}
 initialFocus={popoverRef}
 >
Expand Down

31 changes: 16 additions & 15 deletions
packages/ui/src/elements/Menu.tsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -18,7 +18,6 @@ import { Col, descriptors, SimpleButton } from '../customizables';
import type { UsePopoverReturn } from '../hooks';
import { usePopover } from '../hooks';
import type { PropsOfComponent } from '../styledSystem';
import { animations } from '../styledSystem';
import { colors } from '../utils/colors';
import { withFloatingTree } from './contexts';
import { Popover } from './Popover';
Expand DownExpand Up@@ -124,20 +123,24 @@ type MenuListProps = PropsOfComponent<typeof Col> & {
export const MenuList = (props: MenuListProps) => {
 const { sx, asPortal, ...rest } = props;
 const { popoverCtx, elementId, getFloatingProps, elementsRef } = useMenuState();
 const { floating, styles, isOpen, context, nodeId } = popoverCtx;
 const { floating, styles, context, nodeId } = popoverCtx;
 const containerRef = useRef<HTMLDivElement | null>(null);
 const mergedRef = useMergeRefs([containerRef, floating]);

 // `FloatingList` only provides list-navigation context (no DOM), so it wraps the `Popover`
 // rather than nesting inside it — that keeps the `Col` as the `Popover`'s direct child, which is
 // the element the `animateExit` transition (origin-aware scale + fade) is applied to.
 return (
 <Popover
 context={context}
 nodeId={nodeId}
 isOpen={isOpen}
 portal={asPortal}
 order={['content']}
 modal={false}
 >
 <FloatingList elementsRef={elementsRef}>
 <FloatingList elementsRef={elementsRef}>
 <Popover
 context={context}
 nodeId={nodeId}
 animateExit
 initialScale={0.88}
 portal={asPortal}
 order={['content']}
 modal={false}
 >
 <Col
 elementDescriptor={descriptors.menuList}
 elementId={descriptors.menuList.setId(elementId)}
Expand All@@ -153,8 +156,6 @@ export const MenuList = (props: MenuListProps) => {
 padding: t.space.$0x5,
 overflow: 'hidden',
 top: `calc(100% + ${t.space.$2})`,
 animation: `${animations.dropdownSlideInScaleAndFade} ${t.transitionDuration.$slower} ${t.transitionTiming.$slowBezier}`,
 transformOrigin: 'top center',
 zIndex: t.zIndices.$dropdown,
 gap: t.space.$0x5,
 }),
Expand All@@ -164,8 +165,8 @@ export const MenuList = (props: MenuListProps) => {
 {...getFloatingProps()}
 {...rest}
 />
 </FloatingList>
 </Popover>
 </Popover>
 </FloatingList>
 );
};

Expand Down

1 change: 1 addition & 0 deletions
packages/ui/src/elements/PhoneInput/index.tsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -145,6 +145,7 @@ const PhoneInputBase = forwardRef<HTMLInputElement, PhoneInputProps & { feedback
 </Text>
 </SelectButton>
 <SelectOptionList
 initialScale={0.96}
 sx={{ padding: '0 0' }}
 containerSx={theme => ({
 gap: 0,
Expand Down

93 changes: 88 additions & 5 deletions
packages/ui/src/elements/Popover.tsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,14 +1,38 @@
import { usePortalRoot } from '@clerk/shared/react';
import type { FloatingContext, ReferenceType } from '@floating-ui/react';
import { FloatingFocusManager, FloatingNode, FloatingPortal } from '@floating-ui/react';
import { FloatingFocusManager, FloatingNode, FloatingPortal, useTransitionStyles } from '@floating-ui/react';
import type { PropsWithChildren } from 'react';
import React from 'react';

import { useAppearance } from '../customizables';
import { transitionDurationValues, transitionTiming } from '../foundations/transitions';
import { useDirection, usePrefersReducedMotion } from '../hooks';

type PopoverProps = PropsWithChildren<{
 context: FloatingContext<ReferenceType>;
 nodeId?: string;
 isOpen?: boolean;
 initialFocus?: number | React.MutableRefObject<HTMLElement | null>;
 /**
 * When `true`, the popover animates in on mount with an origin-aware scale + fade and stays
 * mounted through a matching fade-out on close, instead of appearing/unmounting instantly.
 * Opt-in so other consumers keep their current instant behavior.
 * @default false
 */
 animateExit?: boolean;
 /**
 * When `animateExit` is set, exits quickly (`$faster`, matching the entrance) instead of the
 * default soft exit (`$slower`). The entrance is always `$faster`.
 * @default false
 */
 exitFast?: boolean;
 /**
 * The scale the popover animates from on enter (and collapses to on exit) when `animateExit`
 * is set. Scale is proportional, so compact surfaces travel fewer pixels — lower this
 * (e.g. `0.92`) to give small popovers like menus a more pronounced motion.
 * @default 0.96
 */
 initialScale?: number;
 /**
 * Determines whether outside elements are inert when modal is enabled. This enables pointer modality without a backdrop.
 * @default false
Expand All@@ -30,6 +54,27 @@ type PopoverProps = PropsWithChildren<{
 root?: HTMLElement | React.MutableRefObject<HTMLElement | null>;
}>;

/**
 * Maps a resolved Floating UI placement to a `transform-origin` so the popover grows from the
 * point nearest its trigger. The primary axis anchors to the edge opposite the `side`; when the
 * placement is aligned to a corner (`-start` / `-end`) the cross axis hugs that corner, otherwise
 * it stays centered. Horizontal alignment is mirrored under RTL to match Floating UI's
 * direction-aware resolved position.
 */
const getTransformOrigin = (placement: string, direction: 'ltr' | 'rtl'): string => {
 const [side, alignment] = placement.split('-');
 if (side === 'top' || side === 'bottom') {
 const y = side === 'top' ? 'bottom' : 'top';
 const start = direction === 'rtl' ? 'right' : 'left';
 const end = direction === 'rtl' ? 'left' : 'right';
 const x = alignment === 'start' ? start : alignment === 'end' ? end : 'center';
 return `${x} ${y}`;
 }
 const x = side === 'left' ? 'right' : 'left';
 const y = alignment === 'start' ? 'top' : alignment === 'end' ? 'bottom' : 'center';
 return `${x} ${y}`;
};

export const Popover = (props: PopoverProps) => {
 const {
 context,
Expand All@@ -39,6 +84,9 @@ export const Popover = (props: PopoverProps) => {
 modal = true,
 nodeId,
 isOpen,
 animateExit = false,
 exitFast = false,
 initialScale = 0.96,
 portal = true,
 root,
 children,
Expand All@@ -47,19 +95,53 @@ export const Popover = (props: PopoverProps) => {
 const portalRoot = usePortalRoot();
 const effectiveRoot = root ?? portalRoot?.() ?? undefined;

 const prefersReducedMotion = usePrefersReducedMotion();
 const direction = useDirection();
 const { animations: layoutAnimations } = useAppearance().parsedOptions;
 const isMotionSafe = !prefersReducedMotion && layoutAnimations === true;
 const animate = animateExit && isMotionSafe;
 const closeDuration = exitFast ? transitionDurationValues.faster : transitionDurationValues.slower;

 // Animate in on mount and out on close with an origin-aware scale + fade. Keeping the element
 // mounted through the close transition (via `isMounted`) is what makes the exit animation
 // possible. `transformOrigin` is derived from the resolved placement so the popover grows from
 // the point nearest its trigger — the aligned corner when present, otherwise the edge center.
 const { isMounted, styles: transitionStyles } = useTransitionStyles(context, {
 duration: {
 open: animate ? transitionDurationValues.faster : 0,
 close: animate ? closeDuration : 0,
 },
 common: ({ placement }) => ({
 transformOrigin: getTransformOrigin(placement, direction),
 transitionTimingFunction: transitionTiming.swiftOut,
 }),
 initial: { opacity: animate ? 0 : 1, transform: animate ? `scale(${initialScale})` : 'scale(1)' },
 open: { opacity: 1, transform: 'scale(1)' },
 close: { opacity: animate ? 0 : 1, transform: animate ? `scale(${initialScale})` : 'scale(1)' },
 });

 // Non-animating consumers keep the original synchronous `isOpen` unmount.
 const shouldRender = animateExit ? isMounted : isOpen;
 const content =
 animateExit && React.isValidElement<{ style?: React.CSSProperties }>(children)
 ? React.cloneElement(children, {
 style: { ...children.props.style, ...transitionStyles },
 })
 : children;

 if (portal) {
 return (
 <FloatingNode id={nodeId}>
 <FloatingPortal root={effectiveRoot}>
 {isOpen && (
 {shouldRender && (
 <FloatingFocusManager
 context={context}
 initialFocus={initialFocus}
 outsideElementsInert={outsideElementsInert}
 order={order}
 modal={modal}
 >
 <>{children}</>
 <>{content}</>
 </FloatingFocusManager>
 )}
 </FloatingPortal>
Expand All@@ -69,14 +151,15 @@ export const Popover = (props: PopoverProps) => {

 return (
 <FloatingNode id={nodeId}>
 {isOpen && (
 {shouldRender && (
 <FloatingFocusManager
 context={context}
 initialFocus={initialFocus}
 outsideElementsInert={outsideElementsInert}
 order={order}
 modal={modal}
 >
 <>{children}</>
 <>{content}</>
Comment thread
maxyinger marked this conversation as resolved.

 </FloatingFocusManager>
 )}
 </FloatingNode>
Expand Down
Loading
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
[WIP] feat(ui): Origin-aware open/close animations for popover menus and selects#9113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Closed

maxyinger
wants to merge
8
commits into

from

 Closed


[WIP] feat(ui): Origin-aware open/close animations for popover menus and selects
#9113
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


8 commits


Select commit
Hold shift + click to select a range
ad67576

snappier in. fade out. new new


maxyinger Jul 9, 2026
5857315

animation refinements


maxyinger Jul 9, 2026
3c7be4d

update origin, add select and menu transitions


maxyinger Jul 9, 2026
b9fd172

fix dropped prop and bump ui common cieling


maxyinger Jul 9, 2026
a934f08

fix unit tests


maxyinger Jul 9, 2026
f489835

fix integration tests


maxyinger Jul 9, 2026
bbe573c

cleanup


maxyinger Jul 9, 2026
ab7d076

more integration fixes


maxyinger Jul 9, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


5 changes: 5 additions & 0 deletions
.changeset/popover-enter-exit-animations.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
---
'@clerk/ui': patch
---

Popover-based surfaces now open and close with an origin-aware scale-and-fade that grows from the edge nearest the trigger, replacing the previous entrance-only slide animation. This covers the `<OrganizationSwitcher />` / `<UserButton />` menus, the overflow (⋯) menus, and selects — menus keep a quick-in / soft-out feel while selects use a quicker exit. Motion is disabled when `appearance.animations` is `false` or the user prefers reduced motion.

14 changes: 14 additions & 0 deletions
integration/tests/custom-pages.test.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -405,14 +405,19 @@ testAgainstRunningApps({ withPattern: ['react.vite.withEmailCodes'] })(
 const notificationsButton = buttons[2];
 const languageButton = buttons[3];

 // Clicking an action closes the popover, which now plays an exit animation and stays
 // mounted until it finishes — wait for it to fully close before re-opening, otherwise
 // the re-open races the still-visible exiting popover.
 // Test chat toggle
 await chatButton.click();
 await u.po.userButton.waitForPopoverClosed();
 await u.po.userButton.toggleTrigger();
 await u.po.userButton.waitForPopover();
 await expect(chatButton).toHaveText('🌐Chat is ON');
 await expect(languageButton).toHaveText('🌍Language: EN');

 await notificationsButton.click();
 await u.po.userButton.waitForPopoverClosed();
 await u.po.userButton.toggleTrigger();
 await u.po.userButton.waitForPopover();
 await expect(notificationsButton).toHaveText('🌐Notifications 🔔 ON');
Expand DownExpand Up@@ -460,14 +465,19 @@ testAgainstRunningApps({ withPattern: ['react.vite.withEmailCodes'] })(
 const languageButton = buttons[3];
 const manageAccountButton = buttons[4];

 // Clicking an action closes the popover, which now plays an exit animation and stays
 // mounted until it finishes — wait for it to fully close before re-opening, otherwise
 // the re-open races the still-visible exiting popover.
 // Test chat toggle
 await chatButton.click();
 await u.po.userButton.waitForPopoverClosed();
 await u.po.userButton.toggleTrigger();
 await u.po.userButton.waitForPopover();
 await expect(chatButton).toHaveText('🌐Chat is ON');
 await expect(languageButton).toHaveText('🌍Language: EN');

 await notificationsButton.click();
 await u.po.userButton.waitForPopoverClosed();
 await u.po.userButton.toggleTrigger();
 await u.po.userButton.waitForPopover();
 await expect(notificationsButton).toHaveText('🌐Notifications 🔔 ON');
Expand DownExpand Up@@ -508,6 +518,10 @@ testAgainstRunningApps({ withPattern: ['react.vite.withEmailCodes'] })(
 await expect(toggleButton.locator('span')).toHaveText('🔔');
 await toggleButton.click();

 // The action closes the popover with an exit animation that keeps it mounted until it
 // finishes; wait for the full close so the re-open doesn't race the exiting popover.
 await u.po.userButton.waitForPopoverClosed();

 // Re-open menu to see updated items
 await u.po.userButton.toggleTrigger();
 await u.po.userButton.waitForPopover();
Expand Down

5 changes: 4 additions & 1 deletion
packages/testing/src/playwright/unstable/page-objects/apiKeys.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -61,7 +61,10 @@ export const createAPIKeysComponentPageObject = (testArgs: { page: EnhancedPage
 return page.getByLabel(/Type "Revoke" to confirm/i).fill(value);
 },
 clickConfirmRevokeButton: () => {
 return page.getByText(/Revoke key/i).click();
 // Target the modal's submit button by its descriptor class rather than by text: the menu
 // action that opens this modal is also labelled "Revoke key", and it now lingers through an
 // exit animation, so a text locator transiently matches both (strict-mode violation).
 return page.locator('.cl-apiKeysRevokeModal .cl-apiKeysRevokeModalSubmitButton').click();
 },
 };
 return self;
Expand Down

2 changes: 1 addition & 1 deletion
packages/ui/bundlewatch.config.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -5,7 +5,7 @@
 { "path": "./dist/ui.shared.browser.js", "maxSize": "40KB" },
 { "path": "./dist/framework*.js", "maxSize": "44KB" },
 { "path": "./dist/vendors*.js", "maxSize": "73KB" },
 { "path": "./dist/ui-common*.js", "maxSize": "130KB" },
 { "path": "./dist/ui-common*.js", "maxSize": "132KB" },
 { "path": "./dist/signin*.js", "maxSize": "17KB" },
 { "path": "./dist/signup*.js", "maxSize": "13KB" },
 { "path": "./dist/userprofile*.js", "maxSize": "16KB" },
Expand Down

2 changes: 0 additions & 2 deletions
packages/ui/src/components/OrganizationSwitcher/OrganizationSwitcherPopover.tsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -23,7 +23,6 @@ export const OrganizationSwitcherPopover = React.forwardRef<HTMLDivElement, Orga
 const { close: unsafeClose, ...rest } = props;
 const close = () => unsafeClose?.(false);
 const card = useCardState();
 const { __experimental_asStandalone } = useOrganizationSwitcherContext();
 const { openOrganizationProfile, openCreateOrganization } = useClerk();
 const getContainer = usePortalRoot();
 const { organization: currentOrg } = useOrganization();
Expand DownExpand Up@@ -138,7 +137,6 @@ export const OrganizationSwitcherPopover = React.forwardRef<HTMLDivElement, Orga
 ref={ref}
 role='dialog'
 aria-label={`${currentOrg?.name} is active`}
 shouldEntryAnimate={!__experimental_asStandalone}
 {...rest}
 >
 <PopoverCard.Content elementDescriptor={descriptors.organizationSwitcherPopoverMain}>
Expand Down

2 changes: 1 addition & 1 deletion
packages/ui/src/components/OrganizationSwitcher/index.tsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -42,7 +42,7 @@ const OrganizationSwitcherWithFloatingTree = withFloatingTree<{ children: ReactE
 <Popover
 nodeId={nodeId}
 context={context}
isOpen={isOpen}
animateExit
 order={['content']}
 initialFocus={popoverRef}
 >
Expand Down

2 changes: 0 additions & 2 deletions
packages/ui/src/components/UserButton/UserButtonPopover.tsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -19,7 +19,6 @@ export const UserButtonPopover = React.forwardRef<HTMLDivElement, UserButtonPopo
 const close = () => unsafeClose?.(false);
 const { session } = useSession() as { session: SignedInSessionResource };
 const userButtonContext = useUserButtonContext();
 const { __experimental_asStandalone } = userButtonContext;
 const { authConfig } = useEnvironment();
 const { user } = useUser();
 const { t } = useLocalizations();
Expand All@@ -40,7 +39,6 @@ export const UserButtonPopover = React.forwardRef<HTMLDivElement, UserButtonPopo
 ref={ref}
 role='dialog'
 aria-label={t(localizationKeys('userButton.label__userButtonPopover'))}
 shouldEntryAnimate={!__experimental_asStandalone}
 {...rest}
 >
 <PopoverCard.Content elementDescriptor={descriptors.userButtonPopoverMain}>
Expand Down

2 changes: 1 addition & 1 deletion
packages/ui/src/components/UserButton/index.tsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -41,7 +41,7 @@ const UserButtonWithFloatingTree = withFloatingTree<{ children: ReactElement }>(
 <Popover
 nodeId={nodeId}
 context={context}
isOpen={isOpen}
animateExit
 order={['content']}
 initialFocus={popoverRef}
 >
Expand Down

31 changes: 16 additions & 15 deletions
packages/ui/src/elements/Menu.tsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -18,7 +18,6 @@ import { Col, descriptors, SimpleButton } from '../customizables';
import type { UsePopoverReturn } from '../hooks';
import { usePopover } from '../hooks';
import type { PropsOfComponent } from '../styledSystem';
import { animations } from '../styledSystem';
import { colors } from '../utils/colors';
import { withFloatingTree } from './contexts';
import { Popover } from './Popover';
Expand DownExpand Up@@ -124,20 +123,24 @@ type MenuListProps = PropsOfComponent<typeof Col> & {
export const MenuList = (props: MenuListProps) => {
 const { sx, asPortal, ...rest } = props;
 const { popoverCtx, elementId, getFloatingProps, elementsRef } = useMenuState();
 const { floating, styles, isOpen, context, nodeId } = popoverCtx;
 const { floating, styles, context, nodeId } = popoverCtx;
 const containerRef = useRef<HTMLDivElement | null>(null);
 const mergedRef = useMergeRefs([containerRef, floating]);

 // `FloatingList` only provides list-navigation context (no DOM), so it wraps the `Popover`
 // rather than nesting inside it — that keeps the `Col` as the `Popover`'s direct child, which is
 // the element the `animateExit` transition (origin-aware scale + fade) is applied to.
 return (
 <Popover
 context={context}
 nodeId={nodeId}
 isOpen={isOpen}
 portal={asPortal}
 order={['content']}
 modal={false}
 >
 <FloatingList elementsRef={elementsRef}>
 <FloatingList elementsRef={elementsRef}>
 <Popover
 context={context}
 nodeId={nodeId}
 animateExit
 initialScale={0.88}
 portal={asPortal}
 order={['content']}
 modal={false}
 >
 <Col
 elementDescriptor={descriptors.menuList}
 elementId={descriptors.menuList.setId(elementId)}
Expand All@@ -153,8 +156,6 @@ export const MenuList = (props: MenuListProps) => {
 padding: t.space.$0x5,
 overflow: 'hidden',
 top: `calc(100% + ${t.space.$2})`,
 animation: `${animations.dropdownSlideInScaleAndFade} ${t.transitionDuration.$slower} ${t.transitionTiming.$slowBezier}`,
 transformOrigin: 'top center',
 zIndex: t.zIndices.$dropdown,
 gap: t.space.$0x5,
 }),
Expand All@@ -164,8 +165,8 @@ export const MenuList = (props: MenuListProps) => {
 {...getFloatingProps()}
 {...rest}
 />
 </FloatingList>
 </Popover>
 </Popover>
 </FloatingList>
 );
};

Expand Down

1 change: 1 addition & 0 deletions
packages/ui/src/elements/PhoneInput/index.tsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -145,6 +145,7 @@ const PhoneInputBase = forwardRef<HTMLInputElement, PhoneInputProps & { feedback
 </Text>
 </SelectButton>
 <SelectOptionList
 initialScale={0.96}
 sx={{ padding: '0 0' }}
 containerSx={theme => ({
 gap: 0,
Expand Down

93 changes: 88 additions & 5 deletions
packages/ui/src/elements/Popover.tsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,14 +1,38 @@
import { usePortalRoot } from '@clerk/shared/react';
import type { FloatingContext, ReferenceType } from '@floating-ui/react';
import { FloatingFocusManager, FloatingNode, FloatingPortal } from '@floating-ui/react';
import { FloatingFocusManager, FloatingNode, FloatingPortal, useTransitionStyles } from '@floating-ui/react';
import type { PropsWithChildren } from 'react';
import React from 'react';

import { useAppearance } from '../customizables';
import { transitionDurationValues, transitionTiming } from '../foundations/transitions';
import { useDirection, usePrefersReducedMotion } from '../hooks';

type PopoverProps = PropsWithChildren<{
 context: FloatingContext<ReferenceType>;
 nodeId?: string;
 isOpen?: boolean;
 initialFocus?: number | React.MutableRefObject<HTMLElement | null>;
 /**
 * When `true`, the popover animates in on mount with an origin-aware scale + fade and stays
 * mounted through a matching fade-out on close, instead of appearing/unmounting instantly.
 * Opt-in so other consumers keep their current instant behavior.
 * @default false
 */
 animateExit?: boolean;
 /**
 * When `animateExit` is set, exits quickly (`$faster`, matching the entrance) instead of the
 * default soft exit (`$slower`). The entrance is always `$faster`.
 * @default false
 */
 exitFast?: boolean;
 /**
 * The scale the popover animates from on enter (and collapses to on exit) when `animateExit`
 * is set. Scale is proportional, so compact surfaces travel fewer pixels — lower this
 * (e.g. `0.92`) to give small popovers like menus a more pronounced motion.
 * @default 0.96
 */
 initialScale?: number;
 /**
 * Determines whether outside elements are inert when modal is enabled. This enables pointer modality without a backdrop.
 * @default false
Expand All@@ -30,6 +54,27 @@ type PopoverProps = PropsWithChildren<{
 root?: HTMLElement | React.MutableRefObject<HTMLElement | null>;
}>;

/**
 * Maps a resolved Floating UI placement to a `transform-origin` so the popover grows from the
 * point nearest its trigger. The primary axis anchors to the edge opposite the `side`; when the
 * placement is aligned to a corner (`-start` / `-end`) the cross axis hugs that corner, otherwise
 * it stays centered. Horizontal alignment is mirrored under RTL to match Floating UI's
 * direction-aware resolved position.
 */
const getTransformOrigin = (placement: string, direction: 'ltr' | 'rtl'): string => {
 const [side, alignment] = placement.split('-');
 if (side === 'top' || side === 'bottom') {
 const y = side === 'top' ? 'bottom' : 'top';
 const start = direction === 'rtl' ? 'right' : 'left';
 const end = direction === 'rtl' ? 'left' : 'right';
 const x = alignment === 'start' ? start : alignment === 'end' ? end : 'center';
 return `${x} ${y}`;
 }
 const x = side === 'left' ? 'right' : 'left';
 const y = alignment === 'start' ? 'top' : alignment === 'end' ? 'bottom' : 'center';
 return `${x} ${y}`;
};

export const Popover = (props: PopoverProps) => {
 const {
 context,
Expand All@@ -39,6 +84,9 @@ export const Popover = (props: PopoverProps) => {
 modal = true,
 nodeId,
 isOpen,
 animateExit = false,
 exitFast = false,
 initialScale = 0.96,
 portal = true,
 root,
 children,
Expand All@@ -47,19 +95,53 @@ export const Popover = (props: PopoverProps) => {
 const portalRoot = usePortalRoot();
 const effectiveRoot = root ?? portalRoot?.() ?? undefined;

 const prefersReducedMotion = usePrefersReducedMotion();
 const direction = useDirection();
 const { animations: layoutAnimations } = useAppearance().parsedOptions;
 const isMotionSafe = !prefersReducedMotion && layoutAnimations === true;
 const animate = animateExit && isMotionSafe;
 const closeDuration = exitFast ? transitionDurationValues.faster : transitionDurationValues.slower;

 // Animate in on mount and out on close with an origin-aware scale + fade. Keeping the element
 // mounted through the close transition (via `isMounted`) is what makes the exit animation
 // possible. `transformOrigin` is derived from the resolved placement so the popover grows from
 // the point nearest its trigger — the aligned corner when present, otherwise the edge center.
 const { isMounted, styles: transitionStyles } = useTransitionStyles(context, {
 duration: {
 open: animate ? transitionDurationValues.faster : 0,
 close: animate ? closeDuration : 0,
 },
 common: ({ placement }) => ({
 transformOrigin: getTransformOrigin(placement, direction),
 transitionTimingFunction: transitionTiming.swiftOut,
 }),
 initial: { opacity: animate ? 0 : 1, transform: animate ? `scale(${initialScale})` : 'scale(1)' },
 open: { opacity: 1, transform: 'scale(1)' },
 close: { opacity: animate ? 0 : 1, transform: animate ? `scale(${initialScale})` : 'scale(1)' },
 });

 // Non-animating consumers keep the original synchronous `isOpen` unmount.
 const shouldRender = animateExit ? isMounted : isOpen;
 const content =
 animateExit && React.isValidElement<{ style?: React.CSSProperties }>(children)
 ? React.cloneElement(children, {
 style: { ...children.props.style, ...transitionStyles },
 })
 : children;

 if (portal) {
 return (
 <FloatingNode id={nodeId}>
 <FloatingPortal root={effectiveRoot}>
 {isOpen && (
 {shouldRender && (
 <FloatingFocusManager
 context={context}
 initialFocus={initialFocus}
 outsideElementsInert={outsideElementsInert}
 order={order}
 modal={modal}
 >
 <>{children}</>
 <>{content}</>
 </FloatingFocusManager>
 )}
 </FloatingPortal>
Expand All@@ -69,14 +151,15 @@ export const Popover = (props: PopoverProps) => {

 return (
 <FloatingNode id={nodeId}>
 {isOpen && (
 {shouldRender && (
 <FloatingFocusManager
 context={context}
 initialFocus={initialFocus}
 outsideElementsInert={outsideElementsInert}
 order={order}
 modal={modal}
 >
 <>{children}</>
 <>{content}</>
Comment thread
maxyinger marked this conversation as resolved.

 </FloatingFocusManager>
 )}
 </FloatingNode>
Expand Down
Loading
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
[WIP] feat(ui): Origin-aware open/close animations for popover menus and selects#9113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Closed

maxyinger
wants to merge
8
commits into

from

 Closed


[WIP] feat(ui): Origin-aware open/close animations for popover menus and selects
#9113
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


8 commits


Select commit
Hold shift + click to select a range
ad67576

snappier in. fade out. new new


maxyinger Jul 9, 2026
5857315

animation refinements


maxyinger Jul 9, 2026
3c7be4d

update origin, add select and menu transitions


maxyinger Jul 9, 2026
b9fd172

fix dropped prop and bump ui common cieling


maxyinger Jul 9, 2026
a934f08

fix unit tests


maxyinger Jul 9, 2026
f489835

fix integration tests


maxyinger Jul 9, 2026
bbe573c

cleanup


maxyinger Jul 9, 2026
ab7d076

more integration fixes


maxyinger Jul 9, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


5 changes: 5 additions & 0 deletions
.changeset/popover-enter-exit-animations.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
---
'@clerk/ui': patch
---

Popover-based surfaces now open and close with an origin-aware scale-and-fade that grows from the edge nearest the trigger, replacing the previous entrance-only slide animation. This covers the `<OrganizationSwitcher />` / `<UserButton />` menus, the overflow (⋯) menus, and selects — menus keep a quick-in / soft-out feel while selects use a quicker exit. Motion is disabled when `appearance.animations` is `false` or the user prefers reduced motion.

14 changes: 14 additions & 0 deletions
integration/tests/custom-pages.test.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -405,14 +405,19 @@ testAgainstRunningApps({ withPattern: ['react.vite.withEmailCodes'] })(
 const notificationsButton = buttons[2];
 const languageButton = buttons[3];

 // Clicking an action closes the popover, which now plays an exit animation and stays
 // mounted until it finishes — wait for it to fully close before re-opening, otherwise
 // the re-open races the still-visible exiting popover.
 // Test chat toggle
 await chatButton.click();
 await u.po.userButton.waitForPopoverClosed();
 await u.po.userButton.toggleTrigger();
 await u.po.userButton.waitForPopover();
 await expect(chatButton).toHaveText('🌐Chat is ON');
 await expect(languageButton).toHaveText('🌍Language: EN');

 await notificationsButton.click();
 await u.po.userButton.waitForPopoverClosed();
 await u.po.userButton.toggleTrigger();
 await u.po.userButton.waitForPopover();
 await expect(notificationsButton).toHaveText('🌐Notifications 🔔 ON');
Expand DownExpand Up@@ -460,14 +465,19 @@ testAgainstRunningApps({ withPattern: ['react.vite.withEmailCodes'] })(
 const languageButton = buttons[3];
 const manageAccountButton = buttons[4];

 // Clicking an action closes the popover, which now plays an exit animation and stays
 // mounted until it finishes — wait for it to fully close before re-opening, otherwise
 // the re-open races the still-visible exiting popover.
 // Test chat toggle
 await chatButton.click();
 await u.po.userButton.waitForPopoverClosed();
 await u.po.userButton.toggleTrigger();
 await u.po.userButton.waitForPopover();
 await expect(chatButton).toHaveText('🌐Chat is ON');
 await expect(languageButton).toHaveText('🌍Language: EN');

 await notificationsButton.click();
 await u.po.userButton.waitForPopoverClosed();
 await u.po.userButton.toggleTrigger();
 await u.po.userButton.waitForPopover();
 await expect(notificationsButton).toHaveText('🌐Notifications 🔔 ON');
Expand DownExpand Up@@ -508,6 +518,10 @@ testAgainstRunningApps({ withPattern: ['react.vite.withEmailCodes'] })(
 await expect(toggleButton.locator('span')).toHaveText('🔔');
 await toggleButton.click();

 // The action closes the popover with an exit animation that keeps it mounted until it
 // finishes; wait for the full close so the re-open doesn't race the exiting popover.
 await u.po.userButton.waitForPopoverClosed();

 // Re-open menu to see updated items
 await u.po.userButton.toggleTrigger();
 await u.po.userButton.waitForPopover();
Expand Down

5 changes: 4 additions & 1 deletion
packages/testing/src/playwright/unstable/page-objects/apiKeys.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -61,7 +61,10 @@ export const createAPIKeysComponentPageObject = (testArgs: { page: EnhancedPage
 return page.getByLabel(/Type "Revoke" to confirm/i).fill(value);
 },
 clickConfirmRevokeButton: () => {
 return page.getByText(/Revoke key/i).click();
 // Target the modal's submit button by its descriptor class rather than by text: the menu
 // action that opens this modal is also labelled "Revoke key", and it now lingers through an
 // exit animation, so a text locator transiently matches both (strict-mode violation).
 return page.locator('.cl-apiKeysRevokeModal .cl-apiKeysRevokeModalSubmitButton').click();
 },
 };
 return self;
Expand Down

2 changes: 1 addition & 1 deletion
packages/ui/bundlewatch.config.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -5,7 +5,7 @@
 { "path": "./dist/ui.shared.browser.js", "maxSize": "40KB" },
 { "path": "./dist/framework*.js", "maxSize": "44KB" },
 { "path": "./dist/vendors*.js", "maxSize": "73KB" },
 { "path": "./dist/ui-common*.js", "maxSize": "130KB" },
 { "path": "./dist/ui-common*.js", "maxSize": "132KB" },
 { "path": "./dist/signin*.js", "maxSize": "17KB" },
 { "path": "./dist/signup*.js", "maxSize": "13KB" },
 { "path": "./dist/userprofile*.js", "maxSize": "16KB" },
Expand Down

2 changes: 0 additions & 2 deletions
packages/ui/src/components/OrganizationSwitcher/OrganizationSwitcherPopover.tsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -23,7 +23,6 @@ export const OrganizationSwitcherPopover = React.forwardRef<HTMLDivElement, Orga
 const { close: unsafeClose, ...rest } = props;
 const close = () => unsafeClose?.(false);
 const card = useCardState();
 const { __experimental_asStandalone } = useOrganizationSwitcherContext();
 const { openOrganizationProfile, openCreateOrganization } = useClerk();
 const getContainer = usePortalRoot();
 const { organization: currentOrg } = useOrganization();
Expand DownExpand Up@@ -138,7 +137,6 @@ export const OrganizationSwitcherPopover = React.forwardRef<HTMLDivElement, Orga
 ref={ref}
 role='dialog'
 aria-label={`${currentOrg?.name} is active`}
 shouldEntryAnimate={!__experimental_asStandalone}
 {...rest}
 >
 <PopoverCard.Content elementDescriptor={descriptors.organizationSwitcherPopoverMain}>
Expand Down

2 changes: 1 addition & 1 deletion
packages/ui/src/components/OrganizationSwitcher/index.tsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -42,7 +42,7 @@ const OrganizationSwitcherWithFloatingTree = withFloatingTree<{ children: ReactE
 <Popover
 nodeId={nodeId}
 context={context}
isOpen={isOpen}
animateExit
 order={['content']}
 initialFocus={popoverRef}
 >
Expand Down

2 changes: 0 additions & 2 deletions
packages/ui/src/components/UserButton/UserButtonPopover.tsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -19,7 +19,6 @@ export const UserButtonPopover = React.forwardRef<HTMLDivElement, UserButtonPopo
 const close = () => unsafeClose?.(false);
 const { session } = useSession() as { session: SignedInSessionResource };
 const userButtonContext = useUserButtonContext();
 const { __experimental_asStandalone } = userButtonContext;
 const { authConfig } = useEnvironment();
 const { user } = useUser();
 const { t } = useLocalizations();
Expand All@@ -40,7 +39,6 @@ export const UserButtonPopover = React.forwardRef<HTMLDivElement, UserButtonPopo
 ref={ref}
 role='dialog'
 aria-label={t(localizationKeys('userButton.label__userButtonPopover'))}
 shouldEntryAnimate={!__experimental_asStandalone}
 {...rest}
 >
 <PopoverCard.Content elementDescriptor={descriptors.userButtonPopoverMain}>
Expand Down

2 changes: 1 addition & 1 deletion
packages/ui/src/components/UserButton/index.tsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -41,7 +41,7 @@ const UserButtonWithFloatingTree = withFloatingTree<{ children: ReactElement }>(
 <Popover
 nodeId={nodeId}
 context={context}
isOpen={isOpen}
animateExit
 order={['content']}
 initialFocus={popoverRef}
 >
Expand Down

31 changes: 16 additions & 15 deletions
packages/ui/src/elements/Menu.tsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -18,7 +18,6 @@ import { Col, descriptors, SimpleButton } from '../customizables';
import type { UsePopoverReturn } from '../hooks';
import { usePopover } from '../hooks';
import type { PropsOfComponent } from '../styledSystem';
import { animations } from '../styledSystem';
import { colors } from '../utils/colors';
import { withFloatingTree } from './contexts';
import { Popover } from './Popover';
Expand DownExpand Up@@ -124,20 +123,24 @@ type MenuListProps = PropsOfComponent<typeof Col> & {
export const MenuList = (props: MenuListProps) => {
 const { sx, asPortal, ...rest } = props;
 const { popoverCtx, elementId, getFloatingProps, elementsRef } = useMenuState();
 const { floating, styles, isOpen, context, nodeId } = popoverCtx;
 const { floating, styles, context, nodeId } = popoverCtx;
 const containerRef = useRef<HTMLDivElement | null>(null);
 const mergedRef = useMergeRefs([containerRef, floating]);

 // `FloatingList` only provides list-navigation context (no DOM), so it wraps the `Popover`
 // rather than nesting inside it — that keeps the `Col` as the `Popover`'s direct child, which is
 // the element the `animateExit` transition (origin-aware scale + fade) is applied to.
 return (
 <Popover
 context={context}
 nodeId={nodeId}
 isOpen={isOpen}
 portal={asPortal}
 order={['content']}
 modal={false}
 >
 <FloatingList elementsRef={elementsRef}>
 <FloatingList elementsRef={elementsRef}>
 <Popover
 context={context}
 nodeId={nodeId}
 animateExit
 initialScale={0.88}
 portal={asPortal}
 order={['content']}
 modal={false}
 >
 <Col
 elementDescriptor={descriptors.menuList}
 elementId={descriptors.menuList.setId(elementId)}
Expand All@@ -153,8 +156,6 @@ export const MenuList = (props: MenuListProps) => {
 padding: t.space.$0x5,
 overflow: 'hidden',
 top: `calc(100% + ${t.space.$2})`,
 animation: `${animations.dropdownSlideInScaleAndFade} ${t.transitionDuration.$slower} ${t.transitionTiming.$slowBezier}`,
 transformOrigin: 'top center',
 zIndex: t.zIndices.$dropdown,
 gap: t.space.$0x5,
 }),
Expand All@@ -164,8 +165,8 @@ export const MenuList = (props: MenuListProps) => {
 {...getFloatingProps()}
 {...rest}
 />
 </FloatingList>
 </Popover>
 </Popover>
 </FloatingList>
 );
};

Expand Down

1 change: 1 addition & 0 deletions
packages/ui/src/elements/PhoneInput/index.tsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -145,6 +145,7 @@ const PhoneInputBase = forwardRef<HTMLInputElement, PhoneInputProps & { feedback
 </Text>
 </SelectButton>
 <SelectOptionList
 initialScale={0.96}
 sx={{ padding: '0 0' }}
 containerSx={theme => ({
 gap: 0,
Expand Down

93 changes: 88 additions & 5 deletions
packages/ui/src/elements/Popover.tsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,14 +1,38 @@
import { usePortalRoot } from '@clerk/shared/react';
import type { FloatingContext, ReferenceType } from '@floating-ui/react';
import { FloatingFocusManager, FloatingNode, FloatingPortal } from '@floating-ui/react';
import { FloatingFocusManager, FloatingNode, FloatingPortal, useTransitionStyles } from '@floating-ui/react';
import type { PropsWithChildren } from 'react';
import React from 'react';

import { useAppearance } from '../customizables';
import { transitionDurationValues, transitionTiming } from '../foundations/transitions';
import { useDirection, usePrefersReducedMotion } from '../hooks';

type PopoverProps = PropsWithChildren<{
 context: FloatingContext<ReferenceType>;
 nodeId?: string;
 isOpen?: boolean;
 initialFocus?: number | React.MutableRefObject<HTMLElement | null>;
 /**
 * When `true`, the popover animates in on mount with an origin-aware scale + fade and stays
 * mounted through a matching fade-out on close, instead of appearing/unmounting instantly.
 * Opt-in so other consumers keep their current instant behavior.
 * @default false
 */
 animateExit?: boolean;
 /**
 * When `animateExit` is set, exits quickly (`$faster`, matching the entrance) instead of the
 * default soft exit (`$slower`). The entrance is always `$faster`.
 * @default false
 */
 exitFast?: boolean;
 /**
 * The scale the popover animates from on enter (and collapses to on exit) when `animateExit`
 * is set. Scale is proportional, so compact surfaces travel fewer pixels — lower this
 * (e.g. `0.92`) to give small popovers like menus a more pronounced motion.
 * @default 0.96
 */
 initialScale?: number;
 /**
 * Determines whether outside elements are inert when modal is enabled. This enables pointer modality without a backdrop.
 * @default false
Expand All@@ -30,6 +54,27 @@ type PopoverProps = PropsWithChildren<{
 root?: HTMLElement | React.MutableRefObject<HTMLElement | null>;
}>;

/**
 * Maps a resolved Floating UI placement to a `transform-origin` so the popover grows from the
 * point nearest its trigger. The primary axis anchors to the edge opposite the `side`; when the
 * placement is aligned to a corner (`-start` / `-end`) the cross axis hugs that corner, otherwise
 * it stays centered. Horizontal alignment is mirrored under RTL to match Floating UI's
 * direction-aware resolved position.
 */
const getTransformOrigin = (placement: string, direction: 'ltr' | 'rtl'): string => {
 const [side, alignment] = placement.split('-');
 if (side === 'top' || side === 'bottom') {
 const y = side === 'top' ? 'bottom' : 'top';
 const start = direction === 'rtl' ? 'right' : 'left';
 const end = direction === 'rtl' ? 'left' : 'right';
 const x = alignment === 'start' ? start : alignment === 'end' ? end : 'center';
 return `${x} ${y}`;
 }
 const x = side === 'left' ? 'right' : 'left';
 const y = alignment === 'start' ? 'top' : alignment === 'end' ? 'bottom' : 'center';
 return `${x} ${y}`;
};

export const Popover = (props: PopoverProps) => {
 const {
 context,
Expand All@@ -39,6 +84,9 @@ export const Popover = (props: PopoverProps) => {
 modal = true,
 nodeId,
 isOpen,
 animateExit = false,
 exitFast = false,
 initialScale = 0.96,
 portal = true,
 root,
 children,
Expand All@@ -47,19 +95,53 @@ export const Popover = (props: PopoverProps) => {
 const portalRoot = usePortalRoot();
 const effectiveRoot = root ?? portalRoot?.() ?? undefined;

 const prefersReducedMotion = usePrefersReducedMotion();
 const direction = useDirection();
 const { animations: layoutAnimations } = useAppearance().parsedOptions;
 const isMotionSafe = !prefersReducedMotion && layoutAnimations === true;
 const animate = animateExit && isMotionSafe;
 const closeDuration = exitFast ? transitionDurationValues.faster : transitionDurationValues.slower;

 // Animate in on mount and out on close with an origin-aware scale + fade. Keeping the element
 // mounted through the close transition (via `isMounted`) is what makes the exit animation
 // possible. `transformOrigin` is derived from the resolved placement so the popover grows from
 // the point nearest its trigger — the aligned corner when present, otherwise the edge center.
 const { isMounted, styles: transitionStyles } = useTransitionStyles(context, {
 duration: {
 open: animate ? transitionDurationValues.faster : 0,
 close: animate ? closeDuration : 0,
 },
 common: ({ placement }) => ({
 transformOrigin: getTransformOrigin(placement, direction),
 transitionTimingFunction: transitionTiming.swiftOut,
 }),
 initial: { opacity: animate ? 0 : 1, transform: animate ? `scale(${initialScale})` : 'scale(1)' },
 open: { opacity: 1, transform: 'scale(1)' },
 close: { opacity: animate ? 0 : 1, transform: animate ? `scale(${initialScale})` : 'scale(1)' },
 });

 // Non-animating consumers keep the original synchronous `isOpen` unmount.
 const shouldRender = animateExit ? isMounted : isOpen;
 const content =
 animateExit && React.isValidElement<{ style?: React.CSSProperties }>(children)
 ? React.cloneElement(children, {
 style: { ...children.props.style, ...transitionStyles },
 })
 : children;

 if (portal) {
 return (
 <FloatingNode id={nodeId}>
 <FloatingPortal root={effectiveRoot}>
 {isOpen && (
 {shouldRender && (
 <FloatingFocusManager
 context={context}
 initialFocus={initialFocus}
 outsideElementsInert={outsideElementsInert}
 order={order}
 modal={modal}
 >
 <>{children}</>
 <>{content}</>
 </FloatingFocusManager>
 )}
 </FloatingPortal>
Expand All@@ -69,14 +151,15 @@ export const Popover = (props: PopoverProps) => {

 return (
 <FloatingNode id={nodeId}>
 {isOpen && (
 {shouldRender && (
 <FloatingFocusManager
 context={context}
 initialFocus={initialFocus}
 outsideElementsInert={outsideElementsInert}
 order={order}
 modal={modal}
 >
 <>{children}</>
 <>{content}</>
Comment thread
maxyinger marked this conversation as resolved.

 </FloatingFocusManager>
 )}
 </FloatingNode>
Expand Down
Loading
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
[WIP] feat(ui): Origin-aware open/close animations for popover menus and selects#9113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Closed

maxyinger
wants to merge
8
commits into

from

 Closed


[WIP] feat(ui): Origin-aware open/close animations for popover menus and selects
#9113
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


8 commits


Select commit
Hold shift + click to select a range
ad67576

snappier in. fade out. new new


maxyinger Jul 9, 2026
5857315

animation refinements


maxyinger Jul 9, 2026
3c7be4d

update origin, add select and menu transitions


maxyinger Jul 9, 2026
b9fd172

fix dropped prop and bump ui common cieling


maxyinger Jul 9, 2026
a934f08

fix unit tests


maxyinger Jul 9, 2026
f489835

fix integration tests


maxyinger Jul 9, 2026
bbe573c

cleanup


maxyinger Jul 9, 2026
ab7d076

more integration fixes


maxyinger Jul 9, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


5 changes: 5 additions & 0 deletions
.changeset/popover-enter-exit-animations.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
---
'@clerk/ui': patch
---

Popover-based surfaces now open and close with an origin-aware scale-and-fade that grows from the edge nearest the trigger, replacing the previous entrance-only slide animation. This covers the `<OrganizationSwitcher />` / `<UserButton />` menus, the overflow (⋯) menus, and selects — menus keep a quick-in / soft-out feel while selects use a quicker exit. Motion is disabled when `appearance.animations` is `false` or the user prefers reduced motion.

14 changes: 14 additions & 0 deletions
integration/tests/custom-pages.test.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -405,14 +405,19 @@ testAgainstRunningApps({ withPattern: ['react.vite.withEmailCodes'] })(
 const notificationsButton = buttons[2];
 const languageButton = buttons[3];

 // Clicking an action closes the popover, which now plays an exit animation and stays
 // mounted until it finishes — wait for it to fully close before re-opening, otherwise
 // the re-open races the still-visible exiting popover.
 // Test chat toggle
 await chatButton.click();
 await u.po.userButton.waitForPopoverClosed();
 await u.po.userButton.toggleTrigger();
 await u.po.userButton.waitForPopover();
 await expect(chatButton).toHaveText('🌐Chat is ON');
 await expect(languageButton).toHaveText('🌍Language: EN');

 await notificationsButton.click();
 await u.po.userButton.waitForPopoverClosed();
 await u.po.userButton.toggleTrigger();
 await u.po.userButton.waitForPopover();
 await expect(notificationsButton).toHaveText('🌐Notifications 🔔 ON');
Expand DownExpand Up@@ -460,14 +465,19 @@ testAgainstRunningApps({ withPattern: ['react.vite.withEmailCodes'] })(
 const languageButton = buttons[3];
 const manageAccountButton = buttons[4];

 // Clicking an action closes the popover, which now plays an exit animation and stays
 // mounted until it finishes — wait for it to fully close before re-opening, otherwise
 // the re-open races the still-visible exiting popover.
 // Test chat toggle
 await chatButton.click();
 await u.po.userButton.waitForPopoverClosed();
 await u.po.userButton.toggleTrigger();
 await u.po.userButton.waitForPopover();
 await expect(chatButton).toHaveText('🌐Chat is ON');
 await expect(languageButton).toHaveText('🌍Language: EN');

 await notificationsButton.click();
 await u.po.userButton.waitForPopoverClosed();
 await u.po.userButton.toggleTrigger();
 await u.po.userButton.waitForPopover();
 await expect(notificationsButton).toHaveText('🌐Notifications 🔔 ON');
Expand DownExpand Up@@ -508,6 +518,10 @@ testAgainstRunningApps({ withPattern: ['react.vite.withEmailCodes'] })(
 await expect(toggleButton.locator('span')).toHaveText('🔔');
 await toggleButton.click();

 // The action closes the popover with an exit animation that keeps it mounted until it
 // finishes; wait for the full close so the re-open doesn't race the exiting popover.
 await u.po.userButton.waitForPopoverClosed();

 // Re-open menu to see updated items
 await u.po.userButton.toggleTrigger();
 await u.po.userButton.waitForPopover();
Expand Down

5 changes: 4 additions & 1 deletion
packages/testing/src/playwright/unstable/page-objects/apiKeys.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -61,7 +61,10 @@ export const createAPIKeysComponentPageObject = (testArgs: { page: EnhancedPage
 return page.getByLabel(/Type "Revoke" to confirm/i).fill(value);
 },
 clickConfirmRevokeButton: () => {
 return page.getByText(/Revoke key/i).click();
 // Target the modal's submit button by its descriptor class rather than by text: the menu
 // action that opens this modal is also labelled "Revoke key", and it now lingers through an
 // exit animation, so a text locator transiently matches both (strict-mode violation).
 return page.locator('.cl-apiKeysRevokeModal .cl-apiKeysRevokeModalSubmitButton').click();
 },
 };
 return self;
Expand Down

2 changes: 1 addition & 1 deletion
packages/ui/bundlewatch.config.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -5,7 +5,7 @@
 { "path": "./dist/ui.shared.browser.js", "maxSize": "40KB" },
 { "path": "./dist/framework*.js", "maxSize": "44KB" },
 { "path": "./dist/vendors*.js", "maxSize": "73KB" },
 { "path": "./dist/ui-common*.js", "maxSize": "130KB" },
 { "path": "./dist/ui-common*.js", "maxSize": "132KB" },
 { "path": "./dist/signin*.js", "maxSize": "17KB" },
 { "path": "./dist/signup*.js", "maxSize": "13KB" },
 { "path": "./dist/userprofile*.js", "maxSize": "16KB" },
Expand Down

2 changes: 0 additions & 2 deletions
packages/ui/src/components/OrganizationSwitcher/OrganizationSwitcherPopover.tsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -23,7 +23,6 @@ export const OrganizationSwitcherPopover = React.forwardRef<HTMLDivElement, Orga
 const { close: unsafeClose, ...rest } = props;
 const close = () => unsafeClose?.(false);
 const card = useCardState();
 const { __experimental_asStandalone } = useOrganizationSwitcherContext();
 const { openOrganizationProfile, openCreateOrganization } = useClerk();
 const getContainer = usePortalRoot();
 const { organization: currentOrg } = useOrganization();
Expand DownExpand Up@@ -138,7 +137,6 @@ export const OrganizationSwitcherPopover = React.forwardRef<HTMLDivElement, Orga
 ref={ref}
 role='dialog'
 aria-label={`${currentOrg?.name} is active`}
 shouldEntryAnimate={!__experimental_asStandalone}
 {...rest}
 >
 <PopoverCard.Content elementDescriptor={descriptors.organizationSwitcherPopoverMain}>
Expand Down

2 changes: 1 addition & 1 deletion
packages/ui/src/components/OrganizationSwitcher/index.tsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -42,7 +42,7 @@ const OrganizationSwitcherWithFloatingTree = withFloatingTree<{ children: ReactE
 <Popover
 nodeId={nodeId}
 context={context}
isOpen={isOpen}
animateExit
 order={['content']}
 initialFocus={popoverRef}
 >
Expand Down

2 changes: 0 additions & 2 deletions
packages/ui/src/components/UserButton/UserButtonPopover.tsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -19,7 +19,6 @@ export const UserButtonPopover = React.forwardRef<HTMLDivElement, UserButtonPopo
 const close = () => unsafeClose?.(false);
 const { session } = useSession() as { session: SignedInSessionResource };
 const userButtonContext = useUserButtonContext();
 const { __experimental_asStandalone } = userButtonContext;
 const { authConfig } = useEnvironment();
 const { user } = useUser();
 const { t } = useLocalizations();
Expand All@@ -40,7 +39,6 @@ export const UserButtonPopover = React.forwardRef<HTMLDivElement, UserButtonPopo
 ref={ref}
 role='dialog'
 aria-label={t(localizationKeys('userButton.label__userButtonPopover'))}
 shouldEntryAnimate={!__experimental_asStandalone}
 {...rest}
 >
 <PopoverCard.Content elementDescriptor={descriptors.userButtonPopoverMain}>
Expand Down

2 changes: 1 addition & 1 deletion
packages/ui/src/components/UserButton/index.tsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -41,7 +41,7 @@ const UserButtonWithFloatingTree = withFloatingTree<{ children: ReactElement }>(
 <Popover
 nodeId={nodeId}
 context={context}
isOpen={isOpen}
animateExit
 order={['content']}
 initialFocus={popoverRef}
 >
Expand Down

31 changes: 16 additions & 15 deletions
packages/ui/src/elements/Menu.tsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -18,7 +18,6 @@ import { Col, descriptors, SimpleButton } from '../customizables';
import type { UsePopoverReturn } from '../hooks';
import { usePopover } from '../hooks';
import type { PropsOfComponent } from '../styledSystem';
import { animations } from '../styledSystem';
import { colors } from '../utils/colors';
import { withFloatingTree } from './contexts';
import { Popover } from './Popover';
Expand DownExpand Up@@ -124,20 +123,24 @@ type MenuListProps = PropsOfComponent<typeof Col> & {
export const MenuList = (props: MenuListProps) => {
 const { sx, asPortal, ...rest } = props;
 const { popoverCtx, elementId, getFloatingProps, elementsRef } = useMenuState();
 const { floating, styles, isOpen, context, nodeId } = popoverCtx;
 const { floating, styles, context, nodeId } = popoverCtx;
 const containerRef = useRef<HTMLDivElement | null>(null);
 const mergedRef = useMergeRefs([containerRef, floating]);

 // `FloatingList` only provides list-navigation context (no DOM), so it wraps the `Popover`
 // rather than nesting inside it — that keeps the `Col` as the `Popover`'s direct child, which is
 // the element the `animateExit` transition (origin-aware scale + fade) is applied to.
 return (
 <Popover
 context={context}
 nodeId={nodeId}
 isOpen={isOpen}
 portal={asPortal}
 order={['content']}
 modal={false}
 >
 <FloatingList elementsRef={elementsRef}>
 <FloatingList elementsRef={elementsRef}>
 <Popover
 context={context}
 nodeId={nodeId}
 animateExit
 initialScale={0.88}
 portal={asPortal}
 order={['content']}
 modal={false}
 >
 <Col
 elementDescriptor={descriptors.menuList}
 elementId={descriptors.menuList.setId(elementId)}
Expand All@@ -153,8 +156,6 @@ export const MenuList = (props: MenuListProps) => {
 padding: t.space.$0x5,
 overflow: 'hidden',
 top: `calc(100% + ${t.space.$2})`,
 animation: `${animations.dropdownSlideInScaleAndFade} ${t.transitionDuration.$slower} ${t.transitionTiming.$slowBezier}`,
 transformOrigin: 'top center',
 zIndex: t.zIndices.$dropdown,
 gap: t.space.$0x5,
 }),
Expand All@@ -164,8 +165,8 @@ export const MenuList = (props: MenuListProps) => {
 {...getFloatingProps()}
 {...rest}
 />
 </FloatingList>
 </Popover>
 </Popover>
 </FloatingList>
 );
};

Expand Down

1 change: 1 addition & 0 deletions
packages/ui/src/elements/PhoneInput/index.tsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -145,6 +145,7 @@ const PhoneInputBase = forwardRef<HTMLInputElement, PhoneInputProps & { feedback
 </Text>
 </SelectButton>
 <SelectOptionList
 initialScale={0.96}
 sx={{ padding: '0 0' }}
 containerSx={theme => ({
 gap: 0,
Expand Down

93 changes: 88 additions & 5 deletions
packages/ui/src/elements/Popover.tsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,14 +1,38 @@
import { usePortalRoot } from '@clerk/shared/react';
import type { FloatingContext, ReferenceType } from '@floating-ui/react';
import { FloatingFocusManager, FloatingNode, FloatingPortal } from '@floating-ui/react';
import { FloatingFocusManager, FloatingNode, FloatingPortal, useTransitionStyles } from '@floating-ui/react';
import type { PropsWithChildren } from 'react';
import React from 'react';

import { useAppearance } from '../customizables';
import { transitionDurationValues, transitionTiming } from '../foundations/transitions';
import { useDirection, usePrefersReducedMotion } from '../hooks';

type PopoverProps = PropsWithChildren<{
 context: FloatingContext<ReferenceType>;
 nodeId?: string;
 isOpen?: boolean;
 initialFocus?: number | React.MutableRefObject<HTMLElement | null>;
 /**
 * When `true`, the popover animates in on mount with an origin-aware scale + fade and stays
 * mounted through a matching fade-out on close, instead of appearing/unmounting instantly.
 * Opt-in so other consumers keep their current instant behavior.
 * @default false
 */
 animateExit?: boolean;
 /**
 * When `animateExit` is set, exits quickly (`$faster`, matching the entrance) instead of the
 * default soft exit (`$slower`). The entrance is always `$faster`.
 * @default false
 */
 exitFast?: boolean;
 /**
 * The scale the popover animates from on enter (and collapses to on exit) when `animateExit`
 * is set. Scale is proportional, so compact surfaces travel fewer pixels — lower this
 * (e.g. `0.92`) to give small popovers like menus a more pronounced motion.
 * @default 0.96
 */
 initialScale?: number;
 /**
 * Determines whether outside elements are inert when modal is enabled. This enables pointer modality without a backdrop.
 * @default false
Expand All@@ -30,6 +54,27 @@ type PopoverProps = PropsWithChildren<{
 root?: HTMLElement | React.MutableRefObject<HTMLElement | null>;
}>;

/**
 * Maps a resolved Floating UI placement to a `transform-origin` so the popover grows from the
 * point nearest its trigger. The primary axis anchors to the edge opposite the `side`; when the
 * placement is aligned to a corner (`-start` / `-end`) the cross axis hugs that corner, otherwise
 * it stays centered. Horizontal alignment is mirrored under RTL to match Floating UI's
 * direction-aware resolved position.
 */
const getTransformOrigin = (placement: string, direction: 'ltr' | 'rtl'): string => {
 const [side, alignment] = placement.split('-');
 if (side === 'top' || side === 'bottom') {
 const y = side === 'top' ? 'bottom' : 'top';
 const start = direction === 'rtl' ? 'right' : 'left';
 const end = direction === 'rtl' ? 'left' : 'right';
 const x = alignment === 'start' ? start : alignment === 'end' ? end : 'center';
 return `${x} ${y}`;
 }
 const x = side === 'left' ? 'right' : 'left';
 const y = alignment === 'start' ? 'top' : alignment === 'end' ? 'bottom' : 'center';
 return `${x} ${y}`;
};

export const Popover = (props: PopoverProps) => {
 const {
 context,
Expand All@@ -39,6 +84,9 @@ export const Popover = (props: PopoverProps) => {
 modal = true,
 nodeId,
 isOpen,
 animateExit = false,
 exitFast = false,
 initialScale = 0.96,
 portal = true,
 root,
 children,
Expand All@@ -47,19 +95,53 @@ export const Popover = (props: PopoverProps) => {
 const portalRoot = usePortalRoot();
 const effectiveRoot = root ?? portalRoot?.() ?? undefined;

 const prefersReducedMotion = usePrefersReducedMotion();
 const direction = useDirection();
 const { animations: layoutAnimations } = useAppearance().parsedOptions;
 const isMotionSafe = !prefersReducedMotion && layoutAnimations === true;
 const animate = animateExit && isMotionSafe;
 const closeDuration = exitFast ? transitionDurationValues.faster : transitionDurationValues.slower;

 // Animate in on mount and out on close with an origin-aware scale + fade. Keeping the element
 // mounted through the close transition (via `isMounted`) is what makes the exit animation
 // possible. `transformOrigin` is derived from the resolved placement so the popover grows from
 // the point nearest its trigger — the aligned corner when present, otherwise the edge center.
 const { isMounted, styles: transitionStyles } = useTransitionStyles(context, {
 duration: {
 open: animate ? transitionDurationValues.faster : 0,
 close: animate ? closeDuration : 0,
 },
 common: ({ placement }) => ({
 transformOrigin: getTransformOrigin(placement, direction),
 transitionTimingFunction: transitionTiming.swiftOut,
 }),
 initial: { opacity: animate ? 0 : 1, transform: animate ? `scale(${initialScale})` : 'scale(1)' },
 open: { opacity: 1, transform: 'scale(1)' },
 close: { opacity: animate ? 0 : 1, transform: animate ? `scale(${initialScale})` : 'scale(1)' },
 });

 // Non-animating consumers keep the original synchronous `isOpen` unmount.
 const shouldRender = animateExit ? isMounted : isOpen;
 const content =
 animateExit && React.isValidElement<{ style?: React.CSSProperties }>(children)
 ? React.cloneElement(children, {
 style: { ...children.props.style, ...transitionStyles },
 })
 : children;

 if (portal) {
 return (
 <FloatingNode id={nodeId}>
 <FloatingPortal root={effectiveRoot}>
 {isOpen && (
 {shouldRender && (
 <FloatingFocusManager
 context={context}
 initialFocus={initialFocus}
 outsideElementsInert={outsideElementsInert}
 order={order}
 modal={modal}
 >
 <>{children}</>
 <>{content}</>
 </FloatingFocusManager>
 )}
 </FloatingPortal>
Expand All@@ -69,14 +151,15 @@ export const Popover = (props: PopoverProps) => {

 return (
 <FloatingNode id={nodeId}>
 {isOpen && (
 {shouldRender && (
 <FloatingFocusManager
 context={context}
 initialFocus={initialFocus}
 outsideElementsInert={outsideElementsInert}
 order={order}
 modal={modal}
 >
 <>{children}</>
 <>{content}</>
Comment thread
maxyinger marked this conversation as resolved.

 </FloatingFocusManager>
 )}
 </FloatingNode>
Expand Down
Loading
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
[WIP] feat(ui): Origin-aware open/close animations for popover menus and selects#9113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Closed

maxyinger
wants to merge
8
commits into

from

 Closed


[WIP] feat(ui): Origin-aware open/close animations for popover menus and selects
#9113
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


8 commits


Select commit
Hold shift + click to select a range
ad67576

snappier in. fade out. new new


maxyinger Jul 9, 2026
5857315

animation refinements


maxyinger Jul 9, 2026
3c7be4d

update origin, add select and menu transitions


maxyinger Jul 9, 2026
b9fd172

fix dropped prop and bump ui common cieling


maxyinger Jul 9, 2026
a934f08

fix unit tests


maxyinger Jul 9, 2026
f489835

fix integration tests


maxyinger Jul 9, 2026
bbe573c

cleanup


maxyinger Jul 9, 2026
ab7d076

more integration fixes


maxyinger Jul 9, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


5 changes: 5 additions & 0 deletions
.changeset/popover-enter-exit-animations.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
---
'@clerk/ui': patch
---

Popover-based surfaces now open and close with an origin-aware scale-and-fade that grows from the edge nearest the trigger, replacing the previous entrance-only slide animation. This covers the `<OrganizationSwitcher />` / `<UserButton />` menus, the overflow (⋯) menus, and selects — menus keep a quick-in / soft-out feel while selects use a quicker exit. Motion is disabled when `appearance.animations` is `false` or the user prefers reduced motion.

14 changes: 14 additions & 0 deletions
integration/tests/custom-pages.test.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -405,14 +405,19 @@ testAgainstRunningApps({ withPattern: ['react.vite.withEmailCodes'] })(
 const notificationsButton = buttons[2];
 const languageButton = buttons[3];

 // Clicking an action closes the popover, which now plays an exit animation and stays
 // mounted until it finishes — wait for it to fully close before re-opening, otherwise
 // the re-open races the still-visible exiting popover.
 // Test chat toggle
 await chatButton.click();
 await u.po.userButton.waitForPopoverClosed();
 await u.po.userButton.toggleTrigger();
 await u.po.userButton.waitForPopover();
 await expect(chatButton).toHaveText('🌐Chat is ON');
 await expect(languageButton).toHaveText('🌍Language: EN');

 await notificationsButton.click();
 await u.po.userButton.waitForPopoverClosed();
 await u.po.userButton.toggleTrigger();
 await u.po.userButton.waitForPopover();
 await expect(notificationsButton).toHaveText('🌐Notifications 🔔 ON');
Expand DownExpand Up@@ -460,14 +465,19 @@ testAgainstRunningApps({ withPattern: ['react.vite.withEmailCodes'] })(
 const languageButton = buttons[3];
 const manageAccountButton = buttons[4];

 // Clicking an action closes the popover, which now plays an exit animation and stays
 // mounted until it finishes — wait for it to fully close before re-opening, otherwise
 // the re-open races the still-visible exiting popover.
 // Test chat toggle
 await chatButton.click();
 await u.po.userButton.waitForPopoverClosed();
 await u.po.userButton.toggleTrigger();
 await u.po.userButton.waitForPopover();
 await expect(chatButton).toHaveText('🌐Chat is ON');
 await expect(languageButton).toHaveText('🌍Language: EN');

 await notificationsButton.click();
 await u.po.userButton.waitForPopoverClosed();
 await u.po.userButton.toggleTrigger();
 await u.po.userButton.waitForPopover();
 await expect(notificationsButton).toHaveText('🌐Notifications 🔔 ON');
Expand DownExpand Up@@ -508,6 +518,10 @@ testAgainstRunningApps({ withPattern: ['react.vite.withEmailCodes'] })(
 await expect(toggleButton.locator('span')).toHaveText('🔔');
 await toggleButton.click();

 // The action closes the popover with an exit animation that keeps it mounted until it
 // finishes; wait for the full close so the re-open doesn't race the exiting popover.
 await u.po.userButton.waitForPopoverClosed();

 // Re-open menu to see updated items
 await u.po.userButton.toggleTrigger();
 await u.po.userButton.waitForPopover();
Expand Down

5 changes: 4 additions & 1 deletion
packages/testing/src/playwright/unstable/page-objects/apiKeys.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -61,7 +61,10 @@ export const createAPIKeysComponentPageObject = (testArgs: { page: EnhancedPage
 return page.getByLabel(/Type "Revoke" to confirm/i).fill(value);
 },
 clickConfirmRevokeButton: () => {
 return page.getByText(/Revoke key/i).click();
 // Target the modal's submit button by its descriptor class rather than by text: the menu
 // action that opens this modal is also labelled "Revoke key", and it now lingers through an
 // exit animation, so a text locator transiently matches both (strict-mode violation).
 return page.locator('.cl-apiKeysRevokeModal .cl-apiKeysRevokeModalSubmitButton').click();
 },
 };
 return self;
Expand Down

2 changes: 1 addition & 1 deletion
packages/ui/bundlewatch.config.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -5,7 +5,7 @@
 { "path": "./dist/ui.shared.browser.js", "maxSize": "40KB" },
 { "path": "./dist/framework*.js", "maxSize": "44KB" },
 { "path": "./dist/vendors*.js", "maxSize": "73KB" },
 { "path": "./dist/ui-common*.js", "maxSize": "130KB" },
 { "path": "./dist/ui-common*.js", "maxSize": "132KB" },
 { "path": "./dist/signin*.js", "maxSize": "17KB" },
 { "path": "./dist/signup*.js", "maxSize": "13KB" },
 { "path": "./dist/userprofile*.js", "maxSize": "16KB" },
Expand Down

2 changes: 0 additions & 2 deletions
packages/ui/src/components/OrganizationSwitcher/OrganizationSwitcherPopover.tsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -23,7 +23,6 @@ export const OrganizationSwitcherPopover = React.forwardRef<HTMLDivElement, Orga
 const { close: unsafeClose, ...rest } = props;
 const close = () => unsafeClose?.(false);
 const card = useCardState();
 const { __experimental_asStandalone } = useOrganizationSwitcherContext();
 const { openOrganizationProfile, openCreateOrganization } = useClerk();
 const getContainer = usePortalRoot();
 const { organization: currentOrg } = useOrganization();
Expand DownExpand Up@@ -138,7 +137,6 @@ export const OrganizationSwitcherPopover = React.forwardRef<HTMLDivElement, Orga
 ref={ref}
 role='dialog'
 aria-label={`${currentOrg?.name} is active`}
 shouldEntryAnimate={!__experimental_asStandalone}
 {...rest}
 >
 <PopoverCard.Content elementDescriptor={descriptors.organizationSwitcherPopoverMain}>
Expand Down

2 changes: 1 addition & 1 deletion
packages/ui/src/components/OrganizationSwitcher/index.tsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -42,7 +42,7 @@ const OrganizationSwitcherWithFloatingTree = withFloatingTree<{ children: ReactE
 <Popover
 nodeId={nodeId}
 context={context}
isOpen={isOpen}
animateExit
 order={['content']}
 initialFocus={popoverRef}
 >
Expand Down

2 changes: 0 additions & 2 deletions
packages/ui/src/components/UserButton/UserButtonPopover.tsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -19,7 +19,6 @@ export const UserButtonPopover = React.forwardRef<HTMLDivElement, UserButtonPopo
 const close = () => unsafeClose?.(false);
 const { session } = useSession() as { session: SignedInSessionResource };
 const userButtonContext = useUserButtonContext();
 const { __experimental_asStandalone } = userButtonContext;
 const { authConfig } = useEnvironment();
 const { user } = useUser();
 const { t } = useLocalizations();
Expand All@@ -40,7 +39,6 @@ export const UserButtonPopover = React.forwardRef<HTMLDivElement, UserButtonPopo
 ref={ref}
 role='dialog'
 aria-label={t(localizationKeys('userButton.label__userButtonPopover'))}
 shouldEntryAnimate={!__experimental_asStandalone}
 {...rest}
 >
 <PopoverCard.Content elementDescriptor={descriptors.userButtonPopoverMain}>
Expand Down

2 changes: 1 addition & 1 deletion
packages/ui/src/components/UserButton/index.tsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -41,7 +41,7 @@ const UserButtonWithFloatingTree = withFloatingTree<{ children: ReactElement }>(
 <Popover
 nodeId={nodeId}
 context={context}
isOpen={isOpen}
animateExit
 order={['content']}
 initialFocus={popoverRef}
 >
Expand Down

31 changes: 16 additions & 15 deletions
packages/ui/src/elements/Menu.tsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -18,7 +18,6 @@ import { Col, descriptors, SimpleButton } from '../customizables';
import type { UsePopoverReturn } from '../hooks';
import { usePopover } from '../hooks';
import type { PropsOfComponent } from '../styledSystem';
import { animations } from '../styledSystem';
import { colors } from '../utils/colors';
import { withFloatingTree } from './contexts';
import { Popover } from './Popover';
Expand DownExpand Up@@ -124,20 +123,24 @@ type MenuListProps = PropsOfComponent<typeof Col> & {
export const MenuList = (props: MenuListProps) => {
 const { sx, asPortal, ...rest } = props;
 const { popoverCtx, elementId, getFloatingProps, elementsRef } = useMenuState();
 const { floating, styles, isOpen, context, nodeId } = popoverCtx;
 const { floating, styles, context, nodeId } = popoverCtx;
 const containerRef = useRef<HTMLDivElement | null>(null);
 const mergedRef = useMergeRefs([containerRef, floating]);

 // `FloatingList` only provides list-navigation context (no DOM), so it wraps the `Popover`
 // rather than nesting inside it — that keeps the `Col` as the `Popover`'s direct child, which is
 // the element the `animateExit` transition (origin-aware scale + fade) is applied to.
 return (
 <Popover
 context={context}
 nodeId={nodeId}
 isOpen={isOpen}
 portal={asPortal}
 order={['content']}
 modal={false}
 >
 <FloatingList elementsRef={elementsRef}>
 <FloatingList elementsRef={elementsRef}>
 <Popover
 context={context}
 nodeId={nodeId}
 animateExit
 initialScale={0.88}
 portal={asPortal}
 order={['content']}
 modal={false}
 >
 <Col
 elementDescriptor={descriptors.menuList}
 elementId={descriptors.menuList.setId(elementId)}
Expand All@@ -153,8 +156,6 @@ export const MenuList = (props: MenuListProps) => {
 padding: t.space.$0x5,
 overflow: 'hidden',
 top: `calc(100% + ${t.space.$2})`,
 animation: `${animations.dropdownSlideInScaleAndFade} ${t.transitionDuration.$slower} ${t.transitionTiming.$slowBezier}`,
 transformOrigin: 'top center',
 zIndex: t.zIndices.$dropdown,
 gap: t.space.$0x5,
 }),
Expand All@@ -164,8 +165,8 @@ export const MenuList = (props: MenuListProps) => {
 {...getFloatingProps()}
 {...rest}
 />
 </FloatingList>
 </Popover>
 </Popover>
 </FloatingList>
 );
};

Expand Down

1 change: 1 addition & 0 deletions
packages/ui/src/elements/PhoneInput/index.tsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -145,6 +145,7 @@ const PhoneInputBase = forwardRef<HTMLInputElement, PhoneInputProps & { feedback
 </Text>
 </SelectButton>
 <SelectOptionList
 initialScale={0.96}
 sx={{ padding: '0 0' }}
 containerSx={theme => ({
 gap: 0,
Expand Down

93 changes: 88 additions & 5 deletions
packages/ui/src/elements/Popover.tsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,14 +1,38 @@
import { usePortalRoot } from '@clerk/shared/react';
import type { FloatingContext, ReferenceType } from '@floating-ui/react';
import { FloatingFocusManager, FloatingNode, FloatingPortal } from '@floating-ui/react';
import { FloatingFocusManager, FloatingNode, FloatingPortal, useTransitionStyles } from '@floating-ui/react';
import type { PropsWithChildren } from 'react';
import React from 'react';

import { useAppearance } from '../customizables';
import { transitionDurationValues, transitionTiming } from '../foundations/transitions';
import { useDirection, usePrefersReducedMotion } from '../hooks';

type PopoverProps = PropsWithChildren<{
 context: FloatingContext<ReferenceType>;
 nodeId?: string;
 isOpen?: boolean;
 initialFocus?: number | React.MutableRefObject<HTMLElement | null>;
 /**
 * When `true`, the popover animates in on mount with an origin-aware scale + fade and stays
 * mounted through a matching fade-out on close, instead of appearing/unmounting instantly.
 * Opt-in so other consumers keep their current instant behavior.
 * @default false
 */
 animateExit?: boolean;
 /**
 * When `animateExit` is set, exits quickly (`$faster`, matching the entrance) instead of the
 * default soft exit (`$slower`). The entrance is always `$faster`.
 * @default false
 */
 exitFast?: boolean;
 /**
 * The scale the popover animates from on enter (and collapses to on exit) when `animateExit`
 * is set. Scale is proportional, so compact surfaces travel fewer pixels — lower this
 * (e.g. `0.92`) to give small popovers like menus a more pronounced motion.
 * @default 0.96
 */
 initialScale?: number;
 /**
 * Determines whether outside elements are inert when modal is enabled. This enables pointer modality without a backdrop.
 * @default false
Expand All@@ -30,6 +54,27 @@ type PopoverProps = PropsWithChildren<{
 root?: HTMLElement | React.MutableRefObject<HTMLElement | null>;
}>;

/**
 * Maps a resolved Floating UI placement to a `transform-origin` so the popover grows from the
 * point nearest its trigger. The primary axis anchors to the edge opposite the `side`; when the
 * placement is aligned to a corner (`-start` / `-end`) the cross axis hugs that corner, otherwise
 * it stays centered. Horizontal alignment is mirrored under RTL to match Floating UI's
 * direction-aware resolved position.
 */
const getTransformOrigin = (placement: string, direction: 'ltr' | 'rtl'): string => {
 const [side, alignment] = placement.split('-');
 if (side === 'top' || side === 'bottom') {
 const y = side === 'top' ? 'bottom' : 'top';
 const start = direction === 'rtl' ? 'right' : 'left';
 const end = direction === 'rtl' ? 'left' : 'right';
 const x = alignment === 'start' ? start : alignment === 'end' ? end : 'center';
 return `${x} ${y}`;
 }
 const x = side === 'left' ? 'right' : 'left';
 const y = alignment === 'start' ? 'top' : alignment === 'end' ? 'bottom' : 'center';
 return `${x} ${y}`;
};

export const Popover = (props: PopoverProps) => {
 const {
 context,
Expand All@@ -39,6 +84,9 @@ export const Popover = (props: PopoverProps) => {
 modal = true,
 nodeId,
 isOpen,
 animateExit = false,
 exitFast = false,
 initialScale = 0.96,
 portal = true,
 root,
 children,
Expand All@@ -47,19 +95,53 @@ export const Popover = (props: PopoverProps) => {
 const portalRoot = usePortalRoot();
 const effectiveRoot = root ?? portalRoot?.() ?? undefined;

 const prefersReducedMotion = usePrefersReducedMotion();
 const direction = useDirection();
 const { animations: layoutAnimations } = useAppearance().parsedOptions;
 const isMotionSafe = !prefersReducedMotion && layoutAnimations === true;
 const animate = animateExit && isMotionSafe;
 const closeDuration = exitFast ? transitionDurationValues.faster : transitionDurationValues.slower;

 // Animate in on mount and out on close with an origin-aware scale + fade. Keeping the element
 // mounted through the close transition (via `isMounted`) is what makes the exit animation
 // possible. `transformOrigin` is derived from the resolved placement so the popover grows from
 // the point nearest its trigger — the aligned corner when present, otherwise the edge center.
 const { isMounted, styles: transitionStyles } = useTransitionStyles(context, {
 duration: {
 open: animate ? transitionDurationValues.faster : 0,
 close: animate ? closeDuration : 0,
 },
 common: ({ placement }) => ({
 transformOrigin: getTransformOrigin(placement, direction),
 transitionTimingFunction: transitionTiming.swiftOut,
 }),
 initial: { opacity: animate ? 0 : 1, transform: animate ? `scale(${initialScale})` : 'scale(1)' },
 open: { opacity: 1, transform: 'scale(1)' },
 close: { opacity: animate ? 0 : 1, transform: animate ? `scale(${initialScale})` : 'scale(1)' },
 });

 // Non-animating consumers keep the original synchronous `isOpen` unmount.
 const shouldRender = animateExit ? isMounted : isOpen;
 const content =
 animateExit && React.isValidElement<{ style?: React.CSSProperties }>(children)
 ? React.cloneElement(children, {
 style: { ...children.props.style, ...transitionStyles },
 })
 : children;

 if (portal) {
 return (
 <FloatingNode id={nodeId}>
 <FloatingPortal root={effectiveRoot}>
 {isOpen && (
 {shouldRender && (
 <FloatingFocusManager
 context={context}
 initialFocus={initialFocus}
 outsideElementsInert={outsideElementsInert}
 order={order}
 modal={modal}
 >
 <>{children}</>
 <>{content}</>
 </FloatingFocusManager>
 )}
 </FloatingPortal>
Expand All@@ -69,14 +151,15 @@ export const Popover = (props: PopoverProps) => {

 return (
 <FloatingNode id={nodeId}>
 {isOpen && (
 {shouldRender && (
 <FloatingFocusManager
 context={context}
 initialFocus={initialFocus}
 outsideElementsInert={outsideElementsInert}
 order={order}
 modal={modal}
 >
 <>{children}</>
 <>{content}</>
Comment thread
maxyinger marked this conversation as resolved.

 </FloatingFocusManager>
 )}
 </FloatingNode>
Expand Down
Loading
Loading