Uh oh!
There was an error while loading. Please reload this page.
feat(ui): add composed OrganizationProfile panels and section components - #9135
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository YAML (base), Repository UI (inherited) Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
8ffd832 to
480ab9bCompare9c766be to
29150faCompare29150fa to
d3d5f20Compare480ab9b to
30a2ce9Compare30a2ce9 to
b54f566Compared3d5f20 to
9165f7dCompareb54f566 to
c430eccCompare9165f7d to
54c0509Compare54c0509 to
72ab698Comparec430ecc to
bf2e82dCompare| ); | ||
| } | ||
| describe('UserProfileProvider wiring', () => { |
There was a problem hiding this comment.
These tests are leaning a bit too far towards testing implementation details for my liking. Would rather see tests that assert on the output of the components, e.g. what a user would see
There was a problem hiding this comment.
Reworked. Appearance + localization now assert rendered output (computed $primary500 color / visible French text) instead of probing context. Dropped the pure impl-detail probes (typeof navigate, currentPath decoupling, apiKeysProps/afterLeave context shape, weak !!mm). Kept getter-resolution + fallback: bundle-boundary contract with no user-visible surface. 269 lines removed.
72ab698 to
a323094Comparebf2e82d to
04936daComparea323094 to
af7f9a6Compared3a7fbe to
f3a1169Compareaf7f9a6 to
a73dcc6Compare…ileProvider Switch OrganizationProfileProvider to resolveComposedClerkRuntime, matching UserProfileProvider and dropping the inline `as any` environment read.
useRequirePage now gates its misuse error on isDevelopmentSDK; mark the fixture SDK as development so the outside-a-page throw test exercises that path.
Convert appearance/localization wiring tests to assert on rendered styles and text a user would see; drop implementation-detail context probes. Keep the moduleManager getter-resolution and fallback tests, which pin a bundle-boundary contract with no user-visible surface.
f3a1169 to
c0da01bCompareUh oh!
There was an error while loading. Please reload this page.
Stack 6/7. Composed
OrganizationProfilepanels and section components, plus the cross-provider wiring and style-cache-sharing tests (they need both providers, so they land here).Not yet wired to the public entrypoint.
Changesets live only on the release PR #9144; this PR carries none.
Stack
Reviewed as a stack. The 7 PRs merge bottom-up into release branch #9144, which integrates into
mainas a single unit.main(integration)@clerk/ui/experimental(public API)