Uh oh!
There was an error while loading. Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork 470
feat(ui): add UserButton controller#9185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Uh oh!
There was an error while loading. Please reload this page.
Merged
Changes from all commits
Commits
Show all changes
71 commits
Select commit
Hold shift + click to select a range
2e8e95a
feat(ui): add UserButton controller
alexcarpenter 6b3bd6f
feat(ui): add loading and busy states to UserButton
alexcarpenter 9ac7574
feat(ui): close the UserButton popover only when a workspace is picked
alexcarpenter 668dbf5
feat(ui): name the active workspace in the UserButton trigger
alexcarpenter 594c60f
refactor(ui): split the UserButton trigger label into two props
alexcarpenter 426181e
feat(ui): let combined UserButton lead with the organization or the a…
alexcarpenter 9274449
feat(ui): hand the UserButton its active organization and list loadin…
alexcarpenter 7b94f02
fix(ui): answer hasOrganizations from the user resource, before the l…
alexcarpenter bf99bd9
feat(ui): open the UserButton profiles as modals, routable by URL
alexcarpenter a4bbae0
feat(ui): portal the UserButton profile modals
alexcarpenter 4e91d5d
feat(ui): offer the personal workspace from the UserButton controller
alexcarpenter 5029a31
feat(ui): route the UserButton personal row with afterSelectPersonalUrl
alexcarpenter e89ca65
fix(ui): withhold the UserButton personal row where an organization i…
alexcarpenter 461f55e
feat(ui): let an app hide the UserButton personal workspace
alexcarpenter 2f0445a
fix(ui): gate UserButton create-organization on the user's permission
alexcarpenter 728bc01
feat(ui): open the create-organization modal from the UserButton
alexcarpenter bf065fe
feat(ui): open the invite-members modal from the Mosaic UserButton
alexcarpenter 588884e
fix(ui): identify the UserButton account the way Clerk does
alexcarpenter f1fd7aa
feat(ui): forward custom menu items through the connected UserButton
alexcarpenter 453a479
docs(ui): document the connected UserButton for the apps using it
alexcarpenter 846f499
fix(ui): render nothing from UserButton until Clerk answers
alexcarpenter e30d0d1
refactor(ui): drop comments the controller test names already carry
alexcarpenter db07d5c
refactor(ui): follow the renderTriggerBadge rename through the connec…
alexcarpenter 2a96d1d
fix(ui): wait for the environment before the user button reports ready
alexcarpenter 85e5cee
fix(ui): read the branding off the instance in the Mosaic UserButton
alexcarpenter 853af2d
fix(ui): follow the renderBranding rename through the UserButton cont…
alexcarpenter ec36261
docs(ui): trim the Mosaic UserButton comments to the non-obvious
alexcarpenter 4ce9b5b
fix(ui): route a switched Mosaic UserButton session to its pending task
alexcarpenter 354c697
feat(ui): add a fallback prop to the Mosaic UserButton
alexcarpenter 52d46a9
test(ui): cover the connected UserButton end to end
alexcarpenter 1abd31b
feat(ui): close the UserButton popover only when a workspace is picked
alexcarpenter 3fdbc56
test(ui): query the account menu trigger as a button
alexcarpenter 26e7609
refactor(ui): migrate the Mosaic Spinner to StyleX and give it a sm size
alexcarpenter d1ad37d
feat(ui): name the active workspace in the UserButton trigger
alexcarpenter 7b02c74
feat(ui): let combined UserButton lead with the organization or the a…
alexcarpenter 42213a2
test(ui): follow the UserButton active-organization contract in the c…
alexcarpenter a8a5446
test(ui): carry organizationMemberships on the connected UserButton u…
alexcarpenter f3c0355
fix(ui): hold the Mosaic UserButton surface still while an action runs
alexcarpenter 46c792b
test(ui): cover the UserButton profile modals end to end
alexcarpenter 5c678d9
feat(ui): close the UserButton popover behind whatever it opens
alexcarpenter 48f5c8d
test(ui): cover the UserButton personal workspace row end to end
alexcarpenter 1e5768b
test(ui): cover the named UserButton personal row end to end
alexcarpenter 828a586
test(ui): move UserButton rendering cases down to the view test
alexcarpenter 63c4cc9
feat(ui): forward mode to the connected UserButton
alexcarpenter a4a55df
test(ui): cover the UserButton create-organization modal end to end
alexcarpenter ae17882
test(ui): assert Invite opens the InviteMembers modal
alexcarpenter 0e6b0a5
test(ui): identify Alice's account row by her username
alexcarpenter 52b443e
test(ui): follow the join button's in-place spinner
alexcarpenter c3b8177
test(ui): cover a custom menu item end to end
alexcarpenter e9cb06e
fix(ui): make UserButton account-only where organizations are disabled
alexcarpenter 857c262
refactor(ui): drive the Mosaic UserButton popover from a state machine
alexcarpenter 0e61db8
refactor(ui): drop comments the integration assertions already carry
alexcarpenter 4c27315
refactor(ui): name the organization mode in full on the connected button
alexcarpenter 921d746
feat(ui): add custom UserProfile pages to the Mosaic UserButton
alexcarpenter e807555
chore(repo): consolidate the branch's changesets into one
alexcarpenter 62060ce
refactor(ui): colocate the user button's page hooks with the button
alexcarpenter aedfdbd
fix(ui): drop the Mosaic UserButton spinner hold when the action clos…
alexcarpenter ed9f99d
test(ui): follow the user button rows' aria-disabled through the inte…
alexcarpenter 39311a9
refactor(ui): name the Mosaic UserButton layers for their MVC roles v…
Ephem cc37bea
Prevent UserButton opening again on sign-in after sign-out
Ephem 968b7e7
Rename frozen -> frozenModel
Ephem 45adf07
Resolve controller status from the frozen model to avoid reverting to…
Ephem 0fbcd81
Update fallback jsdoc comment
Ephem 13ddc58
Await suggestion/invitation revalidation
Ephem 0fa16fe
Add afterSwitchSessionUrl prop
Ephem 6476273
Handle "No organization selected"
Ephem 025cfe3
Add comment with possibly missing props compared to old UserButton
Ephem dd14d63
Fix swingset formatting
Ephem c20f0dc
Refactor open/closed state to be a machine context value instead of a…
Ephem f4e55a3
Format
Ephem 7e5061c
Fix tests
Ephem File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Jump to file
Failed to load files.
Loading
Uh oh!
There was an error while loading. Please reload this page.
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,2 @@ | ||
| --- | ||
| --- | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,2 @@ | ||
| --- | ||
| --- |
9 changes: 6 additions & 3 deletions
9 packages/shared/src/react/hooks/useAttemptToEnableOrganizations.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
18 changes: 14 additions & 4 deletions
18 packages/ui/src/mosaic/components/button/submit-button.test.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
21 changes: 21 additions & 0 deletions
21 packages/ui/src/mosaic/hooks/__tests__/useSpinDelay.test.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Oops, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.