Skip to content

fix(expo): Resolve Android native modules optionally - #9203

Merged
wobsoriano merged 2 commits into
mainfrom
rob/fix-js-issue-9197
Jul 21, 2026
Merged

fix(expo): Resolve Android native modules optionally#9203
wobsoriano merged 2 commits into
mainfrom
rob/fix-js-issue-9197

Conversation

@wobsoriano

Copy link
Copy Markdown
Member

Description

On Android, the native module specs used requireNativeModule, which throws at import time. Since ClerkProvider imports that chain unconditionally, every Android app crashed at startup with Cannot find native module 'ClerkExpo' when the module wasn't compiled in (Expo Go), even for JavaScript-only flows.

iOS already used requireOptionalNativeModule. This makes Android match, letting the existing null guard degrade gracefully.

Fixes#9197

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

@changeset-bot

changeset-botBot commented Jul 21, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 2881086

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
NameType
@clerk/expoPatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel

vercelBot commented Jul 21, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxReadyReadyPreview, CommentJul 21, 2026 4:24am
swingsetReadyReadyPreview, CommentJul 21, 2026 4:24am

Request Review

@pkg-pr-new

pkg-pr-newBot commented Jul 21, 2026

Copy link
Copy Markdown

Open in StackBlitz

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@9203

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@9203

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@9203

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@9203

@clerk/electron

npm i https://pkg.pr.new/@clerk/electron@9203

@clerk/electron-passkeys

npm i https://pkg.pr.new/@clerk/electron-passkeys@9203

@clerk/eslint-plugin

npm i https://pkg.pr.new/@clerk/eslint-plugin@9203

@clerk/expo

npm i https://pkg.pr.new/@clerk/expo@9203

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@9203

@clerk/express

npm i https://pkg.pr.new/@clerk/express@9203

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@9203

@clerk/hono

npm i https://pkg.pr.new/@clerk/hono@9203

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@9203

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@9203

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@9203

@clerk/react

npm i https://pkg.pr.new/@clerk/react@9203

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@9203

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@9203

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@9203

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@9203

@clerk/ui

npm i https://pkg.pr.new/@clerk/ui@9203

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@9203

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@9203

commit: 2881086

@coderabbitai

coderabbitaiBot commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: 98b04413-ec95-46a4-a8dc-176d4870cf4a

📥 Commits

Reviewing files that changed from the base of the PR and between c112e5f and 2881086.

📒 Files selected for processing (2)
  • packages/expo/src/specs/NativeClerkGoogleSignIn.android.ts
  • packages/expo/src/specs/__tests__/androidSpecs.test.ts
🔗 Linked repositories identified

CodeRabbit considers these linked repositories for cross-repo context during reviews:

  • clerk/clerk_go(manual)
  • clerk/dashboard(manual)
  • clerk/accounts(manual)
  • clerk/backoffice(manual)
  • clerk/clerk(manual)
  • clerk/clerk-docs(manual)
  • clerk/cloudflare-workers(manual)
🚧 Files skipped from review as they are similar to previous changes (2)
  • packages/expo/src/specs/tests/androidSpecs.test.ts
  • packages/expo/src/specs/NativeClerkGoogleSignIn.android.ts

📝 Walkthrough

Walkthrough

Android Expo native module specs now use optional loading, allowing missing ClerkExpo and ClerkGoogleSignIn modules to resolve to null instead of throwing during import. New tests verify this behavior in Expo Go, and a patch changeset documents the fix for the Android <ClerkProvider> crash.

Estimated code review effort: 2 (Simple) | ~10 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check nameStatusExplanation
Title check✅ PassedThe title is concise and accurately reflects the Android optional native-module change.
Description check✅ PassedThe description clearly matches the Android Expo Go crash fix and optional module loading change.
Linked Issues check✅ PassedThe changes satisfy #9197 by making Android native-module resolution optional and adding coverage for the Expo Go case.
Out of Scope Changes check✅ PassedThe extra Google SignIn optional-loading update and changelog entry are consistent with the same Expo fix, not unrelated scope.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

Comment @coderabbitai help to get the list of available commands.

@coderabbitaicoderabbitaiBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@packages/expo/src/specs/__tests__/androidSpecs.test.ts`:
- Around line 8-22: The android native module specs tests only cover missing
modules; extend the mocked requireOptionalNativeModule path to return fake
modules for each expected module name and assert ClerkExpoSpec and
ClerkGoogleSignInSpec preserve those modules. Keep the existing null/error
tests, and ensure the name-sensitive mock also catches incorrect native module
identifiers.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: be63474d-8af5-4729-9b28-a11e3edab236

📥 Commits

Reviewing files that changed from the base of the PR and between c904fb4 and c112e5f.

📒 Files selected for processing (4)
  • .changeset/fix-android-optional-native-module.md
  • packages/expo/src/specs/NativeClerkGoogleSignIn.android.ts
  • packages/expo/src/specs/NativeClerkModule.android.ts
  • packages/expo/src/specs/__tests__/androidSpecs.test.ts
🔗 Linked repositories identified

CodeRabbit considers these linked repositories for cross-repo context during reviews:

  • clerk/clerk_go(manual)
  • clerk/dashboard(manual)
  • clerk/accounts(manual)
  • clerk/backoffice(manual)
  • clerk/clerk(manual)
  • clerk/clerk-docs(manual)
  • clerk/cloudflare-workers(manual)

Comment threadpackages/expo/src/specs/__tests__/androidSpecs.test.ts
@github-actions

github-actionsBot commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

API Changes Report

Generated by Break Check on 2026-07-21T04:24:51.102Z

Summary

MetricCount
Packages analyzed19
Packages with changes0
🔴 Breaking changes0
🟡 Non-breaking changes0
🟢 Additions0

No API Changes Detected

All packages have stable APIs with no detected changes.


Report generated by Break Check

Last ran on 2881086.

@wobsoriano
wobsoriano merged commit 854bd52 into mainJul 21, 2026
59 checks passed
@wobsoriano
wobsoriano deleted the rob/fix-js-issue-9197 branch July 21, 2026 14:08
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[expo] Android spec hard-requires ClerkExpo native module at import time — crashes Expo Go even for JS-only flows

2 participants

@wobsoriano@mikepitre
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
fix(expo): Resolve Android native modules optionally by wobsoriano · Pull Request #9203 · clerk/javascript · GitHub
Skip to content

fix(expo): Resolve Android native modules optionally - #9203

Merged
wobsoriano merged 2 commits into
mainfrom
rob/fix-js-issue-9197
Jul 21, 2026
Merged

fix(expo): Resolve Android native modules optionally#9203
wobsoriano merged 2 commits into
mainfrom
rob/fix-js-issue-9197

Conversation

@wobsoriano

Copy link
Copy Markdown
Member

Description

On Android, the native module specs used requireNativeModule, which throws at import time. Since ClerkProvider imports that chain unconditionally, every Android app crashed at startup with Cannot find native module 'ClerkExpo' when the module wasn't compiled in (Expo Go), even for JavaScript-only flows.

iOS already used requireOptionalNativeModule. This makes Android match, letting the existing null guard degrade gracefully.

Fixes#9197

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

@changeset-bot

changeset-botBot commented Jul 21, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 2881086

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
NameType
@clerk/expoPatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel

vercelBot commented Jul 21, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxReadyReadyPreview, CommentJul 21, 2026 4:24am
swingsetReadyReadyPreview, CommentJul 21, 2026 4:24am

Request Review

@pkg-pr-new

pkg-pr-newBot commented Jul 21, 2026

Copy link
Copy Markdown

Open in StackBlitz

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@9203

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@9203

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@9203

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@9203

@clerk/electron

npm i https://pkg.pr.new/@clerk/electron@9203

@clerk/electron-passkeys

npm i https://pkg.pr.new/@clerk/electron-passkeys@9203

@clerk/eslint-plugin

npm i https://pkg.pr.new/@clerk/eslint-plugin@9203

@clerk/expo

npm i https://pkg.pr.new/@clerk/expo@9203

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@9203

@clerk/express

npm i https://pkg.pr.new/@clerk/express@9203

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@9203

@clerk/hono

npm i https://pkg.pr.new/@clerk/hono@9203

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@9203

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@9203

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@9203

@clerk/react

npm i https://pkg.pr.new/@clerk/react@9203

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@9203

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@9203

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@9203

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@9203

@clerk/ui

npm i https://pkg.pr.new/@clerk/ui@9203

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@9203

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@9203

commit: 2881086

@coderabbitai

coderabbitaiBot commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: 98b04413-ec95-46a4-a8dc-176d4870cf4a

📥 Commits

Reviewing files that changed from the base of the PR and between c112e5f and 2881086.

📒 Files selected for processing (2)
  • packages/expo/src/specs/NativeClerkGoogleSignIn.android.ts
  • packages/expo/src/specs/__tests__/androidSpecs.test.ts
🔗 Linked repositories identified

CodeRabbit considers these linked repositories for cross-repo context during reviews:

  • clerk/clerk_go(manual)
  • clerk/dashboard(manual)
  • clerk/accounts(manual)
  • clerk/backoffice(manual)
  • clerk/clerk(manual)
  • clerk/clerk-docs(manual)
  • clerk/cloudflare-workers(manual)
🚧 Files skipped from review as they are similar to previous changes (2)
  • packages/expo/src/specs/tests/androidSpecs.test.ts
  • packages/expo/src/specs/NativeClerkGoogleSignIn.android.ts

📝 Walkthrough

Walkthrough

Android Expo native module specs now use optional loading, allowing missing ClerkExpo and ClerkGoogleSignIn modules to resolve to null instead of throwing during import. New tests verify this behavior in Expo Go, and a patch changeset documents the fix for the Android <ClerkProvider> crash.

Estimated code review effort: 2 (Simple) | ~10 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check nameStatusExplanation
Title check✅ PassedThe title is concise and accurately reflects the Android optional native-module change.
Description check✅ PassedThe description clearly matches the Android Expo Go crash fix and optional module loading change.
Linked Issues check✅ PassedThe changes satisfy #9197 by making Android native-module resolution optional and adding coverage for the Expo Go case.
Out of Scope Changes check✅ PassedThe extra Google SignIn optional-loading update and changelog entry are consistent with the same Expo fix, not unrelated scope.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

Comment @coderabbitai help to get the list of available commands.

@coderabbitaicoderabbitaiBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@packages/expo/src/specs/__tests__/androidSpecs.test.ts`:
- Around line 8-22: The android native module specs tests only cover missing
modules; extend the mocked requireOptionalNativeModule path to return fake
modules for each expected module name and assert ClerkExpoSpec and
ClerkGoogleSignInSpec preserve those modules. Keep the existing null/error
tests, and ensure the name-sensitive mock also catches incorrect native module
identifiers.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: be63474d-8af5-4729-9b28-a11e3edab236

📥 Commits

Reviewing files that changed from the base of the PR and between c904fb4 and c112e5f.

📒 Files selected for processing (4)
  • .changeset/fix-android-optional-native-module.md
  • packages/expo/src/specs/NativeClerkGoogleSignIn.android.ts
  • packages/expo/src/specs/NativeClerkModule.android.ts
  • packages/expo/src/specs/__tests__/androidSpecs.test.ts
🔗 Linked repositories identified

CodeRabbit considers these linked repositories for cross-repo context during reviews:

  • clerk/clerk_go(manual)
  • clerk/dashboard(manual)
  • clerk/accounts(manual)
  • clerk/backoffice(manual)
  • clerk/clerk(manual)
  • clerk/clerk-docs(manual)
  • clerk/cloudflare-workers(manual)

Comment threadpackages/expo/src/specs/__tests__/androidSpecs.test.ts
@github-actions

github-actionsBot commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

API Changes Report

Generated by Break Check on 2026-07-21T04:24:51.102Z

Summary

MetricCount
Packages analyzed19
Packages with changes0
🔴 Breaking changes0
🟡 Non-breaking changes0
🟢 Additions0

No API Changes Detected

All packages have stable APIs with no detected changes.


Report generated by Break Check

Last ran on 2881086.

@wobsoriano
wobsoriano merged commit 854bd52 into mainJul 21, 2026
59 checks passed
@wobsoriano
wobsoriano deleted the rob/fix-js-issue-9197 branch July 21, 2026 14:08
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[expo] Android spec hard-requires ClerkExpo native module at import time — crashes Expo Go even for JS-only flows

2 participants

@wobsoriano@mikepitre
, 'i'); if (__m === '*' || __re.test(location.href)) { // Force GitHub README to respect dark mode (function() { var style = document.createElement('style'); style.textContent = ' .markdown-body { color-scheme: dark light; } .markdown-body pre { background: #161b22 !important; } .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; } .markdown-body table th, .markdown-body table td { border-color: #30363d !important; } .markdown-body img { background: #0d1117; } .markdown-body blockquote { border-left-color: #8b949e; } .markdown-body hr { border-color: #30363d; } '; document.head.appendChild(style); })(); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' fix(expo): Resolve Android native modules optionally by wobsoriano · Pull Request #9203 · clerk/javascript · GitHub
Skip to content

fix(expo): Resolve Android native modules optionally - #9203

Merged
wobsoriano merged 2 commits into
mainfrom
rob/fix-js-issue-9197
Jul 21, 2026
Merged

fix(expo): Resolve Android native modules optionally#9203
wobsoriano merged 2 commits into
mainfrom
rob/fix-js-issue-9197

Conversation

@wobsoriano

Copy link
Copy Markdown
Member

Description

On Android, the native module specs used requireNativeModule, which throws at import time. Since ClerkProvider imports that chain unconditionally, every Android app crashed at startup with Cannot find native module 'ClerkExpo' when the module wasn't compiled in (Expo Go), even for JavaScript-only flows.

iOS already used requireOptionalNativeModule. This makes Android match, letting the existing null guard degrade gracefully.

Fixes#9197

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

@changeset-bot

changeset-botBot commented Jul 21, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 2881086

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
NameType
@clerk/expoPatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel

vercelBot commented Jul 21, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxReadyReadyPreview, CommentJul 21, 2026 4:24am
swingsetReadyReadyPreview, CommentJul 21, 2026 4:24am

Request Review

@pkg-pr-new

pkg-pr-newBot commented Jul 21, 2026

Copy link
Copy Markdown

Open in StackBlitz

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@9203

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@9203

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@9203

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@9203

@clerk/electron

npm i https://pkg.pr.new/@clerk/electron@9203

@clerk/electron-passkeys

npm i https://pkg.pr.new/@clerk/electron-passkeys@9203

@clerk/eslint-plugin

npm i https://pkg.pr.new/@clerk/eslint-plugin@9203

@clerk/expo

npm i https://pkg.pr.new/@clerk/expo@9203

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@9203

@clerk/express

npm i https://pkg.pr.new/@clerk/express@9203

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@9203

@clerk/hono

npm i https://pkg.pr.new/@clerk/hono@9203

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@9203

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@9203

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@9203

@clerk/react

npm i https://pkg.pr.new/@clerk/react@9203

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@9203

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@9203

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@9203

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@9203

@clerk/ui

npm i https://pkg.pr.new/@clerk/ui@9203

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@9203

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@9203

commit: 2881086

@coderabbitai

coderabbitaiBot commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: 98b04413-ec95-46a4-a8dc-176d4870cf4a

📥 Commits

Reviewing files that changed from the base of the PR and between c112e5f and 2881086.

📒 Files selected for processing (2)
  • packages/expo/src/specs/NativeClerkGoogleSignIn.android.ts
  • packages/expo/src/specs/__tests__/androidSpecs.test.ts
🔗 Linked repositories identified

CodeRabbit considers these linked repositories for cross-repo context during reviews:

  • clerk/clerk_go(manual)
  • clerk/dashboard(manual)
  • clerk/accounts(manual)
  • clerk/backoffice(manual)
  • clerk/clerk(manual)
  • clerk/clerk-docs(manual)
  • clerk/cloudflare-workers(manual)
🚧 Files skipped from review as they are similar to previous changes (2)
  • packages/expo/src/specs/tests/androidSpecs.test.ts
  • packages/expo/src/specs/NativeClerkGoogleSignIn.android.ts

📝 Walkthrough

Walkthrough

Android Expo native module specs now use optional loading, allowing missing ClerkExpo and ClerkGoogleSignIn modules to resolve to null instead of throwing during import. New tests verify this behavior in Expo Go, and a patch changeset documents the fix for the Android <ClerkProvider> crash.

Estimated code review effort: 2 (Simple) | ~10 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check nameStatusExplanation
Title check✅ PassedThe title is concise and accurately reflects the Android optional native-module change.
Description check✅ PassedThe description clearly matches the Android Expo Go crash fix and optional module loading change.
Linked Issues check✅ PassedThe changes satisfy #9197 by making Android native-module resolution optional and adding coverage for the Expo Go case.
Out of Scope Changes check✅ PassedThe extra Google SignIn optional-loading update and changelog entry are consistent with the same Expo fix, not unrelated scope.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

Comment @coderabbitai help to get the list of available commands.

@coderabbitaicoderabbitaiBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@packages/expo/src/specs/__tests__/androidSpecs.test.ts`:
- Around line 8-22: The android native module specs tests only cover missing
modules; extend the mocked requireOptionalNativeModule path to return fake
modules for each expected module name and assert ClerkExpoSpec and
ClerkGoogleSignInSpec preserve those modules. Keep the existing null/error
tests, and ensure the name-sensitive mock also catches incorrect native module
identifiers.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: be63474d-8af5-4729-9b28-a11e3edab236

📥 Commits

Reviewing files that changed from the base of the PR and between c904fb4 and c112e5f.

📒 Files selected for processing (4)
  • .changeset/fix-android-optional-native-module.md
  • packages/expo/src/specs/NativeClerkGoogleSignIn.android.ts
  • packages/expo/src/specs/NativeClerkModule.android.ts
  • packages/expo/src/specs/__tests__/androidSpecs.test.ts
🔗 Linked repositories identified

CodeRabbit considers these linked repositories for cross-repo context during reviews:

  • clerk/clerk_go(manual)
  • clerk/dashboard(manual)
  • clerk/accounts(manual)
  • clerk/backoffice(manual)
  • clerk/clerk(manual)
  • clerk/clerk-docs(manual)
  • clerk/cloudflare-workers(manual)

Comment threadpackages/expo/src/specs/__tests__/androidSpecs.test.ts
@github-actions

github-actionsBot commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

API Changes Report

Generated by Break Check on 2026-07-21T04:24:51.102Z

Summary

MetricCount
Packages analyzed19
Packages with changes0
🔴 Breaking changes0
🟡 Non-breaking changes0
🟢 Additions0

No API Changes Detected

All packages have stable APIs with no detected changes.


Report generated by Break Check

Last ran on 2881086.

@wobsoriano
wobsoriano merged commit 854bd52 into mainJul 21, 2026
59 checks passed
@wobsoriano
wobsoriano deleted the rob/fix-js-issue-9197 branch July 21, 2026 14:08
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[expo] Android spec hard-requires ClerkExpo native module at import time — crashes Expo Go even for JS-only flows

2 participants

@wobsoriano@mikepitre
, 'i'); if (__m === '*' || __re.test(location.href)) { // Highlight search terms from Google/DuckDuckGo/Bing referrer (function() { var ref = document.referrer; var terms = []; if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) { var url = new URL(ref); var q = url.searchParams.get('q') || url.searchParams.get('p'); if (q) { terms = q.split(/\s+/).filter(function(t) { return t.length > 2; }); } } if (terms.length === 0) return; var style = document.createElement('style'); style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }'; document.head.appendChild(style); function highlight(node) { if (node.nodeType === 3) { // text node var text = node.textContent; var found = false; terms.forEach(function(term) { var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' fix(expo): Resolve Android native modules optionally by wobsoriano · Pull Request #9203 · clerk/javascript · GitHub
Skip to content

fix(expo): Resolve Android native modules optionally - #9203

Merged
wobsoriano merged 2 commits into
mainfrom
rob/fix-js-issue-9197
Jul 21, 2026
Merged

fix(expo): Resolve Android native modules optionally#9203
wobsoriano merged 2 commits into
mainfrom
rob/fix-js-issue-9197

Conversation

@wobsoriano

Copy link
Copy Markdown
Member

Description

On Android, the native module specs used requireNativeModule, which throws at import time. Since ClerkProvider imports that chain unconditionally, every Android app crashed at startup with Cannot find native module 'ClerkExpo' when the module wasn't compiled in (Expo Go), even for JavaScript-only flows.

iOS already used requireOptionalNativeModule. This makes Android match, letting the existing null guard degrade gracefully.

Fixes#9197

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

@changeset-bot

changeset-botBot commented Jul 21, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 2881086

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
NameType
@clerk/expoPatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel

vercelBot commented Jul 21, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxReadyReadyPreview, CommentJul 21, 2026 4:24am
swingsetReadyReadyPreview, CommentJul 21, 2026 4:24am

Request Review

@pkg-pr-new

pkg-pr-newBot commented Jul 21, 2026

Copy link
Copy Markdown

Open in StackBlitz

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@9203

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@9203

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@9203

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@9203

@clerk/electron

npm i https://pkg.pr.new/@clerk/electron@9203

@clerk/electron-passkeys

npm i https://pkg.pr.new/@clerk/electron-passkeys@9203

@clerk/eslint-plugin

npm i https://pkg.pr.new/@clerk/eslint-plugin@9203

@clerk/expo

npm i https://pkg.pr.new/@clerk/expo@9203

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@9203

@clerk/express

npm i https://pkg.pr.new/@clerk/express@9203

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@9203

@clerk/hono

npm i https://pkg.pr.new/@clerk/hono@9203

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@9203

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@9203

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@9203

@clerk/react

npm i https://pkg.pr.new/@clerk/react@9203

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@9203

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@9203

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@9203

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@9203

@clerk/ui

npm i https://pkg.pr.new/@clerk/ui@9203

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@9203

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@9203

commit: 2881086

@coderabbitai

coderabbitaiBot commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: 98b04413-ec95-46a4-a8dc-176d4870cf4a

📥 Commits

Reviewing files that changed from the base of the PR and between c112e5f and 2881086.

📒 Files selected for processing (2)
  • packages/expo/src/specs/NativeClerkGoogleSignIn.android.ts
  • packages/expo/src/specs/__tests__/androidSpecs.test.ts
🔗 Linked repositories identified

CodeRabbit considers these linked repositories for cross-repo context during reviews:

  • clerk/clerk_go(manual)
  • clerk/dashboard(manual)
  • clerk/accounts(manual)
  • clerk/backoffice(manual)
  • clerk/clerk(manual)
  • clerk/clerk-docs(manual)
  • clerk/cloudflare-workers(manual)
🚧 Files skipped from review as they are similar to previous changes (2)
  • packages/expo/src/specs/tests/androidSpecs.test.ts
  • packages/expo/src/specs/NativeClerkGoogleSignIn.android.ts

📝 Walkthrough

Walkthrough

Android Expo native module specs now use optional loading, allowing missing ClerkExpo and ClerkGoogleSignIn modules to resolve to null instead of throwing during import. New tests verify this behavior in Expo Go, and a patch changeset documents the fix for the Android <ClerkProvider> crash.

Estimated code review effort: 2 (Simple) | ~10 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check nameStatusExplanation
Title check✅ PassedThe title is concise and accurately reflects the Android optional native-module change.
Description check✅ PassedThe description clearly matches the Android Expo Go crash fix and optional module loading change.
Linked Issues check✅ PassedThe changes satisfy #9197 by making Android native-module resolution optional and adding coverage for the Expo Go case.
Out of Scope Changes check✅ PassedThe extra Google SignIn optional-loading update and changelog entry are consistent with the same Expo fix, not unrelated scope.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

Comment @coderabbitai help to get the list of available commands.

@coderabbitaicoderabbitaiBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@packages/expo/src/specs/__tests__/androidSpecs.test.ts`:
- Around line 8-22: The android native module specs tests only cover missing
modules; extend the mocked requireOptionalNativeModule path to return fake
modules for each expected module name and assert ClerkExpoSpec and
ClerkGoogleSignInSpec preserve those modules. Keep the existing null/error
tests, and ensure the name-sensitive mock also catches incorrect native module
identifiers.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: be63474d-8af5-4729-9b28-a11e3edab236

📥 Commits

Reviewing files that changed from the base of the PR and between c904fb4 and c112e5f.

📒 Files selected for processing (4)
  • .changeset/fix-android-optional-native-module.md
  • packages/expo/src/specs/NativeClerkGoogleSignIn.android.ts
  • packages/expo/src/specs/NativeClerkModule.android.ts
  • packages/expo/src/specs/__tests__/androidSpecs.test.ts
🔗 Linked repositories identified

CodeRabbit considers these linked repositories for cross-repo context during reviews:

  • clerk/clerk_go(manual)
  • clerk/dashboard(manual)
  • clerk/accounts(manual)
  • clerk/backoffice(manual)
  • clerk/clerk(manual)
  • clerk/clerk-docs(manual)
  • clerk/cloudflare-workers(manual)

Comment threadpackages/expo/src/specs/__tests__/androidSpecs.test.ts
@github-actions

github-actionsBot commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

API Changes Report

Generated by Break Check on 2026-07-21T04:24:51.102Z

Summary

MetricCount
Packages analyzed19
Packages with changes0
🔴 Breaking changes0
🟡 Non-breaking changes0
🟢 Additions0

No API Changes Detected

All packages have stable APIs with no detected changes.


Report generated by Break Check

Last ran on 2881086.

@wobsoriano
wobsoriano merged commit 854bd52 into mainJul 21, 2026
59 checks passed
@wobsoriano
wobsoriano deleted the rob/fix-js-issue-9197 branch July 21, 2026 14:08
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[expo] Android spec hard-requires ClerkExpo native module at import time — crashes Expo Go even for JS-only flows

2 participants

@wobsoriano@mikepitre
, 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ' fix(expo): Resolve Android native modules optionally by wobsoriano · Pull Request #9203 · clerk/javascript · GitHub
Skip to content

fix(expo): Resolve Android native modules optionally - #9203

Merged
wobsoriano merged 2 commits into
mainfrom
rob/fix-js-issue-9197
Jul 21, 2026
Merged

fix(expo): Resolve Android native modules optionally#9203
wobsoriano merged 2 commits into
mainfrom
rob/fix-js-issue-9197

Conversation

@wobsoriano

Copy link
Copy Markdown
Member

Description

On Android, the native module specs used requireNativeModule, which throws at import time. Since ClerkProvider imports that chain unconditionally, every Android app crashed at startup with Cannot find native module 'ClerkExpo' when the module wasn't compiled in (Expo Go), even for JavaScript-only flows.

iOS already used requireOptionalNativeModule. This makes Android match, letting the existing null guard degrade gracefully.

Fixes#9197

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

@changeset-bot

changeset-botBot commented Jul 21, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 2881086

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
NameType
@clerk/expoPatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel

vercelBot commented Jul 21, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxReadyReadyPreview, CommentJul 21, 2026 4:24am
swingsetReadyReadyPreview, CommentJul 21, 2026 4:24am

Request Review

@pkg-pr-new

pkg-pr-newBot commented Jul 21, 2026

Copy link
Copy Markdown

Open in StackBlitz

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@9203

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@9203

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@9203

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@9203

@clerk/electron

npm i https://pkg.pr.new/@clerk/electron@9203

@clerk/electron-passkeys

npm i https://pkg.pr.new/@clerk/electron-passkeys@9203

@clerk/eslint-plugin

npm i https://pkg.pr.new/@clerk/eslint-plugin@9203

@clerk/expo

npm i https://pkg.pr.new/@clerk/expo@9203

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@9203

@clerk/express

npm i https://pkg.pr.new/@clerk/express@9203

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@9203

@clerk/hono

npm i https://pkg.pr.new/@clerk/hono@9203

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@9203

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@9203

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@9203

@clerk/react

npm i https://pkg.pr.new/@clerk/react@9203

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@9203

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@9203

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@9203

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@9203

@clerk/ui

npm i https://pkg.pr.new/@clerk/ui@9203

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@9203

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@9203

commit: 2881086

@coderabbitai

coderabbitaiBot commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: 98b04413-ec95-46a4-a8dc-176d4870cf4a

📥 Commits

Reviewing files that changed from the base of the PR and between c112e5f and 2881086.

📒 Files selected for processing (2)
  • packages/expo/src/specs/NativeClerkGoogleSignIn.android.ts
  • packages/expo/src/specs/__tests__/androidSpecs.test.ts
🔗 Linked repositories identified

CodeRabbit considers these linked repositories for cross-repo context during reviews:

  • clerk/clerk_go(manual)
  • clerk/dashboard(manual)
  • clerk/accounts(manual)
  • clerk/backoffice(manual)
  • clerk/clerk(manual)
  • clerk/clerk-docs(manual)
  • clerk/cloudflare-workers(manual)
🚧 Files skipped from review as they are similar to previous changes (2)
  • packages/expo/src/specs/tests/androidSpecs.test.ts
  • packages/expo/src/specs/NativeClerkGoogleSignIn.android.ts

📝 Walkthrough

Walkthrough

Android Expo native module specs now use optional loading, allowing missing ClerkExpo and ClerkGoogleSignIn modules to resolve to null instead of throwing during import. New tests verify this behavior in Expo Go, and a patch changeset documents the fix for the Android <ClerkProvider> crash.

Estimated code review effort: 2 (Simple) | ~10 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check nameStatusExplanation
Title check✅ PassedThe title is concise and accurately reflects the Android optional native-module change.
Description check✅ PassedThe description clearly matches the Android Expo Go crash fix and optional module loading change.
Linked Issues check✅ PassedThe changes satisfy #9197 by making Android native-module resolution optional and adding coverage for the Expo Go case.
Out of Scope Changes check✅ PassedThe extra Google SignIn optional-loading update and changelog entry are consistent with the same Expo fix, not unrelated scope.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

Comment @coderabbitai help to get the list of available commands.

@coderabbitaicoderabbitaiBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@packages/expo/src/specs/__tests__/androidSpecs.test.ts`:
- Around line 8-22: The android native module specs tests only cover missing
modules; extend the mocked requireOptionalNativeModule path to return fake
modules for each expected module name and assert ClerkExpoSpec and
ClerkGoogleSignInSpec preserve those modules. Keep the existing null/error
tests, and ensure the name-sensitive mock also catches incorrect native module
identifiers.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: be63474d-8af5-4729-9b28-a11e3edab236

📥 Commits

Reviewing files that changed from the base of the PR and between c904fb4 and c112e5f.

📒 Files selected for processing (4)
  • .changeset/fix-android-optional-native-module.md
  • packages/expo/src/specs/NativeClerkGoogleSignIn.android.ts
  • packages/expo/src/specs/NativeClerkModule.android.ts
  • packages/expo/src/specs/__tests__/androidSpecs.test.ts
🔗 Linked repositories identified

CodeRabbit considers these linked repositories for cross-repo context during reviews:

  • clerk/clerk_go(manual)
  • clerk/dashboard(manual)
  • clerk/accounts(manual)
  • clerk/backoffice(manual)
  • clerk/clerk(manual)
  • clerk/clerk-docs(manual)
  • clerk/cloudflare-workers(manual)

Comment threadpackages/expo/src/specs/__tests__/androidSpecs.test.ts
@github-actions

github-actionsBot commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

API Changes Report

Generated by Break Check on 2026-07-21T04:24:51.102Z

Summary

MetricCount
Packages analyzed19
Packages with changes0
🔴 Breaking changes0
🟡 Non-breaking changes0
🟢 Additions0

No API Changes Detected

All packages have stable APIs with no detected changes.


Report generated by Break Check

Last ran on 2881086.

@wobsoriano
wobsoriano merged commit 854bd52 into mainJul 21, 2026
59 checks passed
@wobsoriano
wobsoriano deleted the rob/fix-js-issue-9197 branch July 21, 2026 14:08
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[expo] Android spec hard-requires ClerkExpo native module at import time — crashes Expo Go even for JS-only flows

2 participants

@wobsoriano@mikepitre
, 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' fix(expo): Resolve Android native modules optionally by wobsoriano · Pull Request #9203 · clerk/javascript · GitHub
Skip to content

fix(expo): Resolve Android native modules optionally - #9203

Merged
wobsoriano merged 2 commits into
mainfrom
rob/fix-js-issue-9197
Jul 21, 2026
Merged

fix(expo): Resolve Android native modules optionally#9203
wobsoriano merged 2 commits into
mainfrom
rob/fix-js-issue-9197

Conversation

@wobsoriano

Copy link
Copy Markdown
Member

Description

On Android, the native module specs used requireNativeModule, which throws at import time. Since ClerkProvider imports that chain unconditionally, every Android app crashed at startup with Cannot find native module 'ClerkExpo' when the module wasn't compiled in (Expo Go), even for JavaScript-only flows.

iOS already used requireOptionalNativeModule. This makes Android match, letting the existing null guard degrade gracefully.

Fixes#9197

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

@changeset-bot

changeset-botBot commented Jul 21, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 2881086

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
NameType
@clerk/expoPatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel

vercelBot commented Jul 21, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxReadyReadyPreview, CommentJul 21, 2026 4:24am
swingsetReadyReadyPreview, CommentJul 21, 2026 4:24am

Request Review

@pkg-pr-new

pkg-pr-newBot commented Jul 21, 2026

Copy link
Copy Markdown

Open in StackBlitz

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@9203

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@9203

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@9203

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@9203

@clerk/electron

npm i https://pkg.pr.new/@clerk/electron@9203

@clerk/electron-passkeys

npm i https://pkg.pr.new/@clerk/electron-passkeys@9203

@clerk/eslint-plugin

npm i https://pkg.pr.new/@clerk/eslint-plugin@9203

@clerk/expo

npm i https://pkg.pr.new/@clerk/expo@9203

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@9203

@clerk/express

npm i https://pkg.pr.new/@clerk/express@9203

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@9203

@clerk/hono

npm i https://pkg.pr.new/@clerk/hono@9203

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@9203

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@9203

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@9203

@clerk/react

npm i https://pkg.pr.new/@clerk/react@9203

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@9203

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@9203

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@9203

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@9203

@clerk/ui

npm i https://pkg.pr.new/@clerk/ui@9203

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@9203

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@9203

commit: 2881086

@coderabbitai

coderabbitaiBot commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: 98b04413-ec95-46a4-a8dc-176d4870cf4a

📥 Commits

Reviewing files that changed from the base of the PR and between c112e5f and 2881086.

📒 Files selected for processing (2)
  • packages/expo/src/specs/NativeClerkGoogleSignIn.android.ts
  • packages/expo/src/specs/__tests__/androidSpecs.test.ts
🔗 Linked repositories identified

CodeRabbit considers these linked repositories for cross-repo context during reviews:

  • clerk/clerk_go(manual)
  • clerk/dashboard(manual)
  • clerk/accounts(manual)
  • clerk/backoffice(manual)
  • clerk/clerk(manual)
  • clerk/clerk-docs(manual)
  • clerk/cloudflare-workers(manual)
🚧 Files skipped from review as they are similar to previous changes (2)
  • packages/expo/src/specs/tests/androidSpecs.test.ts
  • packages/expo/src/specs/NativeClerkGoogleSignIn.android.ts

📝 Walkthrough

Walkthrough

Android Expo native module specs now use optional loading, allowing missing ClerkExpo and ClerkGoogleSignIn modules to resolve to null instead of throwing during import. New tests verify this behavior in Expo Go, and a patch changeset documents the fix for the Android <ClerkProvider> crash.

Estimated code review effort: 2 (Simple) | ~10 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check nameStatusExplanation
Title check✅ PassedThe title is concise and accurately reflects the Android optional native-module change.
Description check✅ PassedThe description clearly matches the Android Expo Go crash fix and optional module loading change.
Linked Issues check✅ PassedThe changes satisfy #9197 by making Android native-module resolution optional and adding coverage for the Expo Go case.
Out of Scope Changes check✅ PassedThe extra Google SignIn optional-loading update and changelog entry are consistent with the same Expo fix, not unrelated scope.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

Comment @coderabbitai help to get the list of available commands.

@coderabbitaicoderabbitaiBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@packages/expo/src/specs/__tests__/androidSpecs.test.ts`:
- Around line 8-22: The android native module specs tests only cover missing
modules; extend the mocked requireOptionalNativeModule path to return fake
modules for each expected module name and assert ClerkExpoSpec and
ClerkGoogleSignInSpec preserve those modules. Keep the existing null/error
tests, and ensure the name-sensitive mock also catches incorrect native module
identifiers.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: be63474d-8af5-4729-9b28-a11e3edab236

📥 Commits

Reviewing files that changed from the base of the PR and between c904fb4 and c112e5f.

📒 Files selected for processing (4)
  • .changeset/fix-android-optional-native-module.md
  • packages/expo/src/specs/NativeClerkGoogleSignIn.android.ts
  • packages/expo/src/specs/NativeClerkModule.android.ts
  • packages/expo/src/specs/__tests__/androidSpecs.test.ts
🔗 Linked repositories identified

CodeRabbit considers these linked repositories for cross-repo context during reviews:

  • clerk/clerk_go(manual)
  • clerk/dashboard(manual)
  • clerk/accounts(manual)
  • clerk/backoffice(manual)
  • clerk/clerk(manual)
  • clerk/clerk-docs(manual)
  • clerk/cloudflare-workers(manual)

Comment threadpackages/expo/src/specs/__tests__/androidSpecs.test.ts
@github-actions

github-actionsBot commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

API Changes Report

Generated by Break Check on 2026-07-21T04:24:51.102Z

Summary

MetricCount
Packages analyzed19
Packages with changes0
🔴 Breaking changes0
🟡 Non-breaking changes0
🟢 Additions0

No API Changes Detected

All packages have stable APIs with no detected changes.


Report generated by Break Check

Last ran on 2881086.

@wobsoriano
wobsoriano merged commit 854bd52 into mainJul 21, 2026
59 checks passed
@wobsoriano
wobsoriano deleted the rob/fix-js-issue-9197 branch July 21, 2026 14:08
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[expo] Android spec hard-requires ClerkExpo native module at import time — crashes Expo Go even for JS-only flows

2 participants

@wobsoriano@mikepitre
, 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' fix(expo): Resolve Android native modules optionally by wobsoriano · Pull Request #9203 · clerk/javascript · GitHub
Skip to content

fix(expo): Resolve Android native modules optionally - #9203

Merged
wobsoriano merged 2 commits into
mainfrom
rob/fix-js-issue-9197
Jul 21, 2026
Merged

fix(expo): Resolve Android native modules optionally#9203
wobsoriano merged 2 commits into
mainfrom
rob/fix-js-issue-9197

Conversation

@wobsoriano

Copy link
Copy Markdown
Member

Description

On Android, the native module specs used requireNativeModule, which throws at import time. Since ClerkProvider imports that chain unconditionally, every Android app crashed at startup with Cannot find native module 'ClerkExpo' when the module wasn't compiled in (Expo Go), even for JavaScript-only flows.

iOS already used requireOptionalNativeModule. This makes Android match, letting the existing null guard degrade gracefully.

Fixes#9197

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

@changeset-bot

changeset-botBot commented Jul 21, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 2881086

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
NameType
@clerk/expoPatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel

vercelBot commented Jul 21, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxReadyReadyPreview, CommentJul 21, 2026 4:24am
swingsetReadyReadyPreview, CommentJul 21, 2026 4:24am

Request Review

@pkg-pr-new

pkg-pr-newBot commented Jul 21, 2026

Copy link
Copy Markdown

Open in StackBlitz

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@9203

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@9203

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@9203

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@9203

@clerk/electron

npm i https://pkg.pr.new/@clerk/electron@9203

@clerk/electron-passkeys

npm i https://pkg.pr.new/@clerk/electron-passkeys@9203

@clerk/eslint-plugin

npm i https://pkg.pr.new/@clerk/eslint-plugin@9203

@clerk/expo

npm i https://pkg.pr.new/@clerk/expo@9203

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@9203

@clerk/express

npm i https://pkg.pr.new/@clerk/express@9203

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@9203

@clerk/hono

npm i https://pkg.pr.new/@clerk/hono@9203

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@9203

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@9203

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@9203

@clerk/react

npm i https://pkg.pr.new/@clerk/react@9203

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@9203

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@9203

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@9203

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@9203

@clerk/ui

npm i https://pkg.pr.new/@clerk/ui@9203

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@9203

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@9203

commit: 2881086

@coderabbitai

coderabbitaiBot commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: 98b04413-ec95-46a4-a8dc-176d4870cf4a

📥 Commits

Reviewing files that changed from the base of the PR and between c112e5f and 2881086.

📒 Files selected for processing (2)
  • packages/expo/src/specs/NativeClerkGoogleSignIn.android.ts
  • packages/expo/src/specs/__tests__/androidSpecs.test.ts
🔗 Linked repositories identified

CodeRabbit considers these linked repositories for cross-repo context during reviews:

  • clerk/clerk_go(manual)
  • clerk/dashboard(manual)
  • clerk/accounts(manual)
  • clerk/backoffice(manual)
  • clerk/clerk(manual)
  • clerk/clerk-docs(manual)
  • clerk/cloudflare-workers(manual)
🚧 Files skipped from review as they are similar to previous changes (2)
  • packages/expo/src/specs/tests/androidSpecs.test.ts
  • packages/expo/src/specs/NativeClerkGoogleSignIn.android.ts

📝 Walkthrough

Walkthrough

Android Expo native module specs now use optional loading, allowing missing ClerkExpo and ClerkGoogleSignIn modules to resolve to null instead of throwing during import. New tests verify this behavior in Expo Go, and a patch changeset documents the fix for the Android <ClerkProvider> crash.

Estimated code review effort: 2 (Simple) | ~10 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check nameStatusExplanation
Title check✅ PassedThe title is concise and accurately reflects the Android optional native-module change.
Description check✅ PassedThe description clearly matches the Android Expo Go crash fix and optional module loading change.
Linked Issues check✅ PassedThe changes satisfy #9197 by making Android native-module resolution optional and adding coverage for the Expo Go case.
Out of Scope Changes check✅ PassedThe extra Google SignIn optional-loading update and changelog entry are consistent with the same Expo fix, not unrelated scope.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

Comment @coderabbitai help to get the list of available commands.

@coderabbitaicoderabbitaiBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@packages/expo/src/specs/__tests__/androidSpecs.test.ts`:
- Around line 8-22: The android native module specs tests only cover missing
modules; extend the mocked requireOptionalNativeModule path to return fake
modules for each expected module name and assert ClerkExpoSpec and
ClerkGoogleSignInSpec preserve those modules. Keep the existing null/error
tests, and ensure the name-sensitive mock also catches incorrect native module
identifiers.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: be63474d-8af5-4729-9b28-a11e3edab236

📥 Commits

Reviewing files that changed from the base of the PR and between c904fb4 and c112e5f.

📒 Files selected for processing (4)
  • .changeset/fix-android-optional-native-module.md
  • packages/expo/src/specs/NativeClerkGoogleSignIn.android.ts
  • packages/expo/src/specs/NativeClerkModule.android.ts
  • packages/expo/src/specs/__tests__/androidSpecs.test.ts
🔗 Linked repositories identified

CodeRabbit considers these linked repositories for cross-repo context during reviews:

  • clerk/clerk_go(manual)
  • clerk/dashboard(manual)
  • clerk/accounts(manual)
  • clerk/backoffice(manual)
  • clerk/clerk(manual)
  • clerk/clerk-docs(manual)
  • clerk/cloudflare-workers(manual)

Comment threadpackages/expo/src/specs/__tests__/androidSpecs.test.ts
@github-actions

github-actionsBot commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

API Changes Report

Generated by Break Check on 2026-07-21T04:24:51.102Z

Summary

MetricCount
Packages analyzed19
Packages with changes0
🔴 Breaking changes0
🟡 Non-breaking changes0
🟢 Additions0

No API Changes Detected

All packages have stable APIs with no detected changes.


Report generated by Break Check

Last ran on 2881086.

@wobsoriano
wobsoriano merged commit 854bd52 into mainJul 21, 2026
59 checks passed
@wobsoriano
wobsoriano deleted the rob/fix-js-issue-9197 branch July 21, 2026 14:08
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[expo] Android spec hard-requires ClerkExpo native module at import time — crashes Expo Go even for JS-only flows

2 participants

@wobsoriano@mikepitre
, 'i'); if (__m === '*' || __re.test(location.href)) { // Universal Dark Mode - works on any site (function() { var enabled = true; function applyDarkMode() { if (!enabled) return; // Create style element if it doesn't exist var style = document.getElementById('universal-dark-mode-style'); if (!style) { style = document.createElement('style'); style.id = 'universal-dark-mode-style'; document.head.appendChild(style); } // Dark mode CSS - inverts colors but preserves images/video style.textContent = ' /* Invert everything except media */ html { filter: invert(1) hue-rotate(180deg) !important; background: #1a1a2e !important; } /* Restore images, videos, iframes, canvas */ img, video, iframe, canvas, svg, picture, [style*="background-image"] { filter: invert(1) hue-rotate(180deg) !important; } /* Preserve specific elements that should not be inverted */ .no-dark-mode, .no-dark-mode *, [data-theme="light"], [data-theme="light"], .ace_editor, .ace_editor *, .CodeMirror, .CodeMirror *, .monaco-editor, .monaco-editor *, .markdown-body pre, .markdown-body pre *, .highlight, .highlight *, pre code, pre code * { filter: none !important; } /* Fix common UI elements */ .modal, .popup, .dropdown-menu, .tooltip, .popover { filter: invert(1) hue-rotate(180deg) !important; background: #2d2d44 !important; border-color: #444 !important; } /* Scrollbars */ ::-webkit-scrollbar { background: #1a1a2e !important; } ::-webkit-scrollbar-thumb { background: #444 !important; } ::-webkit-scrollbar-thumb:hover { background: #555 !important; } /* Selection */ ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; } ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; } '; } function removeDarkMode() { var style = document.getElementById('universal-dark-mode-style'); if (style) style.remove(); } // Toggle with Alt+Shift+D document.addEventListener('keydown', function(e) { if (e.altKey && e.shiftKey && e.key === 'D') { e.preventDefault(); enabled = !enabled; if (enabled) { applyDarkMode(); console.log('[Universal Dark Mode] Enabled'); } else { removeDarkMode(); console.log('[Universal Dark Mode] Disabled'); } } }); // Apply on load applyDarkMode(); // Re-apply on dynamic content var observer = new MutationObserver(function(mutations) { if (enabled && !document.getElementById('universal-dark-mode-style')) { applyDarkMode(); } }); observer.observe(document.head, { childList: true }); console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle'); })(); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })(); fix(expo): Resolve Android native modules optionally by wobsoriano · Pull Request #9203 · clerk/javascript · GitHub
Skip to content

fix(expo): Resolve Android native modules optionally - #9203

Merged
wobsoriano merged 2 commits into
mainfrom
rob/fix-js-issue-9197
Jul 21, 2026
Merged

fix(expo): Resolve Android native modules optionally#9203
wobsoriano merged 2 commits into
mainfrom
rob/fix-js-issue-9197

Conversation

@wobsoriano

Copy link
Copy Markdown
Member

Description

On Android, the native module specs used requireNativeModule, which throws at import time. Since ClerkProvider imports that chain unconditionally, every Android app crashed at startup with Cannot find native module 'ClerkExpo' when the module wasn't compiled in (Expo Go), even for JavaScript-only flows.

iOS already used requireOptionalNativeModule. This makes Android match, letting the existing null guard degrade gracefully.

Fixes#9197

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

@changeset-bot

changeset-botBot commented Jul 21, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 2881086

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
NameType
@clerk/expoPatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel

vercelBot commented Jul 21, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxReadyReadyPreview, CommentJul 21, 2026 4:24am
swingsetReadyReadyPreview, CommentJul 21, 2026 4:24am

Request Review

@pkg-pr-new

pkg-pr-newBot commented Jul 21, 2026

Copy link
Copy Markdown

Open in StackBlitz

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@9203

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@9203

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@9203

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@9203

@clerk/electron

npm i https://pkg.pr.new/@clerk/electron@9203

@clerk/electron-passkeys

npm i https://pkg.pr.new/@clerk/electron-passkeys@9203

@clerk/eslint-plugin

npm i https://pkg.pr.new/@clerk/eslint-plugin@9203

@clerk/expo

npm i https://pkg.pr.new/@clerk/expo@9203

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@9203

@clerk/express

npm i https://pkg.pr.new/@clerk/express@9203

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@9203

@clerk/hono

npm i https://pkg.pr.new/@clerk/hono@9203

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@9203

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@9203

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@9203

@clerk/react

npm i https://pkg.pr.new/@clerk/react@9203

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@9203

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@9203

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@9203

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@9203

@clerk/ui

npm i https://pkg.pr.new/@clerk/ui@9203

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@9203

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@9203

commit: 2881086

@coderabbitai

coderabbitaiBot commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: 98b04413-ec95-46a4-a8dc-176d4870cf4a

📥 Commits

Reviewing files that changed from the base of the PR and between c112e5f and 2881086.

📒 Files selected for processing (2)
  • packages/expo/src/specs/NativeClerkGoogleSignIn.android.ts
  • packages/expo/src/specs/__tests__/androidSpecs.test.ts
🔗 Linked repositories identified

CodeRabbit considers these linked repositories for cross-repo context during reviews:

  • clerk/clerk_go(manual)
  • clerk/dashboard(manual)
  • clerk/accounts(manual)
  • clerk/backoffice(manual)
  • clerk/clerk(manual)
  • clerk/clerk-docs(manual)
  • clerk/cloudflare-workers(manual)
🚧 Files skipped from review as they are similar to previous changes (2)
  • packages/expo/src/specs/tests/androidSpecs.test.ts
  • packages/expo/src/specs/NativeClerkGoogleSignIn.android.ts

📝 Walkthrough

Walkthrough

Android Expo native module specs now use optional loading, allowing missing ClerkExpo and ClerkGoogleSignIn modules to resolve to null instead of throwing during import. New tests verify this behavior in Expo Go, and a patch changeset documents the fix for the Android <ClerkProvider> crash.

Estimated code review effort: 2 (Simple) | ~10 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check nameStatusExplanation
Title check✅ PassedThe title is concise and accurately reflects the Android optional native-module change.
Description check✅ PassedThe description clearly matches the Android Expo Go crash fix and optional module loading change.
Linked Issues check✅ PassedThe changes satisfy #9197 by making Android native-module resolution optional and adding coverage for the Expo Go case.
Out of Scope Changes check✅ PassedThe extra Google SignIn optional-loading update and changelog entry are consistent with the same Expo fix, not unrelated scope.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

Comment @coderabbitai help to get the list of available commands.

@coderabbitaicoderabbitaiBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@packages/expo/src/specs/__tests__/androidSpecs.test.ts`:
- Around line 8-22: The android native module specs tests only cover missing
modules; extend the mocked requireOptionalNativeModule path to return fake
modules for each expected module name and assert ClerkExpoSpec and
ClerkGoogleSignInSpec preserve those modules. Keep the existing null/error
tests, and ensure the name-sensitive mock also catches incorrect native module
identifiers.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: be63474d-8af5-4729-9b28-a11e3edab236

📥 Commits

Reviewing files that changed from the base of the PR and between c904fb4 and c112e5f.

📒 Files selected for processing (4)
  • .changeset/fix-android-optional-native-module.md
  • packages/expo/src/specs/NativeClerkGoogleSignIn.android.ts
  • packages/expo/src/specs/NativeClerkModule.android.ts
  • packages/expo/src/specs/__tests__/androidSpecs.test.ts
🔗 Linked repositories identified

CodeRabbit considers these linked repositories for cross-repo context during reviews:

  • clerk/clerk_go(manual)
  • clerk/dashboard(manual)
  • clerk/accounts(manual)
  • clerk/backoffice(manual)
  • clerk/clerk(manual)
  • clerk/clerk-docs(manual)
  • clerk/cloudflare-workers(manual)

Comment threadpackages/expo/src/specs/__tests__/androidSpecs.test.ts
@github-actions

github-actionsBot commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

API Changes Report

Generated by Break Check on 2026-07-21T04:24:51.102Z

Summary

MetricCount
Packages analyzed19
Packages with changes0
🔴 Breaking changes0
🟡 Non-breaking changes0
🟢 Additions0

No API Changes Detected

All packages have stable APIs with no detected changes.


Report generated by Break Check

Last ran on 2881086.

@wobsoriano
wobsoriano merged commit 854bd52 into mainJul 21, 2026
59 checks passed
@wobsoriano
wobsoriano deleted the rob/fix-js-issue-9197 branch July 21, 2026 14:08
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[expo] Android spec hard-requires ClerkExpo native module at import time — crashes Expo Go even for JS-only flows

2 participants

@wobsoriano@mikepitre