feat(ui): migrate Mosaic Button to StyleX - #9208

Merged
alexcarpenter merged 12 commits into
mainfrom
migrate-mosaic-to-stylex
Jul 22, 2026
Merged

feat(ui): migrate Mosaic Button to StyleX#9208
alexcarpenter merged 12 commits into
mainfrom
migrate-mosaic-to-stylex

Conversation

@alexcarpenter

@alexcarpenteralexcarpenter commented Jul 21, 2026

Copy link
Copy Markdown
Member

Mosaic Button: Emotion → StyleX. Compile-time atomic CSS, static sheet, zero runtime.

What

  • tokens.stylex.ts: --cl-* vars (oklch + light-dark())
  • props.ts: public contract — .cl-<slot> class + data-<axis> attrs + class/style merge
  • Button → plain StyleX, foldered: components/button/{button,button.styles,index,button.test}
  • isolated build:mosaic (tsdown + rollup-plugin) → dist-mosaic/styles.css, export @clerk/ui/styles.css
  • all 9 @stylexjs eslint rules on src/mosaic/**

Swingset

  • consumes Mosaic from source (@clerk/ui/mosaic aliased to ../ui/src/mosaic)
  • StyleX split two ways, same babel version/opts so atom hashes match:
    • next.config unplugin → compiles StyleX JS only (calls become static atoms, nothing hits runtime; SWC/Emotion/next/font untouched)
    • postcss plugin → owns CSS, replaces @stylex; in globals.css (dev "no CSS asset" warning expected)
  • useCSSLayers: true (matches published build) → atoms carry StyleX @layer priorityN precedence; consumers pick the outer layer at import: @import '@clerk/ui/styles.css' layer(components)
  • lightningcss targets pinned to browsers with native light-dark()/oklch() (no down-level to invalid polyfill)

Notes

  • Mosaic internal/unreleased → empty changeset, no back-compat constraint
  • org views: sxstyle on new Button

@changeset-bot

changeset-botBot commented Jul 21, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 09be4be

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 0 packages

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel

vercelBot commented Jul 21, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxReadyReadyPreview, CommentJul 22, 2026 7:24pm
swingsetReadyReadyPreview, CommentJul 22, 2026 7:24pm

Request Review

@pkg-pr-new

pkg-pr-newBot commented Jul 21, 2026

Copy link
Copy Markdown

Open in StackBlitz

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@9208

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@9208

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@9208

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@9208

@clerk/electron

npm i https://pkg.pr.new/@clerk/electron@9208

@clerk/electron-passkeys

npm i https://pkg.pr.new/@clerk/electron-passkeys@9208

@clerk/eslint-plugin

npm i https://pkg.pr.new/@clerk/eslint-plugin@9208

@clerk/expo

npm i https://pkg.pr.new/@clerk/expo@9208

@clerk/expo-google-signin

npm i https://pkg.pr.new/@clerk/expo-google-signin@9208

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@9208

@clerk/express

npm i https://pkg.pr.new/@clerk/express@9208

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@9208

@clerk/hono

npm i https://pkg.pr.new/@clerk/hono@9208

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@9208

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@9208

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@9208

@clerk/react

npm i https://pkg.pr.new/@clerk/react@9208

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@9208

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@9208

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@9208

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@9208

@clerk/ui

npm i https://pkg.pr.new/@clerk/ui@9208

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@9208

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@9208

commit: 09be4be

@coderabbitai

coderabbitaiBot commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

  • @coderabbitai resume to resume automatic reviews.
  • @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

  • ▶️ Resume reviews
  • 🔍 Trigger review
📝 Walkthrough

Walkthrough

The PR migrates Mosaic button styling to StyleX by adding tokens, prop helpers, button styles, component exports, tests, isolated CSS extraction, package exports, lint and test integration, and Swingset webpack/PostCSS configuration. Organization views replace sx styling with inline styles, and the Button story defines variant metadata inline.

Estimated code review effort: 4 (Complex) | ~60 minutes

Suggested reviewers:kylemac

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check nameStatusExplanationResolution
Docstring Coverage⚠️ WarningDocstring coverage is 44.44% which is insufficient. The required threshold is 80.00%.Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check nameStatusExplanation
Title check✅ PassedThe title accurately summarizes the main change: migrating the Mosaic Button to StyleX.
Description check✅ PassedThe description is detailed and directly matches the StyleX migration and related build/config changes.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.

Comment @coderabbitai help to get the list of available commands.

@coderabbitaicoderabbitaiBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 4

🧹 Nitpick comments (1)
packages/ui/src/mosaic/styles/index.ts (1)

7-22: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick win

Avoid growing this index.ts re-export barrel.

Move this curated build entry to a named module (for example, mosaic-stylex.ts) and point tsdown.mosaic.config.mts to it. This avoids a circular-dependency hotspot as migrated components accumulate.

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@packages/ui/src/mosaic/styles/index.ts` around lines 7 - 22, Move the curated
exports and token type aliases from the styles index module into a dedicated
named entry module such as mosaic-stylex.ts, then update
tsdown.mosaic.config.mts to use that entry. Keep the existing exports and type
unions unchanged, and leave the index module free from further build-entry
growth.

Source: Coding guidelines

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@packages/swingset/next.config.mjs`:
- Around line 74-93: Use a single StyleX CSS extraction owner for Mosaic across
packages/swingset/next.config.mjs:74-93 and
packages/swingset/postcss.config.mjs:15-38. Update the stylexPlugin
configuration in next.config.mjs and the corresponding PostCSS configuration so
only one path emits CSS, while the other performs JS transforms only; preserve
matching StyleX options and avoid duplicate atom output.
In `@packages/swingset/src/stories/button.stories.tsx`:
- Line 16: Update the Button story’s source path to reference the migrated
exporter at the nested button/button.tsx location, ensuring the Story “View
source” link resolves correctly.
In `@packages/ui/package.json`:
- Around line 75-83: Update the package.json build script to invoke the existing
build:mosaic script as part of the normal build sequence, ensuring
dist-mosaic/styles.css is generated before the package is published.
In `@packages/ui/src/mosaic/components/button/button.test.tsx`:
- Around line 13-21: Extend the “applies default variants when none are passed”
test for the Button component to assert that the rendered button has
type="button". Keep the existing default variant assertions unchanged.
---
Nitpick comments:
In `@packages/ui/src/mosaic/styles/index.ts`:
- Around line 7-22: Move the curated exports and token type aliases from the
styles index module into a dedicated named entry module such as
mosaic-stylex.ts, then update tsdown.mosaic.config.mts to use that entry. Keep
the existing exports and type unions unchanged, and leave the index module free
from further build-entry growth.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: 8e28f65c-c34e-42fa-8812-9d706f10ac7e

📥 Commits

Reviewing files that changed from the base of the PR and between 5070797 and d70595f.

⛔ Files ignored due to path filters (1)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (29)
  • .changeset/mosaic-stylex-migration.md
  • .gitignore
  • eslint.config.mjs
  • package.json
  • packages/swingset/next.config.mjs
  • packages/swingset/package.json
  • packages/swingset/postcss.config.mjs
  • packages/swingset/src/app/globals.css
  • packages/swingset/src/stories/button.stories.tsx
  • packages/ui/package.json
  • packages/ui/src/mosaic/__tests__/props.test.ts
  • packages/ui/src/mosaic/components/__tests__/button.test.tsx
  • packages/ui/src/mosaic/components/button.tsx
  • packages/ui/src/mosaic/components/button/button.styles.ts
  • packages/ui/src/mosaic/components/button/button.test.tsx
  • packages/ui/src/mosaic/components/button/button.tsx
  • packages/ui/src/mosaic/components/button/index.ts
  • packages/ui/src/mosaic/organization/organization-profile-delete-section.view.tsx
  • packages/ui/src/mosaic/organization/organization-profile-domains-section.view.tsx
  • packages/ui/src/mosaic/organization/organization-profile-leave-section.view.tsx
  • packages/ui/src/mosaic/organization/organization-profile-members-panel.view.tsx
  • packages/ui/src/mosaic/organization/organization-profile-profile-section.view.tsx
  • packages/ui/src/mosaic/props.ts
  • packages/ui/src/mosaic/styles/index.ts
  • packages/ui/src/mosaic/tokens.stylex.ts
  • packages/ui/styles.css.d.ts
  • packages/ui/tsconfig.mosaic.json
  • packages/ui/tsdown.mosaic.config.mts
  • packages/ui/vitest.config.mts
🔗 Linked repositories identified

CodeRabbit considers these linked repositories for cross-repo context during reviews:

  • clerk/clerk_go(manual)
  • clerk/dashboard(manual)
  • clerk/accounts(manual)
  • clerk/backoffice(manual)
  • clerk/clerk(manual)
  • clerk/clerk-docs(manual)
  • clerk/cloudflare-workers(manual)
💤 Files with no reviewable changes (2)
  • packages/ui/src/mosaic/components/tests/button.test.tsx
  • packages/ui/src/mosaic/components/button.tsx

Comment threadpackages/swingset/next.config.mjs
Comment threadpackages/swingset/src/stories/button.stories.tsx Outdated
Comment threadpackages/ui/package.json
Comment threadpackages/ui/src/mosaic/components/button/button.test.tsx
@github-actions

github-actionsBot commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

API Changes Report

Generated by Break Check on 2026-07-22T19:25:18.932Z

Summary

MetricCount
Packages analyzed19
Packages with changes1
🔴 Breaking changes0
🟡 Non-breaking changes0
🟢 Additions1

@clerk/ui

Current version: 1.25.7
Recommended bump: MINOR → 1.26.0

Subpath ./styles.css

🟢 Additions (1)

Added: ./styles.css

New subpath export ./styles.css


Report generated by Break Check

Last ran on 09be4be.

@alexcarpenter

Copy link
Copy Markdown
MemberAuthor

Nitpick — styles/index.ts barrel → named module: leaving as-is. It's the isolated build entry (tsdown.mosaic.config.mts), imported by nothing else; depends on components/tokens/props one-directionally, so no circular-dep risk.

@wobsorianowobsoriano left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very exciting

Comment threadpackages/ui/package.json Outdated
Swingset extracts Mosaic CSS via the postcss-plugin glob scanner, not the
webpack module graph, so the entry never guarded anything; verified swingset's
emitted CSS is byte-identical without it. src is unpublished, so it was inert
for consumers too. dist-mosaic/styles.css remains the tracked CSS side effect.
…ostcss include)
The unplugin transforms JS only and emits no CSS, so its lightningcssOptions
never processed a sheet; and the postcss include glob was redundant — production
CSS is byte-identical without both. Verified against a positive control.
lightningcss down-leveling is only a concern in the published rollup build
(tsdown.mosaic.config.mts), which keeps its targets.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@alexcarpenter@dstaley@wobsoriano
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Skip to content

feat(ui): migrate Mosaic Button to StyleX - #9208

Merged
alexcarpenter merged 12 commits into
mainfrom
migrate-mosaic-to-stylex
Jul 22, 2026
Merged

feat(ui): migrate Mosaic Button to StyleX#9208
alexcarpenter merged 12 commits into
mainfrom
migrate-mosaic-to-stylex

Conversation

@alexcarpenter

@alexcarpenteralexcarpenter commented Jul 21, 2026

Copy link
Copy Markdown
Member

Mosaic Button: Emotion → StyleX. Compile-time atomic CSS, static sheet, zero runtime.

What

  • tokens.stylex.ts: --cl-* vars (oklch + light-dark())
  • props.ts: public contract — .cl-<slot> class + data-<axis> attrs + class/style merge
  • Button → plain StyleX, foldered: components/button/{button,button.styles,index,button.test}
  • isolated build:mosaic (tsdown + rollup-plugin) → dist-mosaic/styles.css, export @clerk/ui/styles.css
  • all 9 @stylexjs eslint rules on src/mosaic/**

Swingset

  • consumes Mosaic from source (@clerk/ui/mosaic aliased to ../ui/src/mosaic)
  • StyleX split two ways, same babel version/opts so atom hashes match:
    • next.config unplugin → compiles StyleX JS only (calls become static atoms, nothing hits runtime; SWC/Emotion/next/font untouched)
    • postcss plugin → owns CSS, replaces @stylex; in globals.css (dev "no CSS asset" warning expected)
  • useCSSLayers: true (matches published build) → atoms carry StyleX @layer priorityN precedence; consumers pick the outer layer at import: @import '@clerk/ui/styles.css' layer(components)
  • lightningcss targets pinned to browsers with native light-dark()/oklch() (no down-level to invalid polyfill)

Notes

  • Mosaic internal/unreleased → empty changeset, no back-compat constraint
  • org views: sxstyle on new Button

@changeset-bot

changeset-botBot commented Jul 21, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 09be4be

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 0 packages

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel

vercelBot commented Jul 21, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxReadyReadyPreview, CommentJul 22, 2026 7:24pm
swingsetReadyReadyPreview, CommentJul 22, 2026 7:24pm

Request Review

@pkg-pr-new

pkg-pr-newBot commented Jul 21, 2026

Copy link
Copy Markdown

Open in StackBlitz

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@9208

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@9208

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@9208

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@9208

@clerk/electron

npm i https://pkg.pr.new/@clerk/electron@9208

@clerk/electron-passkeys

npm i https://pkg.pr.new/@clerk/electron-passkeys@9208

@clerk/eslint-plugin

npm i https://pkg.pr.new/@clerk/eslint-plugin@9208

@clerk/expo

npm i https://pkg.pr.new/@clerk/expo@9208

@clerk/expo-google-signin

npm i https://pkg.pr.new/@clerk/expo-google-signin@9208

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@9208

@clerk/express

npm i https://pkg.pr.new/@clerk/express@9208

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@9208

@clerk/hono

npm i https://pkg.pr.new/@clerk/hono@9208

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@9208

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@9208

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@9208

@clerk/react

npm i https://pkg.pr.new/@clerk/react@9208

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@9208

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@9208

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@9208

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@9208

@clerk/ui

npm i https://pkg.pr.new/@clerk/ui@9208

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@9208

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@9208

commit: 09be4be

@coderabbitai

coderabbitaiBot commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

  • @coderabbitai resume to resume automatic reviews.
  • @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

  • ▶️ Resume reviews
  • 🔍 Trigger review
📝 Walkthrough

Walkthrough

The PR migrates Mosaic button styling to StyleX by adding tokens, prop helpers, button styles, component exports, tests, isolated CSS extraction, package exports, lint and test integration, and Swingset webpack/PostCSS configuration. Organization views replace sx styling with inline styles, and the Button story defines variant metadata inline.

Estimated code review effort: 4 (Complex) | ~60 minutes

Suggested reviewers:kylemac

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check nameStatusExplanationResolution
Docstring Coverage⚠️ WarningDocstring coverage is 44.44% which is insufficient. The required threshold is 80.00%.Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check nameStatusExplanation
Title check✅ PassedThe title accurately summarizes the main change: migrating the Mosaic Button to StyleX.
Description check✅ PassedThe description is detailed and directly matches the StyleX migration and related build/config changes.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.

Comment @coderabbitai help to get the list of available commands.

@coderabbitaicoderabbitaiBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 4

🧹 Nitpick comments (1)
packages/ui/src/mosaic/styles/index.ts (1)

7-22: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick win

Avoid growing this index.ts re-export barrel.

Move this curated build entry to a named module (for example, mosaic-stylex.ts) and point tsdown.mosaic.config.mts to it. This avoids a circular-dependency hotspot as migrated components accumulate.

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@packages/ui/src/mosaic/styles/index.ts` around lines 7 - 22, Move the curated
exports and token type aliases from the styles index module into a dedicated
named entry module such as mosaic-stylex.ts, then update
tsdown.mosaic.config.mts to use that entry. Keep the existing exports and type
unions unchanged, and leave the index module free from further build-entry
growth.

Source: Coding guidelines

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@packages/swingset/next.config.mjs`:
- Around line 74-93: Use a single StyleX CSS extraction owner for Mosaic across
packages/swingset/next.config.mjs:74-93 and
packages/swingset/postcss.config.mjs:15-38. Update the stylexPlugin
configuration in next.config.mjs and the corresponding PostCSS configuration so
only one path emits CSS, while the other performs JS transforms only; preserve
matching StyleX options and avoid duplicate atom output.
In `@packages/swingset/src/stories/button.stories.tsx`:
- Line 16: Update the Button story’s source path to reference the migrated
exporter at the nested button/button.tsx location, ensuring the Story “View
source” link resolves correctly.
In `@packages/ui/package.json`:
- Around line 75-83: Update the package.json build script to invoke the existing
build:mosaic script as part of the normal build sequence, ensuring
dist-mosaic/styles.css is generated before the package is published.
In `@packages/ui/src/mosaic/components/button/button.test.tsx`:
- Around line 13-21: Extend the “applies default variants when none are passed”
test for the Button component to assert that the rendered button has
type="button". Keep the existing default variant assertions unchanged.
---
Nitpick comments:
In `@packages/ui/src/mosaic/styles/index.ts`:
- Around line 7-22: Move the curated exports and token type aliases from the
styles index module into a dedicated named entry module such as
mosaic-stylex.ts, then update tsdown.mosaic.config.mts to use that entry. Keep
the existing exports and type unions unchanged, and leave the index module free
from further build-entry growth.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: 8e28f65c-c34e-42fa-8812-9d706f10ac7e

📥 Commits

Reviewing files that changed from the base of the PR and between 5070797 and d70595f.

⛔ Files ignored due to path filters (1)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (29)
  • .changeset/mosaic-stylex-migration.md
  • .gitignore
  • eslint.config.mjs
  • package.json
  • packages/swingset/next.config.mjs
  • packages/swingset/package.json
  • packages/swingset/postcss.config.mjs
  • packages/swingset/src/app/globals.css
  • packages/swingset/src/stories/button.stories.tsx
  • packages/ui/package.json
  • packages/ui/src/mosaic/__tests__/props.test.ts
  • packages/ui/src/mosaic/components/__tests__/button.test.tsx
  • packages/ui/src/mosaic/components/button.tsx
  • packages/ui/src/mosaic/components/button/button.styles.ts
  • packages/ui/src/mosaic/components/button/button.test.tsx
  • packages/ui/src/mosaic/components/button/button.tsx
  • packages/ui/src/mosaic/components/button/index.ts
  • packages/ui/src/mosaic/organization/organization-profile-delete-section.view.tsx
  • packages/ui/src/mosaic/organization/organization-profile-domains-section.view.tsx
  • packages/ui/src/mosaic/organization/organization-profile-leave-section.view.tsx
  • packages/ui/src/mosaic/organization/organization-profile-members-panel.view.tsx
  • packages/ui/src/mosaic/organization/organization-profile-profile-section.view.tsx
  • packages/ui/src/mosaic/props.ts
  • packages/ui/src/mosaic/styles/index.ts
  • packages/ui/src/mosaic/tokens.stylex.ts
  • packages/ui/styles.css.d.ts
  • packages/ui/tsconfig.mosaic.json
  • packages/ui/tsdown.mosaic.config.mts
  • packages/ui/vitest.config.mts
🔗 Linked repositories identified

CodeRabbit considers these linked repositories for cross-repo context during reviews:

  • clerk/clerk_go(manual)
  • clerk/dashboard(manual)
  • clerk/accounts(manual)
  • clerk/backoffice(manual)
  • clerk/clerk(manual)
  • clerk/clerk-docs(manual)
  • clerk/cloudflare-workers(manual)
💤 Files with no reviewable changes (2)
  • packages/ui/src/mosaic/components/tests/button.test.tsx
  • packages/ui/src/mosaic/components/button.tsx

Comment threadpackages/swingset/next.config.mjs
Comment threadpackages/swingset/src/stories/button.stories.tsx Outdated
Comment threadpackages/ui/package.json
Comment threadpackages/ui/src/mosaic/components/button/button.test.tsx
@github-actions

github-actionsBot commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

API Changes Report

Generated by Break Check on 2026-07-22T19:25:18.932Z

Summary

MetricCount
Packages analyzed19
Packages with changes1
🔴 Breaking changes0
🟡 Non-breaking changes0
🟢 Additions1

@clerk/ui

Current version: 1.25.7
Recommended bump: MINOR → 1.26.0

Subpath ./styles.css

🟢 Additions (1)

Added: ./styles.css

New subpath export ./styles.css


Report generated by Break Check

Last ran on 09be4be.

@alexcarpenter

Copy link
Copy Markdown
MemberAuthor

Nitpick — styles/index.ts barrel → named module: leaving as-is. It's the isolated build entry (tsdown.mosaic.config.mts), imported by nothing else; depends on components/tokens/props one-directionally, so no circular-dep risk.

@wobsorianowobsoriano left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very exciting

Comment threadpackages/ui/package.json Outdated
Swingset extracts Mosaic CSS via the postcss-plugin glob scanner, not the
webpack module graph, so the entry never guarded anything; verified swingset's
emitted CSS is byte-identical without it. src is unpublished, so it was inert
for consumers too. dist-mosaic/styles.css remains the tracked CSS side effect.
…ostcss include)
The unplugin transforms JS only and emits no CSS, so its lightningcssOptions
never processed a sheet; and the postcss include glob was redundant — production
CSS is byte-identical without both. Verified against a positive control.
lightningcss down-leveling is only a concern in the published rollup build
(tsdown.mosaic.config.mts), which keeps its targets.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@alexcarpenter@dstaley@wobsoriano
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix"); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

feat(ui): migrate Mosaic Button to StyleX - #9208

Merged
alexcarpenter merged 12 commits into
mainfrom
migrate-mosaic-to-stylex
Jul 22, 2026
Merged

feat(ui): migrate Mosaic Button to StyleX#9208
alexcarpenter merged 12 commits into
mainfrom
migrate-mosaic-to-stylex

Conversation

@alexcarpenter

@alexcarpenteralexcarpenter commented Jul 21, 2026

Copy link
Copy Markdown
Member

Mosaic Button: Emotion → StyleX. Compile-time atomic CSS, static sheet, zero runtime.

What

  • tokens.stylex.ts: --cl-* vars (oklch + light-dark())
  • props.ts: public contract — .cl-<slot> class + data-<axis> attrs + class/style merge
  • Button → plain StyleX, foldered: components/button/{button,button.styles,index,button.test}
  • isolated build:mosaic (tsdown + rollup-plugin) → dist-mosaic/styles.css, export @clerk/ui/styles.css
  • all 9 @stylexjs eslint rules on src/mosaic/**

Swingset

  • consumes Mosaic from source (@clerk/ui/mosaic aliased to ../ui/src/mosaic)
  • StyleX split two ways, same babel version/opts so atom hashes match:
    • next.config unplugin → compiles StyleX JS only (calls become static atoms, nothing hits runtime; SWC/Emotion/next/font untouched)
    • postcss plugin → owns CSS, replaces @stylex; in globals.css (dev "no CSS asset" warning expected)
  • useCSSLayers: true (matches published build) → atoms carry StyleX @layer priorityN precedence; consumers pick the outer layer at import: @import '@clerk/ui/styles.css' layer(components)
  • lightningcss targets pinned to browsers with native light-dark()/oklch() (no down-level to invalid polyfill)

Notes

  • Mosaic internal/unreleased → empty changeset, no back-compat constraint
  • org views: sxstyle on new Button

@changeset-bot

changeset-botBot commented Jul 21, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 09be4be

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 0 packages

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel

vercelBot commented Jul 21, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxReadyReadyPreview, CommentJul 22, 2026 7:24pm
swingsetReadyReadyPreview, CommentJul 22, 2026 7:24pm

Request Review

@pkg-pr-new

pkg-pr-newBot commented Jul 21, 2026

Copy link
Copy Markdown

Open in StackBlitz

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@9208

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@9208

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@9208

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@9208

@clerk/electron

npm i https://pkg.pr.new/@clerk/electron@9208

@clerk/electron-passkeys

npm i https://pkg.pr.new/@clerk/electron-passkeys@9208

@clerk/eslint-plugin

npm i https://pkg.pr.new/@clerk/eslint-plugin@9208

@clerk/expo

npm i https://pkg.pr.new/@clerk/expo@9208

@clerk/expo-google-signin

npm i https://pkg.pr.new/@clerk/expo-google-signin@9208

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@9208

@clerk/express

npm i https://pkg.pr.new/@clerk/express@9208

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@9208

@clerk/hono

npm i https://pkg.pr.new/@clerk/hono@9208

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@9208

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@9208

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@9208

@clerk/react

npm i https://pkg.pr.new/@clerk/react@9208

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@9208

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@9208

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@9208

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@9208

@clerk/ui

npm i https://pkg.pr.new/@clerk/ui@9208

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@9208

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@9208

commit: 09be4be

@coderabbitai

coderabbitaiBot commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

  • @coderabbitai resume to resume automatic reviews.
  • @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

  • ▶️ Resume reviews
  • 🔍 Trigger review
📝 Walkthrough

Walkthrough

The PR migrates Mosaic button styling to StyleX by adding tokens, prop helpers, button styles, component exports, tests, isolated CSS extraction, package exports, lint and test integration, and Swingset webpack/PostCSS configuration. Organization views replace sx styling with inline styles, and the Button story defines variant metadata inline.

Estimated code review effort: 4 (Complex) | ~60 minutes

Suggested reviewers:kylemac

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check nameStatusExplanationResolution
Docstring Coverage⚠️ WarningDocstring coverage is 44.44% which is insufficient. The required threshold is 80.00%.Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check nameStatusExplanation
Title check✅ PassedThe title accurately summarizes the main change: migrating the Mosaic Button to StyleX.
Description check✅ PassedThe description is detailed and directly matches the StyleX migration and related build/config changes.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.

Comment @coderabbitai help to get the list of available commands.

@coderabbitaicoderabbitaiBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 4

🧹 Nitpick comments (1)
packages/ui/src/mosaic/styles/index.ts (1)

7-22: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick win

Avoid growing this index.ts re-export barrel.

Move this curated build entry to a named module (for example, mosaic-stylex.ts) and point tsdown.mosaic.config.mts to it. This avoids a circular-dependency hotspot as migrated components accumulate.

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@packages/ui/src/mosaic/styles/index.ts` around lines 7 - 22, Move the curated
exports and token type aliases from the styles index module into a dedicated
named entry module such as mosaic-stylex.ts, then update
tsdown.mosaic.config.mts to use that entry. Keep the existing exports and type
unions unchanged, and leave the index module free from further build-entry
growth.

Source: Coding guidelines

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@packages/swingset/next.config.mjs`:
- Around line 74-93: Use a single StyleX CSS extraction owner for Mosaic across
packages/swingset/next.config.mjs:74-93 and
packages/swingset/postcss.config.mjs:15-38. Update the stylexPlugin
configuration in next.config.mjs and the corresponding PostCSS configuration so
only one path emits CSS, while the other performs JS transforms only; preserve
matching StyleX options and avoid duplicate atom output.
In `@packages/swingset/src/stories/button.stories.tsx`:
- Line 16: Update the Button story’s source path to reference the migrated
exporter at the nested button/button.tsx location, ensuring the Story “View
source” link resolves correctly.
In `@packages/ui/package.json`:
- Around line 75-83: Update the package.json build script to invoke the existing
build:mosaic script as part of the normal build sequence, ensuring
dist-mosaic/styles.css is generated before the package is published.
In `@packages/ui/src/mosaic/components/button/button.test.tsx`:
- Around line 13-21: Extend the “applies default variants when none are passed”
test for the Button component to assert that the rendered button has
type="button". Keep the existing default variant assertions unchanged.
---
Nitpick comments:
In `@packages/ui/src/mosaic/styles/index.ts`:
- Around line 7-22: Move the curated exports and token type aliases from the
styles index module into a dedicated named entry module such as
mosaic-stylex.ts, then update tsdown.mosaic.config.mts to use that entry. Keep
the existing exports and type unions unchanged, and leave the index module free
from further build-entry growth.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: 8e28f65c-c34e-42fa-8812-9d706f10ac7e

📥 Commits

Reviewing files that changed from the base of the PR and between 5070797 and d70595f.

⛔ Files ignored due to path filters (1)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (29)
  • .changeset/mosaic-stylex-migration.md
  • .gitignore
  • eslint.config.mjs
  • package.json
  • packages/swingset/next.config.mjs
  • packages/swingset/package.json
  • packages/swingset/postcss.config.mjs
  • packages/swingset/src/app/globals.css
  • packages/swingset/src/stories/button.stories.tsx
  • packages/ui/package.json
  • packages/ui/src/mosaic/__tests__/props.test.ts
  • packages/ui/src/mosaic/components/__tests__/button.test.tsx
  • packages/ui/src/mosaic/components/button.tsx
  • packages/ui/src/mosaic/components/button/button.styles.ts
  • packages/ui/src/mosaic/components/button/button.test.tsx
  • packages/ui/src/mosaic/components/button/button.tsx
  • packages/ui/src/mosaic/components/button/index.ts
  • packages/ui/src/mosaic/organization/organization-profile-delete-section.view.tsx
  • packages/ui/src/mosaic/organization/organization-profile-domains-section.view.tsx
  • packages/ui/src/mosaic/organization/organization-profile-leave-section.view.tsx
  • packages/ui/src/mosaic/organization/organization-profile-members-panel.view.tsx
  • packages/ui/src/mosaic/organization/organization-profile-profile-section.view.tsx
  • packages/ui/src/mosaic/props.ts
  • packages/ui/src/mosaic/styles/index.ts
  • packages/ui/src/mosaic/tokens.stylex.ts
  • packages/ui/styles.css.d.ts
  • packages/ui/tsconfig.mosaic.json
  • packages/ui/tsdown.mosaic.config.mts
  • packages/ui/vitest.config.mts
🔗 Linked repositories identified

CodeRabbit considers these linked repositories for cross-repo context during reviews:

  • clerk/clerk_go(manual)
  • clerk/dashboard(manual)
  • clerk/accounts(manual)
  • clerk/backoffice(manual)
  • clerk/clerk(manual)
  • clerk/clerk-docs(manual)
  • clerk/cloudflare-workers(manual)
💤 Files with no reviewable changes (2)
  • packages/ui/src/mosaic/components/tests/button.test.tsx
  • packages/ui/src/mosaic/components/button.tsx

Comment threadpackages/swingset/next.config.mjs
Comment threadpackages/swingset/src/stories/button.stories.tsx Outdated
Comment threadpackages/ui/package.json
Comment threadpackages/ui/src/mosaic/components/button/button.test.tsx
@github-actions

github-actionsBot commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

API Changes Report

Generated by Break Check on 2026-07-22T19:25:18.932Z

Summary

MetricCount
Packages analyzed19
Packages with changes1
🔴 Breaking changes0
🟡 Non-breaking changes0
🟢 Additions1

@clerk/ui

Current version: 1.25.7
Recommended bump: MINOR → 1.26.0

Subpath ./styles.css

🟢 Additions (1)

Added: ./styles.css

New subpath export ./styles.css


Report generated by Break Check

Last ran on 09be4be.

@alexcarpenter

Copy link
Copy Markdown
MemberAuthor

Nitpick — styles/index.ts barrel → named module: leaving as-is. It's the isolated build entry (tsdown.mosaic.config.mts), imported by nothing else; depends on components/tokens/props one-directionally, so no circular-dep risk.

@wobsorianowobsoriano left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very exciting

Comment threadpackages/ui/package.json Outdated
Swingset extracts Mosaic CSS via the postcss-plugin glob scanner, not the
webpack module graph, so the entry never guarded anything; verified swingset's
emitted CSS is byte-identical without it. src is unpublished, so it was inert
for consumers too. dist-mosaic/styles.css remains the tracked CSS side effect.
…ostcss include)
The unplugin transforms JS only and emits no CSS, so its lightningcssOptions
never processed a sheet; and the postcss include glob was redundant — production
CSS is byte-identical without both. Verified against a positive control.
lightningcss down-leveling is only a concern in the published rollup build
(tsdown.mosaic.config.mts), which keeps its targets.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@alexcarpenter@dstaley@wobsoriano
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms"); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

feat(ui): migrate Mosaic Button to StyleX - #9208

Merged
alexcarpenter merged 12 commits into
mainfrom
migrate-mosaic-to-stylex
Jul 22, 2026
Merged

feat(ui): migrate Mosaic Button to StyleX#9208
alexcarpenter merged 12 commits into
mainfrom
migrate-mosaic-to-stylex

Conversation

@alexcarpenter

@alexcarpenteralexcarpenter commented Jul 21, 2026

Copy link
Copy Markdown
Member

Mosaic Button: Emotion → StyleX. Compile-time atomic CSS, static sheet, zero runtime.

What

  • tokens.stylex.ts: --cl-* vars (oklch + light-dark())
  • props.ts: public contract — .cl-<slot> class + data-<axis> attrs + class/style merge
  • Button → plain StyleX, foldered: components/button/{button,button.styles,index,button.test}
  • isolated build:mosaic (tsdown + rollup-plugin) → dist-mosaic/styles.css, export @clerk/ui/styles.css
  • all 9 @stylexjs eslint rules on src/mosaic/**

Swingset

  • consumes Mosaic from source (@clerk/ui/mosaic aliased to ../ui/src/mosaic)
  • StyleX split two ways, same babel version/opts so atom hashes match:
    • next.config unplugin → compiles StyleX JS only (calls become static atoms, nothing hits runtime; SWC/Emotion/next/font untouched)
    • postcss plugin → owns CSS, replaces @stylex; in globals.css (dev "no CSS asset" warning expected)
  • useCSSLayers: true (matches published build) → atoms carry StyleX @layer priorityN precedence; consumers pick the outer layer at import: @import '@clerk/ui/styles.css' layer(components)
  • lightningcss targets pinned to browsers with native light-dark()/oklch() (no down-level to invalid polyfill)

Notes

  • Mosaic internal/unreleased → empty changeset, no back-compat constraint
  • org views: sxstyle on new Button

@changeset-bot

changeset-botBot commented Jul 21, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 09be4be

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 0 packages

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel

vercelBot commented Jul 21, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxReadyReadyPreview, CommentJul 22, 2026 7:24pm
swingsetReadyReadyPreview, CommentJul 22, 2026 7:24pm

Request Review

@pkg-pr-new

pkg-pr-newBot commented Jul 21, 2026

Copy link
Copy Markdown

Open in StackBlitz

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@9208

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@9208

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@9208

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@9208

@clerk/electron

npm i https://pkg.pr.new/@clerk/electron@9208

@clerk/electron-passkeys

npm i https://pkg.pr.new/@clerk/electron-passkeys@9208

@clerk/eslint-plugin

npm i https://pkg.pr.new/@clerk/eslint-plugin@9208

@clerk/expo

npm i https://pkg.pr.new/@clerk/expo@9208

@clerk/expo-google-signin

npm i https://pkg.pr.new/@clerk/expo-google-signin@9208

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@9208

@clerk/express

npm i https://pkg.pr.new/@clerk/express@9208

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@9208

@clerk/hono

npm i https://pkg.pr.new/@clerk/hono@9208

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@9208

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@9208

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@9208

@clerk/react

npm i https://pkg.pr.new/@clerk/react@9208

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@9208

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@9208

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@9208

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@9208

@clerk/ui

npm i https://pkg.pr.new/@clerk/ui@9208

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@9208

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@9208

commit: 09be4be

@coderabbitai

coderabbitaiBot commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

  • @coderabbitai resume to resume automatic reviews.
  • @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

  • ▶️ Resume reviews
  • 🔍 Trigger review
📝 Walkthrough

Walkthrough

The PR migrates Mosaic button styling to StyleX by adding tokens, prop helpers, button styles, component exports, tests, isolated CSS extraction, package exports, lint and test integration, and Swingset webpack/PostCSS configuration. Organization views replace sx styling with inline styles, and the Button story defines variant metadata inline.

Estimated code review effort: 4 (Complex) | ~60 minutes

Suggested reviewers:kylemac

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check nameStatusExplanationResolution
Docstring Coverage⚠️ WarningDocstring coverage is 44.44% which is insufficient. The required threshold is 80.00%.Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check nameStatusExplanation
Title check✅ PassedThe title accurately summarizes the main change: migrating the Mosaic Button to StyleX.
Description check✅ PassedThe description is detailed and directly matches the StyleX migration and related build/config changes.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.

Comment @coderabbitai help to get the list of available commands.

@coderabbitaicoderabbitaiBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 4

🧹 Nitpick comments (1)
packages/ui/src/mosaic/styles/index.ts (1)

7-22: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick win

Avoid growing this index.ts re-export barrel.

Move this curated build entry to a named module (for example, mosaic-stylex.ts) and point tsdown.mosaic.config.mts to it. This avoids a circular-dependency hotspot as migrated components accumulate.

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@packages/ui/src/mosaic/styles/index.ts` around lines 7 - 22, Move the curated
exports and token type aliases from the styles index module into a dedicated
named entry module such as mosaic-stylex.ts, then update
tsdown.mosaic.config.mts to use that entry. Keep the existing exports and type
unions unchanged, and leave the index module free from further build-entry
growth.

Source: Coding guidelines

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@packages/swingset/next.config.mjs`:
- Around line 74-93: Use a single StyleX CSS extraction owner for Mosaic across
packages/swingset/next.config.mjs:74-93 and
packages/swingset/postcss.config.mjs:15-38. Update the stylexPlugin
configuration in next.config.mjs and the corresponding PostCSS configuration so
only one path emits CSS, while the other performs JS transforms only; preserve
matching StyleX options and avoid duplicate atom output.
In `@packages/swingset/src/stories/button.stories.tsx`:
- Line 16: Update the Button story’s source path to reference the migrated
exporter at the nested button/button.tsx location, ensuring the Story “View
source” link resolves correctly.
In `@packages/ui/package.json`:
- Around line 75-83: Update the package.json build script to invoke the existing
build:mosaic script as part of the normal build sequence, ensuring
dist-mosaic/styles.css is generated before the package is published.
In `@packages/ui/src/mosaic/components/button/button.test.tsx`:
- Around line 13-21: Extend the “applies default variants when none are passed”
test for the Button component to assert that the rendered button has
type="button". Keep the existing default variant assertions unchanged.
---
Nitpick comments:
In `@packages/ui/src/mosaic/styles/index.ts`:
- Around line 7-22: Move the curated exports and token type aliases from the
styles index module into a dedicated named entry module such as
mosaic-stylex.ts, then update tsdown.mosaic.config.mts to use that entry. Keep
the existing exports and type unions unchanged, and leave the index module free
from further build-entry growth.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: 8e28f65c-c34e-42fa-8812-9d706f10ac7e

📥 Commits

Reviewing files that changed from the base of the PR and between 5070797 and d70595f.

⛔ Files ignored due to path filters (1)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (29)
  • .changeset/mosaic-stylex-migration.md
  • .gitignore
  • eslint.config.mjs
  • package.json
  • packages/swingset/next.config.mjs
  • packages/swingset/package.json
  • packages/swingset/postcss.config.mjs
  • packages/swingset/src/app/globals.css
  • packages/swingset/src/stories/button.stories.tsx
  • packages/ui/package.json
  • packages/ui/src/mosaic/__tests__/props.test.ts
  • packages/ui/src/mosaic/components/__tests__/button.test.tsx
  • packages/ui/src/mosaic/components/button.tsx
  • packages/ui/src/mosaic/components/button/button.styles.ts
  • packages/ui/src/mosaic/components/button/button.test.tsx
  • packages/ui/src/mosaic/components/button/button.tsx
  • packages/ui/src/mosaic/components/button/index.ts
  • packages/ui/src/mosaic/organization/organization-profile-delete-section.view.tsx
  • packages/ui/src/mosaic/organization/organization-profile-domains-section.view.tsx
  • packages/ui/src/mosaic/organization/organization-profile-leave-section.view.tsx
  • packages/ui/src/mosaic/organization/organization-profile-members-panel.view.tsx
  • packages/ui/src/mosaic/organization/organization-profile-profile-section.view.tsx
  • packages/ui/src/mosaic/props.ts
  • packages/ui/src/mosaic/styles/index.ts
  • packages/ui/src/mosaic/tokens.stylex.ts
  • packages/ui/styles.css.d.ts
  • packages/ui/tsconfig.mosaic.json
  • packages/ui/tsdown.mosaic.config.mts
  • packages/ui/vitest.config.mts
🔗 Linked repositories identified

CodeRabbit considers these linked repositories for cross-repo context during reviews:

  • clerk/clerk_go(manual)
  • clerk/dashboard(manual)
  • clerk/accounts(manual)
  • clerk/backoffice(manual)
  • clerk/clerk(manual)
  • clerk/clerk-docs(manual)
  • clerk/cloudflare-workers(manual)
💤 Files with no reviewable changes (2)
  • packages/ui/src/mosaic/components/tests/button.test.tsx
  • packages/ui/src/mosaic/components/button.tsx

Comment threadpackages/swingset/next.config.mjs
Comment threadpackages/swingset/src/stories/button.stories.tsx Outdated
Comment threadpackages/ui/package.json
Comment threadpackages/ui/src/mosaic/components/button/button.test.tsx
@github-actions

github-actionsBot commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

API Changes Report

Generated by Break Check on 2026-07-22T19:25:18.932Z

Summary

MetricCount
Packages analyzed19
Packages with changes1
🔴 Breaking changes0
🟡 Non-breaking changes0
🟢 Additions1

@clerk/ui

Current version: 1.25.7
Recommended bump: MINOR → 1.26.0

Subpath ./styles.css

🟢 Additions (1)

Added: ./styles.css

New subpath export ./styles.css


Report generated by Break Check

Last ran on 09be4be.

@alexcarpenter

Copy link
Copy Markdown
MemberAuthor

Nitpick — styles/index.ts barrel → named module: leaving as-is. It's the isolated build entry (tsdown.mosaic.config.mts), imported by nothing else; depends on components/tokens/props one-directionally, so no circular-dep risk.

@wobsorianowobsoriano left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very exciting

Comment threadpackages/ui/package.json Outdated
Swingset extracts Mosaic CSS via the postcss-plugin glob scanner, not the
webpack module graph, so the entry never guarded anything; verified swingset's
emitted CSS is byte-identical without it. src is unpublished, so it was inert
for consumers too. dist-mosaic/styles.css remains the tracked CSS side effect.
…ostcss include)
The unplugin transforms JS only and emits no CSS, so its lightningcssOptions
never processed a sheet; and the postcss include glob was redundant — production
CSS is byte-identical without both. Verified against a positive control.
lightningcss down-leveling is only a concern in the published rollup build
(tsdown.mosaic.config.mts), which keeps its targets.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@alexcarpenter@dstaley@wobsoriano
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links"); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + '
Skip to content

feat(ui): migrate Mosaic Button to StyleX - #9208

Merged
alexcarpenter merged 12 commits into
mainfrom
migrate-mosaic-to-stylex
Jul 22, 2026
Merged

feat(ui): migrate Mosaic Button to StyleX#9208
alexcarpenter merged 12 commits into
mainfrom
migrate-mosaic-to-stylex

Conversation

@alexcarpenter

@alexcarpenteralexcarpenter commented Jul 21, 2026

Copy link
Copy Markdown
Member

Mosaic Button: Emotion → StyleX. Compile-time atomic CSS, static sheet, zero runtime.

What

  • tokens.stylex.ts: --cl-* vars (oklch + light-dark())
  • props.ts: public contract — .cl-<slot> class + data-<axis> attrs + class/style merge
  • Button → plain StyleX, foldered: components/button/{button,button.styles,index,button.test}
  • isolated build:mosaic (tsdown + rollup-plugin) → dist-mosaic/styles.css, export @clerk/ui/styles.css
  • all 9 @stylexjs eslint rules on src/mosaic/**

Swingset

  • consumes Mosaic from source (@clerk/ui/mosaic aliased to ../ui/src/mosaic)
  • StyleX split two ways, same babel version/opts so atom hashes match:
    • next.config unplugin → compiles StyleX JS only (calls become static atoms, nothing hits runtime; SWC/Emotion/next/font untouched)
    • postcss plugin → owns CSS, replaces @stylex; in globals.css (dev "no CSS asset" warning expected)
  • useCSSLayers: true (matches published build) → atoms carry StyleX @layer priorityN precedence; consumers pick the outer layer at import: @import '@clerk/ui/styles.css' layer(components)
  • lightningcss targets pinned to browsers with native light-dark()/oklch() (no down-level to invalid polyfill)

Notes

  • Mosaic internal/unreleased → empty changeset, no back-compat constraint
  • org views: sxstyle on new Button

@changeset-bot

changeset-botBot commented Jul 21, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 09be4be

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 0 packages

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel

vercelBot commented Jul 21, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxReadyReadyPreview, CommentJul 22, 2026 7:24pm
swingsetReadyReadyPreview, CommentJul 22, 2026 7:24pm

Request Review

@pkg-pr-new

pkg-pr-newBot commented Jul 21, 2026

Copy link
Copy Markdown

Open in StackBlitz

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@9208

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@9208

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@9208

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@9208

@clerk/electron

npm i https://pkg.pr.new/@clerk/electron@9208

@clerk/electron-passkeys

npm i https://pkg.pr.new/@clerk/electron-passkeys@9208

@clerk/eslint-plugin

npm i https://pkg.pr.new/@clerk/eslint-plugin@9208

@clerk/expo

npm i https://pkg.pr.new/@clerk/expo@9208

@clerk/expo-google-signin

npm i https://pkg.pr.new/@clerk/expo-google-signin@9208

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@9208

@clerk/express

npm i https://pkg.pr.new/@clerk/express@9208

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@9208

@clerk/hono

npm i https://pkg.pr.new/@clerk/hono@9208

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@9208

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@9208

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@9208

@clerk/react

npm i https://pkg.pr.new/@clerk/react@9208

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@9208

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@9208

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@9208

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@9208

@clerk/ui

npm i https://pkg.pr.new/@clerk/ui@9208

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@9208

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@9208

commit: 09be4be

@coderabbitai

coderabbitaiBot commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

  • @coderabbitai resume to resume automatic reviews.
  • @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

  • ▶️ Resume reviews
  • 🔍 Trigger review
📝 Walkthrough

Walkthrough

The PR migrates Mosaic button styling to StyleX by adding tokens, prop helpers, button styles, component exports, tests, isolated CSS extraction, package exports, lint and test integration, and Swingset webpack/PostCSS configuration. Organization views replace sx styling with inline styles, and the Button story defines variant metadata inline.

Estimated code review effort: 4 (Complex) | ~60 minutes

Suggested reviewers:kylemac

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check nameStatusExplanationResolution
Docstring Coverage⚠️ WarningDocstring coverage is 44.44% which is insufficient. The required threshold is 80.00%.Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check nameStatusExplanation
Title check✅ PassedThe title accurately summarizes the main change: migrating the Mosaic Button to StyleX.
Description check✅ PassedThe description is detailed and directly matches the StyleX migration and related build/config changes.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.

Comment @coderabbitai help to get the list of available commands.

@coderabbitaicoderabbitaiBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 4

🧹 Nitpick comments (1)
packages/ui/src/mosaic/styles/index.ts (1)

7-22: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick win

Avoid growing this index.ts re-export barrel.

Move this curated build entry to a named module (for example, mosaic-stylex.ts) and point tsdown.mosaic.config.mts to it. This avoids a circular-dependency hotspot as migrated components accumulate.

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@packages/ui/src/mosaic/styles/index.ts` around lines 7 - 22, Move the curated
exports and token type aliases from the styles index module into a dedicated
named entry module such as mosaic-stylex.ts, then update
tsdown.mosaic.config.mts to use that entry. Keep the existing exports and type
unions unchanged, and leave the index module free from further build-entry
growth.

Source: Coding guidelines

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@packages/swingset/next.config.mjs`:
- Around line 74-93: Use a single StyleX CSS extraction owner for Mosaic across
packages/swingset/next.config.mjs:74-93 and
packages/swingset/postcss.config.mjs:15-38. Update the stylexPlugin
configuration in next.config.mjs and the corresponding PostCSS configuration so
only one path emits CSS, while the other performs JS transforms only; preserve
matching StyleX options and avoid duplicate atom output.
In `@packages/swingset/src/stories/button.stories.tsx`:
- Line 16: Update the Button story’s source path to reference the migrated
exporter at the nested button/button.tsx location, ensuring the Story “View
source” link resolves correctly.
In `@packages/ui/package.json`:
- Around line 75-83: Update the package.json build script to invoke the existing
build:mosaic script as part of the normal build sequence, ensuring
dist-mosaic/styles.css is generated before the package is published.
In `@packages/ui/src/mosaic/components/button/button.test.tsx`:
- Around line 13-21: Extend the “applies default variants when none are passed”
test for the Button component to assert that the rendered button has
type="button". Keep the existing default variant assertions unchanged.
---
Nitpick comments:
In `@packages/ui/src/mosaic/styles/index.ts`:
- Around line 7-22: Move the curated exports and token type aliases from the
styles index module into a dedicated named entry module such as
mosaic-stylex.ts, then update tsdown.mosaic.config.mts to use that entry. Keep
the existing exports and type unions unchanged, and leave the index module free
from further build-entry growth.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: 8e28f65c-c34e-42fa-8812-9d706f10ac7e

📥 Commits

Reviewing files that changed from the base of the PR and between 5070797 and d70595f.

⛔ Files ignored due to path filters (1)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (29)
  • .changeset/mosaic-stylex-migration.md
  • .gitignore
  • eslint.config.mjs
  • package.json
  • packages/swingset/next.config.mjs
  • packages/swingset/package.json
  • packages/swingset/postcss.config.mjs
  • packages/swingset/src/app/globals.css
  • packages/swingset/src/stories/button.stories.tsx
  • packages/ui/package.json
  • packages/ui/src/mosaic/__tests__/props.test.ts
  • packages/ui/src/mosaic/components/__tests__/button.test.tsx
  • packages/ui/src/mosaic/components/button.tsx
  • packages/ui/src/mosaic/components/button/button.styles.ts
  • packages/ui/src/mosaic/components/button/button.test.tsx
  • packages/ui/src/mosaic/components/button/button.tsx
  • packages/ui/src/mosaic/components/button/index.ts
  • packages/ui/src/mosaic/organization/organization-profile-delete-section.view.tsx
  • packages/ui/src/mosaic/organization/organization-profile-domains-section.view.tsx
  • packages/ui/src/mosaic/organization/organization-profile-leave-section.view.tsx
  • packages/ui/src/mosaic/organization/organization-profile-members-panel.view.tsx
  • packages/ui/src/mosaic/organization/organization-profile-profile-section.view.tsx
  • packages/ui/src/mosaic/props.ts
  • packages/ui/src/mosaic/styles/index.ts
  • packages/ui/src/mosaic/tokens.stylex.ts
  • packages/ui/styles.css.d.ts
  • packages/ui/tsconfig.mosaic.json
  • packages/ui/tsdown.mosaic.config.mts
  • packages/ui/vitest.config.mts
🔗 Linked repositories identified

CodeRabbit considers these linked repositories for cross-repo context during reviews:

  • clerk/clerk_go(manual)
  • clerk/dashboard(manual)
  • clerk/accounts(manual)
  • clerk/backoffice(manual)
  • clerk/clerk(manual)
  • clerk/clerk-docs(manual)
  • clerk/cloudflare-workers(manual)
💤 Files with no reviewable changes (2)
  • packages/ui/src/mosaic/components/tests/button.test.tsx
  • packages/ui/src/mosaic/components/button.tsx

Comment threadpackages/swingset/next.config.mjs
Comment threadpackages/swingset/src/stories/button.stories.tsx Outdated
Comment threadpackages/ui/package.json
Comment threadpackages/ui/src/mosaic/components/button/button.test.tsx
@github-actions

github-actionsBot commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

API Changes Report

Generated by Break Check on 2026-07-22T19:25:18.932Z

Summary

MetricCount
Packages analyzed19
Packages with changes1
🔴 Breaking changes0
🟡 Non-breaking changes0
🟢 Additions1

@clerk/ui

Current version: 1.25.7
Recommended bump: MINOR → 1.26.0

Subpath ./styles.css

🟢 Additions (1)

Added: ./styles.css

New subpath export ./styles.css


Report generated by Break Check

Last ran on 09be4be.

@alexcarpenter

Copy link
Copy Markdown
MemberAuthor

Nitpick — styles/index.ts barrel → named module: leaving as-is. It's the isolated build entry (tsdown.mosaic.config.mts), imported by nothing else; depends on components/tokens/props one-directionally, so no circular-dep risk.

@wobsorianowobsoriano left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very exciting

Comment threadpackages/ui/package.json Outdated
Swingset extracts Mosaic CSS via the postcss-plugin glob scanner, not the
webpack module graph, so the entry never guarded anything; verified swingset's
emitted CSS is byte-identical without it. src is unpublished, so it was inert
for consumers too. dist-mosaic/styles.css remains the tracked CSS side effect.
…ostcss include)
The unplugin transforms JS only and emits no CSS, so its lightningcssOptions
never processed a sheet; and the postcss include glob was redundant — production
CSS is byte-identical without both. Verified against a positive control.
lightningcss down-leveling is only a concern in the published rollup build
(tsdown.mosaic.config.mts), which keeps its targets.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@alexcarpenter@dstaley@wobsoriano
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default"); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

feat(ui): migrate Mosaic Button to StyleX - #9208

Merged
alexcarpenter merged 12 commits into
mainfrom
migrate-mosaic-to-stylex
Jul 22, 2026
Merged

feat(ui): migrate Mosaic Button to StyleX#9208
alexcarpenter merged 12 commits into
mainfrom
migrate-mosaic-to-stylex

Conversation

@alexcarpenter

@alexcarpenteralexcarpenter commented Jul 21, 2026

Copy link
Copy Markdown
Member

Mosaic Button: Emotion → StyleX. Compile-time atomic CSS, static sheet, zero runtime.

What

  • tokens.stylex.ts: --cl-* vars (oklch + light-dark())
  • props.ts: public contract — .cl-<slot> class + data-<axis> attrs + class/style merge
  • Button → plain StyleX, foldered: components/button/{button,button.styles,index,button.test}
  • isolated build:mosaic (tsdown + rollup-plugin) → dist-mosaic/styles.css, export @clerk/ui/styles.css
  • all 9 @stylexjs eslint rules on src/mosaic/**

Swingset

  • consumes Mosaic from source (@clerk/ui/mosaic aliased to ../ui/src/mosaic)
  • StyleX split two ways, same babel version/opts so atom hashes match:
    • next.config unplugin → compiles StyleX JS only (calls become static atoms, nothing hits runtime; SWC/Emotion/next/font untouched)
    • postcss plugin → owns CSS, replaces @stylex; in globals.css (dev "no CSS asset" warning expected)
  • useCSSLayers: true (matches published build) → atoms carry StyleX @layer priorityN precedence; consumers pick the outer layer at import: @import '@clerk/ui/styles.css' layer(components)
  • lightningcss targets pinned to browsers with native light-dark()/oklch() (no down-level to invalid polyfill)

Notes

  • Mosaic internal/unreleased → empty changeset, no back-compat constraint
  • org views: sxstyle on new Button

@changeset-bot

changeset-botBot commented Jul 21, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 09be4be

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 0 packages

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel

vercelBot commented Jul 21, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxReadyReadyPreview, CommentJul 22, 2026 7:24pm
swingsetReadyReadyPreview, CommentJul 22, 2026 7:24pm

Request Review

@pkg-pr-new

pkg-pr-newBot commented Jul 21, 2026

Copy link
Copy Markdown

Open in StackBlitz

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@9208

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@9208

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@9208

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@9208

@clerk/electron

npm i https://pkg.pr.new/@clerk/electron@9208

@clerk/electron-passkeys

npm i https://pkg.pr.new/@clerk/electron-passkeys@9208

@clerk/eslint-plugin

npm i https://pkg.pr.new/@clerk/eslint-plugin@9208

@clerk/expo

npm i https://pkg.pr.new/@clerk/expo@9208

@clerk/expo-google-signin

npm i https://pkg.pr.new/@clerk/expo-google-signin@9208

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@9208

@clerk/express

npm i https://pkg.pr.new/@clerk/express@9208

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@9208

@clerk/hono

npm i https://pkg.pr.new/@clerk/hono@9208

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@9208

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@9208

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@9208

@clerk/react

npm i https://pkg.pr.new/@clerk/react@9208

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@9208

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@9208

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@9208

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@9208

@clerk/ui

npm i https://pkg.pr.new/@clerk/ui@9208

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@9208

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@9208

commit: 09be4be

@coderabbitai

coderabbitaiBot commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

  • @coderabbitai resume to resume automatic reviews.
  • @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

  • ▶️ Resume reviews
  • 🔍 Trigger review
📝 Walkthrough

Walkthrough

The PR migrates Mosaic button styling to StyleX by adding tokens, prop helpers, button styles, component exports, tests, isolated CSS extraction, package exports, lint and test integration, and Swingset webpack/PostCSS configuration. Organization views replace sx styling with inline styles, and the Button story defines variant metadata inline.

Estimated code review effort: 4 (Complex) | ~60 minutes

Suggested reviewers:kylemac

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check nameStatusExplanationResolution
Docstring Coverage⚠️ WarningDocstring coverage is 44.44% which is insufficient. The required threshold is 80.00%.Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check nameStatusExplanation
Title check✅ PassedThe title accurately summarizes the main change: migrating the Mosaic Button to StyleX.
Description check✅ PassedThe description is detailed and directly matches the StyleX migration and related build/config changes.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.

Comment @coderabbitai help to get the list of available commands.

@coderabbitaicoderabbitaiBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 4

🧹 Nitpick comments (1)
packages/ui/src/mosaic/styles/index.ts (1)

7-22: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick win

Avoid growing this index.ts re-export barrel.

Move this curated build entry to a named module (for example, mosaic-stylex.ts) and point tsdown.mosaic.config.mts to it. This avoids a circular-dependency hotspot as migrated components accumulate.

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@packages/ui/src/mosaic/styles/index.ts` around lines 7 - 22, Move the curated
exports and token type aliases from the styles index module into a dedicated
named entry module such as mosaic-stylex.ts, then update
tsdown.mosaic.config.mts to use that entry. Keep the existing exports and type
unions unchanged, and leave the index module free from further build-entry
growth.

Source: Coding guidelines

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@packages/swingset/next.config.mjs`:
- Around line 74-93: Use a single StyleX CSS extraction owner for Mosaic across
packages/swingset/next.config.mjs:74-93 and
packages/swingset/postcss.config.mjs:15-38. Update the stylexPlugin
configuration in next.config.mjs and the corresponding PostCSS configuration so
only one path emits CSS, while the other performs JS transforms only; preserve
matching StyleX options and avoid duplicate atom output.
In `@packages/swingset/src/stories/button.stories.tsx`:
- Line 16: Update the Button story’s source path to reference the migrated
exporter at the nested button/button.tsx location, ensuring the Story “View
source” link resolves correctly.
In `@packages/ui/package.json`:
- Around line 75-83: Update the package.json build script to invoke the existing
build:mosaic script as part of the normal build sequence, ensuring
dist-mosaic/styles.css is generated before the package is published.
In `@packages/ui/src/mosaic/components/button/button.test.tsx`:
- Around line 13-21: Extend the “applies default variants when none are passed”
test for the Button component to assert that the rendered button has
type="button". Keep the existing default variant assertions unchanged.
---
Nitpick comments:
In `@packages/ui/src/mosaic/styles/index.ts`:
- Around line 7-22: Move the curated exports and token type aliases from the
styles index module into a dedicated named entry module such as
mosaic-stylex.ts, then update tsdown.mosaic.config.mts to use that entry. Keep
the existing exports and type unions unchanged, and leave the index module free
from further build-entry growth.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: 8e28f65c-c34e-42fa-8812-9d706f10ac7e

📥 Commits

Reviewing files that changed from the base of the PR and between 5070797 and d70595f.

⛔ Files ignored due to path filters (1)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (29)
  • .changeset/mosaic-stylex-migration.md
  • .gitignore
  • eslint.config.mjs
  • package.json
  • packages/swingset/next.config.mjs
  • packages/swingset/package.json
  • packages/swingset/postcss.config.mjs
  • packages/swingset/src/app/globals.css
  • packages/swingset/src/stories/button.stories.tsx
  • packages/ui/package.json
  • packages/ui/src/mosaic/__tests__/props.test.ts
  • packages/ui/src/mosaic/components/__tests__/button.test.tsx
  • packages/ui/src/mosaic/components/button.tsx
  • packages/ui/src/mosaic/components/button/button.styles.ts
  • packages/ui/src/mosaic/components/button/button.test.tsx
  • packages/ui/src/mosaic/components/button/button.tsx
  • packages/ui/src/mosaic/components/button/index.ts
  • packages/ui/src/mosaic/organization/organization-profile-delete-section.view.tsx
  • packages/ui/src/mosaic/organization/organization-profile-domains-section.view.tsx
  • packages/ui/src/mosaic/organization/organization-profile-leave-section.view.tsx
  • packages/ui/src/mosaic/organization/organization-profile-members-panel.view.tsx
  • packages/ui/src/mosaic/organization/organization-profile-profile-section.view.tsx
  • packages/ui/src/mosaic/props.ts
  • packages/ui/src/mosaic/styles/index.ts
  • packages/ui/src/mosaic/tokens.stylex.ts
  • packages/ui/styles.css.d.ts
  • packages/ui/tsconfig.mosaic.json
  • packages/ui/tsdown.mosaic.config.mts
  • packages/ui/vitest.config.mts
🔗 Linked repositories identified

CodeRabbit considers these linked repositories for cross-repo context during reviews:

  • clerk/clerk_go(manual)
  • clerk/dashboard(manual)
  • clerk/accounts(manual)
  • clerk/backoffice(manual)
  • clerk/clerk(manual)
  • clerk/clerk-docs(manual)
  • clerk/cloudflare-workers(manual)
💤 Files with no reviewable changes (2)
  • packages/ui/src/mosaic/components/tests/button.test.tsx
  • packages/ui/src/mosaic/components/button.tsx

Comment threadpackages/swingset/next.config.mjs
Comment threadpackages/swingset/src/stories/button.stories.tsx Outdated
Comment threadpackages/ui/package.json
Comment threadpackages/ui/src/mosaic/components/button/button.test.tsx
@github-actions

github-actionsBot commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

API Changes Report

Generated by Break Check on 2026-07-22T19:25:18.932Z

Summary

MetricCount
Packages analyzed19
Packages with changes1
🔴 Breaking changes0
🟡 Non-breaking changes0
🟢 Additions1

@clerk/ui

Current version: 1.25.7
Recommended bump: MINOR → 1.26.0

Subpath ./styles.css

🟢 Additions (1)

Added: ./styles.css

New subpath export ./styles.css


Report generated by Break Check

Last ran on 09be4be.

@alexcarpenter

Copy link
Copy Markdown
MemberAuthor

Nitpick — styles/index.ts barrel → named module: leaving as-is. It's the isolated build entry (tsdown.mosaic.config.mts), imported by nothing else; depends on components/tokens/props one-directionally, so no circular-dep risk.

@wobsorianowobsoriano left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very exciting

Comment threadpackages/ui/package.json Outdated
Swingset extracts Mosaic CSS via the postcss-plugin glob scanner, not the
webpack module graph, so the entry never guarded anything; verified swingset's
emitted CSS is byte-identical without it. src is unpublished, so it was inert
for consumers too. dist-mosaic/styles.css remains the tracked CSS side effect.
…ostcss include)
The unplugin transforms JS only and emits no CSS, so its lightningcssOptions
never processed a sheet; and the postcss include glob was redundant — production
CSS is byte-identical without both. Verified against a positive control.
lightningcss down-leveling is only a concern in the published rollup build
(tsdown.mosaic.config.mts), which keeps its targets.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@alexcarpenter@dstaley@wobsoriano
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers"); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

feat(ui): migrate Mosaic Button to StyleX - #9208

Merged
alexcarpenter merged 12 commits into
mainfrom
migrate-mosaic-to-stylex
Jul 22, 2026
Merged

feat(ui): migrate Mosaic Button to StyleX#9208
alexcarpenter merged 12 commits into
mainfrom
migrate-mosaic-to-stylex

Conversation

@alexcarpenter

@alexcarpenteralexcarpenter commented Jul 21, 2026

Copy link
Copy Markdown
Member

Mosaic Button: Emotion → StyleX. Compile-time atomic CSS, static sheet, zero runtime.

What

  • tokens.stylex.ts: --cl-* vars (oklch + light-dark())
  • props.ts: public contract — .cl-<slot> class + data-<axis> attrs + class/style merge
  • Button → plain StyleX, foldered: components/button/{button,button.styles,index,button.test}
  • isolated build:mosaic (tsdown + rollup-plugin) → dist-mosaic/styles.css, export @clerk/ui/styles.css
  • all 9 @stylexjs eslint rules on src/mosaic/**

Swingset

  • consumes Mosaic from source (@clerk/ui/mosaic aliased to ../ui/src/mosaic)
  • StyleX split two ways, same babel version/opts so atom hashes match:
    • next.config unplugin → compiles StyleX JS only (calls become static atoms, nothing hits runtime; SWC/Emotion/next/font untouched)
    • postcss plugin → owns CSS, replaces @stylex; in globals.css (dev "no CSS asset" warning expected)
  • useCSSLayers: true (matches published build) → atoms carry StyleX @layer priorityN precedence; consumers pick the outer layer at import: @import '@clerk/ui/styles.css' layer(components)
  • lightningcss targets pinned to browsers with native light-dark()/oklch() (no down-level to invalid polyfill)

Notes

  • Mosaic internal/unreleased → empty changeset, no back-compat constraint
  • org views: sxstyle on new Button

@changeset-bot

changeset-botBot commented Jul 21, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 09be4be

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 0 packages

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel

vercelBot commented Jul 21, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxReadyReadyPreview, CommentJul 22, 2026 7:24pm
swingsetReadyReadyPreview, CommentJul 22, 2026 7:24pm

Request Review

@pkg-pr-new

pkg-pr-newBot commented Jul 21, 2026

Copy link
Copy Markdown

Open in StackBlitz

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@9208

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@9208

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@9208

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@9208

@clerk/electron

npm i https://pkg.pr.new/@clerk/electron@9208

@clerk/electron-passkeys

npm i https://pkg.pr.new/@clerk/electron-passkeys@9208

@clerk/eslint-plugin

npm i https://pkg.pr.new/@clerk/eslint-plugin@9208

@clerk/expo

npm i https://pkg.pr.new/@clerk/expo@9208

@clerk/expo-google-signin

npm i https://pkg.pr.new/@clerk/expo-google-signin@9208

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@9208

@clerk/express

npm i https://pkg.pr.new/@clerk/express@9208

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@9208

@clerk/hono

npm i https://pkg.pr.new/@clerk/hono@9208

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@9208

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@9208

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@9208

@clerk/react

npm i https://pkg.pr.new/@clerk/react@9208

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@9208

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@9208

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@9208

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@9208

@clerk/ui

npm i https://pkg.pr.new/@clerk/ui@9208

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@9208

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@9208

commit: 09be4be

@coderabbitai

coderabbitaiBot commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

  • @coderabbitai resume to resume automatic reviews.
  • @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

  • ▶️ Resume reviews
  • 🔍 Trigger review
📝 Walkthrough

Walkthrough

The PR migrates Mosaic button styling to StyleX by adding tokens, prop helpers, button styles, component exports, tests, isolated CSS extraction, package exports, lint and test integration, and Swingset webpack/PostCSS configuration. Organization views replace sx styling with inline styles, and the Button story defines variant metadata inline.

Estimated code review effort: 4 (Complex) | ~60 minutes

Suggested reviewers:kylemac

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check nameStatusExplanationResolution
Docstring Coverage⚠️ WarningDocstring coverage is 44.44% which is insufficient. The required threshold is 80.00%.Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check nameStatusExplanation
Title check✅ PassedThe title accurately summarizes the main change: migrating the Mosaic Button to StyleX.
Description check✅ PassedThe description is detailed and directly matches the StyleX migration and related build/config changes.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.

Comment @coderabbitai help to get the list of available commands.

@coderabbitaicoderabbitaiBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 4

🧹 Nitpick comments (1)
packages/ui/src/mosaic/styles/index.ts (1)

7-22: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick win

Avoid growing this index.ts re-export barrel.

Move this curated build entry to a named module (for example, mosaic-stylex.ts) and point tsdown.mosaic.config.mts to it. This avoids a circular-dependency hotspot as migrated components accumulate.

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@packages/ui/src/mosaic/styles/index.ts` around lines 7 - 22, Move the curated
exports and token type aliases from the styles index module into a dedicated
named entry module such as mosaic-stylex.ts, then update
tsdown.mosaic.config.mts to use that entry. Keep the existing exports and type
unions unchanged, and leave the index module free from further build-entry
growth.

Source: Coding guidelines

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@packages/swingset/next.config.mjs`:
- Around line 74-93: Use a single StyleX CSS extraction owner for Mosaic across
packages/swingset/next.config.mjs:74-93 and
packages/swingset/postcss.config.mjs:15-38. Update the stylexPlugin
configuration in next.config.mjs and the corresponding PostCSS configuration so
only one path emits CSS, while the other performs JS transforms only; preserve
matching StyleX options and avoid duplicate atom output.
In `@packages/swingset/src/stories/button.stories.tsx`:
- Line 16: Update the Button story’s source path to reference the migrated
exporter at the nested button/button.tsx location, ensuring the Story “View
source” link resolves correctly.
In `@packages/ui/package.json`:
- Around line 75-83: Update the package.json build script to invoke the existing
build:mosaic script as part of the normal build sequence, ensuring
dist-mosaic/styles.css is generated before the package is published.
In `@packages/ui/src/mosaic/components/button/button.test.tsx`:
- Around line 13-21: Extend the “applies default variants when none are passed”
test for the Button component to assert that the rendered button has
type="button". Keep the existing default variant assertions unchanged.
---
Nitpick comments:
In `@packages/ui/src/mosaic/styles/index.ts`:
- Around line 7-22: Move the curated exports and token type aliases from the
styles index module into a dedicated named entry module such as
mosaic-stylex.ts, then update tsdown.mosaic.config.mts to use that entry. Keep
the existing exports and type unions unchanged, and leave the index module free
from further build-entry growth.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: 8e28f65c-c34e-42fa-8812-9d706f10ac7e

📥 Commits

Reviewing files that changed from the base of the PR and between 5070797 and d70595f.

⛔ Files ignored due to path filters (1)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (29)
  • .changeset/mosaic-stylex-migration.md
  • .gitignore
  • eslint.config.mjs
  • package.json
  • packages/swingset/next.config.mjs
  • packages/swingset/package.json
  • packages/swingset/postcss.config.mjs
  • packages/swingset/src/app/globals.css
  • packages/swingset/src/stories/button.stories.tsx
  • packages/ui/package.json
  • packages/ui/src/mosaic/__tests__/props.test.ts
  • packages/ui/src/mosaic/components/__tests__/button.test.tsx
  • packages/ui/src/mosaic/components/button.tsx
  • packages/ui/src/mosaic/components/button/button.styles.ts
  • packages/ui/src/mosaic/components/button/button.test.tsx
  • packages/ui/src/mosaic/components/button/button.tsx
  • packages/ui/src/mosaic/components/button/index.ts
  • packages/ui/src/mosaic/organization/organization-profile-delete-section.view.tsx
  • packages/ui/src/mosaic/organization/organization-profile-domains-section.view.tsx
  • packages/ui/src/mosaic/organization/organization-profile-leave-section.view.tsx
  • packages/ui/src/mosaic/organization/organization-profile-members-panel.view.tsx
  • packages/ui/src/mosaic/organization/organization-profile-profile-section.view.tsx
  • packages/ui/src/mosaic/props.ts
  • packages/ui/src/mosaic/styles/index.ts
  • packages/ui/src/mosaic/tokens.stylex.ts
  • packages/ui/styles.css.d.ts
  • packages/ui/tsconfig.mosaic.json
  • packages/ui/tsdown.mosaic.config.mts
  • packages/ui/vitest.config.mts
🔗 Linked repositories identified

CodeRabbit considers these linked repositories for cross-repo context during reviews:

  • clerk/clerk_go(manual)
  • clerk/dashboard(manual)
  • clerk/accounts(manual)
  • clerk/backoffice(manual)
  • clerk/clerk(manual)
  • clerk/clerk-docs(manual)
  • clerk/cloudflare-workers(manual)
💤 Files with no reviewable changes (2)
  • packages/ui/src/mosaic/components/tests/button.test.tsx
  • packages/ui/src/mosaic/components/button.tsx

Comment threadpackages/swingset/next.config.mjs
Comment threadpackages/swingset/src/stories/button.stories.tsx Outdated
Comment threadpackages/ui/package.json
Comment threadpackages/ui/src/mosaic/components/button/button.test.tsx
@github-actions

github-actionsBot commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

API Changes Report

Generated by Break Check on 2026-07-22T19:25:18.932Z

Summary

MetricCount
Packages analyzed19
Packages with changes1
🔴 Breaking changes0
🟡 Non-breaking changes0
🟢 Additions1

@clerk/ui

Current version: 1.25.7
Recommended bump: MINOR → 1.26.0

Subpath ./styles.css

🟢 Additions (1)

Added: ./styles.css

New subpath export ./styles.css


Report generated by Break Check

Last ran on 09be4be.

@alexcarpenter

Copy link
Copy Markdown
MemberAuthor

Nitpick — styles/index.ts barrel → named module: leaving as-is. It's the isolated build entry (tsdown.mosaic.config.mts), imported by nothing else; depends on components/tokens/props one-directionally, so no circular-dep risk.

@wobsorianowobsoriano left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very exciting

Comment threadpackages/ui/package.json Outdated
Swingset extracts Mosaic CSS via the postcss-plugin glob scanner, not the
webpack module graph, so the entry never guarded anything; verified swingset's
emitted CSS is byte-identical without it. src is unpublished, so it was inert
for consumers too. dist-mosaic/styles.css remains the tracked CSS side effect.
…ostcss include)
The unplugin transforms JS only and emits no CSS, so its lightningcssOptions
never processed a sheet; and the postcss include glob was redundant — production
CSS is byte-identical without both. Verified against a positive control.
lightningcss down-leveling is only a concern in the published rollup build
(tsdown.mosaic.config.mts), which keeps its targets.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@alexcarpenter@dstaley@wobsoriano
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode"); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })();
Skip to content

feat(ui): migrate Mosaic Button to StyleX - #9208

Merged
alexcarpenter merged 12 commits into
mainfrom
migrate-mosaic-to-stylex
Jul 22, 2026
Merged

feat(ui): migrate Mosaic Button to StyleX#9208
alexcarpenter merged 12 commits into
mainfrom
migrate-mosaic-to-stylex

Conversation

@alexcarpenter

@alexcarpenteralexcarpenter commented Jul 21, 2026

Copy link
Copy Markdown
Member

Mosaic Button: Emotion → StyleX. Compile-time atomic CSS, static sheet, zero runtime.

What

  • tokens.stylex.ts: --cl-* vars (oklch + light-dark())
  • props.ts: public contract — .cl-<slot> class + data-<axis> attrs + class/style merge
  • Button → plain StyleX, foldered: components/button/{button,button.styles,index,button.test}
  • isolated build:mosaic (tsdown + rollup-plugin) → dist-mosaic/styles.css, export @clerk/ui/styles.css
  • all 9 @stylexjs eslint rules on src/mosaic/**

Swingset

  • consumes Mosaic from source (@clerk/ui/mosaic aliased to ../ui/src/mosaic)
  • StyleX split two ways, same babel version/opts so atom hashes match:
    • next.config unplugin → compiles StyleX JS only (calls become static atoms, nothing hits runtime; SWC/Emotion/next/font untouched)
    • postcss plugin → owns CSS, replaces @stylex; in globals.css (dev "no CSS asset" warning expected)
  • useCSSLayers: true (matches published build) → atoms carry StyleX @layer priorityN precedence; consumers pick the outer layer at import: @import '@clerk/ui/styles.css' layer(components)
  • lightningcss targets pinned to browsers with native light-dark()/oklch() (no down-level to invalid polyfill)

Notes

  • Mosaic internal/unreleased → empty changeset, no back-compat constraint
  • org views: sxstyle on new Button

@changeset-bot

changeset-botBot commented Jul 21, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 09be4be

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 0 packages

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel

vercelBot commented Jul 21, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxReadyReadyPreview, CommentJul 22, 2026 7:24pm
swingsetReadyReadyPreview, CommentJul 22, 2026 7:24pm

Request Review

@pkg-pr-new

pkg-pr-newBot commented Jul 21, 2026

Copy link
Copy Markdown

Open in StackBlitz

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@9208

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@9208

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@9208

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@9208

@clerk/electron

npm i https://pkg.pr.new/@clerk/electron@9208

@clerk/electron-passkeys

npm i https://pkg.pr.new/@clerk/electron-passkeys@9208

@clerk/eslint-plugin

npm i https://pkg.pr.new/@clerk/eslint-plugin@9208

@clerk/expo

npm i https://pkg.pr.new/@clerk/expo@9208

@clerk/expo-google-signin

npm i https://pkg.pr.new/@clerk/expo-google-signin@9208

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@9208

@clerk/express

npm i https://pkg.pr.new/@clerk/express@9208

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@9208

@clerk/hono

npm i https://pkg.pr.new/@clerk/hono@9208

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@9208

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@9208

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@9208

@clerk/react

npm i https://pkg.pr.new/@clerk/react@9208

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@9208

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@9208

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@9208

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@9208

@clerk/ui

npm i https://pkg.pr.new/@clerk/ui@9208

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@9208

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@9208

commit: 09be4be

@coderabbitai

coderabbitaiBot commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

  • @coderabbitai resume to resume automatic reviews.
  • @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

  • ▶️ Resume reviews
  • 🔍 Trigger review
📝 Walkthrough

Walkthrough

The PR migrates Mosaic button styling to StyleX by adding tokens, prop helpers, button styles, component exports, tests, isolated CSS extraction, package exports, lint and test integration, and Swingset webpack/PostCSS configuration. Organization views replace sx styling with inline styles, and the Button story defines variant metadata inline.

Estimated code review effort: 4 (Complex) | ~60 minutes

Suggested reviewers:kylemac

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check nameStatusExplanationResolution
Docstring Coverage⚠️ WarningDocstring coverage is 44.44% which is insufficient. The required threshold is 80.00%.Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check nameStatusExplanation
Title check✅ PassedThe title accurately summarizes the main change: migrating the Mosaic Button to StyleX.
Description check✅ PassedThe description is detailed and directly matches the StyleX migration and related build/config changes.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.

Comment @coderabbitai help to get the list of available commands.

@coderabbitaicoderabbitaiBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 4

🧹 Nitpick comments (1)
packages/ui/src/mosaic/styles/index.ts (1)

7-22: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick win

Avoid growing this index.ts re-export barrel.

Move this curated build entry to a named module (for example, mosaic-stylex.ts) and point tsdown.mosaic.config.mts to it. This avoids a circular-dependency hotspot as migrated components accumulate.

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@packages/ui/src/mosaic/styles/index.ts` around lines 7 - 22, Move the curated
exports and token type aliases from the styles index module into a dedicated
named entry module such as mosaic-stylex.ts, then update
tsdown.mosaic.config.mts to use that entry. Keep the existing exports and type
unions unchanged, and leave the index module free from further build-entry
growth.

Source: Coding guidelines

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@packages/swingset/next.config.mjs`:
- Around line 74-93: Use a single StyleX CSS extraction owner for Mosaic across
packages/swingset/next.config.mjs:74-93 and
packages/swingset/postcss.config.mjs:15-38. Update the stylexPlugin
configuration in next.config.mjs and the corresponding PostCSS configuration so
only one path emits CSS, while the other performs JS transforms only; preserve
matching StyleX options and avoid duplicate atom output.
In `@packages/swingset/src/stories/button.stories.tsx`:
- Line 16: Update the Button story’s source path to reference the migrated
exporter at the nested button/button.tsx location, ensuring the Story “View
source” link resolves correctly.
In `@packages/ui/package.json`:
- Around line 75-83: Update the package.json build script to invoke the existing
build:mosaic script as part of the normal build sequence, ensuring
dist-mosaic/styles.css is generated before the package is published.
In `@packages/ui/src/mosaic/components/button/button.test.tsx`:
- Around line 13-21: Extend the “applies default variants when none are passed”
test for the Button component to assert that the rendered button has
type="button". Keep the existing default variant assertions unchanged.
---
Nitpick comments:
In `@packages/ui/src/mosaic/styles/index.ts`:
- Around line 7-22: Move the curated exports and token type aliases from the
styles index module into a dedicated named entry module such as
mosaic-stylex.ts, then update tsdown.mosaic.config.mts to use that entry. Keep
the existing exports and type unions unchanged, and leave the index module free
from further build-entry growth.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: 8e28f65c-c34e-42fa-8812-9d706f10ac7e

📥 Commits

Reviewing files that changed from the base of the PR and between 5070797 and d70595f.

⛔ Files ignored due to path filters (1)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (29)
  • .changeset/mosaic-stylex-migration.md
  • .gitignore
  • eslint.config.mjs
  • package.json
  • packages/swingset/next.config.mjs
  • packages/swingset/package.json
  • packages/swingset/postcss.config.mjs
  • packages/swingset/src/app/globals.css
  • packages/swingset/src/stories/button.stories.tsx
  • packages/ui/package.json
  • packages/ui/src/mosaic/__tests__/props.test.ts
  • packages/ui/src/mosaic/components/__tests__/button.test.tsx
  • packages/ui/src/mosaic/components/button.tsx
  • packages/ui/src/mosaic/components/button/button.styles.ts
  • packages/ui/src/mosaic/components/button/button.test.tsx
  • packages/ui/src/mosaic/components/button/button.tsx
  • packages/ui/src/mosaic/components/button/index.ts
  • packages/ui/src/mosaic/organization/organization-profile-delete-section.view.tsx
  • packages/ui/src/mosaic/organization/organization-profile-domains-section.view.tsx
  • packages/ui/src/mosaic/organization/organization-profile-leave-section.view.tsx
  • packages/ui/src/mosaic/organization/organization-profile-members-panel.view.tsx
  • packages/ui/src/mosaic/organization/organization-profile-profile-section.view.tsx
  • packages/ui/src/mosaic/props.ts
  • packages/ui/src/mosaic/styles/index.ts
  • packages/ui/src/mosaic/tokens.stylex.ts
  • packages/ui/styles.css.d.ts
  • packages/ui/tsconfig.mosaic.json
  • packages/ui/tsdown.mosaic.config.mts
  • packages/ui/vitest.config.mts
🔗 Linked repositories identified

CodeRabbit considers these linked repositories for cross-repo context during reviews:

  • clerk/clerk_go(manual)
  • clerk/dashboard(manual)
  • clerk/accounts(manual)
  • clerk/backoffice(manual)
  • clerk/clerk(manual)
  • clerk/clerk-docs(manual)
  • clerk/cloudflare-workers(manual)
💤 Files with no reviewable changes (2)
  • packages/ui/src/mosaic/components/tests/button.test.tsx
  • packages/ui/src/mosaic/components/button.tsx

Comment threadpackages/swingset/next.config.mjs
Comment threadpackages/swingset/src/stories/button.stories.tsx Outdated
Comment threadpackages/ui/package.json
Comment threadpackages/ui/src/mosaic/components/button/button.test.tsx
@github-actions

github-actionsBot commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

API Changes Report

Generated by Break Check on 2026-07-22T19:25:18.932Z

Summary

MetricCount
Packages analyzed19
Packages with changes1
🔴 Breaking changes0
🟡 Non-breaking changes0
🟢 Additions1

@clerk/ui

Current version: 1.25.7
Recommended bump: MINOR → 1.26.0

Subpath ./styles.css

🟢 Additions (1)

Added: ./styles.css

New subpath export ./styles.css


Report generated by Break Check

Last ran on 09be4be.

@alexcarpenter

Copy link
Copy Markdown
MemberAuthor

Nitpick — styles/index.ts barrel → named module: leaving as-is. It's the isolated build entry (tsdown.mosaic.config.mts), imported by nothing else; depends on components/tokens/props one-directionally, so no circular-dep risk.

@wobsorianowobsoriano left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very exciting

Comment threadpackages/ui/package.json Outdated
Swingset extracts Mosaic CSS via the postcss-plugin glob scanner, not the
webpack module graph, so the entry never guarded anything; verified swingset's
emitted CSS is byte-identical without it. src is unpublished, so it was inert
for consumers too. dist-mosaic/styles.css remains the tracked CSS side effect.
…ostcss include)
The unplugin transforms JS only and emits no CSS, so its lightningcssOptions
never processed a sheet; and the postcss include glob was redundant — production
CSS is byte-identical without both. Verified against a positive control.
lightningcss down-leveling is only a concern in the published rollup build
(tsdown.mosaic.config.mts), which keeps its targets.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@alexcarpenter@dstaley@wobsoriano