Uh oh!
There was an error while loading. Please reload this page.
chore(repo): re-enable eslint for @clerk/ui - #9218
Merged
Merged
Conversation
The lint script was renamed to `lint:disabled` in 4da7668 so turbo's `lint` task would stop matching it. Rename it back and clear the 117 errors that had accumulated. Notable: - Physical `left`/`right`/`paddingLeft` replaced with logical properties in OrganizationMembers and SetupMfaStartScreen (broken in RTL). - Non-null assertions removed from slot-recipe and BaseRouter. - `no-navigate-useClerk` and `no-unstable-methods` now registered for packages/ui, where the migrated components live. No new violations. - a11y heading/label rules off for mosaic: its `render` prop indirection makes both rules report on every usage.
🦋 Changeset detectedLatest commit: 59c4ef2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
API Changes Report
Summary
No API Changes DetectedAll packages have stable APIs with no detected changes. Report generated by Break Check Last ran on |
@clerk/astro@clerk/backend@clerk/chrome-extension@clerk/clerk-js@clerk/electron@clerk/electron-passkeys@clerk/eslint-plugin@clerk/expo@clerk/expo-google-signin@clerk/expo-passkeys@clerk/express@clerk/fastify@clerk/hono@clerk/localizations@clerk/nextjs@clerk/nuxt@clerk/react@clerk/react-router@clerk/shared@clerk/tanstack-react-start@clerk/testing@clerk/ui@clerk/upgrade@clerk/vuecommit: |
Contributor
📝 WalkthroughWalkthroughThe PR enables additional UI ESLint rules and updates related package configuration. It replaces physical horizontal CSS properties with logical properties in organization and MFA components, adds targeted suppressions for intentional physical positioning, and refactors several parsing, routing, machine, and caching implementations without changing their stated behavior. Numerous source and test files also receive import ordering, formatting, unused-import, JSX shorthand, and type-test updates. A UI TypeScript path alias and patch changeset are added. Estimated code review effort: 3 (Moderate) | ~25 minutes 🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (3 passed)
Comment |
wobsoriano
approved these changes
Jul 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.