feat(headless): migrate remaining primitives to useRender - #9232

Merged
alexcarpenter merged 3 commits into
mainfrom
carp/mosaic-use-render-pr2
Jul 23, 2026
Merged

feat(headless): migrate remaining primitives to useRender#9232
alexcarpenter merged 3 commits into
mainfrom
carp/mosaic-use-render-pr2

Conversation

@alexcarpenter

@alexcarpenteralexcarpenter commented Jul 23, 2026

Copy link
Copy Markdown
Member

Stacked on #9231. Merge that first.

PR2 of the renderElement → useRender migration. #9231 added the useRender hook and converted Mosaic + a couple representative primitives. This converts every remaining primitive family so renderElement has no callers left (final PR deletes it).

What changed

58 primitives across accordion, autocomplete, collapsible, dialog, drawer, file-upload, menu, otp, popover, select, tabs, tooltip. Mechanical swap, three transforms:

Refs merge inside the hook. Per-site useMergeRefs disappears.

// beforeconstcombinedRef=useMergeRefs([popupRef,refs.setFloating,ref]);constdefaultProps={ref: combinedRef, ...getFloatingProps()};returnrenderElement({defaultTagName: 'div', render,props: mergeProps(defaultProps,otherProps)});// afterreturnuseRender({defaultTagName: 'div', render,ref: [popupRef,refs.setFloating,ref],props: mergeProps(defaultProps,otherProps)});

mounted guard becomes enabled. Hook stays unconditional (returns null).

// beforeif(!mounted)returnnull;returnrenderElement({ ... });// after (wrapped-in-JSX case)constelement=useRender({ ...,enabled: mounted});if(!element)returnnull;return<FloatingFocusManager...>{element}</FloatingFocusManager>;

Composite/CompositeItem callbacks. floating-ui invokes the render callback synchronously during its own render (see renderJsx), so useRender there is runtime-safe but trips react-hooks/rules-of-hooks — carries a justified disable. The callback's injected roving-tabindex ref is extracted to the ref param (leaving it in props would let the hook's merged ref clobber it and break keyboard nav).

Ref safety

useRender overwrites any ref left in props with its own merged ref. So every ref was routed to the ref param, nothing left in props. Roving-focus/ref-forwarding tests cover the Composite cases.

Verified

  • @clerk/headless: 601 tests pass, typecheck clean, eslint clean (zero warnings)
  • no renderElement callers remain in src/primitives

Empty changeset: @clerk/headless is private.

@alexcarpenter
feat(headless): add useRender hook alongside renderElement
3445cc3
Introduces a base-ui-style useRender hook: a render prop that accepts a
React element (render={<Link/>}) or a function, with internal ref merging
and state-to-data-attribute mapping. renderElement stays exported for the
phased migration. Migrates Mosaic Box, Heading, Text and the dialog
trigger/popup primitives onto the hook.
@alexcarpenter
feat(headless): migrate remaining primitives to useRender
25d48a4
Convert the rest of the primitive families (accordion, autocomplete, collapsible, dialog, drawer, file-upload, menu, otp, popover, select, tabs, tooltip) from the renderElement function to the useRender hook.
Refs move to useRender's ref param; mounted guards become the enabled param; Composite/CompositeItem render callbacks extract the injected roving-tabindex ref and carry a rules-of-hooks disable justified by floating-ui invoking the callback synchronously during render.
renderElement remains exported for the final cleanup PR.
@changeset-bot

changeset-botBot commented Jul 23, 2026•
edited
Loading

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: a24606c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 0 packages

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel

vercelBot commented Jul 23, 2026•
edited
Loading

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxReadyReadyPreview, CommentJul 23, 2026 10:30pm
swingsetReadyReadyPreview, CommentJul 23, 2026 10:30pm

Request Review

@alexcarpenteralexcarpenter mentioned this pull request Jul 23, 2026
Merged
Base automatically changed from carp/mosaic-use-render to mainJuly 23, 2026 22:26
@wobsoriano
wobsoriano self-requested a review July 23, 2026 22:28
@pkg-pr-new

pkg-pr-newBot commented Jul 23, 2026

Copy link
Copy Markdown

Open in StackBlitz

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@9232

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@9232

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@9232

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@9232

@clerk/electron

npm i https://pkg.pr.new/@clerk/electron@9232

@clerk/electron-passkeys

npm i https://pkg.pr.new/@clerk/electron-passkeys@9232

@clerk/eslint-plugin

npm i https://pkg.pr.new/@clerk/eslint-plugin@9232

@clerk/expo

npm i https://pkg.pr.new/@clerk/expo@9232

@clerk/expo-google-signin

npm i https://pkg.pr.new/@clerk/expo-google-signin@9232

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@9232

@clerk/express

npm i https://pkg.pr.new/@clerk/express@9232

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@9232

@clerk/hono

npm i https://pkg.pr.new/@clerk/hono@9232

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@9232

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@9232

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@9232

@clerk/react

npm i https://pkg.pr.new/@clerk/react@9232

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@9232

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@9232

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@9232

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@9232

@clerk/ui

npm i https://pkg.pr.new/@clerk/ui@9232

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@9232

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@9232

commit: a24606c

@coderabbitai

coderabbitaiBot commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: 5b6557dd-238d-4c41-81c2-201740932479

📥 Commits

Reviewing files that changed from the base of the PR and between 17d1db1 and a24606c.

📒 Files selected for processing (60)
  • .changeset/headless-primitives-use-render.md
  • packages/headless/src/primitives/accordion/accordion-header.tsx
  • packages/headless/src/primitives/accordion/accordion-item.tsx
  • packages/headless/src/primitives/accordion/accordion-panel.tsx
  • packages/headless/src/primitives/accordion/accordion-root.tsx
  • packages/headless/src/primitives/accordion/accordion-trigger.tsx
  • packages/headless/src/primitives/autocomplete/autocomplete-input.tsx
  • packages/headless/src/primitives/autocomplete/autocomplete-list.tsx
  • packages/headless/src/primitives/autocomplete/autocomplete-option.tsx
  • packages/headless/src/primitives/autocomplete/autocomplete-popup.tsx
  • packages/headless/src/primitives/autocomplete/autocomplete-positioner.tsx
  • packages/headless/src/primitives/collapsible/collapsible-panel.tsx
  • packages/headless/src/primitives/collapsible/collapsible-root.tsx
  • packages/headless/src/primitives/collapsible/collapsible-trigger.tsx
  • packages/headless/src/primitives/dialog/README.md
  • packages/headless/src/primitives/dialog/dialog-backdrop.tsx
  • packages/headless/src/primitives/dialog/dialog-close.tsx
  • packages/headless/src/primitives/dialog/dialog-description.tsx
  • packages/headless/src/primitives/dialog/dialog-title.tsx
  • packages/headless/src/primitives/dialog/dialog-viewport.tsx
  • packages/headless/src/primitives/drawer/drawer-backdrop.tsx
  • packages/headless/src/primitives/drawer/drawer-close.tsx
  • packages/headless/src/primitives/drawer/drawer-description.tsx
  • packages/headless/src/primitives/drawer/drawer-handle-grip.tsx
  • packages/headless/src/primitives/drawer/drawer-popup.tsx
  • packages/headless/src/primitives/drawer/drawer-title.tsx
  • packages/headless/src/primitives/drawer/drawer-trigger.tsx
  • packages/headless/src/primitives/drawer/drawer-viewport.tsx
  • packages/headless/src/primitives/file-upload/file-upload-dropzone.tsx
  • packages/headless/src/primitives/file-upload/file-upload-item-delete.tsx
  • packages/headless/src/primitives/file-upload/file-upload-item-preview.tsx
  • packages/headless/src/primitives/file-upload/file-upload-item.tsx
  • packages/headless/src/primitives/file-upload/file-upload-root.tsx
  • packages/headless/src/primitives/file-upload/file-upload-trigger.tsx
  • packages/headless/src/primitives/menu/menu-item.tsx
  • packages/headless/src/primitives/menu/menu-popup.tsx
  • packages/headless/src/primitives/menu/menu-positioner.tsx
  • packages/headless/src/primitives/menu/menu-separator.tsx
  • packages/headless/src/primitives/menu/menu-trigger.tsx
  • packages/headless/src/primitives/otp/otp-input.tsx
  • packages/headless/src/primitives/otp/otp-root.tsx
  • packages/headless/src/primitives/popover/popover-close.tsx
  • packages/headless/src/primitives/popover/popover-description.tsx
  • packages/headless/src/primitives/popover/popover-popup.tsx
  • packages/headless/src/primitives/popover/popover-positioner.tsx
  • packages/headless/src/primitives/popover/popover-title.tsx
  • packages/headless/src/primitives/popover/popover-trigger.tsx
  • packages/headless/src/primitives/select/select-option.tsx
  • packages/headless/src/primitives/select/select-popup.tsx
  • packages/headless/src/primitives/select/select-positioner.tsx
  • packages/headless/src/primitives/select/select-trigger.tsx
  • packages/headless/src/primitives/select/select-value.tsx
  • packages/headless/src/primitives/tabs/tabs-indicator.tsx
  • packages/headless/src/primitives/tabs/tabs-list.tsx
  • packages/headless/src/primitives/tabs/tabs-panel.tsx
  • packages/headless/src/primitives/tabs/tabs-tab.tsx
  • packages/headless/src/primitives/tabs/tabs-trigger.tsx
  • packages/headless/src/primitives/tooltip/tooltip-popup.tsx
  • packages/headless/src/primitives/tooltip/tooltip-positioner.tsx
  • packages/headless/src/primitives/tooltip/tooltip-trigger.tsx
🔗 Linked repositories identified

CodeRabbit considers these linked repositories for cross-repo context during reviews:

  • clerk/clerk_go(manual)
  • clerk/dashboard(manual)
  • clerk/accounts(manual)
  • clerk/backoffice(manual)
  • clerk/clerk(manual)
  • clerk/clerk-docs(manual)
  • clerk/cloudflare-workers(manual)
  • clerk/clerk-ios(auto-detected)
  • clerk/cli(auto-detected)
  • clerk/clerk-android(auto-detected)
📝 Walkthrough

Walkthrough

The headless primitives replace renderElement with useRender across accordion, autocomplete, collapsible, dialog, drawer, file-upload, menu, OTP, popover, select, tabs, and tooltip components. Manual useMergeRefs usage is replaced by ref arrays passed to useRender. Mounted rendering is handled through enabled and null-element guards, while Composite callbacks extract injected refs explicitly. Documentation and a Changeset entry were updated accordingly.

Estimated code review effort: 4 (Complex) | ~60 minutes

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check nameStatusExplanationResolution
Docstring Coverage⚠️ WarningDocstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check nameStatusExplanation
Title check✅ PassedThe title clearly summarizes the main change: migrating the remaining headless primitives to useRender.
Description check✅ PassedThe description is directly related to the changeset and accurately outlines the migration and ref-handling changes.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.

Warning

Review ran into problems

🔥 Problems

Linked repositories: Couldn't analyze clerk/clerk-android - clone failed: Clone operation failed: Cloning into '/home/jailuser/git'...
warning: templates not found in /usr/share/git-core/templates
From https://github.com/clerk/clerk-android

Errors logged to '/home/jailuser/git/.git/lfs/logs/20260723T223201.601324587.log'.
Use git lfs logs last to view the log.
error: external filter 'git-lfs filter-process' failed
fatal: config/bin/detekt-cli: smudge filter lfs failed
Downloading config/bin/detekt-cli (71 MB)
Error downloading object: config/bin/detekt-cli (2655f48): Smudge error: Error downloading config/bin/detekt-cli (2655f48c7c303a5f9bf920a33229408b8571bb1d29e4e57cf7be3e151bceecb1): LFS: Client error: https://github-cloud.githubusercontent.com/alambic/media/877189286/26/55/2655f48c7c303a5f9bf920a33229408b8571bb1d29e4e57cf7be3e151bceecb1?X-Amz-Algorithm=AWS4-HMAC-SHA256&X-Amz-Credential=AKIA5BA2674WPWWEFGQ5%2F20260723%2Fus-east-1%2Fs3%2Faws4_request&X-Amz-Date=20260723T223321Z&X-Amz-Expires=3600&X-Amz-Signature=38431be9b6664e9dd6fd2c7d6276184b7366a9cbabe3ddab17076c1707c49bf8&X-Amz-SignedHeaders=host&actor_id=136622811&key_id=0&repo_id=980409545&token=1

Errors logged to '/home/jailuser/git/.git/lfs/logs/20260723T223321.746095183.log'.
Use git lfs logs last to view the log.
error: external filter 'git-lfs filter-process' failed
fatal: config/bin/detekt-cli: smudge filter lfs failed

Comment @coderabbitai help to get the list of available commands.

@alexcarpenter
alexcarpenter merged commit 499897f into mainJul 23, 2026
49 checks passed
@alexcarpenter
alexcarpenter deleted the carp/mosaic-use-render-pr2 branch July 23, 2026 23:20
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wobsorianowobsorianowobsoriano approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@alexcarpenter@wobsoriano
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
feat(headless): migrate remaining primitives to useRender - #9232
Merged
alexcarpenter merged 3 commits into
mainfrom 
carp/mosaic-use-render-pr2
Jul 23, 2026
Merged
feat(headless): migrate remaining primitives to useRender#9232
alexcarpenter merged 3 commits into
mainfrom 
carp/mosaic-use-render-pr2
Conversation
@alexcarpenter
@alexcarpenteralexcarpenter
commented
Jul 23, 2026

Copy link


Copy Markdown

Member
Stacked on #9231. Merge that first.
PR2 of the renderElement → useRender migration. #9231 added the useRender hook and converted Mosaic + a couple representative primitives. This converts every remaining primitive family so renderElement has no callers left (final PR deletes it).
What changed
58 primitives across accordion, autocomplete, collapsible, dialog, drawer, file-upload, menu, otp, popover, select, tabs, tooltip. Mechanical swap, three transforms:
Refs merge inside the hook. Per-site useMergeRefs disappears.
// beforeconstcombinedRef=useMergeRefs([popupRef,refs.setFloating,ref]);constdefaultProps={ref: combinedRef, ...getFloatingProps()};returnrenderElement({defaultTagName: 'div', render,props: mergeProps(defaultProps,otherProps)});// afterreturnuseRender({defaultTagName: 'div', render,ref: [popupRef,refs.setFloating,ref],props: mergeProps(defaultProps,otherProps)});
mounted guard becomes enabled. Hook stays unconditional (returns null).
// beforeif(!mounted)returnnull;returnrenderElement({ ... });// after (wrapped-in-JSX case)constelement=useRender({ ...,enabled: mounted});if(!element)returnnull;return<FloatingFocusManager...>{element}</FloatingFocusManager>;
Composite/CompositeItem callbacks. floating-ui invokes the render callback synchronously during its own render (see renderJsx), so useRender there is runtime-safe but trips react-hooks/rules-of-hooks — carries a justified disable. The callback's injected roving-tabindex ref is extracted to the ref param (leaving it in props would let the hook's merged ref clobber it and break keyboard nav).
Ref safety
useRender overwrites any ref left in props with its own merged ref. So every ref was routed to the ref param, nothing left in props. Roving-focus/ref-forwarding tests cover the Composite cases.
Verified
  • @clerk/headless: 601 tests pass, typecheck clean, eslint clean (zero warnings)
  • no renderElement callers remain in src/primitives
Empty changeset: @clerk/headless is private.
@alexcarpenter
feat(headless): add useRender hook alongside renderElement
3445cc3
Introduces a base-ui-style useRender hook: a render prop that accepts a
React element (render={<Link/>}) or a function, with internal ref merging
and state-to-data-attribute mapping. renderElement stays exported for the
phased migration. Migrates Mosaic Box, Heading, Text and the dialog
trigger/popup primitives onto the hook.
@alexcarpenter
feat(headless): migrate remaining primitives to useRender
25d48a4
Convert the rest of the primitive families (accordion, autocomplete, collapsible, dialog, drawer, file-upload, menu, otp, popover, select, tabs, tooltip) from the renderElement function to the useRender hook.
Refs move to useRender's ref param; mounted guards become the enabled param; Composite/CompositeItem render callbacks extract the injected roving-tabindex ref and carry a rules-of-hooks disable justified by floating-ui invoking the callback synchronously during render.
renderElement remains exported for the final cleanup PR.
@changeset-bot
changeset-botBot
commented
Jul 23, 2026•

edited

Loading

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: a24606c
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 0 packages
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@vercel
vercelBot
commented
Jul 23, 2026•

edited

Loading

Copy link


Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.
ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxReadyReadyPreview, CommentJul 23, 2026 10:30pm
swingsetReadyReadyPreview, CommentJul 23, 2026 10:30pm
Request Review
@alexcarpenteralexcarpenter
mentioned this pull request
Jul 23, 2026
 Merged


Base automatically changed from
carp/mosaic-use-render to
mainJuly 23, 2026 22:26
@wobsoriano
wobsoriano
self-requested a review
July 23, 2026 22:28
@pkg-pr-new
pkg-pr-newBot
commented
Jul 23, 2026

Copy link


Copy Markdown

Open in StackBlitz
@clerk/astro
npm i https://pkg.pr.new/@clerk/astro@9232

@clerk/backend
npm i https://pkg.pr.new/@clerk/backend@9232

@clerk/chrome-extension
npm i https://pkg.pr.new/@clerk/chrome-extension@9232

@clerk/clerk-js
npm i https://pkg.pr.new/@clerk/clerk-js@9232

@clerk/electron
npm i https://pkg.pr.new/@clerk/electron@9232

@clerk/electron-passkeys
npm i https://pkg.pr.new/@clerk/electron-passkeys@9232

@clerk/eslint-plugin
npm i https://pkg.pr.new/@clerk/eslint-plugin@9232

@clerk/expo
npm i https://pkg.pr.new/@clerk/expo@9232

@clerk/expo-google-signin
npm i https://pkg.pr.new/@clerk/expo-google-signin@9232

@clerk/expo-passkeys
npm i https://pkg.pr.new/@clerk/expo-passkeys@9232

@clerk/express
npm i https://pkg.pr.new/@clerk/express@9232

@clerk/fastify
npm i https://pkg.pr.new/@clerk/fastify@9232

@clerk/hono
npm i https://pkg.pr.new/@clerk/hono@9232

@clerk/localizations
npm i https://pkg.pr.new/@clerk/localizations@9232

@clerk/nextjs
npm i https://pkg.pr.new/@clerk/nextjs@9232

@clerk/nuxt
npm i https://pkg.pr.new/@clerk/nuxt@9232

@clerk/react
npm i https://pkg.pr.new/@clerk/react@9232

@clerk/react-router
npm i https://pkg.pr.new/@clerk/react-router@9232

@clerk/shared
npm i https://pkg.pr.new/@clerk/shared@9232

@clerk/tanstack-react-start
npm i https://pkg.pr.new/@clerk/tanstack-react-start@9232

@clerk/testing
npm i https://pkg.pr.new/@clerk/testing@9232

@clerk/ui
npm i https://pkg.pr.new/@clerk/ui@9232

@clerk/upgrade
npm i https://pkg.pr.new/@clerk/upgrade@9232

@clerk/vue
npm i https://pkg.pr.new/@clerk/vue@9232

commit: a24606c
@coderabbitai
coderabbitaiBot
commented
Jul 23, 2026

Copy link


Copy Markdown

Contributor
Review Change Stack
No actionable comments were generated in the recent review. 🎉
ℹ️ Recent review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Organization UI (inherited)
Review profile: CHILL
Plan: Pro Plus
Run ID: 5b6557dd-238d-4c41-81c2-201740932479
📥 Commits
Reviewing files that changed from the base of the PR and between 17d1db1 and a24606c.
📒 Files selected for processing (60)
  • .changeset/headless-primitives-use-render.md
  • packages/headless/src/primitives/accordion/accordion-header.tsx
  • packages/headless/src/primitives/accordion/accordion-item.tsx
  • packages/headless/src/primitives/accordion/accordion-panel.tsx
  • packages/headless/src/primitives/accordion/accordion-root.tsx
  • packages/headless/src/primitives/accordion/accordion-trigger.tsx
  • packages/headless/src/primitives/autocomplete/autocomplete-input.tsx
  • packages/headless/src/primitives/autocomplete/autocomplete-list.tsx
  • packages/headless/src/primitives/autocomplete/autocomplete-option.tsx
  • packages/headless/src/primitives/autocomplete/autocomplete-popup.tsx
  • packages/headless/src/primitives/autocomplete/autocomplete-positioner.tsx
  • packages/headless/src/primitives/collapsible/collapsible-panel.tsx
  • packages/headless/src/primitives/collapsible/collapsible-root.tsx
  • packages/headless/src/primitives/collapsible/collapsible-trigger.tsx
  • packages/headless/src/primitives/dialog/README.md
  • packages/headless/src/primitives/dialog/dialog-backdrop.tsx
  • packages/headless/src/primitives/dialog/dialog-close.tsx
  • packages/headless/src/primitives/dialog/dialog-description.tsx
  • packages/headless/src/primitives/dialog/dialog-title.tsx
  • packages/headless/src/primitives/dialog/dialog-viewport.tsx
  • packages/headless/src/primitives/drawer/drawer-backdrop.tsx
  • packages/headless/src/primitives/drawer/drawer-close.tsx
  • packages/headless/src/primitives/drawer/drawer-description.tsx
  • packages/headless/src/primitives/drawer/drawer-handle-grip.tsx
  • packages/headless/src/primitives/drawer/drawer-popup.tsx
  • packages/headless/src/primitives/drawer/drawer-title.tsx
  • packages/headless/src/primitives/drawer/drawer-trigger.tsx
  • packages/headless/src/primitives/drawer/drawer-viewport.tsx
  • packages/headless/src/primitives/file-upload/file-upload-dropzone.tsx
  • packages/headless/src/primitives/file-upload/file-upload-item-delete.tsx
  • packages/headless/src/primitives/file-upload/file-upload-item-preview.tsx
  • packages/headless/src/primitives/file-upload/file-upload-item.tsx
  • packages/headless/src/primitives/file-upload/file-upload-root.tsx
  • packages/headless/src/primitives/file-upload/file-upload-trigger.tsx
  • packages/headless/src/primitives/menu/menu-item.tsx
  • packages/headless/src/primitives/menu/menu-popup.tsx
  • packages/headless/src/primitives/menu/menu-positioner.tsx
  • packages/headless/src/primitives/menu/menu-separator.tsx
  • packages/headless/src/primitives/menu/menu-trigger.tsx
  • packages/headless/src/primitives/otp/otp-input.tsx
  • packages/headless/src/primitives/otp/otp-root.tsx
  • packages/headless/src/primitives/popover/popover-close.tsx
  • packages/headless/src/primitives/popover/popover-description.tsx
  • packages/headless/src/primitives/popover/popover-popup.tsx
  • packages/headless/src/primitives/popover/popover-positioner.tsx
  • packages/headless/src/primitives/popover/popover-title.tsx
  • packages/headless/src/primitives/popover/popover-trigger.tsx
  • packages/headless/src/primitives/select/select-option.tsx
  • packages/headless/src/primitives/select/select-popup.tsx
  • packages/headless/src/primitives/select/select-positioner.tsx
  • packages/headless/src/primitives/select/select-trigger.tsx
  • packages/headless/src/primitives/select/select-value.tsx
  • packages/headless/src/primitives/tabs/tabs-indicator.tsx
  • packages/headless/src/primitives/tabs/tabs-list.tsx
  • packages/headless/src/primitives/tabs/tabs-panel.tsx
  • packages/headless/src/primitives/tabs/tabs-tab.tsx
  • packages/headless/src/primitives/tabs/tabs-trigger.tsx
  • packages/headless/src/primitives/tooltip/tooltip-popup.tsx
  • packages/headless/src/primitives/tooltip/tooltip-positioner.tsx
  • packages/headless/src/primitives/tooltip/tooltip-trigger.tsx
🔗 Linked repositories identified
CodeRabbit considers these linked repositories for cross-repo context during reviews:
  • clerk/clerk_go(manual)
  • clerk/dashboard(manual)
  • clerk/accounts(manual)
  • clerk/backoffice(manual)
  • clerk/clerk(manual)
  • clerk/clerk-docs(manual)
  • clerk/cloudflare-workers(manual)
  • clerk/clerk-ios(auto-detected)
  • clerk/cli(auto-detected)
  • clerk/clerk-android(auto-detected)
📝 Walkthrough
Walkthrough
The headless primitives replace renderElement with useRender across accordion, autocomplete, collapsible, dialog, drawer, file-upload, menu, OTP, popover, select, tabs, and tooltip components. Manual useMergeRefs usage is replaced by ref arrays passed to useRender. Mounted rendering is handled through enabled and null-element guards, while Composite callbacks extract injected refs explicitly. Documentation and a Changeset entry were updated accordingly.
Estimated code review effort: 4 (Complex) | ~60 minutes
🚥 Pre-merge checks | ✅ 4 | ❌ 1
❌ Failed checks (1 warning)
Check nameStatusExplanationResolution
Docstring Coverage⚠️ WarningDocstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check nameStatusExplanation
Title check✅ PassedThe title clearly summarizes the main change: migrating the remaining headless primitives to useRender.
Description check✅ PassedThe description is directly related to the changeset and accurately outlines the migration and ref-handling changes.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
Warning
Review ran into problems
🔥 Problems
Linked repositories: Couldn't analyze clerk/clerk-android - clone failed: Clone operation failed: Cloning into '/home/jailuser/git'...

warning: templates not found in /usr/share/git-core/templates

From https://github.com/clerk/clerk-android
Errors logged to '/home/jailuser/git/.git/lfs/logs/20260723T223201.601324587.log'.

Use git lfs logs last to view the log.

error: external filter 'git-lfs filter-process' failed

fatal: config/bin/detekt-cli: smudge filter lfs failed

Downloading config/bin/detekt-cli (71 MB)

Error downloading object: config/bin/detekt-cli (2655f48): Smudge error: Error downloading config/bin/detekt-cli (2655f48c7c303a5f9bf920a33229408b8571bb1d29e4e57cf7be3e151bceecb1): LFS: Client error: https://github-cloud.githubusercontent.com/alambic/media/877189286/26/55/2655f48c7c303a5f9bf920a33229408b8571bb1d29e4e57cf7be3e151bceecb1?X-Amz-Algorithm=AWS4-HMAC-SHA256&X-Amz-Credential=AKIA5BA2674WPWWEFGQ5%2F20260723%2Fus-east-1%2Fs3%2Faws4_request&X-Amz-Date=20260723T223321Z&X-Amz-Expires=3600&X-Amz-Signature=38431be9b6664e9dd6fd2c7d6276184b7366a9cbabe3ddab17076c1707c49bf8&X-Amz-SignedHeaders=host&actor_id=136622811&key_id=0&repo_id=980409545&token=1
Errors logged to '/home/jailuser/git/.git/lfs/logs/20260723T223321.746095183.log'.

Use git lfs logs last to view the log.

error: external filter 'git-lfs filter-process' failed

fatal: config/bin/detekt-cli: smudge filter lfs failed
Comment @coderabbitai help to get the list of available commands.
@alexcarpenter
alexcarpenter
merged commit 499897f
into
mainJul 23, 2026

49 checks passed

@alexcarpenter
alexcarpenter
deleted the

carp/mosaic-use-render-pr2

branch
July 23, 2026 23:20
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@wobsorianowobsorianowobsoriano approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@alexcarpenter@wobsoriano

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
feat(headless): migrate remaining primitives to useRender - #9232
Merged
alexcarpenter merged 3 commits into
mainfrom 
carp/mosaic-use-render-pr2
Jul 23, 2026
Merged
feat(headless): migrate remaining primitives to useRender#9232
alexcarpenter merged 3 commits into
mainfrom 
carp/mosaic-use-render-pr2
Conversation
@alexcarpenter
@alexcarpenteralexcarpenter
commented
Jul 23, 2026

Copy link


Copy Markdown

Member
Stacked on #9231. Merge that first.
PR2 of the renderElement → useRender migration. #9231 added the useRender hook and converted Mosaic + a couple representative primitives. This converts every remaining primitive family so renderElement has no callers left (final PR deletes it).
What changed
58 primitives across accordion, autocomplete, collapsible, dialog, drawer, file-upload, menu, otp, popover, select, tabs, tooltip. Mechanical swap, three transforms:
Refs merge inside the hook. Per-site useMergeRefs disappears.
// beforeconstcombinedRef=useMergeRefs([popupRef,refs.setFloating,ref]);constdefaultProps={ref: combinedRef, ...getFloatingProps()};returnrenderElement({defaultTagName: 'div', render,props: mergeProps(defaultProps,otherProps)});// afterreturnuseRender({defaultTagName: 'div', render,ref: [popupRef,refs.setFloating,ref],props: mergeProps(defaultProps,otherProps)});
mounted guard becomes enabled. Hook stays unconditional (returns null).
// beforeif(!mounted)returnnull;returnrenderElement({ ... });// after (wrapped-in-JSX case)constelement=useRender({ ...,enabled: mounted});if(!element)returnnull;return<FloatingFocusManager...>{element}</FloatingFocusManager>;
Composite/CompositeItem callbacks. floating-ui invokes the render callback synchronously during its own render (see renderJsx), so useRender there is runtime-safe but trips react-hooks/rules-of-hooks — carries a justified disable. The callback's injected roving-tabindex ref is extracted to the ref param (leaving it in props would let the hook's merged ref clobber it and break keyboard nav).
Ref safety
useRender overwrites any ref left in props with its own merged ref. So every ref was routed to the ref param, nothing left in props. Roving-focus/ref-forwarding tests cover the Composite cases.
Verified
  • @clerk/headless: 601 tests pass, typecheck clean, eslint clean (zero warnings)
  • no renderElement callers remain in src/primitives
Empty changeset: @clerk/headless is private.
@alexcarpenter
feat(headless): add useRender hook alongside renderElement
3445cc3
Introduces a base-ui-style useRender hook: a render prop that accepts a
React element (render={<Link/>}) or a function, with internal ref merging
and state-to-data-attribute mapping. renderElement stays exported for the
phased migration. Migrates Mosaic Box, Heading, Text and the dialog
trigger/popup primitives onto the hook.
@alexcarpenter
feat(headless): migrate remaining primitives to useRender
25d48a4
Convert the rest of the primitive families (accordion, autocomplete, collapsible, dialog, drawer, file-upload, menu, otp, popover, select, tabs, tooltip) from the renderElement function to the useRender hook.
Refs move to useRender's ref param; mounted guards become the enabled param; Composite/CompositeItem render callbacks extract the injected roving-tabindex ref and carry a rules-of-hooks disable justified by floating-ui invoking the callback synchronously during render.
renderElement remains exported for the final cleanup PR.
@changeset-bot
changeset-botBot
commented
Jul 23, 2026•

edited

Loading

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: a24606c
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 0 packages
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@vercel
vercelBot
commented
Jul 23, 2026•

edited

Loading

Copy link


Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.
ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxReadyReadyPreview, CommentJul 23, 2026 10:30pm
swingsetReadyReadyPreview, CommentJul 23, 2026 10:30pm
Request Review
@alexcarpenteralexcarpenter
mentioned this pull request
Jul 23, 2026
 Merged


Base automatically changed from
carp/mosaic-use-render to
mainJuly 23, 2026 22:26
@wobsoriano
wobsoriano
self-requested a review
July 23, 2026 22:28
@pkg-pr-new
pkg-pr-newBot
commented
Jul 23, 2026

Copy link


Copy Markdown

Open in StackBlitz
@clerk/astro
npm i https://pkg.pr.new/@clerk/astro@9232

@clerk/backend
npm i https://pkg.pr.new/@clerk/backend@9232

@clerk/chrome-extension
npm i https://pkg.pr.new/@clerk/chrome-extension@9232

@clerk/clerk-js
npm i https://pkg.pr.new/@clerk/clerk-js@9232

@clerk/electron
npm i https://pkg.pr.new/@clerk/electron@9232

@clerk/electron-passkeys
npm i https://pkg.pr.new/@clerk/electron-passkeys@9232

@clerk/eslint-plugin
npm i https://pkg.pr.new/@clerk/eslint-plugin@9232

@clerk/expo
npm i https://pkg.pr.new/@clerk/expo@9232

@clerk/expo-google-signin
npm i https://pkg.pr.new/@clerk/expo-google-signin@9232

@clerk/expo-passkeys
npm i https://pkg.pr.new/@clerk/expo-passkeys@9232

@clerk/express
npm i https://pkg.pr.new/@clerk/express@9232

@clerk/fastify
npm i https://pkg.pr.new/@clerk/fastify@9232

@clerk/hono
npm i https://pkg.pr.new/@clerk/hono@9232

@clerk/localizations
npm i https://pkg.pr.new/@clerk/localizations@9232

@clerk/nextjs
npm i https://pkg.pr.new/@clerk/nextjs@9232

@clerk/nuxt
npm i https://pkg.pr.new/@clerk/nuxt@9232

@clerk/react
npm i https://pkg.pr.new/@clerk/react@9232

@clerk/react-router
npm i https://pkg.pr.new/@clerk/react-router@9232

@clerk/shared
npm i https://pkg.pr.new/@clerk/shared@9232

@clerk/tanstack-react-start
npm i https://pkg.pr.new/@clerk/tanstack-react-start@9232

@clerk/testing
npm i https://pkg.pr.new/@clerk/testing@9232

@clerk/ui
npm i https://pkg.pr.new/@clerk/ui@9232

@clerk/upgrade
npm i https://pkg.pr.new/@clerk/upgrade@9232

@clerk/vue
npm i https://pkg.pr.new/@clerk/vue@9232

commit: a24606c
@coderabbitai
coderabbitaiBot
commented
Jul 23, 2026

Copy link


Copy Markdown

Contributor
Review Change Stack
No actionable comments were generated in the recent review. 🎉
ℹ️ Recent review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Organization UI (inherited)
Review profile: CHILL
Plan: Pro Plus
Run ID: 5b6557dd-238d-4c41-81c2-201740932479
📥 Commits
Reviewing files that changed from the base of the PR and between 17d1db1 and a24606c.
📒 Files selected for processing (60)
  • .changeset/headless-primitives-use-render.md
  • packages/headless/src/primitives/accordion/accordion-header.tsx
  • packages/headless/src/primitives/accordion/accordion-item.tsx
  • packages/headless/src/primitives/accordion/accordion-panel.tsx
  • packages/headless/src/primitives/accordion/accordion-root.tsx
  • packages/headless/src/primitives/accordion/accordion-trigger.tsx
  • packages/headless/src/primitives/autocomplete/autocomplete-input.tsx
  • packages/headless/src/primitives/autocomplete/autocomplete-list.tsx
  • packages/headless/src/primitives/autocomplete/autocomplete-option.tsx
  • packages/headless/src/primitives/autocomplete/autocomplete-popup.tsx
  • packages/headless/src/primitives/autocomplete/autocomplete-positioner.tsx
  • packages/headless/src/primitives/collapsible/collapsible-panel.tsx
  • packages/headless/src/primitives/collapsible/collapsible-root.tsx
  • packages/headless/src/primitives/collapsible/collapsible-trigger.tsx
  • packages/headless/src/primitives/dialog/README.md
  • packages/headless/src/primitives/dialog/dialog-backdrop.tsx
  • packages/headless/src/primitives/dialog/dialog-close.tsx
  • packages/headless/src/primitives/dialog/dialog-description.tsx
  • packages/headless/src/primitives/dialog/dialog-title.tsx
  • packages/headless/src/primitives/dialog/dialog-viewport.tsx
  • packages/headless/src/primitives/drawer/drawer-backdrop.tsx
  • packages/headless/src/primitives/drawer/drawer-close.tsx
  • packages/headless/src/primitives/drawer/drawer-description.tsx
  • packages/headless/src/primitives/drawer/drawer-handle-grip.tsx
  • packages/headless/src/primitives/drawer/drawer-popup.tsx
  • packages/headless/src/primitives/drawer/drawer-title.tsx
  • packages/headless/src/primitives/drawer/drawer-trigger.tsx
  • packages/headless/src/primitives/drawer/drawer-viewport.tsx
  • packages/headless/src/primitives/file-upload/file-upload-dropzone.tsx
  • packages/headless/src/primitives/file-upload/file-upload-item-delete.tsx
  • packages/headless/src/primitives/file-upload/file-upload-item-preview.tsx
  • packages/headless/src/primitives/file-upload/file-upload-item.tsx
  • packages/headless/src/primitives/file-upload/file-upload-root.tsx
  • packages/headless/src/primitives/file-upload/file-upload-trigger.tsx
  • packages/headless/src/primitives/menu/menu-item.tsx
  • packages/headless/src/primitives/menu/menu-popup.tsx
  • packages/headless/src/primitives/menu/menu-positioner.tsx
  • packages/headless/src/primitives/menu/menu-separator.tsx
  • packages/headless/src/primitives/menu/menu-trigger.tsx
  • packages/headless/src/primitives/otp/otp-input.tsx
  • packages/headless/src/primitives/otp/otp-root.tsx
  • packages/headless/src/primitives/popover/popover-close.tsx
  • packages/headless/src/primitives/popover/popover-description.tsx
  • packages/headless/src/primitives/popover/popover-popup.tsx
  • packages/headless/src/primitives/popover/popover-positioner.tsx
  • packages/headless/src/primitives/popover/popover-title.tsx
  • packages/headless/src/primitives/popover/popover-trigger.tsx
  • packages/headless/src/primitives/select/select-option.tsx
  • packages/headless/src/primitives/select/select-popup.tsx
  • packages/headless/src/primitives/select/select-positioner.tsx
  • packages/headless/src/primitives/select/select-trigger.tsx
  • packages/headless/src/primitives/select/select-value.tsx
  • packages/headless/src/primitives/tabs/tabs-indicator.tsx
  • packages/headless/src/primitives/tabs/tabs-list.tsx
  • packages/headless/src/primitives/tabs/tabs-panel.tsx
  • packages/headless/src/primitives/tabs/tabs-tab.tsx
  • packages/headless/src/primitives/tabs/tabs-trigger.tsx
  • packages/headless/src/primitives/tooltip/tooltip-popup.tsx
  • packages/headless/src/primitives/tooltip/tooltip-positioner.tsx
  • packages/headless/src/primitives/tooltip/tooltip-trigger.tsx
🔗 Linked repositories identified
CodeRabbit considers these linked repositories for cross-repo context during reviews:
  • clerk/clerk_go(manual)
  • clerk/dashboard(manual)
  • clerk/accounts(manual)
  • clerk/backoffice(manual)
  • clerk/clerk(manual)
  • clerk/clerk-docs(manual)
  • clerk/cloudflare-workers(manual)
  • clerk/clerk-ios(auto-detected)
  • clerk/cli(auto-detected)
  • clerk/clerk-android(auto-detected)
📝 Walkthrough
Walkthrough
The headless primitives replace renderElement with useRender across accordion, autocomplete, collapsible, dialog, drawer, file-upload, menu, OTP, popover, select, tabs, and tooltip components. Manual useMergeRefs usage is replaced by ref arrays passed to useRender. Mounted rendering is handled through enabled and null-element guards, while Composite callbacks extract injected refs explicitly. Documentation and a Changeset entry were updated accordingly.
Estimated code review effort: 4 (Complex) | ~60 minutes
🚥 Pre-merge checks | ✅ 4 | ❌ 1
❌ Failed checks (1 warning)
Check nameStatusExplanationResolution
Docstring Coverage⚠️ WarningDocstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check nameStatusExplanation
Title check✅ PassedThe title clearly summarizes the main change: migrating the remaining headless primitives to useRender.
Description check✅ PassedThe description is directly related to the changeset and accurately outlines the migration and ref-handling changes.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
Warning
Review ran into problems
🔥 Problems
Linked repositories: Couldn't analyze clerk/clerk-android - clone failed: Clone operation failed: Cloning into '/home/jailuser/git'...

warning: templates not found in /usr/share/git-core/templates

From https://github.com/clerk/clerk-android
Errors logged to '/home/jailuser/git/.git/lfs/logs/20260723T223201.601324587.log'.

Use git lfs logs last to view the log.

error: external filter 'git-lfs filter-process' failed

fatal: config/bin/detekt-cli: smudge filter lfs failed

Downloading config/bin/detekt-cli (71 MB)

Error downloading object: config/bin/detekt-cli (2655f48): Smudge error: Error downloading config/bin/detekt-cli (2655f48c7c303a5f9bf920a33229408b8571bb1d29e4e57cf7be3e151bceecb1): LFS: Client error: https://github-cloud.githubusercontent.com/alambic/media/877189286/26/55/2655f48c7c303a5f9bf920a33229408b8571bb1d29e4e57cf7be3e151bceecb1?X-Amz-Algorithm=AWS4-HMAC-SHA256&X-Amz-Credential=AKIA5BA2674WPWWEFGQ5%2F20260723%2Fus-east-1%2Fs3%2Faws4_request&X-Amz-Date=20260723T223321Z&X-Amz-Expires=3600&X-Amz-Signature=38431be9b6664e9dd6fd2c7d6276184b7366a9cbabe3ddab17076c1707c49bf8&X-Amz-SignedHeaders=host&actor_id=136622811&key_id=0&repo_id=980409545&token=1
Errors logged to '/home/jailuser/git/.git/lfs/logs/20260723T223321.746095183.log'.

Use git lfs logs last to view the log.

error: external filter 'git-lfs filter-process' failed

fatal: config/bin/detekt-cli: smudge filter lfs failed
Comment @coderabbitai help to get the list of available commands.
@alexcarpenter
alexcarpenter
merged commit 499897f
into
mainJul 23, 2026

49 checks passed

@alexcarpenter
alexcarpenter
deleted the

carp/mosaic-use-render-pr2

branch
July 23, 2026 23:20
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@wobsorianowobsorianowobsoriano approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@alexcarpenter@wobsoriano

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
feat(headless): migrate remaining primitives to useRender - #9232
Merged
alexcarpenter merged 3 commits into
mainfrom 
carp/mosaic-use-render-pr2
Jul 23, 2026
Merged
feat(headless): migrate remaining primitives to useRender#9232
alexcarpenter merged 3 commits into
mainfrom 
carp/mosaic-use-render-pr2
Conversation
@alexcarpenter
@alexcarpenteralexcarpenter
commented
Jul 23, 2026

Copy link


Copy Markdown

Member
Stacked on #9231. Merge that first.
PR2 of the renderElement → useRender migration. #9231 added the useRender hook and converted Mosaic + a couple representative primitives. This converts every remaining primitive family so renderElement has no callers left (final PR deletes it).
What changed
58 primitives across accordion, autocomplete, collapsible, dialog, drawer, file-upload, menu, otp, popover, select, tabs, tooltip. Mechanical swap, three transforms:
Refs merge inside the hook. Per-site useMergeRefs disappears.
// beforeconstcombinedRef=useMergeRefs([popupRef,refs.setFloating,ref]);constdefaultProps={ref: combinedRef, ...getFloatingProps()};returnrenderElement({defaultTagName: 'div', render,props: mergeProps(defaultProps,otherProps)});// afterreturnuseRender({defaultTagName: 'div', render,ref: [popupRef,refs.setFloating,ref],props: mergeProps(defaultProps,otherProps)});
mounted guard becomes enabled. Hook stays unconditional (returns null).
// beforeif(!mounted)returnnull;returnrenderElement({ ... });// after (wrapped-in-JSX case)constelement=useRender({ ...,enabled: mounted});if(!element)returnnull;return<FloatingFocusManager...>{element}</FloatingFocusManager>;
Composite/CompositeItem callbacks. floating-ui invokes the render callback synchronously during its own render (see renderJsx), so useRender there is runtime-safe but trips react-hooks/rules-of-hooks — carries a justified disable. The callback's injected roving-tabindex ref is extracted to the ref param (leaving it in props would let the hook's merged ref clobber it and break keyboard nav).
Ref safety
useRender overwrites any ref left in props with its own merged ref. So every ref was routed to the ref param, nothing left in props. Roving-focus/ref-forwarding tests cover the Composite cases.
Verified
  • @clerk/headless: 601 tests pass, typecheck clean, eslint clean (zero warnings)
  • no renderElement callers remain in src/primitives
Empty changeset: @clerk/headless is private.
@alexcarpenter
feat(headless): add useRender hook alongside renderElement
3445cc3
Introduces a base-ui-style useRender hook: a render prop that accepts a
React element (render={<Link/>}) or a function, with internal ref merging
and state-to-data-attribute mapping. renderElement stays exported for the
phased migration. Migrates Mosaic Box, Heading, Text and the dialog
trigger/popup primitives onto the hook.
@alexcarpenter
feat(headless): migrate remaining primitives to useRender
25d48a4
Convert the rest of the primitive families (accordion, autocomplete, collapsible, dialog, drawer, file-upload, menu, otp, popover, select, tabs, tooltip) from the renderElement function to the useRender hook.
Refs move to useRender's ref param; mounted guards become the enabled param; Composite/CompositeItem render callbacks extract the injected roving-tabindex ref and carry a rules-of-hooks disable justified by floating-ui invoking the callback synchronously during render.
renderElement remains exported for the final cleanup PR.
@changeset-bot
changeset-botBot
commented
Jul 23, 2026•

edited

Loading

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: a24606c
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 0 packages
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@vercel
vercelBot
commented
Jul 23, 2026•

edited

Loading

Copy link


Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.
ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxReadyReadyPreview, CommentJul 23, 2026 10:30pm
swingsetReadyReadyPreview, CommentJul 23, 2026 10:30pm
Request Review
@alexcarpenteralexcarpenter
mentioned this pull request
Jul 23, 2026
 Merged


Base automatically changed from
carp/mosaic-use-render to
mainJuly 23, 2026 22:26
@wobsoriano
wobsoriano
self-requested a review
July 23, 2026 22:28
@pkg-pr-new
pkg-pr-newBot
commented
Jul 23, 2026

Copy link


Copy Markdown

Open in StackBlitz
@clerk/astro
npm i https://pkg.pr.new/@clerk/astro@9232

@clerk/backend
npm i https://pkg.pr.new/@clerk/backend@9232

@clerk/chrome-extension
npm i https://pkg.pr.new/@clerk/chrome-extension@9232

@clerk/clerk-js
npm i https://pkg.pr.new/@clerk/clerk-js@9232

@clerk/electron
npm i https://pkg.pr.new/@clerk/electron@9232

@clerk/electron-passkeys
npm i https://pkg.pr.new/@clerk/electron-passkeys@9232

@clerk/eslint-plugin
npm i https://pkg.pr.new/@clerk/eslint-plugin@9232

@clerk/expo
npm i https://pkg.pr.new/@clerk/expo@9232

@clerk/expo-google-signin
npm i https://pkg.pr.new/@clerk/expo-google-signin@9232

@clerk/expo-passkeys
npm i https://pkg.pr.new/@clerk/expo-passkeys@9232

@clerk/express
npm i https://pkg.pr.new/@clerk/express@9232

@clerk/fastify
npm i https://pkg.pr.new/@clerk/fastify@9232

@clerk/hono
npm i https://pkg.pr.new/@clerk/hono@9232

@clerk/localizations
npm i https://pkg.pr.new/@clerk/localizations@9232

@clerk/nextjs
npm i https://pkg.pr.new/@clerk/nextjs@9232

@clerk/nuxt
npm i https://pkg.pr.new/@clerk/nuxt@9232

@clerk/react
npm i https://pkg.pr.new/@clerk/react@9232

@clerk/react-router
npm i https://pkg.pr.new/@clerk/react-router@9232

@clerk/shared
npm i https://pkg.pr.new/@clerk/shared@9232

@clerk/tanstack-react-start
npm i https://pkg.pr.new/@clerk/tanstack-react-start@9232

@clerk/testing
npm i https://pkg.pr.new/@clerk/testing@9232

@clerk/ui
npm i https://pkg.pr.new/@clerk/ui@9232

@clerk/upgrade
npm i https://pkg.pr.new/@clerk/upgrade@9232

@clerk/vue
npm i https://pkg.pr.new/@clerk/vue@9232

commit: a24606c
@coderabbitai
coderabbitaiBot
commented
Jul 23, 2026

Copy link


Copy Markdown

Contributor
Review Change Stack
No actionable comments were generated in the recent review. 🎉
ℹ️ Recent review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Organization UI (inherited)
Review profile: CHILL
Plan: Pro Plus
Run ID: 5b6557dd-238d-4c41-81c2-201740932479
📥 Commits
Reviewing files that changed from the base of the PR and between 17d1db1 and a24606c.
📒 Files selected for processing (60)
  • .changeset/headless-primitives-use-render.md
  • packages/headless/src/primitives/accordion/accordion-header.tsx
  • packages/headless/src/primitives/accordion/accordion-item.tsx
  • packages/headless/src/primitives/accordion/accordion-panel.tsx
  • packages/headless/src/primitives/accordion/accordion-root.tsx
  • packages/headless/src/primitives/accordion/accordion-trigger.tsx
  • packages/headless/src/primitives/autocomplete/autocomplete-input.tsx
  • packages/headless/src/primitives/autocomplete/autocomplete-list.tsx
  • packages/headless/src/primitives/autocomplete/autocomplete-option.tsx
  • packages/headless/src/primitives/autocomplete/autocomplete-popup.tsx
  • packages/headless/src/primitives/autocomplete/autocomplete-positioner.tsx
  • packages/headless/src/primitives/collapsible/collapsible-panel.tsx
  • packages/headless/src/primitives/collapsible/collapsible-root.tsx
  • packages/headless/src/primitives/collapsible/collapsible-trigger.tsx
  • packages/headless/src/primitives/dialog/README.md
  • packages/headless/src/primitives/dialog/dialog-backdrop.tsx
  • packages/headless/src/primitives/dialog/dialog-close.tsx
  • packages/headless/src/primitives/dialog/dialog-description.tsx
  • packages/headless/src/primitives/dialog/dialog-title.tsx
  • packages/headless/src/primitives/dialog/dialog-viewport.tsx
  • packages/headless/src/primitives/drawer/drawer-backdrop.tsx
  • packages/headless/src/primitives/drawer/drawer-close.tsx
  • packages/headless/src/primitives/drawer/drawer-description.tsx
  • packages/headless/src/primitives/drawer/drawer-handle-grip.tsx
  • packages/headless/src/primitives/drawer/drawer-popup.tsx
  • packages/headless/src/primitives/drawer/drawer-title.tsx
  • packages/headless/src/primitives/drawer/drawer-trigger.tsx
  • packages/headless/src/primitives/drawer/drawer-viewport.tsx
  • packages/headless/src/primitives/file-upload/file-upload-dropzone.tsx
  • packages/headless/src/primitives/file-upload/file-upload-item-delete.tsx
  • packages/headless/src/primitives/file-upload/file-upload-item-preview.tsx
  • packages/headless/src/primitives/file-upload/file-upload-item.tsx
  • packages/headless/src/primitives/file-upload/file-upload-root.tsx
  • packages/headless/src/primitives/file-upload/file-upload-trigger.tsx
  • packages/headless/src/primitives/menu/menu-item.tsx
  • packages/headless/src/primitives/menu/menu-popup.tsx
  • packages/headless/src/primitives/menu/menu-positioner.tsx
  • packages/headless/src/primitives/menu/menu-separator.tsx
  • packages/headless/src/primitives/menu/menu-trigger.tsx
  • packages/headless/src/primitives/otp/otp-input.tsx
  • packages/headless/src/primitives/otp/otp-root.tsx
  • packages/headless/src/primitives/popover/popover-close.tsx
  • packages/headless/src/primitives/popover/popover-description.tsx
  • packages/headless/src/primitives/popover/popover-popup.tsx
  • packages/headless/src/primitives/popover/popover-positioner.tsx
  • packages/headless/src/primitives/popover/popover-title.tsx
  • packages/headless/src/primitives/popover/popover-trigger.tsx
  • packages/headless/src/primitives/select/select-option.tsx
  • packages/headless/src/primitives/select/select-popup.tsx
  • packages/headless/src/primitives/select/select-positioner.tsx
  • packages/headless/src/primitives/select/select-trigger.tsx
  • packages/headless/src/primitives/select/select-value.tsx
  • packages/headless/src/primitives/tabs/tabs-indicator.tsx
  • packages/headless/src/primitives/tabs/tabs-list.tsx
  • packages/headless/src/primitives/tabs/tabs-panel.tsx
  • packages/headless/src/primitives/tabs/tabs-tab.tsx
  • packages/headless/src/primitives/tabs/tabs-trigger.tsx
  • packages/headless/src/primitives/tooltip/tooltip-popup.tsx
  • packages/headless/src/primitives/tooltip/tooltip-positioner.tsx
  • packages/headless/src/primitives/tooltip/tooltip-trigger.tsx
🔗 Linked repositories identified
CodeRabbit considers these linked repositories for cross-repo context during reviews:
  • clerk/clerk_go(manual)
  • clerk/dashboard(manual)
  • clerk/accounts(manual)
  • clerk/backoffice(manual)
  • clerk/clerk(manual)
  • clerk/clerk-docs(manual)
  • clerk/cloudflare-workers(manual)
  • clerk/clerk-ios(auto-detected)
  • clerk/cli(auto-detected)
  • clerk/clerk-android(auto-detected)
📝 Walkthrough
Walkthrough
The headless primitives replace renderElement with useRender across accordion, autocomplete, collapsible, dialog, drawer, file-upload, menu, OTP, popover, select, tabs, and tooltip components. Manual useMergeRefs usage is replaced by ref arrays passed to useRender. Mounted rendering is handled through enabled and null-element guards, while Composite callbacks extract injected refs explicitly. Documentation and a Changeset entry were updated accordingly.
Estimated code review effort: 4 (Complex) | ~60 minutes
🚥 Pre-merge checks | ✅ 4 | ❌ 1
❌ Failed checks (1 warning)
Check nameStatusExplanationResolution
Docstring Coverage⚠️ WarningDocstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check nameStatusExplanation
Title check✅ PassedThe title clearly summarizes the main change: migrating the remaining headless primitives to useRender.
Description check✅ PassedThe description is directly related to the changeset and accurately outlines the migration and ref-handling changes.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
Warning
Review ran into problems
🔥 Problems
Linked repositories: Couldn't analyze clerk/clerk-android - clone failed: Clone operation failed: Cloning into '/home/jailuser/git'...

warning: templates not found in /usr/share/git-core/templates

From https://github.com/clerk/clerk-android
Errors logged to '/home/jailuser/git/.git/lfs/logs/20260723T223201.601324587.log'.

Use git lfs logs last to view the log.

error: external filter 'git-lfs filter-process' failed

fatal: config/bin/detekt-cli: smudge filter lfs failed

Downloading config/bin/detekt-cli (71 MB)

Error downloading object: config/bin/detekt-cli (2655f48): Smudge error: Error downloading config/bin/detekt-cli (2655f48c7c303a5f9bf920a33229408b8571bb1d29e4e57cf7be3e151bceecb1): LFS: Client error: https://github-cloud.githubusercontent.com/alambic/media/877189286/26/55/2655f48c7c303a5f9bf920a33229408b8571bb1d29e4e57cf7be3e151bceecb1?X-Amz-Algorithm=AWS4-HMAC-SHA256&X-Amz-Credential=AKIA5BA2674WPWWEFGQ5%2F20260723%2Fus-east-1%2Fs3%2Faws4_request&X-Amz-Date=20260723T223321Z&X-Amz-Expires=3600&X-Amz-Signature=38431be9b6664e9dd6fd2c7d6276184b7366a9cbabe3ddab17076c1707c49bf8&X-Amz-SignedHeaders=host&actor_id=136622811&key_id=0&repo_id=980409545&token=1
Errors logged to '/home/jailuser/git/.git/lfs/logs/20260723T223321.746095183.log'.

Use git lfs logs last to view the log.

error: external filter 'git-lfs filter-process' failed

fatal: config/bin/detekt-cli: smudge filter lfs failed
Comment @coderabbitai help to get the list of available commands.
@alexcarpenter
alexcarpenter
merged commit 499897f
into
mainJul 23, 2026

49 checks passed

@alexcarpenter
alexcarpenter
deleted the

carp/mosaic-use-render-pr2

branch
July 23, 2026 23:20
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@wobsorianowobsorianowobsoriano approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@alexcarpenter@wobsoriano

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
feat(headless): migrate remaining primitives to useRender - #9232
Merged
alexcarpenter merged 3 commits into
mainfrom 
carp/mosaic-use-render-pr2
Jul 23, 2026
Merged
feat(headless): migrate remaining primitives to useRender#9232
alexcarpenter merged 3 commits into
mainfrom 
carp/mosaic-use-render-pr2
Conversation
@alexcarpenter
@alexcarpenteralexcarpenter
commented
Jul 23, 2026

Copy link


Copy Markdown

Member
Stacked on #9231. Merge that first.
PR2 of the renderElement → useRender migration. #9231 added the useRender hook and converted Mosaic + a couple representative primitives. This converts every remaining primitive family so renderElement has no callers left (final PR deletes it).
What changed
58 primitives across accordion, autocomplete, collapsible, dialog, drawer, file-upload, menu, otp, popover, select, tabs, tooltip. Mechanical swap, three transforms:
Refs merge inside the hook. Per-site useMergeRefs disappears.
// beforeconstcombinedRef=useMergeRefs([popupRef,refs.setFloating,ref]);constdefaultProps={ref: combinedRef, ...getFloatingProps()};returnrenderElement({defaultTagName: 'div', render,props: mergeProps(defaultProps,otherProps)});// afterreturnuseRender({defaultTagName: 'div', render,ref: [popupRef,refs.setFloating,ref],props: mergeProps(defaultProps,otherProps)});
mounted guard becomes enabled. Hook stays unconditional (returns null).
// beforeif(!mounted)returnnull;returnrenderElement({ ... });// after (wrapped-in-JSX case)constelement=useRender({ ...,enabled: mounted});if(!element)returnnull;return<FloatingFocusManager...>{element}</FloatingFocusManager>;
Composite/CompositeItem callbacks. floating-ui invokes the render callback synchronously during its own render (see renderJsx), so useRender there is runtime-safe but trips react-hooks/rules-of-hooks — carries a justified disable. The callback's injected roving-tabindex ref is extracted to the ref param (leaving it in props would let the hook's merged ref clobber it and break keyboard nav).
Ref safety
useRender overwrites any ref left in props with its own merged ref. So every ref was routed to the ref param, nothing left in props. Roving-focus/ref-forwarding tests cover the Composite cases.
Verified
  • @clerk/headless: 601 tests pass, typecheck clean, eslint clean (zero warnings)
  • no renderElement callers remain in src/primitives
Empty changeset: @clerk/headless is private.
@alexcarpenter
feat(headless): add useRender hook alongside renderElement
3445cc3
Introduces a base-ui-style useRender hook: a render prop that accepts a
React element (render={<Link/>}) or a function, with internal ref merging
and state-to-data-attribute mapping. renderElement stays exported for the
phased migration. Migrates Mosaic Box, Heading, Text and the dialog
trigger/popup primitives onto the hook.
@alexcarpenter
feat(headless): migrate remaining primitives to useRender
25d48a4
Convert the rest of the primitive families (accordion, autocomplete, collapsible, dialog, drawer, file-upload, menu, otp, popover, select, tabs, tooltip) from the renderElement function to the useRender hook.
Refs move to useRender's ref param; mounted guards become the enabled param; Composite/CompositeItem render callbacks extract the injected roving-tabindex ref and carry a rules-of-hooks disable justified by floating-ui invoking the callback synchronously during render.
renderElement remains exported for the final cleanup PR.
@changeset-bot
changeset-botBot
commented
Jul 23, 2026•

edited

Loading

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: a24606c
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 0 packages
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@vercel
vercelBot
commented
Jul 23, 2026•

edited

Loading

Copy link


Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.
ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxReadyReadyPreview, CommentJul 23, 2026 10:30pm
swingsetReadyReadyPreview, CommentJul 23, 2026 10:30pm
Request Review
@alexcarpenteralexcarpenter
mentioned this pull request
Jul 23, 2026
 Merged


Base automatically changed from
carp/mosaic-use-render to
mainJuly 23, 2026 22:26
@wobsoriano
wobsoriano
self-requested a review
July 23, 2026 22:28
@pkg-pr-new
pkg-pr-newBot
commented
Jul 23, 2026

Copy link


Copy Markdown

Open in StackBlitz
@clerk/astro
npm i https://pkg.pr.new/@clerk/astro@9232

@clerk/backend
npm i https://pkg.pr.new/@clerk/backend@9232

@clerk/chrome-extension
npm i https://pkg.pr.new/@clerk/chrome-extension@9232

@clerk/clerk-js
npm i https://pkg.pr.new/@clerk/clerk-js@9232

@clerk/electron
npm i https://pkg.pr.new/@clerk/electron@9232

@clerk/electron-passkeys
npm i https://pkg.pr.new/@clerk/electron-passkeys@9232

@clerk/eslint-plugin
npm i https://pkg.pr.new/@clerk/eslint-plugin@9232

@clerk/expo
npm i https://pkg.pr.new/@clerk/expo@9232

@clerk/expo-google-signin
npm i https://pkg.pr.new/@clerk/expo-google-signin@9232

@clerk/expo-passkeys
npm i https://pkg.pr.new/@clerk/expo-passkeys@9232

@clerk/express
npm i https://pkg.pr.new/@clerk/express@9232

@clerk/fastify
npm i https://pkg.pr.new/@clerk/fastify@9232

@clerk/hono
npm i https://pkg.pr.new/@clerk/hono@9232

@clerk/localizations
npm i https://pkg.pr.new/@clerk/localizations@9232

@clerk/nextjs
npm i https://pkg.pr.new/@clerk/nextjs@9232

@clerk/nuxt
npm i https://pkg.pr.new/@clerk/nuxt@9232

@clerk/react
npm i https://pkg.pr.new/@clerk/react@9232

@clerk/react-router
npm i https://pkg.pr.new/@clerk/react-router@9232

@clerk/shared
npm i https://pkg.pr.new/@clerk/shared@9232

@clerk/tanstack-react-start
npm i https://pkg.pr.new/@clerk/tanstack-react-start@9232

@clerk/testing
npm i https://pkg.pr.new/@clerk/testing@9232

@clerk/ui
npm i https://pkg.pr.new/@clerk/ui@9232

@clerk/upgrade
npm i https://pkg.pr.new/@clerk/upgrade@9232

@clerk/vue
npm i https://pkg.pr.new/@clerk/vue@9232

commit: a24606c
@coderabbitai
coderabbitaiBot
commented
Jul 23, 2026

Copy link


Copy Markdown

Contributor
Review Change Stack
No actionable comments were generated in the recent review. 🎉
ℹ️ Recent review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Organization UI (inherited)
Review profile: CHILL
Plan: Pro Plus
Run ID: 5b6557dd-238d-4c41-81c2-201740932479
📥 Commits
Reviewing files that changed from the base of the PR and between 17d1db1 and a24606c.
📒 Files selected for processing (60)
  • .changeset/headless-primitives-use-render.md
  • packages/headless/src/primitives/accordion/accordion-header.tsx
  • packages/headless/src/primitives/accordion/accordion-item.tsx
  • packages/headless/src/primitives/accordion/accordion-panel.tsx
  • packages/headless/src/primitives/accordion/accordion-root.tsx
  • packages/headless/src/primitives/accordion/accordion-trigger.tsx
  • packages/headless/src/primitives/autocomplete/autocomplete-input.tsx
  • packages/headless/src/primitives/autocomplete/autocomplete-list.tsx
  • packages/headless/src/primitives/autocomplete/autocomplete-option.tsx
  • packages/headless/src/primitives/autocomplete/autocomplete-popup.tsx
  • packages/headless/src/primitives/autocomplete/autocomplete-positioner.tsx
  • packages/headless/src/primitives/collapsible/collapsible-panel.tsx
  • packages/headless/src/primitives/collapsible/collapsible-root.tsx
  • packages/headless/src/primitives/collapsible/collapsible-trigger.tsx
  • packages/headless/src/primitives/dialog/README.md
  • packages/headless/src/primitives/dialog/dialog-backdrop.tsx
  • packages/headless/src/primitives/dialog/dialog-close.tsx
  • packages/headless/src/primitives/dialog/dialog-description.tsx
  • packages/headless/src/primitives/dialog/dialog-title.tsx
  • packages/headless/src/primitives/dialog/dialog-viewport.tsx
  • packages/headless/src/primitives/drawer/drawer-backdrop.tsx
  • packages/headless/src/primitives/drawer/drawer-close.tsx
  • packages/headless/src/primitives/drawer/drawer-description.tsx
  • packages/headless/src/primitives/drawer/drawer-handle-grip.tsx
  • packages/headless/src/primitives/drawer/drawer-popup.tsx
  • packages/headless/src/primitives/drawer/drawer-title.tsx
  • packages/headless/src/primitives/drawer/drawer-trigger.tsx
  • packages/headless/src/primitives/drawer/drawer-viewport.tsx
  • packages/headless/src/primitives/file-upload/file-upload-dropzone.tsx
  • packages/headless/src/primitives/file-upload/file-upload-item-delete.tsx
  • packages/headless/src/primitives/file-upload/file-upload-item-preview.tsx
  • packages/headless/src/primitives/file-upload/file-upload-item.tsx
  • packages/headless/src/primitives/file-upload/file-upload-root.tsx
  • packages/headless/src/primitives/file-upload/file-upload-trigger.tsx
  • packages/headless/src/primitives/menu/menu-item.tsx
  • packages/headless/src/primitives/menu/menu-popup.tsx
  • packages/headless/src/primitives/menu/menu-positioner.tsx
  • packages/headless/src/primitives/menu/menu-separator.tsx
  • packages/headless/src/primitives/menu/menu-trigger.tsx
  • packages/headless/src/primitives/otp/otp-input.tsx
  • packages/headless/src/primitives/otp/otp-root.tsx
  • packages/headless/src/primitives/popover/popover-close.tsx
  • packages/headless/src/primitives/popover/popover-description.tsx
  • packages/headless/src/primitives/popover/popover-popup.tsx
  • packages/headless/src/primitives/popover/popover-positioner.tsx
  • packages/headless/src/primitives/popover/popover-title.tsx
  • packages/headless/src/primitives/popover/popover-trigger.tsx
  • packages/headless/src/primitives/select/select-option.tsx
  • packages/headless/src/primitives/select/select-popup.tsx
  • packages/headless/src/primitives/select/select-positioner.tsx
  • packages/headless/src/primitives/select/select-trigger.tsx
  • packages/headless/src/primitives/select/select-value.tsx
  • packages/headless/src/primitives/tabs/tabs-indicator.tsx
  • packages/headless/src/primitives/tabs/tabs-list.tsx
  • packages/headless/src/primitives/tabs/tabs-panel.tsx
  • packages/headless/src/primitives/tabs/tabs-tab.tsx
  • packages/headless/src/primitives/tabs/tabs-trigger.tsx
  • packages/headless/src/primitives/tooltip/tooltip-popup.tsx
  • packages/headless/src/primitives/tooltip/tooltip-positioner.tsx
  • packages/headless/src/primitives/tooltip/tooltip-trigger.tsx
🔗 Linked repositories identified
CodeRabbit considers these linked repositories for cross-repo context during reviews:
  • clerk/clerk_go(manual)
  • clerk/dashboard(manual)
  • clerk/accounts(manual)
  • clerk/backoffice(manual)
  • clerk/clerk(manual)
  • clerk/clerk-docs(manual)
  • clerk/cloudflare-workers(manual)
  • clerk/clerk-ios(auto-detected)
  • clerk/cli(auto-detected)
  • clerk/clerk-android(auto-detected)
📝 Walkthrough
Walkthrough
The headless primitives replace renderElement with useRender across accordion, autocomplete, collapsible, dialog, drawer, file-upload, menu, OTP, popover, select, tabs, and tooltip components. Manual useMergeRefs usage is replaced by ref arrays passed to useRender. Mounted rendering is handled through enabled and null-element guards, while Composite callbacks extract injected refs explicitly. Documentation and a Changeset entry were updated accordingly.
Estimated code review effort: 4 (Complex) | ~60 minutes
🚥 Pre-merge checks | ✅ 4 | ❌ 1
❌ Failed checks (1 warning)
Check nameStatusExplanationResolution
Docstring Coverage⚠️ WarningDocstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check nameStatusExplanation
Title check✅ PassedThe title clearly summarizes the main change: migrating the remaining headless primitives to useRender.
Description check✅ PassedThe description is directly related to the changeset and accurately outlines the migration and ref-handling changes.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
Warning
Review ran into problems
🔥 Problems
Linked repositories: Couldn't analyze clerk/clerk-android - clone failed: Clone operation failed: Cloning into '/home/jailuser/git'...

warning: templates not found in /usr/share/git-core/templates

From https://github.com/clerk/clerk-android
Errors logged to '/home/jailuser/git/.git/lfs/logs/20260723T223201.601324587.log'.

Use git lfs logs last to view the log.

error: external filter 'git-lfs filter-process' failed

fatal: config/bin/detekt-cli: smudge filter lfs failed

Downloading config/bin/detekt-cli (71 MB)

Error downloading object: config/bin/detekt-cli (2655f48): Smudge error: Error downloading config/bin/detekt-cli (2655f48c7c303a5f9bf920a33229408b8571bb1d29e4e57cf7be3e151bceecb1): LFS: Client error: https://github-cloud.githubusercontent.com/alambic/media/877189286/26/55/2655f48c7c303a5f9bf920a33229408b8571bb1d29e4e57cf7be3e151bceecb1?X-Amz-Algorithm=AWS4-HMAC-SHA256&X-Amz-Credential=AKIA5BA2674WPWWEFGQ5%2F20260723%2Fus-east-1%2Fs3%2Faws4_request&X-Amz-Date=20260723T223321Z&X-Amz-Expires=3600&X-Amz-Signature=38431be9b6664e9dd6fd2c7d6276184b7366a9cbabe3ddab17076c1707c49bf8&X-Amz-SignedHeaders=host&actor_id=136622811&key_id=0&repo_id=980409545&token=1
Errors logged to '/home/jailuser/git/.git/lfs/logs/20260723T223321.746095183.log'.

Use git lfs logs last to view the log.

error: external filter 'git-lfs filter-process' failed

fatal: config/bin/detekt-cli: smudge filter lfs failed
Comment @coderabbitai help to get the list of available commands.
@alexcarpenter
alexcarpenter
merged commit 499897f
into
mainJul 23, 2026

49 checks passed

@alexcarpenter
alexcarpenter
deleted the

carp/mosaic-use-render-pr2

branch
July 23, 2026 23:20
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@wobsorianowobsorianowobsoriano approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@alexcarpenter@wobsoriano

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
feat(headless): migrate remaining primitives to useRender - #9232
Merged
alexcarpenter merged 3 commits into
mainfrom 
carp/mosaic-use-render-pr2
Jul 23, 2026
Merged
feat(headless): migrate remaining primitives to useRender#9232
alexcarpenter merged 3 commits into
mainfrom 
carp/mosaic-use-render-pr2
Conversation
@alexcarpenter
@alexcarpenteralexcarpenter
commented
Jul 23, 2026

Copy link


Copy Markdown

Member
Stacked on #9231. Merge that first.
PR2 of the renderElement → useRender migration. #9231 added the useRender hook and converted Mosaic + a couple representative primitives. This converts every remaining primitive family so renderElement has no callers left (final PR deletes it).
What changed
58 primitives across accordion, autocomplete, collapsible, dialog, drawer, file-upload, menu, otp, popover, select, tabs, tooltip. Mechanical swap, three transforms:
Refs merge inside the hook. Per-site useMergeRefs disappears.
// beforeconstcombinedRef=useMergeRefs([popupRef,refs.setFloating,ref]);constdefaultProps={ref: combinedRef, ...getFloatingProps()};returnrenderElement({defaultTagName: 'div', render,props: mergeProps(defaultProps,otherProps)});// afterreturnuseRender({defaultTagName: 'div', render,ref: [popupRef,refs.setFloating,ref],props: mergeProps(defaultProps,otherProps)});
mounted guard becomes enabled. Hook stays unconditional (returns null).
// beforeif(!mounted)returnnull;returnrenderElement({ ... });// after (wrapped-in-JSX case)constelement=useRender({ ...,enabled: mounted});if(!element)returnnull;return<FloatingFocusManager...>{element}</FloatingFocusManager>;
Composite/CompositeItem callbacks. floating-ui invokes the render callback synchronously during its own render (see renderJsx), so useRender there is runtime-safe but trips react-hooks/rules-of-hooks — carries a justified disable. The callback's injected roving-tabindex ref is extracted to the ref param (leaving it in props would let the hook's merged ref clobber it and break keyboard nav).
Ref safety
useRender overwrites any ref left in props with its own merged ref. So every ref was routed to the ref param, nothing left in props. Roving-focus/ref-forwarding tests cover the Composite cases.
Verified
  • @clerk/headless: 601 tests pass, typecheck clean, eslint clean (zero warnings)
  • no renderElement callers remain in src/primitives
Empty changeset: @clerk/headless is private.
@alexcarpenter
feat(headless): add useRender hook alongside renderElement
3445cc3
Introduces a base-ui-style useRender hook: a render prop that accepts a
React element (render={<Link/>}) or a function, with internal ref merging
and state-to-data-attribute mapping. renderElement stays exported for the
phased migration. Migrates Mosaic Box, Heading, Text and the dialog
trigger/popup primitives onto the hook.
@alexcarpenter
feat(headless): migrate remaining primitives to useRender
25d48a4
Convert the rest of the primitive families (accordion, autocomplete, collapsible, dialog, drawer, file-upload, menu, otp, popover, select, tabs, tooltip) from the renderElement function to the useRender hook.
Refs move to useRender's ref param; mounted guards become the enabled param; Composite/CompositeItem render callbacks extract the injected roving-tabindex ref and carry a rules-of-hooks disable justified by floating-ui invoking the callback synchronously during render.
renderElement remains exported for the final cleanup PR.
@changeset-bot
changeset-botBot
commented
Jul 23, 2026•

edited

Loading

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: a24606c
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 0 packages
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@vercel
vercelBot
commented
Jul 23, 2026•

edited

Loading

Copy link


Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.
ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxReadyReadyPreview, CommentJul 23, 2026 10:30pm
swingsetReadyReadyPreview, CommentJul 23, 2026 10:30pm
Request Review
@alexcarpenteralexcarpenter
mentioned this pull request
Jul 23, 2026
 Merged


Base automatically changed from
carp/mosaic-use-render to
mainJuly 23, 2026 22:26
@wobsoriano
wobsoriano
self-requested a review
July 23, 2026 22:28
@pkg-pr-new
pkg-pr-newBot
commented
Jul 23, 2026

Copy link


Copy Markdown

Open in StackBlitz
@clerk/astro
npm i https://pkg.pr.new/@clerk/astro@9232

@clerk/backend
npm i https://pkg.pr.new/@clerk/backend@9232

@clerk/chrome-extension
npm i https://pkg.pr.new/@clerk/chrome-extension@9232

@clerk/clerk-js
npm i https://pkg.pr.new/@clerk/clerk-js@9232

@clerk/electron
npm i https://pkg.pr.new/@clerk/electron@9232

@clerk/electron-passkeys
npm i https://pkg.pr.new/@clerk/electron-passkeys@9232

@clerk/eslint-plugin
npm i https://pkg.pr.new/@clerk/eslint-plugin@9232

@clerk/expo
npm i https://pkg.pr.new/@clerk/expo@9232

@clerk/expo-google-signin
npm i https://pkg.pr.new/@clerk/expo-google-signin@9232

@clerk/expo-passkeys
npm i https://pkg.pr.new/@clerk/expo-passkeys@9232

@clerk/express
npm i https://pkg.pr.new/@clerk/express@9232

@clerk/fastify
npm i https://pkg.pr.new/@clerk/fastify@9232

@clerk/hono
npm i https://pkg.pr.new/@clerk/hono@9232

@clerk/localizations
npm i https://pkg.pr.new/@clerk/localizations@9232

@clerk/nextjs
npm i https://pkg.pr.new/@clerk/nextjs@9232

@clerk/nuxt
npm i https://pkg.pr.new/@clerk/nuxt@9232

@clerk/react
npm i https://pkg.pr.new/@clerk/react@9232

@clerk/react-router
npm i https://pkg.pr.new/@clerk/react-router@9232

@clerk/shared
npm i https://pkg.pr.new/@clerk/shared@9232

@clerk/tanstack-react-start
npm i https://pkg.pr.new/@clerk/tanstack-react-start@9232

@clerk/testing
npm i https://pkg.pr.new/@clerk/testing@9232

@clerk/ui
npm i https://pkg.pr.new/@clerk/ui@9232

@clerk/upgrade
npm i https://pkg.pr.new/@clerk/upgrade@9232

@clerk/vue
npm i https://pkg.pr.new/@clerk/vue@9232

commit: a24606c
@coderabbitai
coderabbitaiBot
commented
Jul 23, 2026

Copy link


Copy Markdown

Contributor
Review Change Stack
No actionable comments were generated in the recent review. 🎉
ℹ️ Recent review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Organization UI (inherited)
Review profile: CHILL
Plan: Pro Plus
Run ID: 5b6557dd-238d-4c41-81c2-201740932479
📥 Commits
Reviewing files that changed from the base of the PR and between 17d1db1 and a24606c.
📒 Files selected for processing (60)
  • .changeset/headless-primitives-use-render.md
  • packages/headless/src/primitives/accordion/accordion-header.tsx
  • packages/headless/src/primitives/accordion/accordion-item.tsx
  • packages/headless/src/primitives/accordion/accordion-panel.tsx
  • packages/headless/src/primitives/accordion/accordion-root.tsx
  • packages/headless/src/primitives/accordion/accordion-trigger.tsx
  • packages/headless/src/primitives/autocomplete/autocomplete-input.tsx
  • packages/headless/src/primitives/autocomplete/autocomplete-list.tsx
  • packages/headless/src/primitives/autocomplete/autocomplete-option.tsx
  • packages/headless/src/primitives/autocomplete/autocomplete-popup.tsx
  • packages/headless/src/primitives/autocomplete/autocomplete-positioner.tsx
  • packages/headless/src/primitives/collapsible/collapsible-panel.tsx
  • packages/headless/src/primitives/collapsible/collapsible-root.tsx
  • packages/headless/src/primitives/collapsible/collapsible-trigger.tsx
  • packages/headless/src/primitives/dialog/README.md
  • packages/headless/src/primitives/dialog/dialog-backdrop.tsx
  • packages/headless/src/primitives/dialog/dialog-close.tsx
  • packages/headless/src/primitives/dialog/dialog-description.tsx
  • packages/headless/src/primitives/dialog/dialog-title.tsx
  • packages/headless/src/primitives/dialog/dialog-viewport.tsx
  • packages/headless/src/primitives/drawer/drawer-backdrop.tsx
  • packages/headless/src/primitives/drawer/drawer-close.tsx
  • packages/headless/src/primitives/drawer/drawer-description.tsx
  • packages/headless/src/primitives/drawer/drawer-handle-grip.tsx
  • packages/headless/src/primitives/drawer/drawer-popup.tsx
  • packages/headless/src/primitives/drawer/drawer-title.tsx
  • packages/headless/src/primitives/drawer/drawer-trigger.tsx
  • packages/headless/src/primitives/drawer/drawer-viewport.tsx
  • packages/headless/src/primitives/file-upload/file-upload-dropzone.tsx
  • packages/headless/src/primitives/file-upload/file-upload-item-delete.tsx
  • packages/headless/src/primitives/file-upload/file-upload-item-preview.tsx
  • packages/headless/src/primitives/file-upload/file-upload-item.tsx
  • packages/headless/src/primitives/file-upload/file-upload-root.tsx
  • packages/headless/src/primitives/file-upload/file-upload-trigger.tsx
  • packages/headless/src/primitives/menu/menu-item.tsx
  • packages/headless/src/primitives/menu/menu-popup.tsx
  • packages/headless/src/primitives/menu/menu-positioner.tsx
  • packages/headless/src/primitives/menu/menu-separator.tsx
  • packages/headless/src/primitives/menu/menu-trigger.tsx
  • packages/headless/src/primitives/otp/otp-input.tsx
  • packages/headless/src/primitives/otp/otp-root.tsx
  • packages/headless/src/primitives/popover/popover-close.tsx
  • packages/headless/src/primitives/popover/popover-description.tsx
  • packages/headless/src/primitives/popover/popover-popup.tsx
  • packages/headless/src/primitives/popover/popover-positioner.tsx
  • packages/headless/src/primitives/popover/popover-title.tsx
  • packages/headless/src/primitives/popover/popover-trigger.tsx
  • packages/headless/src/primitives/select/select-option.tsx
  • packages/headless/src/primitives/select/select-popup.tsx
  • packages/headless/src/primitives/select/select-positioner.tsx
  • packages/headless/src/primitives/select/select-trigger.tsx
  • packages/headless/src/primitives/select/select-value.tsx
  • packages/headless/src/primitives/tabs/tabs-indicator.tsx
  • packages/headless/src/primitives/tabs/tabs-list.tsx
  • packages/headless/src/primitives/tabs/tabs-panel.tsx
  • packages/headless/src/primitives/tabs/tabs-tab.tsx
  • packages/headless/src/primitives/tabs/tabs-trigger.tsx
  • packages/headless/src/primitives/tooltip/tooltip-popup.tsx
  • packages/headless/src/primitives/tooltip/tooltip-positioner.tsx
  • packages/headless/src/primitives/tooltip/tooltip-trigger.tsx
🔗 Linked repositories identified
CodeRabbit considers these linked repositories for cross-repo context during reviews:
  • clerk/clerk_go(manual)
  • clerk/dashboard(manual)
  • clerk/accounts(manual)
  • clerk/backoffice(manual)
  • clerk/clerk(manual)
  • clerk/clerk-docs(manual)
  • clerk/cloudflare-workers(manual)
  • clerk/clerk-ios(auto-detected)
  • clerk/cli(auto-detected)
  • clerk/clerk-android(auto-detected)
📝 Walkthrough
Walkthrough
The headless primitives replace renderElement with useRender across accordion, autocomplete, collapsible, dialog, drawer, file-upload, menu, OTP, popover, select, tabs, and tooltip components. Manual useMergeRefs usage is replaced by ref arrays passed to useRender. Mounted rendering is handled through enabled and null-element guards, while Composite callbacks extract injected refs explicitly. Documentation and a Changeset entry were updated accordingly.
Estimated code review effort: 4 (Complex) | ~60 minutes
🚥 Pre-merge checks | ✅ 4 | ❌ 1
❌ Failed checks (1 warning)
Check nameStatusExplanationResolution
Docstring Coverage⚠️ WarningDocstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check nameStatusExplanation
Title check✅ PassedThe title clearly summarizes the main change: migrating the remaining headless primitives to useRender.
Description check✅ PassedThe description is directly related to the changeset and accurately outlines the migration and ref-handling changes.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
Warning
Review ran into problems
🔥 Problems
Linked repositories: Couldn't analyze clerk/clerk-android - clone failed: Clone operation failed: Cloning into '/home/jailuser/git'...

warning: templates not found in /usr/share/git-core/templates

From https://github.com/clerk/clerk-android
Errors logged to '/home/jailuser/git/.git/lfs/logs/20260723T223201.601324587.log'.

Use git lfs logs last to view the log.

error: external filter 'git-lfs filter-process' failed

fatal: config/bin/detekt-cli: smudge filter lfs failed

Downloading config/bin/detekt-cli (71 MB)

Error downloading object: config/bin/detekt-cli (2655f48): Smudge error: Error downloading config/bin/detekt-cli (2655f48c7c303a5f9bf920a33229408b8571bb1d29e4e57cf7be3e151bceecb1): LFS: Client error: https://github-cloud.githubusercontent.com/alambic/media/877189286/26/55/2655f48c7c303a5f9bf920a33229408b8571bb1d29e4e57cf7be3e151bceecb1?X-Amz-Algorithm=AWS4-HMAC-SHA256&X-Amz-Credential=AKIA5BA2674WPWWEFGQ5%2F20260723%2Fus-east-1%2Fs3%2Faws4_request&X-Amz-Date=20260723T223321Z&X-Amz-Expires=3600&X-Amz-Signature=38431be9b6664e9dd6fd2c7d6276184b7366a9cbabe3ddab17076c1707c49bf8&X-Amz-SignedHeaders=host&actor_id=136622811&key_id=0&repo_id=980409545&token=1
Errors logged to '/home/jailuser/git/.git/lfs/logs/20260723T223321.746095183.log'.

Use git lfs logs last to view the log.

error: external filter 'git-lfs filter-process' failed

fatal: config/bin/detekt-cli: smudge filter lfs failed
Comment @coderabbitai help to get the list of available commands.
@alexcarpenter
alexcarpenter
merged commit 499897f
into
mainJul 23, 2026

49 checks passed

@alexcarpenter
alexcarpenter
deleted the

carp/mosaic-use-render-pr2

branch
July 23, 2026 23:20
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@wobsorianowobsorianowobsoriano approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@alexcarpenter@wobsoriano

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
feat(headless): migrate remaining primitives to useRender - #9232
Merged
alexcarpenter merged 3 commits into
mainfrom 
carp/mosaic-use-render-pr2
Jul 23, 2026
Merged
feat(headless): migrate remaining primitives to useRender#9232
alexcarpenter merged 3 commits into
mainfrom 
carp/mosaic-use-render-pr2
Conversation
@alexcarpenter
@alexcarpenteralexcarpenter
commented
Jul 23, 2026

Copy link


Copy Markdown

Member
Stacked on #9231. Merge that first.
PR2 of the renderElement → useRender migration. #9231 added the useRender hook and converted Mosaic + a couple representative primitives. This converts every remaining primitive family so renderElement has no callers left (final PR deletes it).
What changed
58 primitives across accordion, autocomplete, collapsible, dialog, drawer, file-upload, menu, otp, popover, select, tabs, tooltip. Mechanical swap, three transforms:
Refs merge inside the hook. Per-site useMergeRefs disappears.
// beforeconstcombinedRef=useMergeRefs([popupRef,refs.setFloating,ref]);constdefaultProps={ref: combinedRef, ...getFloatingProps()};returnrenderElement({defaultTagName: 'div', render,props: mergeProps(defaultProps,otherProps)});// afterreturnuseRender({defaultTagName: 'div', render,ref: [popupRef,refs.setFloating,ref],props: mergeProps(defaultProps,otherProps)});
mounted guard becomes enabled. Hook stays unconditional (returns null).
// beforeif(!mounted)returnnull;returnrenderElement({ ... });// after (wrapped-in-JSX case)constelement=useRender({ ...,enabled: mounted});if(!element)returnnull;return<FloatingFocusManager...>{element}</FloatingFocusManager>;
Composite/CompositeItem callbacks. floating-ui invokes the render callback synchronously during its own render (see renderJsx), so useRender there is runtime-safe but trips react-hooks/rules-of-hooks — carries a justified disable. The callback's injected roving-tabindex ref is extracted to the ref param (leaving it in props would let the hook's merged ref clobber it and break keyboard nav).
Ref safety
useRender overwrites any ref left in props with its own merged ref. So every ref was routed to the ref param, nothing left in props. Roving-focus/ref-forwarding tests cover the Composite cases.
Verified
  • @clerk/headless: 601 tests pass, typecheck clean, eslint clean (zero warnings)
  • no renderElement callers remain in src/primitives
Empty changeset: @clerk/headless is private.
@alexcarpenter
feat(headless): add useRender hook alongside renderElement
3445cc3
Introduces a base-ui-style useRender hook: a render prop that accepts a
React element (render={<Link/>}) or a function, with internal ref merging
and state-to-data-attribute mapping. renderElement stays exported for the
phased migration. Migrates Mosaic Box, Heading, Text and the dialog
trigger/popup primitives onto the hook.
@alexcarpenter
feat(headless): migrate remaining primitives to useRender
25d48a4
Convert the rest of the primitive families (accordion, autocomplete, collapsible, dialog, drawer, file-upload, menu, otp, popover, select, tabs, tooltip) from the renderElement function to the useRender hook.
Refs move to useRender's ref param; mounted guards become the enabled param; Composite/CompositeItem render callbacks extract the injected roving-tabindex ref and carry a rules-of-hooks disable justified by floating-ui invoking the callback synchronously during render.
renderElement remains exported for the final cleanup PR.
@changeset-bot
changeset-botBot
commented
Jul 23, 2026•

edited

Loading

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: a24606c
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 0 packages
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@vercel
vercelBot
commented
Jul 23, 2026•

edited

Loading

Copy link


Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.
ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxReadyReadyPreview, CommentJul 23, 2026 10:30pm
swingsetReadyReadyPreview, CommentJul 23, 2026 10:30pm
Request Review
@alexcarpenteralexcarpenter
mentioned this pull request
Jul 23, 2026
 Merged


Base automatically changed from
carp/mosaic-use-render to
mainJuly 23, 2026 22:26
@wobsoriano
wobsoriano
self-requested a review
July 23, 2026 22:28
@pkg-pr-new
pkg-pr-newBot
commented
Jul 23, 2026

Copy link


Copy Markdown

Open in StackBlitz
@clerk/astro
npm i https://pkg.pr.new/@clerk/astro@9232

@clerk/backend
npm i https://pkg.pr.new/@clerk/backend@9232

@clerk/chrome-extension
npm i https://pkg.pr.new/@clerk/chrome-extension@9232

@clerk/clerk-js
npm i https://pkg.pr.new/@clerk/clerk-js@9232

@clerk/electron
npm i https://pkg.pr.new/@clerk/electron@9232

@clerk/electron-passkeys
npm i https://pkg.pr.new/@clerk/electron-passkeys@9232

@clerk/eslint-plugin
npm i https://pkg.pr.new/@clerk/eslint-plugin@9232

@clerk/expo
npm i https://pkg.pr.new/@clerk/expo@9232

@clerk/expo-google-signin
npm i https://pkg.pr.new/@clerk/expo-google-signin@9232

@clerk/expo-passkeys
npm i https://pkg.pr.new/@clerk/expo-passkeys@9232

@clerk/express
npm i https://pkg.pr.new/@clerk/express@9232

@clerk/fastify
npm i https://pkg.pr.new/@clerk/fastify@9232

@clerk/hono
npm i https://pkg.pr.new/@clerk/hono@9232

@clerk/localizations
npm i https://pkg.pr.new/@clerk/localizations@9232

@clerk/nextjs
npm i https://pkg.pr.new/@clerk/nextjs@9232

@clerk/nuxt
npm i https://pkg.pr.new/@clerk/nuxt@9232

@clerk/react
npm i https://pkg.pr.new/@clerk/react@9232

@clerk/react-router
npm i https://pkg.pr.new/@clerk/react-router@9232

@clerk/shared
npm i https://pkg.pr.new/@clerk/shared@9232

@clerk/tanstack-react-start
npm i https://pkg.pr.new/@clerk/tanstack-react-start@9232

@clerk/testing
npm i https://pkg.pr.new/@clerk/testing@9232

@clerk/ui
npm i https://pkg.pr.new/@clerk/ui@9232

@clerk/upgrade
npm i https://pkg.pr.new/@clerk/upgrade@9232

@clerk/vue
npm i https://pkg.pr.new/@clerk/vue@9232

commit: a24606c
@coderabbitai
coderabbitaiBot
commented
Jul 23, 2026

Copy link


Copy Markdown

Contributor
Review Change Stack
No actionable comments were generated in the recent review. 🎉
ℹ️ Recent review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Organization UI (inherited)
Review profile: CHILL
Plan: Pro Plus
Run ID: 5b6557dd-238d-4c41-81c2-201740932479
📥 Commits
Reviewing files that changed from the base of the PR and between 17d1db1 and a24606c.
📒 Files selected for processing (60)
  • .changeset/headless-primitives-use-render.md
  • packages/headless/src/primitives/accordion/accordion-header.tsx
  • packages/headless/src/primitives/accordion/accordion-item.tsx
  • packages/headless/src/primitives/accordion/accordion-panel.tsx
  • packages/headless/src/primitives/accordion/accordion-root.tsx
  • packages/headless/src/primitives/accordion/accordion-trigger.tsx
  • packages/headless/src/primitives/autocomplete/autocomplete-input.tsx
  • packages/headless/src/primitives/autocomplete/autocomplete-list.tsx
  • packages/headless/src/primitives/autocomplete/autocomplete-option.tsx
  • packages/headless/src/primitives/autocomplete/autocomplete-popup.tsx
  • packages/headless/src/primitives/autocomplete/autocomplete-positioner.tsx
  • packages/headless/src/primitives/collapsible/collapsible-panel.tsx
  • packages/headless/src/primitives/collapsible/collapsible-root.tsx
  • packages/headless/src/primitives/collapsible/collapsible-trigger.tsx
  • packages/headless/src/primitives/dialog/README.md
  • packages/headless/src/primitives/dialog/dialog-backdrop.tsx
  • packages/headless/src/primitives/dialog/dialog-close.tsx
  • packages/headless/src/primitives/dialog/dialog-description.tsx
  • packages/headless/src/primitives/dialog/dialog-title.tsx
  • packages/headless/src/primitives/dialog/dialog-viewport.tsx
  • packages/headless/src/primitives/drawer/drawer-backdrop.tsx
  • packages/headless/src/primitives/drawer/drawer-close.tsx
  • packages/headless/src/primitives/drawer/drawer-description.tsx
  • packages/headless/src/primitives/drawer/drawer-handle-grip.tsx
  • packages/headless/src/primitives/drawer/drawer-popup.tsx
  • packages/headless/src/primitives/drawer/drawer-title.tsx
  • packages/headless/src/primitives/drawer/drawer-trigger.tsx
  • packages/headless/src/primitives/drawer/drawer-viewport.tsx
  • packages/headless/src/primitives/file-upload/file-upload-dropzone.tsx
  • packages/headless/src/primitives/file-upload/file-upload-item-delete.tsx
  • packages/headless/src/primitives/file-upload/file-upload-item-preview.tsx
  • packages/headless/src/primitives/file-upload/file-upload-item.tsx
  • packages/headless/src/primitives/file-upload/file-upload-root.tsx
  • packages/headless/src/primitives/file-upload/file-upload-trigger.tsx
  • packages/headless/src/primitives/menu/menu-item.tsx
  • packages/headless/src/primitives/menu/menu-popup.tsx
  • packages/headless/src/primitives/menu/menu-positioner.tsx
  • packages/headless/src/primitives/menu/menu-separator.tsx
  • packages/headless/src/primitives/menu/menu-trigger.tsx
  • packages/headless/src/primitives/otp/otp-input.tsx
  • packages/headless/src/primitives/otp/otp-root.tsx
  • packages/headless/src/primitives/popover/popover-close.tsx
  • packages/headless/src/primitives/popover/popover-description.tsx
  • packages/headless/src/primitives/popover/popover-popup.tsx
  • packages/headless/src/primitives/popover/popover-positioner.tsx
  • packages/headless/src/primitives/popover/popover-title.tsx
  • packages/headless/src/primitives/popover/popover-trigger.tsx
  • packages/headless/src/primitives/select/select-option.tsx
  • packages/headless/src/primitives/select/select-popup.tsx
  • packages/headless/src/primitives/select/select-positioner.tsx
  • packages/headless/src/primitives/select/select-trigger.tsx
  • packages/headless/src/primitives/select/select-value.tsx
  • packages/headless/src/primitives/tabs/tabs-indicator.tsx
  • packages/headless/src/primitives/tabs/tabs-list.tsx
  • packages/headless/src/primitives/tabs/tabs-panel.tsx
  • packages/headless/src/primitives/tabs/tabs-tab.tsx
  • packages/headless/src/primitives/tabs/tabs-trigger.tsx
  • packages/headless/src/primitives/tooltip/tooltip-popup.tsx
  • packages/headless/src/primitives/tooltip/tooltip-positioner.tsx
  • packages/headless/src/primitives/tooltip/tooltip-trigger.tsx
🔗 Linked repositories identified
CodeRabbit considers these linked repositories for cross-repo context during reviews:
  • clerk/clerk_go(manual)
  • clerk/dashboard(manual)
  • clerk/accounts(manual)
  • clerk/backoffice(manual)
  • clerk/clerk(manual)
  • clerk/clerk-docs(manual)
  • clerk/cloudflare-workers(manual)
  • clerk/clerk-ios(auto-detected)
  • clerk/cli(auto-detected)
  • clerk/clerk-android(auto-detected)
📝 Walkthrough
Walkthrough
The headless primitives replace renderElement with useRender across accordion, autocomplete, collapsible, dialog, drawer, file-upload, menu, OTP, popover, select, tabs, and tooltip components. Manual useMergeRefs usage is replaced by ref arrays passed to useRender. Mounted rendering is handled through enabled and null-element guards, while Composite callbacks extract injected refs explicitly. Documentation and a Changeset entry were updated accordingly.
Estimated code review effort: 4 (Complex) | ~60 minutes
🚥 Pre-merge checks | ✅ 4 | ❌ 1
❌ Failed checks (1 warning)
Check nameStatusExplanationResolution
Docstring Coverage⚠️ WarningDocstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check nameStatusExplanation
Title check✅ PassedThe title clearly summarizes the main change: migrating the remaining headless primitives to useRender.
Description check✅ PassedThe description is directly related to the changeset and accurately outlines the migration and ref-handling changes.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
Warning
Review ran into problems
🔥 Problems
Linked repositories: Couldn't analyze clerk/clerk-android - clone failed: Clone operation failed: Cloning into '/home/jailuser/git'...

warning: templates not found in /usr/share/git-core/templates

From https://github.com/clerk/clerk-android
Errors logged to '/home/jailuser/git/.git/lfs/logs/20260723T223201.601324587.log'.

Use git lfs logs last to view the log.

error: external filter 'git-lfs filter-process' failed

fatal: config/bin/detekt-cli: smudge filter lfs failed

Downloading config/bin/detekt-cli (71 MB)

Error downloading object: config/bin/detekt-cli (2655f48): Smudge error: Error downloading config/bin/detekt-cli (2655f48c7c303a5f9bf920a33229408b8571bb1d29e4e57cf7be3e151bceecb1): LFS: Client error: https://github-cloud.githubusercontent.com/alambic/media/877189286/26/55/2655f48c7c303a5f9bf920a33229408b8571bb1d29e4e57cf7be3e151bceecb1?X-Amz-Algorithm=AWS4-HMAC-SHA256&X-Amz-Credential=AKIA5BA2674WPWWEFGQ5%2F20260723%2Fus-east-1%2Fs3%2Faws4_request&X-Amz-Date=20260723T223321Z&X-Amz-Expires=3600&X-Amz-Signature=38431be9b6664e9dd6fd2c7d6276184b7366a9cbabe3ddab17076c1707c49bf8&X-Amz-SignedHeaders=host&actor_id=136622811&key_id=0&repo_id=980409545&token=1
Errors logged to '/home/jailuser/git/.git/lfs/logs/20260723T223321.746095183.log'.

Use git lfs logs last to view the log.

error: external filter 'git-lfs filter-process' failed

fatal: config/bin/detekt-cli: smudge filter lfs failed
Comment @coderabbitai help to get the list of available commands.
@alexcarpenter
alexcarpenter
merged commit 499897f
into
mainJul 23, 2026

49 checks passed

@alexcarpenter
alexcarpenter
deleted the

carp/mosaic-use-render-pr2

branch
July 23, 2026 23:20
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@wobsorianowobsorianowobsoriano approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@alexcarpenter@wobsoriano

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
feat(headless): migrate remaining primitives to useRender - #9232
Merged
alexcarpenter merged 3 commits into
mainfrom 
carp/mosaic-use-render-pr2
Jul 23, 2026
Merged
feat(headless): migrate remaining primitives to useRender#9232
alexcarpenter merged 3 commits into
mainfrom 
carp/mosaic-use-render-pr2
Conversation
@alexcarpenter
@alexcarpenteralexcarpenter
commented
Jul 23, 2026

Copy link


Copy Markdown

Member
Stacked on #9231. Merge that first.
PR2 of the renderElement → useRender migration. #9231 added the useRender hook and converted Mosaic + a couple representative primitives. This converts every remaining primitive family so renderElement has no callers left (final PR deletes it).
What changed
58 primitives across accordion, autocomplete, collapsible, dialog, drawer, file-upload, menu, otp, popover, select, tabs, tooltip. Mechanical swap, three transforms:
Refs merge inside the hook. Per-site useMergeRefs disappears.
// beforeconstcombinedRef=useMergeRefs([popupRef,refs.setFloating,ref]);constdefaultProps={ref: combinedRef, ...getFloatingProps()};returnrenderElement({defaultTagName: 'div', render,props: mergeProps(defaultProps,otherProps)});// afterreturnuseRender({defaultTagName: 'div', render,ref: [popupRef,refs.setFloating,ref],props: mergeProps(defaultProps,otherProps)});
mounted guard becomes enabled. Hook stays unconditional (returns null).
// beforeif(!mounted)returnnull;returnrenderElement({ ... });// after (wrapped-in-JSX case)constelement=useRender({ ...,enabled: mounted});if(!element)returnnull;return<FloatingFocusManager...>{element}</FloatingFocusManager>;
Composite/CompositeItem callbacks. floating-ui invokes the render callback synchronously during its own render (see renderJsx), so useRender there is runtime-safe but trips react-hooks/rules-of-hooks — carries a justified disable. The callback's injected roving-tabindex ref is extracted to the ref param (leaving it in props would let the hook's merged ref clobber it and break keyboard nav).
Ref safety
useRender overwrites any ref left in props with its own merged ref. So every ref was routed to the ref param, nothing left in props. Roving-focus/ref-forwarding tests cover the Composite cases.
Verified
  • @clerk/headless: 601 tests pass, typecheck clean, eslint clean (zero warnings)
  • no renderElement callers remain in src/primitives
Empty changeset: @clerk/headless is private.
@alexcarpenter
feat(headless): add useRender hook alongside renderElement
3445cc3
Introduces a base-ui-style useRender hook: a render prop that accepts a
React element (render={<Link/>}) or a function, with internal ref merging
and state-to-data-attribute mapping. renderElement stays exported for the
phased migration. Migrates Mosaic Box, Heading, Text and the dialog
trigger/popup primitives onto the hook.
@alexcarpenter
feat(headless): migrate remaining primitives to useRender
25d48a4
Convert the rest of the primitive families (accordion, autocomplete, collapsible, dialog, drawer, file-upload, menu, otp, popover, select, tabs, tooltip) from the renderElement function to the useRender hook.
Refs move to useRender's ref param; mounted guards become the enabled param; Composite/CompositeItem render callbacks extract the injected roving-tabindex ref and carry a rules-of-hooks disable justified by floating-ui invoking the callback synchronously during render.
renderElement remains exported for the final cleanup PR.
@changeset-bot
changeset-botBot
commented
Jul 23, 2026•

edited

Loading

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: a24606c
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 0 packages
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@vercel
vercelBot
commented
Jul 23, 2026•

edited

Loading

Copy link


Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.
ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxReadyReadyPreview, CommentJul 23, 2026 10:30pm
swingsetReadyReadyPreview, CommentJul 23, 2026 10:30pm
Request Review
@alexcarpenteralexcarpenter
mentioned this pull request
Jul 23, 2026
 Merged


Base automatically changed from
carp/mosaic-use-render to
mainJuly 23, 2026 22:26
@wobsoriano
wobsoriano
self-requested a review
July 23, 2026 22:28
@pkg-pr-new
pkg-pr-newBot
commented
Jul 23, 2026

Copy link


Copy Markdown

Open in StackBlitz
@clerk/astro
npm i https://pkg.pr.new/@clerk/astro@9232

@clerk/backend
npm i https://pkg.pr.new/@clerk/backend@9232

@clerk/chrome-extension
npm i https://pkg.pr.new/@clerk/chrome-extension@9232

@clerk/clerk-js
npm i https://pkg.pr.new/@clerk/clerk-js@9232

@clerk/electron
npm i https://pkg.pr.new/@clerk/electron@9232

@clerk/electron-passkeys
npm i https://pkg.pr.new/@clerk/electron-passkeys@9232

@clerk/eslint-plugin
npm i https://pkg.pr.new/@clerk/eslint-plugin@9232

@clerk/expo
npm i https://pkg.pr.new/@clerk/expo@9232

@clerk/expo-google-signin
npm i https://pkg.pr.new/@clerk/expo-google-signin@9232

@clerk/expo-passkeys
npm i https://pkg.pr.new/@clerk/expo-passkeys@9232

@clerk/express
npm i https://pkg.pr.new/@clerk/express@9232

@clerk/fastify
npm i https://pkg.pr.new/@clerk/fastify@9232

@clerk/hono
npm i https://pkg.pr.new/@clerk/hono@9232

@clerk/localizations
npm i https://pkg.pr.new/@clerk/localizations@9232

@clerk/nextjs
npm i https://pkg.pr.new/@clerk/nextjs@9232

@clerk/nuxt
npm i https://pkg.pr.new/@clerk/nuxt@9232

@clerk/react
npm i https://pkg.pr.new/@clerk/react@9232

@clerk/react-router
npm i https://pkg.pr.new/@clerk/react-router@9232

@clerk/shared
npm i https://pkg.pr.new/@clerk/shared@9232

@clerk/tanstack-react-start
npm i https://pkg.pr.new/@clerk/tanstack-react-start@9232

@clerk/testing
npm i https://pkg.pr.new/@clerk/testing@9232

@clerk/ui
npm i https://pkg.pr.new/@clerk/ui@9232

@clerk/upgrade
npm i https://pkg.pr.new/@clerk/upgrade@9232

@clerk/vue
npm i https://pkg.pr.new/@clerk/vue@9232

commit: a24606c
@coderabbitai
coderabbitaiBot
commented
Jul 23, 2026

Copy link


Copy Markdown

Contributor
Review Change Stack
No actionable comments were generated in the recent review. 🎉
ℹ️ Recent review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Organization UI (inherited)
Review profile: CHILL
Plan: Pro Plus
Run ID: 5b6557dd-238d-4c41-81c2-201740932479
📥 Commits
Reviewing files that changed from the base of the PR and between 17d1db1 and a24606c.
📒 Files selected for processing (60)
  • .changeset/headless-primitives-use-render.md
  • packages/headless/src/primitives/accordion/accordion-header.tsx
  • packages/headless/src/primitives/accordion/accordion-item.tsx
  • packages/headless/src/primitives/accordion/accordion-panel.tsx
  • packages/headless/src/primitives/accordion/accordion-root.tsx
  • packages/headless/src/primitives/accordion/accordion-trigger.tsx
  • packages/headless/src/primitives/autocomplete/autocomplete-input.tsx
  • packages/headless/src/primitives/autocomplete/autocomplete-list.tsx
  • packages/headless/src/primitives/autocomplete/autocomplete-option.tsx
  • packages/headless/src/primitives/autocomplete/autocomplete-popup.tsx
  • packages/headless/src/primitives/autocomplete/autocomplete-positioner.tsx
  • packages/headless/src/primitives/collapsible/collapsible-panel.tsx
  • packages/headless/src/primitives/collapsible/collapsible-root.tsx
  • packages/headless/src/primitives/collapsible/collapsible-trigger.tsx
  • packages/headless/src/primitives/dialog/README.md
  • packages/headless/src/primitives/dialog/dialog-backdrop.tsx
  • packages/headless/src/primitives/dialog/dialog-close.tsx
  • packages/headless/src/primitives/dialog/dialog-description.tsx
  • packages/headless/src/primitives/dialog/dialog-title.tsx
  • packages/headless/src/primitives/dialog/dialog-viewport.tsx
  • packages/headless/src/primitives/drawer/drawer-backdrop.tsx
  • packages/headless/src/primitives/drawer/drawer-close.tsx
  • packages/headless/src/primitives/drawer/drawer-description.tsx
  • packages/headless/src/primitives/drawer/drawer-handle-grip.tsx
  • packages/headless/src/primitives/drawer/drawer-popup.tsx
  • packages/headless/src/primitives/drawer/drawer-title.tsx
  • packages/headless/src/primitives/drawer/drawer-trigger.tsx
  • packages/headless/src/primitives/drawer/drawer-viewport.tsx
  • packages/headless/src/primitives/file-upload/file-upload-dropzone.tsx
  • packages/headless/src/primitives/file-upload/file-upload-item-delete.tsx
  • packages/headless/src/primitives/file-upload/file-upload-item-preview.tsx
  • packages/headless/src/primitives/file-upload/file-upload-item.tsx
  • packages/headless/src/primitives/file-upload/file-upload-root.tsx
  • packages/headless/src/primitives/file-upload/file-upload-trigger.tsx
  • packages/headless/src/primitives/menu/menu-item.tsx
  • packages/headless/src/primitives/menu/menu-popup.tsx
  • packages/headless/src/primitives/menu/menu-positioner.tsx
  • packages/headless/src/primitives/menu/menu-separator.tsx
  • packages/headless/src/primitives/menu/menu-trigger.tsx
  • packages/headless/src/primitives/otp/otp-input.tsx
  • packages/headless/src/primitives/otp/otp-root.tsx
  • packages/headless/src/primitives/popover/popover-close.tsx
  • packages/headless/src/primitives/popover/popover-description.tsx
  • packages/headless/src/primitives/popover/popover-popup.tsx
  • packages/headless/src/primitives/popover/popover-positioner.tsx
  • packages/headless/src/primitives/popover/popover-title.tsx
  • packages/headless/src/primitives/popover/popover-trigger.tsx
  • packages/headless/src/primitives/select/select-option.tsx
  • packages/headless/src/primitives/select/select-popup.tsx
  • packages/headless/src/primitives/select/select-positioner.tsx
  • packages/headless/src/primitives/select/select-trigger.tsx
  • packages/headless/src/primitives/select/select-value.tsx
  • packages/headless/src/primitives/tabs/tabs-indicator.tsx
  • packages/headless/src/primitives/tabs/tabs-list.tsx
  • packages/headless/src/primitives/tabs/tabs-panel.tsx
  • packages/headless/src/primitives/tabs/tabs-tab.tsx
  • packages/headless/src/primitives/tabs/tabs-trigger.tsx
  • packages/headless/src/primitives/tooltip/tooltip-popup.tsx
  • packages/headless/src/primitives/tooltip/tooltip-positioner.tsx
  • packages/headless/src/primitives/tooltip/tooltip-trigger.tsx
🔗 Linked repositories identified
CodeRabbit considers these linked repositories for cross-repo context during reviews:
  • clerk/clerk_go(manual)
  • clerk/dashboard(manual)
  • clerk/accounts(manual)
  • clerk/backoffice(manual)
  • clerk/clerk(manual)
  • clerk/clerk-docs(manual)
  • clerk/cloudflare-workers(manual)
  • clerk/clerk-ios(auto-detected)
  • clerk/cli(auto-detected)
  • clerk/clerk-android(auto-detected)
📝 Walkthrough
Walkthrough
The headless primitives replace renderElement with useRender across accordion, autocomplete, collapsible, dialog, drawer, file-upload, menu, OTP, popover, select, tabs, and tooltip components. Manual useMergeRefs usage is replaced by ref arrays passed to useRender. Mounted rendering is handled through enabled and null-element guards, while Composite callbacks extract injected refs explicitly. Documentation and a Changeset entry were updated accordingly.
Estimated code review effort: 4 (Complex) | ~60 minutes
🚥 Pre-merge checks | ✅ 4 | ❌ 1
❌ Failed checks (1 warning)
Check nameStatusExplanationResolution
Docstring Coverage⚠️ WarningDocstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check nameStatusExplanation
Title check✅ PassedThe title clearly summarizes the main change: migrating the remaining headless primitives to useRender.
Description check✅ PassedThe description is directly related to the changeset and accurately outlines the migration and ref-handling changes.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
Warning
Review ran into problems
🔥 Problems
Linked repositories: Couldn't analyze clerk/clerk-android - clone failed: Clone operation failed: Cloning into '/home/jailuser/git'...

warning: templates not found in /usr/share/git-core/templates

From https://github.com/clerk/clerk-android
Errors logged to '/home/jailuser/git/.git/lfs/logs/20260723T223201.601324587.log'.

Use git lfs logs last to view the log.

error: external filter 'git-lfs filter-process' failed

fatal: config/bin/detekt-cli: smudge filter lfs failed

Downloading config/bin/detekt-cli (71 MB)

Error downloading object: config/bin/detekt-cli (2655f48): Smudge error: Error downloading config/bin/detekt-cli (2655f48c7c303a5f9bf920a33229408b8571bb1d29e4e57cf7be3e151bceecb1): LFS: Client error: https://github-cloud.githubusercontent.com/alambic/media/877189286/26/55/2655f48c7c303a5f9bf920a33229408b8571bb1d29e4e57cf7be3e151bceecb1?X-Amz-Algorithm=AWS4-HMAC-SHA256&X-Amz-Credential=AKIA5BA2674WPWWEFGQ5%2F20260723%2Fus-east-1%2Fs3%2Faws4_request&X-Amz-Date=20260723T223321Z&X-Amz-Expires=3600&X-Amz-Signature=38431be9b6664e9dd6fd2c7d6276184b7366a9cbabe3ddab17076c1707c49bf8&X-Amz-SignedHeaders=host&actor_id=136622811&key_id=0&repo_id=980409545&token=1
Errors logged to '/home/jailuser/git/.git/lfs/logs/20260723T223321.746095183.log'.

Use git lfs logs last to view the log.

error: external filter 'git-lfs filter-process' failed

fatal: config/bin/detekt-cli: smudge filter lfs failed
Comment @coderabbitai help to get the list of available commands.
@alexcarpenter
alexcarpenter
merged commit 499897f
into
mainJul 23, 2026

49 checks passed

@alexcarpenter
alexcarpenter
deleted the

carp/mosaic-use-render-pr2

branch
July 23, 2026 23:20
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@wobsorianowobsorianowobsoriano approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@alexcarpenter@wobsoriano