Uh oh!
There was an error while loading. Please reload this page.
fix(swingset): preserve Mosaic colors in production builds - #9283
Conversation
🦋 Changeset detectedLatest commit: 5ef5431 The changes in this PR will be included in the next version bump. This PR includes changesets to release 0 packagesWhen changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The latest updates on your projects. Learn more about Vercel for GitHub.
|
📝 WalkthroughWalkthroughAdds a shared Estimated code review effort: 2 (Simple) | ~10 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Comment |
@clerk/astro@clerk/backend@clerk/chrome-extension@clerk/clerk-js@clerk/electron@clerk/electron-passkeys@clerk/eslint-plugin@clerk/expo@clerk/expo-google-signin@clerk/expo-passkeys@clerk/express@clerk/fastify@clerk/hono@clerk/localizations@clerk/nextjs@clerk/nuxt@clerk/react@clerk/react-router@clerk/shared@clerk/tanstack-react-start@clerk/testing@clerk/ui@clerk/upgrade@clerk/vuecommit: |
API Changes Report
Summary
No API Changes DetectedAll packages have stable APIs with no detected changes. Report generated by Break Check Last ran on |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.changeset/bright-glasses-hammer.md:
- Around line 1-2: Add the affected package entries and appropriate semver bump
levels to the changeset frontmatter, then write a concise release summary
describing the production Lightning CSS configuration change. Keep the changeset
valid for changeset version and publish workflows.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Organization UI (inherited)
Review profile: CHILL
Plan: Pro Plus
Run ID: a3df5ae5-5c02-4365-b43b-7ff458091164
📒 Files selected for processing (1)
.changeset/bright-glasses-hammer.md
🔗 Linked repositories identified
CodeRabbit considers these linked repositories for cross-repo context during reviews:
clerk/clerk_go(manual)clerk/dashboard(manual)clerk/accounts(manual)clerk/backoffice(manual)clerk/clerk(manual)clerk/clerk-docs(manual)clerk/cloudflare-workers(manual)clerk/clerk-ios(auto-detected)clerk/clerk-android(auto-detected)clerk/cli(auto-detected)
| --- | ||
| --- |
There was a problem hiding this comment.
🗄️ Data Integrity & Integration | 🟠 Major | ⚡ Quick win
Add the affected package bumps and release summary.
This changeset is empty, so changeset version/publish will not release or document the production Lightning CSS configuration change. Add the affected package names, appropriate semver bumps, and a concise summary.
As per coding guidelines, Changesets must be used for version management and changelogs.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In @.changeset/bright-glasses-hammer.md around lines 1 - 2, Add the affected
package entries and appropriate semver bump levels to the changeset frontmatter,
then write a concise release summary describing the production Lightning CSS
configuration change. Keep the changeset valid for changeset version and publish
workflows.
Source: Coding guidelines
Description
In production Lightning CSS sees
light-dark()and tries to convert it for older browsers. That conversion doesn’t work correctly with StyleX’s extracted variables, so the colors become invalid.The config tells Lightning CSS that Mosaic targets browsers that already support
light-dark()so it leaves the colors unchanged.parcel-bundler/lightningcss#873 (comment)
Checklist
pnpm testruns as expected.pnpm buildruns as expected.Type of change