Skip to content

fix(fastify,express): Respond 400 instead of 500 to requests that cannot be web requests - #9290

Merged
wobsoriano merged 3 commits into
mainfrom
rob/harden-request-conversion
Jul 31, 2026
Merged

fix(fastify,express): Respond 400 instead of 500 to requests that cannot be web requests#9290
wobsoriano merged 3 commits into
mainfrom
rob/harden-request-conversion

Conversation

@wobsoriano

@wobsorianowobsoriano commented Jul 30, 2026•
edited
Loading

Copy link
Copy Markdown
Member

Description

This PR makes clerkPlugin (fastify) and clerkMiddleware (express) respond 400 Bad Request instead of 500 to requests that cannot be converted into a fetch Request. Node's HTTP parser accepts vulnerability-scanner probes such as hostless GET // targets, targets that parse as credentialed URLs, and TRACE requests, but the middleware's unguarded new URL() / new Request() calls threw on them, surfacing 500s and error-log noise where a bare app answers 404.

400 is the status for a request the server cannot process due to a client error such as malformed syntax (RFC 9110 §15.5.1), and it matches what Node and Fastify already return for the same class of input caught at their own layer. The guard also covers the Frontend API proxy branches, and the exported authenticateRequest helper is unchanged apart from an optional prebuilt clerkRequest param that avoids converting twice.

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

@changeset-bot

changeset-botBot commented Jul 30, 2026•
edited
Loading

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 01d4695

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
NameType
@clerk/fastifyPatch
@clerk/expressPatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel

vercelBot commented Jul 30, 2026•
edited
Loading

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxReadyReadyPreviewJul 30, 2026 7:59pm
swingsetReadyReadyPreviewJul 30, 2026 7:59pm

Request Review

@wobsorianowobsoriano changed the title fix(fastify,express): Response 400 instead of 500 to requests that cannot be web requestsfix(fastify,express): Respond 400 instead of 500 to requests that cannot be web requestsJul 30, 2026
github-advanced-security[bot]
github-advanced-securityBot found potential problems Jul 30, 2026
View reviewed changes
Comment threadpackages/express/src/__tests__/clerkMiddleware.test.ts Dismissed
@pkg-pr-new

pkg-pr-newBot commented Jul 30, 2026•
edited
Loading

Copy link
Copy Markdown

Open in StackBlitz

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@9290

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@9290

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@9290

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@9290

@clerk/electron

npm i https://pkg.pr.new/@clerk/electron@9290

@clerk/electron-passkeys

npm i https://pkg.pr.new/@clerk/electron-passkeys@9290

@clerk/eslint-plugin

npm i https://pkg.pr.new/@clerk/eslint-plugin@9290

@clerk/expo

npm i https://pkg.pr.new/@clerk/expo@9290

@clerk/expo-google-signin

npm i https://pkg.pr.new/@clerk/expo-google-signin@9290

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@9290

@clerk/express

npm i https://pkg.pr.new/@clerk/express@9290

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@9290

@clerk/hono

npm i https://pkg.pr.new/@clerk/hono@9290

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@9290

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@9290

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@9290

@clerk/react

npm i https://pkg.pr.new/@clerk/react@9290

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@9290

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@9290

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@9290

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@9290

@clerk/ui

npm i https://pkg.pr.new/@clerk/ui@9290

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@9290

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@9290

commit: 01d4695

@wobsoriano
wobsoriano marked this pull request as ready for review July 30, 2026 19:02
@github-actions

github-actionsBot commented Jul 30, 2026•
edited
Loading

Copy link
Copy Markdown
Contributor

API Changes Report

Generated by Break Check on 2026-07-30T20:02:36.851Z

Summary

MetricCount
Packages analyzed19
Packages with changes1
🔴 Breaking changes0
🟡 Non-breaking changes1
🟢 Additions0

🤖 This report was reviewed by claude-sonnet-4-6.

@clerk/express

Current version: 2.1.48
Recommended bump: MINOR → 2.2.0

Subpath ./types

🟡 Non-breaking Changes (1)

Modified: AuthenticateRequestParams
 type AuthenticateRequestParams = {
clerkClient: ClerkClient$1;
request: Request;
- options?: ClerkMiddlewareOptions;+ options?: ClerkMiddlewareOptions; /** Prebuilt ClerkRequest, so callers that already converted the request can skip re-conversion. */+ clerkRequest?: ClerkRequest;
};

Static analyzer: Breaking change in type alias AuthenticateRequestParams: Type changed: {clerkClient:import("@clerk/express").~ClerkClient$1;request:import("@types/express").e.Request;options?:import("@clerk… → {clerkClient:import("@clerk/express").~ClerkClient$1;request:import("@types/express").e.Request;options?:import("@clerk…

🤖 AI review (reclassified as non-breaking) (95%): The change only adds a new optional property clerkRequest? to AuthenticateRequestParams; existing consumers who construct this type need not provide it, and the type appears to be used as an input/parameter type where adding an optional field is non-breaking.

Report generated by Break Check

Last ran on 01d4695.

@coderabbitai

coderabbitaiBot commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: 00097325-ae6a-4796-9d6e-42308d5b788d

📥 Commits

Reviewing files that changed from the base of the PR and between fe6ee54 and 2db65e3.

📒 Files selected for processing (7)
  • .changeset/harden-request-conversion.md
  • packages/express/src/__tests__/clerkMiddleware.test.ts
  • packages/express/src/authenticateRequest.ts
  • packages/express/src/types.ts
  • packages/fastify/src/__tests__/frontendApiProxy.test.ts
  • packages/fastify/src/__tests__/withClerkMiddleware.test.ts
  • packages/fastify/src/withClerkMiddleware.ts
🔗 Linked repositories identified

CodeRabbit considers these linked repositories for cross-repo context during reviews:

  • clerk/clerk_go(manual)
  • clerk/dashboard(manual)
  • clerk/accounts(manual)
  • clerk/backoffice(manual)
  • clerk/clerk(manual)
  • clerk/clerk-docs(manual)
  • clerk/cloudflare-workers(manual)
  • clerk/clerk-ios(auto-detected)
  • clerk/clerk-android(auto-detected)
  • clerk/cli(auto-detected)
📝 Walkthrough

Walkthrough

Express and Fastify middleware now return HTTP 400 when request URLs, targets, methods, or proxy conversions cannot produce Fetch requests. Express can reuse a prebuilt ClerkRequest during authentication. Tests cover invalid targets, hostless targets, credentialed URL-like inputs, TRACE, and proxy bypass behavior. A changeset records patch releases for both packages.

Estimated code review effort: 3 (Moderate) | ~25 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check nameStatusExplanation
Title check✅ PassedThe title concisely summarizes the main change: returning 400 for requests that cannot be converted into web requests.
Description check✅ PassedThe description accurately describes the Fastify and Express 400-handling changes and the optional clerkRequest tweak.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Fix failing CI checks

Comment @coderabbitai help to get the list of available commands.

@wobsoriano
wobsoriano merged commit fa761dc into mainJul 31, 2026
52 checks passed
@wobsoriano
wobsoriano deleted the rob/harden-request-conversion branch July 31, 2026 16:13
@clerk-cookieclerk-cookie mentioned this pull request Jul 31, 2026
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alexcarpenteralexcarpenteralexcarpenter approved these changes
+1 more reviewer
@github-advanced-securitygithub-advanced-security[bot]github-advanced-security[bot] left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

expressfastify

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@wobsoriano@alexcarpenter@github-advanced-security
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
fix(fastify,express): Respond 400 instead of 500 to requests that cannot be web requests by wobsoriano · Pull Request #9290 · clerk/javascript · GitHub
Skip to content
fix(fastify,express): Respond 400 instead of 500 to requests that cannot be web requests - #9290
Merged
wobsoriano merged 3 commits into
mainfrom 
rob/harden-request-conversion
Jul 31, 2026
Merged
fix(fastify,express): Respond 400 instead of 500 to requests that cannot be web requests#9290
wobsoriano merged 3 commits into
mainfrom 
rob/harden-request-conversion
Conversation
@wobsoriano
@wobsorianowobsoriano
commented
Jul 30, 2026•

edited

Loading

Copy link


Copy Markdown

Member
Description
This PR makes clerkPlugin (fastify) and clerkMiddleware (express) respond 400 Bad Request instead of 500 to requests that cannot be converted into a fetch Request. Node's HTTP parser accepts vulnerability-scanner probes such as hostless GET // targets, targets that parse as credentialed URLs, and TRACE requests, but the middleware's unguarded new URL() / new Request() calls threw on them, surfacing 500s and error-log noise where a bare app answers 404.
400 is the status for a request the server cannot process due to a client error such as malformed syntax (RFC 9110 §15.5.1), and it matches what Node and Fastify already return for the same class of input caught at their own layer. The guard also covers the Frontend API proxy branches, and the exported authenticateRequest helper is unchanged apart from an optional prebuilt clerkRequest param that avoids converting twice.
Checklist
  • pnpm test runs as expected.
  • pnpm build runs as expected.
  •  (If applicable) JSDoc comments have been added or updated for any package exports
  •  (If applicable) Documentation has been updated
Type of change
  •  🐛 Bug fix
  •  🌟 New feature
  •  🔨 Breaking change
  •  📖 Refactoring / dependency upgrade / documentation
  •  other:
@changeset-bot
changeset-botBot
commented
Jul 30, 2026•

edited

Loading

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: 01d4695
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 2 packages
NameType
@clerk/fastifyPatch
@clerk/expressPatch
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@vercel
vercelBot
commented
Jul 30, 2026•

edited

Loading

Copy link


Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.
ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxReadyReadyPreviewJul 30, 2026 7:59pm
swingsetReadyReadyPreviewJul 30, 2026 7:59pm
Request Review
@wobsorianowobsoriano
changed the title
fix(fastify,express): Response 400 instead of 500 to requests that cannot be web requestsfix(fastify,express): Respond 400 instead of 500 to requests that cannot be web requestsJul 30, 2026
github-advanced-security[bot]
github-advanced-securityBot
found potential problems
Jul 30, 2026
View reviewed changes
Comment threadpackages/express/src/__tests__/clerkMiddleware.test.ts
Dismissed

@pkg-pr-new
pkg-pr-newBot
commented
Jul 30, 2026•

edited

Loading

Copy link


Copy Markdown

Open in StackBlitz
@clerk/astro
npm i https://pkg.pr.new/@clerk/astro@9290

@clerk/backend
npm i https://pkg.pr.new/@clerk/backend@9290

@clerk/chrome-extension
npm i https://pkg.pr.new/@clerk/chrome-extension@9290

@clerk/clerk-js
npm i https://pkg.pr.new/@clerk/clerk-js@9290

@clerk/electron
npm i https://pkg.pr.new/@clerk/electron@9290

@clerk/electron-passkeys
npm i https://pkg.pr.new/@clerk/electron-passkeys@9290

@clerk/eslint-plugin
npm i https://pkg.pr.new/@clerk/eslint-plugin@9290

@clerk/expo
npm i https://pkg.pr.new/@clerk/expo@9290

@clerk/expo-google-signin
npm i https://pkg.pr.new/@clerk/expo-google-signin@9290

@clerk/expo-passkeys
npm i https://pkg.pr.new/@clerk/expo-passkeys@9290

@clerk/express
npm i https://pkg.pr.new/@clerk/express@9290

@clerk/fastify
npm i https://pkg.pr.new/@clerk/fastify@9290

@clerk/hono
npm i https://pkg.pr.new/@clerk/hono@9290

@clerk/localizations
npm i https://pkg.pr.new/@clerk/localizations@9290

@clerk/nextjs
npm i https://pkg.pr.new/@clerk/nextjs@9290

@clerk/nuxt
npm i https://pkg.pr.new/@clerk/nuxt@9290

@clerk/react
npm i https://pkg.pr.new/@clerk/react@9290

@clerk/react-router
npm i https://pkg.pr.new/@clerk/react-router@9290

@clerk/shared
npm i https://pkg.pr.new/@clerk/shared@9290

@clerk/tanstack-react-start
npm i https://pkg.pr.new/@clerk/tanstack-react-start@9290

@clerk/testing
npm i https://pkg.pr.new/@clerk/testing@9290

@clerk/ui
npm i https://pkg.pr.new/@clerk/ui@9290

@clerk/upgrade
npm i https://pkg.pr.new/@clerk/upgrade@9290

@clerk/vue
npm i https://pkg.pr.new/@clerk/vue@9290

commit: 01d4695
@wobsoriano
wobsoriano
marked this pull request as ready for review
July 30, 2026 19:02
@github-actions
github-actionsBot
commented
Jul 30, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
API Changes Report
Generated by Break Check on 2026-07-30T20:02:36.851Z
Summary
MetricCount
Packages analyzed19
Packages with changes1
🔴 Breaking changes0
🟡 Non-breaking changes1
🟢 Additions0
🤖 This report was reviewed by claude-sonnet-4-6.
@clerk/express
Current version: 2.1.48
Recommended bump: MINOR → 2.2.0
Subpath ./types
🟡 Non-breaking Changes (1)
Modified: AuthenticateRequestParams
 type AuthenticateRequestParams = {
clerkClient: ClerkClient$1;
request: Request;
- options?: ClerkMiddlewareOptions;+ options?: ClerkMiddlewareOptions; /** Prebuilt ClerkRequest, so callers that already converted the request can skip re-conversion. */+ clerkRequest?: ClerkRequest;
};
Static analyzer: Breaking change in type alias AuthenticateRequestParams: Type changed: {clerkClient:import("@clerk/express").~ClerkClient$1;request:import("@types/express").e.Request;options?:import("@clerk… → {clerkClient:import("@clerk/express").~ClerkClient$1;request:import("@types/express").e.Request;options?:import("@clerk…
🤖 AI review (reclassified as non-breaking) (95%): The change only adds a new optional property clerkRequest? to AuthenticateRequestParams; existing consumers who construct this type need not provide it, and the type appears to be used as an input/parameter type where adding an optional field is non-breaking.
Report generated by Break Check
Last ran on 01d4695.
@coderabbitai
coderabbitaiBot
commented
Jul 30, 2026

Copy link


Copy Markdown

Contributor
Review Change Stack
No actionable comments were generated in the recent review. 🎉
ℹ️ Recent review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Organization UI (inherited)
Review profile: CHILL
Plan: Pro Plus
Run ID: 00097325-ae6a-4796-9d6e-42308d5b788d
📥 Commits
Reviewing files that changed from the base of the PR and between fe6ee54 and 2db65e3.
📒 Files selected for processing (7)
  • .changeset/harden-request-conversion.md
  • packages/express/src/__tests__/clerkMiddleware.test.ts
  • packages/express/src/authenticateRequest.ts
  • packages/express/src/types.ts
  • packages/fastify/src/__tests__/frontendApiProxy.test.ts
  • packages/fastify/src/__tests__/withClerkMiddleware.test.ts
  • packages/fastify/src/withClerkMiddleware.ts
🔗 Linked repositories identified
CodeRabbit considers these linked repositories for cross-repo context during reviews:
  • clerk/clerk_go(manual)
  • clerk/dashboard(manual)
  • clerk/accounts(manual)
  • clerk/backoffice(manual)
  • clerk/clerk(manual)
  • clerk/clerk-docs(manual)
  • clerk/cloudflare-workers(manual)
  • clerk/clerk-ios(auto-detected)
  • clerk/clerk-android(auto-detected)
  • clerk/cli(auto-detected)
📝 Walkthrough
Walkthrough
Express and Fastify middleware now return HTTP 400 when request URLs, targets, methods, or proxy conversions cannot produce Fetch requests. Express can reuse a prebuilt ClerkRequest during authentication. Tests cover invalid targets, hostless targets, credentialed URL-like inputs, TRACE, and proxy bypass behavior. A changeset records patch releases for both packages.
Estimated code review effort: 3 (Moderate) | ~25 minutes
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check nameStatusExplanation
Title check✅ PassedThe title concisely summarizes the main change: returning 400 for requests that cannot be converted into web requests.
Description check✅ PassedThe description accurately describes the Fastify and Express 400-handling changes and the optional clerkRequest tweak.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  •  Fix failing CI checks
Comment @coderabbitai help to get the list of available commands.
@wobsoriano
wobsoriano
merged commit fa761dc
into
mainJul 31, 2026

52 checks passed

@wobsoriano
wobsoriano
deleted the

rob/harden-request-conversion

branch
July 31, 2026 16:13
@clerk-cookieclerk-cookie
mentioned this pull request
Jul 31, 2026
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@alexcarpenteralexcarpenteralexcarpenter approved these changes

+1 more reviewer

@github-advanced-securitygithub-advanced-security[bot]github-advanced-security[bot] left review comments
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

expressfastify

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@wobsoriano@alexcarpenter@github-advanced-security

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
fix(fastify,express): Respond 400 instead of 500 to requests that cannot be web requests by wobsoriano · Pull Request #9290 · clerk/javascript · GitHub
Skip to content
fix(fastify,express): Respond 400 instead of 500 to requests that cannot be web requests - #9290
Merged
wobsoriano merged 3 commits into
mainfrom 
rob/harden-request-conversion
Jul 31, 2026
Merged
fix(fastify,express): Respond 400 instead of 500 to requests that cannot be web requests#9290
wobsoriano merged 3 commits into
mainfrom 
rob/harden-request-conversion
Conversation
@wobsoriano
@wobsorianowobsoriano
commented
Jul 30, 2026•

edited

Loading

Copy link


Copy Markdown

Member
Description
This PR makes clerkPlugin (fastify) and clerkMiddleware (express) respond 400 Bad Request instead of 500 to requests that cannot be converted into a fetch Request. Node's HTTP parser accepts vulnerability-scanner probes such as hostless GET // targets, targets that parse as credentialed URLs, and TRACE requests, but the middleware's unguarded new URL() / new Request() calls threw on them, surfacing 500s and error-log noise where a bare app answers 404.
400 is the status for a request the server cannot process due to a client error such as malformed syntax (RFC 9110 §15.5.1), and it matches what Node and Fastify already return for the same class of input caught at their own layer. The guard also covers the Frontend API proxy branches, and the exported authenticateRequest helper is unchanged apart from an optional prebuilt clerkRequest param that avoids converting twice.
Checklist
  • pnpm test runs as expected.
  • pnpm build runs as expected.
  •  (If applicable) JSDoc comments have been added or updated for any package exports
  •  (If applicable) Documentation has been updated
Type of change
  •  🐛 Bug fix
  •  🌟 New feature
  •  🔨 Breaking change
  •  📖 Refactoring / dependency upgrade / documentation
  •  other:
@changeset-bot
changeset-botBot
commented
Jul 30, 2026•

edited

Loading

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: 01d4695
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 2 packages
NameType
@clerk/fastifyPatch
@clerk/expressPatch
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@vercel
vercelBot
commented
Jul 30, 2026•

edited

Loading

Copy link


Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.
ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxReadyReadyPreviewJul 30, 2026 7:59pm
swingsetReadyReadyPreviewJul 30, 2026 7:59pm
Request Review
@wobsorianowobsoriano
changed the title
fix(fastify,express): Response 400 instead of 500 to requests that cannot be web requestsfix(fastify,express): Respond 400 instead of 500 to requests that cannot be web requestsJul 30, 2026
github-advanced-security[bot]
github-advanced-securityBot
found potential problems
Jul 30, 2026
View reviewed changes
Comment threadpackages/express/src/__tests__/clerkMiddleware.test.ts
Dismissed

@pkg-pr-new
pkg-pr-newBot
commented
Jul 30, 2026•

edited

Loading

Copy link


Copy Markdown

Open in StackBlitz
@clerk/astro
npm i https://pkg.pr.new/@clerk/astro@9290

@clerk/backend
npm i https://pkg.pr.new/@clerk/backend@9290

@clerk/chrome-extension
npm i https://pkg.pr.new/@clerk/chrome-extension@9290

@clerk/clerk-js
npm i https://pkg.pr.new/@clerk/clerk-js@9290

@clerk/electron
npm i https://pkg.pr.new/@clerk/electron@9290

@clerk/electron-passkeys
npm i https://pkg.pr.new/@clerk/electron-passkeys@9290

@clerk/eslint-plugin
npm i https://pkg.pr.new/@clerk/eslint-plugin@9290

@clerk/expo
npm i https://pkg.pr.new/@clerk/expo@9290

@clerk/expo-google-signin
npm i https://pkg.pr.new/@clerk/expo-google-signin@9290

@clerk/expo-passkeys
npm i https://pkg.pr.new/@clerk/expo-passkeys@9290

@clerk/express
npm i https://pkg.pr.new/@clerk/express@9290

@clerk/fastify
npm i https://pkg.pr.new/@clerk/fastify@9290

@clerk/hono
npm i https://pkg.pr.new/@clerk/hono@9290

@clerk/localizations
npm i https://pkg.pr.new/@clerk/localizations@9290

@clerk/nextjs
npm i https://pkg.pr.new/@clerk/nextjs@9290

@clerk/nuxt
npm i https://pkg.pr.new/@clerk/nuxt@9290

@clerk/react
npm i https://pkg.pr.new/@clerk/react@9290

@clerk/react-router
npm i https://pkg.pr.new/@clerk/react-router@9290

@clerk/shared
npm i https://pkg.pr.new/@clerk/shared@9290

@clerk/tanstack-react-start
npm i https://pkg.pr.new/@clerk/tanstack-react-start@9290

@clerk/testing
npm i https://pkg.pr.new/@clerk/testing@9290

@clerk/ui
npm i https://pkg.pr.new/@clerk/ui@9290

@clerk/upgrade
npm i https://pkg.pr.new/@clerk/upgrade@9290

@clerk/vue
npm i https://pkg.pr.new/@clerk/vue@9290

commit: 01d4695
@wobsoriano
wobsoriano
marked this pull request as ready for review
July 30, 2026 19:02
@github-actions
github-actionsBot
commented
Jul 30, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
API Changes Report
Generated by Break Check on 2026-07-30T20:02:36.851Z
Summary
MetricCount
Packages analyzed19
Packages with changes1
🔴 Breaking changes0
🟡 Non-breaking changes1
🟢 Additions0
🤖 This report was reviewed by claude-sonnet-4-6.
@clerk/express
Current version: 2.1.48
Recommended bump: MINOR → 2.2.0
Subpath ./types
🟡 Non-breaking Changes (1)
Modified: AuthenticateRequestParams
 type AuthenticateRequestParams = {
clerkClient: ClerkClient$1;
request: Request;
- options?: ClerkMiddlewareOptions;+ options?: ClerkMiddlewareOptions; /** Prebuilt ClerkRequest, so callers that already converted the request can skip re-conversion. */+ clerkRequest?: ClerkRequest;
};
Static analyzer: Breaking change in type alias AuthenticateRequestParams: Type changed: {clerkClient:import("@clerk/express").~ClerkClient$1;request:import("@types/express").e.Request;options?:import("@clerk… → {clerkClient:import("@clerk/express").~ClerkClient$1;request:import("@types/express").e.Request;options?:import("@clerk…
🤖 AI review (reclassified as non-breaking) (95%): The change only adds a new optional property clerkRequest? to AuthenticateRequestParams; existing consumers who construct this type need not provide it, and the type appears to be used as an input/parameter type where adding an optional field is non-breaking.
Report generated by Break Check
Last ran on 01d4695.
@coderabbitai
coderabbitaiBot
commented
Jul 30, 2026

Copy link


Copy Markdown

Contributor
Review Change Stack
No actionable comments were generated in the recent review. 🎉
ℹ️ Recent review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Organization UI (inherited)
Review profile: CHILL
Plan: Pro Plus
Run ID: 00097325-ae6a-4796-9d6e-42308d5b788d
📥 Commits
Reviewing files that changed from the base of the PR and between fe6ee54 and 2db65e3.
📒 Files selected for processing (7)
  • .changeset/harden-request-conversion.md
  • packages/express/src/__tests__/clerkMiddleware.test.ts
  • packages/express/src/authenticateRequest.ts
  • packages/express/src/types.ts
  • packages/fastify/src/__tests__/frontendApiProxy.test.ts
  • packages/fastify/src/__tests__/withClerkMiddleware.test.ts
  • packages/fastify/src/withClerkMiddleware.ts
🔗 Linked repositories identified
CodeRabbit considers these linked repositories for cross-repo context during reviews:
  • clerk/clerk_go(manual)
  • clerk/dashboard(manual)
  • clerk/accounts(manual)
  • clerk/backoffice(manual)
  • clerk/clerk(manual)
  • clerk/clerk-docs(manual)
  • clerk/cloudflare-workers(manual)
  • clerk/clerk-ios(auto-detected)
  • clerk/clerk-android(auto-detected)
  • clerk/cli(auto-detected)
📝 Walkthrough
Walkthrough
Express and Fastify middleware now return HTTP 400 when request URLs, targets, methods, or proxy conversions cannot produce Fetch requests. Express can reuse a prebuilt ClerkRequest during authentication. Tests cover invalid targets, hostless targets, credentialed URL-like inputs, TRACE, and proxy bypass behavior. A changeset records patch releases for both packages.
Estimated code review effort: 3 (Moderate) | ~25 minutes
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check nameStatusExplanation
Title check✅ PassedThe title concisely summarizes the main change: returning 400 for requests that cannot be converted into web requests.
Description check✅ PassedThe description accurately describes the Fastify and Express 400-handling changes and the optional clerkRequest tweak.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  •  Fix failing CI checks
Comment @coderabbitai help to get the list of available commands.
@wobsoriano
wobsoriano
merged commit fa761dc
into
mainJul 31, 2026

52 checks passed

@wobsoriano
wobsoriano
deleted the

rob/harden-request-conversion

branch
July 31, 2026 16:13
@clerk-cookieclerk-cookie
mentioned this pull request
Jul 31, 2026
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@alexcarpenteralexcarpenteralexcarpenter approved these changes

+1 more reviewer

@github-advanced-securitygithub-advanced-security[bot]github-advanced-security[bot] left review comments
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

expressfastify

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@wobsoriano@alexcarpenter@github-advanced-security

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
fix(fastify,express): Respond 400 instead of 500 to requests that cannot be web requests by wobsoriano · Pull Request #9290 · clerk/javascript · GitHub
Skip to content
fix(fastify,express): Respond 400 instead of 500 to requests that cannot be web requests - #9290
Merged
wobsoriano merged 3 commits into
mainfrom 
rob/harden-request-conversion
Jul 31, 2026
Merged
fix(fastify,express): Respond 400 instead of 500 to requests that cannot be web requests#9290
wobsoriano merged 3 commits into
mainfrom 
rob/harden-request-conversion
Conversation
@wobsoriano
@wobsorianowobsoriano
commented
Jul 30, 2026•

edited

Loading

Copy link


Copy Markdown

Member
Description
This PR makes clerkPlugin (fastify) and clerkMiddleware (express) respond 400 Bad Request instead of 500 to requests that cannot be converted into a fetch Request. Node's HTTP parser accepts vulnerability-scanner probes such as hostless GET // targets, targets that parse as credentialed URLs, and TRACE requests, but the middleware's unguarded new URL() / new Request() calls threw on them, surfacing 500s and error-log noise where a bare app answers 404.
400 is the status for a request the server cannot process due to a client error such as malformed syntax (RFC 9110 §15.5.1), and it matches what Node and Fastify already return for the same class of input caught at their own layer. The guard also covers the Frontend API proxy branches, and the exported authenticateRequest helper is unchanged apart from an optional prebuilt clerkRequest param that avoids converting twice.
Checklist
  • pnpm test runs as expected.
  • pnpm build runs as expected.
  •  (If applicable) JSDoc comments have been added or updated for any package exports
  •  (If applicable) Documentation has been updated
Type of change
  •  🐛 Bug fix
  •  🌟 New feature
  •  🔨 Breaking change
  •  📖 Refactoring / dependency upgrade / documentation
  •  other:
@changeset-bot
changeset-botBot
commented
Jul 30, 2026•

edited

Loading

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: 01d4695
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 2 packages
NameType
@clerk/fastifyPatch
@clerk/expressPatch
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@vercel
vercelBot
commented
Jul 30, 2026•

edited

Loading

Copy link


Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.
ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxReadyReadyPreviewJul 30, 2026 7:59pm
swingsetReadyReadyPreviewJul 30, 2026 7:59pm
Request Review
@wobsorianowobsoriano
changed the title
fix(fastify,express): Response 400 instead of 500 to requests that cannot be web requestsfix(fastify,express): Respond 400 instead of 500 to requests that cannot be web requestsJul 30, 2026
github-advanced-security[bot]
github-advanced-securityBot
found potential problems
Jul 30, 2026
View reviewed changes
Comment threadpackages/express/src/__tests__/clerkMiddleware.test.ts
Dismissed

@pkg-pr-new
pkg-pr-newBot
commented
Jul 30, 2026•

edited

Loading

Copy link


Copy Markdown

Open in StackBlitz
@clerk/astro
npm i https://pkg.pr.new/@clerk/astro@9290

@clerk/backend
npm i https://pkg.pr.new/@clerk/backend@9290

@clerk/chrome-extension
npm i https://pkg.pr.new/@clerk/chrome-extension@9290

@clerk/clerk-js
npm i https://pkg.pr.new/@clerk/clerk-js@9290

@clerk/electron
npm i https://pkg.pr.new/@clerk/electron@9290

@clerk/electron-passkeys
npm i https://pkg.pr.new/@clerk/electron-passkeys@9290

@clerk/eslint-plugin
npm i https://pkg.pr.new/@clerk/eslint-plugin@9290

@clerk/expo
npm i https://pkg.pr.new/@clerk/expo@9290

@clerk/expo-google-signin
npm i https://pkg.pr.new/@clerk/expo-google-signin@9290

@clerk/expo-passkeys
npm i https://pkg.pr.new/@clerk/expo-passkeys@9290

@clerk/express
npm i https://pkg.pr.new/@clerk/express@9290

@clerk/fastify
npm i https://pkg.pr.new/@clerk/fastify@9290

@clerk/hono
npm i https://pkg.pr.new/@clerk/hono@9290

@clerk/localizations
npm i https://pkg.pr.new/@clerk/localizations@9290

@clerk/nextjs
npm i https://pkg.pr.new/@clerk/nextjs@9290

@clerk/nuxt
npm i https://pkg.pr.new/@clerk/nuxt@9290

@clerk/react
npm i https://pkg.pr.new/@clerk/react@9290

@clerk/react-router
npm i https://pkg.pr.new/@clerk/react-router@9290

@clerk/shared
npm i https://pkg.pr.new/@clerk/shared@9290

@clerk/tanstack-react-start
npm i https://pkg.pr.new/@clerk/tanstack-react-start@9290

@clerk/testing
npm i https://pkg.pr.new/@clerk/testing@9290

@clerk/ui
npm i https://pkg.pr.new/@clerk/ui@9290

@clerk/upgrade
npm i https://pkg.pr.new/@clerk/upgrade@9290

@clerk/vue
npm i https://pkg.pr.new/@clerk/vue@9290

commit: 01d4695
@wobsoriano
wobsoriano
marked this pull request as ready for review
July 30, 2026 19:02
@github-actions
github-actionsBot
commented
Jul 30, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
API Changes Report
Generated by Break Check on 2026-07-30T20:02:36.851Z
Summary
MetricCount
Packages analyzed19
Packages with changes1
🔴 Breaking changes0
🟡 Non-breaking changes1
🟢 Additions0
🤖 This report was reviewed by claude-sonnet-4-6.
@clerk/express
Current version: 2.1.48
Recommended bump: MINOR → 2.2.0
Subpath ./types
🟡 Non-breaking Changes (1)
Modified: AuthenticateRequestParams
 type AuthenticateRequestParams = {
clerkClient: ClerkClient$1;
request: Request;
- options?: ClerkMiddlewareOptions;+ options?: ClerkMiddlewareOptions; /** Prebuilt ClerkRequest, so callers that already converted the request can skip re-conversion. */+ clerkRequest?: ClerkRequest;
};
Static analyzer: Breaking change in type alias AuthenticateRequestParams: Type changed: {clerkClient:import("@clerk/express").~ClerkClient$1;request:import("@types/express").e.Request;options?:import("@clerk… → {clerkClient:import("@clerk/express").~ClerkClient$1;request:import("@types/express").e.Request;options?:import("@clerk…
🤖 AI review (reclassified as non-breaking) (95%): The change only adds a new optional property clerkRequest? to AuthenticateRequestParams; existing consumers who construct this type need not provide it, and the type appears to be used as an input/parameter type where adding an optional field is non-breaking.
Report generated by Break Check
Last ran on 01d4695.
@coderabbitai
coderabbitaiBot
commented
Jul 30, 2026

Copy link


Copy Markdown

Contributor
Review Change Stack
No actionable comments were generated in the recent review. 🎉
ℹ️ Recent review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Organization UI (inherited)
Review profile: CHILL
Plan: Pro Plus
Run ID: 00097325-ae6a-4796-9d6e-42308d5b788d
📥 Commits
Reviewing files that changed from the base of the PR and between fe6ee54 and 2db65e3.
📒 Files selected for processing (7)
  • .changeset/harden-request-conversion.md
  • packages/express/src/__tests__/clerkMiddleware.test.ts
  • packages/express/src/authenticateRequest.ts
  • packages/express/src/types.ts
  • packages/fastify/src/__tests__/frontendApiProxy.test.ts
  • packages/fastify/src/__tests__/withClerkMiddleware.test.ts
  • packages/fastify/src/withClerkMiddleware.ts
🔗 Linked repositories identified
CodeRabbit considers these linked repositories for cross-repo context during reviews:
  • clerk/clerk_go(manual)
  • clerk/dashboard(manual)
  • clerk/accounts(manual)
  • clerk/backoffice(manual)
  • clerk/clerk(manual)
  • clerk/clerk-docs(manual)
  • clerk/cloudflare-workers(manual)
  • clerk/clerk-ios(auto-detected)
  • clerk/clerk-android(auto-detected)
  • clerk/cli(auto-detected)
📝 Walkthrough
Walkthrough
Express and Fastify middleware now return HTTP 400 when request URLs, targets, methods, or proxy conversions cannot produce Fetch requests. Express can reuse a prebuilt ClerkRequest during authentication. Tests cover invalid targets, hostless targets, credentialed URL-like inputs, TRACE, and proxy bypass behavior. A changeset records patch releases for both packages.
Estimated code review effort: 3 (Moderate) | ~25 minutes
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check nameStatusExplanation
Title check✅ PassedThe title concisely summarizes the main change: returning 400 for requests that cannot be converted into web requests.
Description check✅ PassedThe description accurately describes the Fastify and Express 400-handling changes and the optional clerkRequest tweak.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  •  Fix failing CI checks
Comment @coderabbitai help to get the list of available commands.
@wobsoriano
wobsoriano
merged commit fa761dc
into
mainJul 31, 2026

52 checks passed

@wobsoriano
wobsoriano
deleted the

rob/harden-request-conversion

branch
July 31, 2026 16:13
@clerk-cookieclerk-cookie
mentioned this pull request
Jul 31, 2026
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@alexcarpenteralexcarpenteralexcarpenter approved these changes

+1 more reviewer

@github-advanced-securitygithub-advanced-security[bot]github-advanced-security[bot] left review comments
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

expressfastify

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@wobsoriano@alexcarpenter@github-advanced-security

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '
fix(fastify,express): Respond 400 instead of 500 to requests that cannot be web requests by wobsoriano · Pull Request #9290 · clerk/javascript · GitHub
Skip to content
fix(fastify,express): Respond 400 instead of 500 to requests that cannot be web requests - #9290
Merged
wobsoriano merged 3 commits into
mainfrom 
rob/harden-request-conversion
Jul 31, 2026
Merged
fix(fastify,express): Respond 400 instead of 500 to requests that cannot be web requests#9290
wobsoriano merged 3 commits into
mainfrom 
rob/harden-request-conversion
Conversation
@wobsoriano
@wobsorianowobsoriano
commented
Jul 30, 2026•

edited

Loading

Copy link


Copy Markdown

Member
Description
This PR makes clerkPlugin (fastify) and clerkMiddleware (express) respond 400 Bad Request instead of 500 to requests that cannot be converted into a fetch Request. Node's HTTP parser accepts vulnerability-scanner probes such as hostless GET // targets, targets that parse as credentialed URLs, and TRACE requests, but the middleware's unguarded new URL() / new Request() calls threw on them, surfacing 500s and error-log noise where a bare app answers 404.
400 is the status for a request the server cannot process due to a client error such as malformed syntax (RFC 9110 §15.5.1), and it matches what Node and Fastify already return for the same class of input caught at their own layer. The guard also covers the Frontend API proxy branches, and the exported authenticateRequest helper is unchanged apart from an optional prebuilt clerkRequest param that avoids converting twice.
Checklist
  • pnpm test runs as expected.
  • pnpm build runs as expected.
  •  (If applicable) JSDoc comments have been added or updated for any package exports
  •  (If applicable) Documentation has been updated
Type of change
  •  🐛 Bug fix
  •  🌟 New feature
  •  🔨 Breaking change
  •  📖 Refactoring / dependency upgrade / documentation
  •  other:
@changeset-bot
changeset-botBot
commented
Jul 30, 2026•

edited

Loading

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: 01d4695
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 2 packages
NameType
@clerk/fastifyPatch
@clerk/expressPatch
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@vercel
vercelBot
commented
Jul 30, 2026•

edited

Loading

Copy link


Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.
ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxReadyReadyPreviewJul 30, 2026 7:59pm
swingsetReadyReadyPreviewJul 30, 2026 7:59pm
Request Review
@wobsorianowobsoriano
changed the title
fix(fastify,express): Response 400 instead of 500 to requests that cannot be web requestsfix(fastify,express): Respond 400 instead of 500 to requests that cannot be web requestsJul 30, 2026
github-advanced-security[bot]
github-advanced-securityBot
found potential problems
Jul 30, 2026
View reviewed changes
Comment threadpackages/express/src/__tests__/clerkMiddleware.test.ts
Dismissed

@pkg-pr-new
pkg-pr-newBot
commented
Jul 30, 2026•

edited

Loading

Copy link


Copy Markdown

Open in StackBlitz
@clerk/astro
npm i https://pkg.pr.new/@clerk/astro@9290

@clerk/backend
npm i https://pkg.pr.new/@clerk/backend@9290

@clerk/chrome-extension
npm i https://pkg.pr.new/@clerk/chrome-extension@9290

@clerk/clerk-js
npm i https://pkg.pr.new/@clerk/clerk-js@9290

@clerk/electron
npm i https://pkg.pr.new/@clerk/electron@9290

@clerk/electron-passkeys
npm i https://pkg.pr.new/@clerk/electron-passkeys@9290

@clerk/eslint-plugin
npm i https://pkg.pr.new/@clerk/eslint-plugin@9290

@clerk/expo
npm i https://pkg.pr.new/@clerk/expo@9290

@clerk/expo-google-signin
npm i https://pkg.pr.new/@clerk/expo-google-signin@9290

@clerk/expo-passkeys
npm i https://pkg.pr.new/@clerk/expo-passkeys@9290

@clerk/express
npm i https://pkg.pr.new/@clerk/express@9290

@clerk/fastify
npm i https://pkg.pr.new/@clerk/fastify@9290

@clerk/hono
npm i https://pkg.pr.new/@clerk/hono@9290

@clerk/localizations
npm i https://pkg.pr.new/@clerk/localizations@9290

@clerk/nextjs
npm i https://pkg.pr.new/@clerk/nextjs@9290

@clerk/nuxt
npm i https://pkg.pr.new/@clerk/nuxt@9290

@clerk/react
npm i https://pkg.pr.new/@clerk/react@9290

@clerk/react-router
npm i https://pkg.pr.new/@clerk/react-router@9290

@clerk/shared
npm i https://pkg.pr.new/@clerk/shared@9290

@clerk/tanstack-react-start
npm i https://pkg.pr.new/@clerk/tanstack-react-start@9290

@clerk/testing
npm i https://pkg.pr.new/@clerk/testing@9290

@clerk/ui
npm i https://pkg.pr.new/@clerk/ui@9290

@clerk/upgrade
npm i https://pkg.pr.new/@clerk/upgrade@9290

@clerk/vue
npm i https://pkg.pr.new/@clerk/vue@9290

commit: 01d4695
@wobsoriano
wobsoriano
marked this pull request as ready for review
July 30, 2026 19:02
@github-actions
github-actionsBot
commented
Jul 30, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
API Changes Report
Generated by Break Check on 2026-07-30T20:02:36.851Z
Summary
MetricCount
Packages analyzed19
Packages with changes1
🔴 Breaking changes0
🟡 Non-breaking changes1
🟢 Additions0
🤖 This report was reviewed by claude-sonnet-4-6.
@clerk/express
Current version: 2.1.48
Recommended bump: MINOR → 2.2.0
Subpath ./types
🟡 Non-breaking Changes (1)
Modified: AuthenticateRequestParams
 type AuthenticateRequestParams = {
clerkClient: ClerkClient$1;
request: Request;
- options?: ClerkMiddlewareOptions;+ options?: ClerkMiddlewareOptions; /** Prebuilt ClerkRequest, so callers that already converted the request can skip re-conversion. */+ clerkRequest?: ClerkRequest;
};
Static analyzer: Breaking change in type alias AuthenticateRequestParams: Type changed: {clerkClient:import("@clerk/express").~ClerkClient$1;request:import("@types/express").e.Request;options?:import("@clerk… → {clerkClient:import("@clerk/express").~ClerkClient$1;request:import("@types/express").e.Request;options?:import("@clerk…
🤖 AI review (reclassified as non-breaking) (95%): The change only adds a new optional property clerkRequest? to AuthenticateRequestParams; existing consumers who construct this type need not provide it, and the type appears to be used as an input/parameter type where adding an optional field is non-breaking.
Report generated by Break Check
Last ran on 01d4695.
@coderabbitai
coderabbitaiBot
commented
Jul 30, 2026

Copy link


Copy Markdown

Contributor
Review Change Stack
No actionable comments were generated in the recent review. 🎉
ℹ️ Recent review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Organization UI (inherited)
Review profile: CHILL
Plan: Pro Plus
Run ID: 00097325-ae6a-4796-9d6e-42308d5b788d
📥 Commits
Reviewing files that changed from the base of the PR and between fe6ee54 and 2db65e3.
📒 Files selected for processing (7)
  • .changeset/harden-request-conversion.md
  • packages/express/src/__tests__/clerkMiddleware.test.ts
  • packages/express/src/authenticateRequest.ts
  • packages/express/src/types.ts
  • packages/fastify/src/__tests__/frontendApiProxy.test.ts
  • packages/fastify/src/__tests__/withClerkMiddleware.test.ts
  • packages/fastify/src/withClerkMiddleware.ts
🔗 Linked repositories identified
CodeRabbit considers these linked repositories for cross-repo context during reviews:
  • clerk/clerk_go(manual)
  • clerk/dashboard(manual)
  • clerk/accounts(manual)
  • clerk/backoffice(manual)
  • clerk/clerk(manual)
  • clerk/clerk-docs(manual)
  • clerk/cloudflare-workers(manual)
  • clerk/clerk-ios(auto-detected)
  • clerk/clerk-android(auto-detected)
  • clerk/cli(auto-detected)
📝 Walkthrough
Walkthrough
Express and Fastify middleware now return HTTP 400 when request URLs, targets, methods, or proxy conversions cannot produce Fetch requests. Express can reuse a prebuilt ClerkRequest during authentication. Tests cover invalid targets, hostless targets, credentialed URL-like inputs, TRACE, and proxy bypass behavior. A changeset records patch releases for both packages.
Estimated code review effort: 3 (Moderate) | ~25 minutes
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check nameStatusExplanation
Title check✅ PassedThe title concisely summarizes the main change: returning 400 for requests that cannot be converted into web requests.
Description check✅ PassedThe description accurately describes the Fastify and Express 400-handling changes and the optional clerkRequest tweak.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  •  Fix failing CI checks
Comment @coderabbitai help to get the list of available commands.
@wobsoriano
wobsoriano
merged commit fa761dc
into
mainJul 31, 2026

52 checks passed

@wobsoriano
wobsoriano
deleted the

rob/harden-request-conversion

branch
July 31, 2026 16:13
@clerk-cookieclerk-cookie
mentioned this pull request
Jul 31, 2026
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@alexcarpenteralexcarpenteralexcarpenter approved these changes

+1 more reviewer

@github-advanced-securitygithub-advanced-security[bot]github-advanced-security[bot] left review comments
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

expressfastify

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@wobsoriano@alexcarpenter@github-advanced-security

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
fix(fastify,express): Respond 400 instead of 500 to requests that cannot be web requests by wobsoriano · Pull Request #9290 · clerk/javascript · GitHub
Skip to content
fix(fastify,express): Respond 400 instead of 500 to requests that cannot be web requests - #9290
Merged
wobsoriano merged 3 commits into
mainfrom 
rob/harden-request-conversion
Jul 31, 2026
Merged
fix(fastify,express): Respond 400 instead of 500 to requests that cannot be web requests#9290
wobsoriano merged 3 commits into
mainfrom 
rob/harden-request-conversion
Conversation
@wobsoriano
@wobsorianowobsoriano
commented
Jul 30, 2026•

edited

Loading

Copy link


Copy Markdown

Member
Description
This PR makes clerkPlugin (fastify) and clerkMiddleware (express) respond 400 Bad Request instead of 500 to requests that cannot be converted into a fetch Request. Node's HTTP parser accepts vulnerability-scanner probes such as hostless GET // targets, targets that parse as credentialed URLs, and TRACE requests, but the middleware's unguarded new URL() / new Request() calls threw on them, surfacing 500s and error-log noise where a bare app answers 404.
400 is the status for a request the server cannot process due to a client error such as malformed syntax (RFC 9110 §15.5.1), and it matches what Node and Fastify already return for the same class of input caught at their own layer. The guard also covers the Frontend API proxy branches, and the exported authenticateRequest helper is unchanged apart from an optional prebuilt clerkRequest param that avoids converting twice.
Checklist
  • pnpm test runs as expected.
  • pnpm build runs as expected.
  •  (If applicable) JSDoc comments have been added or updated for any package exports
  •  (If applicable) Documentation has been updated
Type of change
  •  🐛 Bug fix
  •  🌟 New feature
  •  🔨 Breaking change
  •  📖 Refactoring / dependency upgrade / documentation
  •  other:
@changeset-bot
changeset-botBot
commented
Jul 30, 2026•

edited

Loading

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: 01d4695
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 2 packages
NameType
@clerk/fastifyPatch
@clerk/expressPatch
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@vercel
vercelBot
commented
Jul 30, 2026•

edited

Loading

Copy link


Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.
ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxReadyReadyPreviewJul 30, 2026 7:59pm
swingsetReadyReadyPreviewJul 30, 2026 7:59pm
Request Review
@wobsorianowobsoriano
changed the title
fix(fastify,express): Response 400 instead of 500 to requests that cannot be web requestsfix(fastify,express): Respond 400 instead of 500 to requests that cannot be web requestsJul 30, 2026
github-advanced-security[bot]
github-advanced-securityBot
found potential problems
Jul 30, 2026
View reviewed changes
Comment threadpackages/express/src/__tests__/clerkMiddleware.test.ts
Dismissed

@pkg-pr-new
pkg-pr-newBot
commented
Jul 30, 2026•

edited

Loading

Copy link


Copy Markdown

Open in StackBlitz
@clerk/astro
npm i https://pkg.pr.new/@clerk/astro@9290

@clerk/backend
npm i https://pkg.pr.new/@clerk/backend@9290

@clerk/chrome-extension
npm i https://pkg.pr.new/@clerk/chrome-extension@9290

@clerk/clerk-js
npm i https://pkg.pr.new/@clerk/clerk-js@9290

@clerk/electron
npm i https://pkg.pr.new/@clerk/electron@9290

@clerk/electron-passkeys
npm i https://pkg.pr.new/@clerk/electron-passkeys@9290

@clerk/eslint-plugin
npm i https://pkg.pr.new/@clerk/eslint-plugin@9290

@clerk/expo
npm i https://pkg.pr.new/@clerk/expo@9290

@clerk/expo-google-signin
npm i https://pkg.pr.new/@clerk/expo-google-signin@9290

@clerk/expo-passkeys
npm i https://pkg.pr.new/@clerk/expo-passkeys@9290

@clerk/express
npm i https://pkg.pr.new/@clerk/express@9290

@clerk/fastify
npm i https://pkg.pr.new/@clerk/fastify@9290

@clerk/hono
npm i https://pkg.pr.new/@clerk/hono@9290

@clerk/localizations
npm i https://pkg.pr.new/@clerk/localizations@9290

@clerk/nextjs
npm i https://pkg.pr.new/@clerk/nextjs@9290

@clerk/nuxt
npm i https://pkg.pr.new/@clerk/nuxt@9290

@clerk/react
npm i https://pkg.pr.new/@clerk/react@9290

@clerk/react-router
npm i https://pkg.pr.new/@clerk/react-router@9290

@clerk/shared
npm i https://pkg.pr.new/@clerk/shared@9290

@clerk/tanstack-react-start
npm i https://pkg.pr.new/@clerk/tanstack-react-start@9290

@clerk/testing
npm i https://pkg.pr.new/@clerk/testing@9290

@clerk/ui
npm i https://pkg.pr.new/@clerk/ui@9290

@clerk/upgrade
npm i https://pkg.pr.new/@clerk/upgrade@9290

@clerk/vue
npm i https://pkg.pr.new/@clerk/vue@9290

commit: 01d4695
@wobsoriano
wobsoriano
marked this pull request as ready for review
July 30, 2026 19:02
@github-actions
github-actionsBot
commented
Jul 30, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
API Changes Report
Generated by Break Check on 2026-07-30T20:02:36.851Z
Summary
MetricCount
Packages analyzed19
Packages with changes1
🔴 Breaking changes0
🟡 Non-breaking changes1
🟢 Additions0
🤖 This report was reviewed by claude-sonnet-4-6.
@clerk/express
Current version: 2.1.48
Recommended bump: MINOR → 2.2.0
Subpath ./types
🟡 Non-breaking Changes (1)
Modified: AuthenticateRequestParams
 type AuthenticateRequestParams = {
clerkClient: ClerkClient$1;
request: Request;
- options?: ClerkMiddlewareOptions;+ options?: ClerkMiddlewareOptions; /** Prebuilt ClerkRequest, so callers that already converted the request can skip re-conversion. */+ clerkRequest?: ClerkRequest;
};
Static analyzer: Breaking change in type alias AuthenticateRequestParams: Type changed: {clerkClient:import("@clerk/express").~ClerkClient$1;request:import("@types/express").e.Request;options?:import("@clerk… → {clerkClient:import("@clerk/express").~ClerkClient$1;request:import("@types/express").e.Request;options?:import("@clerk…
🤖 AI review (reclassified as non-breaking) (95%): The change only adds a new optional property clerkRequest? to AuthenticateRequestParams; existing consumers who construct this type need not provide it, and the type appears to be used as an input/parameter type where adding an optional field is non-breaking.
Report generated by Break Check
Last ran on 01d4695.
@coderabbitai
coderabbitaiBot
commented
Jul 30, 2026

Copy link


Copy Markdown

Contributor
Review Change Stack
No actionable comments were generated in the recent review. 🎉
ℹ️ Recent review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Organization UI (inherited)
Review profile: CHILL
Plan: Pro Plus
Run ID: 00097325-ae6a-4796-9d6e-42308d5b788d
📥 Commits
Reviewing files that changed from the base of the PR and between fe6ee54 and 2db65e3.
📒 Files selected for processing (7)
  • .changeset/harden-request-conversion.md
  • packages/express/src/__tests__/clerkMiddleware.test.ts
  • packages/express/src/authenticateRequest.ts
  • packages/express/src/types.ts
  • packages/fastify/src/__tests__/frontendApiProxy.test.ts
  • packages/fastify/src/__tests__/withClerkMiddleware.test.ts
  • packages/fastify/src/withClerkMiddleware.ts
🔗 Linked repositories identified
CodeRabbit considers these linked repositories for cross-repo context during reviews:
  • clerk/clerk_go(manual)
  • clerk/dashboard(manual)
  • clerk/accounts(manual)
  • clerk/backoffice(manual)
  • clerk/clerk(manual)
  • clerk/clerk-docs(manual)
  • clerk/cloudflare-workers(manual)
  • clerk/clerk-ios(auto-detected)
  • clerk/clerk-android(auto-detected)
  • clerk/cli(auto-detected)
📝 Walkthrough
Walkthrough
Express and Fastify middleware now return HTTP 400 when request URLs, targets, methods, or proxy conversions cannot produce Fetch requests. Express can reuse a prebuilt ClerkRequest during authentication. Tests cover invalid targets, hostless targets, credentialed URL-like inputs, TRACE, and proxy bypass behavior. A changeset records patch releases for both packages.
Estimated code review effort: 3 (Moderate) | ~25 minutes
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check nameStatusExplanation
Title check✅ PassedThe title concisely summarizes the main change: returning 400 for requests that cannot be converted into web requests.
Description check✅ PassedThe description accurately describes the Fastify and Express 400-handling changes and the optional clerkRequest tweak.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  •  Fix failing CI checks
Comment @coderabbitai help to get the list of available commands.
@wobsoriano
wobsoriano
merged commit fa761dc
into
mainJul 31, 2026

52 checks passed

@wobsoriano
wobsoriano
deleted the

rob/harden-request-conversion

branch
July 31, 2026 16:13
@clerk-cookieclerk-cookie
mentioned this pull request
Jul 31, 2026
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@alexcarpenteralexcarpenteralexcarpenter approved these changes

+1 more reviewer

@github-advanced-securitygithub-advanced-security[bot]github-advanced-security[bot] left review comments
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

expressfastify

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@wobsoriano@alexcarpenter@github-advanced-security

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
fix(fastify,express): Respond 400 instead of 500 to requests that cannot be web requests by wobsoriano · Pull Request #9290 · clerk/javascript · GitHub
Skip to content
fix(fastify,express): Respond 400 instead of 500 to requests that cannot be web requests - #9290
Merged
wobsoriano merged 3 commits into
mainfrom 
rob/harden-request-conversion
Jul 31, 2026
Merged
fix(fastify,express): Respond 400 instead of 500 to requests that cannot be web requests#9290
wobsoriano merged 3 commits into
mainfrom 
rob/harden-request-conversion
Conversation
@wobsoriano
@wobsorianowobsoriano
commented
Jul 30, 2026•

edited

Loading

Copy link


Copy Markdown

Member
Description
This PR makes clerkPlugin (fastify) and clerkMiddleware (express) respond 400 Bad Request instead of 500 to requests that cannot be converted into a fetch Request. Node's HTTP parser accepts vulnerability-scanner probes such as hostless GET // targets, targets that parse as credentialed URLs, and TRACE requests, but the middleware's unguarded new URL() / new Request() calls threw on them, surfacing 500s and error-log noise where a bare app answers 404.
400 is the status for a request the server cannot process due to a client error such as malformed syntax (RFC 9110 §15.5.1), and it matches what Node and Fastify already return for the same class of input caught at their own layer. The guard also covers the Frontend API proxy branches, and the exported authenticateRequest helper is unchanged apart from an optional prebuilt clerkRequest param that avoids converting twice.
Checklist
  • pnpm test runs as expected.
  • pnpm build runs as expected.
  •  (If applicable) JSDoc comments have been added or updated for any package exports
  •  (If applicable) Documentation has been updated
Type of change
  •  🐛 Bug fix
  •  🌟 New feature
  •  🔨 Breaking change
  •  📖 Refactoring / dependency upgrade / documentation
  •  other:
@changeset-bot
changeset-botBot
commented
Jul 30, 2026•

edited

Loading

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: 01d4695
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 2 packages
NameType
@clerk/fastifyPatch
@clerk/expressPatch
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@vercel
vercelBot
commented
Jul 30, 2026•

edited

Loading

Copy link


Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.
ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxReadyReadyPreviewJul 30, 2026 7:59pm
swingsetReadyReadyPreviewJul 30, 2026 7:59pm
Request Review
@wobsorianowobsoriano
changed the title
fix(fastify,express): Response 400 instead of 500 to requests that cannot be web requestsfix(fastify,express): Respond 400 instead of 500 to requests that cannot be web requestsJul 30, 2026
github-advanced-security[bot]
github-advanced-securityBot
found potential problems
Jul 30, 2026
View reviewed changes
Comment threadpackages/express/src/__tests__/clerkMiddleware.test.ts
Dismissed

@pkg-pr-new
pkg-pr-newBot
commented
Jul 30, 2026•

edited

Loading

Copy link


Copy Markdown

Open in StackBlitz
@clerk/astro
npm i https://pkg.pr.new/@clerk/astro@9290

@clerk/backend
npm i https://pkg.pr.new/@clerk/backend@9290

@clerk/chrome-extension
npm i https://pkg.pr.new/@clerk/chrome-extension@9290

@clerk/clerk-js
npm i https://pkg.pr.new/@clerk/clerk-js@9290

@clerk/electron
npm i https://pkg.pr.new/@clerk/electron@9290

@clerk/electron-passkeys
npm i https://pkg.pr.new/@clerk/electron-passkeys@9290

@clerk/eslint-plugin
npm i https://pkg.pr.new/@clerk/eslint-plugin@9290

@clerk/expo
npm i https://pkg.pr.new/@clerk/expo@9290

@clerk/expo-google-signin
npm i https://pkg.pr.new/@clerk/expo-google-signin@9290

@clerk/expo-passkeys
npm i https://pkg.pr.new/@clerk/expo-passkeys@9290

@clerk/express
npm i https://pkg.pr.new/@clerk/express@9290

@clerk/fastify
npm i https://pkg.pr.new/@clerk/fastify@9290

@clerk/hono
npm i https://pkg.pr.new/@clerk/hono@9290

@clerk/localizations
npm i https://pkg.pr.new/@clerk/localizations@9290

@clerk/nextjs
npm i https://pkg.pr.new/@clerk/nextjs@9290

@clerk/nuxt
npm i https://pkg.pr.new/@clerk/nuxt@9290

@clerk/react
npm i https://pkg.pr.new/@clerk/react@9290

@clerk/react-router
npm i https://pkg.pr.new/@clerk/react-router@9290

@clerk/shared
npm i https://pkg.pr.new/@clerk/shared@9290

@clerk/tanstack-react-start
npm i https://pkg.pr.new/@clerk/tanstack-react-start@9290

@clerk/testing
npm i https://pkg.pr.new/@clerk/testing@9290

@clerk/ui
npm i https://pkg.pr.new/@clerk/ui@9290

@clerk/upgrade
npm i https://pkg.pr.new/@clerk/upgrade@9290

@clerk/vue
npm i https://pkg.pr.new/@clerk/vue@9290

commit: 01d4695
@wobsoriano
wobsoriano
marked this pull request as ready for review
July 30, 2026 19:02
@github-actions
github-actionsBot
commented
Jul 30, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
API Changes Report
Generated by Break Check on 2026-07-30T20:02:36.851Z
Summary
MetricCount
Packages analyzed19
Packages with changes1
🔴 Breaking changes0
🟡 Non-breaking changes1
🟢 Additions0
🤖 This report was reviewed by claude-sonnet-4-6.
@clerk/express
Current version: 2.1.48
Recommended bump: MINOR → 2.2.0
Subpath ./types
🟡 Non-breaking Changes (1)
Modified: AuthenticateRequestParams
 type AuthenticateRequestParams = {
clerkClient: ClerkClient$1;
request: Request;
- options?: ClerkMiddlewareOptions;+ options?: ClerkMiddlewareOptions; /** Prebuilt ClerkRequest, so callers that already converted the request can skip re-conversion. */+ clerkRequest?: ClerkRequest;
};
Static analyzer: Breaking change in type alias AuthenticateRequestParams: Type changed: {clerkClient:import("@clerk/express").~ClerkClient$1;request:import("@types/express").e.Request;options?:import("@clerk… → {clerkClient:import("@clerk/express").~ClerkClient$1;request:import("@types/express").e.Request;options?:import("@clerk…
🤖 AI review (reclassified as non-breaking) (95%): The change only adds a new optional property clerkRequest? to AuthenticateRequestParams; existing consumers who construct this type need not provide it, and the type appears to be used as an input/parameter type where adding an optional field is non-breaking.
Report generated by Break Check
Last ran on 01d4695.
@coderabbitai
coderabbitaiBot
commented
Jul 30, 2026

Copy link


Copy Markdown

Contributor
Review Change Stack
No actionable comments were generated in the recent review. 🎉
ℹ️ Recent review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Organization UI (inherited)
Review profile: CHILL
Plan: Pro Plus
Run ID: 00097325-ae6a-4796-9d6e-42308d5b788d
📥 Commits
Reviewing files that changed from the base of the PR and between fe6ee54 and 2db65e3.
📒 Files selected for processing (7)
  • .changeset/harden-request-conversion.md
  • packages/express/src/__tests__/clerkMiddleware.test.ts
  • packages/express/src/authenticateRequest.ts
  • packages/express/src/types.ts
  • packages/fastify/src/__tests__/frontendApiProxy.test.ts
  • packages/fastify/src/__tests__/withClerkMiddleware.test.ts
  • packages/fastify/src/withClerkMiddleware.ts
🔗 Linked repositories identified
CodeRabbit considers these linked repositories for cross-repo context during reviews:
  • clerk/clerk_go(manual)
  • clerk/dashboard(manual)
  • clerk/accounts(manual)
  • clerk/backoffice(manual)
  • clerk/clerk(manual)
  • clerk/clerk-docs(manual)
  • clerk/cloudflare-workers(manual)
  • clerk/clerk-ios(auto-detected)
  • clerk/clerk-android(auto-detected)
  • clerk/cli(auto-detected)
📝 Walkthrough
Walkthrough
Express and Fastify middleware now return HTTP 400 when request URLs, targets, methods, or proxy conversions cannot produce Fetch requests. Express can reuse a prebuilt ClerkRequest during authentication. Tests cover invalid targets, hostless targets, credentialed URL-like inputs, TRACE, and proxy bypass behavior. A changeset records patch releases for both packages.
Estimated code review effort: 3 (Moderate) | ~25 minutes
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check nameStatusExplanation
Title check✅ PassedThe title concisely summarizes the main change: returning 400 for requests that cannot be converted into web requests.
Description check✅ PassedThe description accurately describes the Fastify and Express 400-handling changes and the optional clerkRequest tweak.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  •  Fix failing CI checks
Comment @coderabbitai help to get the list of available commands.
@wobsoriano
wobsoriano
merged commit fa761dc
into
mainJul 31, 2026

52 checks passed

@wobsoriano
wobsoriano
deleted the

rob/harden-request-conversion

branch
July 31, 2026 16:13
@clerk-cookieclerk-cookie
mentioned this pull request
Jul 31, 2026
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@alexcarpenteralexcarpenteralexcarpenter approved these changes

+1 more reviewer

@github-advanced-securitygithub-advanced-security[bot]github-advanced-security[bot] left review comments
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

expressfastify

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@wobsoriano@alexcarpenter@github-advanced-security

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Universal Dark Mode - works on any site
(function() {
var enabled = true;
function applyDarkMode() {
if (!enabled) return;
// Create style element if it doesn't exist
var style = document.getElementById('universal-dark-mode-style');
if (!style) {
style = document.createElement('style');
style.id = 'universal-dark-mode-style';
document.head.appendChild(style);
}
// Dark mode CSS - inverts colors but preserves images/video
style.textContent = '
/* Invert everything except media */
html {
filter: invert(1) hue-rotate(180deg) !important;
background: #1a1a2e !important;
}
/* Restore images, videos, iframes, canvas */
img, video, iframe, canvas, svg, picture, [style*="background-image"] {
filter: invert(1) hue-rotate(180deg) !important;
}
/* Preserve specific elements that should not be inverted */
.no-dark-mode, .no-dark-mode *,
[data-theme="light"], [data-theme="light"],
.ace_editor, .ace_editor *,
.CodeMirror, .CodeMirror *,
.monaco-editor, .monaco-editor *,
.markdown-body pre, .markdown-body pre *,
.highlight, .highlight *,
pre code, pre code * {
filter: none !important;
}
/* Fix common UI elements */
.modal, .popup, .dropdown-menu, .tooltip, .popover {
filter: invert(1) hue-rotate(180deg) !important;
background: #2d2d44 !important;
border-color: #444 !important;
}
/* Scrollbars */
::-webkit-scrollbar { background: #1a1a2e !important; }
::-webkit-scrollbar-thumb { background: #444 !important; }
::-webkit-scrollbar-thumb:hover { background: #555 !important; }
/* Selection */
::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
';
}
function removeDarkMode() {
var style = document.getElementById('universal-dark-mode-style');
if (style) style.remove();
}
// Toggle with Alt+Shift+D
document.addEventListener('keydown', function(e) {
if (e.altKey && e.shiftKey && e.key === 'D') {
e.preventDefault();
enabled = !enabled;
if (enabled) {
applyDarkMode();
console.log('[Universal Dark Mode] Enabled');
} else {
removeDarkMode();
console.log('[Universal Dark Mode] Disabled');
}
}
});
// Apply on load
applyDarkMode();
// Re-apply on dynamic content
var observer = new MutationObserver(function(mutations) {
if (enabled && !document.getElementById('universal-dark-mode-style')) {
applyDarkMode();
}
});
observer.observe(document.head, { childList: true });
console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');
})();
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();
fix(fastify,express): Respond 400 instead of 500 to requests that cannot be web requests by wobsoriano · Pull Request #9290 · clerk/javascript · GitHub
Skip to content
fix(fastify,express): Respond 400 instead of 500 to requests that cannot be web requests - #9290
Merged
wobsoriano merged 3 commits into
mainfrom 
rob/harden-request-conversion
Jul 31, 2026
Merged
fix(fastify,express): Respond 400 instead of 500 to requests that cannot be web requests#9290
wobsoriano merged 3 commits into
mainfrom 
rob/harden-request-conversion
Conversation
@wobsoriano
@wobsorianowobsoriano
commented
Jul 30, 2026•

edited

Loading

Copy link


Copy Markdown

Member
Description
This PR makes clerkPlugin (fastify) and clerkMiddleware (express) respond 400 Bad Request instead of 500 to requests that cannot be converted into a fetch Request. Node's HTTP parser accepts vulnerability-scanner probes such as hostless GET // targets, targets that parse as credentialed URLs, and TRACE requests, but the middleware's unguarded new URL() / new Request() calls threw on them, surfacing 500s and error-log noise where a bare app answers 404.
400 is the status for a request the server cannot process due to a client error such as malformed syntax (RFC 9110 §15.5.1), and it matches what Node and Fastify already return for the same class of input caught at their own layer. The guard also covers the Frontend API proxy branches, and the exported authenticateRequest helper is unchanged apart from an optional prebuilt clerkRequest param that avoids converting twice.
Checklist
  • pnpm test runs as expected.
  • pnpm build runs as expected.
  •  (If applicable) JSDoc comments have been added or updated for any package exports
  •  (If applicable) Documentation has been updated
Type of change
  •  🐛 Bug fix
  •  🌟 New feature
  •  🔨 Breaking change
  •  📖 Refactoring / dependency upgrade / documentation
  •  other:
@changeset-bot
changeset-botBot
commented
Jul 30, 2026•

edited

Loading

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: 01d4695
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 2 packages
NameType
@clerk/fastifyPatch
@clerk/expressPatch
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@vercel
vercelBot
commented
Jul 30, 2026•

edited

Loading

Copy link


Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.
ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxReadyReadyPreviewJul 30, 2026 7:59pm
swingsetReadyReadyPreviewJul 30, 2026 7:59pm
Request Review
@wobsorianowobsoriano
changed the title
fix(fastify,express): Response 400 instead of 500 to requests that cannot be web requestsfix(fastify,express): Respond 400 instead of 500 to requests that cannot be web requestsJul 30, 2026
github-advanced-security[bot]
github-advanced-securityBot
found potential problems
Jul 30, 2026
View reviewed changes
Comment threadpackages/express/src/__tests__/clerkMiddleware.test.ts
Dismissed

@pkg-pr-new
pkg-pr-newBot
commented
Jul 30, 2026•

edited

Loading

Copy link


Copy Markdown

Open in StackBlitz
@clerk/astro
npm i https://pkg.pr.new/@clerk/astro@9290

@clerk/backend
npm i https://pkg.pr.new/@clerk/backend@9290

@clerk/chrome-extension
npm i https://pkg.pr.new/@clerk/chrome-extension@9290

@clerk/clerk-js
npm i https://pkg.pr.new/@clerk/clerk-js@9290

@clerk/electron
npm i https://pkg.pr.new/@clerk/electron@9290

@clerk/electron-passkeys
npm i https://pkg.pr.new/@clerk/electron-passkeys@9290

@clerk/eslint-plugin
npm i https://pkg.pr.new/@clerk/eslint-plugin@9290

@clerk/expo
npm i https://pkg.pr.new/@clerk/expo@9290

@clerk/expo-google-signin
npm i https://pkg.pr.new/@clerk/expo-google-signin@9290

@clerk/expo-passkeys
npm i https://pkg.pr.new/@clerk/expo-passkeys@9290

@clerk/express
npm i https://pkg.pr.new/@clerk/express@9290

@clerk/fastify
npm i https://pkg.pr.new/@clerk/fastify@9290

@clerk/hono
npm i https://pkg.pr.new/@clerk/hono@9290

@clerk/localizations
npm i https://pkg.pr.new/@clerk/localizations@9290

@clerk/nextjs
npm i https://pkg.pr.new/@clerk/nextjs@9290

@clerk/nuxt
npm i https://pkg.pr.new/@clerk/nuxt@9290

@clerk/react
npm i https://pkg.pr.new/@clerk/react@9290

@clerk/react-router
npm i https://pkg.pr.new/@clerk/react-router@9290

@clerk/shared
npm i https://pkg.pr.new/@clerk/shared@9290

@clerk/tanstack-react-start
npm i https://pkg.pr.new/@clerk/tanstack-react-start@9290

@clerk/testing
npm i https://pkg.pr.new/@clerk/testing@9290

@clerk/ui
npm i https://pkg.pr.new/@clerk/ui@9290

@clerk/upgrade
npm i https://pkg.pr.new/@clerk/upgrade@9290

@clerk/vue
npm i https://pkg.pr.new/@clerk/vue@9290

commit: 01d4695
@wobsoriano
wobsoriano
marked this pull request as ready for review
July 30, 2026 19:02
@github-actions
github-actionsBot
commented
Jul 30, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
API Changes Report
Generated by Break Check on 2026-07-30T20:02:36.851Z
Summary
MetricCount
Packages analyzed19
Packages with changes1
🔴 Breaking changes0
🟡 Non-breaking changes1
🟢 Additions0
🤖 This report was reviewed by claude-sonnet-4-6.
@clerk/express
Current version: 2.1.48
Recommended bump: MINOR → 2.2.0
Subpath ./types
🟡 Non-breaking Changes (1)
Modified: AuthenticateRequestParams
 type AuthenticateRequestParams = {
clerkClient: ClerkClient$1;
request: Request;
- options?: ClerkMiddlewareOptions;+ options?: ClerkMiddlewareOptions; /** Prebuilt ClerkRequest, so callers that already converted the request can skip re-conversion. */+ clerkRequest?: ClerkRequest;
};
Static analyzer: Breaking change in type alias AuthenticateRequestParams: Type changed: {clerkClient:import("@clerk/express").~ClerkClient$1;request:import("@types/express").e.Request;options?:import("@clerk… → {clerkClient:import("@clerk/express").~ClerkClient$1;request:import("@types/express").e.Request;options?:import("@clerk…
🤖 AI review (reclassified as non-breaking) (95%): The change only adds a new optional property clerkRequest? to AuthenticateRequestParams; existing consumers who construct this type need not provide it, and the type appears to be used as an input/parameter type where adding an optional field is non-breaking.
Report generated by Break Check
Last ran on 01d4695.
@coderabbitai
coderabbitaiBot
commented
Jul 30, 2026

Copy link


Copy Markdown

Contributor
Review Change Stack
No actionable comments were generated in the recent review. 🎉
ℹ️ Recent review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Organization UI (inherited)
Review profile: CHILL
Plan: Pro Plus
Run ID: 00097325-ae6a-4796-9d6e-42308d5b788d
📥 Commits
Reviewing files that changed from the base of the PR and between fe6ee54 and 2db65e3.
📒 Files selected for processing (7)
  • .changeset/harden-request-conversion.md
  • packages/express/src/__tests__/clerkMiddleware.test.ts
  • packages/express/src/authenticateRequest.ts
  • packages/express/src/types.ts
  • packages/fastify/src/__tests__/frontendApiProxy.test.ts
  • packages/fastify/src/__tests__/withClerkMiddleware.test.ts
  • packages/fastify/src/withClerkMiddleware.ts
🔗 Linked repositories identified
CodeRabbit considers these linked repositories for cross-repo context during reviews:
  • clerk/clerk_go(manual)
  • clerk/dashboard(manual)
  • clerk/accounts(manual)
  • clerk/backoffice(manual)
  • clerk/clerk(manual)
  • clerk/clerk-docs(manual)
  • clerk/cloudflare-workers(manual)
  • clerk/clerk-ios(auto-detected)
  • clerk/clerk-android(auto-detected)
  • clerk/cli(auto-detected)
📝 Walkthrough
Walkthrough
Express and Fastify middleware now return HTTP 400 when request URLs, targets, methods, or proxy conversions cannot produce Fetch requests. Express can reuse a prebuilt ClerkRequest during authentication. Tests cover invalid targets, hostless targets, credentialed URL-like inputs, TRACE, and proxy bypass behavior. A changeset records patch releases for both packages.
Estimated code review effort: 3 (Moderate) | ~25 minutes
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check nameStatusExplanation
Title check✅ PassedThe title concisely summarizes the main change: returning 400 for requests that cannot be converted into web requests.
Description check✅ PassedThe description accurately describes the Fastify and Express 400-handling changes and the optional clerkRequest tweak.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  •  Fix failing CI checks
Comment @coderabbitai help to get the list of available commands.
@wobsoriano
wobsoriano
merged commit fa761dc
into
mainJul 31, 2026

52 checks passed

@wobsoriano
wobsoriano
deleted the

rob/harden-request-conversion

branch
July 31, 2026 16:13
@clerk-cookieclerk-cookie
mentioned this pull request
Jul 31, 2026
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@alexcarpenteralexcarpenteralexcarpenter approved these changes

+1 more reviewer

@github-advanced-securitygithub-advanced-security[bot]github-advanced-security[bot] left review comments
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

expressfastify

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@wobsoriano@alexcarpenter@github-advanced-security