Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .changeset/headless-return-focus.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
---
---
98 changes: 98 additions & 0 deletions packages/headless/src/hooks/use-return-focus.test.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,98 @@
import type { FloatingEvents } from '@floating-ui/react';
import { renderHook } from '@testing-library/react';
import { afterEach, beforeEach, describe, expect, it } from 'vitest';

import { useReturnFocus } from './use-return-focus';

function createEvents(): FloatingEvents & { close: (event?: Event) => void } {
const handlers = new Map<string, Array<(data: unknown) => void>>();

return {
emit(event, data) {
handlers.get(event)?.forEach(handler => handler(data));
},
on(event, handler) {
handlers.set(event, [...(handlers.get(event) ?? []), handler]);
},
off(event, handler) {
handlers.set(
event,
(handlers.get(event) ?? []).filter(h => h !== handler),
);
},
close(event) {
this.emit('openchange', { open: false, event });
},
};
}

function renderReturnFocus(trigger: HTMLElement) {
const events = createEvents();

const { result, rerender } = renderHook(
({ open }: { open: boolean }) =>
useReturnFocus({ open, events, elements: { domReference: trigger, reference: trigger, floating: null } }),
{ initialProps: { open: false } },
);

return { events, result, open: (open: boolean) => rerender({ open }) };
}

let trigger: HTMLElement;

afterEach(() => trigger?.remove());

describe('useReturnFocus', () => {
beforeEach(() => {
trigger = document.createElement('button');
document.body.append(trigger);
});

it('resolves to the trigger while open', () => {
const { result, open } = renderReturnFocus(trigger);

open(true);

expect(result.current.current).toBe(trigger);
});

it('keeps the trigger when the close came from the keyboard', () => {
const { events, result, open } = renderReturnFocus(trigger);
open(true);

events.close(new KeyboardEvent('keydown', { key: 'Escape' }));

expect(result.current.current).toBe(trigger);
});

it('keeps the trigger when the close came from a control inside the popup', () => {
const { events, result, open } = renderReturnFocus(trigger);
open(true);

// A Close button or menu item routes through the consumer's own state setter,
// so floating-ui reports the change with no event behind it.
events.close();

expect(result.current.current).toBe(trigger);
});

it('leaves focus alone when the close came from a pointer', () => {
const { events, result, open } = renderReturnFocus(trigger);
open(true);

events.close(new MouseEvent('mousedown', { detail: 1 }));

expect(result.current.current).toBeNull();
});

it('restores the trigger on the next open', () => {
const { events, result, open } = renderReturnFocus(trigger);
open(true);
events.close(new MouseEvent('mousedown', { detail: 1 }));

open(false);
open(true);

expect(result.current.current).toBe(trigger);
});
});
49 changes: 49 additions & 0 deletions packages/headless/src/hooks/use-return-focus.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,49 @@
'use client';

import type { FloatingContext } from '@floating-ui/react';
import { useEffect, useRef } from 'react';

import { isKeyboardEvent } from '../utils/interaction-modality';

/**
* The element `FloatingFocusManager` restores focus to when the floating element closes.
*
* The trigger is the default, which is what a keyboard user needs. Safari never focuses a
* button it was clicked on, so after a pointer dismiss the popup is the only thing the page
* has focused: restoring focus to the trigger then matches `:focus-visible` and paints a ring
* the user never asked for. A pointer dismiss therefore resolves to `null`, which leaves focus
* where the pointer left it, the same choice Base UI makes from its close interaction type.
*
* Pass the result to `FloatingFocusManager`'s `returnFocus`. On `null` it falls back to the
* hidden guard element it keeps next to the trigger, so the tab position survives; verify that
* still holds when upgrading `@floating-ui/react`.
*/
export function useReturnFocus(
context: Pick<FloatingContext, 'open' | 'events' | 'elements'>,
): React.MutableRefObject<HTMLElement | null> {
const { open, events, elements } = context;
const returnFocusRef = useRef<HTMLElement | null>(null);
const trigger = elements.domReference;

useEffect(() => {
if (open) {
returnFocusRef.current = trigger instanceof HTMLElement ? trigger : null;
}
}, [open, trigger]);

useEffect(() => {
// Closes routed straight through the consumer's own state setter (a Close button, an
// item click) never reach floating-ui, so only what floating-ui itself drives can
// downgrade the default.
function onOpenChange({ open, event }: { open: boolean; event?: Event }) {
if (!open && event && !isKeyboardEvent(event)) {
returnFocusRef.current = null;
}
}

events.on('openchange', onOpenChange);
return () => events.off('openchange', onOpenChange);
}, [events]);

return returnFocusRef;
}
Original file line numberDiff line numberDiff line change
Expand Up@@ -643,6 +643,7 @@ describe('Autocomplete', () => {

return (
<Popover.Root
initialFocus='first'
open={popoverOpen}
onOpenChange={open => {
setPopoverOpen(open);
Expand DownExpand Up@@ -786,6 +787,7 @@ describe('Autocomplete', () => {

return (
<Popover.Root
initialFocus='first'
open={popoverOpen}
onOpenChange={open => {
setPopoverOpen(open);
Expand DownExpand Up@@ -880,6 +882,7 @@ describe('Autocomplete', () => {

return (
<Popover.Root
initialFocus='first'
open={popoverOpen}
onOpenChange={open => {
setPopoverOpen(open);
Expand Down
2 changes: 2 additions & 0 deletions packages/headless/src/primitives/dialog/dialog-context.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -11,6 +11,8 @@ export interface DialogContextValue {
getReferenceProps: UseInteractionsReturn['getReferenceProps'];
getFloatingProps: UseInteractionsReturn['getFloatingProps'];
popupRef: React.RefObject<HTMLDivElement | null>;
/** Where focus goes when the dialog closes, or `null` to leave focus alone. */
returnFocusRef: React.MutableRefObject<HTMLElement | null>;
modal: boolean;
labelId: string;
descriptionId: string;
Expand Down
15 changes: 13 additions & 2 deletions packages/headless/src/primitives/dialog/dialog-popup.tsx
Original file line numberDiff line numberDiff line change
Expand Up@@ -12,8 +12,18 @@ export type DialogPopupProps = ComponentProps<'div'>;
/** The dialog content container. Manages focus trapping via `FloatingFocusManager` and wires ARIA attributes from `Dialog.Title` and `Dialog.Description`. */
export const DialogPopup = React.forwardRef<HTMLDivElement, DialogPopupProps>(function DialogPopup(props, ref) {
const { render, ...otherProps } = props;
const { popupRef, refs, getFloatingProps, floatingContext, modal, labelId, descriptionId, mounted, transitionProps } =
useDialogContext();
const {
popupRef,
refs,
getFloatingProps,
floatingContext,
modal,
returnFocusRef,
labelId,
descriptionId,
mounted,
transitionProps,
} = useDialogContext();

const ownProps = {
'aria-labelledby': labelId,
Expand DownExpand Up@@ -43,6 +53,7 @@ export const DialogPopup = React.forwardRef<HTMLDivElement, DialogPopupProps>(fu
context={floatingContext}
modal={modal}
outsideElementsInert={modal}
returnFocus={returnFocusRef}
>
{element}
</FloatingFocusManager>
Expand Down
5 changes: 5 additions & 0 deletions packages/headless/src/primitives/dialog/dialog-root.tsx
Original file line numberDiff line numberDiff line change
Expand Up@@ -14,6 +14,7 @@ import {
import { type ReactNode, useId, useMemo, useRef } from 'react';

import { useControllableState } from '../../hooks/use-controllable-state';
import { useReturnFocus } from '../../hooks/use-return-focus';
import { useTransition } from '../../hooks/use-transition';
import { DialogContext, type DialogContextValue } from './dialog-context';

Expand DownExpand Up@@ -43,6 +44,8 @@ function DialogInner(props: DialogProps) {
onOpenChange: setOpen,
});

const returnFocusRef = useReturnFocus(floatingContext);

const { mounted, transitionProps } = useTransition({
open,
ref: popupRef,
Expand All@@ -65,6 +68,7 @@ function DialogInner(props: DialogProps) {
getReferenceProps,
getFloatingProps,
popupRef,
returnFocusRef,
modal,
labelId,
descriptionId,
Expand All@@ -78,6 +82,7 @@ function DialogInner(props: DialogProps) {
refs,
getReferenceProps,
getFloatingProps,
returnFocusRef,
modal,
labelId,
descriptionId,
Expand Down
2 changes: 2 additions & 0 deletions packages/headless/src/primitives/drawer/drawer-popup.tsx
Original file line numberDiff line numberDiff line change
Expand Up@@ -24,6 +24,7 @@ export const DrawerPopup = React.forwardRef<HTMLDivElement, DrawerPopupProps>(fu
getFloatingProps,
floatingContext,
modal,
returnFocusRef,
labelId,
descriptionId,
mounted,
Expand DownExpand Up@@ -107,6 +108,7 @@ export const DrawerPopup = React.forwardRef<HTMLDivElement, DrawerPopupProps>(fu
modal={modal}
outsideElementsInert={modal}
initialFocus={autoFocus ? undefined : popupRef}
returnFocus={returnFocusRef}
>
{element}
</FloatingFocusManager>
Expand Down
5 changes: 5 additions & 0 deletions packages/headless/src/primitives/drawer/drawer-root.tsx
Original file line numberDiff line numberDiff line change
Expand Up@@ -14,6 +14,7 @@ import {
import { type ReactNode, useCallback, useEffect, useId, useMemo, useRef, useState } from 'react';

import { useControllableState } from '../../hooks/use-controllable-state';
import { useReturnFocus } from '../../hooks/use-return-focus';
import { useTransition } from '../../hooks/use-transition';
import { DrawerAttrs, DrawerCssVars, registerDrawerCssVars } from './css-vars';
import {
Expand DownExpand Up@@ -119,6 +120,8 @@ function DrawerInner(props: DrawerProps) {
onOpenChange: setOpen,
});

const returnFocusRef = useReturnFocus(floatingContext);

const { mounted, transitionProps } = useTransition({ open, ref: popupRef });

const click = useClick(floatingContext);
Expand DownExpand Up@@ -223,6 +226,7 @@ function DrawerInner(props: DrawerProps) {
getFloatingProps,
popupRef,
backdropRef,
returnFocusRef,
modal,
labelId,
descriptionId,
Expand All@@ -247,6 +251,7 @@ function DrawerInner(props: DrawerProps) {
refs,
getReferenceProps,
getFloatingProps,
returnFocusRef,
modal,
labelId,
descriptionId,
Expand Down
2 changes: 2 additions & 0 deletions packages/headless/src/primitives/menu/menu-context.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -24,6 +24,8 @@ export interface MenuContextValue {
labelsRef: React.MutableRefObject<Array<string | null>>;
arrowRef: React.MutableRefObject<SVGSVGElement | null>;
popupRef: React.RefObject<HTMLDivElement | null>;
/** Where focus goes when the menu closes, or `null` to leave focus alone. */
returnFocusRef: React.MutableRefObject<HTMLElement | null>;
isNested: boolean;
mounted: boolean;
transitionProps: TransitionProps;
Expand Down
7 changes: 4 additions & 3 deletions packages/headless/src/primitives/menu/menu-positioner.tsx
Original file line numberDiff line numberDiff line change
Expand Up@@ -3,7 +3,7 @@
import { FloatingFocusManager, FloatingList } from '@floating-ui/react';
import React from 'react';

import { type ComponentProps, type DefaultProps, mergeProps, useRender } from '../../utils';
import { type ComponentProps, type DefaultProps, isKeyboardOpen, mergeProps, useRender } from '../../utils';
import { useMenuContext } from './menu-context';

export type MenuPositionerProps = ComponentProps<'div'>;
Expand All@@ -21,6 +21,7 @@ export const MenuPositioner = React.forwardRef<HTMLDivElement, MenuPositionerPro
elementsRef,
labelsRef,
isNested,
returnFocusRef,
setActiveIndex,
} = useMenuContext();

Expand DownExpand Up@@ -83,8 +84,8 @@ export const MenuPositioner = React.forwardRef<HTMLDivElement, MenuPositionerPro
<FloatingFocusManager
context={floatingContext}
modal={false}
initialFocus={isNested ? -1 : 0}
returnFocus={!isNested}
initialFocus={isNested ? -1 : isKeyboardOpen(floatingContext) ? 0 : refs.floating}
returnFocus={isNested ? false : returnFocusRef}
>
<FloatingList
elementsRef={elementsRef}
Expand Down
5 changes: 5 additions & 0 deletions packages/headless/src/primitives/menu/menu-root.tsx
Original file line numberDiff line numberDiff line change
Expand Up@@ -25,6 +25,7 @@ import {
import { type ReactNode, useContext, useEffect, useMemo, useRef, useState } from 'react';

import { useControllableState } from '../../hooks/use-controllable-state';
import { useReturnFocus } from '../../hooks/use-return-focus';
import { useTransition } from '../../hooks/use-transition';
import { cssVars } from '../../utils/css-vars';
import { MenuContext, type MenuContextValue } from './menu-context';
Expand DownExpand Up@@ -85,6 +86,8 @@ function MenuInner(props: MenuProps) {
whileElementsMounted: autoUpdate,
});

const returnFocusRef = useReturnFocus(floatingContext);

const { mounted, transitionProps } = useTransition({
open,
ref: popupRef,
Expand DownExpand Up@@ -179,6 +182,7 @@ function MenuInner(props: MenuProps) {
labelsRef,
arrowRef,
popupRef,
returnFocusRef,
isNested,
mounted,
transitionProps,
Expand All@@ -194,6 +198,7 @@ function MenuInner(props: MenuProps) {
getFloatingProps,
getItemProps,
activeIndex,
returnFocusRef,
isNested,
mounted,
transitionProps,
Expand Down
Loading
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .changeset/headless-return-focus.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
---
---
98 changes: 98 additions & 0 deletions packages/headless/src/hooks/use-return-focus.test.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,98 @@
import type { FloatingEvents } from '@floating-ui/react';
import { renderHook } from '@testing-library/react';
import { afterEach, beforeEach, describe, expect, it } from 'vitest';

import { useReturnFocus } from './use-return-focus';

function createEvents(): FloatingEvents & { close: (event?: Event) => void } {
const handlers = new Map<string, Array<(data: unknown) => void>>();

return {
emit(event, data) {
handlers.get(event)?.forEach(handler => handler(data));
},
on(event, handler) {
handlers.set(event, [...(handlers.get(event) ?? []), handler]);
},
off(event, handler) {
handlers.set(
event,
(handlers.get(event) ?? []).filter(h => h !== handler),
);
},
close(event) {
this.emit('openchange', { open: false, event });
},
};
}

function renderReturnFocus(trigger: HTMLElement) {
const events = createEvents();

const { result, rerender } = renderHook(
({ open }: { open: boolean }) =>
useReturnFocus({ open, events, elements: { domReference: trigger, reference: trigger, floating: null } }),
{ initialProps: { open: false } },
);

return { events, result, open: (open: boolean) => rerender({ open }) };
}

let trigger: HTMLElement;

afterEach(() => trigger?.remove());

describe('useReturnFocus', () => {
beforeEach(() => {
trigger = document.createElement('button');
document.body.append(trigger);
});

it('resolves to the trigger while open', () => {
const { result, open } = renderReturnFocus(trigger);

open(true);

expect(result.current.current).toBe(trigger);
});

it('keeps the trigger when the close came from the keyboard', () => {
const { events, result, open } = renderReturnFocus(trigger);
open(true);

events.close(new KeyboardEvent('keydown', { key: 'Escape' }));

expect(result.current.current).toBe(trigger);
});

it('keeps the trigger when the close came from a control inside the popup', () => {
const { events, result, open } = renderReturnFocus(trigger);
open(true);

// A Close button or menu item routes through the consumer's own state setter,
// so floating-ui reports the change with no event behind it.
events.close();

expect(result.current.current).toBe(trigger);
});

it('leaves focus alone when the close came from a pointer', () => {
const { events, result, open } = renderReturnFocus(trigger);
open(true);

events.close(new MouseEvent('mousedown', { detail: 1 }));

expect(result.current.current).toBeNull();
});

it('restores the trigger on the next open', () => {
const { events, result, open } = renderReturnFocus(trigger);
open(true);
events.close(new MouseEvent('mousedown', { detail: 1 }));

open(false);
open(true);

expect(result.current.current).toBe(trigger);
});
});
49 changes: 49 additions & 0 deletions packages/headless/src/hooks/use-return-focus.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,49 @@
'use client';

import type { FloatingContext } from '@floating-ui/react';
import { useEffect, useRef } from 'react';

import { isKeyboardEvent } from '../utils/interaction-modality';

/**
* The element `FloatingFocusManager` restores focus to when the floating element closes.
*
* The trigger is the default, which is what a keyboard user needs. Safari never focuses a
* button it was clicked on, so after a pointer dismiss the popup is the only thing the page
* has focused: restoring focus to the trigger then matches `:focus-visible` and paints a ring
* the user never asked for. A pointer dismiss therefore resolves to `null`, which leaves focus
* where the pointer left it, the same choice Base UI makes from its close interaction type.
*
* Pass the result to `FloatingFocusManager`'s `returnFocus`. On `null` it falls back to the
* hidden guard element it keeps next to the trigger, so the tab position survives; verify that
* still holds when upgrading `@floating-ui/react`.
*/
export function useReturnFocus(
context: Pick<FloatingContext, 'open' | 'events' | 'elements'>,
): React.MutableRefObject<HTMLElement | null> {
const { open, events, elements } = context;
const returnFocusRef = useRef<HTMLElement | null>(null);
const trigger = elements.domReference;

useEffect(() => {
if (open) {
returnFocusRef.current = trigger instanceof HTMLElement ? trigger : null;
}
}, [open, trigger]);

useEffect(() => {
// Closes routed straight through the consumer's own state setter (a Close button, an
// item click) never reach floating-ui, so only what floating-ui itself drives can
// downgrade the default.
function onOpenChange({ open, event }: { open: boolean; event?: Event }) {
if (!open && event && !isKeyboardEvent(event)) {
returnFocusRef.current = null;
}
}

events.on('openchange', onOpenChange);
return () => events.off('openchange', onOpenChange);
}, [events]);

return returnFocusRef;
}
Original file line numberDiff line numberDiff line change
Expand Up@@ -643,6 +643,7 @@ describe('Autocomplete', () => {

return (
<Popover.Root
initialFocus='first'
open={popoverOpen}
onOpenChange={open => {
setPopoverOpen(open);
Expand DownExpand Up@@ -786,6 +787,7 @@ describe('Autocomplete', () => {

return (
<Popover.Root
initialFocus='first'
open={popoverOpen}
onOpenChange={open => {
setPopoverOpen(open);
Expand DownExpand Up@@ -880,6 +882,7 @@ describe('Autocomplete', () => {

return (
<Popover.Root
initialFocus='first'
open={popoverOpen}
onOpenChange={open => {
setPopoverOpen(open);
Expand Down
2 changes: 2 additions & 0 deletions packages/headless/src/primitives/dialog/dialog-context.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -11,6 +11,8 @@ export interface DialogContextValue {
getReferenceProps: UseInteractionsReturn['getReferenceProps'];
getFloatingProps: UseInteractionsReturn['getFloatingProps'];
popupRef: React.RefObject<HTMLDivElement | null>;
/** Where focus goes when the dialog closes, or `null` to leave focus alone. */
returnFocusRef: React.MutableRefObject<HTMLElement | null>;
modal: boolean;
labelId: string;
descriptionId: string;
Expand Down
15 changes: 13 additions & 2 deletions packages/headless/src/primitives/dialog/dialog-popup.tsx
Original file line numberDiff line numberDiff line change
Expand Up@@ -12,8 +12,18 @@ export type DialogPopupProps = ComponentProps<'div'>;
/** The dialog content container. Manages focus trapping via `FloatingFocusManager` and wires ARIA attributes from `Dialog.Title` and `Dialog.Description`. */
export const DialogPopup = React.forwardRef<HTMLDivElement, DialogPopupProps>(function DialogPopup(props, ref) {
const { render, ...otherProps } = props;
const { popupRef, refs, getFloatingProps, floatingContext, modal, labelId, descriptionId, mounted, transitionProps } =
useDialogContext();
const {
popupRef,
refs,
getFloatingProps,
floatingContext,
modal,
returnFocusRef,
labelId,
descriptionId,
mounted,
transitionProps,
} = useDialogContext();

const ownProps = {
'aria-labelledby': labelId,
Expand DownExpand Up@@ -43,6 +53,7 @@ export const DialogPopup = React.forwardRef<HTMLDivElement, DialogPopupProps>(fu
context={floatingContext}
modal={modal}
outsideElementsInert={modal}
returnFocus={returnFocusRef}
>
{element}
</FloatingFocusManager>
Expand Down
5 changes: 5 additions & 0 deletions packages/headless/src/primitives/dialog/dialog-root.tsx
Original file line numberDiff line numberDiff line change
Expand Up@@ -14,6 +14,7 @@ import {
import { type ReactNode, useId, useMemo, useRef } from 'react';

import { useControllableState } from '../../hooks/use-controllable-state';
import { useReturnFocus } from '../../hooks/use-return-focus';
import { useTransition } from '../../hooks/use-transition';
import { DialogContext, type DialogContextValue } from './dialog-context';

Expand DownExpand Up@@ -43,6 +44,8 @@ function DialogInner(props: DialogProps) {
onOpenChange: setOpen,
});

const returnFocusRef = useReturnFocus(floatingContext);

const { mounted, transitionProps } = useTransition({
open,
ref: popupRef,
Expand All@@ -65,6 +68,7 @@ function DialogInner(props: DialogProps) {
getReferenceProps,
getFloatingProps,
popupRef,
returnFocusRef,
modal,
labelId,
descriptionId,
Expand All@@ -78,6 +82,7 @@ function DialogInner(props: DialogProps) {
refs,
getReferenceProps,
getFloatingProps,
returnFocusRef,
modal,
labelId,
descriptionId,
Expand Down
2 changes: 2 additions & 0 deletions packages/headless/src/primitives/drawer/drawer-popup.tsx
Original file line numberDiff line numberDiff line change
Expand Up@@ -24,6 +24,7 @@ export const DrawerPopup = React.forwardRef<HTMLDivElement, DrawerPopupProps>(fu
getFloatingProps,
floatingContext,
modal,
returnFocusRef,
labelId,
descriptionId,
mounted,
Expand DownExpand Up@@ -107,6 +108,7 @@ export const DrawerPopup = React.forwardRef<HTMLDivElement, DrawerPopupProps>(fu
modal={modal}
outsideElementsInert={modal}
initialFocus={autoFocus ? undefined : popupRef}
returnFocus={returnFocusRef}
>
{element}
</FloatingFocusManager>
Expand Down
5 changes: 5 additions & 0 deletions packages/headless/src/primitives/drawer/drawer-root.tsx
Original file line numberDiff line numberDiff line change
Expand Up@@ -14,6 +14,7 @@ import {
import { type ReactNode, useCallback, useEffect, useId, useMemo, useRef, useState } from 'react';

import { useControllableState } from '../../hooks/use-controllable-state';
import { useReturnFocus } from '../../hooks/use-return-focus';
import { useTransition } from '../../hooks/use-transition';
import { DrawerAttrs, DrawerCssVars, registerDrawerCssVars } from './css-vars';
import {
Expand DownExpand Up@@ -119,6 +120,8 @@ function DrawerInner(props: DrawerProps) {
onOpenChange: setOpen,
});

const returnFocusRef = useReturnFocus(floatingContext);

const { mounted, transitionProps } = useTransition({ open, ref: popupRef });

const click = useClick(floatingContext);
Expand DownExpand Up@@ -223,6 +226,7 @@ function DrawerInner(props: DrawerProps) {
getFloatingProps,
popupRef,
backdropRef,
returnFocusRef,
modal,
labelId,
descriptionId,
Expand All@@ -247,6 +251,7 @@ function DrawerInner(props: DrawerProps) {
refs,
getReferenceProps,
getFloatingProps,
returnFocusRef,
modal,
labelId,
descriptionId,
Expand Down
2 changes: 2 additions & 0 deletions packages/headless/src/primitives/menu/menu-context.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -24,6 +24,8 @@ export interface MenuContextValue {
labelsRef: React.MutableRefObject<Array<string | null>>;
arrowRef: React.MutableRefObject<SVGSVGElement | null>;
popupRef: React.RefObject<HTMLDivElement | null>;
/** Where focus goes when the menu closes, or `null` to leave focus alone. */
returnFocusRef: React.MutableRefObject<HTMLElement | null>;
isNested: boolean;
mounted: boolean;
transitionProps: TransitionProps;
Expand Down
7 changes: 4 additions & 3 deletions packages/headless/src/primitives/menu/menu-positioner.tsx
Original file line numberDiff line numberDiff line change
Expand Up@@ -3,7 +3,7 @@
import { FloatingFocusManager, FloatingList } from '@floating-ui/react';
import React from 'react';

import { type ComponentProps, type DefaultProps, mergeProps, useRender } from '../../utils';
import { type ComponentProps, type DefaultProps, isKeyboardOpen, mergeProps, useRender } from '../../utils';
import { useMenuContext } from './menu-context';

export type MenuPositionerProps = ComponentProps<'div'>;
Expand All@@ -21,6 +21,7 @@ export const MenuPositioner = React.forwardRef<HTMLDivElement, MenuPositionerPro
elementsRef,
labelsRef,
isNested,
returnFocusRef,
setActiveIndex,
} = useMenuContext();

Expand DownExpand Up@@ -83,8 +84,8 @@ export const MenuPositioner = React.forwardRef<HTMLDivElement, MenuPositionerPro
<FloatingFocusManager
context={floatingContext}
modal={false}
initialFocus={isNested ? -1 : 0}
returnFocus={!isNested}
initialFocus={isNested ? -1 : isKeyboardOpen(floatingContext) ? 0 : refs.floating}
returnFocus={isNested ? false : returnFocusRef}
>
<FloatingList
elementsRef={elementsRef}
Expand Down
5 changes: 5 additions & 0 deletions packages/headless/src/primitives/menu/menu-root.tsx
Original file line numberDiff line numberDiff line change
Expand Up@@ -25,6 +25,7 @@ import {
import { type ReactNode, useContext, useEffect, useMemo, useRef, useState } from 'react';

import { useControllableState } from '../../hooks/use-controllable-state';
import { useReturnFocus } from '../../hooks/use-return-focus';
import { useTransition } from '../../hooks/use-transition';
import { cssVars } from '../../utils/css-vars';
import { MenuContext, type MenuContextValue } from './menu-context';
Expand DownExpand Up@@ -85,6 +86,8 @@ function MenuInner(props: MenuProps) {
whileElementsMounted: autoUpdate,
});

const returnFocusRef = useReturnFocus(floatingContext);

const { mounted, transitionProps } = useTransition({
open,
ref: popupRef,
Expand DownExpand Up@@ -179,6 +182,7 @@ function MenuInner(props: MenuProps) {
labelsRef,
arrowRef,
popupRef,
returnFocusRef,
isNested,
mounted,
transitionProps,
Expand All@@ -194,6 +198,7 @@ function MenuInner(props: MenuProps) {
getFloatingProps,
getItemProps,
activeIndex,
returnFocusRef,
isNested,
mounted,
transitionProps,
Expand Down
Loading
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix"); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .changeset/headless-return-focus.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
---
---
98 changes: 98 additions & 0 deletions packages/headless/src/hooks/use-return-focus.test.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,98 @@
import type { FloatingEvents } from '@floating-ui/react';
import { renderHook } from '@testing-library/react';
import { afterEach, beforeEach, describe, expect, it } from 'vitest';

import { useReturnFocus } from './use-return-focus';

function createEvents(): FloatingEvents & { close: (event?: Event) => void } {
const handlers = new Map<string, Array<(data: unknown) => void>>();

return {
emit(event, data) {
handlers.get(event)?.forEach(handler => handler(data));
},
on(event, handler) {
handlers.set(event, [...(handlers.get(event) ?? []), handler]);
},
off(event, handler) {
handlers.set(
event,
(handlers.get(event) ?? []).filter(h => h !== handler),
);
},
close(event) {
this.emit('openchange', { open: false, event });
},
};
}

function renderReturnFocus(trigger: HTMLElement) {
const events = createEvents();

const { result, rerender } = renderHook(
({ open }: { open: boolean }) =>
useReturnFocus({ open, events, elements: { domReference: trigger, reference: trigger, floating: null } }),
{ initialProps: { open: false } },
);

return { events, result, open: (open: boolean) => rerender({ open }) };
}

let trigger: HTMLElement;

afterEach(() => trigger?.remove());

describe('useReturnFocus', () => {
beforeEach(() => {
trigger = document.createElement('button');
document.body.append(trigger);
});

it('resolves to the trigger while open', () => {
const { result, open } = renderReturnFocus(trigger);

open(true);

expect(result.current.current).toBe(trigger);
});

it('keeps the trigger when the close came from the keyboard', () => {
const { events, result, open } = renderReturnFocus(trigger);
open(true);

events.close(new KeyboardEvent('keydown', { key: 'Escape' }));

expect(result.current.current).toBe(trigger);
});

it('keeps the trigger when the close came from a control inside the popup', () => {
const { events, result, open } = renderReturnFocus(trigger);
open(true);

// A Close button or menu item routes through the consumer's own state setter,
// so floating-ui reports the change with no event behind it.
events.close();

expect(result.current.current).toBe(trigger);
});

it('leaves focus alone when the close came from a pointer', () => {
const { events, result, open } = renderReturnFocus(trigger);
open(true);

events.close(new MouseEvent('mousedown', { detail: 1 }));

expect(result.current.current).toBeNull();
});

it('restores the trigger on the next open', () => {
const { events, result, open } = renderReturnFocus(trigger);
open(true);
events.close(new MouseEvent('mousedown', { detail: 1 }));

open(false);
open(true);

expect(result.current.current).toBe(trigger);
});
});
49 changes: 49 additions & 0 deletions packages/headless/src/hooks/use-return-focus.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,49 @@
'use client';

import type { FloatingContext } from '@floating-ui/react';
import { useEffect, useRef } from 'react';

import { isKeyboardEvent } from '../utils/interaction-modality';

/**
* The element `FloatingFocusManager` restores focus to when the floating element closes.
*
* The trigger is the default, which is what a keyboard user needs. Safari never focuses a
* button it was clicked on, so after a pointer dismiss the popup is the only thing the page
* has focused: restoring focus to the trigger then matches `:focus-visible` and paints a ring
* the user never asked for. A pointer dismiss therefore resolves to `null`, which leaves focus
* where the pointer left it, the same choice Base UI makes from its close interaction type.
*
* Pass the result to `FloatingFocusManager`'s `returnFocus`. On `null` it falls back to the
* hidden guard element it keeps next to the trigger, so the tab position survives; verify that
* still holds when upgrading `@floating-ui/react`.
*/
export function useReturnFocus(
context: Pick<FloatingContext, 'open' | 'events' | 'elements'>,
): React.MutableRefObject<HTMLElement | null> {
const { open, events, elements } = context;
const returnFocusRef = useRef<HTMLElement | null>(null);
const trigger = elements.domReference;

useEffect(() => {
if (open) {
returnFocusRef.current = trigger instanceof HTMLElement ? trigger : null;
}
}, [open, trigger]);

useEffect(() => {
// Closes routed straight through the consumer's own state setter (a Close button, an
// item click) never reach floating-ui, so only what floating-ui itself drives can
// downgrade the default.
function onOpenChange({ open, event }: { open: boolean; event?: Event }) {
if (!open && event && !isKeyboardEvent(event)) {
returnFocusRef.current = null;
}
}

events.on('openchange', onOpenChange);
return () => events.off('openchange', onOpenChange);
}, [events]);

return returnFocusRef;
}
Original file line numberDiff line numberDiff line change
Expand Up@@ -643,6 +643,7 @@ describe('Autocomplete', () => {

return (
<Popover.Root
initialFocus='first'
open={popoverOpen}
onOpenChange={open => {
setPopoverOpen(open);
Expand DownExpand Up@@ -786,6 +787,7 @@ describe('Autocomplete', () => {

return (
<Popover.Root
initialFocus='first'
open={popoverOpen}
onOpenChange={open => {
setPopoverOpen(open);
Expand DownExpand Up@@ -880,6 +882,7 @@ describe('Autocomplete', () => {

return (
<Popover.Root
initialFocus='first'
open={popoverOpen}
onOpenChange={open => {
setPopoverOpen(open);
Expand Down
2 changes: 2 additions & 0 deletions packages/headless/src/primitives/dialog/dialog-context.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -11,6 +11,8 @@ export interface DialogContextValue {
getReferenceProps: UseInteractionsReturn['getReferenceProps'];
getFloatingProps: UseInteractionsReturn['getFloatingProps'];
popupRef: React.RefObject<HTMLDivElement | null>;
/** Where focus goes when the dialog closes, or `null` to leave focus alone. */
returnFocusRef: React.MutableRefObject<HTMLElement | null>;
modal: boolean;
labelId: string;
descriptionId: string;
Expand Down
15 changes: 13 additions & 2 deletions packages/headless/src/primitives/dialog/dialog-popup.tsx
Original file line numberDiff line numberDiff line change
Expand Up@@ -12,8 +12,18 @@ export type DialogPopupProps = ComponentProps<'div'>;
/** The dialog content container. Manages focus trapping via `FloatingFocusManager` and wires ARIA attributes from `Dialog.Title` and `Dialog.Description`. */
export const DialogPopup = React.forwardRef<HTMLDivElement, DialogPopupProps>(function DialogPopup(props, ref) {
const { render, ...otherProps } = props;
const { popupRef, refs, getFloatingProps, floatingContext, modal, labelId, descriptionId, mounted, transitionProps } =
useDialogContext();
const {
popupRef,
refs,
getFloatingProps,
floatingContext,
modal,
returnFocusRef,
labelId,
descriptionId,
mounted,
transitionProps,
} = useDialogContext();

const ownProps = {
'aria-labelledby': labelId,
Expand DownExpand Up@@ -43,6 +53,7 @@ export const DialogPopup = React.forwardRef<HTMLDivElement, DialogPopupProps>(fu
context={floatingContext}
modal={modal}
outsideElementsInert={modal}
returnFocus={returnFocusRef}
>
{element}
</FloatingFocusManager>
Expand Down
5 changes: 5 additions & 0 deletions packages/headless/src/primitives/dialog/dialog-root.tsx
Original file line numberDiff line numberDiff line change
Expand Up@@ -14,6 +14,7 @@ import {
import { type ReactNode, useId, useMemo, useRef } from 'react';

import { useControllableState } from '../../hooks/use-controllable-state';
import { useReturnFocus } from '../../hooks/use-return-focus';
import { useTransition } from '../../hooks/use-transition';
import { DialogContext, type DialogContextValue } from './dialog-context';

Expand DownExpand Up@@ -43,6 +44,8 @@ function DialogInner(props: DialogProps) {
onOpenChange: setOpen,
});

const returnFocusRef = useReturnFocus(floatingContext);

const { mounted, transitionProps } = useTransition({
open,
ref: popupRef,
Expand All@@ -65,6 +68,7 @@ function DialogInner(props: DialogProps) {
getReferenceProps,
getFloatingProps,
popupRef,
returnFocusRef,
modal,
labelId,
descriptionId,
Expand All@@ -78,6 +82,7 @@ function DialogInner(props: DialogProps) {
refs,
getReferenceProps,
getFloatingProps,
returnFocusRef,
modal,
labelId,
descriptionId,
Expand Down
2 changes: 2 additions & 0 deletions packages/headless/src/primitives/drawer/drawer-popup.tsx
Original file line numberDiff line numberDiff line change
Expand Up@@ -24,6 +24,7 @@ export const DrawerPopup = React.forwardRef<HTMLDivElement, DrawerPopupProps>(fu
getFloatingProps,
floatingContext,
modal,
returnFocusRef,
labelId,
descriptionId,
mounted,
Expand DownExpand Up@@ -107,6 +108,7 @@ export const DrawerPopup = React.forwardRef<HTMLDivElement, DrawerPopupProps>(fu
modal={modal}
outsideElementsInert={modal}
initialFocus={autoFocus ? undefined : popupRef}
returnFocus={returnFocusRef}
>
{element}
</FloatingFocusManager>
Expand Down
5 changes: 5 additions & 0 deletions packages/headless/src/primitives/drawer/drawer-root.tsx
Original file line numberDiff line numberDiff line change
Expand Up@@ -14,6 +14,7 @@ import {
import { type ReactNode, useCallback, useEffect, useId, useMemo, useRef, useState } from 'react';

import { useControllableState } from '../../hooks/use-controllable-state';
import { useReturnFocus } from '../../hooks/use-return-focus';
import { useTransition } from '../../hooks/use-transition';
import { DrawerAttrs, DrawerCssVars, registerDrawerCssVars } from './css-vars';
import {
Expand DownExpand Up@@ -119,6 +120,8 @@ function DrawerInner(props: DrawerProps) {
onOpenChange: setOpen,
});

const returnFocusRef = useReturnFocus(floatingContext);

const { mounted, transitionProps } = useTransition({ open, ref: popupRef });

const click = useClick(floatingContext);
Expand DownExpand Up@@ -223,6 +226,7 @@ function DrawerInner(props: DrawerProps) {
getFloatingProps,
popupRef,
backdropRef,
returnFocusRef,
modal,
labelId,
descriptionId,
Expand All@@ -247,6 +251,7 @@ function DrawerInner(props: DrawerProps) {
refs,
getReferenceProps,
getFloatingProps,
returnFocusRef,
modal,
labelId,
descriptionId,
Expand Down
2 changes: 2 additions & 0 deletions packages/headless/src/primitives/menu/menu-context.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -24,6 +24,8 @@ export interface MenuContextValue {
labelsRef: React.MutableRefObject<Array<string | null>>;
arrowRef: React.MutableRefObject<SVGSVGElement | null>;
popupRef: React.RefObject<HTMLDivElement | null>;
/** Where focus goes when the menu closes, or `null` to leave focus alone. */
returnFocusRef: React.MutableRefObject<HTMLElement | null>;
isNested: boolean;
mounted: boolean;
transitionProps: TransitionProps;
Expand Down
7 changes: 4 additions & 3 deletions packages/headless/src/primitives/menu/menu-positioner.tsx
Original file line numberDiff line numberDiff line change
Expand Up@@ -3,7 +3,7 @@
import { FloatingFocusManager, FloatingList } from '@floating-ui/react';
import React from 'react';

import { type ComponentProps, type DefaultProps, mergeProps, useRender } from '../../utils';
import { type ComponentProps, type DefaultProps, isKeyboardOpen, mergeProps, useRender } from '../../utils';
import { useMenuContext } from './menu-context';

export type MenuPositionerProps = ComponentProps<'div'>;
Expand All@@ -21,6 +21,7 @@ export const MenuPositioner = React.forwardRef<HTMLDivElement, MenuPositionerPro
elementsRef,
labelsRef,
isNested,
returnFocusRef,
setActiveIndex,
} = useMenuContext();

Expand DownExpand Up@@ -83,8 +84,8 @@ export const MenuPositioner = React.forwardRef<HTMLDivElement, MenuPositionerPro
<FloatingFocusManager
context={floatingContext}
modal={false}
initialFocus={isNested ? -1 : 0}
returnFocus={!isNested}
initialFocus={isNested ? -1 : isKeyboardOpen(floatingContext) ? 0 : refs.floating}
returnFocus={isNested ? false : returnFocusRef}
>
<FloatingList
elementsRef={elementsRef}
Expand Down
5 changes: 5 additions & 0 deletions packages/headless/src/primitives/menu/menu-root.tsx
Original file line numberDiff line numberDiff line change
Expand Up@@ -25,6 +25,7 @@ import {
import { type ReactNode, useContext, useEffect, useMemo, useRef, useState } from 'react';

import { useControllableState } from '../../hooks/use-controllable-state';
import { useReturnFocus } from '../../hooks/use-return-focus';
import { useTransition } from '../../hooks/use-transition';
import { cssVars } from '../../utils/css-vars';
import { MenuContext, type MenuContextValue } from './menu-context';
Expand DownExpand Up@@ -85,6 +86,8 @@ function MenuInner(props: MenuProps) {
whileElementsMounted: autoUpdate,
});

const returnFocusRef = useReturnFocus(floatingContext);

const { mounted, transitionProps } = useTransition({
open,
ref: popupRef,
Expand DownExpand Up@@ -179,6 +182,7 @@ function MenuInner(props: MenuProps) {
labelsRef,
arrowRef,
popupRef,
returnFocusRef,
isNested,
mounted,
transitionProps,
Expand All@@ -194,6 +198,7 @@ function MenuInner(props: MenuProps) {
getFloatingProps,
getItemProps,
activeIndex,
returnFocusRef,
isNested,
mounted,
transitionProps,
Expand Down
Loading
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms"); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .changeset/headless-return-focus.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
---
---
98 changes: 98 additions & 0 deletions packages/headless/src/hooks/use-return-focus.test.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,98 @@
import type { FloatingEvents } from '@floating-ui/react';
import { renderHook } from '@testing-library/react';
import { afterEach, beforeEach, describe, expect, it } from 'vitest';

import { useReturnFocus } from './use-return-focus';

function createEvents(): FloatingEvents & { close: (event?: Event) => void } {
const handlers = new Map<string, Array<(data: unknown) => void>>();

return {
emit(event, data) {
handlers.get(event)?.forEach(handler => handler(data));
},
on(event, handler) {
handlers.set(event, [...(handlers.get(event) ?? []), handler]);
},
off(event, handler) {
handlers.set(
event,
(handlers.get(event) ?? []).filter(h => h !== handler),
);
},
close(event) {
this.emit('openchange', { open: false, event });
},
};
}

function renderReturnFocus(trigger: HTMLElement) {
const events = createEvents();

const { result, rerender } = renderHook(
({ open }: { open: boolean }) =>
useReturnFocus({ open, events, elements: { domReference: trigger, reference: trigger, floating: null } }),
{ initialProps: { open: false } },
);

return { events, result, open: (open: boolean) => rerender({ open }) };
}

let trigger: HTMLElement;

afterEach(() => trigger?.remove());

describe('useReturnFocus', () => {
beforeEach(() => {
trigger = document.createElement('button');
document.body.append(trigger);
});

it('resolves to the trigger while open', () => {
const { result, open } = renderReturnFocus(trigger);

open(true);

expect(result.current.current).toBe(trigger);
});

it('keeps the trigger when the close came from the keyboard', () => {
const { events, result, open } = renderReturnFocus(trigger);
open(true);

events.close(new KeyboardEvent('keydown', { key: 'Escape' }));

expect(result.current.current).toBe(trigger);
});

it('keeps the trigger when the close came from a control inside the popup', () => {
const { events, result, open } = renderReturnFocus(trigger);
open(true);

// A Close button or menu item routes through the consumer's own state setter,
// so floating-ui reports the change with no event behind it.
events.close();

expect(result.current.current).toBe(trigger);
});

it('leaves focus alone when the close came from a pointer', () => {
const { events, result, open } = renderReturnFocus(trigger);
open(true);

events.close(new MouseEvent('mousedown', { detail: 1 }));

expect(result.current.current).toBeNull();
});

it('restores the trigger on the next open', () => {
const { events, result, open } = renderReturnFocus(trigger);
open(true);
events.close(new MouseEvent('mousedown', { detail: 1 }));

open(false);
open(true);

expect(result.current.current).toBe(trigger);
});
});
49 changes: 49 additions & 0 deletions packages/headless/src/hooks/use-return-focus.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,49 @@
'use client';

import type { FloatingContext } from '@floating-ui/react';
import { useEffect, useRef } from 'react';

import { isKeyboardEvent } from '../utils/interaction-modality';

/**
* The element `FloatingFocusManager` restores focus to when the floating element closes.
*
* The trigger is the default, which is what a keyboard user needs. Safari never focuses a
* button it was clicked on, so after a pointer dismiss the popup is the only thing the page
* has focused: restoring focus to the trigger then matches `:focus-visible` and paints a ring
* the user never asked for. A pointer dismiss therefore resolves to `null`, which leaves focus
* where the pointer left it, the same choice Base UI makes from its close interaction type.
*
* Pass the result to `FloatingFocusManager`'s `returnFocus`. On `null` it falls back to the
* hidden guard element it keeps next to the trigger, so the tab position survives; verify that
* still holds when upgrading `@floating-ui/react`.
*/
export function useReturnFocus(
context: Pick<FloatingContext, 'open' | 'events' | 'elements'>,
): React.MutableRefObject<HTMLElement | null> {
const { open, events, elements } = context;
const returnFocusRef = useRef<HTMLElement | null>(null);
const trigger = elements.domReference;

useEffect(() => {
if (open) {
returnFocusRef.current = trigger instanceof HTMLElement ? trigger : null;
}
}, [open, trigger]);

useEffect(() => {
// Closes routed straight through the consumer's own state setter (a Close button, an
// item click) never reach floating-ui, so only what floating-ui itself drives can
// downgrade the default.
function onOpenChange({ open, event }: { open: boolean; event?: Event }) {
if (!open && event && !isKeyboardEvent(event)) {
returnFocusRef.current = null;
}
}

events.on('openchange', onOpenChange);
return () => events.off('openchange', onOpenChange);
}, [events]);

return returnFocusRef;
}
Original file line numberDiff line numberDiff line change
Expand Up@@ -643,6 +643,7 @@ describe('Autocomplete', () => {

return (
<Popover.Root
initialFocus='first'
open={popoverOpen}
onOpenChange={open => {
setPopoverOpen(open);
Expand DownExpand Up@@ -786,6 +787,7 @@ describe('Autocomplete', () => {

return (
<Popover.Root
initialFocus='first'
open={popoverOpen}
onOpenChange={open => {
setPopoverOpen(open);
Expand DownExpand Up@@ -880,6 +882,7 @@ describe('Autocomplete', () => {

return (
<Popover.Root
initialFocus='first'
open={popoverOpen}
onOpenChange={open => {
setPopoverOpen(open);
Expand Down
2 changes: 2 additions & 0 deletions packages/headless/src/primitives/dialog/dialog-context.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -11,6 +11,8 @@ export interface DialogContextValue {
getReferenceProps: UseInteractionsReturn['getReferenceProps'];
getFloatingProps: UseInteractionsReturn['getFloatingProps'];
popupRef: React.RefObject<HTMLDivElement | null>;
/** Where focus goes when the dialog closes, or `null` to leave focus alone. */
returnFocusRef: React.MutableRefObject<HTMLElement | null>;
modal: boolean;
labelId: string;
descriptionId: string;
Expand Down
15 changes: 13 additions & 2 deletions packages/headless/src/primitives/dialog/dialog-popup.tsx
Original file line numberDiff line numberDiff line change
Expand Up@@ -12,8 +12,18 @@ export type DialogPopupProps = ComponentProps<'div'>;
/** The dialog content container. Manages focus trapping via `FloatingFocusManager` and wires ARIA attributes from `Dialog.Title` and `Dialog.Description`. */
export const DialogPopup = React.forwardRef<HTMLDivElement, DialogPopupProps>(function DialogPopup(props, ref) {
const { render, ...otherProps } = props;
const { popupRef, refs, getFloatingProps, floatingContext, modal, labelId, descriptionId, mounted, transitionProps } =
useDialogContext();
const {
popupRef,
refs,
getFloatingProps,
floatingContext,
modal,
returnFocusRef,
labelId,
descriptionId,
mounted,
transitionProps,
} = useDialogContext();

const ownProps = {
'aria-labelledby': labelId,
Expand DownExpand Up@@ -43,6 +53,7 @@ export const DialogPopup = React.forwardRef<HTMLDivElement, DialogPopupProps>(fu
context={floatingContext}
modal={modal}
outsideElementsInert={modal}
returnFocus={returnFocusRef}
>
{element}
</FloatingFocusManager>
Expand Down
5 changes: 5 additions & 0 deletions packages/headless/src/primitives/dialog/dialog-root.tsx
Original file line numberDiff line numberDiff line change
Expand Up@@ -14,6 +14,7 @@ import {
import { type ReactNode, useId, useMemo, useRef } from 'react';

import { useControllableState } from '../../hooks/use-controllable-state';
import { useReturnFocus } from '../../hooks/use-return-focus';
import { useTransition } from '../../hooks/use-transition';
import { DialogContext, type DialogContextValue } from './dialog-context';

Expand DownExpand Up@@ -43,6 +44,8 @@ function DialogInner(props: DialogProps) {
onOpenChange: setOpen,
});

const returnFocusRef = useReturnFocus(floatingContext);

const { mounted, transitionProps } = useTransition({
open,
ref: popupRef,
Expand All@@ -65,6 +68,7 @@ function DialogInner(props: DialogProps) {
getReferenceProps,
getFloatingProps,
popupRef,
returnFocusRef,
modal,
labelId,
descriptionId,
Expand All@@ -78,6 +82,7 @@ function DialogInner(props: DialogProps) {
refs,
getReferenceProps,
getFloatingProps,
returnFocusRef,
modal,
labelId,
descriptionId,
Expand Down
2 changes: 2 additions & 0 deletions packages/headless/src/primitives/drawer/drawer-popup.tsx
Original file line numberDiff line numberDiff line change
Expand Up@@ -24,6 +24,7 @@ export const DrawerPopup = React.forwardRef<HTMLDivElement, DrawerPopupProps>(fu
getFloatingProps,
floatingContext,
modal,
returnFocusRef,
labelId,
descriptionId,
mounted,
Expand DownExpand Up@@ -107,6 +108,7 @@ export const DrawerPopup = React.forwardRef<HTMLDivElement, DrawerPopupProps>(fu
modal={modal}
outsideElementsInert={modal}
initialFocus={autoFocus ? undefined : popupRef}
returnFocus={returnFocusRef}
>
{element}
</FloatingFocusManager>
Expand Down
5 changes: 5 additions & 0 deletions packages/headless/src/primitives/drawer/drawer-root.tsx
Original file line numberDiff line numberDiff line change
Expand Up@@ -14,6 +14,7 @@ import {
import { type ReactNode, useCallback, useEffect, useId, useMemo, useRef, useState } from 'react';

import { useControllableState } from '../../hooks/use-controllable-state';
import { useReturnFocus } from '../../hooks/use-return-focus';
import { useTransition } from '../../hooks/use-transition';
import { DrawerAttrs, DrawerCssVars, registerDrawerCssVars } from './css-vars';
import {
Expand DownExpand Up@@ -119,6 +120,8 @@ function DrawerInner(props: DrawerProps) {
onOpenChange: setOpen,
});

const returnFocusRef = useReturnFocus(floatingContext);

const { mounted, transitionProps } = useTransition({ open, ref: popupRef });

const click = useClick(floatingContext);
Expand DownExpand Up@@ -223,6 +226,7 @@ function DrawerInner(props: DrawerProps) {
getFloatingProps,
popupRef,
backdropRef,
returnFocusRef,
modal,
labelId,
descriptionId,
Expand All@@ -247,6 +251,7 @@ function DrawerInner(props: DrawerProps) {
refs,
getReferenceProps,
getFloatingProps,
returnFocusRef,
modal,
labelId,
descriptionId,
Expand Down
2 changes: 2 additions & 0 deletions packages/headless/src/primitives/menu/menu-context.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -24,6 +24,8 @@ export interface MenuContextValue {
labelsRef: React.MutableRefObject<Array<string | null>>;
arrowRef: React.MutableRefObject<SVGSVGElement | null>;
popupRef: React.RefObject<HTMLDivElement | null>;
/** Where focus goes when the menu closes, or `null` to leave focus alone. */
returnFocusRef: React.MutableRefObject<HTMLElement | null>;
isNested: boolean;
mounted: boolean;
transitionProps: TransitionProps;
Expand Down
7 changes: 4 additions & 3 deletions packages/headless/src/primitives/menu/menu-positioner.tsx
Original file line numberDiff line numberDiff line change
Expand Up@@ -3,7 +3,7 @@
import { FloatingFocusManager, FloatingList } from '@floating-ui/react';
import React from 'react';

import { type ComponentProps, type DefaultProps, mergeProps, useRender } from '../../utils';
import { type ComponentProps, type DefaultProps, isKeyboardOpen, mergeProps, useRender } from '../../utils';
import { useMenuContext } from './menu-context';

export type MenuPositionerProps = ComponentProps<'div'>;
Expand All@@ -21,6 +21,7 @@ export const MenuPositioner = React.forwardRef<HTMLDivElement, MenuPositionerPro
elementsRef,
labelsRef,
isNested,
returnFocusRef,
setActiveIndex,
} = useMenuContext();

Expand DownExpand Up@@ -83,8 +84,8 @@ export const MenuPositioner = React.forwardRef<HTMLDivElement, MenuPositionerPro
<FloatingFocusManager
context={floatingContext}
modal={false}
initialFocus={isNested ? -1 : 0}
returnFocus={!isNested}
initialFocus={isNested ? -1 : isKeyboardOpen(floatingContext) ? 0 : refs.floating}
returnFocus={isNested ? false : returnFocusRef}
>
<FloatingList
elementsRef={elementsRef}
Expand Down
5 changes: 5 additions & 0 deletions packages/headless/src/primitives/menu/menu-root.tsx
Original file line numberDiff line numberDiff line change
Expand Up@@ -25,6 +25,7 @@ import {
import { type ReactNode, useContext, useEffect, useMemo, useRef, useState } from 'react';

import { useControllableState } from '../../hooks/use-controllable-state';
import { useReturnFocus } from '../../hooks/use-return-focus';
import { useTransition } from '../../hooks/use-transition';
import { cssVars } from '../../utils/css-vars';
import { MenuContext, type MenuContextValue } from './menu-context';
Expand DownExpand Up@@ -85,6 +86,8 @@ function MenuInner(props: MenuProps) {
whileElementsMounted: autoUpdate,
});

const returnFocusRef = useReturnFocus(floatingContext);

const { mounted, transitionProps } = useTransition({
open,
ref: popupRef,
Expand DownExpand Up@@ -179,6 +182,7 @@ function MenuInner(props: MenuProps) {
labelsRef,
arrowRef,
popupRef,
returnFocusRef,
isNested,
mounted,
transitionProps,
Expand All@@ -194,6 +198,7 @@ function MenuInner(props: MenuProps) {
getFloatingProps,
getItemProps,
activeIndex,
returnFocusRef,
isNested,
mounted,
transitionProps,
Expand Down
Loading
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links"); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .changeset/headless-return-focus.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
---
---
98 changes: 98 additions & 0 deletions packages/headless/src/hooks/use-return-focus.test.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,98 @@
import type { FloatingEvents } from '@floating-ui/react';
import { renderHook } from '@testing-library/react';
import { afterEach, beforeEach, describe, expect, it } from 'vitest';

import { useReturnFocus } from './use-return-focus';

function createEvents(): FloatingEvents & { close: (event?: Event) => void } {
const handlers = new Map<string, Array<(data: unknown) => void>>();

return {
emit(event, data) {
handlers.get(event)?.forEach(handler => handler(data));
},
on(event, handler) {
handlers.set(event, [...(handlers.get(event) ?? []), handler]);
},
off(event, handler) {
handlers.set(
event,
(handlers.get(event) ?? []).filter(h => h !== handler),
);
},
close(event) {
this.emit('openchange', { open: false, event });
},
};
}

function renderReturnFocus(trigger: HTMLElement) {
const events = createEvents();

const { result, rerender } = renderHook(
({ open }: { open: boolean }) =>
useReturnFocus({ open, events, elements: { domReference: trigger, reference: trigger, floating: null } }),
{ initialProps: { open: false } },
);

return { events, result, open: (open: boolean) => rerender({ open }) };
}

let trigger: HTMLElement;

afterEach(() => trigger?.remove());

describe('useReturnFocus', () => {
beforeEach(() => {
trigger = document.createElement('button');
document.body.append(trigger);
});

it('resolves to the trigger while open', () => {
const { result, open } = renderReturnFocus(trigger);

open(true);

expect(result.current.current).toBe(trigger);
});

it('keeps the trigger when the close came from the keyboard', () => {
const { events, result, open } = renderReturnFocus(trigger);
open(true);

events.close(new KeyboardEvent('keydown', { key: 'Escape' }));

expect(result.current.current).toBe(trigger);
});

it('keeps the trigger when the close came from a control inside the popup', () => {
const { events, result, open } = renderReturnFocus(trigger);
open(true);

// A Close button or menu item routes through the consumer's own state setter,
// so floating-ui reports the change with no event behind it.
events.close();

expect(result.current.current).toBe(trigger);
});

it('leaves focus alone when the close came from a pointer', () => {
const { events, result, open } = renderReturnFocus(trigger);
open(true);

events.close(new MouseEvent('mousedown', { detail: 1 }));

expect(result.current.current).toBeNull();
});

it('restores the trigger on the next open', () => {
const { events, result, open } = renderReturnFocus(trigger);
open(true);
events.close(new MouseEvent('mousedown', { detail: 1 }));

open(false);
open(true);

expect(result.current.current).toBe(trigger);
});
});
49 changes: 49 additions & 0 deletions packages/headless/src/hooks/use-return-focus.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,49 @@
'use client';

import type { FloatingContext } from '@floating-ui/react';
import { useEffect, useRef } from 'react';

import { isKeyboardEvent } from '../utils/interaction-modality';

/**
* The element `FloatingFocusManager` restores focus to when the floating element closes.
*
* The trigger is the default, which is what a keyboard user needs. Safari never focuses a
* button it was clicked on, so after a pointer dismiss the popup is the only thing the page
* has focused: restoring focus to the trigger then matches `:focus-visible` and paints a ring
* the user never asked for. A pointer dismiss therefore resolves to `null`, which leaves focus
* where the pointer left it, the same choice Base UI makes from its close interaction type.
*
* Pass the result to `FloatingFocusManager`'s `returnFocus`. On `null` it falls back to the
* hidden guard element it keeps next to the trigger, so the tab position survives; verify that
* still holds when upgrading `@floating-ui/react`.
*/
export function useReturnFocus(
context: Pick<FloatingContext, 'open' | 'events' | 'elements'>,
): React.MutableRefObject<HTMLElement | null> {
const { open, events, elements } = context;
const returnFocusRef = useRef<HTMLElement | null>(null);
const trigger = elements.domReference;

useEffect(() => {
if (open) {
returnFocusRef.current = trigger instanceof HTMLElement ? trigger : null;
}
}, [open, trigger]);

useEffect(() => {
// Closes routed straight through the consumer's own state setter (a Close button, an
// item click) never reach floating-ui, so only what floating-ui itself drives can
// downgrade the default.
function onOpenChange({ open, event }: { open: boolean; event?: Event }) {
if (!open && event && !isKeyboardEvent(event)) {
returnFocusRef.current = null;
}
}

events.on('openchange', onOpenChange);
return () => events.off('openchange', onOpenChange);
}, [events]);

return returnFocusRef;
}
Original file line numberDiff line numberDiff line change
Expand Up@@ -643,6 +643,7 @@ describe('Autocomplete', () => {

return (
<Popover.Root
initialFocus='first'
open={popoverOpen}
onOpenChange={open => {
setPopoverOpen(open);
Expand DownExpand Up@@ -786,6 +787,7 @@ describe('Autocomplete', () => {

return (
<Popover.Root
initialFocus='first'
open={popoverOpen}
onOpenChange={open => {
setPopoverOpen(open);
Expand DownExpand Up@@ -880,6 +882,7 @@ describe('Autocomplete', () => {

return (
<Popover.Root
initialFocus='first'
open={popoverOpen}
onOpenChange={open => {
setPopoverOpen(open);
Expand Down
2 changes: 2 additions & 0 deletions packages/headless/src/primitives/dialog/dialog-context.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -11,6 +11,8 @@ export interface DialogContextValue {
getReferenceProps: UseInteractionsReturn['getReferenceProps'];
getFloatingProps: UseInteractionsReturn['getFloatingProps'];
popupRef: React.RefObject<HTMLDivElement | null>;
/** Where focus goes when the dialog closes, or `null` to leave focus alone. */
returnFocusRef: React.MutableRefObject<HTMLElement | null>;
modal: boolean;
labelId: string;
descriptionId: string;
Expand Down
15 changes: 13 additions & 2 deletions packages/headless/src/primitives/dialog/dialog-popup.tsx
Original file line numberDiff line numberDiff line change
Expand Up@@ -12,8 +12,18 @@ export type DialogPopupProps = ComponentProps<'div'>;
/** The dialog content container. Manages focus trapping via `FloatingFocusManager` and wires ARIA attributes from `Dialog.Title` and `Dialog.Description`. */
export const DialogPopup = React.forwardRef<HTMLDivElement, DialogPopupProps>(function DialogPopup(props, ref) {
const { render, ...otherProps } = props;
const { popupRef, refs, getFloatingProps, floatingContext, modal, labelId, descriptionId, mounted, transitionProps } =
useDialogContext();
const {
popupRef,
refs,
getFloatingProps,
floatingContext,
modal,
returnFocusRef,
labelId,
descriptionId,
mounted,
transitionProps,
} = useDialogContext();

const ownProps = {
'aria-labelledby': labelId,
Expand DownExpand Up@@ -43,6 +53,7 @@ export const DialogPopup = React.forwardRef<HTMLDivElement, DialogPopupProps>(fu
context={floatingContext}
modal={modal}
outsideElementsInert={modal}
returnFocus={returnFocusRef}
>
{element}
</FloatingFocusManager>
Expand Down
5 changes: 5 additions & 0 deletions packages/headless/src/primitives/dialog/dialog-root.tsx
Original file line numberDiff line numberDiff line change
Expand Up@@ -14,6 +14,7 @@ import {
import { type ReactNode, useId, useMemo, useRef } from 'react';

import { useControllableState } from '../../hooks/use-controllable-state';
import { useReturnFocus } from '../../hooks/use-return-focus';
import { useTransition } from '../../hooks/use-transition';
import { DialogContext, type DialogContextValue } from './dialog-context';

Expand DownExpand Up@@ -43,6 +44,8 @@ function DialogInner(props: DialogProps) {
onOpenChange: setOpen,
});

const returnFocusRef = useReturnFocus(floatingContext);

const { mounted, transitionProps } = useTransition({
open,
ref: popupRef,
Expand All@@ -65,6 +68,7 @@ function DialogInner(props: DialogProps) {
getReferenceProps,
getFloatingProps,
popupRef,
returnFocusRef,
modal,
labelId,
descriptionId,
Expand All@@ -78,6 +82,7 @@ function DialogInner(props: DialogProps) {
refs,
getReferenceProps,
getFloatingProps,
returnFocusRef,
modal,
labelId,
descriptionId,
Expand Down
2 changes: 2 additions & 0 deletions packages/headless/src/primitives/drawer/drawer-popup.tsx
Original file line numberDiff line numberDiff line change
Expand Up@@ -24,6 +24,7 @@ export const DrawerPopup = React.forwardRef<HTMLDivElement, DrawerPopupProps>(fu
getFloatingProps,
floatingContext,
modal,
returnFocusRef,
labelId,
descriptionId,
mounted,
Expand DownExpand Up@@ -107,6 +108,7 @@ export const DrawerPopup = React.forwardRef<HTMLDivElement, DrawerPopupProps>(fu
modal={modal}
outsideElementsInert={modal}
initialFocus={autoFocus ? undefined : popupRef}
returnFocus={returnFocusRef}
>
{element}
</FloatingFocusManager>
Expand Down
5 changes: 5 additions & 0 deletions packages/headless/src/primitives/drawer/drawer-root.tsx
Original file line numberDiff line numberDiff line change
Expand Up@@ -14,6 +14,7 @@ import {
import { type ReactNode, useCallback, useEffect, useId, useMemo, useRef, useState } from 'react';

import { useControllableState } from '../../hooks/use-controllable-state';
import { useReturnFocus } from '../../hooks/use-return-focus';
import { useTransition } from '../../hooks/use-transition';
import { DrawerAttrs, DrawerCssVars, registerDrawerCssVars } from './css-vars';
import {
Expand DownExpand Up@@ -119,6 +120,8 @@ function DrawerInner(props: DrawerProps) {
onOpenChange: setOpen,
});

const returnFocusRef = useReturnFocus(floatingContext);

const { mounted, transitionProps } = useTransition({ open, ref: popupRef });

const click = useClick(floatingContext);
Expand DownExpand Up@@ -223,6 +226,7 @@ function DrawerInner(props: DrawerProps) {
getFloatingProps,
popupRef,
backdropRef,
returnFocusRef,
modal,
labelId,
descriptionId,
Expand All@@ -247,6 +251,7 @@ function DrawerInner(props: DrawerProps) {
refs,
getReferenceProps,
getFloatingProps,
returnFocusRef,
modal,
labelId,
descriptionId,
Expand Down
2 changes: 2 additions & 0 deletions packages/headless/src/primitives/menu/menu-context.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -24,6 +24,8 @@ export interface MenuContextValue {
labelsRef: React.MutableRefObject<Array<string | null>>;
arrowRef: React.MutableRefObject<SVGSVGElement | null>;
popupRef: React.RefObject<HTMLDivElement | null>;
/** Where focus goes when the menu closes, or `null` to leave focus alone. */
returnFocusRef: React.MutableRefObject<HTMLElement | null>;
isNested: boolean;
mounted: boolean;
transitionProps: TransitionProps;
Expand Down
7 changes: 4 additions & 3 deletions packages/headless/src/primitives/menu/menu-positioner.tsx
Original file line numberDiff line numberDiff line change
Expand Up@@ -3,7 +3,7 @@
import { FloatingFocusManager, FloatingList } from '@floating-ui/react';
import React from 'react';

import { type ComponentProps, type DefaultProps, mergeProps, useRender } from '../../utils';
import { type ComponentProps, type DefaultProps, isKeyboardOpen, mergeProps, useRender } from '../../utils';
import { useMenuContext } from './menu-context';

export type MenuPositionerProps = ComponentProps<'div'>;
Expand All@@ -21,6 +21,7 @@ export const MenuPositioner = React.forwardRef<HTMLDivElement, MenuPositionerPro
elementsRef,
labelsRef,
isNested,
returnFocusRef,
setActiveIndex,
} = useMenuContext();

Expand DownExpand Up@@ -83,8 +84,8 @@ export const MenuPositioner = React.forwardRef<HTMLDivElement, MenuPositionerPro
<FloatingFocusManager
context={floatingContext}
modal={false}
initialFocus={isNested ? -1 : 0}
returnFocus={!isNested}
initialFocus={isNested ? -1 : isKeyboardOpen(floatingContext) ? 0 : refs.floating}
returnFocus={isNested ? false : returnFocusRef}
>
<FloatingList
elementsRef={elementsRef}
Expand Down
5 changes: 5 additions & 0 deletions packages/headless/src/primitives/menu/menu-root.tsx
Original file line numberDiff line numberDiff line change
Expand Up@@ -25,6 +25,7 @@ import {
import { type ReactNode, useContext, useEffect, useMemo, useRef, useState } from 'react';

import { useControllableState } from '../../hooks/use-controllable-state';
import { useReturnFocus } from '../../hooks/use-return-focus';
import { useTransition } from '../../hooks/use-transition';
import { cssVars } from '../../utils/css-vars';
import { MenuContext, type MenuContextValue } from './menu-context';
Expand DownExpand Up@@ -85,6 +86,8 @@ function MenuInner(props: MenuProps) {
whileElementsMounted: autoUpdate,
});

const returnFocusRef = useReturnFocus(floatingContext);

const { mounted, transitionProps } = useTransition({
open,
ref: popupRef,
Expand DownExpand Up@@ -179,6 +182,7 @@ function MenuInner(props: MenuProps) {
labelsRef,
arrowRef,
popupRef,
returnFocusRef,
isNested,
mounted,
transitionProps,
Expand All@@ -194,6 +198,7 @@ function MenuInner(props: MenuProps) {
getFloatingProps,
getItemProps,
activeIndex,
returnFocusRef,
isNested,
mounted,
transitionProps,
Expand Down
Loading
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default"); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .changeset/headless-return-focus.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
---
---
98 changes: 98 additions & 0 deletions packages/headless/src/hooks/use-return-focus.test.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,98 @@
import type { FloatingEvents } from '@floating-ui/react';
import { renderHook } from '@testing-library/react';
import { afterEach, beforeEach, describe, expect, it } from 'vitest';

import { useReturnFocus } from './use-return-focus';

function createEvents(): FloatingEvents & { close: (event?: Event) => void } {
const handlers = new Map<string, Array<(data: unknown) => void>>();

return {
emit(event, data) {
handlers.get(event)?.forEach(handler => handler(data));
},
on(event, handler) {
handlers.set(event, [...(handlers.get(event) ?? []), handler]);
},
off(event, handler) {
handlers.set(
event,
(handlers.get(event) ?? []).filter(h => h !== handler),
);
},
close(event) {
this.emit('openchange', { open: false, event });
},
};
}

function renderReturnFocus(trigger: HTMLElement) {
const events = createEvents();

const { result, rerender } = renderHook(
({ open }: { open: boolean }) =>
useReturnFocus({ open, events, elements: { domReference: trigger, reference: trigger, floating: null } }),
{ initialProps: { open: false } },
);

return { events, result, open: (open: boolean) => rerender({ open }) };
}

let trigger: HTMLElement;

afterEach(() => trigger?.remove());

describe('useReturnFocus', () => {
beforeEach(() => {
trigger = document.createElement('button');
document.body.append(trigger);
});

it('resolves to the trigger while open', () => {
const { result, open } = renderReturnFocus(trigger);

open(true);

expect(result.current.current).toBe(trigger);
});

it('keeps the trigger when the close came from the keyboard', () => {
const { events, result, open } = renderReturnFocus(trigger);
open(true);

events.close(new KeyboardEvent('keydown', { key: 'Escape' }));

expect(result.current.current).toBe(trigger);
});

it('keeps the trigger when the close came from a control inside the popup', () => {
const { events, result, open } = renderReturnFocus(trigger);
open(true);

// A Close button or menu item routes through the consumer's own state setter,
// so floating-ui reports the change with no event behind it.
events.close();

expect(result.current.current).toBe(trigger);
});

it('leaves focus alone when the close came from a pointer', () => {
const { events, result, open } = renderReturnFocus(trigger);
open(true);

events.close(new MouseEvent('mousedown', { detail: 1 }));

expect(result.current.current).toBeNull();
});

it('restores the trigger on the next open', () => {
const { events, result, open } = renderReturnFocus(trigger);
open(true);
events.close(new MouseEvent('mousedown', { detail: 1 }));

open(false);
open(true);

expect(result.current.current).toBe(trigger);
});
});
49 changes: 49 additions & 0 deletions packages/headless/src/hooks/use-return-focus.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,49 @@
'use client';

import type { FloatingContext } from '@floating-ui/react';
import { useEffect, useRef } from 'react';

import { isKeyboardEvent } from '../utils/interaction-modality';

/**
* The element `FloatingFocusManager` restores focus to when the floating element closes.
*
* The trigger is the default, which is what a keyboard user needs. Safari never focuses a
* button it was clicked on, so after a pointer dismiss the popup is the only thing the page
* has focused: restoring focus to the trigger then matches `:focus-visible` and paints a ring
* the user never asked for. A pointer dismiss therefore resolves to `null`, which leaves focus
* where the pointer left it, the same choice Base UI makes from its close interaction type.
*
* Pass the result to `FloatingFocusManager`'s `returnFocus`. On `null` it falls back to the
* hidden guard element it keeps next to the trigger, so the tab position survives; verify that
* still holds when upgrading `@floating-ui/react`.
*/
export function useReturnFocus(
context: Pick<FloatingContext, 'open' | 'events' | 'elements'>,
): React.MutableRefObject<HTMLElement | null> {
const { open, events, elements } = context;
const returnFocusRef = useRef<HTMLElement | null>(null);
const trigger = elements.domReference;

useEffect(() => {
if (open) {
returnFocusRef.current = trigger instanceof HTMLElement ? trigger : null;
}
}, [open, trigger]);

useEffect(() => {
// Closes routed straight through the consumer's own state setter (a Close button, an
// item click) never reach floating-ui, so only what floating-ui itself drives can
// downgrade the default.
function onOpenChange({ open, event }: { open: boolean; event?: Event }) {
if (!open && event && !isKeyboardEvent(event)) {
returnFocusRef.current = null;
}
}

events.on('openchange', onOpenChange);
return () => events.off('openchange', onOpenChange);
}, [events]);

return returnFocusRef;
}
Original file line numberDiff line numberDiff line change
Expand Up@@ -643,6 +643,7 @@ describe('Autocomplete', () => {

return (
<Popover.Root
initialFocus='first'
open={popoverOpen}
onOpenChange={open => {
setPopoverOpen(open);
Expand DownExpand Up@@ -786,6 +787,7 @@ describe('Autocomplete', () => {

return (
<Popover.Root
initialFocus='first'
open={popoverOpen}
onOpenChange={open => {
setPopoverOpen(open);
Expand DownExpand Up@@ -880,6 +882,7 @@ describe('Autocomplete', () => {

return (
<Popover.Root
initialFocus='first'
open={popoverOpen}
onOpenChange={open => {
setPopoverOpen(open);
Expand Down
2 changes: 2 additions & 0 deletions packages/headless/src/primitives/dialog/dialog-context.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -11,6 +11,8 @@ export interface DialogContextValue {
getReferenceProps: UseInteractionsReturn['getReferenceProps'];
getFloatingProps: UseInteractionsReturn['getFloatingProps'];
popupRef: React.RefObject<HTMLDivElement | null>;
/** Where focus goes when the dialog closes, or `null` to leave focus alone. */
returnFocusRef: React.MutableRefObject<HTMLElement | null>;
modal: boolean;
labelId: string;
descriptionId: string;
Expand Down
15 changes: 13 additions & 2 deletions packages/headless/src/primitives/dialog/dialog-popup.tsx
Original file line numberDiff line numberDiff line change
Expand Up@@ -12,8 +12,18 @@ export type DialogPopupProps = ComponentProps<'div'>;
/** The dialog content container. Manages focus trapping via `FloatingFocusManager` and wires ARIA attributes from `Dialog.Title` and `Dialog.Description`. */
export const DialogPopup = React.forwardRef<HTMLDivElement, DialogPopupProps>(function DialogPopup(props, ref) {
const { render, ...otherProps } = props;
const { popupRef, refs, getFloatingProps, floatingContext, modal, labelId, descriptionId, mounted, transitionProps } =
useDialogContext();
const {
popupRef,
refs,
getFloatingProps,
floatingContext,
modal,
returnFocusRef,
labelId,
descriptionId,
mounted,
transitionProps,
} = useDialogContext();

const ownProps = {
'aria-labelledby': labelId,
Expand DownExpand Up@@ -43,6 +53,7 @@ export const DialogPopup = React.forwardRef<HTMLDivElement, DialogPopupProps>(fu
context={floatingContext}
modal={modal}
outsideElementsInert={modal}
returnFocus={returnFocusRef}
>
{element}
</FloatingFocusManager>
Expand Down
5 changes: 5 additions & 0 deletions packages/headless/src/primitives/dialog/dialog-root.tsx
Original file line numberDiff line numberDiff line change
Expand Up@@ -14,6 +14,7 @@ import {
import { type ReactNode, useId, useMemo, useRef } from 'react';

import { useControllableState } from '../../hooks/use-controllable-state';
import { useReturnFocus } from '../../hooks/use-return-focus';
import { useTransition } from '../../hooks/use-transition';
import { DialogContext, type DialogContextValue } from './dialog-context';

Expand DownExpand Up@@ -43,6 +44,8 @@ function DialogInner(props: DialogProps) {
onOpenChange: setOpen,
});

const returnFocusRef = useReturnFocus(floatingContext);

const { mounted, transitionProps } = useTransition({
open,
ref: popupRef,
Expand All@@ -65,6 +68,7 @@ function DialogInner(props: DialogProps) {
getReferenceProps,
getFloatingProps,
popupRef,
returnFocusRef,
modal,
labelId,
descriptionId,
Expand All@@ -78,6 +82,7 @@ function DialogInner(props: DialogProps) {
refs,
getReferenceProps,
getFloatingProps,
returnFocusRef,
modal,
labelId,
descriptionId,
Expand Down
2 changes: 2 additions & 0 deletions packages/headless/src/primitives/drawer/drawer-popup.tsx
Original file line numberDiff line numberDiff line change
Expand Up@@ -24,6 +24,7 @@ export const DrawerPopup = React.forwardRef<HTMLDivElement, DrawerPopupProps>(fu
getFloatingProps,
floatingContext,
modal,
returnFocusRef,
labelId,
descriptionId,
mounted,
Expand DownExpand Up@@ -107,6 +108,7 @@ export const DrawerPopup = React.forwardRef<HTMLDivElement, DrawerPopupProps>(fu
modal={modal}
outsideElementsInert={modal}
initialFocus={autoFocus ? undefined : popupRef}
returnFocus={returnFocusRef}
>
{element}
</FloatingFocusManager>
Expand Down
5 changes: 5 additions & 0 deletions packages/headless/src/primitives/drawer/drawer-root.tsx
Original file line numberDiff line numberDiff line change
Expand Up@@ -14,6 +14,7 @@ import {
import { type ReactNode, useCallback, useEffect, useId, useMemo, useRef, useState } from 'react';

import { useControllableState } from '../../hooks/use-controllable-state';
import { useReturnFocus } from '../../hooks/use-return-focus';
import { useTransition } from '../../hooks/use-transition';
import { DrawerAttrs, DrawerCssVars, registerDrawerCssVars } from './css-vars';
import {
Expand DownExpand Up@@ -119,6 +120,8 @@ function DrawerInner(props: DrawerProps) {
onOpenChange: setOpen,
});

const returnFocusRef = useReturnFocus(floatingContext);

const { mounted, transitionProps } = useTransition({ open, ref: popupRef });

const click = useClick(floatingContext);
Expand DownExpand Up@@ -223,6 +226,7 @@ function DrawerInner(props: DrawerProps) {
getFloatingProps,
popupRef,
backdropRef,
returnFocusRef,
modal,
labelId,
descriptionId,
Expand All@@ -247,6 +251,7 @@ function DrawerInner(props: DrawerProps) {
refs,
getReferenceProps,
getFloatingProps,
returnFocusRef,
modal,
labelId,
descriptionId,
Expand Down
2 changes: 2 additions & 0 deletions packages/headless/src/primitives/menu/menu-context.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -24,6 +24,8 @@ export interface MenuContextValue {
labelsRef: React.MutableRefObject<Array<string | null>>;
arrowRef: React.MutableRefObject<SVGSVGElement | null>;
popupRef: React.RefObject<HTMLDivElement | null>;
/** Where focus goes when the menu closes, or `null` to leave focus alone. */
returnFocusRef: React.MutableRefObject<HTMLElement | null>;
isNested: boolean;
mounted: boolean;
transitionProps: TransitionProps;
Expand Down
7 changes: 4 additions & 3 deletions packages/headless/src/primitives/menu/menu-positioner.tsx
Original file line numberDiff line numberDiff line change
Expand Up@@ -3,7 +3,7 @@
import { FloatingFocusManager, FloatingList } from '@floating-ui/react';
import React from 'react';

import { type ComponentProps, type DefaultProps, mergeProps, useRender } from '../../utils';
import { type ComponentProps, type DefaultProps, isKeyboardOpen, mergeProps, useRender } from '../../utils';
import { useMenuContext } from './menu-context';

export type MenuPositionerProps = ComponentProps<'div'>;
Expand All@@ -21,6 +21,7 @@ export const MenuPositioner = React.forwardRef<HTMLDivElement, MenuPositionerPro
elementsRef,
labelsRef,
isNested,
returnFocusRef,
setActiveIndex,
} = useMenuContext();

Expand DownExpand Up@@ -83,8 +84,8 @@ export const MenuPositioner = React.forwardRef<HTMLDivElement, MenuPositionerPro
<FloatingFocusManager
context={floatingContext}
modal={false}
initialFocus={isNested ? -1 : 0}
returnFocus={!isNested}
initialFocus={isNested ? -1 : isKeyboardOpen(floatingContext) ? 0 : refs.floating}
returnFocus={isNested ? false : returnFocusRef}
>
<FloatingList
elementsRef={elementsRef}
Expand Down
5 changes: 5 additions & 0 deletions packages/headless/src/primitives/menu/menu-root.tsx
Original file line numberDiff line numberDiff line change
Expand Up@@ -25,6 +25,7 @@ import {
import { type ReactNode, useContext, useEffect, useMemo, useRef, useState } from 'react';

import { useControllableState } from '../../hooks/use-controllable-state';
import { useReturnFocus } from '../../hooks/use-return-focus';
import { useTransition } from '../../hooks/use-transition';
import { cssVars } from '../../utils/css-vars';
import { MenuContext, type MenuContextValue } from './menu-context';
Expand DownExpand Up@@ -85,6 +86,8 @@ function MenuInner(props: MenuProps) {
whileElementsMounted: autoUpdate,
});

const returnFocusRef = useReturnFocus(floatingContext);

const { mounted, transitionProps } = useTransition({
open,
ref: popupRef,
Expand DownExpand Up@@ -179,6 +182,7 @@ function MenuInner(props: MenuProps) {
labelsRef,
arrowRef,
popupRef,
returnFocusRef,
isNested,
mounted,
transitionProps,
Expand All@@ -194,6 +198,7 @@ function MenuInner(props: MenuProps) {
getFloatingProps,
getItemProps,
activeIndex,
returnFocusRef,
isNested,
mounted,
transitionProps,
Expand Down
Loading
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers"); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .changeset/headless-return-focus.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
---
---
98 changes: 98 additions & 0 deletions packages/headless/src/hooks/use-return-focus.test.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,98 @@
import type { FloatingEvents } from '@floating-ui/react';
import { renderHook } from '@testing-library/react';
import { afterEach, beforeEach, describe, expect, it } from 'vitest';

import { useReturnFocus } from './use-return-focus';

function createEvents(): FloatingEvents & { close: (event?: Event) => void } {
const handlers = new Map<string, Array<(data: unknown) => void>>();

return {
emit(event, data) {
handlers.get(event)?.forEach(handler => handler(data));
},
on(event, handler) {
handlers.set(event, [...(handlers.get(event) ?? []), handler]);
},
off(event, handler) {
handlers.set(
event,
(handlers.get(event) ?? []).filter(h => h !== handler),
);
},
close(event) {
this.emit('openchange', { open: false, event });
},
};
}

function renderReturnFocus(trigger: HTMLElement) {
const events = createEvents();

const { result, rerender } = renderHook(
({ open }: { open: boolean }) =>
useReturnFocus({ open, events, elements: { domReference: trigger, reference: trigger, floating: null } }),
{ initialProps: { open: false } },
);

return { events, result, open: (open: boolean) => rerender({ open }) };
}

let trigger: HTMLElement;

afterEach(() => trigger?.remove());

describe('useReturnFocus', () => {
beforeEach(() => {
trigger = document.createElement('button');
document.body.append(trigger);
});

it('resolves to the trigger while open', () => {
const { result, open } = renderReturnFocus(trigger);

open(true);

expect(result.current.current).toBe(trigger);
});

it('keeps the trigger when the close came from the keyboard', () => {
const { events, result, open } = renderReturnFocus(trigger);
open(true);

events.close(new KeyboardEvent('keydown', { key: 'Escape' }));

expect(result.current.current).toBe(trigger);
});

it('keeps the trigger when the close came from a control inside the popup', () => {
const { events, result, open } = renderReturnFocus(trigger);
open(true);

// A Close button or menu item routes through the consumer's own state setter,
// so floating-ui reports the change with no event behind it.
events.close();

expect(result.current.current).toBe(trigger);
});

it('leaves focus alone when the close came from a pointer', () => {
const { events, result, open } = renderReturnFocus(trigger);
open(true);

events.close(new MouseEvent('mousedown', { detail: 1 }));

expect(result.current.current).toBeNull();
});

it('restores the trigger on the next open', () => {
const { events, result, open } = renderReturnFocus(trigger);
open(true);
events.close(new MouseEvent('mousedown', { detail: 1 }));

open(false);
open(true);

expect(result.current.current).toBe(trigger);
});
});
49 changes: 49 additions & 0 deletions packages/headless/src/hooks/use-return-focus.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,49 @@
'use client';

import type { FloatingContext } from '@floating-ui/react';
import { useEffect, useRef } from 'react';

import { isKeyboardEvent } from '../utils/interaction-modality';

/**
* The element `FloatingFocusManager` restores focus to when the floating element closes.
*
* The trigger is the default, which is what a keyboard user needs. Safari never focuses a
* button it was clicked on, so after a pointer dismiss the popup is the only thing the page
* has focused: restoring focus to the trigger then matches `:focus-visible` and paints a ring
* the user never asked for. A pointer dismiss therefore resolves to `null`, which leaves focus
* where the pointer left it, the same choice Base UI makes from its close interaction type.
*
* Pass the result to `FloatingFocusManager`'s `returnFocus`. On `null` it falls back to the
* hidden guard element it keeps next to the trigger, so the tab position survives; verify that
* still holds when upgrading `@floating-ui/react`.
*/
export function useReturnFocus(
context: Pick<FloatingContext, 'open' | 'events' | 'elements'>,
): React.MutableRefObject<HTMLElement | null> {
const { open, events, elements } = context;
const returnFocusRef = useRef<HTMLElement | null>(null);
const trigger = elements.domReference;

useEffect(() => {
if (open) {
returnFocusRef.current = trigger instanceof HTMLElement ? trigger : null;
}
}, [open, trigger]);

useEffect(() => {
// Closes routed straight through the consumer's own state setter (a Close button, an
// item click) never reach floating-ui, so only what floating-ui itself drives can
// downgrade the default.
function onOpenChange({ open, event }: { open: boolean; event?: Event }) {
if (!open && event && !isKeyboardEvent(event)) {
returnFocusRef.current = null;
}
}

events.on('openchange', onOpenChange);
return () => events.off('openchange', onOpenChange);
}, [events]);

return returnFocusRef;
}
Original file line numberDiff line numberDiff line change
Expand Up@@ -643,6 +643,7 @@ describe('Autocomplete', () => {

return (
<Popover.Root
initialFocus='first'
open={popoverOpen}
onOpenChange={open => {
setPopoverOpen(open);
Expand DownExpand Up@@ -786,6 +787,7 @@ describe('Autocomplete', () => {

return (
<Popover.Root
initialFocus='first'
open={popoverOpen}
onOpenChange={open => {
setPopoverOpen(open);
Expand DownExpand Up@@ -880,6 +882,7 @@ describe('Autocomplete', () => {

return (
<Popover.Root
initialFocus='first'
open={popoverOpen}
onOpenChange={open => {
setPopoverOpen(open);
Expand Down
2 changes: 2 additions & 0 deletions packages/headless/src/primitives/dialog/dialog-context.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -11,6 +11,8 @@ export interface DialogContextValue {
getReferenceProps: UseInteractionsReturn['getReferenceProps'];
getFloatingProps: UseInteractionsReturn['getFloatingProps'];
popupRef: React.RefObject<HTMLDivElement | null>;
/** Where focus goes when the dialog closes, or `null` to leave focus alone. */
returnFocusRef: React.MutableRefObject<HTMLElement | null>;
modal: boolean;
labelId: string;
descriptionId: string;
Expand Down
15 changes: 13 additions & 2 deletions packages/headless/src/primitives/dialog/dialog-popup.tsx
Original file line numberDiff line numberDiff line change
Expand Up@@ -12,8 +12,18 @@ export type DialogPopupProps = ComponentProps<'div'>;
/** The dialog content container. Manages focus trapping via `FloatingFocusManager` and wires ARIA attributes from `Dialog.Title` and `Dialog.Description`. */
export const DialogPopup = React.forwardRef<HTMLDivElement, DialogPopupProps>(function DialogPopup(props, ref) {
const { render, ...otherProps } = props;
const { popupRef, refs, getFloatingProps, floatingContext, modal, labelId, descriptionId, mounted, transitionProps } =
useDialogContext();
const {
popupRef,
refs,
getFloatingProps,
floatingContext,
modal,
returnFocusRef,
labelId,
descriptionId,
mounted,
transitionProps,
} = useDialogContext();

const ownProps = {
'aria-labelledby': labelId,
Expand DownExpand Up@@ -43,6 +53,7 @@ export const DialogPopup = React.forwardRef<HTMLDivElement, DialogPopupProps>(fu
context={floatingContext}
modal={modal}
outsideElementsInert={modal}
returnFocus={returnFocusRef}
>
{element}
</FloatingFocusManager>
Expand Down
5 changes: 5 additions & 0 deletions packages/headless/src/primitives/dialog/dialog-root.tsx
Original file line numberDiff line numberDiff line change
Expand Up@@ -14,6 +14,7 @@ import {
import { type ReactNode, useId, useMemo, useRef } from 'react';

import { useControllableState } from '../../hooks/use-controllable-state';
import { useReturnFocus } from '../../hooks/use-return-focus';
import { useTransition } from '../../hooks/use-transition';
import { DialogContext, type DialogContextValue } from './dialog-context';

Expand DownExpand Up@@ -43,6 +44,8 @@ function DialogInner(props: DialogProps) {
onOpenChange: setOpen,
});

const returnFocusRef = useReturnFocus(floatingContext);

const { mounted, transitionProps } = useTransition({
open,
ref: popupRef,
Expand All@@ -65,6 +68,7 @@ function DialogInner(props: DialogProps) {
getReferenceProps,
getFloatingProps,
popupRef,
returnFocusRef,
modal,
labelId,
descriptionId,
Expand All@@ -78,6 +82,7 @@ function DialogInner(props: DialogProps) {
refs,
getReferenceProps,
getFloatingProps,
returnFocusRef,
modal,
labelId,
descriptionId,
Expand Down
2 changes: 2 additions & 0 deletions packages/headless/src/primitives/drawer/drawer-popup.tsx
Original file line numberDiff line numberDiff line change
Expand Up@@ -24,6 +24,7 @@ export const DrawerPopup = React.forwardRef<HTMLDivElement, DrawerPopupProps>(fu
getFloatingProps,
floatingContext,
modal,
returnFocusRef,
labelId,
descriptionId,
mounted,
Expand DownExpand Up@@ -107,6 +108,7 @@ export const DrawerPopup = React.forwardRef<HTMLDivElement, DrawerPopupProps>(fu
modal={modal}
outsideElementsInert={modal}
initialFocus={autoFocus ? undefined : popupRef}
returnFocus={returnFocusRef}
>
{element}
</FloatingFocusManager>
Expand Down
5 changes: 5 additions & 0 deletions packages/headless/src/primitives/drawer/drawer-root.tsx
Original file line numberDiff line numberDiff line change
Expand Up@@ -14,6 +14,7 @@ import {
import { type ReactNode, useCallback, useEffect, useId, useMemo, useRef, useState } from 'react';

import { useControllableState } from '../../hooks/use-controllable-state';
import { useReturnFocus } from '../../hooks/use-return-focus';
import { useTransition } from '../../hooks/use-transition';
import { DrawerAttrs, DrawerCssVars, registerDrawerCssVars } from './css-vars';
import {
Expand DownExpand Up@@ -119,6 +120,8 @@ function DrawerInner(props: DrawerProps) {
onOpenChange: setOpen,
});

const returnFocusRef = useReturnFocus(floatingContext);

const { mounted, transitionProps } = useTransition({ open, ref: popupRef });

const click = useClick(floatingContext);
Expand DownExpand Up@@ -223,6 +226,7 @@ function DrawerInner(props: DrawerProps) {
getFloatingProps,
popupRef,
backdropRef,
returnFocusRef,
modal,
labelId,
descriptionId,
Expand All@@ -247,6 +251,7 @@ function DrawerInner(props: DrawerProps) {
refs,
getReferenceProps,
getFloatingProps,
returnFocusRef,
modal,
labelId,
descriptionId,
Expand Down
2 changes: 2 additions & 0 deletions packages/headless/src/primitives/menu/menu-context.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -24,6 +24,8 @@ export interface MenuContextValue {
labelsRef: React.MutableRefObject<Array<string | null>>;
arrowRef: React.MutableRefObject<SVGSVGElement | null>;
popupRef: React.RefObject<HTMLDivElement | null>;
/** Where focus goes when the menu closes, or `null` to leave focus alone. */
returnFocusRef: React.MutableRefObject<HTMLElement | null>;
isNested: boolean;
mounted: boolean;
transitionProps: TransitionProps;
Expand Down
7 changes: 4 additions & 3 deletions packages/headless/src/primitives/menu/menu-positioner.tsx
Original file line numberDiff line numberDiff line change
Expand Up@@ -3,7 +3,7 @@
import { FloatingFocusManager, FloatingList } from '@floating-ui/react';
import React from 'react';

import { type ComponentProps, type DefaultProps, mergeProps, useRender } from '../../utils';
import { type ComponentProps, type DefaultProps, isKeyboardOpen, mergeProps, useRender } from '../../utils';
import { useMenuContext } from './menu-context';

export type MenuPositionerProps = ComponentProps<'div'>;
Expand All@@ -21,6 +21,7 @@ export const MenuPositioner = React.forwardRef<HTMLDivElement, MenuPositionerPro
elementsRef,
labelsRef,
isNested,
returnFocusRef,
setActiveIndex,
} = useMenuContext();

Expand DownExpand Up@@ -83,8 +84,8 @@ export const MenuPositioner = React.forwardRef<HTMLDivElement, MenuPositionerPro
<FloatingFocusManager
context={floatingContext}
modal={false}
initialFocus={isNested ? -1 : 0}
returnFocus={!isNested}
initialFocus={isNested ? -1 : isKeyboardOpen(floatingContext) ? 0 : refs.floating}
returnFocus={isNested ? false : returnFocusRef}
>
<FloatingList
elementsRef={elementsRef}
Expand Down
5 changes: 5 additions & 0 deletions packages/headless/src/primitives/menu/menu-root.tsx
Original file line numberDiff line numberDiff line change
Expand Up@@ -25,6 +25,7 @@ import {
import { type ReactNode, useContext, useEffect, useMemo, useRef, useState } from 'react';

import { useControllableState } from '../../hooks/use-controllable-state';
import { useReturnFocus } from '../../hooks/use-return-focus';
import { useTransition } from '../../hooks/use-transition';
import { cssVars } from '../../utils/css-vars';
import { MenuContext, type MenuContextValue } from './menu-context';
Expand DownExpand Up@@ -85,6 +86,8 @@ function MenuInner(props: MenuProps) {
whileElementsMounted: autoUpdate,
});

const returnFocusRef = useReturnFocus(floatingContext);

const { mounted, transitionProps } = useTransition({
open,
ref: popupRef,
Expand DownExpand Up@@ -179,6 +182,7 @@ function MenuInner(props: MenuProps) {
labelsRef,
arrowRef,
popupRef,
returnFocusRef,
isNested,
mounted,
transitionProps,
Expand All@@ -194,6 +198,7 @@ function MenuInner(props: MenuProps) {
getFloatingProps,
getItemProps,
activeIndex,
returnFocusRef,
isNested,
mounted,
transitionProps,
Expand Down
Loading
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode"); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })();
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .changeset/headless-return-focus.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
---
---
98 changes: 98 additions & 0 deletions packages/headless/src/hooks/use-return-focus.test.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,98 @@
import type { FloatingEvents } from '@floating-ui/react';
import { renderHook } from '@testing-library/react';
import { afterEach, beforeEach, describe, expect, it } from 'vitest';

import { useReturnFocus } from './use-return-focus';

function createEvents(): FloatingEvents & { close: (event?: Event) => void } {
const handlers = new Map<string, Array<(data: unknown) => void>>();

return {
emit(event, data) {
handlers.get(event)?.forEach(handler => handler(data));
},
on(event, handler) {
handlers.set(event, [...(handlers.get(event) ?? []), handler]);
},
off(event, handler) {
handlers.set(
event,
(handlers.get(event) ?? []).filter(h => h !== handler),
);
},
close(event) {
this.emit('openchange', { open: false, event });
},
};
}

function renderReturnFocus(trigger: HTMLElement) {
const events = createEvents();

const { result, rerender } = renderHook(
({ open }: { open: boolean }) =>
useReturnFocus({ open, events, elements: { domReference: trigger, reference: trigger, floating: null } }),
{ initialProps: { open: false } },
);

return { events, result, open: (open: boolean) => rerender({ open }) };
}

let trigger: HTMLElement;

afterEach(() => trigger?.remove());

describe('useReturnFocus', () => {
beforeEach(() => {
trigger = document.createElement('button');
document.body.append(trigger);
});

it('resolves to the trigger while open', () => {
const { result, open } = renderReturnFocus(trigger);

open(true);

expect(result.current.current).toBe(trigger);
});

it('keeps the trigger when the close came from the keyboard', () => {
const { events, result, open } = renderReturnFocus(trigger);
open(true);

events.close(new KeyboardEvent('keydown', { key: 'Escape' }));

expect(result.current.current).toBe(trigger);
});

it('keeps the trigger when the close came from a control inside the popup', () => {
const { events, result, open } = renderReturnFocus(trigger);
open(true);

// A Close button or menu item routes through the consumer's own state setter,
// so floating-ui reports the change with no event behind it.
events.close();

expect(result.current.current).toBe(trigger);
});

it('leaves focus alone when the close came from a pointer', () => {
const { events, result, open } = renderReturnFocus(trigger);
open(true);

events.close(new MouseEvent('mousedown', { detail: 1 }));

expect(result.current.current).toBeNull();
});

it('restores the trigger on the next open', () => {
const { events, result, open } = renderReturnFocus(trigger);
open(true);
events.close(new MouseEvent('mousedown', { detail: 1 }));

open(false);
open(true);

expect(result.current.current).toBe(trigger);
});
});
49 changes: 49 additions & 0 deletions packages/headless/src/hooks/use-return-focus.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,49 @@
'use client';

import type { FloatingContext } from '@floating-ui/react';
import { useEffect, useRef } from 'react';

import { isKeyboardEvent } from '../utils/interaction-modality';

/**
* The element `FloatingFocusManager` restores focus to when the floating element closes.
*
* The trigger is the default, which is what a keyboard user needs. Safari never focuses a
* button it was clicked on, so after a pointer dismiss the popup is the only thing the page
* has focused: restoring focus to the trigger then matches `:focus-visible` and paints a ring
* the user never asked for. A pointer dismiss therefore resolves to `null`, which leaves focus
* where the pointer left it, the same choice Base UI makes from its close interaction type.
*
* Pass the result to `FloatingFocusManager`'s `returnFocus`. On `null` it falls back to the
* hidden guard element it keeps next to the trigger, so the tab position survives; verify that
* still holds when upgrading `@floating-ui/react`.
*/
export function useReturnFocus(
context: Pick<FloatingContext, 'open' | 'events' | 'elements'>,
): React.MutableRefObject<HTMLElement | null> {
const { open, events, elements } = context;
const returnFocusRef = useRef<HTMLElement | null>(null);
const trigger = elements.domReference;

useEffect(() => {
if (open) {
returnFocusRef.current = trigger instanceof HTMLElement ? trigger : null;
}
}, [open, trigger]);

useEffect(() => {
// Closes routed straight through the consumer's own state setter (a Close button, an
// item click) never reach floating-ui, so only what floating-ui itself drives can
// downgrade the default.
function onOpenChange({ open, event }: { open: boolean; event?: Event }) {
if (!open && event && !isKeyboardEvent(event)) {
returnFocusRef.current = null;
}
}

events.on('openchange', onOpenChange);
return () => events.off('openchange', onOpenChange);
}, [events]);

return returnFocusRef;
}
Original file line numberDiff line numberDiff line change
Expand Up@@ -643,6 +643,7 @@ describe('Autocomplete', () => {

return (
<Popover.Root
initialFocus='first'
open={popoverOpen}
onOpenChange={open => {
setPopoverOpen(open);
Expand DownExpand Up@@ -786,6 +787,7 @@ describe('Autocomplete', () => {

return (
<Popover.Root
initialFocus='first'
open={popoverOpen}
onOpenChange={open => {
setPopoverOpen(open);
Expand DownExpand Up@@ -880,6 +882,7 @@ describe('Autocomplete', () => {

return (
<Popover.Root
initialFocus='first'
open={popoverOpen}
onOpenChange={open => {
setPopoverOpen(open);
Expand Down
2 changes: 2 additions & 0 deletions packages/headless/src/primitives/dialog/dialog-context.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -11,6 +11,8 @@ export interface DialogContextValue {
getReferenceProps: UseInteractionsReturn['getReferenceProps'];
getFloatingProps: UseInteractionsReturn['getFloatingProps'];
popupRef: React.RefObject<HTMLDivElement | null>;
/** Where focus goes when the dialog closes, or `null` to leave focus alone. */
returnFocusRef: React.MutableRefObject<HTMLElement | null>;
modal: boolean;
labelId: string;
descriptionId: string;
Expand Down
15 changes: 13 additions & 2 deletions packages/headless/src/primitives/dialog/dialog-popup.tsx
Original file line numberDiff line numberDiff line change
Expand Up@@ -12,8 +12,18 @@ export type DialogPopupProps = ComponentProps<'div'>;
/** The dialog content container. Manages focus trapping via `FloatingFocusManager` and wires ARIA attributes from `Dialog.Title` and `Dialog.Description`. */
export const DialogPopup = React.forwardRef<HTMLDivElement, DialogPopupProps>(function DialogPopup(props, ref) {
const { render, ...otherProps } = props;
const { popupRef, refs, getFloatingProps, floatingContext, modal, labelId, descriptionId, mounted, transitionProps } =
useDialogContext();
const {
popupRef,
refs,
getFloatingProps,
floatingContext,
modal,
returnFocusRef,
labelId,
descriptionId,
mounted,
transitionProps,
} = useDialogContext();

const ownProps = {
'aria-labelledby': labelId,
Expand DownExpand Up@@ -43,6 +53,7 @@ export const DialogPopup = React.forwardRef<HTMLDivElement, DialogPopupProps>(fu
context={floatingContext}
modal={modal}
outsideElementsInert={modal}
returnFocus={returnFocusRef}
>
{element}
</FloatingFocusManager>
Expand Down
5 changes: 5 additions & 0 deletions packages/headless/src/primitives/dialog/dialog-root.tsx
Original file line numberDiff line numberDiff line change
Expand Up@@ -14,6 +14,7 @@ import {
import { type ReactNode, useId, useMemo, useRef } from 'react';

import { useControllableState } from '../../hooks/use-controllable-state';
import { useReturnFocus } from '../../hooks/use-return-focus';
import { useTransition } from '../../hooks/use-transition';
import { DialogContext, type DialogContextValue } from './dialog-context';

Expand DownExpand Up@@ -43,6 +44,8 @@ function DialogInner(props: DialogProps) {
onOpenChange: setOpen,
});

const returnFocusRef = useReturnFocus(floatingContext);

const { mounted, transitionProps } = useTransition({
open,
ref: popupRef,
Expand All@@ -65,6 +68,7 @@ function DialogInner(props: DialogProps) {
getReferenceProps,
getFloatingProps,
popupRef,
returnFocusRef,
modal,
labelId,
descriptionId,
Expand All@@ -78,6 +82,7 @@ function DialogInner(props: DialogProps) {
refs,
getReferenceProps,
getFloatingProps,
returnFocusRef,
modal,
labelId,
descriptionId,
Expand Down
2 changes: 2 additions & 0 deletions packages/headless/src/primitives/drawer/drawer-popup.tsx
Original file line numberDiff line numberDiff line change
Expand Up@@ -24,6 +24,7 @@ export const DrawerPopup = React.forwardRef<HTMLDivElement, DrawerPopupProps>(fu
getFloatingProps,
floatingContext,
modal,
returnFocusRef,
labelId,
descriptionId,
mounted,
Expand DownExpand Up@@ -107,6 +108,7 @@ export const DrawerPopup = React.forwardRef<HTMLDivElement, DrawerPopupProps>(fu
modal={modal}
outsideElementsInert={modal}
initialFocus={autoFocus ? undefined : popupRef}
returnFocus={returnFocusRef}
>
{element}
</FloatingFocusManager>
Expand Down
5 changes: 5 additions & 0 deletions packages/headless/src/primitives/drawer/drawer-root.tsx
Original file line numberDiff line numberDiff line change
Expand Up@@ -14,6 +14,7 @@ import {
import { type ReactNode, useCallback, useEffect, useId, useMemo, useRef, useState } from 'react';

import { useControllableState } from '../../hooks/use-controllable-state';
import { useReturnFocus } from '../../hooks/use-return-focus';
import { useTransition } from '../../hooks/use-transition';
import { DrawerAttrs, DrawerCssVars, registerDrawerCssVars } from './css-vars';
import {
Expand DownExpand Up@@ -119,6 +120,8 @@ function DrawerInner(props: DrawerProps) {
onOpenChange: setOpen,
});

const returnFocusRef = useReturnFocus(floatingContext);

const { mounted, transitionProps } = useTransition({ open, ref: popupRef });

const click = useClick(floatingContext);
Expand DownExpand Up@@ -223,6 +226,7 @@ function DrawerInner(props: DrawerProps) {
getFloatingProps,
popupRef,
backdropRef,
returnFocusRef,
modal,
labelId,
descriptionId,
Expand All@@ -247,6 +251,7 @@ function DrawerInner(props: DrawerProps) {
refs,
getReferenceProps,
getFloatingProps,
returnFocusRef,
modal,
labelId,
descriptionId,
Expand Down
2 changes: 2 additions & 0 deletions packages/headless/src/primitives/menu/menu-context.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -24,6 +24,8 @@ export interface MenuContextValue {
labelsRef: React.MutableRefObject<Array<string | null>>;
arrowRef: React.MutableRefObject<SVGSVGElement | null>;
popupRef: React.RefObject<HTMLDivElement | null>;
/** Where focus goes when the menu closes, or `null` to leave focus alone. */
returnFocusRef: React.MutableRefObject<HTMLElement | null>;
isNested: boolean;
mounted: boolean;
transitionProps: TransitionProps;
Expand Down
7 changes: 4 additions & 3 deletions packages/headless/src/primitives/menu/menu-positioner.tsx
Original file line numberDiff line numberDiff line change
Expand Up@@ -3,7 +3,7 @@
import { FloatingFocusManager, FloatingList } from '@floating-ui/react';
import React from 'react';

import { type ComponentProps, type DefaultProps, mergeProps, useRender } from '../../utils';
import { type ComponentProps, type DefaultProps, isKeyboardOpen, mergeProps, useRender } from '../../utils';
import { useMenuContext } from './menu-context';

export type MenuPositionerProps = ComponentProps<'div'>;
Expand All@@ -21,6 +21,7 @@ export const MenuPositioner = React.forwardRef<HTMLDivElement, MenuPositionerPro
elementsRef,
labelsRef,
isNested,
returnFocusRef,
setActiveIndex,
} = useMenuContext();

Expand DownExpand Up@@ -83,8 +84,8 @@ export const MenuPositioner = React.forwardRef<HTMLDivElement, MenuPositionerPro
<FloatingFocusManager
context={floatingContext}
modal={false}
initialFocus={isNested ? -1 : 0}
returnFocus={!isNested}
initialFocus={isNested ? -1 : isKeyboardOpen(floatingContext) ? 0 : refs.floating}
returnFocus={isNested ? false : returnFocusRef}
>
<FloatingList
elementsRef={elementsRef}
Expand Down
5 changes: 5 additions & 0 deletions packages/headless/src/primitives/menu/menu-root.tsx
Original file line numberDiff line numberDiff line change
Expand Up@@ -25,6 +25,7 @@ import {
import { type ReactNode, useContext, useEffect, useMemo, useRef, useState } from 'react';

import { useControllableState } from '../../hooks/use-controllable-state';
import { useReturnFocus } from '../../hooks/use-return-focus';
import { useTransition } from '../../hooks/use-transition';
import { cssVars } from '../../utils/css-vars';
import { MenuContext, type MenuContextValue } from './menu-context';
Expand DownExpand Up@@ -85,6 +86,8 @@ function MenuInner(props: MenuProps) {
whileElementsMounted: autoUpdate,
});

const returnFocusRef = useReturnFocus(floatingContext);

const { mounted, transitionProps } = useTransition({
open,
ref: popupRef,
Expand DownExpand Up@@ -179,6 +182,7 @@ function MenuInner(props: MenuProps) {
labelsRef,
arrowRef,
popupRef,
returnFocusRef,
isNested,
mounted,
transitionProps,
Expand All@@ -194,6 +198,7 @@ function MenuInner(props: MenuProps) {
getFloatingProps,
getItemProps,
activeIndex,
returnFocusRef,
isNested,
mounted,
transitionProps,
Expand Down
Loading
Loading