Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/tidy-device-trust-methods.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
---
'@clerk/ui': patch
---

Hide the “Use another method” action during Device Trust and second-factor verification when no alternative verification method is available.
1 change: 1 addition & 0 deletions integration/tests/client-trust.test.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -38,6 +38,7 @@ testAgainstRunningApps({ withEnv: [appConfigs.envs.withNeedsClientTrust] })(

// Should contain the new device verification notice
await expect(u.page.getByText("You're signing in from a new device.")).toBeVisible();
await expect(u.page.getByRole('link', { name: 'Use another method' })).toBeHidden();

// User should not be signed in yet since client trust step is required
await u.po.expect.toBeSignedOut();
Expand Down
8 changes: 5 additions & 3 deletions packages/ui/src/components/SignIn/SignInClientTrust.tsx
Original file line numberDiff line numberDiff line change
Expand Up@@ -19,6 +19,8 @@ function SignInClientTrustInternal(): JSX.Element {
showAllStrategies,
toggleAllStrategies,
} = useSecondFactorSelection(signIn.supportedSecondFactors);
const onShowAlternativeMethodsClicked =
signIn.supportedSecondFactors && signIn.supportedSecondFactors.length > 1 ? toggleAllStrategies : undefined;

if (!currentFactor) {
return <LoadingCard />;
Expand All@@ -41,7 +43,7 @@ function SignInClientTrustInternal(): JSX.Element {
factorAlreadyPrepared={factorAlreadyPrepared}
onFactorPrepare={handleFactorPrepare}
factor={currentFactor}
onShowAlternativeMethodsClicked={toggleAllStrategies}
onShowAlternativeMethodsClicked={onShowAlternativeMethodsClicked}
/>
);
case 'email_code':
Expand All@@ -51,7 +53,7 @@ function SignInClientTrustInternal(): JSX.Element {
factorAlreadyPrepared={factorAlreadyPrepared}
onFactorPrepare={handleFactorPrepare}
factor={currentFactor}
onShowAlternativeMethodsClicked={toggleAllStrategies}
onShowAlternativeMethodsClicked={onShowAlternativeMethodsClicked}
/>
);
case 'email_link':
Expand All@@ -61,7 +63,7 @@ function SignInClientTrustInternal(): JSX.Element {
factorAlreadyPrepared={factorAlreadyPrepared}
onFactorPrepare={handleFactorPrepare}
factor={currentFactor}
onShowAlternativeMethodsClicked={toggleAllStrategies}
onShowAlternativeMethodsClicked={onShowAlternativeMethodsClicked}
/>
);
default:
Expand Down
12 changes: 7 additions & 5 deletions packages/ui/src/components/SignIn/SignInFactorTwo.tsx
Original file line numberDiff line numberDiff line change
Expand Up@@ -28,6 +28,8 @@ function SignInFactorTwoInternal(): JSX.Element {
showAllStrategies,
toggleAllStrategies,
} = useSecondFactorSelection(signIn.supportedSecondFactors);
const onShowAlternativeMethodsClicked =
signIn.supportedSecondFactors && signIn.supportedSecondFactors.length > 1 ? toggleAllStrategies : undefined;

React.useEffect(() => {
if (clerk.__internal_setActiveInProgress) {
Expand DownExpand Up@@ -69,7 +71,7 @@ function SignInFactorTwoInternal(): JSX.Element {
factorAlreadyPrepared={factorAlreadyPrepared}
onFactorPrepare={handleFactorPrepare}
factor={currentFactor}
onShowAlternativeMethodsClicked={toggleAllStrategies}
onShowAlternativeMethodsClicked={onShowAlternativeMethodsClicked}
/>
);
case 'totp':
Expand All@@ -78,18 +80,18 @@ function SignInFactorTwoInternal(): JSX.Element {
factorAlreadyPrepared={factorAlreadyPrepared}
onFactorPrepare={handleFactorPrepare}
factor={currentFactor}
onShowAlternativeMethodsClicked={toggleAllStrategies}
onShowAlternativeMethodsClicked={onShowAlternativeMethodsClicked}
/>
);
case 'backup_code':
return <SignInFactorTwoBackupCodeCard onShowAlternativeMethodsClicked={toggleAllStrategies} />;
return <SignInFactorTwoBackupCodeCard onShowAlternativeMethodsClicked={onShowAlternativeMethodsClicked} />;
case 'email_code':
return (
<SignInFactorTwoEmailCodeCard
factorAlreadyPrepared={factorAlreadyPrepared}
onFactorPrepare={handleFactorPrepare}
factor={currentFactor}
onShowAlternativeMethodsClicked={toggleAllStrategies}
onShowAlternativeMethodsClicked={onShowAlternativeMethodsClicked}
/>
);
case 'email_link':
Expand All@@ -98,7 +100,7 @@ function SignInFactorTwoInternal(): JSX.Element {
factorAlreadyPrepared={factorAlreadyPrepared}
onFactorPrepare={handleFactorPrepare}
factor={currentFactor}
onShowAlternativeMethodsClicked={toggleAllStrategies}
onShowAlternativeMethodsClicked={onShowAlternativeMethodsClicked}
/>
);
default:
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -19,7 +19,7 @@ import { navigateOnSignInProtectGate } from './handleProtectCheck';
import { isResetPasswordStrategy } from './utils';

type SignInFactorTwoBackupCodeCardProps = {
onShowAlternativeMethodsClicked: React.MouseEventHandler;
onShowAlternativeMethodsClicked?: React.MouseEventHandler;
};

export const SignInFactorTwoBackupCodeCard = (props: SignInFactorTwoBackupCodeCardProps) => {
Expand Down
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,35 @@
import type { SignInResource } from '@clerk/shared/types';
import { describe, expect, it } from 'vitest';

import { bindCreateFixtures } from '@/test/create-fixtures';
import { render, screen } from '@/test/utils';

import { SignInClientTrust } from '../SignInClientTrust';

const { createFixtures } = bindCreateFixtures('SignIn');

describe('SignInClientTrust', () => {
describe('Use another method', () => {
it('does not render when only one verification factor is available', async () => {
const { wrapper, fixtures } = await createFixtures(f => {
f.startSignInClientTrust({ supportPhoneCode: true });
});

fixtures.signIn.prepareSecondFactor.mockResolvedValueOnce({} as SignInResource);
render(<SignInClientTrust />, { wrapper });

expect(screen.queryByText('Use another method')).not.toBeInTheDocument();
});

it('renders when multiple verification factors are available', async () => {
const { wrapper, fixtures } = await createFixtures(f => {
f.startSignInClientTrust({ supportPhoneCode: true, supportEmailCode: true });
});

fixtures.signIn.prepareSecondFactor.mockResolvedValueOnce({} as SignInResource);
render(<SignInClientTrust />, { wrapper });

expect(screen.getByText('Use another method')).toBeInTheDocument();
});
});
});
Original file line numberDiff line numberDiff line change
Expand Up@@ -407,6 +407,28 @@ describe('SignInFactorTwo', () => {
});

describe('Use another method', () => {
it('does not render when only one verification factor is available', async () => {
const { wrapper, fixtures } = await createFixtures(f => {
f.startSignInFactorTwo({ supportPhoneCode: true });
});

fixtures.signIn.prepareSecondFactor.mockResolvedValueOnce({} as SignInResource);
render(<SignInFactorTwo />, { wrapper });

expect(screen.queryByText('Use another method')).not.toBeInTheDocument();
});

it('renders when multiple verification factors are available', async () => {
const { wrapper, fixtures } = await createFixtures(f => {
f.startSignInFactorTwo({ supportPhoneCode: true, supportEmailCode: true });
});

fixtures.signIn.prepareSecondFactor.mockResolvedValueOnce({} as SignInResource);
render(<SignInFactorTwo />, { wrapper });

expect(screen.getByText('Use another method')).toBeInTheDocument();
});

it('renders the other authentication methods list component when clicking on "Use another method"', async () => {
const { wrapper, fixtures } = await createFixtures(f => {
f.withEmailAddress();
Expand Down
24 changes: 21 additions & 3 deletions packages/ui/src/test/fixture-helpers.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -119,6 +119,7 @@ const createSignInFixtureHelpers = (baseClient: ClientJSON) => {
type SignInFactorTwoParams = {
identifier?: string;
supportPhoneCode?: boolean;
supportEmailCode?: boolean;
supportTotp?: boolean;
supportBackupCode?: boolean;
supportResetPasswordEmail?: boolean;
Expand DownExpand Up@@ -185,17 +186,21 @@ const createSignInFixtureHelpers = (baseClient: ClientJSON) => {
} as SignInJSON;
};

const startSignInFactorTwo = (params?: SignInFactorTwoParams) => {
const startSignInVerification = (
status: Extract<SignInJSON['status'], 'needs_client_trust' | 'needs_second_factor'>,
params?: SignInFactorTwoParams,
) => {
const {
identifier = '+30 691 1111111',
supportPhoneCode = true,
supportEmailCode,
supportTotp,
supportBackupCode,
supportResetPasswordEmail,
supportResetPasswordPhone,
} = params || {};
baseClient.sign_in = {
status: 'needs_second_factor',
status,
identifier,
...(supportResetPasswordEmail
? {
Expand All@@ -216,13 +221,20 @@ const createSignInFixtureHelpers = (baseClient: ClientJSON) => {
supported_identifiers: ['email_address', 'phone_number'],
supported_second_factors: [
...(supportPhoneCode ? [{ strategy: 'phone_code', safe_identifier: identifier || 'n*****@clerk.com' }] : []),
...(supportEmailCode ? [{ strategy: 'email_code', safe_identifier: 'n*****@clerk.com' }] : []),
Comment thread
tmilewski marked this conversation as resolved.
...(supportTotp ? [{ strategy: 'totp', safe_identifier: identifier || 'n*****@clerk.com' }] : []),
...(supportBackupCode ? [{ strategy: 'backup_code', safe_identifier: identifier || 'n*****@clerk.com' }] : []),
],
user_data: { ...(createUserFixture() as any) },
} as SignInJSON;
};

const startSignInFactorTwo = (params?: SignInFactorTwoParams) =>
startSignInVerification('needs_second_factor', params);

const startSignInClientTrust = (params?: SignInFactorTwoParams) =>
startSignInVerification('needs_client_trust', params);

const startSignInWithProtectCheck = (params?: {
expiresAt?: number;
uiHints?: Record<string, string>;
Expand All@@ -249,7 +261,13 @@ const createSignInFixtureHelpers = (baseClient: ClientJSON) => {
} as SignInJSON;
};

return { startSignInWithEmailAddress, startSignInWithPhoneNumber, startSignInFactorTwo, startSignInWithProtectCheck };
return {
startSignInWithEmailAddress,
startSignInWithPhoneNumber,
startSignInFactorTwo,
startSignInClientTrust,
startSignInWithProtectCheck,
};
};

const createSignUpFixtureHelpers = (baseClient: ClientJSON) => {
Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/tidy-device-trust-methods.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
---
'@clerk/ui': patch
---

Hide the “Use another method” action during Device Trust and second-factor verification when no alternative verification method is available.
1 change: 1 addition & 0 deletions integration/tests/client-trust.test.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -38,6 +38,7 @@ testAgainstRunningApps({ withEnv: [appConfigs.envs.withNeedsClientTrust] })(

// Should contain the new device verification notice
await expect(u.page.getByText("You're signing in from a new device.")).toBeVisible();
await expect(u.page.getByRole('link', { name: 'Use another method' })).toBeHidden();

// User should not be signed in yet since client trust step is required
await u.po.expect.toBeSignedOut();
Expand Down
8 changes: 5 additions & 3 deletions packages/ui/src/components/SignIn/SignInClientTrust.tsx
Original file line numberDiff line numberDiff line change
Expand Up@@ -19,6 +19,8 @@ function SignInClientTrustInternal(): JSX.Element {
showAllStrategies,
toggleAllStrategies,
} = useSecondFactorSelection(signIn.supportedSecondFactors);
const onShowAlternativeMethodsClicked =
signIn.supportedSecondFactors && signIn.supportedSecondFactors.length > 1 ? toggleAllStrategies : undefined;

if (!currentFactor) {
return <LoadingCard />;
Expand All@@ -41,7 +43,7 @@ function SignInClientTrustInternal(): JSX.Element {
factorAlreadyPrepared={factorAlreadyPrepared}
onFactorPrepare={handleFactorPrepare}
factor={currentFactor}
onShowAlternativeMethodsClicked={toggleAllStrategies}
onShowAlternativeMethodsClicked={onShowAlternativeMethodsClicked}
/>
);
case 'email_code':
Expand All@@ -51,7 +53,7 @@ function SignInClientTrustInternal(): JSX.Element {
factorAlreadyPrepared={factorAlreadyPrepared}
onFactorPrepare={handleFactorPrepare}
factor={currentFactor}
onShowAlternativeMethodsClicked={toggleAllStrategies}
onShowAlternativeMethodsClicked={onShowAlternativeMethodsClicked}
/>
);
case 'email_link':
Expand All@@ -61,7 +63,7 @@ function SignInClientTrustInternal(): JSX.Element {
factorAlreadyPrepared={factorAlreadyPrepared}
onFactorPrepare={handleFactorPrepare}
factor={currentFactor}
onShowAlternativeMethodsClicked={toggleAllStrategies}
onShowAlternativeMethodsClicked={onShowAlternativeMethodsClicked}
/>
);
default:
Expand Down
12 changes: 7 additions & 5 deletions packages/ui/src/components/SignIn/SignInFactorTwo.tsx
Original file line numberDiff line numberDiff line change
Expand Up@@ -28,6 +28,8 @@ function SignInFactorTwoInternal(): JSX.Element {
showAllStrategies,
toggleAllStrategies,
} = useSecondFactorSelection(signIn.supportedSecondFactors);
const onShowAlternativeMethodsClicked =
signIn.supportedSecondFactors && signIn.supportedSecondFactors.length > 1 ? toggleAllStrategies : undefined;

React.useEffect(() => {
if (clerk.__internal_setActiveInProgress) {
Expand DownExpand Up@@ -69,7 +71,7 @@ function SignInFactorTwoInternal(): JSX.Element {
factorAlreadyPrepared={factorAlreadyPrepared}
onFactorPrepare={handleFactorPrepare}
factor={currentFactor}
onShowAlternativeMethodsClicked={toggleAllStrategies}
onShowAlternativeMethodsClicked={onShowAlternativeMethodsClicked}
/>
);
case 'totp':
Expand All@@ -78,18 +80,18 @@ function SignInFactorTwoInternal(): JSX.Element {
factorAlreadyPrepared={factorAlreadyPrepared}
onFactorPrepare={handleFactorPrepare}
factor={currentFactor}
onShowAlternativeMethodsClicked={toggleAllStrategies}
onShowAlternativeMethodsClicked={onShowAlternativeMethodsClicked}
/>
);
case 'backup_code':
return <SignInFactorTwoBackupCodeCard onShowAlternativeMethodsClicked={toggleAllStrategies} />;
return <SignInFactorTwoBackupCodeCard onShowAlternativeMethodsClicked={onShowAlternativeMethodsClicked} />;
case 'email_code':
return (
<SignInFactorTwoEmailCodeCard
factorAlreadyPrepared={factorAlreadyPrepared}
onFactorPrepare={handleFactorPrepare}
factor={currentFactor}
onShowAlternativeMethodsClicked={toggleAllStrategies}
onShowAlternativeMethodsClicked={onShowAlternativeMethodsClicked}
/>
);
case 'email_link':
Expand All@@ -98,7 +100,7 @@ function SignInFactorTwoInternal(): JSX.Element {
factorAlreadyPrepared={factorAlreadyPrepared}
onFactorPrepare={handleFactorPrepare}
factor={currentFactor}
onShowAlternativeMethodsClicked={toggleAllStrategies}
onShowAlternativeMethodsClicked={onShowAlternativeMethodsClicked}
/>
);
default:
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -19,7 +19,7 @@ import { navigateOnSignInProtectGate } from './handleProtectCheck';
import { isResetPasswordStrategy } from './utils';

type SignInFactorTwoBackupCodeCardProps = {
onShowAlternativeMethodsClicked: React.MouseEventHandler;
onShowAlternativeMethodsClicked?: React.MouseEventHandler;
};

export const SignInFactorTwoBackupCodeCard = (props: SignInFactorTwoBackupCodeCardProps) => {
Expand Down
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,35 @@
import type { SignInResource } from '@clerk/shared/types';
import { describe, expect, it } from 'vitest';

import { bindCreateFixtures } from '@/test/create-fixtures';
import { render, screen } from '@/test/utils';

import { SignInClientTrust } from '../SignInClientTrust';

const { createFixtures } = bindCreateFixtures('SignIn');

describe('SignInClientTrust', () => {
describe('Use another method', () => {
it('does not render when only one verification factor is available', async () => {
const { wrapper, fixtures } = await createFixtures(f => {
f.startSignInClientTrust({ supportPhoneCode: true });
});

fixtures.signIn.prepareSecondFactor.mockResolvedValueOnce({} as SignInResource);
render(<SignInClientTrust />, { wrapper });

expect(screen.queryByText('Use another method')).not.toBeInTheDocument();
});

it('renders when multiple verification factors are available', async () => {
const { wrapper, fixtures } = await createFixtures(f => {
f.startSignInClientTrust({ supportPhoneCode: true, supportEmailCode: true });
});

fixtures.signIn.prepareSecondFactor.mockResolvedValueOnce({} as SignInResource);
render(<SignInClientTrust />, { wrapper });

expect(screen.getByText('Use another method')).toBeInTheDocument();
});
});
});
Original file line numberDiff line numberDiff line change
Expand Up@@ -407,6 +407,28 @@ describe('SignInFactorTwo', () => {
});

describe('Use another method', () => {
it('does not render when only one verification factor is available', async () => {
const { wrapper, fixtures } = await createFixtures(f => {
f.startSignInFactorTwo({ supportPhoneCode: true });
});

fixtures.signIn.prepareSecondFactor.mockResolvedValueOnce({} as SignInResource);
render(<SignInFactorTwo />, { wrapper });

expect(screen.queryByText('Use another method')).not.toBeInTheDocument();
});

it('renders when multiple verification factors are available', async () => {
const { wrapper, fixtures } = await createFixtures(f => {
f.startSignInFactorTwo({ supportPhoneCode: true, supportEmailCode: true });
});

fixtures.signIn.prepareSecondFactor.mockResolvedValueOnce({} as SignInResource);
render(<SignInFactorTwo />, { wrapper });

expect(screen.getByText('Use another method')).toBeInTheDocument();
});

it('renders the other authentication methods list component when clicking on "Use another method"', async () => {
const { wrapper, fixtures } = await createFixtures(f => {
f.withEmailAddress();
Expand Down
24 changes: 21 additions & 3 deletions packages/ui/src/test/fixture-helpers.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -119,6 +119,7 @@ const createSignInFixtureHelpers = (baseClient: ClientJSON) => {
type SignInFactorTwoParams = {
identifier?: string;
supportPhoneCode?: boolean;
supportEmailCode?: boolean;
supportTotp?: boolean;
supportBackupCode?: boolean;
supportResetPasswordEmail?: boolean;
Expand DownExpand Up@@ -185,17 +186,21 @@ const createSignInFixtureHelpers = (baseClient: ClientJSON) => {
} as SignInJSON;
};

const startSignInFactorTwo = (params?: SignInFactorTwoParams) => {
const startSignInVerification = (
status: Extract<SignInJSON['status'], 'needs_client_trust' | 'needs_second_factor'>,
params?: SignInFactorTwoParams,
) => {
const {
identifier = '+30 691 1111111',
supportPhoneCode = true,
supportEmailCode,
supportTotp,
supportBackupCode,
supportResetPasswordEmail,
supportResetPasswordPhone,
} = params || {};
baseClient.sign_in = {
status: 'needs_second_factor',
status,
identifier,
...(supportResetPasswordEmail
? {
Expand All@@ -216,13 +221,20 @@ const createSignInFixtureHelpers = (baseClient: ClientJSON) => {
supported_identifiers: ['email_address', 'phone_number'],
supported_second_factors: [
...(supportPhoneCode ? [{ strategy: 'phone_code', safe_identifier: identifier || 'n*****@clerk.com' }] : []),
...(supportEmailCode ? [{ strategy: 'email_code', safe_identifier: 'n*****@clerk.com' }] : []),
Comment thread
tmilewski marked this conversation as resolved.
...(supportTotp ? [{ strategy: 'totp', safe_identifier: identifier || 'n*****@clerk.com' }] : []),
...(supportBackupCode ? [{ strategy: 'backup_code', safe_identifier: identifier || 'n*****@clerk.com' }] : []),
],
user_data: { ...(createUserFixture() as any) },
} as SignInJSON;
};

const startSignInFactorTwo = (params?: SignInFactorTwoParams) =>
startSignInVerification('needs_second_factor', params);

const startSignInClientTrust = (params?: SignInFactorTwoParams) =>
startSignInVerification('needs_client_trust', params);

const startSignInWithProtectCheck = (params?: {
expiresAt?: number;
uiHints?: Record<string, string>;
Expand All@@ -249,7 +261,13 @@ const createSignInFixtureHelpers = (baseClient: ClientJSON) => {
} as SignInJSON;
};

return { startSignInWithEmailAddress, startSignInWithPhoneNumber, startSignInFactorTwo, startSignInWithProtectCheck };
return {
startSignInWithEmailAddress,
startSignInWithPhoneNumber,
startSignInFactorTwo,
startSignInClientTrust,
startSignInWithProtectCheck,
};
};

const createSignUpFixtureHelpers = (baseClient: ClientJSON) => {
Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix"); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/tidy-device-trust-methods.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
---
'@clerk/ui': patch
---

Hide the “Use another method” action during Device Trust and second-factor verification when no alternative verification method is available.
1 change: 1 addition & 0 deletions integration/tests/client-trust.test.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -38,6 +38,7 @@ testAgainstRunningApps({ withEnv: [appConfigs.envs.withNeedsClientTrust] })(

// Should contain the new device verification notice
await expect(u.page.getByText("You're signing in from a new device.")).toBeVisible();
await expect(u.page.getByRole('link', { name: 'Use another method' })).toBeHidden();

// User should not be signed in yet since client trust step is required
await u.po.expect.toBeSignedOut();
Expand Down
8 changes: 5 additions & 3 deletions packages/ui/src/components/SignIn/SignInClientTrust.tsx
Original file line numberDiff line numberDiff line change
Expand Up@@ -19,6 +19,8 @@ function SignInClientTrustInternal(): JSX.Element {
showAllStrategies,
toggleAllStrategies,
} = useSecondFactorSelection(signIn.supportedSecondFactors);
const onShowAlternativeMethodsClicked =
signIn.supportedSecondFactors && signIn.supportedSecondFactors.length > 1 ? toggleAllStrategies : undefined;

if (!currentFactor) {
return <LoadingCard />;
Expand All@@ -41,7 +43,7 @@ function SignInClientTrustInternal(): JSX.Element {
factorAlreadyPrepared={factorAlreadyPrepared}
onFactorPrepare={handleFactorPrepare}
factor={currentFactor}
onShowAlternativeMethodsClicked={toggleAllStrategies}
onShowAlternativeMethodsClicked={onShowAlternativeMethodsClicked}
/>
);
case 'email_code':
Expand All@@ -51,7 +53,7 @@ function SignInClientTrustInternal(): JSX.Element {
factorAlreadyPrepared={factorAlreadyPrepared}
onFactorPrepare={handleFactorPrepare}
factor={currentFactor}
onShowAlternativeMethodsClicked={toggleAllStrategies}
onShowAlternativeMethodsClicked={onShowAlternativeMethodsClicked}
/>
);
case 'email_link':
Expand All@@ -61,7 +63,7 @@ function SignInClientTrustInternal(): JSX.Element {
factorAlreadyPrepared={factorAlreadyPrepared}
onFactorPrepare={handleFactorPrepare}
factor={currentFactor}
onShowAlternativeMethodsClicked={toggleAllStrategies}
onShowAlternativeMethodsClicked={onShowAlternativeMethodsClicked}
/>
);
default:
Expand Down
12 changes: 7 additions & 5 deletions packages/ui/src/components/SignIn/SignInFactorTwo.tsx
Original file line numberDiff line numberDiff line change
Expand Up@@ -28,6 +28,8 @@ function SignInFactorTwoInternal(): JSX.Element {
showAllStrategies,
toggleAllStrategies,
} = useSecondFactorSelection(signIn.supportedSecondFactors);
const onShowAlternativeMethodsClicked =
signIn.supportedSecondFactors && signIn.supportedSecondFactors.length > 1 ? toggleAllStrategies : undefined;

React.useEffect(() => {
if (clerk.__internal_setActiveInProgress) {
Expand DownExpand Up@@ -69,7 +71,7 @@ function SignInFactorTwoInternal(): JSX.Element {
factorAlreadyPrepared={factorAlreadyPrepared}
onFactorPrepare={handleFactorPrepare}
factor={currentFactor}
onShowAlternativeMethodsClicked={toggleAllStrategies}
onShowAlternativeMethodsClicked={onShowAlternativeMethodsClicked}
/>
);
case 'totp':
Expand All@@ -78,18 +80,18 @@ function SignInFactorTwoInternal(): JSX.Element {
factorAlreadyPrepared={factorAlreadyPrepared}
onFactorPrepare={handleFactorPrepare}
factor={currentFactor}
onShowAlternativeMethodsClicked={toggleAllStrategies}
onShowAlternativeMethodsClicked={onShowAlternativeMethodsClicked}
/>
);
case 'backup_code':
return <SignInFactorTwoBackupCodeCard onShowAlternativeMethodsClicked={toggleAllStrategies} />;
return <SignInFactorTwoBackupCodeCard onShowAlternativeMethodsClicked={onShowAlternativeMethodsClicked} />;
case 'email_code':
return (
<SignInFactorTwoEmailCodeCard
factorAlreadyPrepared={factorAlreadyPrepared}
onFactorPrepare={handleFactorPrepare}
factor={currentFactor}
onShowAlternativeMethodsClicked={toggleAllStrategies}
onShowAlternativeMethodsClicked={onShowAlternativeMethodsClicked}
/>
);
case 'email_link':
Expand All@@ -98,7 +100,7 @@ function SignInFactorTwoInternal(): JSX.Element {
factorAlreadyPrepared={factorAlreadyPrepared}
onFactorPrepare={handleFactorPrepare}
factor={currentFactor}
onShowAlternativeMethodsClicked={toggleAllStrategies}
onShowAlternativeMethodsClicked={onShowAlternativeMethodsClicked}
/>
);
default:
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -19,7 +19,7 @@ import { navigateOnSignInProtectGate } from './handleProtectCheck';
import { isResetPasswordStrategy } from './utils';

type SignInFactorTwoBackupCodeCardProps = {
onShowAlternativeMethodsClicked: React.MouseEventHandler;
onShowAlternativeMethodsClicked?: React.MouseEventHandler;
};

export const SignInFactorTwoBackupCodeCard = (props: SignInFactorTwoBackupCodeCardProps) => {
Expand Down
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,35 @@
import type { SignInResource } from '@clerk/shared/types';
import { describe, expect, it } from 'vitest';

import { bindCreateFixtures } from '@/test/create-fixtures';
import { render, screen } from '@/test/utils';

import { SignInClientTrust } from '../SignInClientTrust';

const { createFixtures } = bindCreateFixtures('SignIn');

describe('SignInClientTrust', () => {
describe('Use another method', () => {
it('does not render when only one verification factor is available', async () => {
const { wrapper, fixtures } = await createFixtures(f => {
f.startSignInClientTrust({ supportPhoneCode: true });
});

fixtures.signIn.prepareSecondFactor.mockResolvedValueOnce({} as SignInResource);
render(<SignInClientTrust />, { wrapper });

expect(screen.queryByText('Use another method')).not.toBeInTheDocument();
});

it('renders when multiple verification factors are available', async () => {
const { wrapper, fixtures } = await createFixtures(f => {
f.startSignInClientTrust({ supportPhoneCode: true, supportEmailCode: true });
});

fixtures.signIn.prepareSecondFactor.mockResolvedValueOnce({} as SignInResource);
render(<SignInClientTrust />, { wrapper });

expect(screen.getByText('Use another method')).toBeInTheDocument();
});
});
});
Original file line numberDiff line numberDiff line change
Expand Up@@ -407,6 +407,28 @@ describe('SignInFactorTwo', () => {
});

describe('Use another method', () => {
it('does not render when only one verification factor is available', async () => {
const { wrapper, fixtures } = await createFixtures(f => {
f.startSignInFactorTwo({ supportPhoneCode: true });
});

fixtures.signIn.prepareSecondFactor.mockResolvedValueOnce({} as SignInResource);
render(<SignInFactorTwo />, { wrapper });

expect(screen.queryByText('Use another method')).not.toBeInTheDocument();
});

it('renders when multiple verification factors are available', async () => {
const { wrapper, fixtures } = await createFixtures(f => {
f.startSignInFactorTwo({ supportPhoneCode: true, supportEmailCode: true });
});

fixtures.signIn.prepareSecondFactor.mockResolvedValueOnce({} as SignInResource);
render(<SignInFactorTwo />, { wrapper });

expect(screen.getByText('Use another method')).toBeInTheDocument();
});

it('renders the other authentication methods list component when clicking on "Use another method"', async () => {
const { wrapper, fixtures } = await createFixtures(f => {
f.withEmailAddress();
Expand Down
24 changes: 21 additions & 3 deletions packages/ui/src/test/fixture-helpers.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -119,6 +119,7 @@ const createSignInFixtureHelpers = (baseClient: ClientJSON) => {
type SignInFactorTwoParams = {
identifier?: string;
supportPhoneCode?: boolean;
supportEmailCode?: boolean;
supportTotp?: boolean;
supportBackupCode?: boolean;
supportResetPasswordEmail?: boolean;
Expand DownExpand Up@@ -185,17 +186,21 @@ const createSignInFixtureHelpers = (baseClient: ClientJSON) => {
} as SignInJSON;
};

const startSignInFactorTwo = (params?: SignInFactorTwoParams) => {
const startSignInVerification = (
status: Extract<SignInJSON['status'], 'needs_client_trust' | 'needs_second_factor'>,
params?: SignInFactorTwoParams,
) => {
const {
identifier = '+30 691 1111111',
supportPhoneCode = true,
supportEmailCode,
supportTotp,
supportBackupCode,
supportResetPasswordEmail,
supportResetPasswordPhone,
} = params || {};
baseClient.sign_in = {
status: 'needs_second_factor',
status,
identifier,
...(supportResetPasswordEmail
? {
Expand All@@ -216,13 +221,20 @@ const createSignInFixtureHelpers = (baseClient: ClientJSON) => {
supported_identifiers: ['email_address', 'phone_number'],
supported_second_factors: [
...(supportPhoneCode ? [{ strategy: 'phone_code', safe_identifier: identifier || 'n*****@clerk.com' }] : []),
...(supportEmailCode ? [{ strategy: 'email_code', safe_identifier: 'n*****@clerk.com' }] : []),
Comment thread
tmilewski marked this conversation as resolved.
...(supportTotp ? [{ strategy: 'totp', safe_identifier: identifier || 'n*****@clerk.com' }] : []),
...(supportBackupCode ? [{ strategy: 'backup_code', safe_identifier: identifier || 'n*****@clerk.com' }] : []),
],
user_data: { ...(createUserFixture() as any) },
} as SignInJSON;
};

const startSignInFactorTwo = (params?: SignInFactorTwoParams) =>
startSignInVerification('needs_second_factor', params);

const startSignInClientTrust = (params?: SignInFactorTwoParams) =>
startSignInVerification('needs_client_trust', params);

const startSignInWithProtectCheck = (params?: {
expiresAt?: number;
uiHints?: Record<string, string>;
Expand All@@ -249,7 +261,13 @@ const createSignInFixtureHelpers = (baseClient: ClientJSON) => {
} as SignInJSON;
};

return { startSignInWithEmailAddress, startSignInWithPhoneNumber, startSignInFactorTwo, startSignInWithProtectCheck };
return {
startSignInWithEmailAddress,
startSignInWithPhoneNumber,
startSignInFactorTwo,
startSignInClientTrust,
startSignInWithProtectCheck,
};
};

const createSignUpFixtureHelpers = (baseClient: ClientJSON) => {
Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms"); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/tidy-device-trust-methods.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
---
'@clerk/ui': patch
---

Hide the “Use another method” action during Device Trust and second-factor verification when no alternative verification method is available.
1 change: 1 addition & 0 deletions integration/tests/client-trust.test.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -38,6 +38,7 @@ testAgainstRunningApps({ withEnv: [appConfigs.envs.withNeedsClientTrust] })(

// Should contain the new device verification notice
await expect(u.page.getByText("You're signing in from a new device.")).toBeVisible();
await expect(u.page.getByRole('link', { name: 'Use another method' })).toBeHidden();

// User should not be signed in yet since client trust step is required
await u.po.expect.toBeSignedOut();
Expand Down
8 changes: 5 additions & 3 deletions packages/ui/src/components/SignIn/SignInClientTrust.tsx
Original file line numberDiff line numberDiff line change
Expand Up@@ -19,6 +19,8 @@ function SignInClientTrustInternal(): JSX.Element {
showAllStrategies,
toggleAllStrategies,
} = useSecondFactorSelection(signIn.supportedSecondFactors);
const onShowAlternativeMethodsClicked =
signIn.supportedSecondFactors && signIn.supportedSecondFactors.length > 1 ? toggleAllStrategies : undefined;

if (!currentFactor) {
return <LoadingCard />;
Expand All@@ -41,7 +43,7 @@ function SignInClientTrustInternal(): JSX.Element {
factorAlreadyPrepared={factorAlreadyPrepared}
onFactorPrepare={handleFactorPrepare}
factor={currentFactor}
onShowAlternativeMethodsClicked={toggleAllStrategies}
onShowAlternativeMethodsClicked={onShowAlternativeMethodsClicked}
/>
);
case 'email_code':
Expand All@@ -51,7 +53,7 @@ function SignInClientTrustInternal(): JSX.Element {
factorAlreadyPrepared={factorAlreadyPrepared}
onFactorPrepare={handleFactorPrepare}
factor={currentFactor}
onShowAlternativeMethodsClicked={toggleAllStrategies}
onShowAlternativeMethodsClicked={onShowAlternativeMethodsClicked}
/>
);
case 'email_link':
Expand All@@ -61,7 +63,7 @@ function SignInClientTrustInternal(): JSX.Element {
factorAlreadyPrepared={factorAlreadyPrepared}
onFactorPrepare={handleFactorPrepare}
factor={currentFactor}
onShowAlternativeMethodsClicked={toggleAllStrategies}
onShowAlternativeMethodsClicked={onShowAlternativeMethodsClicked}
/>
);
default:
Expand Down
12 changes: 7 additions & 5 deletions packages/ui/src/components/SignIn/SignInFactorTwo.tsx
Original file line numberDiff line numberDiff line change
Expand Up@@ -28,6 +28,8 @@ function SignInFactorTwoInternal(): JSX.Element {
showAllStrategies,
toggleAllStrategies,
} = useSecondFactorSelection(signIn.supportedSecondFactors);
const onShowAlternativeMethodsClicked =
signIn.supportedSecondFactors && signIn.supportedSecondFactors.length > 1 ? toggleAllStrategies : undefined;

React.useEffect(() => {
if (clerk.__internal_setActiveInProgress) {
Expand DownExpand Up@@ -69,7 +71,7 @@ function SignInFactorTwoInternal(): JSX.Element {
factorAlreadyPrepared={factorAlreadyPrepared}
onFactorPrepare={handleFactorPrepare}
factor={currentFactor}
onShowAlternativeMethodsClicked={toggleAllStrategies}
onShowAlternativeMethodsClicked={onShowAlternativeMethodsClicked}
/>
);
case 'totp':
Expand All@@ -78,18 +80,18 @@ function SignInFactorTwoInternal(): JSX.Element {
factorAlreadyPrepared={factorAlreadyPrepared}
onFactorPrepare={handleFactorPrepare}
factor={currentFactor}
onShowAlternativeMethodsClicked={toggleAllStrategies}
onShowAlternativeMethodsClicked={onShowAlternativeMethodsClicked}
/>
);
case 'backup_code':
return <SignInFactorTwoBackupCodeCard onShowAlternativeMethodsClicked={toggleAllStrategies} />;
return <SignInFactorTwoBackupCodeCard onShowAlternativeMethodsClicked={onShowAlternativeMethodsClicked} />;
case 'email_code':
return (
<SignInFactorTwoEmailCodeCard
factorAlreadyPrepared={factorAlreadyPrepared}
onFactorPrepare={handleFactorPrepare}
factor={currentFactor}
onShowAlternativeMethodsClicked={toggleAllStrategies}
onShowAlternativeMethodsClicked={onShowAlternativeMethodsClicked}
/>
);
case 'email_link':
Expand All@@ -98,7 +100,7 @@ function SignInFactorTwoInternal(): JSX.Element {
factorAlreadyPrepared={factorAlreadyPrepared}
onFactorPrepare={handleFactorPrepare}
factor={currentFactor}
onShowAlternativeMethodsClicked={toggleAllStrategies}
onShowAlternativeMethodsClicked={onShowAlternativeMethodsClicked}
/>
);
default:
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -19,7 +19,7 @@ import { navigateOnSignInProtectGate } from './handleProtectCheck';
import { isResetPasswordStrategy } from './utils';

type SignInFactorTwoBackupCodeCardProps = {
onShowAlternativeMethodsClicked: React.MouseEventHandler;
onShowAlternativeMethodsClicked?: React.MouseEventHandler;
};

export const SignInFactorTwoBackupCodeCard = (props: SignInFactorTwoBackupCodeCardProps) => {
Expand Down
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,35 @@
import type { SignInResource } from '@clerk/shared/types';
import { describe, expect, it } from 'vitest';

import { bindCreateFixtures } from '@/test/create-fixtures';
import { render, screen } from '@/test/utils';

import { SignInClientTrust } from '../SignInClientTrust';

const { createFixtures } = bindCreateFixtures('SignIn');

describe('SignInClientTrust', () => {
describe('Use another method', () => {
it('does not render when only one verification factor is available', async () => {
const { wrapper, fixtures } = await createFixtures(f => {
f.startSignInClientTrust({ supportPhoneCode: true });
});

fixtures.signIn.prepareSecondFactor.mockResolvedValueOnce({} as SignInResource);
render(<SignInClientTrust />, { wrapper });

expect(screen.queryByText('Use another method')).not.toBeInTheDocument();
});

it('renders when multiple verification factors are available', async () => {
const { wrapper, fixtures } = await createFixtures(f => {
f.startSignInClientTrust({ supportPhoneCode: true, supportEmailCode: true });
});

fixtures.signIn.prepareSecondFactor.mockResolvedValueOnce({} as SignInResource);
render(<SignInClientTrust />, { wrapper });

expect(screen.getByText('Use another method')).toBeInTheDocument();
});
});
});
Original file line numberDiff line numberDiff line change
Expand Up@@ -407,6 +407,28 @@ describe('SignInFactorTwo', () => {
});

describe('Use another method', () => {
it('does not render when only one verification factor is available', async () => {
const { wrapper, fixtures } = await createFixtures(f => {
f.startSignInFactorTwo({ supportPhoneCode: true });
});

fixtures.signIn.prepareSecondFactor.mockResolvedValueOnce({} as SignInResource);
render(<SignInFactorTwo />, { wrapper });

expect(screen.queryByText('Use another method')).not.toBeInTheDocument();
});

it('renders when multiple verification factors are available', async () => {
const { wrapper, fixtures } = await createFixtures(f => {
f.startSignInFactorTwo({ supportPhoneCode: true, supportEmailCode: true });
});

fixtures.signIn.prepareSecondFactor.mockResolvedValueOnce({} as SignInResource);
render(<SignInFactorTwo />, { wrapper });

expect(screen.getByText('Use another method')).toBeInTheDocument();
});

it('renders the other authentication methods list component when clicking on "Use another method"', async () => {
const { wrapper, fixtures } = await createFixtures(f => {
f.withEmailAddress();
Expand Down
24 changes: 21 additions & 3 deletions packages/ui/src/test/fixture-helpers.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -119,6 +119,7 @@ const createSignInFixtureHelpers = (baseClient: ClientJSON) => {
type SignInFactorTwoParams = {
identifier?: string;
supportPhoneCode?: boolean;
supportEmailCode?: boolean;
supportTotp?: boolean;
supportBackupCode?: boolean;
supportResetPasswordEmail?: boolean;
Expand DownExpand Up@@ -185,17 +186,21 @@ const createSignInFixtureHelpers = (baseClient: ClientJSON) => {
} as SignInJSON;
};

const startSignInFactorTwo = (params?: SignInFactorTwoParams) => {
const startSignInVerification = (
status: Extract<SignInJSON['status'], 'needs_client_trust' | 'needs_second_factor'>,
params?: SignInFactorTwoParams,
) => {
const {
identifier = '+30 691 1111111',
supportPhoneCode = true,
supportEmailCode,
supportTotp,
supportBackupCode,
supportResetPasswordEmail,
supportResetPasswordPhone,
} = params || {};
baseClient.sign_in = {
status: 'needs_second_factor',
status,
identifier,
...(supportResetPasswordEmail
? {
Expand All@@ -216,13 +221,20 @@ const createSignInFixtureHelpers = (baseClient: ClientJSON) => {
supported_identifiers: ['email_address', 'phone_number'],
supported_second_factors: [
...(supportPhoneCode ? [{ strategy: 'phone_code', safe_identifier: identifier || 'n*****@clerk.com' }] : []),
...(supportEmailCode ? [{ strategy: 'email_code', safe_identifier: 'n*****@clerk.com' }] : []),
Comment thread
tmilewski marked this conversation as resolved.
...(supportTotp ? [{ strategy: 'totp', safe_identifier: identifier || 'n*****@clerk.com' }] : []),
...(supportBackupCode ? [{ strategy: 'backup_code', safe_identifier: identifier || 'n*****@clerk.com' }] : []),
],
user_data: { ...(createUserFixture() as any) },
} as SignInJSON;
};

const startSignInFactorTwo = (params?: SignInFactorTwoParams) =>
startSignInVerification('needs_second_factor', params);

const startSignInClientTrust = (params?: SignInFactorTwoParams) =>
startSignInVerification('needs_client_trust', params);

const startSignInWithProtectCheck = (params?: {
expiresAt?: number;
uiHints?: Record<string, string>;
Expand All@@ -249,7 +261,13 @@ const createSignInFixtureHelpers = (baseClient: ClientJSON) => {
} as SignInJSON;
};

return { startSignInWithEmailAddress, startSignInWithPhoneNumber, startSignInFactorTwo, startSignInWithProtectCheck };
return {
startSignInWithEmailAddress,
startSignInWithPhoneNumber,
startSignInFactorTwo,
startSignInClientTrust,
startSignInWithProtectCheck,
};
};

const createSignUpFixtureHelpers = (baseClient: ClientJSON) => {
Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links"); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/tidy-device-trust-methods.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
---
'@clerk/ui': patch
---

Hide the “Use another method” action during Device Trust and second-factor verification when no alternative verification method is available.
1 change: 1 addition & 0 deletions integration/tests/client-trust.test.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -38,6 +38,7 @@ testAgainstRunningApps({ withEnv: [appConfigs.envs.withNeedsClientTrust] })(

// Should contain the new device verification notice
await expect(u.page.getByText("You're signing in from a new device.")).toBeVisible();
await expect(u.page.getByRole('link', { name: 'Use another method' })).toBeHidden();

// User should not be signed in yet since client trust step is required
await u.po.expect.toBeSignedOut();
Expand Down
8 changes: 5 additions & 3 deletions packages/ui/src/components/SignIn/SignInClientTrust.tsx
Original file line numberDiff line numberDiff line change
Expand Up@@ -19,6 +19,8 @@ function SignInClientTrustInternal(): JSX.Element {
showAllStrategies,
toggleAllStrategies,
} = useSecondFactorSelection(signIn.supportedSecondFactors);
const onShowAlternativeMethodsClicked =
signIn.supportedSecondFactors && signIn.supportedSecondFactors.length > 1 ? toggleAllStrategies : undefined;

if (!currentFactor) {
return <LoadingCard />;
Expand All@@ -41,7 +43,7 @@ function SignInClientTrustInternal(): JSX.Element {
factorAlreadyPrepared={factorAlreadyPrepared}
onFactorPrepare={handleFactorPrepare}
factor={currentFactor}
onShowAlternativeMethodsClicked={toggleAllStrategies}
onShowAlternativeMethodsClicked={onShowAlternativeMethodsClicked}
/>
);
case 'email_code':
Expand All@@ -51,7 +53,7 @@ function SignInClientTrustInternal(): JSX.Element {
factorAlreadyPrepared={factorAlreadyPrepared}
onFactorPrepare={handleFactorPrepare}
factor={currentFactor}
onShowAlternativeMethodsClicked={toggleAllStrategies}
onShowAlternativeMethodsClicked={onShowAlternativeMethodsClicked}
/>
);
case 'email_link':
Expand All@@ -61,7 +63,7 @@ function SignInClientTrustInternal(): JSX.Element {
factorAlreadyPrepared={factorAlreadyPrepared}
onFactorPrepare={handleFactorPrepare}
factor={currentFactor}
onShowAlternativeMethodsClicked={toggleAllStrategies}
onShowAlternativeMethodsClicked={onShowAlternativeMethodsClicked}
/>
);
default:
Expand Down
12 changes: 7 additions & 5 deletions packages/ui/src/components/SignIn/SignInFactorTwo.tsx
Original file line numberDiff line numberDiff line change
Expand Up@@ -28,6 +28,8 @@ function SignInFactorTwoInternal(): JSX.Element {
showAllStrategies,
toggleAllStrategies,
} = useSecondFactorSelection(signIn.supportedSecondFactors);
const onShowAlternativeMethodsClicked =
signIn.supportedSecondFactors && signIn.supportedSecondFactors.length > 1 ? toggleAllStrategies : undefined;

React.useEffect(() => {
if (clerk.__internal_setActiveInProgress) {
Expand DownExpand Up@@ -69,7 +71,7 @@ function SignInFactorTwoInternal(): JSX.Element {
factorAlreadyPrepared={factorAlreadyPrepared}
onFactorPrepare={handleFactorPrepare}
factor={currentFactor}
onShowAlternativeMethodsClicked={toggleAllStrategies}
onShowAlternativeMethodsClicked={onShowAlternativeMethodsClicked}
/>
);
case 'totp':
Expand All@@ -78,18 +80,18 @@ function SignInFactorTwoInternal(): JSX.Element {
factorAlreadyPrepared={factorAlreadyPrepared}
onFactorPrepare={handleFactorPrepare}
factor={currentFactor}
onShowAlternativeMethodsClicked={toggleAllStrategies}
onShowAlternativeMethodsClicked={onShowAlternativeMethodsClicked}
/>
);
case 'backup_code':
return <SignInFactorTwoBackupCodeCard onShowAlternativeMethodsClicked={toggleAllStrategies} />;
return <SignInFactorTwoBackupCodeCard onShowAlternativeMethodsClicked={onShowAlternativeMethodsClicked} />;
case 'email_code':
return (
<SignInFactorTwoEmailCodeCard
factorAlreadyPrepared={factorAlreadyPrepared}
onFactorPrepare={handleFactorPrepare}
factor={currentFactor}
onShowAlternativeMethodsClicked={toggleAllStrategies}
onShowAlternativeMethodsClicked={onShowAlternativeMethodsClicked}
/>
);
case 'email_link':
Expand All@@ -98,7 +100,7 @@ function SignInFactorTwoInternal(): JSX.Element {
factorAlreadyPrepared={factorAlreadyPrepared}
onFactorPrepare={handleFactorPrepare}
factor={currentFactor}
onShowAlternativeMethodsClicked={toggleAllStrategies}
onShowAlternativeMethodsClicked={onShowAlternativeMethodsClicked}
/>
);
default:
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -19,7 +19,7 @@ import { navigateOnSignInProtectGate } from './handleProtectCheck';
import { isResetPasswordStrategy } from './utils';

type SignInFactorTwoBackupCodeCardProps = {
onShowAlternativeMethodsClicked: React.MouseEventHandler;
onShowAlternativeMethodsClicked?: React.MouseEventHandler;
};

export const SignInFactorTwoBackupCodeCard = (props: SignInFactorTwoBackupCodeCardProps) => {
Expand Down
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,35 @@
import type { SignInResource } from '@clerk/shared/types';
import { describe, expect, it } from 'vitest';

import { bindCreateFixtures } from '@/test/create-fixtures';
import { render, screen } from '@/test/utils';

import { SignInClientTrust } from '../SignInClientTrust';

const { createFixtures } = bindCreateFixtures('SignIn');

describe('SignInClientTrust', () => {
describe('Use another method', () => {
it('does not render when only one verification factor is available', async () => {
const { wrapper, fixtures } = await createFixtures(f => {
f.startSignInClientTrust({ supportPhoneCode: true });
});

fixtures.signIn.prepareSecondFactor.mockResolvedValueOnce({} as SignInResource);
render(<SignInClientTrust />, { wrapper });

expect(screen.queryByText('Use another method')).not.toBeInTheDocument();
});

it('renders when multiple verification factors are available', async () => {
const { wrapper, fixtures } = await createFixtures(f => {
f.startSignInClientTrust({ supportPhoneCode: true, supportEmailCode: true });
});

fixtures.signIn.prepareSecondFactor.mockResolvedValueOnce({} as SignInResource);
render(<SignInClientTrust />, { wrapper });

expect(screen.getByText('Use another method')).toBeInTheDocument();
});
});
});
Original file line numberDiff line numberDiff line change
Expand Up@@ -407,6 +407,28 @@ describe('SignInFactorTwo', () => {
});

describe('Use another method', () => {
it('does not render when only one verification factor is available', async () => {
const { wrapper, fixtures } = await createFixtures(f => {
f.startSignInFactorTwo({ supportPhoneCode: true });
});

fixtures.signIn.prepareSecondFactor.mockResolvedValueOnce({} as SignInResource);
render(<SignInFactorTwo />, { wrapper });

expect(screen.queryByText('Use another method')).not.toBeInTheDocument();
});

it('renders when multiple verification factors are available', async () => {
const { wrapper, fixtures } = await createFixtures(f => {
f.startSignInFactorTwo({ supportPhoneCode: true, supportEmailCode: true });
});

fixtures.signIn.prepareSecondFactor.mockResolvedValueOnce({} as SignInResource);
render(<SignInFactorTwo />, { wrapper });

expect(screen.getByText('Use another method')).toBeInTheDocument();
});

it('renders the other authentication methods list component when clicking on "Use another method"', async () => {
const { wrapper, fixtures } = await createFixtures(f => {
f.withEmailAddress();
Expand Down
24 changes: 21 additions & 3 deletions packages/ui/src/test/fixture-helpers.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -119,6 +119,7 @@ const createSignInFixtureHelpers = (baseClient: ClientJSON) => {
type SignInFactorTwoParams = {
identifier?: string;
supportPhoneCode?: boolean;
supportEmailCode?: boolean;
supportTotp?: boolean;
supportBackupCode?: boolean;
supportResetPasswordEmail?: boolean;
Expand DownExpand Up@@ -185,17 +186,21 @@ const createSignInFixtureHelpers = (baseClient: ClientJSON) => {
} as SignInJSON;
};

const startSignInFactorTwo = (params?: SignInFactorTwoParams) => {
const startSignInVerification = (
status: Extract<SignInJSON['status'], 'needs_client_trust' | 'needs_second_factor'>,
params?: SignInFactorTwoParams,
) => {
const {
identifier = '+30 691 1111111',
supportPhoneCode = true,
supportEmailCode,
supportTotp,
supportBackupCode,
supportResetPasswordEmail,
supportResetPasswordPhone,
} = params || {};
baseClient.sign_in = {
status: 'needs_second_factor',
status,
identifier,
...(supportResetPasswordEmail
? {
Expand All@@ -216,13 +221,20 @@ const createSignInFixtureHelpers = (baseClient: ClientJSON) => {
supported_identifiers: ['email_address', 'phone_number'],
supported_second_factors: [
...(supportPhoneCode ? [{ strategy: 'phone_code', safe_identifier: identifier || 'n*****@clerk.com' }] : []),
...(supportEmailCode ? [{ strategy: 'email_code', safe_identifier: 'n*****@clerk.com' }] : []),
Comment thread
tmilewski marked this conversation as resolved.
...(supportTotp ? [{ strategy: 'totp', safe_identifier: identifier || 'n*****@clerk.com' }] : []),
...(supportBackupCode ? [{ strategy: 'backup_code', safe_identifier: identifier || 'n*****@clerk.com' }] : []),
],
user_data: { ...(createUserFixture() as any) },
} as SignInJSON;
};

const startSignInFactorTwo = (params?: SignInFactorTwoParams) =>
startSignInVerification('needs_second_factor', params);

const startSignInClientTrust = (params?: SignInFactorTwoParams) =>
startSignInVerification('needs_client_trust', params);

const startSignInWithProtectCheck = (params?: {
expiresAt?: number;
uiHints?: Record<string, string>;
Expand All@@ -249,7 +261,13 @@ const createSignInFixtureHelpers = (baseClient: ClientJSON) => {
} as SignInJSON;
};

return { startSignInWithEmailAddress, startSignInWithPhoneNumber, startSignInFactorTwo, startSignInWithProtectCheck };
return {
startSignInWithEmailAddress,
startSignInWithPhoneNumber,
startSignInFactorTwo,
startSignInClientTrust,
startSignInWithProtectCheck,
};
};

const createSignUpFixtureHelpers = (baseClient: ClientJSON) => {
Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default"); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/tidy-device-trust-methods.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
---
'@clerk/ui': patch
---

Hide the “Use another method” action during Device Trust and second-factor verification when no alternative verification method is available.
1 change: 1 addition & 0 deletions integration/tests/client-trust.test.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -38,6 +38,7 @@ testAgainstRunningApps({ withEnv: [appConfigs.envs.withNeedsClientTrust] })(

// Should contain the new device verification notice
await expect(u.page.getByText("You're signing in from a new device.")).toBeVisible();
await expect(u.page.getByRole('link', { name: 'Use another method' })).toBeHidden();

// User should not be signed in yet since client trust step is required
await u.po.expect.toBeSignedOut();
Expand Down
8 changes: 5 additions & 3 deletions packages/ui/src/components/SignIn/SignInClientTrust.tsx
Original file line numberDiff line numberDiff line change
Expand Up@@ -19,6 +19,8 @@ function SignInClientTrustInternal(): JSX.Element {
showAllStrategies,
toggleAllStrategies,
} = useSecondFactorSelection(signIn.supportedSecondFactors);
const onShowAlternativeMethodsClicked =
signIn.supportedSecondFactors && signIn.supportedSecondFactors.length > 1 ? toggleAllStrategies : undefined;

if (!currentFactor) {
return <LoadingCard />;
Expand All@@ -41,7 +43,7 @@ function SignInClientTrustInternal(): JSX.Element {
factorAlreadyPrepared={factorAlreadyPrepared}
onFactorPrepare={handleFactorPrepare}
factor={currentFactor}
onShowAlternativeMethodsClicked={toggleAllStrategies}
onShowAlternativeMethodsClicked={onShowAlternativeMethodsClicked}
/>
);
case 'email_code':
Expand All@@ -51,7 +53,7 @@ function SignInClientTrustInternal(): JSX.Element {
factorAlreadyPrepared={factorAlreadyPrepared}
onFactorPrepare={handleFactorPrepare}
factor={currentFactor}
onShowAlternativeMethodsClicked={toggleAllStrategies}
onShowAlternativeMethodsClicked={onShowAlternativeMethodsClicked}
/>
);
case 'email_link':
Expand All@@ -61,7 +63,7 @@ function SignInClientTrustInternal(): JSX.Element {
factorAlreadyPrepared={factorAlreadyPrepared}
onFactorPrepare={handleFactorPrepare}
factor={currentFactor}
onShowAlternativeMethodsClicked={toggleAllStrategies}
onShowAlternativeMethodsClicked={onShowAlternativeMethodsClicked}
/>
);
default:
Expand Down
12 changes: 7 additions & 5 deletions packages/ui/src/components/SignIn/SignInFactorTwo.tsx
Original file line numberDiff line numberDiff line change
Expand Up@@ -28,6 +28,8 @@ function SignInFactorTwoInternal(): JSX.Element {
showAllStrategies,
toggleAllStrategies,
} = useSecondFactorSelection(signIn.supportedSecondFactors);
const onShowAlternativeMethodsClicked =
signIn.supportedSecondFactors && signIn.supportedSecondFactors.length > 1 ? toggleAllStrategies : undefined;

React.useEffect(() => {
if (clerk.__internal_setActiveInProgress) {
Expand DownExpand Up@@ -69,7 +71,7 @@ function SignInFactorTwoInternal(): JSX.Element {
factorAlreadyPrepared={factorAlreadyPrepared}
onFactorPrepare={handleFactorPrepare}
factor={currentFactor}
onShowAlternativeMethodsClicked={toggleAllStrategies}
onShowAlternativeMethodsClicked={onShowAlternativeMethodsClicked}
/>
);
case 'totp':
Expand All@@ -78,18 +80,18 @@ function SignInFactorTwoInternal(): JSX.Element {
factorAlreadyPrepared={factorAlreadyPrepared}
onFactorPrepare={handleFactorPrepare}
factor={currentFactor}
onShowAlternativeMethodsClicked={toggleAllStrategies}
onShowAlternativeMethodsClicked={onShowAlternativeMethodsClicked}
/>
);
case 'backup_code':
return <SignInFactorTwoBackupCodeCard onShowAlternativeMethodsClicked={toggleAllStrategies} />;
return <SignInFactorTwoBackupCodeCard onShowAlternativeMethodsClicked={onShowAlternativeMethodsClicked} />;
case 'email_code':
return (
<SignInFactorTwoEmailCodeCard
factorAlreadyPrepared={factorAlreadyPrepared}
onFactorPrepare={handleFactorPrepare}
factor={currentFactor}
onShowAlternativeMethodsClicked={toggleAllStrategies}
onShowAlternativeMethodsClicked={onShowAlternativeMethodsClicked}
/>
);
case 'email_link':
Expand All@@ -98,7 +100,7 @@ function SignInFactorTwoInternal(): JSX.Element {
factorAlreadyPrepared={factorAlreadyPrepared}
onFactorPrepare={handleFactorPrepare}
factor={currentFactor}
onShowAlternativeMethodsClicked={toggleAllStrategies}
onShowAlternativeMethodsClicked={onShowAlternativeMethodsClicked}
/>
);
default:
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -19,7 +19,7 @@ import { navigateOnSignInProtectGate } from './handleProtectCheck';
import { isResetPasswordStrategy } from './utils';

type SignInFactorTwoBackupCodeCardProps = {
onShowAlternativeMethodsClicked: React.MouseEventHandler;
onShowAlternativeMethodsClicked?: React.MouseEventHandler;
};

export const SignInFactorTwoBackupCodeCard = (props: SignInFactorTwoBackupCodeCardProps) => {
Expand Down
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,35 @@
import type { SignInResource } from '@clerk/shared/types';
import { describe, expect, it } from 'vitest';

import { bindCreateFixtures } from '@/test/create-fixtures';
import { render, screen } from '@/test/utils';

import { SignInClientTrust } from '../SignInClientTrust';

const { createFixtures } = bindCreateFixtures('SignIn');

describe('SignInClientTrust', () => {
describe('Use another method', () => {
it('does not render when only one verification factor is available', async () => {
const { wrapper, fixtures } = await createFixtures(f => {
f.startSignInClientTrust({ supportPhoneCode: true });
});

fixtures.signIn.prepareSecondFactor.mockResolvedValueOnce({} as SignInResource);
render(<SignInClientTrust />, { wrapper });

expect(screen.queryByText('Use another method')).not.toBeInTheDocument();
});

it('renders when multiple verification factors are available', async () => {
const { wrapper, fixtures } = await createFixtures(f => {
f.startSignInClientTrust({ supportPhoneCode: true, supportEmailCode: true });
});

fixtures.signIn.prepareSecondFactor.mockResolvedValueOnce({} as SignInResource);
render(<SignInClientTrust />, { wrapper });

expect(screen.getByText('Use another method')).toBeInTheDocument();
});
});
});
Original file line numberDiff line numberDiff line change
Expand Up@@ -407,6 +407,28 @@ describe('SignInFactorTwo', () => {
});

describe('Use another method', () => {
it('does not render when only one verification factor is available', async () => {
const { wrapper, fixtures } = await createFixtures(f => {
f.startSignInFactorTwo({ supportPhoneCode: true });
});

fixtures.signIn.prepareSecondFactor.mockResolvedValueOnce({} as SignInResource);
render(<SignInFactorTwo />, { wrapper });

expect(screen.queryByText('Use another method')).not.toBeInTheDocument();
});

it('renders when multiple verification factors are available', async () => {
const { wrapper, fixtures } = await createFixtures(f => {
f.startSignInFactorTwo({ supportPhoneCode: true, supportEmailCode: true });
});

fixtures.signIn.prepareSecondFactor.mockResolvedValueOnce({} as SignInResource);
render(<SignInFactorTwo />, { wrapper });

expect(screen.getByText('Use another method')).toBeInTheDocument();
});

it('renders the other authentication methods list component when clicking on "Use another method"', async () => {
const { wrapper, fixtures } = await createFixtures(f => {
f.withEmailAddress();
Expand Down
24 changes: 21 additions & 3 deletions packages/ui/src/test/fixture-helpers.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -119,6 +119,7 @@ const createSignInFixtureHelpers = (baseClient: ClientJSON) => {
type SignInFactorTwoParams = {
identifier?: string;
supportPhoneCode?: boolean;
supportEmailCode?: boolean;
supportTotp?: boolean;
supportBackupCode?: boolean;
supportResetPasswordEmail?: boolean;
Expand DownExpand Up@@ -185,17 +186,21 @@ const createSignInFixtureHelpers = (baseClient: ClientJSON) => {
} as SignInJSON;
};

const startSignInFactorTwo = (params?: SignInFactorTwoParams) => {
const startSignInVerification = (
status: Extract<SignInJSON['status'], 'needs_client_trust' | 'needs_second_factor'>,
params?: SignInFactorTwoParams,
) => {
const {
identifier = '+30 691 1111111',
supportPhoneCode = true,
supportEmailCode,
supportTotp,
supportBackupCode,
supportResetPasswordEmail,
supportResetPasswordPhone,
} = params || {};
baseClient.sign_in = {
status: 'needs_second_factor',
status,
identifier,
...(supportResetPasswordEmail
? {
Expand All@@ -216,13 +221,20 @@ const createSignInFixtureHelpers = (baseClient: ClientJSON) => {
supported_identifiers: ['email_address', 'phone_number'],
supported_second_factors: [
...(supportPhoneCode ? [{ strategy: 'phone_code', safe_identifier: identifier || 'n*****@clerk.com' }] : []),
...(supportEmailCode ? [{ strategy: 'email_code', safe_identifier: 'n*****@clerk.com' }] : []),
Comment thread
tmilewski marked this conversation as resolved.
...(supportTotp ? [{ strategy: 'totp', safe_identifier: identifier || 'n*****@clerk.com' }] : []),
...(supportBackupCode ? [{ strategy: 'backup_code', safe_identifier: identifier || 'n*****@clerk.com' }] : []),
],
user_data: { ...(createUserFixture() as any) },
} as SignInJSON;
};

const startSignInFactorTwo = (params?: SignInFactorTwoParams) =>
startSignInVerification('needs_second_factor', params);

const startSignInClientTrust = (params?: SignInFactorTwoParams) =>
startSignInVerification('needs_client_trust', params);

const startSignInWithProtectCheck = (params?: {
expiresAt?: number;
uiHints?: Record<string, string>;
Expand All@@ -249,7 +261,13 @@ const createSignInFixtureHelpers = (baseClient: ClientJSON) => {
} as SignInJSON;
};

return { startSignInWithEmailAddress, startSignInWithPhoneNumber, startSignInFactorTwo, startSignInWithProtectCheck };
return {
startSignInWithEmailAddress,
startSignInWithPhoneNumber,
startSignInFactorTwo,
startSignInClientTrust,
startSignInWithProtectCheck,
};
};

const createSignUpFixtureHelpers = (baseClient: ClientJSON) => {
Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers"); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/tidy-device-trust-methods.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
---
'@clerk/ui': patch
---

Hide the “Use another method” action during Device Trust and second-factor verification when no alternative verification method is available.
1 change: 1 addition & 0 deletions integration/tests/client-trust.test.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -38,6 +38,7 @@ testAgainstRunningApps({ withEnv: [appConfigs.envs.withNeedsClientTrust] })(

// Should contain the new device verification notice
await expect(u.page.getByText("You're signing in from a new device.")).toBeVisible();
await expect(u.page.getByRole('link', { name: 'Use another method' })).toBeHidden();

// User should not be signed in yet since client trust step is required
await u.po.expect.toBeSignedOut();
Expand Down
8 changes: 5 additions & 3 deletions packages/ui/src/components/SignIn/SignInClientTrust.tsx
Original file line numberDiff line numberDiff line change
Expand Up@@ -19,6 +19,8 @@ function SignInClientTrustInternal(): JSX.Element {
showAllStrategies,
toggleAllStrategies,
} = useSecondFactorSelection(signIn.supportedSecondFactors);
const onShowAlternativeMethodsClicked =
signIn.supportedSecondFactors && signIn.supportedSecondFactors.length > 1 ? toggleAllStrategies : undefined;

if (!currentFactor) {
return <LoadingCard />;
Expand All@@ -41,7 +43,7 @@ function SignInClientTrustInternal(): JSX.Element {
factorAlreadyPrepared={factorAlreadyPrepared}
onFactorPrepare={handleFactorPrepare}
factor={currentFactor}
onShowAlternativeMethodsClicked={toggleAllStrategies}
onShowAlternativeMethodsClicked={onShowAlternativeMethodsClicked}
/>
);
case 'email_code':
Expand All@@ -51,7 +53,7 @@ function SignInClientTrustInternal(): JSX.Element {
factorAlreadyPrepared={factorAlreadyPrepared}
onFactorPrepare={handleFactorPrepare}
factor={currentFactor}
onShowAlternativeMethodsClicked={toggleAllStrategies}
onShowAlternativeMethodsClicked={onShowAlternativeMethodsClicked}
/>
);
case 'email_link':
Expand All@@ -61,7 +63,7 @@ function SignInClientTrustInternal(): JSX.Element {
factorAlreadyPrepared={factorAlreadyPrepared}
onFactorPrepare={handleFactorPrepare}
factor={currentFactor}
onShowAlternativeMethodsClicked={toggleAllStrategies}
onShowAlternativeMethodsClicked={onShowAlternativeMethodsClicked}
/>
);
default:
Expand Down
12 changes: 7 additions & 5 deletions packages/ui/src/components/SignIn/SignInFactorTwo.tsx
Original file line numberDiff line numberDiff line change
Expand Up@@ -28,6 +28,8 @@ function SignInFactorTwoInternal(): JSX.Element {
showAllStrategies,
toggleAllStrategies,
} = useSecondFactorSelection(signIn.supportedSecondFactors);
const onShowAlternativeMethodsClicked =
signIn.supportedSecondFactors && signIn.supportedSecondFactors.length > 1 ? toggleAllStrategies : undefined;

React.useEffect(() => {
if (clerk.__internal_setActiveInProgress) {
Expand DownExpand Up@@ -69,7 +71,7 @@ function SignInFactorTwoInternal(): JSX.Element {
factorAlreadyPrepared={factorAlreadyPrepared}
onFactorPrepare={handleFactorPrepare}
factor={currentFactor}
onShowAlternativeMethodsClicked={toggleAllStrategies}
onShowAlternativeMethodsClicked={onShowAlternativeMethodsClicked}
/>
);
case 'totp':
Expand All@@ -78,18 +80,18 @@ function SignInFactorTwoInternal(): JSX.Element {
factorAlreadyPrepared={factorAlreadyPrepared}
onFactorPrepare={handleFactorPrepare}
factor={currentFactor}
onShowAlternativeMethodsClicked={toggleAllStrategies}
onShowAlternativeMethodsClicked={onShowAlternativeMethodsClicked}
/>
);
case 'backup_code':
return <SignInFactorTwoBackupCodeCard onShowAlternativeMethodsClicked={toggleAllStrategies} />;
return <SignInFactorTwoBackupCodeCard onShowAlternativeMethodsClicked={onShowAlternativeMethodsClicked} />;
case 'email_code':
return (
<SignInFactorTwoEmailCodeCard
factorAlreadyPrepared={factorAlreadyPrepared}
onFactorPrepare={handleFactorPrepare}
factor={currentFactor}
onShowAlternativeMethodsClicked={toggleAllStrategies}
onShowAlternativeMethodsClicked={onShowAlternativeMethodsClicked}
/>
);
case 'email_link':
Expand All@@ -98,7 +100,7 @@ function SignInFactorTwoInternal(): JSX.Element {
factorAlreadyPrepared={factorAlreadyPrepared}
onFactorPrepare={handleFactorPrepare}
factor={currentFactor}
onShowAlternativeMethodsClicked={toggleAllStrategies}
onShowAlternativeMethodsClicked={onShowAlternativeMethodsClicked}
/>
);
default:
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -19,7 +19,7 @@ import { navigateOnSignInProtectGate } from './handleProtectCheck';
import { isResetPasswordStrategy } from './utils';

type SignInFactorTwoBackupCodeCardProps = {
onShowAlternativeMethodsClicked: React.MouseEventHandler;
onShowAlternativeMethodsClicked?: React.MouseEventHandler;
};

export const SignInFactorTwoBackupCodeCard = (props: SignInFactorTwoBackupCodeCardProps) => {
Expand Down
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,35 @@
import type { SignInResource } from '@clerk/shared/types';
import { describe, expect, it } from 'vitest';

import { bindCreateFixtures } from '@/test/create-fixtures';
import { render, screen } from '@/test/utils';

import { SignInClientTrust } from '../SignInClientTrust';

const { createFixtures } = bindCreateFixtures('SignIn');

describe('SignInClientTrust', () => {
describe('Use another method', () => {
it('does not render when only one verification factor is available', async () => {
const { wrapper, fixtures } = await createFixtures(f => {
f.startSignInClientTrust({ supportPhoneCode: true });
});

fixtures.signIn.prepareSecondFactor.mockResolvedValueOnce({} as SignInResource);
render(<SignInClientTrust />, { wrapper });

expect(screen.queryByText('Use another method')).not.toBeInTheDocument();
});

it('renders when multiple verification factors are available', async () => {
const { wrapper, fixtures } = await createFixtures(f => {
f.startSignInClientTrust({ supportPhoneCode: true, supportEmailCode: true });
});

fixtures.signIn.prepareSecondFactor.mockResolvedValueOnce({} as SignInResource);
render(<SignInClientTrust />, { wrapper });

expect(screen.getByText('Use another method')).toBeInTheDocument();
});
});
});
Original file line numberDiff line numberDiff line change
Expand Up@@ -407,6 +407,28 @@ describe('SignInFactorTwo', () => {
});

describe('Use another method', () => {
it('does not render when only one verification factor is available', async () => {
const { wrapper, fixtures } = await createFixtures(f => {
f.startSignInFactorTwo({ supportPhoneCode: true });
});

fixtures.signIn.prepareSecondFactor.mockResolvedValueOnce({} as SignInResource);
render(<SignInFactorTwo />, { wrapper });

expect(screen.queryByText('Use another method')).not.toBeInTheDocument();
});

it('renders when multiple verification factors are available', async () => {
const { wrapper, fixtures } = await createFixtures(f => {
f.startSignInFactorTwo({ supportPhoneCode: true, supportEmailCode: true });
});

fixtures.signIn.prepareSecondFactor.mockResolvedValueOnce({} as SignInResource);
render(<SignInFactorTwo />, { wrapper });

expect(screen.getByText('Use another method')).toBeInTheDocument();
});

it('renders the other authentication methods list component when clicking on "Use another method"', async () => {
const { wrapper, fixtures } = await createFixtures(f => {
f.withEmailAddress();
Expand Down
24 changes: 21 additions & 3 deletions packages/ui/src/test/fixture-helpers.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -119,6 +119,7 @@ const createSignInFixtureHelpers = (baseClient: ClientJSON) => {
type SignInFactorTwoParams = {
identifier?: string;
supportPhoneCode?: boolean;
supportEmailCode?: boolean;
supportTotp?: boolean;
supportBackupCode?: boolean;
supportResetPasswordEmail?: boolean;
Expand DownExpand Up@@ -185,17 +186,21 @@ const createSignInFixtureHelpers = (baseClient: ClientJSON) => {
} as SignInJSON;
};

const startSignInFactorTwo = (params?: SignInFactorTwoParams) => {
const startSignInVerification = (
status: Extract<SignInJSON['status'], 'needs_client_trust' | 'needs_second_factor'>,
params?: SignInFactorTwoParams,
) => {
const {
identifier = '+30 691 1111111',
supportPhoneCode = true,
supportEmailCode,
supportTotp,
supportBackupCode,
supportResetPasswordEmail,
supportResetPasswordPhone,
} = params || {};
baseClient.sign_in = {
status: 'needs_second_factor',
status,
identifier,
...(supportResetPasswordEmail
? {
Expand All@@ -216,13 +221,20 @@ const createSignInFixtureHelpers = (baseClient: ClientJSON) => {
supported_identifiers: ['email_address', 'phone_number'],
supported_second_factors: [
...(supportPhoneCode ? [{ strategy: 'phone_code', safe_identifier: identifier || 'n*****@clerk.com' }] : []),
...(supportEmailCode ? [{ strategy: 'email_code', safe_identifier: 'n*****@clerk.com' }] : []),
Comment thread
tmilewski marked this conversation as resolved.
...(supportTotp ? [{ strategy: 'totp', safe_identifier: identifier || 'n*****@clerk.com' }] : []),
...(supportBackupCode ? [{ strategy: 'backup_code', safe_identifier: identifier || 'n*****@clerk.com' }] : []),
],
user_data: { ...(createUserFixture() as any) },
} as SignInJSON;
};

const startSignInFactorTwo = (params?: SignInFactorTwoParams) =>
startSignInVerification('needs_second_factor', params);

const startSignInClientTrust = (params?: SignInFactorTwoParams) =>
startSignInVerification('needs_client_trust', params);

const startSignInWithProtectCheck = (params?: {
expiresAt?: number;
uiHints?: Record<string, string>;
Expand All@@ -249,7 +261,13 @@ const createSignInFixtureHelpers = (baseClient: ClientJSON) => {
} as SignInJSON;
};

return { startSignInWithEmailAddress, startSignInWithPhoneNumber, startSignInFactorTwo, startSignInWithProtectCheck };
return {
startSignInWithEmailAddress,
startSignInWithPhoneNumber,
startSignInFactorTwo,
startSignInClientTrust,
startSignInWithProtectCheck,
};
};

const createSignUpFixtureHelpers = (baseClient: ClientJSON) => {
Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode"); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })();
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/tidy-device-trust-methods.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
---
'@clerk/ui': patch
---

Hide the “Use another method” action during Device Trust and second-factor verification when no alternative verification method is available.
1 change: 1 addition & 0 deletions integration/tests/client-trust.test.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -38,6 +38,7 @@ testAgainstRunningApps({ withEnv: [appConfigs.envs.withNeedsClientTrust] })(

// Should contain the new device verification notice
await expect(u.page.getByText("You're signing in from a new device.")).toBeVisible();
await expect(u.page.getByRole('link', { name: 'Use another method' })).toBeHidden();

// User should not be signed in yet since client trust step is required
await u.po.expect.toBeSignedOut();
Expand Down
8 changes: 5 additions & 3 deletions packages/ui/src/components/SignIn/SignInClientTrust.tsx
Original file line numberDiff line numberDiff line change
Expand Up@@ -19,6 +19,8 @@ function SignInClientTrustInternal(): JSX.Element {
showAllStrategies,
toggleAllStrategies,
} = useSecondFactorSelection(signIn.supportedSecondFactors);
const onShowAlternativeMethodsClicked =
signIn.supportedSecondFactors && signIn.supportedSecondFactors.length > 1 ? toggleAllStrategies : undefined;

if (!currentFactor) {
return <LoadingCard />;
Expand All@@ -41,7 +43,7 @@ function SignInClientTrustInternal(): JSX.Element {
factorAlreadyPrepared={factorAlreadyPrepared}
onFactorPrepare={handleFactorPrepare}
factor={currentFactor}
onShowAlternativeMethodsClicked={toggleAllStrategies}
onShowAlternativeMethodsClicked={onShowAlternativeMethodsClicked}
/>
);
case 'email_code':
Expand All@@ -51,7 +53,7 @@ function SignInClientTrustInternal(): JSX.Element {
factorAlreadyPrepared={factorAlreadyPrepared}
onFactorPrepare={handleFactorPrepare}
factor={currentFactor}
onShowAlternativeMethodsClicked={toggleAllStrategies}
onShowAlternativeMethodsClicked={onShowAlternativeMethodsClicked}
/>
);
case 'email_link':
Expand All@@ -61,7 +63,7 @@ function SignInClientTrustInternal(): JSX.Element {
factorAlreadyPrepared={factorAlreadyPrepared}
onFactorPrepare={handleFactorPrepare}
factor={currentFactor}
onShowAlternativeMethodsClicked={toggleAllStrategies}
onShowAlternativeMethodsClicked={onShowAlternativeMethodsClicked}
/>
);
default:
Expand Down
12 changes: 7 additions & 5 deletions packages/ui/src/components/SignIn/SignInFactorTwo.tsx
Original file line numberDiff line numberDiff line change
Expand Up@@ -28,6 +28,8 @@ function SignInFactorTwoInternal(): JSX.Element {
showAllStrategies,
toggleAllStrategies,
} = useSecondFactorSelection(signIn.supportedSecondFactors);
const onShowAlternativeMethodsClicked =
signIn.supportedSecondFactors && signIn.supportedSecondFactors.length > 1 ? toggleAllStrategies : undefined;

React.useEffect(() => {
if (clerk.__internal_setActiveInProgress) {
Expand DownExpand Up@@ -69,7 +71,7 @@ function SignInFactorTwoInternal(): JSX.Element {
factorAlreadyPrepared={factorAlreadyPrepared}
onFactorPrepare={handleFactorPrepare}
factor={currentFactor}
onShowAlternativeMethodsClicked={toggleAllStrategies}
onShowAlternativeMethodsClicked={onShowAlternativeMethodsClicked}
/>
);
case 'totp':
Expand All@@ -78,18 +80,18 @@ function SignInFactorTwoInternal(): JSX.Element {
factorAlreadyPrepared={factorAlreadyPrepared}
onFactorPrepare={handleFactorPrepare}
factor={currentFactor}
onShowAlternativeMethodsClicked={toggleAllStrategies}
onShowAlternativeMethodsClicked={onShowAlternativeMethodsClicked}
/>
);
case 'backup_code':
return <SignInFactorTwoBackupCodeCard onShowAlternativeMethodsClicked={toggleAllStrategies} />;
return <SignInFactorTwoBackupCodeCard onShowAlternativeMethodsClicked={onShowAlternativeMethodsClicked} />;
case 'email_code':
return (
<SignInFactorTwoEmailCodeCard
factorAlreadyPrepared={factorAlreadyPrepared}
onFactorPrepare={handleFactorPrepare}
factor={currentFactor}
onShowAlternativeMethodsClicked={toggleAllStrategies}
onShowAlternativeMethodsClicked={onShowAlternativeMethodsClicked}
/>
);
case 'email_link':
Expand All@@ -98,7 +100,7 @@ function SignInFactorTwoInternal(): JSX.Element {
factorAlreadyPrepared={factorAlreadyPrepared}
onFactorPrepare={handleFactorPrepare}
factor={currentFactor}
onShowAlternativeMethodsClicked={toggleAllStrategies}
onShowAlternativeMethodsClicked={onShowAlternativeMethodsClicked}
/>
);
default:
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -19,7 +19,7 @@ import { navigateOnSignInProtectGate } from './handleProtectCheck';
import { isResetPasswordStrategy } from './utils';

type SignInFactorTwoBackupCodeCardProps = {
onShowAlternativeMethodsClicked: React.MouseEventHandler;
onShowAlternativeMethodsClicked?: React.MouseEventHandler;
};

export const SignInFactorTwoBackupCodeCard = (props: SignInFactorTwoBackupCodeCardProps) => {
Expand Down
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,35 @@
import type { SignInResource } from '@clerk/shared/types';
import { describe, expect, it } from 'vitest';

import { bindCreateFixtures } from '@/test/create-fixtures';
import { render, screen } from '@/test/utils';

import { SignInClientTrust } from '../SignInClientTrust';

const { createFixtures } = bindCreateFixtures('SignIn');

describe('SignInClientTrust', () => {
describe('Use another method', () => {
it('does not render when only one verification factor is available', async () => {
const { wrapper, fixtures } = await createFixtures(f => {
f.startSignInClientTrust({ supportPhoneCode: true });
});

fixtures.signIn.prepareSecondFactor.mockResolvedValueOnce({} as SignInResource);
render(<SignInClientTrust />, { wrapper });

expect(screen.queryByText('Use another method')).not.toBeInTheDocument();
});

it('renders when multiple verification factors are available', async () => {
const { wrapper, fixtures } = await createFixtures(f => {
f.startSignInClientTrust({ supportPhoneCode: true, supportEmailCode: true });
});

fixtures.signIn.prepareSecondFactor.mockResolvedValueOnce({} as SignInResource);
render(<SignInClientTrust />, { wrapper });

expect(screen.getByText('Use another method')).toBeInTheDocument();
});
});
});
Original file line numberDiff line numberDiff line change
Expand Up@@ -407,6 +407,28 @@ describe('SignInFactorTwo', () => {
});

describe('Use another method', () => {
it('does not render when only one verification factor is available', async () => {
const { wrapper, fixtures } = await createFixtures(f => {
f.startSignInFactorTwo({ supportPhoneCode: true });
});

fixtures.signIn.prepareSecondFactor.mockResolvedValueOnce({} as SignInResource);
render(<SignInFactorTwo />, { wrapper });

expect(screen.queryByText('Use another method')).not.toBeInTheDocument();
});

it('renders when multiple verification factors are available', async () => {
const { wrapper, fixtures } = await createFixtures(f => {
f.startSignInFactorTwo({ supportPhoneCode: true, supportEmailCode: true });
});

fixtures.signIn.prepareSecondFactor.mockResolvedValueOnce({} as SignInResource);
render(<SignInFactorTwo />, { wrapper });

expect(screen.getByText('Use another method')).toBeInTheDocument();
});

it('renders the other authentication methods list component when clicking on "Use another method"', async () => {
const { wrapper, fixtures } = await createFixtures(f => {
f.withEmailAddress();
Expand Down
24 changes: 21 additions & 3 deletions packages/ui/src/test/fixture-helpers.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -119,6 +119,7 @@ const createSignInFixtureHelpers = (baseClient: ClientJSON) => {
type SignInFactorTwoParams = {
identifier?: string;
supportPhoneCode?: boolean;
supportEmailCode?: boolean;
supportTotp?: boolean;
supportBackupCode?: boolean;
supportResetPasswordEmail?: boolean;
Expand DownExpand Up@@ -185,17 +186,21 @@ const createSignInFixtureHelpers = (baseClient: ClientJSON) => {
} as SignInJSON;
};

const startSignInFactorTwo = (params?: SignInFactorTwoParams) => {
const startSignInVerification = (
status: Extract<SignInJSON['status'], 'needs_client_trust' | 'needs_second_factor'>,
params?: SignInFactorTwoParams,
) => {
const {
identifier = '+30 691 1111111',
supportPhoneCode = true,
supportEmailCode,
supportTotp,
supportBackupCode,
supportResetPasswordEmail,
supportResetPasswordPhone,
} = params || {};
baseClient.sign_in = {
status: 'needs_second_factor',
status,
identifier,
...(supportResetPasswordEmail
? {
Expand All@@ -216,13 +221,20 @@ const createSignInFixtureHelpers = (baseClient: ClientJSON) => {
supported_identifiers: ['email_address', 'phone_number'],
supported_second_factors: [
...(supportPhoneCode ? [{ strategy: 'phone_code', safe_identifier: identifier || 'n*****@clerk.com' }] : []),
...(supportEmailCode ? [{ strategy: 'email_code', safe_identifier: 'n*****@clerk.com' }] : []),
Comment thread
tmilewski marked this conversation as resolved.
...(supportTotp ? [{ strategy: 'totp', safe_identifier: identifier || 'n*****@clerk.com' }] : []),
...(supportBackupCode ? [{ strategy: 'backup_code', safe_identifier: identifier || 'n*****@clerk.com' }] : []),
],
user_data: { ...(createUserFixture() as any) },
} as SignInJSON;
};

const startSignInFactorTwo = (params?: SignInFactorTwoParams) =>
startSignInVerification('needs_second_factor', params);

const startSignInClientTrust = (params?: SignInFactorTwoParams) =>
startSignInVerification('needs_client_trust', params);

const startSignInWithProtectCheck = (params?: {
expiresAt?: number;
uiHints?: Record<string, string>;
Expand All@@ -249,7 +261,13 @@ const createSignInFixtureHelpers = (baseClient: ClientJSON) => {
} as SignInJSON;
};

return { startSignInWithEmailAddress, startSignInWithPhoneNumber, startSignInFactorTwo, startSignInWithProtectCheck };
return {
startSignInWithEmailAddress,
startSignInWithPhoneNumber,
startSignInFactorTwo,
startSignInClientTrust,
startSignInWithProtectCheck,
};
};

const createSignUpFixtureHelpers = (baseClient: ClientJSON) => {
Expand Down
Loading