Skip to content

feat(ui): add dialog closedBy dismissal policy - #9366

Merged
maxyinger merged 3 commits into
mainfrom
max/dialog-updates
Aug 12, 2026
Merged

feat(ui): add dialog closedBy dismissal policy#9366
maxyinger merged 3 commits into
mainfrom
max/dialog-updates

Conversation

@maxyinger

@maxyingermaxyinger commented Aug 7, 2026

Copy link
Copy Markdown
Collaborator

Description

Adds closedBy to the Dialog, controlling which gestures dismiss it. Mirrors the native <dialog closedby> attribute:

ValueEscapeOutside pressProgrammatic
any (default)✅✅✅
closerequest✅❌✅
none❌❌✅

A single ordered enum rather than two booleans, so the fourth combination — outside press dismisses but Escape does not — stays unrepresentable.

The five Mosaic dialogs now use closerequest. This fixes a live bug in Destructive, where a stray backdrop click discarded the type-to-confirm input or closed the dialog mid-delete.

trigger on the Mosaic Dialog is now optional, so the machine-driven dialogs stop rendering a button they never use.

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

@maxyinger@claude
feat(ui): add dialog closedBy dismissal policy
38e7c1f
Adds `closedBy: 'any' | 'closerequest' | 'none'` to the headless Dialog root,
driving `escapeKey` and `outsidePress` on `useDismiss`. Defaults to `any`, so
existing callers are unaffected.
The five Mosaic dialogs now use `closerequest`, which stops a stray backdrop
click from discarding the type-to-confirm input in `Destructive` or closing a
dialog mid-request.
`trigger` on the Mosaic `Dialog` becomes optional, so the machine-driven
dialogs no longer render a button they don't use.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
@vercel

vercelBot commented Aug 7, 2026•
edited
Loading

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxReadyReadyPreviewAug 12, 2026 7:33pm
swingsetReadyReadyPreviewAug 12, 2026 7:33pm

Request Review

@changeset-bot

changeset-botBot commented Aug 7, 2026•
edited
Loading

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: d089e1c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 0 packages

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@pkg-pr-new

pkg-pr-newBot commented Aug 7, 2026•
edited
Loading

Copy link
Copy Markdown

Open in StackBlitz

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@9366

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@9366

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@9366

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@9366

@clerk/electron

npm i https://pkg.pr.new/@clerk/electron@9366

@clerk/electron-passkeys

npm i https://pkg.pr.new/@clerk/electron-passkeys@9366

@clerk/eslint-plugin

npm i https://pkg.pr.new/@clerk/eslint-plugin@9366

@clerk/expo

npm i https://pkg.pr.new/@clerk/expo@9366

@clerk/expo-google-signin

npm i https://pkg.pr.new/@clerk/expo-google-signin@9366

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@9366

@clerk/express

npm i https://pkg.pr.new/@clerk/express@9366

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@9366

@clerk/hono

npm i https://pkg.pr.new/@clerk/hono@9366

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@9366

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@9366

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@9366

@clerk/react

npm i https://pkg.pr.new/@clerk/react@9366

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@9366

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@9366

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@9366

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@9366

@clerk/ui

npm i https://pkg.pr.new/@clerk/ui@9366

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@9366

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@9366

commit: d089e1c

@github-actions

github-actionsBot commented Aug 7, 2026•
edited
Loading

Copy link
Copy Markdown
Contributor

API Changes Report

Generated by Break Check on 2026-08-12T19:34:24.670Z

Summary

MetricCount
Packages analyzed19
Packages with changes0
🔴 Breaking changes0
🟡 Non-breaking changes0
🟢 Additions0

No API Changes Detected

All packages have stable APIs with no detected changes.

Report generated by Break Check

Last ran on d089e1c.

@coderabbitai

coderabbitaiBot commented Aug 7, 2026•
edited
Loading

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: 67559746-9f94-4d1b-a186-3f6bb30f7c12

📥 Commits

Reviewing files that changed from the base of the PR and between 7c1aa99 and d089e1c.

📒 Files selected for processing (1)
  • .changeset/lucky-donuts-invite.md
🔗 Linked repositories identified

CodeRabbit considers these linked repositories for cross-repo context during reviews:

  • clerk/clerk_go(manual)
  • clerk/dashboard(manual)
  • clerk/accounts(manual)
  • clerk/backoffice(manual)
  • clerk/clerk(manual)
  • clerk/clerk-docs(manual)
  • clerk/cloudflare-workers(manual)
  • clerk/clerk-ios(auto-detected)
  • clerk/cli(auto-detected)
  • clerk/clerk-android(auto-detected)
💤 Files with no reviewable changes (1)
  • .changeset/lucky-donuts-invite.md
📝 Walkthrough

Walkthrough

The headless dialog adds closedBy modes for Escape and outside-press dismissal. The public type is exported and covered by tests and documentation. Mosaic dialogs accept optional triggers and forward closedBy. Several organization dialogs use closerequest. The dialog story updates backdrop and viewport composition.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Possibly related PRs

  • clerk/javascript#9388: Both PRs modify Dialog.Root and Mosaic dialog consumers to add and use the closedBy dismissal policy, including optional triggers.
  • clerk/javascript#9420: Both PRs introduce the closedBy API and dismissal behavior changes in the headless and Mosaic dialog implementations.

Suggested reviewers:austincalvelage

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check nameStatusExplanationResolution
Docstring Coverage⚠️ WarningDocstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check nameStatusExplanation
Title check✅ PassedThe title clearly and concisely describes the new Dialog closedBy dismissal policy.
Description check✅ PassedThe description directly explains the closedBy feature, its dismissal behavior, and related Mosaic dialog changes.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.

Comment @coderabbitai help to get the list of available commands.

coderabbitai[bot]
coderabbitaiBot reviewed Aug 7, 2026
View reviewed changes

@coderabbitaicoderabbitaiBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@packages/headless/src/primitives/dialog/dialog-root.tsx`:
- Around line 21-31: Update the shared closedBy='none' contract in
packages/headless/src/primitives/dialog/dialog-root.tsx lines 21-31,
packages/headless/src/primitives/dialog/README.md lines 74-94, and
.changeset/lucky-donuts-invite.md line 5: state that Escape and outside-press
dismissal are disabled while explicit close controls such as Dialog.Close remain
available. Use consistent wording across all three sites.
🪄 Autofix

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: 16d1a9d7-2fb9-415c-8aef-4a6c79b99611

📥 Commits

Reviewing files that changed from the base of the PR and between 6100719 and 38e7c1f.

📒 Files selected for processing (14)
  • .changeset/lucky-donuts-invite.md
  • packages/headless/src/primitives/dialog/README.md
  • packages/headless/src/primitives/dialog/dialog-root.tsx
  • packages/headless/src/primitives/dialog/dialog.test.tsx
  • packages/headless/src/primitives/dialog/index.ts
  • packages/headless/src/primitives/dialog/parts.ts
  • packages/swingset/src/stories/dialog.mdx
  • packages/swingset/src/stories/dialog.stories.tsx
  • packages/ui/src/mosaic/block/destructive.tsx
  • packages/ui/src/mosaic/components/dialog.tsx
  • packages/ui/src/mosaic/organization/organization-profile-domains-section-add-verify.view.tsx
  • packages/ui/src/mosaic/organization/organization-profile-domains-section-enrollment.view.tsx
  • packages/ui/src/mosaic/organization/organization-profile-domains-section-remove.view.tsx
  • packages/ui/src/mosaic/organization/organization-profile-profile-section.view.tsx
🔗 Linked repositories identified

CodeRabbit considers these linked repositories for cross-repo context during reviews:

  • clerk/clerk_go(manual)
  • clerk/dashboard(manual)
  • clerk/accounts(manual)
  • clerk/backoffice(manual)
  • clerk/clerk(manual)
  • clerk/clerk-docs(manual)
  • clerk/cloudflare-workers(manual)
  • clerk/clerk-ios(auto-detected)
  • clerk/cli(auto-detected)
  • clerk/clerk-android(auto-detected)

Comment threadpackages/headless/src/primitives/dialog/dialog-root.tsx
@coderabbitaicoderabbitaiBot mentioned this pull request Aug 11, 2026
Merged
11 tasks
@coderabbitai

coderabbitaiBot commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

Note

GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer.

@coderabbitaicoderabbitaiBot mentioned this pull request Aug 12, 2026
Closed
9 tasks
@maxyinger
maxyinger merged commit dfc9c0d into mainAug 12, 2026
111 of 118 checks passed
@maxyinger
maxyinger deleted the max/dialog-updates branch August 12, 2026 20:45
@coderabbitaicoderabbitaiBot mentioned this pull request Aug 12, 2026
Open
9 tasks
@maxyingermaxyinger mentioned this pull request Aug 13, 2026
Closed
9 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@coderabbitaicoderabbitai[bot]coderabbitai[bot] left review comments
@alexcarpenteralexcarpenteralexcarpenter approved these changes

Assignees

No one assigned

Labels

ui

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@maxyinger@alexcarpenter
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
feat(ui): add dialog closedBy dismissal policy by maxyinger · Pull Request #9366 · clerk/javascript · GitHub
Skip to content
feat(ui): add dialog closedBy dismissal policy - #9366
Merged
maxyinger merged 3 commits into
mainfrom 
max/dialog-updates
Aug 12, 2026
Merged
feat(ui): add dialog closedBy dismissal policy#9366
maxyinger merged 3 commits into
mainfrom 
max/dialog-updates
Conversation
@maxyinger
@maxyingermaxyinger
commented
Aug 7, 2026

Copy link


Copy Markdown

Collaborator
Description
Adds closedBy to the Dialog, controlling which gestures dismiss it. Mirrors the native <dialog closedby> attribute:
ValueEscapeOutside pressProgrammatic
any (default)✅✅✅
closerequest✅❌✅
none❌❌✅
A single ordered enum rather than two booleans, so the fourth combination — outside press dismisses but Escape does not — stays unrepresentable.
The five Mosaic dialogs now use closerequest. This fixes a live bug in Destructive, where a stray backdrop click discarded the type-to-confirm input or closed the dialog mid-delete.
trigger on the Mosaic Dialog is now optional, so the machine-driven dialogs stop rendering a button they never use.
Checklist
  • pnpm test runs as expected.
  • pnpm build runs as expected.
  •  (If applicable) JSDoc comments have been added or updated for any package exports
  •  (If applicable) Documentation has been updated
Type of change
  •  🐛 Bug fix
  •  🌟 New feature
  •  🔨 Breaking change
  •  📖 Refactoring / dependency upgrade / documentation
  •  other:
@maxyinger@claude
feat(ui): add dialog closedBy dismissal policy
38e7c1f
Adds `closedBy: 'any' | 'closerequest' | 'none'` to the headless Dialog root,
driving `escapeKey` and `outsidePress` on `useDismiss`. Defaults to `any`, so
existing callers are unaffected.
The five Mosaic dialogs now use `closerequest`, which stops a stray backdrop
click from discarding the type-to-confirm input in `Destructive` or closing a
dialog mid-request.
`trigger` on the Mosaic `Dialog` becomes optional, so the machine-driven
dialogs no longer render a button they don't use.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
@vercel
vercelBot
commented
Aug 7, 2026•

edited

Loading

Copy link


Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.
ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxReadyReadyPreviewAug 12, 2026 7:33pm
swingsetReadyReadyPreviewAug 12, 2026 7:33pm
Request Review
@changeset-bot
changeset-botBot
commented
Aug 7, 2026•

edited

Loading

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: d089e1c
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 0 packages
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@pkg-pr-new
pkg-pr-newBot
commented
Aug 7, 2026•

edited

Loading

Copy link


Copy Markdown

Open in StackBlitz
@clerk/astro
npm i https://pkg.pr.new/@clerk/astro@9366

@clerk/backend
npm i https://pkg.pr.new/@clerk/backend@9366

@clerk/chrome-extension
npm i https://pkg.pr.new/@clerk/chrome-extension@9366

@clerk/clerk-js
npm i https://pkg.pr.new/@clerk/clerk-js@9366

@clerk/electron
npm i https://pkg.pr.new/@clerk/electron@9366

@clerk/electron-passkeys
npm i https://pkg.pr.new/@clerk/electron-passkeys@9366

@clerk/eslint-plugin
npm i https://pkg.pr.new/@clerk/eslint-plugin@9366

@clerk/expo
npm i https://pkg.pr.new/@clerk/expo@9366

@clerk/expo-google-signin
npm i https://pkg.pr.new/@clerk/expo-google-signin@9366

@clerk/expo-passkeys
npm i https://pkg.pr.new/@clerk/expo-passkeys@9366

@clerk/express
npm i https://pkg.pr.new/@clerk/express@9366

@clerk/fastify
npm i https://pkg.pr.new/@clerk/fastify@9366

@clerk/hono
npm i https://pkg.pr.new/@clerk/hono@9366

@clerk/localizations
npm i https://pkg.pr.new/@clerk/localizations@9366

@clerk/nextjs
npm i https://pkg.pr.new/@clerk/nextjs@9366

@clerk/nuxt
npm i https://pkg.pr.new/@clerk/nuxt@9366

@clerk/react
npm i https://pkg.pr.new/@clerk/react@9366

@clerk/react-router
npm i https://pkg.pr.new/@clerk/react-router@9366

@clerk/shared
npm i https://pkg.pr.new/@clerk/shared@9366

@clerk/tanstack-react-start
npm i https://pkg.pr.new/@clerk/tanstack-react-start@9366

@clerk/testing
npm i https://pkg.pr.new/@clerk/testing@9366

@clerk/ui
npm i https://pkg.pr.new/@clerk/ui@9366

@clerk/upgrade
npm i https://pkg.pr.new/@clerk/upgrade@9366

@clerk/vue
npm i https://pkg.pr.new/@clerk/vue@9366

commit: d089e1c
@github-actions
github-actionsBot
commented
Aug 7, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
API Changes Report
Generated by Break Check on 2026-08-12T19:34:24.670Z
Summary
MetricCount
Packages analyzed19
Packages with changes0
🔴 Breaking changes0
🟡 Non-breaking changes0
🟢 Additions0
No API Changes Detected
All packages have stable APIs with no detected changes.
Report generated by Break Check
Last ran on d089e1c.
@coderabbitai
coderabbitaiBot
commented
Aug 7, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Review Change Stack
No actionable comments were generated in the recent review. 🎉
ℹ️ Recent review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Organization UI (inherited)
Review profile: CHILL
Plan: Pro Plus
Run ID: 67559746-9f94-4d1b-a186-3f6bb30f7c12
📥 Commits
Reviewing files that changed from the base of the PR and between 7c1aa99 and d089e1c.
📒 Files selected for processing (1)
  • .changeset/lucky-donuts-invite.md
🔗 Linked repositories identified
CodeRabbit considers these linked repositories for cross-repo context during reviews:
  • clerk/clerk_go(manual)
  • clerk/dashboard(manual)
  • clerk/accounts(manual)
  • clerk/backoffice(manual)
  • clerk/clerk(manual)
  • clerk/clerk-docs(manual)
  • clerk/cloudflare-workers(manual)
  • clerk/clerk-ios(auto-detected)
  • clerk/cli(auto-detected)
  • clerk/clerk-android(auto-detected)
💤 Files with no reviewable changes (1)
  • .changeset/lucky-donuts-invite.md
📝 Walkthrough
Walkthrough
The headless dialog adds closedBy modes for Escape and outside-press dismissal. The public type is exported and covered by tests and documentation. Mosaic dialogs accept optional triggers and forward closedBy. Several organization dialogs use closerequest. The dialog story updates backdrop and viewport composition.
Estimated code review effort: 3 (Moderate) | ~20 minutes
Possibly related PRs
  • clerk/javascript#9388: Both PRs modify Dialog.Root and Mosaic dialog consumers to add and use the closedBy dismissal policy, including optional triggers.
  • clerk/javascript#9420: Both PRs introduce the closedBy API and dismissal behavior changes in the headless and Mosaic dialog implementations.
Suggested reviewers:austincalvelage
🚥 Pre-merge checks | ✅ 4 | ❌ 1
❌ Failed checks (1 warning)
Check nameStatusExplanationResolution
Docstring Coverage⚠️ WarningDocstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check nameStatusExplanation
Title check✅ PassedThe title clearly and concisely describes the new Dialog closedBy dismissal policy.
Description check✅ PassedThe description directly explains the closedBy feature, its dismissal behavior, and related Mosaic dialog changes.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
Comment @coderabbitai help to get the list of available commands.
coderabbitai[bot]
coderabbitaiBot
reviewed
Aug 7, 2026
View reviewed changes
@coderabbitaicoderabbitaiBot
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@packages/headless/src/primitives/dialog/dialog-root.tsx`:
- Around line 21-31: Update the shared closedBy='none' contract in
packages/headless/src/primitives/dialog/dialog-root.tsx lines 21-31,
packages/headless/src/primitives/dialog/README.md lines 74-94, and
.changeset/lucky-donuts-invite.md line 5: state that Escape and outside-press
dismissal are disabled while explicit close controls such as Dialog.Close remain
available. Use consistent wording across all three sites.

🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
  •  Push a commit to this branch (recommended)
  •  Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Organization UI (inherited)
Review profile: CHILL
Plan: Pro Plus
Run ID: 16d1a9d7-2fb9-415c-8aef-4a6c79b99611
📥 Commits
Reviewing files that changed from the base of the PR and between 6100719 and 38e7c1f.
📒 Files selected for processing (14)
  • .changeset/lucky-donuts-invite.md
  • packages/headless/src/primitives/dialog/README.md
  • packages/headless/src/primitives/dialog/dialog-root.tsx
  • packages/headless/src/primitives/dialog/dialog.test.tsx
  • packages/headless/src/primitives/dialog/index.ts
  • packages/headless/src/primitives/dialog/parts.ts
  • packages/swingset/src/stories/dialog.mdx
  • packages/swingset/src/stories/dialog.stories.tsx
  • packages/ui/src/mosaic/block/destructive.tsx
  • packages/ui/src/mosaic/components/dialog.tsx
  • packages/ui/src/mosaic/organization/organization-profile-domains-section-add-verify.view.tsx
  • packages/ui/src/mosaic/organization/organization-profile-domains-section-enrollment.view.tsx
  • packages/ui/src/mosaic/organization/organization-profile-domains-section-remove.view.tsx
  • packages/ui/src/mosaic/organization/organization-profile-profile-section.view.tsx
🔗 Linked repositories identified
CodeRabbit considers these linked repositories for cross-repo context during reviews:
  • clerk/clerk_go(manual)
  • clerk/dashboard(manual)
  • clerk/accounts(manual)
  • clerk/backoffice(manual)
  • clerk/clerk(manual)
  • clerk/clerk-docs(manual)
  • clerk/cloudflare-workers(manual)
  • clerk/clerk-ios(auto-detected)
  • clerk/cli(auto-detected)
  • clerk/clerk-android(auto-detected)
Comment threadpackages/headless/src/primitives/dialog/dialog-root.tsx
@coderabbitaicoderabbitaiBot
mentioned this pull request
Aug 11, 2026
 Merged

11 tasks
@coderabbitai
coderabbitaiBot
commented
Aug 12, 2026

Copy link


Copy Markdown

Contributor
Note
GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer.
@coderabbitaicoderabbitaiBot
mentioned this pull request
Aug 12, 2026
 Closed

9 tasks
@maxyinger
maxyinger
merged commit dfc9c0d
into
mainAug 12, 2026

111 of 118 checks passed

@maxyinger
maxyinger
deleted the

max/dialog-updates

branch
August 12, 2026 20:45
@coderabbitaicoderabbitaiBot
mentioned this pull request
Aug 12, 2026
 Open

9 tasks
@maxyingermaxyinger
mentioned this pull request
Aug 13, 2026
 Closed

9 tasks
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@coderabbitaicoderabbitai[bot]coderabbitai[bot] left review comments
@alexcarpenteralexcarpenteralexcarpenter approved these changes

Assignees


No one assigned


Labels

ui

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@maxyinger@alexcarpenter

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
feat(ui): add dialog closedBy dismissal policy by maxyinger · Pull Request #9366 · clerk/javascript · GitHub
Skip to content
feat(ui): add dialog closedBy dismissal policy - #9366
Merged
maxyinger merged 3 commits into
mainfrom 
max/dialog-updates
Aug 12, 2026
Merged
feat(ui): add dialog closedBy dismissal policy#9366
maxyinger merged 3 commits into
mainfrom 
max/dialog-updates
Conversation
@maxyinger
@maxyingermaxyinger
commented
Aug 7, 2026

Copy link


Copy Markdown

Collaborator
Description
Adds closedBy to the Dialog, controlling which gestures dismiss it. Mirrors the native <dialog closedby> attribute:
ValueEscapeOutside pressProgrammatic
any (default)✅✅✅
closerequest✅❌✅
none❌❌✅
A single ordered enum rather than two booleans, so the fourth combination — outside press dismisses but Escape does not — stays unrepresentable.
The five Mosaic dialogs now use closerequest. This fixes a live bug in Destructive, where a stray backdrop click discarded the type-to-confirm input or closed the dialog mid-delete.
trigger on the Mosaic Dialog is now optional, so the machine-driven dialogs stop rendering a button they never use.
Checklist
  • pnpm test runs as expected.
  • pnpm build runs as expected.
  •  (If applicable) JSDoc comments have been added or updated for any package exports
  •  (If applicable) Documentation has been updated
Type of change
  •  🐛 Bug fix
  •  🌟 New feature
  •  🔨 Breaking change
  •  📖 Refactoring / dependency upgrade / documentation
  •  other:
@maxyinger@claude
feat(ui): add dialog closedBy dismissal policy
38e7c1f
Adds `closedBy: 'any' | 'closerequest' | 'none'` to the headless Dialog root,
driving `escapeKey` and `outsidePress` on `useDismiss`. Defaults to `any`, so
existing callers are unaffected.
The five Mosaic dialogs now use `closerequest`, which stops a stray backdrop
click from discarding the type-to-confirm input in `Destructive` or closing a
dialog mid-request.
`trigger` on the Mosaic `Dialog` becomes optional, so the machine-driven
dialogs no longer render a button they don't use.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
@vercel
vercelBot
commented
Aug 7, 2026•

edited

Loading

Copy link


Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.
ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxReadyReadyPreviewAug 12, 2026 7:33pm
swingsetReadyReadyPreviewAug 12, 2026 7:33pm
Request Review
@changeset-bot
changeset-botBot
commented
Aug 7, 2026•

edited

Loading

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: d089e1c
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 0 packages
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@pkg-pr-new
pkg-pr-newBot
commented
Aug 7, 2026•

edited

Loading

Copy link


Copy Markdown

Open in StackBlitz
@clerk/astro
npm i https://pkg.pr.new/@clerk/astro@9366

@clerk/backend
npm i https://pkg.pr.new/@clerk/backend@9366

@clerk/chrome-extension
npm i https://pkg.pr.new/@clerk/chrome-extension@9366

@clerk/clerk-js
npm i https://pkg.pr.new/@clerk/clerk-js@9366

@clerk/electron
npm i https://pkg.pr.new/@clerk/electron@9366

@clerk/electron-passkeys
npm i https://pkg.pr.new/@clerk/electron-passkeys@9366

@clerk/eslint-plugin
npm i https://pkg.pr.new/@clerk/eslint-plugin@9366

@clerk/expo
npm i https://pkg.pr.new/@clerk/expo@9366

@clerk/expo-google-signin
npm i https://pkg.pr.new/@clerk/expo-google-signin@9366

@clerk/expo-passkeys
npm i https://pkg.pr.new/@clerk/expo-passkeys@9366

@clerk/express
npm i https://pkg.pr.new/@clerk/express@9366

@clerk/fastify
npm i https://pkg.pr.new/@clerk/fastify@9366

@clerk/hono
npm i https://pkg.pr.new/@clerk/hono@9366

@clerk/localizations
npm i https://pkg.pr.new/@clerk/localizations@9366

@clerk/nextjs
npm i https://pkg.pr.new/@clerk/nextjs@9366

@clerk/nuxt
npm i https://pkg.pr.new/@clerk/nuxt@9366

@clerk/react
npm i https://pkg.pr.new/@clerk/react@9366

@clerk/react-router
npm i https://pkg.pr.new/@clerk/react-router@9366

@clerk/shared
npm i https://pkg.pr.new/@clerk/shared@9366

@clerk/tanstack-react-start
npm i https://pkg.pr.new/@clerk/tanstack-react-start@9366

@clerk/testing
npm i https://pkg.pr.new/@clerk/testing@9366

@clerk/ui
npm i https://pkg.pr.new/@clerk/ui@9366

@clerk/upgrade
npm i https://pkg.pr.new/@clerk/upgrade@9366

@clerk/vue
npm i https://pkg.pr.new/@clerk/vue@9366

commit: d089e1c
@github-actions
github-actionsBot
commented
Aug 7, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
API Changes Report
Generated by Break Check on 2026-08-12T19:34:24.670Z
Summary
MetricCount
Packages analyzed19
Packages with changes0
🔴 Breaking changes0
🟡 Non-breaking changes0
🟢 Additions0
No API Changes Detected
All packages have stable APIs with no detected changes.
Report generated by Break Check
Last ran on d089e1c.
@coderabbitai
coderabbitaiBot
commented
Aug 7, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Review Change Stack
No actionable comments were generated in the recent review. 🎉
ℹ️ Recent review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Organization UI (inherited)
Review profile: CHILL
Plan: Pro Plus
Run ID: 67559746-9f94-4d1b-a186-3f6bb30f7c12
📥 Commits
Reviewing files that changed from the base of the PR and between 7c1aa99 and d089e1c.
📒 Files selected for processing (1)
  • .changeset/lucky-donuts-invite.md
🔗 Linked repositories identified
CodeRabbit considers these linked repositories for cross-repo context during reviews:
  • clerk/clerk_go(manual)
  • clerk/dashboard(manual)
  • clerk/accounts(manual)
  • clerk/backoffice(manual)
  • clerk/clerk(manual)
  • clerk/clerk-docs(manual)
  • clerk/cloudflare-workers(manual)
  • clerk/clerk-ios(auto-detected)
  • clerk/cli(auto-detected)
  • clerk/clerk-android(auto-detected)
💤 Files with no reviewable changes (1)
  • .changeset/lucky-donuts-invite.md
📝 Walkthrough
Walkthrough
The headless dialog adds closedBy modes for Escape and outside-press dismissal. The public type is exported and covered by tests and documentation. Mosaic dialogs accept optional triggers and forward closedBy. Several organization dialogs use closerequest. The dialog story updates backdrop and viewport composition.
Estimated code review effort: 3 (Moderate) | ~20 minutes
Possibly related PRs
  • clerk/javascript#9388: Both PRs modify Dialog.Root and Mosaic dialog consumers to add and use the closedBy dismissal policy, including optional triggers.
  • clerk/javascript#9420: Both PRs introduce the closedBy API and dismissal behavior changes in the headless and Mosaic dialog implementations.
Suggested reviewers:austincalvelage
🚥 Pre-merge checks | ✅ 4 | ❌ 1
❌ Failed checks (1 warning)
Check nameStatusExplanationResolution
Docstring Coverage⚠️ WarningDocstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check nameStatusExplanation
Title check✅ PassedThe title clearly and concisely describes the new Dialog closedBy dismissal policy.
Description check✅ PassedThe description directly explains the closedBy feature, its dismissal behavior, and related Mosaic dialog changes.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
Comment @coderabbitai help to get the list of available commands.
coderabbitai[bot]
coderabbitaiBot
reviewed
Aug 7, 2026
View reviewed changes
@coderabbitaicoderabbitaiBot
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@packages/headless/src/primitives/dialog/dialog-root.tsx`:
- Around line 21-31: Update the shared closedBy='none' contract in
packages/headless/src/primitives/dialog/dialog-root.tsx lines 21-31,
packages/headless/src/primitives/dialog/README.md lines 74-94, and
.changeset/lucky-donuts-invite.md line 5: state that Escape and outside-press
dismissal are disabled while explicit close controls such as Dialog.Close remain
available. Use consistent wording across all three sites.

🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
  •  Push a commit to this branch (recommended)
  •  Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Organization UI (inherited)
Review profile: CHILL
Plan: Pro Plus
Run ID: 16d1a9d7-2fb9-415c-8aef-4a6c79b99611
📥 Commits
Reviewing files that changed from the base of the PR and between 6100719 and 38e7c1f.
📒 Files selected for processing (14)
  • .changeset/lucky-donuts-invite.md
  • packages/headless/src/primitives/dialog/README.md
  • packages/headless/src/primitives/dialog/dialog-root.tsx
  • packages/headless/src/primitives/dialog/dialog.test.tsx
  • packages/headless/src/primitives/dialog/index.ts
  • packages/headless/src/primitives/dialog/parts.ts
  • packages/swingset/src/stories/dialog.mdx
  • packages/swingset/src/stories/dialog.stories.tsx
  • packages/ui/src/mosaic/block/destructive.tsx
  • packages/ui/src/mosaic/components/dialog.tsx
  • packages/ui/src/mosaic/organization/organization-profile-domains-section-add-verify.view.tsx
  • packages/ui/src/mosaic/organization/organization-profile-domains-section-enrollment.view.tsx
  • packages/ui/src/mosaic/organization/organization-profile-domains-section-remove.view.tsx
  • packages/ui/src/mosaic/organization/organization-profile-profile-section.view.tsx
🔗 Linked repositories identified
CodeRabbit considers these linked repositories for cross-repo context during reviews:
  • clerk/clerk_go(manual)
  • clerk/dashboard(manual)
  • clerk/accounts(manual)
  • clerk/backoffice(manual)
  • clerk/clerk(manual)
  • clerk/clerk-docs(manual)
  • clerk/cloudflare-workers(manual)
  • clerk/clerk-ios(auto-detected)
  • clerk/cli(auto-detected)
  • clerk/clerk-android(auto-detected)
Comment threadpackages/headless/src/primitives/dialog/dialog-root.tsx
@coderabbitaicoderabbitaiBot
mentioned this pull request
Aug 11, 2026
 Merged

11 tasks
@coderabbitai
coderabbitaiBot
commented
Aug 12, 2026

Copy link


Copy Markdown

Contributor
Note
GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer.
@coderabbitaicoderabbitaiBot
mentioned this pull request
Aug 12, 2026
 Closed

9 tasks
@maxyinger
maxyinger
merged commit dfc9c0d
into
mainAug 12, 2026

111 of 118 checks passed

@maxyinger
maxyinger
deleted the

max/dialog-updates

branch
August 12, 2026 20:45
@coderabbitaicoderabbitaiBot
mentioned this pull request
Aug 12, 2026
 Open

9 tasks
@maxyingermaxyinger
mentioned this pull request
Aug 13, 2026
 Closed

9 tasks
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@coderabbitaicoderabbitai[bot]coderabbitai[bot] left review comments
@alexcarpenteralexcarpenteralexcarpenter approved these changes

Assignees


No one assigned


Labels

ui

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@maxyinger@alexcarpenter

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
feat(ui): add dialog closedBy dismissal policy by maxyinger · Pull Request #9366 · clerk/javascript · GitHub
Skip to content
feat(ui): add dialog closedBy dismissal policy - #9366
Merged
maxyinger merged 3 commits into
mainfrom 
max/dialog-updates
Aug 12, 2026
Merged
feat(ui): add dialog closedBy dismissal policy#9366
maxyinger merged 3 commits into
mainfrom 
max/dialog-updates
Conversation
@maxyinger
@maxyingermaxyinger
commented
Aug 7, 2026

Copy link


Copy Markdown

Collaborator
Description
Adds closedBy to the Dialog, controlling which gestures dismiss it. Mirrors the native <dialog closedby> attribute:
ValueEscapeOutside pressProgrammatic
any (default)✅✅✅
closerequest✅❌✅
none❌❌✅
A single ordered enum rather than two booleans, so the fourth combination — outside press dismisses but Escape does not — stays unrepresentable.
The five Mosaic dialogs now use closerequest. This fixes a live bug in Destructive, where a stray backdrop click discarded the type-to-confirm input or closed the dialog mid-delete.
trigger on the Mosaic Dialog is now optional, so the machine-driven dialogs stop rendering a button they never use.
Checklist
  • pnpm test runs as expected.
  • pnpm build runs as expected.
  •  (If applicable) JSDoc comments have been added or updated for any package exports
  •  (If applicable) Documentation has been updated
Type of change
  •  🐛 Bug fix
  •  🌟 New feature
  •  🔨 Breaking change
  •  📖 Refactoring / dependency upgrade / documentation
  •  other:
@maxyinger@claude
feat(ui): add dialog closedBy dismissal policy
38e7c1f
Adds `closedBy: 'any' | 'closerequest' | 'none'` to the headless Dialog root,
driving `escapeKey` and `outsidePress` on `useDismiss`. Defaults to `any`, so
existing callers are unaffected.
The five Mosaic dialogs now use `closerequest`, which stops a stray backdrop
click from discarding the type-to-confirm input in `Destructive` or closing a
dialog mid-request.
`trigger` on the Mosaic `Dialog` becomes optional, so the machine-driven
dialogs no longer render a button they don't use.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
@vercel
vercelBot
commented
Aug 7, 2026•

edited

Loading

Copy link


Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.
ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxReadyReadyPreviewAug 12, 2026 7:33pm
swingsetReadyReadyPreviewAug 12, 2026 7:33pm
Request Review
@changeset-bot
changeset-botBot
commented
Aug 7, 2026•

edited

Loading

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: d089e1c
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 0 packages
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@pkg-pr-new
pkg-pr-newBot
commented
Aug 7, 2026•

edited

Loading

Copy link


Copy Markdown

Open in StackBlitz
@clerk/astro
npm i https://pkg.pr.new/@clerk/astro@9366

@clerk/backend
npm i https://pkg.pr.new/@clerk/backend@9366

@clerk/chrome-extension
npm i https://pkg.pr.new/@clerk/chrome-extension@9366

@clerk/clerk-js
npm i https://pkg.pr.new/@clerk/clerk-js@9366

@clerk/electron
npm i https://pkg.pr.new/@clerk/electron@9366

@clerk/electron-passkeys
npm i https://pkg.pr.new/@clerk/electron-passkeys@9366

@clerk/eslint-plugin
npm i https://pkg.pr.new/@clerk/eslint-plugin@9366

@clerk/expo
npm i https://pkg.pr.new/@clerk/expo@9366

@clerk/expo-google-signin
npm i https://pkg.pr.new/@clerk/expo-google-signin@9366

@clerk/expo-passkeys
npm i https://pkg.pr.new/@clerk/expo-passkeys@9366

@clerk/express
npm i https://pkg.pr.new/@clerk/express@9366

@clerk/fastify
npm i https://pkg.pr.new/@clerk/fastify@9366

@clerk/hono
npm i https://pkg.pr.new/@clerk/hono@9366

@clerk/localizations
npm i https://pkg.pr.new/@clerk/localizations@9366

@clerk/nextjs
npm i https://pkg.pr.new/@clerk/nextjs@9366

@clerk/nuxt
npm i https://pkg.pr.new/@clerk/nuxt@9366

@clerk/react
npm i https://pkg.pr.new/@clerk/react@9366

@clerk/react-router
npm i https://pkg.pr.new/@clerk/react-router@9366

@clerk/shared
npm i https://pkg.pr.new/@clerk/shared@9366

@clerk/tanstack-react-start
npm i https://pkg.pr.new/@clerk/tanstack-react-start@9366

@clerk/testing
npm i https://pkg.pr.new/@clerk/testing@9366

@clerk/ui
npm i https://pkg.pr.new/@clerk/ui@9366

@clerk/upgrade
npm i https://pkg.pr.new/@clerk/upgrade@9366

@clerk/vue
npm i https://pkg.pr.new/@clerk/vue@9366

commit: d089e1c
@github-actions
github-actionsBot
commented
Aug 7, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
API Changes Report
Generated by Break Check on 2026-08-12T19:34:24.670Z
Summary
MetricCount
Packages analyzed19
Packages with changes0
🔴 Breaking changes0
🟡 Non-breaking changes0
🟢 Additions0
No API Changes Detected
All packages have stable APIs with no detected changes.
Report generated by Break Check
Last ran on d089e1c.
@coderabbitai
coderabbitaiBot
commented
Aug 7, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Review Change Stack
No actionable comments were generated in the recent review. 🎉
ℹ️ Recent review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Organization UI (inherited)
Review profile: CHILL
Plan: Pro Plus
Run ID: 67559746-9f94-4d1b-a186-3f6bb30f7c12
📥 Commits
Reviewing files that changed from the base of the PR and between 7c1aa99 and d089e1c.
📒 Files selected for processing (1)
  • .changeset/lucky-donuts-invite.md
🔗 Linked repositories identified
CodeRabbit considers these linked repositories for cross-repo context during reviews:
  • clerk/clerk_go(manual)
  • clerk/dashboard(manual)
  • clerk/accounts(manual)
  • clerk/backoffice(manual)
  • clerk/clerk(manual)
  • clerk/clerk-docs(manual)
  • clerk/cloudflare-workers(manual)
  • clerk/clerk-ios(auto-detected)
  • clerk/cli(auto-detected)
  • clerk/clerk-android(auto-detected)
💤 Files with no reviewable changes (1)
  • .changeset/lucky-donuts-invite.md
📝 Walkthrough
Walkthrough
The headless dialog adds closedBy modes for Escape and outside-press dismissal. The public type is exported and covered by tests and documentation. Mosaic dialogs accept optional triggers and forward closedBy. Several organization dialogs use closerequest. The dialog story updates backdrop and viewport composition.
Estimated code review effort: 3 (Moderate) | ~20 minutes
Possibly related PRs
  • clerk/javascript#9388: Both PRs modify Dialog.Root and Mosaic dialog consumers to add and use the closedBy dismissal policy, including optional triggers.
  • clerk/javascript#9420: Both PRs introduce the closedBy API and dismissal behavior changes in the headless and Mosaic dialog implementations.
Suggested reviewers:austincalvelage
🚥 Pre-merge checks | ✅ 4 | ❌ 1
❌ Failed checks (1 warning)
Check nameStatusExplanationResolution
Docstring Coverage⚠️ WarningDocstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check nameStatusExplanation
Title check✅ PassedThe title clearly and concisely describes the new Dialog closedBy dismissal policy.
Description check✅ PassedThe description directly explains the closedBy feature, its dismissal behavior, and related Mosaic dialog changes.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
Comment @coderabbitai help to get the list of available commands.
coderabbitai[bot]
coderabbitaiBot
reviewed
Aug 7, 2026
View reviewed changes
@coderabbitaicoderabbitaiBot
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@packages/headless/src/primitives/dialog/dialog-root.tsx`:
- Around line 21-31: Update the shared closedBy='none' contract in
packages/headless/src/primitives/dialog/dialog-root.tsx lines 21-31,
packages/headless/src/primitives/dialog/README.md lines 74-94, and
.changeset/lucky-donuts-invite.md line 5: state that Escape and outside-press
dismissal are disabled while explicit close controls such as Dialog.Close remain
available. Use consistent wording across all three sites.

🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
  •  Push a commit to this branch (recommended)
  •  Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Organization UI (inherited)
Review profile: CHILL
Plan: Pro Plus
Run ID: 16d1a9d7-2fb9-415c-8aef-4a6c79b99611
📥 Commits
Reviewing files that changed from the base of the PR and between 6100719 and 38e7c1f.
📒 Files selected for processing (14)
  • .changeset/lucky-donuts-invite.md
  • packages/headless/src/primitives/dialog/README.md
  • packages/headless/src/primitives/dialog/dialog-root.tsx
  • packages/headless/src/primitives/dialog/dialog.test.tsx
  • packages/headless/src/primitives/dialog/index.ts
  • packages/headless/src/primitives/dialog/parts.ts
  • packages/swingset/src/stories/dialog.mdx
  • packages/swingset/src/stories/dialog.stories.tsx
  • packages/ui/src/mosaic/block/destructive.tsx
  • packages/ui/src/mosaic/components/dialog.tsx
  • packages/ui/src/mosaic/organization/organization-profile-domains-section-add-verify.view.tsx
  • packages/ui/src/mosaic/organization/organization-profile-domains-section-enrollment.view.tsx
  • packages/ui/src/mosaic/organization/organization-profile-domains-section-remove.view.tsx
  • packages/ui/src/mosaic/organization/organization-profile-profile-section.view.tsx
🔗 Linked repositories identified
CodeRabbit considers these linked repositories for cross-repo context during reviews:
  • clerk/clerk_go(manual)
  • clerk/dashboard(manual)
  • clerk/accounts(manual)
  • clerk/backoffice(manual)
  • clerk/clerk(manual)
  • clerk/clerk-docs(manual)
  • clerk/cloudflare-workers(manual)
  • clerk/clerk-ios(auto-detected)
  • clerk/cli(auto-detected)
  • clerk/clerk-android(auto-detected)
Comment threadpackages/headless/src/primitives/dialog/dialog-root.tsx
@coderabbitaicoderabbitaiBot
mentioned this pull request
Aug 11, 2026
 Merged

11 tasks
@coderabbitai
coderabbitaiBot
commented
Aug 12, 2026

Copy link


Copy Markdown

Contributor
Note
GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer.
@coderabbitaicoderabbitaiBot
mentioned this pull request
Aug 12, 2026
 Closed

9 tasks
@maxyinger
maxyinger
merged commit dfc9c0d
into
mainAug 12, 2026

111 of 118 checks passed

@maxyinger
maxyinger
deleted the

max/dialog-updates

branch
August 12, 2026 20:45
@coderabbitaicoderabbitaiBot
mentioned this pull request
Aug 12, 2026
 Open

9 tasks
@maxyingermaxyinger
mentioned this pull request
Aug 13, 2026
 Closed

9 tasks
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@coderabbitaicoderabbitai[bot]coderabbitai[bot] left review comments
@alexcarpenteralexcarpenteralexcarpenter approved these changes

Assignees


No one assigned


Labels

ui

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@maxyinger@alexcarpenter

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '
feat(ui): add dialog closedBy dismissal policy by maxyinger · Pull Request #9366 · clerk/javascript · GitHub
Skip to content
feat(ui): add dialog closedBy dismissal policy - #9366
Merged
maxyinger merged 3 commits into
mainfrom 
max/dialog-updates
Aug 12, 2026
Merged
feat(ui): add dialog closedBy dismissal policy#9366
maxyinger merged 3 commits into
mainfrom 
max/dialog-updates
Conversation
@maxyinger
@maxyingermaxyinger
commented
Aug 7, 2026

Copy link


Copy Markdown

Collaborator
Description
Adds closedBy to the Dialog, controlling which gestures dismiss it. Mirrors the native <dialog closedby> attribute:
ValueEscapeOutside pressProgrammatic
any (default)✅✅✅
closerequest✅❌✅
none❌❌✅
A single ordered enum rather than two booleans, so the fourth combination — outside press dismisses but Escape does not — stays unrepresentable.
The five Mosaic dialogs now use closerequest. This fixes a live bug in Destructive, where a stray backdrop click discarded the type-to-confirm input or closed the dialog mid-delete.
trigger on the Mosaic Dialog is now optional, so the machine-driven dialogs stop rendering a button they never use.
Checklist
  • pnpm test runs as expected.
  • pnpm build runs as expected.
  •  (If applicable) JSDoc comments have been added or updated for any package exports
  •  (If applicable) Documentation has been updated
Type of change
  •  🐛 Bug fix
  •  🌟 New feature
  •  🔨 Breaking change
  •  📖 Refactoring / dependency upgrade / documentation
  •  other:
@maxyinger@claude
feat(ui): add dialog closedBy dismissal policy
38e7c1f
Adds `closedBy: 'any' | 'closerequest' | 'none'` to the headless Dialog root,
driving `escapeKey` and `outsidePress` on `useDismiss`. Defaults to `any`, so
existing callers are unaffected.
The five Mosaic dialogs now use `closerequest`, which stops a stray backdrop
click from discarding the type-to-confirm input in `Destructive` or closing a
dialog mid-request.
`trigger` on the Mosaic `Dialog` becomes optional, so the machine-driven
dialogs no longer render a button they don't use.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
@vercel
vercelBot
commented
Aug 7, 2026•

edited

Loading

Copy link


Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.
ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxReadyReadyPreviewAug 12, 2026 7:33pm
swingsetReadyReadyPreviewAug 12, 2026 7:33pm
Request Review
@changeset-bot
changeset-botBot
commented
Aug 7, 2026•

edited

Loading

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: d089e1c
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 0 packages
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@pkg-pr-new
pkg-pr-newBot
commented
Aug 7, 2026•

edited

Loading

Copy link


Copy Markdown

Open in StackBlitz
@clerk/astro
npm i https://pkg.pr.new/@clerk/astro@9366

@clerk/backend
npm i https://pkg.pr.new/@clerk/backend@9366

@clerk/chrome-extension
npm i https://pkg.pr.new/@clerk/chrome-extension@9366

@clerk/clerk-js
npm i https://pkg.pr.new/@clerk/clerk-js@9366

@clerk/electron
npm i https://pkg.pr.new/@clerk/electron@9366

@clerk/electron-passkeys
npm i https://pkg.pr.new/@clerk/electron-passkeys@9366

@clerk/eslint-plugin
npm i https://pkg.pr.new/@clerk/eslint-plugin@9366

@clerk/expo
npm i https://pkg.pr.new/@clerk/expo@9366

@clerk/expo-google-signin
npm i https://pkg.pr.new/@clerk/expo-google-signin@9366

@clerk/expo-passkeys
npm i https://pkg.pr.new/@clerk/expo-passkeys@9366

@clerk/express
npm i https://pkg.pr.new/@clerk/express@9366

@clerk/fastify
npm i https://pkg.pr.new/@clerk/fastify@9366

@clerk/hono
npm i https://pkg.pr.new/@clerk/hono@9366

@clerk/localizations
npm i https://pkg.pr.new/@clerk/localizations@9366

@clerk/nextjs
npm i https://pkg.pr.new/@clerk/nextjs@9366

@clerk/nuxt
npm i https://pkg.pr.new/@clerk/nuxt@9366

@clerk/react
npm i https://pkg.pr.new/@clerk/react@9366

@clerk/react-router
npm i https://pkg.pr.new/@clerk/react-router@9366

@clerk/shared
npm i https://pkg.pr.new/@clerk/shared@9366

@clerk/tanstack-react-start
npm i https://pkg.pr.new/@clerk/tanstack-react-start@9366

@clerk/testing
npm i https://pkg.pr.new/@clerk/testing@9366

@clerk/ui
npm i https://pkg.pr.new/@clerk/ui@9366

@clerk/upgrade
npm i https://pkg.pr.new/@clerk/upgrade@9366

@clerk/vue
npm i https://pkg.pr.new/@clerk/vue@9366

commit: d089e1c
@github-actions
github-actionsBot
commented
Aug 7, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
API Changes Report
Generated by Break Check on 2026-08-12T19:34:24.670Z
Summary
MetricCount
Packages analyzed19
Packages with changes0
🔴 Breaking changes0
🟡 Non-breaking changes0
🟢 Additions0
No API Changes Detected
All packages have stable APIs with no detected changes.
Report generated by Break Check
Last ran on d089e1c.
@coderabbitai
coderabbitaiBot
commented
Aug 7, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Review Change Stack
No actionable comments were generated in the recent review. 🎉
ℹ️ Recent review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Organization UI (inherited)
Review profile: CHILL
Plan: Pro Plus
Run ID: 67559746-9f94-4d1b-a186-3f6bb30f7c12
📥 Commits
Reviewing files that changed from the base of the PR and between 7c1aa99 and d089e1c.
📒 Files selected for processing (1)
  • .changeset/lucky-donuts-invite.md
🔗 Linked repositories identified
CodeRabbit considers these linked repositories for cross-repo context during reviews:
  • clerk/clerk_go(manual)
  • clerk/dashboard(manual)
  • clerk/accounts(manual)
  • clerk/backoffice(manual)
  • clerk/clerk(manual)
  • clerk/clerk-docs(manual)
  • clerk/cloudflare-workers(manual)
  • clerk/clerk-ios(auto-detected)
  • clerk/cli(auto-detected)
  • clerk/clerk-android(auto-detected)
💤 Files with no reviewable changes (1)
  • .changeset/lucky-donuts-invite.md
📝 Walkthrough
Walkthrough
The headless dialog adds closedBy modes for Escape and outside-press dismissal. The public type is exported and covered by tests and documentation. Mosaic dialogs accept optional triggers and forward closedBy. Several organization dialogs use closerequest. The dialog story updates backdrop and viewport composition.
Estimated code review effort: 3 (Moderate) | ~20 minutes
Possibly related PRs
  • clerk/javascript#9388: Both PRs modify Dialog.Root and Mosaic dialog consumers to add and use the closedBy dismissal policy, including optional triggers.
  • clerk/javascript#9420: Both PRs introduce the closedBy API and dismissal behavior changes in the headless and Mosaic dialog implementations.
Suggested reviewers:austincalvelage
🚥 Pre-merge checks | ✅ 4 | ❌ 1
❌ Failed checks (1 warning)
Check nameStatusExplanationResolution
Docstring Coverage⚠️ WarningDocstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check nameStatusExplanation
Title check✅ PassedThe title clearly and concisely describes the new Dialog closedBy dismissal policy.
Description check✅ PassedThe description directly explains the closedBy feature, its dismissal behavior, and related Mosaic dialog changes.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
Comment @coderabbitai help to get the list of available commands.
coderabbitai[bot]
coderabbitaiBot
reviewed
Aug 7, 2026
View reviewed changes
@coderabbitaicoderabbitaiBot
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@packages/headless/src/primitives/dialog/dialog-root.tsx`:
- Around line 21-31: Update the shared closedBy='none' contract in
packages/headless/src/primitives/dialog/dialog-root.tsx lines 21-31,
packages/headless/src/primitives/dialog/README.md lines 74-94, and
.changeset/lucky-donuts-invite.md line 5: state that Escape and outside-press
dismissal are disabled while explicit close controls such as Dialog.Close remain
available. Use consistent wording across all three sites.

🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
  •  Push a commit to this branch (recommended)
  •  Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Organization UI (inherited)
Review profile: CHILL
Plan: Pro Plus
Run ID: 16d1a9d7-2fb9-415c-8aef-4a6c79b99611
📥 Commits
Reviewing files that changed from the base of the PR and between 6100719 and 38e7c1f.
📒 Files selected for processing (14)
  • .changeset/lucky-donuts-invite.md
  • packages/headless/src/primitives/dialog/README.md
  • packages/headless/src/primitives/dialog/dialog-root.tsx
  • packages/headless/src/primitives/dialog/dialog.test.tsx
  • packages/headless/src/primitives/dialog/index.ts
  • packages/headless/src/primitives/dialog/parts.ts
  • packages/swingset/src/stories/dialog.mdx
  • packages/swingset/src/stories/dialog.stories.tsx
  • packages/ui/src/mosaic/block/destructive.tsx
  • packages/ui/src/mosaic/components/dialog.tsx
  • packages/ui/src/mosaic/organization/organization-profile-domains-section-add-verify.view.tsx
  • packages/ui/src/mosaic/organization/organization-profile-domains-section-enrollment.view.tsx
  • packages/ui/src/mosaic/organization/organization-profile-domains-section-remove.view.tsx
  • packages/ui/src/mosaic/organization/organization-profile-profile-section.view.tsx
🔗 Linked repositories identified
CodeRabbit considers these linked repositories for cross-repo context during reviews:
  • clerk/clerk_go(manual)
  • clerk/dashboard(manual)
  • clerk/accounts(manual)
  • clerk/backoffice(manual)
  • clerk/clerk(manual)
  • clerk/clerk-docs(manual)
  • clerk/cloudflare-workers(manual)
  • clerk/clerk-ios(auto-detected)
  • clerk/cli(auto-detected)
  • clerk/clerk-android(auto-detected)
Comment threadpackages/headless/src/primitives/dialog/dialog-root.tsx
@coderabbitaicoderabbitaiBot
mentioned this pull request
Aug 11, 2026
 Merged

11 tasks
@coderabbitai
coderabbitaiBot
commented
Aug 12, 2026

Copy link


Copy Markdown

Contributor
Note
GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer.
@coderabbitaicoderabbitaiBot
mentioned this pull request
Aug 12, 2026
 Closed

9 tasks
@maxyinger
maxyinger
merged commit dfc9c0d
into
mainAug 12, 2026

111 of 118 checks passed

@maxyinger
maxyinger
deleted the

max/dialog-updates

branch
August 12, 2026 20:45
@coderabbitaicoderabbitaiBot
mentioned this pull request
Aug 12, 2026
 Open

9 tasks
@maxyingermaxyinger
mentioned this pull request
Aug 13, 2026
 Closed

9 tasks
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@coderabbitaicoderabbitai[bot]coderabbitai[bot] left review comments
@alexcarpenteralexcarpenteralexcarpenter approved these changes

Assignees


No one assigned


Labels

ui

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@maxyinger@alexcarpenter

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
feat(ui): add dialog closedBy dismissal policy by maxyinger · Pull Request #9366 · clerk/javascript · GitHub
Skip to content
feat(ui): add dialog closedBy dismissal policy - #9366
Merged
maxyinger merged 3 commits into
mainfrom 
max/dialog-updates
Aug 12, 2026
Merged
feat(ui): add dialog closedBy dismissal policy#9366
maxyinger merged 3 commits into
mainfrom 
max/dialog-updates
Conversation
@maxyinger
@maxyingermaxyinger
commented
Aug 7, 2026

Copy link


Copy Markdown

Collaborator
Description
Adds closedBy to the Dialog, controlling which gestures dismiss it. Mirrors the native <dialog closedby> attribute:
ValueEscapeOutside pressProgrammatic
any (default)✅✅✅
closerequest✅❌✅
none❌❌✅
A single ordered enum rather than two booleans, so the fourth combination — outside press dismisses but Escape does not — stays unrepresentable.
The five Mosaic dialogs now use closerequest. This fixes a live bug in Destructive, where a stray backdrop click discarded the type-to-confirm input or closed the dialog mid-delete.
trigger on the Mosaic Dialog is now optional, so the machine-driven dialogs stop rendering a button they never use.
Checklist
  • pnpm test runs as expected.
  • pnpm build runs as expected.
  •  (If applicable) JSDoc comments have been added or updated for any package exports
  •  (If applicable) Documentation has been updated
Type of change
  •  🐛 Bug fix
  •  🌟 New feature
  •  🔨 Breaking change
  •  📖 Refactoring / dependency upgrade / documentation
  •  other:
@maxyinger@claude
feat(ui): add dialog closedBy dismissal policy
38e7c1f
Adds `closedBy: 'any' | 'closerequest' | 'none'` to the headless Dialog root,
driving `escapeKey` and `outsidePress` on `useDismiss`. Defaults to `any`, so
existing callers are unaffected.
The five Mosaic dialogs now use `closerequest`, which stops a stray backdrop
click from discarding the type-to-confirm input in `Destructive` or closing a
dialog mid-request.
`trigger` on the Mosaic `Dialog` becomes optional, so the machine-driven
dialogs no longer render a button they don't use.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
@vercel
vercelBot
commented
Aug 7, 2026•

edited

Loading

Copy link


Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.
ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxReadyReadyPreviewAug 12, 2026 7:33pm
swingsetReadyReadyPreviewAug 12, 2026 7:33pm
Request Review
@changeset-bot
changeset-botBot
commented
Aug 7, 2026•

edited

Loading

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: d089e1c
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 0 packages
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@pkg-pr-new
pkg-pr-newBot
commented
Aug 7, 2026•

edited

Loading

Copy link


Copy Markdown

Open in StackBlitz
@clerk/astro
npm i https://pkg.pr.new/@clerk/astro@9366

@clerk/backend
npm i https://pkg.pr.new/@clerk/backend@9366

@clerk/chrome-extension
npm i https://pkg.pr.new/@clerk/chrome-extension@9366

@clerk/clerk-js
npm i https://pkg.pr.new/@clerk/clerk-js@9366

@clerk/electron
npm i https://pkg.pr.new/@clerk/electron@9366

@clerk/electron-passkeys
npm i https://pkg.pr.new/@clerk/electron-passkeys@9366

@clerk/eslint-plugin
npm i https://pkg.pr.new/@clerk/eslint-plugin@9366

@clerk/expo
npm i https://pkg.pr.new/@clerk/expo@9366

@clerk/expo-google-signin
npm i https://pkg.pr.new/@clerk/expo-google-signin@9366

@clerk/expo-passkeys
npm i https://pkg.pr.new/@clerk/expo-passkeys@9366

@clerk/express
npm i https://pkg.pr.new/@clerk/express@9366

@clerk/fastify
npm i https://pkg.pr.new/@clerk/fastify@9366

@clerk/hono
npm i https://pkg.pr.new/@clerk/hono@9366

@clerk/localizations
npm i https://pkg.pr.new/@clerk/localizations@9366

@clerk/nextjs
npm i https://pkg.pr.new/@clerk/nextjs@9366

@clerk/nuxt
npm i https://pkg.pr.new/@clerk/nuxt@9366

@clerk/react
npm i https://pkg.pr.new/@clerk/react@9366

@clerk/react-router
npm i https://pkg.pr.new/@clerk/react-router@9366

@clerk/shared
npm i https://pkg.pr.new/@clerk/shared@9366

@clerk/tanstack-react-start
npm i https://pkg.pr.new/@clerk/tanstack-react-start@9366

@clerk/testing
npm i https://pkg.pr.new/@clerk/testing@9366

@clerk/ui
npm i https://pkg.pr.new/@clerk/ui@9366

@clerk/upgrade
npm i https://pkg.pr.new/@clerk/upgrade@9366

@clerk/vue
npm i https://pkg.pr.new/@clerk/vue@9366

commit: d089e1c
@github-actions
github-actionsBot
commented
Aug 7, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
API Changes Report
Generated by Break Check on 2026-08-12T19:34:24.670Z
Summary
MetricCount
Packages analyzed19
Packages with changes0
🔴 Breaking changes0
🟡 Non-breaking changes0
🟢 Additions0
No API Changes Detected
All packages have stable APIs with no detected changes.
Report generated by Break Check
Last ran on d089e1c.
@coderabbitai
coderabbitaiBot
commented
Aug 7, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Review Change Stack
No actionable comments were generated in the recent review. 🎉
ℹ️ Recent review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Organization UI (inherited)
Review profile: CHILL
Plan: Pro Plus
Run ID: 67559746-9f94-4d1b-a186-3f6bb30f7c12
📥 Commits
Reviewing files that changed from the base of the PR and between 7c1aa99 and d089e1c.
📒 Files selected for processing (1)
  • .changeset/lucky-donuts-invite.md
🔗 Linked repositories identified
CodeRabbit considers these linked repositories for cross-repo context during reviews:
  • clerk/clerk_go(manual)
  • clerk/dashboard(manual)
  • clerk/accounts(manual)
  • clerk/backoffice(manual)
  • clerk/clerk(manual)
  • clerk/clerk-docs(manual)
  • clerk/cloudflare-workers(manual)
  • clerk/clerk-ios(auto-detected)
  • clerk/cli(auto-detected)
  • clerk/clerk-android(auto-detected)
💤 Files with no reviewable changes (1)
  • .changeset/lucky-donuts-invite.md
📝 Walkthrough
Walkthrough
The headless dialog adds closedBy modes for Escape and outside-press dismissal. The public type is exported and covered by tests and documentation. Mosaic dialogs accept optional triggers and forward closedBy. Several organization dialogs use closerequest. The dialog story updates backdrop and viewport composition.
Estimated code review effort: 3 (Moderate) | ~20 minutes
Possibly related PRs
  • clerk/javascript#9388: Both PRs modify Dialog.Root and Mosaic dialog consumers to add and use the closedBy dismissal policy, including optional triggers.
  • clerk/javascript#9420: Both PRs introduce the closedBy API and dismissal behavior changes in the headless and Mosaic dialog implementations.
Suggested reviewers:austincalvelage
🚥 Pre-merge checks | ✅ 4 | ❌ 1
❌ Failed checks (1 warning)
Check nameStatusExplanationResolution
Docstring Coverage⚠️ WarningDocstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check nameStatusExplanation
Title check✅ PassedThe title clearly and concisely describes the new Dialog closedBy dismissal policy.
Description check✅ PassedThe description directly explains the closedBy feature, its dismissal behavior, and related Mosaic dialog changes.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
Comment @coderabbitai help to get the list of available commands.
coderabbitai[bot]
coderabbitaiBot
reviewed
Aug 7, 2026
View reviewed changes
@coderabbitaicoderabbitaiBot
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@packages/headless/src/primitives/dialog/dialog-root.tsx`:
- Around line 21-31: Update the shared closedBy='none' contract in
packages/headless/src/primitives/dialog/dialog-root.tsx lines 21-31,
packages/headless/src/primitives/dialog/README.md lines 74-94, and
.changeset/lucky-donuts-invite.md line 5: state that Escape and outside-press
dismissal are disabled while explicit close controls such as Dialog.Close remain
available. Use consistent wording across all three sites.

🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
  •  Push a commit to this branch (recommended)
  •  Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Organization UI (inherited)
Review profile: CHILL
Plan: Pro Plus
Run ID: 16d1a9d7-2fb9-415c-8aef-4a6c79b99611
📥 Commits
Reviewing files that changed from the base of the PR and between 6100719 and 38e7c1f.
📒 Files selected for processing (14)
  • .changeset/lucky-donuts-invite.md
  • packages/headless/src/primitives/dialog/README.md
  • packages/headless/src/primitives/dialog/dialog-root.tsx
  • packages/headless/src/primitives/dialog/dialog.test.tsx
  • packages/headless/src/primitives/dialog/index.ts
  • packages/headless/src/primitives/dialog/parts.ts
  • packages/swingset/src/stories/dialog.mdx
  • packages/swingset/src/stories/dialog.stories.tsx
  • packages/ui/src/mosaic/block/destructive.tsx
  • packages/ui/src/mosaic/components/dialog.tsx
  • packages/ui/src/mosaic/organization/organization-profile-domains-section-add-verify.view.tsx
  • packages/ui/src/mosaic/organization/organization-profile-domains-section-enrollment.view.tsx
  • packages/ui/src/mosaic/organization/organization-profile-domains-section-remove.view.tsx
  • packages/ui/src/mosaic/organization/organization-profile-profile-section.view.tsx
🔗 Linked repositories identified
CodeRabbit considers these linked repositories for cross-repo context during reviews:
  • clerk/clerk_go(manual)
  • clerk/dashboard(manual)
  • clerk/accounts(manual)
  • clerk/backoffice(manual)
  • clerk/clerk(manual)
  • clerk/clerk-docs(manual)
  • clerk/cloudflare-workers(manual)
  • clerk/clerk-ios(auto-detected)
  • clerk/cli(auto-detected)
  • clerk/clerk-android(auto-detected)
Comment threadpackages/headless/src/primitives/dialog/dialog-root.tsx
@coderabbitaicoderabbitaiBot
mentioned this pull request
Aug 11, 2026
 Merged

11 tasks
@coderabbitai
coderabbitaiBot
commented
Aug 12, 2026

Copy link


Copy Markdown

Contributor
Note
GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer.
@coderabbitaicoderabbitaiBot
mentioned this pull request
Aug 12, 2026
 Closed

9 tasks
@maxyinger
maxyinger
merged commit dfc9c0d
into
mainAug 12, 2026

111 of 118 checks passed

@maxyinger
maxyinger
deleted the

max/dialog-updates

branch
August 12, 2026 20:45
@coderabbitaicoderabbitaiBot
mentioned this pull request
Aug 12, 2026
 Open

9 tasks
@maxyingermaxyinger
mentioned this pull request
Aug 13, 2026
 Closed

9 tasks
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@coderabbitaicoderabbitai[bot]coderabbitai[bot] left review comments
@alexcarpenteralexcarpenteralexcarpenter approved these changes

Assignees


No one assigned


Labels

ui

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@maxyinger@alexcarpenter

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
feat(ui): add dialog closedBy dismissal policy by maxyinger · Pull Request #9366 · clerk/javascript · GitHub
Skip to content
feat(ui): add dialog closedBy dismissal policy - #9366
Merged
maxyinger merged 3 commits into
mainfrom 
max/dialog-updates
Aug 12, 2026
Merged
feat(ui): add dialog closedBy dismissal policy#9366
maxyinger merged 3 commits into
mainfrom 
max/dialog-updates
Conversation
@maxyinger
@maxyingermaxyinger
commented
Aug 7, 2026

Copy link


Copy Markdown

Collaborator
Description
Adds closedBy to the Dialog, controlling which gestures dismiss it. Mirrors the native <dialog closedby> attribute:
ValueEscapeOutside pressProgrammatic
any (default)✅✅✅
closerequest✅❌✅
none❌❌✅
A single ordered enum rather than two booleans, so the fourth combination — outside press dismisses but Escape does not — stays unrepresentable.
The five Mosaic dialogs now use closerequest. This fixes a live bug in Destructive, where a stray backdrop click discarded the type-to-confirm input or closed the dialog mid-delete.
trigger on the Mosaic Dialog is now optional, so the machine-driven dialogs stop rendering a button they never use.
Checklist
  • pnpm test runs as expected.
  • pnpm build runs as expected.
  •  (If applicable) JSDoc comments have been added or updated for any package exports
  •  (If applicable) Documentation has been updated
Type of change
  •  🐛 Bug fix
  •  🌟 New feature
  •  🔨 Breaking change
  •  📖 Refactoring / dependency upgrade / documentation
  •  other:
@maxyinger@claude
feat(ui): add dialog closedBy dismissal policy
38e7c1f
Adds `closedBy: 'any' | 'closerequest' | 'none'` to the headless Dialog root,
driving `escapeKey` and `outsidePress` on `useDismiss`. Defaults to `any`, so
existing callers are unaffected.
The five Mosaic dialogs now use `closerequest`, which stops a stray backdrop
click from discarding the type-to-confirm input in `Destructive` or closing a
dialog mid-request.
`trigger` on the Mosaic `Dialog` becomes optional, so the machine-driven
dialogs no longer render a button they don't use.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
@vercel
vercelBot
commented
Aug 7, 2026•

edited

Loading

Copy link


Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.
ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxReadyReadyPreviewAug 12, 2026 7:33pm
swingsetReadyReadyPreviewAug 12, 2026 7:33pm
Request Review
@changeset-bot
changeset-botBot
commented
Aug 7, 2026•

edited

Loading

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: d089e1c
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 0 packages
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@pkg-pr-new
pkg-pr-newBot
commented
Aug 7, 2026•

edited

Loading

Copy link


Copy Markdown

Open in StackBlitz
@clerk/astro
npm i https://pkg.pr.new/@clerk/astro@9366

@clerk/backend
npm i https://pkg.pr.new/@clerk/backend@9366

@clerk/chrome-extension
npm i https://pkg.pr.new/@clerk/chrome-extension@9366

@clerk/clerk-js
npm i https://pkg.pr.new/@clerk/clerk-js@9366

@clerk/electron
npm i https://pkg.pr.new/@clerk/electron@9366

@clerk/electron-passkeys
npm i https://pkg.pr.new/@clerk/electron-passkeys@9366

@clerk/eslint-plugin
npm i https://pkg.pr.new/@clerk/eslint-plugin@9366

@clerk/expo
npm i https://pkg.pr.new/@clerk/expo@9366

@clerk/expo-google-signin
npm i https://pkg.pr.new/@clerk/expo-google-signin@9366

@clerk/expo-passkeys
npm i https://pkg.pr.new/@clerk/expo-passkeys@9366

@clerk/express
npm i https://pkg.pr.new/@clerk/express@9366

@clerk/fastify
npm i https://pkg.pr.new/@clerk/fastify@9366

@clerk/hono
npm i https://pkg.pr.new/@clerk/hono@9366

@clerk/localizations
npm i https://pkg.pr.new/@clerk/localizations@9366

@clerk/nextjs
npm i https://pkg.pr.new/@clerk/nextjs@9366

@clerk/nuxt
npm i https://pkg.pr.new/@clerk/nuxt@9366

@clerk/react
npm i https://pkg.pr.new/@clerk/react@9366

@clerk/react-router
npm i https://pkg.pr.new/@clerk/react-router@9366

@clerk/shared
npm i https://pkg.pr.new/@clerk/shared@9366

@clerk/tanstack-react-start
npm i https://pkg.pr.new/@clerk/tanstack-react-start@9366

@clerk/testing
npm i https://pkg.pr.new/@clerk/testing@9366

@clerk/ui
npm i https://pkg.pr.new/@clerk/ui@9366

@clerk/upgrade
npm i https://pkg.pr.new/@clerk/upgrade@9366

@clerk/vue
npm i https://pkg.pr.new/@clerk/vue@9366

commit: d089e1c
@github-actions
github-actionsBot
commented
Aug 7, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
API Changes Report
Generated by Break Check on 2026-08-12T19:34:24.670Z
Summary
MetricCount
Packages analyzed19
Packages with changes0
🔴 Breaking changes0
🟡 Non-breaking changes0
🟢 Additions0
No API Changes Detected
All packages have stable APIs with no detected changes.
Report generated by Break Check
Last ran on d089e1c.
@coderabbitai
coderabbitaiBot
commented
Aug 7, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Review Change Stack
No actionable comments were generated in the recent review. 🎉
ℹ️ Recent review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Organization UI (inherited)
Review profile: CHILL
Plan: Pro Plus
Run ID: 67559746-9f94-4d1b-a186-3f6bb30f7c12
📥 Commits
Reviewing files that changed from the base of the PR and between 7c1aa99 and d089e1c.
📒 Files selected for processing (1)
  • .changeset/lucky-donuts-invite.md
🔗 Linked repositories identified
CodeRabbit considers these linked repositories for cross-repo context during reviews:
  • clerk/clerk_go(manual)
  • clerk/dashboard(manual)
  • clerk/accounts(manual)
  • clerk/backoffice(manual)
  • clerk/clerk(manual)
  • clerk/clerk-docs(manual)
  • clerk/cloudflare-workers(manual)
  • clerk/clerk-ios(auto-detected)
  • clerk/cli(auto-detected)
  • clerk/clerk-android(auto-detected)
💤 Files with no reviewable changes (1)
  • .changeset/lucky-donuts-invite.md
📝 Walkthrough
Walkthrough
The headless dialog adds closedBy modes for Escape and outside-press dismissal. The public type is exported and covered by tests and documentation. Mosaic dialogs accept optional triggers and forward closedBy. Several organization dialogs use closerequest. The dialog story updates backdrop and viewport composition.
Estimated code review effort: 3 (Moderate) | ~20 minutes
Possibly related PRs
  • clerk/javascript#9388: Both PRs modify Dialog.Root and Mosaic dialog consumers to add and use the closedBy dismissal policy, including optional triggers.
  • clerk/javascript#9420: Both PRs introduce the closedBy API and dismissal behavior changes in the headless and Mosaic dialog implementations.
Suggested reviewers:austincalvelage
🚥 Pre-merge checks | ✅ 4 | ❌ 1
❌ Failed checks (1 warning)
Check nameStatusExplanationResolution
Docstring Coverage⚠️ WarningDocstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check nameStatusExplanation
Title check✅ PassedThe title clearly and concisely describes the new Dialog closedBy dismissal policy.
Description check✅ PassedThe description directly explains the closedBy feature, its dismissal behavior, and related Mosaic dialog changes.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
Comment @coderabbitai help to get the list of available commands.
coderabbitai[bot]
coderabbitaiBot
reviewed
Aug 7, 2026
View reviewed changes
@coderabbitaicoderabbitaiBot
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@packages/headless/src/primitives/dialog/dialog-root.tsx`:
- Around line 21-31: Update the shared closedBy='none' contract in
packages/headless/src/primitives/dialog/dialog-root.tsx lines 21-31,
packages/headless/src/primitives/dialog/README.md lines 74-94, and
.changeset/lucky-donuts-invite.md line 5: state that Escape and outside-press
dismissal are disabled while explicit close controls such as Dialog.Close remain
available. Use consistent wording across all three sites.

🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
  •  Push a commit to this branch (recommended)
  •  Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Organization UI (inherited)
Review profile: CHILL
Plan: Pro Plus
Run ID: 16d1a9d7-2fb9-415c-8aef-4a6c79b99611
📥 Commits
Reviewing files that changed from the base of the PR and between 6100719 and 38e7c1f.
📒 Files selected for processing (14)
  • .changeset/lucky-donuts-invite.md
  • packages/headless/src/primitives/dialog/README.md
  • packages/headless/src/primitives/dialog/dialog-root.tsx
  • packages/headless/src/primitives/dialog/dialog.test.tsx
  • packages/headless/src/primitives/dialog/index.ts
  • packages/headless/src/primitives/dialog/parts.ts
  • packages/swingset/src/stories/dialog.mdx
  • packages/swingset/src/stories/dialog.stories.tsx
  • packages/ui/src/mosaic/block/destructive.tsx
  • packages/ui/src/mosaic/components/dialog.tsx
  • packages/ui/src/mosaic/organization/organization-profile-domains-section-add-verify.view.tsx
  • packages/ui/src/mosaic/organization/organization-profile-domains-section-enrollment.view.tsx
  • packages/ui/src/mosaic/organization/organization-profile-domains-section-remove.view.tsx
  • packages/ui/src/mosaic/organization/organization-profile-profile-section.view.tsx
🔗 Linked repositories identified
CodeRabbit considers these linked repositories for cross-repo context during reviews:
  • clerk/clerk_go(manual)
  • clerk/dashboard(manual)
  • clerk/accounts(manual)
  • clerk/backoffice(manual)
  • clerk/clerk(manual)
  • clerk/clerk-docs(manual)
  • clerk/cloudflare-workers(manual)
  • clerk/clerk-ios(auto-detected)
  • clerk/cli(auto-detected)
  • clerk/clerk-android(auto-detected)
Comment threadpackages/headless/src/primitives/dialog/dialog-root.tsx
@coderabbitaicoderabbitaiBot
mentioned this pull request
Aug 11, 2026
 Merged

11 tasks
@coderabbitai
coderabbitaiBot
commented
Aug 12, 2026

Copy link


Copy Markdown

Contributor
Note
GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer.
@coderabbitaicoderabbitaiBot
mentioned this pull request
Aug 12, 2026
 Closed

9 tasks
@maxyinger
maxyinger
merged commit dfc9c0d
into
mainAug 12, 2026

111 of 118 checks passed

@maxyinger
maxyinger
deleted the

max/dialog-updates

branch
August 12, 2026 20:45
@coderabbitaicoderabbitaiBot
mentioned this pull request
Aug 12, 2026
 Open

9 tasks
@maxyingermaxyinger
mentioned this pull request
Aug 13, 2026
 Closed

9 tasks
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@coderabbitaicoderabbitai[bot]coderabbitai[bot] left review comments
@alexcarpenteralexcarpenteralexcarpenter approved these changes

Assignees


No one assigned


Labels

ui

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@maxyinger@alexcarpenter

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Universal Dark Mode - works on any site
(function() {
var enabled = true;
function applyDarkMode() {
if (!enabled) return;
// Create style element if it doesn't exist
var style = document.getElementById('universal-dark-mode-style');
if (!style) {
style = document.createElement('style');
style.id = 'universal-dark-mode-style';
document.head.appendChild(style);
}
// Dark mode CSS - inverts colors but preserves images/video
style.textContent = '
/* Invert everything except media */
html {
filter: invert(1) hue-rotate(180deg) !important;
background: #1a1a2e !important;
}
/* Restore images, videos, iframes, canvas */
img, video, iframe, canvas, svg, picture, [style*="background-image"] {
filter: invert(1) hue-rotate(180deg) !important;
}
/* Preserve specific elements that should not be inverted */
.no-dark-mode, .no-dark-mode *,
[data-theme="light"], [data-theme="light"],
.ace_editor, .ace_editor *,
.CodeMirror, .CodeMirror *,
.monaco-editor, .monaco-editor *,
.markdown-body pre, .markdown-body pre *,
.highlight, .highlight *,
pre code, pre code * {
filter: none !important;
}
/* Fix common UI elements */
.modal, .popup, .dropdown-menu, .tooltip, .popover {
filter: invert(1) hue-rotate(180deg) !important;
background: #2d2d44 !important;
border-color: #444 !important;
}
/* Scrollbars */
::-webkit-scrollbar { background: #1a1a2e !important; }
::-webkit-scrollbar-thumb { background: #444 !important; }
::-webkit-scrollbar-thumb:hover { background: #555 !important; }
/* Selection */
::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
';
}
function removeDarkMode() {
var style = document.getElementById('universal-dark-mode-style');
if (style) style.remove();
}
// Toggle with Alt+Shift+D
document.addEventListener('keydown', function(e) {
if (e.altKey && e.shiftKey && e.key === 'D') {
e.preventDefault();
enabled = !enabled;
if (enabled) {
applyDarkMode();
console.log('[Universal Dark Mode] Enabled');
} else {
removeDarkMode();
console.log('[Universal Dark Mode] Disabled');
}
}
});
// Apply on load
applyDarkMode();
// Re-apply on dynamic content
var observer = new MutationObserver(function(mutations) {
if (enabled && !document.getElementById('universal-dark-mode-style')) {
applyDarkMode();
}
});
observer.observe(document.head, { childList: true });
console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');
})();
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();
feat(ui): add dialog closedBy dismissal policy by maxyinger · Pull Request #9366 · clerk/javascript · GitHub
Skip to content
feat(ui): add dialog closedBy dismissal policy - #9366
Merged
maxyinger merged 3 commits into
mainfrom 
max/dialog-updates
Aug 12, 2026
Merged
feat(ui): add dialog closedBy dismissal policy#9366
maxyinger merged 3 commits into
mainfrom 
max/dialog-updates
Conversation
@maxyinger
@maxyingermaxyinger
commented
Aug 7, 2026

Copy link


Copy Markdown

Collaborator
Description
Adds closedBy to the Dialog, controlling which gestures dismiss it. Mirrors the native <dialog closedby> attribute:
ValueEscapeOutside pressProgrammatic
any (default)✅✅✅
closerequest✅❌✅
none❌❌✅
A single ordered enum rather than two booleans, so the fourth combination — outside press dismisses but Escape does not — stays unrepresentable.
The five Mosaic dialogs now use closerequest. This fixes a live bug in Destructive, where a stray backdrop click discarded the type-to-confirm input or closed the dialog mid-delete.
trigger on the Mosaic Dialog is now optional, so the machine-driven dialogs stop rendering a button they never use.
Checklist
  • pnpm test runs as expected.
  • pnpm build runs as expected.
  •  (If applicable) JSDoc comments have been added or updated for any package exports
  •  (If applicable) Documentation has been updated
Type of change
  •  🐛 Bug fix
  •  🌟 New feature
  •  🔨 Breaking change
  •  📖 Refactoring / dependency upgrade / documentation
  •  other:
@maxyinger@claude
feat(ui): add dialog closedBy dismissal policy
38e7c1f
Adds `closedBy: 'any' | 'closerequest' | 'none'` to the headless Dialog root,
driving `escapeKey` and `outsidePress` on `useDismiss`. Defaults to `any`, so
existing callers are unaffected.
The five Mosaic dialogs now use `closerequest`, which stops a stray backdrop
click from discarding the type-to-confirm input in `Destructive` or closing a
dialog mid-request.
`trigger` on the Mosaic `Dialog` becomes optional, so the machine-driven
dialogs no longer render a button they don't use.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
@vercel
vercelBot
commented
Aug 7, 2026•

edited

Loading

Copy link


Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.
ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxReadyReadyPreviewAug 12, 2026 7:33pm
swingsetReadyReadyPreviewAug 12, 2026 7:33pm
Request Review
@changeset-bot
changeset-botBot
commented
Aug 7, 2026•

edited

Loading

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: d089e1c
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 0 packages
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@pkg-pr-new
pkg-pr-newBot
commented
Aug 7, 2026•

edited

Loading

Copy link


Copy Markdown

Open in StackBlitz
@clerk/astro
npm i https://pkg.pr.new/@clerk/astro@9366

@clerk/backend
npm i https://pkg.pr.new/@clerk/backend@9366

@clerk/chrome-extension
npm i https://pkg.pr.new/@clerk/chrome-extension@9366

@clerk/clerk-js
npm i https://pkg.pr.new/@clerk/clerk-js@9366

@clerk/electron
npm i https://pkg.pr.new/@clerk/electron@9366

@clerk/electron-passkeys
npm i https://pkg.pr.new/@clerk/electron-passkeys@9366

@clerk/eslint-plugin
npm i https://pkg.pr.new/@clerk/eslint-plugin@9366

@clerk/expo
npm i https://pkg.pr.new/@clerk/expo@9366

@clerk/expo-google-signin
npm i https://pkg.pr.new/@clerk/expo-google-signin@9366

@clerk/expo-passkeys
npm i https://pkg.pr.new/@clerk/expo-passkeys@9366

@clerk/express
npm i https://pkg.pr.new/@clerk/express@9366

@clerk/fastify
npm i https://pkg.pr.new/@clerk/fastify@9366

@clerk/hono
npm i https://pkg.pr.new/@clerk/hono@9366

@clerk/localizations
npm i https://pkg.pr.new/@clerk/localizations@9366

@clerk/nextjs
npm i https://pkg.pr.new/@clerk/nextjs@9366

@clerk/nuxt
npm i https://pkg.pr.new/@clerk/nuxt@9366

@clerk/react
npm i https://pkg.pr.new/@clerk/react@9366

@clerk/react-router
npm i https://pkg.pr.new/@clerk/react-router@9366

@clerk/shared
npm i https://pkg.pr.new/@clerk/shared@9366

@clerk/tanstack-react-start
npm i https://pkg.pr.new/@clerk/tanstack-react-start@9366

@clerk/testing
npm i https://pkg.pr.new/@clerk/testing@9366

@clerk/ui
npm i https://pkg.pr.new/@clerk/ui@9366

@clerk/upgrade
npm i https://pkg.pr.new/@clerk/upgrade@9366

@clerk/vue
npm i https://pkg.pr.new/@clerk/vue@9366

commit: d089e1c
@github-actions
github-actionsBot
commented
Aug 7, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
API Changes Report
Generated by Break Check on 2026-08-12T19:34:24.670Z
Summary
MetricCount
Packages analyzed19
Packages with changes0
🔴 Breaking changes0
🟡 Non-breaking changes0
🟢 Additions0
No API Changes Detected
All packages have stable APIs with no detected changes.
Report generated by Break Check
Last ran on d089e1c.
@coderabbitai
coderabbitaiBot
commented
Aug 7, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Review Change Stack
No actionable comments were generated in the recent review. 🎉
ℹ️ Recent review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Organization UI (inherited)
Review profile: CHILL
Plan: Pro Plus
Run ID: 67559746-9f94-4d1b-a186-3f6bb30f7c12
📥 Commits
Reviewing files that changed from the base of the PR and between 7c1aa99 and d089e1c.
📒 Files selected for processing (1)
  • .changeset/lucky-donuts-invite.md
🔗 Linked repositories identified
CodeRabbit considers these linked repositories for cross-repo context during reviews:
  • clerk/clerk_go(manual)
  • clerk/dashboard(manual)
  • clerk/accounts(manual)
  • clerk/backoffice(manual)
  • clerk/clerk(manual)
  • clerk/clerk-docs(manual)
  • clerk/cloudflare-workers(manual)
  • clerk/clerk-ios(auto-detected)
  • clerk/cli(auto-detected)
  • clerk/clerk-android(auto-detected)
💤 Files with no reviewable changes (1)
  • .changeset/lucky-donuts-invite.md
📝 Walkthrough
Walkthrough
The headless dialog adds closedBy modes for Escape and outside-press dismissal. The public type is exported and covered by tests and documentation. Mosaic dialogs accept optional triggers and forward closedBy. Several organization dialogs use closerequest. The dialog story updates backdrop and viewport composition.
Estimated code review effort: 3 (Moderate) | ~20 minutes
Possibly related PRs
  • clerk/javascript#9388: Both PRs modify Dialog.Root and Mosaic dialog consumers to add and use the closedBy dismissal policy, including optional triggers.
  • clerk/javascript#9420: Both PRs introduce the closedBy API and dismissal behavior changes in the headless and Mosaic dialog implementations.
Suggested reviewers:austincalvelage
🚥 Pre-merge checks | ✅ 4 | ❌ 1
❌ Failed checks (1 warning)
Check nameStatusExplanationResolution
Docstring Coverage⚠️ WarningDocstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check nameStatusExplanation
Title check✅ PassedThe title clearly and concisely describes the new Dialog closedBy dismissal policy.
Description check✅ PassedThe description directly explains the closedBy feature, its dismissal behavior, and related Mosaic dialog changes.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
Comment @coderabbitai help to get the list of available commands.
coderabbitai[bot]
coderabbitaiBot
reviewed
Aug 7, 2026
View reviewed changes
@coderabbitaicoderabbitaiBot
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@packages/headless/src/primitives/dialog/dialog-root.tsx`:
- Around line 21-31: Update the shared closedBy='none' contract in
packages/headless/src/primitives/dialog/dialog-root.tsx lines 21-31,
packages/headless/src/primitives/dialog/README.md lines 74-94, and
.changeset/lucky-donuts-invite.md line 5: state that Escape and outside-press
dismissal are disabled while explicit close controls such as Dialog.Close remain
available. Use consistent wording across all three sites.

🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
  •  Push a commit to this branch (recommended)
  •  Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Organization UI (inherited)
Review profile: CHILL
Plan: Pro Plus
Run ID: 16d1a9d7-2fb9-415c-8aef-4a6c79b99611
📥 Commits
Reviewing files that changed from the base of the PR and between 6100719 and 38e7c1f.
📒 Files selected for processing (14)
  • .changeset/lucky-donuts-invite.md
  • packages/headless/src/primitives/dialog/README.md
  • packages/headless/src/primitives/dialog/dialog-root.tsx
  • packages/headless/src/primitives/dialog/dialog.test.tsx
  • packages/headless/src/primitives/dialog/index.ts
  • packages/headless/src/primitives/dialog/parts.ts
  • packages/swingset/src/stories/dialog.mdx
  • packages/swingset/src/stories/dialog.stories.tsx
  • packages/ui/src/mosaic/block/destructive.tsx
  • packages/ui/src/mosaic/components/dialog.tsx
  • packages/ui/src/mosaic/organization/organization-profile-domains-section-add-verify.view.tsx
  • packages/ui/src/mosaic/organization/organization-profile-domains-section-enrollment.view.tsx
  • packages/ui/src/mosaic/organization/organization-profile-domains-section-remove.view.tsx
  • packages/ui/src/mosaic/organization/organization-profile-profile-section.view.tsx
🔗 Linked repositories identified
CodeRabbit considers these linked repositories for cross-repo context during reviews:
  • clerk/clerk_go(manual)
  • clerk/dashboard(manual)
  • clerk/accounts(manual)
  • clerk/backoffice(manual)
  • clerk/clerk(manual)
  • clerk/clerk-docs(manual)
  • clerk/cloudflare-workers(manual)
  • clerk/clerk-ios(auto-detected)
  • clerk/cli(auto-detected)
  • clerk/clerk-android(auto-detected)
Comment threadpackages/headless/src/primitives/dialog/dialog-root.tsx
@coderabbitaicoderabbitaiBot
mentioned this pull request
Aug 11, 2026
 Merged

11 tasks
@coderabbitai
coderabbitaiBot
commented
Aug 12, 2026

Copy link


Copy Markdown

Contributor
Note
GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer.
@coderabbitaicoderabbitaiBot
mentioned this pull request
Aug 12, 2026
 Closed

9 tasks
@maxyinger
maxyinger
merged commit dfc9c0d
into
mainAug 12, 2026

111 of 118 checks passed

@maxyinger
maxyinger
deleted the

max/dialog-updates

branch
August 12, 2026 20:45
@coderabbitaicoderabbitaiBot
mentioned this pull request
Aug 12, 2026
 Open

9 tasks
@maxyingermaxyinger
mentioned this pull request
Aug 13, 2026
 Closed

9 tasks
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@coderabbitaicoderabbitai[bot]coderabbitai[bot] left review comments
@alexcarpenteralexcarpenteralexcarpenter approved these changes

Assignees


No one assigned


Labels

ui

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@maxyinger@alexcarpenter