Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .changeset/olive-doors-tell.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
---
---
Comment on lines +1 to +2

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🗄️ Data Integrity & Integration | 🟠 Major | 🏗️ Heavy lift

Restore a changeset entry for the @clerk/ui Dialog API change.

This changeset is now empty, so the release carries no version bump and no changelog entry. packages/ui is published and pinned by external consumers — clerk/dashboard pins @clerk/ui at 1.7.0, and both clerk/dashboard and clerk/clerk load @clerk/ui@1 from the CDN.

This PR replaces the Mosaic Dialog modules, moves size from the popup to Dialog.Root, and drops sx in favour of .cl-dialog-* classes. Consumers need a changelog entry and an appropriate semver bump for that.

Choose one path:

  • Keep deprecated compatibility shims for the removed Dialog props and publish a minor release with a changeset describing the new API.
  • Publish a major release with a changeset that documents the migration from sx and from popup-level size.

As per coding guidelines, "Maintain backward compatibility in packages/clerk-js and packages/ui with SDK versions already in the wild" and "Use Changesets for version management and changelogs".

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In @.changeset/olive-doors-tell.md around lines 1 - 2, Restore the changeset
entry in the empty `.changeset/olive-doors-tell.md` file for the `@clerk/ui`
Dialog API change. Choose either a minor bump with deprecated compatibility
shims for removed props, or a major bump documenting migration from `sx` and
popup-level `size`; include the corresponding changelog details and valid
Changesets frontmatter.

Sources: Coding guidelines, Linked repositories

13 changes: 9 additions & 4 deletions packages/headless/src/primitives/dialog/README.md
Original file line numberDiff line numberDiff line change
Expand Up@@ -120,17 +120,22 @@ No additional props beyond standard HTML attributes and the `render` prop.

## Data Attributes

| Attribute | Applies To | Description |
| --------------------------- | ---------------------------------- | ----------- |
| `data-open` / `data-closed` | Trigger, Backdrop, Viewport, Popup | Open state |
| Attribute | Applies To | Description |
| --------------------------- | ---------------------------------- | ------------------------------------------- |
| `data-open` / `data-closed` | Trigger, Backdrop, Viewport, Popup | Open state |
| `data-nested` | Backdrop, Viewport, Popup | Opened from inside another floating element |

`data-nested` is what a stacked overlay styles itself from — chiefly so backdrops don't composite
into an ever-darker scrim as the stack grows. It reflects any floating ancestor, not strictly a
dialog one: the `FloatingTree` a Menu or Popover establishes counts too.

The headless parts are unstyled. Target a part with your own className (or `render` prop) and combine it with the `data-*` state attributes above.

## Important Notes

- **`Dialog.Popup` should be a child of `Dialog.Viewport`** for centered, scroll-locked modal behavior. The viewport hosts the fixed overlay container; the popup alone does not handle positioning or scroll lock.
- **Title and Description are optional but recommended.** If omitted, `aria-labelledby` / `aria-describedby` are simply absent from the popup.
- **Nested dialogs are supported.** The `FloatingTree` pattern handles nesting automatically.
- **Nested dialogs are supported**, and covered by tests. The `FloatingTree` pattern handles it: `useDismiss` blocks both Escape and outside-press on a parent while any child is open, and `FloatingOverlay`'s scroll lock is refcounted, so the body stays locked until the last dialog closes.
- **No positioning middleware.** Dialogs are centered via CSS, not Floating UI positioning.

## Authoring rule for new primitives
Expand Down
5 changes: 3 additions & 2 deletions packages/headless/src/primitives/dialog/dialog-backdrop.tsx
Original file line numberDiff line numberDiff line change
Expand Up@@ -12,9 +12,9 @@ export type DialogBackdropProps = ComponentProps<'div'>;
export const DialogBackdrop = React.forwardRef<HTMLDivElement, DialogBackdropProps>(
function DialogBackdrop(props, ref) {
const { render, ...otherProps } = props;
const { open, mounted, transitionProps } = useDialogContext();
const { open, mounted, isNested, transitionProps } = useDialogContext();

const state = { open };
const state = { open, nested: isNested };

const defaultProps = {
...transitionProps,
Expand All@@ -28,6 +28,7 @@ export const DialogBackdrop = React.forwardRef<HTMLDivElement, DialogBackdropPro
state,
stateAttributesMapping: {
open: (v: boolean): Record<string, string> | null => (v ? { 'data-open': '' } : { 'data-closed': '' }),
nested: (v: boolean): Record<string, string> | null => (v ? { 'data-nested': '' } : null),
},
props: mergeProps<'div'>(defaultProps, otherProps),
});
Expand Down
10 changes: 10 additions & 0 deletions packages/headless/src/primitives/dialog/dialog-context.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -14,6 +14,16 @@ export interface DialogContextValue {
/** Where focus goes when the dialog closes, or `null` to leave focus alone. */
returnFocusRef: React.MutableRefObject<HTMLElement | null>;
modal: boolean;
/**
* Whether this dialog opened from inside another floating element, so a stacked overlay can
* style itself differently from the one beneath it — chiefly so backdrops don't composite into
* an ever-darker scrim as the stack grows.
*
* True for any floating ancestor, not strictly a dialog one: the `FloatingTree` a Menu or
* Popover establishes counts too. That is the honest reading of what is knowable here, and the
* cases coincide in practice.
*/
isNested: boolean;
labelId: string;
descriptionId: string;
mounted: boolean;
Expand Down
8 changes: 7 additions & 1 deletion packages/headless/src/primitives/dialog/dialog-popup.tsx
Original file line numberDiff line numberDiff line change
Expand Up@@ -18,6 +18,7 @@ export const DialogPopup = React.forwardRef<HTMLDivElement, DialogPopupProps>(fu
getFloatingProps,
floatingContext,
modal,
isNested,
returnFocusRef,
labelId,
descriptionId,
Expand All@@ -30,7 +31,12 @@ export const DialogPopup = React.forwardRef<HTMLDivElement, DialogPopupProps>(fu
'aria-describedby': descriptionId,
} satisfies DefaultProps<'div'>;

const defaultProps = { ...ownProps, ...getFloatingProps(), ...transitionProps };
const defaultProps = {
...ownProps,
...(isNested ? { 'data-nested': '' } : {}),
...getFloatingProps(),
...transitionProps,
};

const element = useRender({
defaultTagName: 'div',
Expand Down
18 changes: 14 additions & 4 deletions packages/headless/src/primitives/dialog/dialog-root.tsx
Original file line numberDiff line numberDiff line change
Expand Up@@ -42,9 +42,9 @@ export interface DialogProps {
children: ReactNode;
}

function DialogInner(props: DialogProps) {
function DialogInner(props: DialogProps & { isNested: boolean }) {
const nodeId = useFloatingNodeId();
const { modal = true, closedBy = 'any', children } = props;
const { modal = true, closedBy = 'any', isNested, children } = props;

const [open, setOpen] = useControllableState(props.open, props.defaultOpen ?? false, props.onOpenChange);

Expand DownExpand Up@@ -87,6 +87,7 @@ function DialogInner(props: DialogProps) {
popupRef,
returnFocusRef,
modal,
isNested,
labelId,
descriptionId,
mounted,
Expand All@@ -101,6 +102,7 @@ function DialogInner(props: DialogProps) {
getFloatingProps,
returnFocusRef,
modal,
isNested,
labelId,
descriptionId,
mounted,
Expand All@@ -121,10 +123,18 @@ export function DialogRoot(props: DialogProps) {
if (parentId === null) {
return (
<FloatingTree>
<DialogInner {...props} />
<DialogInner
{...props}
isNested={false}
/>
</FloatingTree>
);
}

return <DialogInner {...props} />;
return (
<DialogInner
{...props}
isNested
/>
);
}
5 changes: 3 additions & 2 deletions packages/headless/src/primitives/dialog/dialog-viewport.tsx
Original file line numberDiff line numberDiff line change
Expand Up@@ -23,9 +23,9 @@ export interface DialogViewportProps extends ComponentProps<'div'> {
export const DialogViewport = React.forwardRef<HTMLDivElement, DialogViewportProps>(
function DialogViewport(props, ref) {
const { render, lockScroll = true, ...otherProps } = props;
const { open, mounted, transitionProps, modal } = useDialogContext();
const { open, mounted, isNested, transitionProps, modal } = useDialogContext();

const state = { open };
const state = { open, nested: isNested };

const defaultProps = {
...transitionProps,
Expand All@@ -40,6 +40,7 @@ export const DialogViewport = React.forwardRef<HTMLDivElement, DialogViewportPro
state,
stateAttributesMapping: {
open: (v: boolean): Record<string, string> | null => (v ? { 'data-open': '' } : { 'data-closed': '' }),
nested: (v: boolean): Record<string, string> | null => (v ? { 'data-nested': '' } : null),
},
props: mergeProps<'div'>(defaultProps, otherProps),
});
Expand Down
2 changes: 0 additions & 2 deletions packages/headless/src/primitives/drawer/drawer-context.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -44,8 +44,6 @@ export interface DrawerContextValue extends DialogContextValue {
snapRestOffset: number | null;
/** Callbacks a nested child `Drawer.Root` invokes on this (parent) drawer. */
onNested: NestedDrawerCallbacks;
/** True when this drawer is itself nested inside another drawer. */
isNested: boolean;
/** How many direct nested child drawers are currently open. */
nestedOpenCount: number;
}
Expand Down
Loading
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .changeset/olive-doors-tell.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
---
---
Comment on lines +1 to +2

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🗄️ Data Integrity & Integration | 🟠 Major | 🏗️ Heavy lift

Restore a changeset entry for the @clerk/ui Dialog API change.

This changeset is now empty, so the release carries no version bump and no changelog entry. packages/ui is published and pinned by external consumers — clerk/dashboard pins @clerk/ui at 1.7.0, and both clerk/dashboard and clerk/clerk load @clerk/ui@1 from the CDN.

This PR replaces the Mosaic Dialog modules, moves size from the popup to Dialog.Root, and drops sx in favour of .cl-dialog-* classes. Consumers need a changelog entry and an appropriate semver bump for that.

Choose one path:

  • Keep deprecated compatibility shims for the removed Dialog props and publish a minor release with a changeset describing the new API.
  • Publish a major release with a changeset that documents the migration from sx and from popup-level size.

As per coding guidelines, "Maintain backward compatibility in packages/clerk-js and packages/ui with SDK versions already in the wild" and "Use Changesets for version management and changelogs".

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In @.changeset/olive-doors-tell.md around lines 1 - 2, Restore the changeset
entry in the empty `.changeset/olive-doors-tell.md` file for the `@clerk/ui`
Dialog API change. Choose either a minor bump with deprecated compatibility
shims for removed props, or a major bump documenting migration from `sx` and
popup-level `size`; include the corresponding changelog details and valid
Changesets frontmatter.

Sources: Coding guidelines, Linked repositories

13 changes: 9 additions & 4 deletions packages/headless/src/primitives/dialog/README.md
Original file line numberDiff line numberDiff line change
Expand Up@@ -120,17 +120,22 @@ No additional props beyond standard HTML attributes and the `render` prop.

## Data Attributes

| Attribute | Applies To | Description |
| --------------------------- | ---------------------------------- | ----------- |
| `data-open` / `data-closed` | Trigger, Backdrop, Viewport, Popup | Open state |
| Attribute | Applies To | Description |
| --------------------------- | ---------------------------------- | ------------------------------------------- |
| `data-open` / `data-closed` | Trigger, Backdrop, Viewport, Popup | Open state |
| `data-nested` | Backdrop, Viewport, Popup | Opened from inside another floating element |

`data-nested` is what a stacked overlay styles itself from — chiefly so backdrops don't composite
into an ever-darker scrim as the stack grows. It reflects any floating ancestor, not strictly a
dialog one: the `FloatingTree` a Menu or Popover establishes counts too.

The headless parts are unstyled. Target a part with your own className (or `render` prop) and combine it with the `data-*` state attributes above.

## Important Notes

- **`Dialog.Popup` should be a child of `Dialog.Viewport`** for centered, scroll-locked modal behavior. The viewport hosts the fixed overlay container; the popup alone does not handle positioning or scroll lock.
- **Title and Description are optional but recommended.** If omitted, `aria-labelledby` / `aria-describedby` are simply absent from the popup.
- **Nested dialogs are supported.** The `FloatingTree` pattern handles nesting automatically.
- **Nested dialogs are supported**, and covered by tests. The `FloatingTree` pattern handles it: `useDismiss` blocks both Escape and outside-press on a parent while any child is open, and `FloatingOverlay`'s scroll lock is refcounted, so the body stays locked until the last dialog closes.
- **No positioning middleware.** Dialogs are centered via CSS, not Floating UI positioning.

## Authoring rule for new primitives
Expand Down
5 changes: 3 additions & 2 deletions packages/headless/src/primitives/dialog/dialog-backdrop.tsx
Original file line numberDiff line numberDiff line change
Expand Up@@ -12,9 +12,9 @@ export type DialogBackdropProps = ComponentProps<'div'>;
export const DialogBackdrop = React.forwardRef<HTMLDivElement, DialogBackdropProps>(
function DialogBackdrop(props, ref) {
const { render, ...otherProps } = props;
const { open, mounted, transitionProps } = useDialogContext();
const { open, mounted, isNested, transitionProps } = useDialogContext();

const state = { open };
const state = { open, nested: isNested };

const defaultProps = {
...transitionProps,
Expand All@@ -28,6 +28,7 @@ export const DialogBackdrop = React.forwardRef<HTMLDivElement, DialogBackdropPro
state,
stateAttributesMapping: {
open: (v: boolean): Record<string, string> | null => (v ? { 'data-open': '' } : { 'data-closed': '' }),
nested: (v: boolean): Record<string, string> | null => (v ? { 'data-nested': '' } : null),
},
props: mergeProps<'div'>(defaultProps, otherProps),
});
Expand Down
10 changes: 10 additions & 0 deletions packages/headless/src/primitives/dialog/dialog-context.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -14,6 +14,16 @@ export interface DialogContextValue {
/** Where focus goes when the dialog closes, or `null` to leave focus alone. */
returnFocusRef: React.MutableRefObject<HTMLElement | null>;
modal: boolean;
/**
* Whether this dialog opened from inside another floating element, so a stacked overlay can
* style itself differently from the one beneath it — chiefly so backdrops don't composite into
* an ever-darker scrim as the stack grows.
*
* True for any floating ancestor, not strictly a dialog one: the `FloatingTree` a Menu or
* Popover establishes counts too. That is the honest reading of what is knowable here, and the
* cases coincide in practice.
*/
isNested: boolean;
labelId: string;
descriptionId: string;
mounted: boolean;
Expand Down
8 changes: 7 additions & 1 deletion packages/headless/src/primitives/dialog/dialog-popup.tsx
Original file line numberDiff line numberDiff line change
Expand Up@@ -18,6 +18,7 @@ export const DialogPopup = React.forwardRef<HTMLDivElement, DialogPopupProps>(fu
getFloatingProps,
floatingContext,
modal,
isNested,
returnFocusRef,
labelId,
descriptionId,
Expand All@@ -30,7 +31,12 @@ export const DialogPopup = React.forwardRef<HTMLDivElement, DialogPopupProps>(fu
'aria-describedby': descriptionId,
} satisfies DefaultProps<'div'>;

const defaultProps = { ...ownProps, ...getFloatingProps(), ...transitionProps };
const defaultProps = {
...ownProps,
...(isNested ? { 'data-nested': '' } : {}),
...getFloatingProps(),
...transitionProps,
};

const element = useRender({
defaultTagName: 'div',
Expand Down
18 changes: 14 additions & 4 deletions packages/headless/src/primitives/dialog/dialog-root.tsx
Original file line numberDiff line numberDiff line change
Expand Up@@ -42,9 +42,9 @@ export interface DialogProps {
children: ReactNode;
}

function DialogInner(props: DialogProps) {
function DialogInner(props: DialogProps & { isNested: boolean }) {
const nodeId = useFloatingNodeId();
const { modal = true, closedBy = 'any', children } = props;
const { modal = true, closedBy = 'any', isNested, children } = props;

const [open, setOpen] = useControllableState(props.open, props.defaultOpen ?? false, props.onOpenChange);

Expand DownExpand Up@@ -87,6 +87,7 @@ function DialogInner(props: DialogProps) {
popupRef,
returnFocusRef,
modal,
isNested,
labelId,
descriptionId,
mounted,
Expand All@@ -101,6 +102,7 @@ function DialogInner(props: DialogProps) {
getFloatingProps,
returnFocusRef,
modal,
isNested,
labelId,
descriptionId,
mounted,
Expand All@@ -121,10 +123,18 @@ export function DialogRoot(props: DialogProps) {
if (parentId === null) {
return (
<FloatingTree>
<DialogInner {...props} />
<DialogInner
{...props}
isNested={false}
/>
</FloatingTree>
);
}

return <DialogInner {...props} />;
return (
<DialogInner
{...props}
isNested
/>
);
}
5 changes: 3 additions & 2 deletions packages/headless/src/primitives/dialog/dialog-viewport.tsx
Original file line numberDiff line numberDiff line change
Expand Up@@ -23,9 +23,9 @@ export interface DialogViewportProps extends ComponentProps<'div'> {
export const DialogViewport = React.forwardRef<HTMLDivElement, DialogViewportProps>(
function DialogViewport(props, ref) {
const { render, lockScroll = true, ...otherProps } = props;
const { open, mounted, transitionProps, modal } = useDialogContext();
const { open, mounted, isNested, transitionProps, modal } = useDialogContext();

const state = { open };
const state = { open, nested: isNested };

const defaultProps = {
...transitionProps,
Expand All@@ -40,6 +40,7 @@ export const DialogViewport = React.forwardRef<HTMLDivElement, DialogViewportPro
state,
stateAttributesMapping: {
open: (v: boolean): Record<string, string> | null => (v ? { 'data-open': '' } : { 'data-closed': '' }),
nested: (v: boolean): Record<string, string> | null => (v ? { 'data-nested': '' } : null),
},
props: mergeProps<'div'>(defaultProps, otherProps),
});
Expand Down
2 changes: 0 additions & 2 deletions packages/headless/src/primitives/drawer/drawer-context.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -44,8 +44,6 @@ export interface DrawerContextValue extends DialogContextValue {
snapRestOffset: number | null;
/** Callbacks a nested child `Drawer.Root` invokes on this (parent) drawer. */
onNested: NestedDrawerCallbacks;
/** True when this drawer is itself nested inside another drawer. */
isNested: boolean;
/** How many direct nested child drawers are currently open. */
nestedOpenCount: number;
}
Expand Down
Loading
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix"); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .changeset/olive-doors-tell.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
---
---
Comment on lines +1 to +2

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🗄️ Data Integrity & Integration | 🟠 Major | 🏗️ Heavy lift

Restore a changeset entry for the @clerk/ui Dialog API change.

This changeset is now empty, so the release carries no version bump and no changelog entry. packages/ui is published and pinned by external consumers — clerk/dashboard pins @clerk/ui at 1.7.0, and both clerk/dashboard and clerk/clerk load @clerk/ui@1 from the CDN.

This PR replaces the Mosaic Dialog modules, moves size from the popup to Dialog.Root, and drops sx in favour of .cl-dialog-* classes. Consumers need a changelog entry and an appropriate semver bump for that.

Choose one path:

  • Keep deprecated compatibility shims for the removed Dialog props and publish a minor release with a changeset describing the new API.
  • Publish a major release with a changeset that documents the migration from sx and from popup-level size.

As per coding guidelines, "Maintain backward compatibility in packages/clerk-js and packages/ui with SDK versions already in the wild" and "Use Changesets for version management and changelogs".

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In @.changeset/olive-doors-tell.md around lines 1 - 2, Restore the changeset
entry in the empty `.changeset/olive-doors-tell.md` file for the `@clerk/ui`
Dialog API change. Choose either a minor bump with deprecated compatibility
shims for removed props, or a major bump documenting migration from `sx` and
popup-level `size`; include the corresponding changelog details and valid
Changesets frontmatter.

Sources: Coding guidelines, Linked repositories

13 changes: 9 additions & 4 deletions packages/headless/src/primitives/dialog/README.md
Original file line numberDiff line numberDiff line change
Expand Up@@ -120,17 +120,22 @@ No additional props beyond standard HTML attributes and the `render` prop.

## Data Attributes

| Attribute | Applies To | Description |
| --------------------------- | ---------------------------------- | ----------- |
| `data-open` / `data-closed` | Trigger, Backdrop, Viewport, Popup | Open state |
| Attribute | Applies To | Description |
| --------------------------- | ---------------------------------- | ------------------------------------------- |
| `data-open` / `data-closed` | Trigger, Backdrop, Viewport, Popup | Open state |
| `data-nested` | Backdrop, Viewport, Popup | Opened from inside another floating element |

`data-nested` is what a stacked overlay styles itself from — chiefly so backdrops don't composite
into an ever-darker scrim as the stack grows. It reflects any floating ancestor, not strictly a
dialog one: the `FloatingTree` a Menu or Popover establishes counts too.

The headless parts are unstyled. Target a part with your own className (or `render` prop) and combine it with the `data-*` state attributes above.

## Important Notes

- **`Dialog.Popup` should be a child of `Dialog.Viewport`** for centered, scroll-locked modal behavior. The viewport hosts the fixed overlay container; the popup alone does not handle positioning or scroll lock.
- **Title and Description are optional but recommended.** If omitted, `aria-labelledby` / `aria-describedby` are simply absent from the popup.
- **Nested dialogs are supported.** The `FloatingTree` pattern handles nesting automatically.
- **Nested dialogs are supported**, and covered by tests. The `FloatingTree` pattern handles it: `useDismiss` blocks both Escape and outside-press on a parent while any child is open, and `FloatingOverlay`'s scroll lock is refcounted, so the body stays locked until the last dialog closes.
- **No positioning middleware.** Dialogs are centered via CSS, not Floating UI positioning.

## Authoring rule for new primitives
Expand Down
5 changes: 3 additions & 2 deletions packages/headless/src/primitives/dialog/dialog-backdrop.tsx
Original file line numberDiff line numberDiff line change
Expand Up@@ -12,9 +12,9 @@ export type DialogBackdropProps = ComponentProps<'div'>;
export const DialogBackdrop = React.forwardRef<HTMLDivElement, DialogBackdropProps>(
function DialogBackdrop(props, ref) {
const { render, ...otherProps } = props;
const { open, mounted, transitionProps } = useDialogContext();
const { open, mounted, isNested, transitionProps } = useDialogContext();

const state = { open };
const state = { open, nested: isNested };

const defaultProps = {
...transitionProps,
Expand All@@ -28,6 +28,7 @@ export const DialogBackdrop = React.forwardRef<HTMLDivElement, DialogBackdropPro
state,
stateAttributesMapping: {
open: (v: boolean): Record<string, string> | null => (v ? { 'data-open': '' } : { 'data-closed': '' }),
nested: (v: boolean): Record<string, string> | null => (v ? { 'data-nested': '' } : null),
},
props: mergeProps<'div'>(defaultProps, otherProps),
});
Expand Down
10 changes: 10 additions & 0 deletions packages/headless/src/primitives/dialog/dialog-context.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -14,6 +14,16 @@ export interface DialogContextValue {
/** Where focus goes when the dialog closes, or `null` to leave focus alone. */
returnFocusRef: React.MutableRefObject<HTMLElement | null>;
modal: boolean;
/**
* Whether this dialog opened from inside another floating element, so a stacked overlay can
* style itself differently from the one beneath it — chiefly so backdrops don't composite into
* an ever-darker scrim as the stack grows.
*
* True for any floating ancestor, not strictly a dialog one: the `FloatingTree` a Menu or
* Popover establishes counts too. That is the honest reading of what is knowable here, and the
* cases coincide in practice.
*/
isNested: boolean;
labelId: string;
descriptionId: string;
mounted: boolean;
Expand Down
8 changes: 7 additions & 1 deletion packages/headless/src/primitives/dialog/dialog-popup.tsx
Original file line numberDiff line numberDiff line change
Expand Up@@ -18,6 +18,7 @@ export const DialogPopup = React.forwardRef<HTMLDivElement, DialogPopupProps>(fu
getFloatingProps,
floatingContext,
modal,
isNested,
returnFocusRef,
labelId,
descriptionId,
Expand All@@ -30,7 +31,12 @@ export const DialogPopup = React.forwardRef<HTMLDivElement, DialogPopupProps>(fu
'aria-describedby': descriptionId,
} satisfies DefaultProps<'div'>;

const defaultProps = { ...ownProps, ...getFloatingProps(), ...transitionProps };
const defaultProps = {
...ownProps,
...(isNested ? { 'data-nested': '' } : {}),
...getFloatingProps(),
...transitionProps,
};

const element = useRender({
defaultTagName: 'div',
Expand Down
18 changes: 14 additions & 4 deletions packages/headless/src/primitives/dialog/dialog-root.tsx
Original file line numberDiff line numberDiff line change
Expand Up@@ -42,9 +42,9 @@ export interface DialogProps {
children: ReactNode;
}

function DialogInner(props: DialogProps) {
function DialogInner(props: DialogProps & { isNested: boolean }) {
const nodeId = useFloatingNodeId();
const { modal = true, closedBy = 'any', children } = props;
const { modal = true, closedBy = 'any', isNested, children } = props;

const [open, setOpen] = useControllableState(props.open, props.defaultOpen ?? false, props.onOpenChange);

Expand DownExpand Up@@ -87,6 +87,7 @@ function DialogInner(props: DialogProps) {
popupRef,
returnFocusRef,
modal,
isNested,
labelId,
descriptionId,
mounted,
Expand All@@ -101,6 +102,7 @@ function DialogInner(props: DialogProps) {
getFloatingProps,
returnFocusRef,
modal,
isNested,
labelId,
descriptionId,
mounted,
Expand All@@ -121,10 +123,18 @@ export function DialogRoot(props: DialogProps) {
if (parentId === null) {
return (
<FloatingTree>
<DialogInner {...props} />
<DialogInner
{...props}
isNested={false}
/>
</FloatingTree>
);
}

return <DialogInner {...props} />;
return (
<DialogInner
{...props}
isNested
/>
);
}
5 changes: 3 additions & 2 deletions packages/headless/src/primitives/dialog/dialog-viewport.tsx
Original file line numberDiff line numberDiff line change
Expand Up@@ -23,9 +23,9 @@ export interface DialogViewportProps extends ComponentProps<'div'> {
export const DialogViewport = React.forwardRef<HTMLDivElement, DialogViewportProps>(
function DialogViewport(props, ref) {
const { render, lockScroll = true, ...otherProps } = props;
const { open, mounted, transitionProps, modal } = useDialogContext();
const { open, mounted, isNested, transitionProps, modal } = useDialogContext();

const state = { open };
const state = { open, nested: isNested };

const defaultProps = {
...transitionProps,
Expand All@@ -40,6 +40,7 @@ export const DialogViewport = React.forwardRef<HTMLDivElement, DialogViewportPro
state,
stateAttributesMapping: {
open: (v: boolean): Record<string, string> | null => (v ? { 'data-open': '' } : { 'data-closed': '' }),
nested: (v: boolean): Record<string, string> | null => (v ? { 'data-nested': '' } : null),
},
props: mergeProps<'div'>(defaultProps, otherProps),
});
Expand Down
2 changes: 0 additions & 2 deletions packages/headless/src/primitives/drawer/drawer-context.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -44,8 +44,6 @@ export interface DrawerContextValue extends DialogContextValue {
snapRestOffset: number | null;
/** Callbacks a nested child `Drawer.Root` invokes on this (parent) drawer. */
onNested: NestedDrawerCallbacks;
/** True when this drawer is itself nested inside another drawer. */
isNested: boolean;
/** How many direct nested child drawers are currently open. */
nestedOpenCount: number;
}
Expand Down
Loading
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms"); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .changeset/olive-doors-tell.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
---
---
Comment on lines +1 to +2

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🗄️ Data Integrity & Integration | 🟠 Major | 🏗️ Heavy lift

Restore a changeset entry for the @clerk/ui Dialog API change.

This changeset is now empty, so the release carries no version bump and no changelog entry. packages/ui is published and pinned by external consumers — clerk/dashboard pins @clerk/ui at 1.7.0, and both clerk/dashboard and clerk/clerk load @clerk/ui@1 from the CDN.

This PR replaces the Mosaic Dialog modules, moves size from the popup to Dialog.Root, and drops sx in favour of .cl-dialog-* classes. Consumers need a changelog entry and an appropriate semver bump for that.

Choose one path:

  • Keep deprecated compatibility shims for the removed Dialog props and publish a minor release with a changeset describing the new API.
  • Publish a major release with a changeset that documents the migration from sx and from popup-level size.

As per coding guidelines, "Maintain backward compatibility in packages/clerk-js and packages/ui with SDK versions already in the wild" and "Use Changesets for version management and changelogs".

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In @.changeset/olive-doors-tell.md around lines 1 - 2, Restore the changeset
entry in the empty `.changeset/olive-doors-tell.md` file for the `@clerk/ui`
Dialog API change. Choose either a minor bump with deprecated compatibility
shims for removed props, or a major bump documenting migration from `sx` and
popup-level `size`; include the corresponding changelog details and valid
Changesets frontmatter.

Sources: Coding guidelines, Linked repositories

13 changes: 9 additions & 4 deletions packages/headless/src/primitives/dialog/README.md
Original file line numberDiff line numberDiff line change
Expand Up@@ -120,17 +120,22 @@ No additional props beyond standard HTML attributes and the `render` prop.

## Data Attributes

| Attribute | Applies To | Description |
| --------------------------- | ---------------------------------- | ----------- |
| `data-open` / `data-closed` | Trigger, Backdrop, Viewport, Popup | Open state |
| Attribute | Applies To | Description |
| --------------------------- | ---------------------------------- | ------------------------------------------- |
| `data-open` / `data-closed` | Trigger, Backdrop, Viewport, Popup | Open state |
| `data-nested` | Backdrop, Viewport, Popup | Opened from inside another floating element |

`data-nested` is what a stacked overlay styles itself from — chiefly so backdrops don't composite
into an ever-darker scrim as the stack grows. It reflects any floating ancestor, not strictly a
dialog one: the `FloatingTree` a Menu or Popover establishes counts too.

The headless parts are unstyled. Target a part with your own className (or `render` prop) and combine it with the `data-*` state attributes above.

## Important Notes

- **`Dialog.Popup` should be a child of `Dialog.Viewport`** for centered, scroll-locked modal behavior. The viewport hosts the fixed overlay container; the popup alone does not handle positioning or scroll lock.
- **Title and Description are optional but recommended.** If omitted, `aria-labelledby` / `aria-describedby` are simply absent from the popup.
- **Nested dialogs are supported.** The `FloatingTree` pattern handles nesting automatically.
- **Nested dialogs are supported**, and covered by tests. The `FloatingTree` pattern handles it: `useDismiss` blocks both Escape and outside-press on a parent while any child is open, and `FloatingOverlay`'s scroll lock is refcounted, so the body stays locked until the last dialog closes.
- **No positioning middleware.** Dialogs are centered via CSS, not Floating UI positioning.

## Authoring rule for new primitives
Expand Down
5 changes: 3 additions & 2 deletions packages/headless/src/primitives/dialog/dialog-backdrop.tsx
Original file line numberDiff line numberDiff line change
Expand Up@@ -12,9 +12,9 @@ export type DialogBackdropProps = ComponentProps<'div'>;
export const DialogBackdrop = React.forwardRef<HTMLDivElement, DialogBackdropProps>(
function DialogBackdrop(props, ref) {
const { render, ...otherProps } = props;
const { open, mounted, transitionProps } = useDialogContext();
const { open, mounted, isNested, transitionProps } = useDialogContext();

const state = { open };
const state = { open, nested: isNested };

const defaultProps = {
...transitionProps,
Expand All@@ -28,6 +28,7 @@ export const DialogBackdrop = React.forwardRef<HTMLDivElement, DialogBackdropPro
state,
stateAttributesMapping: {
open: (v: boolean): Record<string, string> | null => (v ? { 'data-open': '' } : { 'data-closed': '' }),
nested: (v: boolean): Record<string, string> | null => (v ? { 'data-nested': '' } : null),
},
props: mergeProps<'div'>(defaultProps, otherProps),
});
Expand Down
10 changes: 10 additions & 0 deletions packages/headless/src/primitives/dialog/dialog-context.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -14,6 +14,16 @@ export interface DialogContextValue {
/** Where focus goes when the dialog closes, or `null` to leave focus alone. */
returnFocusRef: React.MutableRefObject<HTMLElement | null>;
modal: boolean;
/**
* Whether this dialog opened from inside another floating element, so a stacked overlay can
* style itself differently from the one beneath it — chiefly so backdrops don't composite into
* an ever-darker scrim as the stack grows.
*
* True for any floating ancestor, not strictly a dialog one: the `FloatingTree` a Menu or
* Popover establishes counts too. That is the honest reading of what is knowable here, and the
* cases coincide in practice.
*/
isNested: boolean;
labelId: string;
descriptionId: string;
mounted: boolean;
Expand Down
8 changes: 7 additions & 1 deletion packages/headless/src/primitives/dialog/dialog-popup.tsx
Original file line numberDiff line numberDiff line change
Expand Up@@ -18,6 +18,7 @@ export const DialogPopup = React.forwardRef<HTMLDivElement, DialogPopupProps>(fu
getFloatingProps,
floatingContext,
modal,
isNested,
returnFocusRef,
labelId,
descriptionId,
Expand All@@ -30,7 +31,12 @@ export const DialogPopup = React.forwardRef<HTMLDivElement, DialogPopupProps>(fu
'aria-describedby': descriptionId,
} satisfies DefaultProps<'div'>;

const defaultProps = { ...ownProps, ...getFloatingProps(), ...transitionProps };
const defaultProps = {
...ownProps,
...(isNested ? { 'data-nested': '' } : {}),
...getFloatingProps(),
...transitionProps,
};

const element = useRender({
defaultTagName: 'div',
Expand Down
18 changes: 14 additions & 4 deletions packages/headless/src/primitives/dialog/dialog-root.tsx
Original file line numberDiff line numberDiff line change
Expand Up@@ -42,9 +42,9 @@ export interface DialogProps {
children: ReactNode;
}

function DialogInner(props: DialogProps) {
function DialogInner(props: DialogProps & { isNested: boolean }) {
const nodeId = useFloatingNodeId();
const { modal = true, closedBy = 'any', children } = props;
const { modal = true, closedBy = 'any', isNested, children } = props;

const [open, setOpen] = useControllableState(props.open, props.defaultOpen ?? false, props.onOpenChange);

Expand DownExpand Up@@ -87,6 +87,7 @@ function DialogInner(props: DialogProps) {
popupRef,
returnFocusRef,
modal,
isNested,
labelId,
descriptionId,
mounted,
Expand All@@ -101,6 +102,7 @@ function DialogInner(props: DialogProps) {
getFloatingProps,
returnFocusRef,
modal,
isNested,
labelId,
descriptionId,
mounted,
Expand All@@ -121,10 +123,18 @@ export function DialogRoot(props: DialogProps) {
if (parentId === null) {
return (
<FloatingTree>
<DialogInner {...props} />
<DialogInner
{...props}
isNested={false}
/>
</FloatingTree>
);
}

return <DialogInner {...props} />;
return (
<DialogInner
{...props}
isNested
/>
);
}
5 changes: 3 additions & 2 deletions packages/headless/src/primitives/dialog/dialog-viewport.tsx
Original file line numberDiff line numberDiff line change
Expand Up@@ -23,9 +23,9 @@ export interface DialogViewportProps extends ComponentProps<'div'> {
export const DialogViewport = React.forwardRef<HTMLDivElement, DialogViewportProps>(
function DialogViewport(props, ref) {
const { render, lockScroll = true, ...otherProps } = props;
const { open, mounted, transitionProps, modal } = useDialogContext();
const { open, mounted, isNested, transitionProps, modal } = useDialogContext();

const state = { open };
const state = { open, nested: isNested };

const defaultProps = {
...transitionProps,
Expand All@@ -40,6 +40,7 @@ export const DialogViewport = React.forwardRef<HTMLDivElement, DialogViewportPro
state,
stateAttributesMapping: {
open: (v: boolean): Record<string, string> | null => (v ? { 'data-open': '' } : { 'data-closed': '' }),
nested: (v: boolean): Record<string, string> | null => (v ? { 'data-nested': '' } : null),
},
props: mergeProps<'div'>(defaultProps, otherProps),
});
Expand Down
2 changes: 0 additions & 2 deletions packages/headless/src/primitives/drawer/drawer-context.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -44,8 +44,6 @@ export interface DrawerContextValue extends DialogContextValue {
snapRestOffset: number | null;
/** Callbacks a nested child `Drawer.Root` invokes on this (parent) drawer. */
onNested: NestedDrawerCallbacks;
/** True when this drawer is itself nested inside another drawer. */
isNested: boolean;
/** How many direct nested child drawers are currently open. */
nestedOpenCount: number;
}
Expand Down
Loading
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links"); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .changeset/olive-doors-tell.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
---
---
Comment on lines +1 to +2

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🗄️ Data Integrity & Integration | 🟠 Major | 🏗️ Heavy lift

Restore a changeset entry for the @clerk/ui Dialog API change.

This changeset is now empty, so the release carries no version bump and no changelog entry. packages/ui is published and pinned by external consumers — clerk/dashboard pins @clerk/ui at 1.7.0, and both clerk/dashboard and clerk/clerk load @clerk/ui@1 from the CDN.

This PR replaces the Mosaic Dialog modules, moves size from the popup to Dialog.Root, and drops sx in favour of .cl-dialog-* classes. Consumers need a changelog entry and an appropriate semver bump for that.

Choose one path:

  • Keep deprecated compatibility shims for the removed Dialog props and publish a minor release with a changeset describing the new API.
  • Publish a major release with a changeset that documents the migration from sx and from popup-level size.

As per coding guidelines, "Maintain backward compatibility in packages/clerk-js and packages/ui with SDK versions already in the wild" and "Use Changesets for version management and changelogs".

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In @.changeset/olive-doors-tell.md around lines 1 - 2, Restore the changeset
entry in the empty `.changeset/olive-doors-tell.md` file for the `@clerk/ui`
Dialog API change. Choose either a minor bump with deprecated compatibility
shims for removed props, or a major bump documenting migration from `sx` and
popup-level `size`; include the corresponding changelog details and valid
Changesets frontmatter.

Sources: Coding guidelines, Linked repositories

13 changes: 9 additions & 4 deletions packages/headless/src/primitives/dialog/README.md
Original file line numberDiff line numberDiff line change
Expand Up@@ -120,17 +120,22 @@ No additional props beyond standard HTML attributes and the `render` prop.

## Data Attributes

| Attribute | Applies To | Description |
| --------------------------- | ---------------------------------- | ----------- |
| `data-open` / `data-closed` | Trigger, Backdrop, Viewport, Popup | Open state |
| Attribute | Applies To | Description |
| --------------------------- | ---------------------------------- | ------------------------------------------- |
| `data-open` / `data-closed` | Trigger, Backdrop, Viewport, Popup | Open state |
| `data-nested` | Backdrop, Viewport, Popup | Opened from inside another floating element |

`data-nested` is what a stacked overlay styles itself from — chiefly so backdrops don't composite
into an ever-darker scrim as the stack grows. It reflects any floating ancestor, not strictly a
dialog one: the `FloatingTree` a Menu or Popover establishes counts too.

The headless parts are unstyled. Target a part with your own className (or `render` prop) and combine it with the `data-*` state attributes above.

## Important Notes

- **`Dialog.Popup` should be a child of `Dialog.Viewport`** for centered, scroll-locked modal behavior. The viewport hosts the fixed overlay container; the popup alone does not handle positioning or scroll lock.
- **Title and Description are optional but recommended.** If omitted, `aria-labelledby` / `aria-describedby` are simply absent from the popup.
- **Nested dialogs are supported.** The `FloatingTree` pattern handles nesting automatically.
- **Nested dialogs are supported**, and covered by tests. The `FloatingTree` pattern handles it: `useDismiss` blocks both Escape and outside-press on a parent while any child is open, and `FloatingOverlay`'s scroll lock is refcounted, so the body stays locked until the last dialog closes.
- **No positioning middleware.** Dialogs are centered via CSS, not Floating UI positioning.

## Authoring rule for new primitives
Expand Down
5 changes: 3 additions & 2 deletions packages/headless/src/primitives/dialog/dialog-backdrop.tsx
Original file line numberDiff line numberDiff line change
Expand Up@@ -12,9 +12,9 @@ export type DialogBackdropProps = ComponentProps<'div'>;
export const DialogBackdrop = React.forwardRef<HTMLDivElement, DialogBackdropProps>(
function DialogBackdrop(props, ref) {
const { render, ...otherProps } = props;
const { open, mounted, transitionProps } = useDialogContext();
const { open, mounted, isNested, transitionProps } = useDialogContext();

const state = { open };
const state = { open, nested: isNested };

const defaultProps = {
...transitionProps,
Expand All@@ -28,6 +28,7 @@ export const DialogBackdrop = React.forwardRef<HTMLDivElement, DialogBackdropPro
state,
stateAttributesMapping: {
open: (v: boolean): Record<string, string> | null => (v ? { 'data-open': '' } : { 'data-closed': '' }),
nested: (v: boolean): Record<string, string> | null => (v ? { 'data-nested': '' } : null),
},
props: mergeProps<'div'>(defaultProps, otherProps),
});
Expand Down
10 changes: 10 additions & 0 deletions packages/headless/src/primitives/dialog/dialog-context.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -14,6 +14,16 @@ export interface DialogContextValue {
/** Where focus goes when the dialog closes, or `null` to leave focus alone. */
returnFocusRef: React.MutableRefObject<HTMLElement | null>;
modal: boolean;
/**
* Whether this dialog opened from inside another floating element, so a stacked overlay can
* style itself differently from the one beneath it — chiefly so backdrops don't composite into
* an ever-darker scrim as the stack grows.
*
* True for any floating ancestor, not strictly a dialog one: the `FloatingTree` a Menu or
* Popover establishes counts too. That is the honest reading of what is knowable here, and the
* cases coincide in practice.
*/
isNested: boolean;
labelId: string;
descriptionId: string;
mounted: boolean;
Expand Down
8 changes: 7 additions & 1 deletion packages/headless/src/primitives/dialog/dialog-popup.tsx
Original file line numberDiff line numberDiff line change
Expand Up@@ -18,6 +18,7 @@ export const DialogPopup = React.forwardRef<HTMLDivElement, DialogPopupProps>(fu
getFloatingProps,
floatingContext,
modal,
isNested,
returnFocusRef,
labelId,
descriptionId,
Expand All@@ -30,7 +31,12 @@ export const DialogPopup = React.forwardRef<HTMLDivElement, DialogPopupProps>(fu
'aria-describedby': descriptionId,
} satisfies DefaultProps<'div'>;

const defaultProps = { ...ownProps, ...getFloatingProps(), ...transitionProps };
const defaultProps = {
...ownProps,
...(isNested ? { 'data-nested': '' } : {}),
...getFloatingProps(),
...transitionProps,
};

const element = useRender({
defaultTagName: 'div',
Expand Down
18 changes: 14 additions & 4 deletions packages/headless/src/primitives/dialog/dialog-root.tsx
Original file line numberDiff line numberDiff line change
Expand Up@@ -42,9 +42,9 @@ export interface DialogProps {
children: ReactNode;
}

function DialogInner(props: DialogProps) {
function DialogInner(props: DialogProps & { isNested: boolean }) {
const nodeId = useFloatingNodeId();
const { modal = true, closedBy = 'any', children } = props;
const { modal = true, closedBy = 'any', isNested, children } = props;

const [open, setOpen] = useControllableState(props.open, props.defaultOpen ?? false, props.onOpenChange);

Expand DownExpand Up@@ -87,6 +87,7 @@ function DialogInner(props: DialogProps) {
popupRef,
returnFocusRef,
modal,
isNested,
labelId,
descriptionId,
mounted,
Expand All@@ -101,6 +102,7 @@ function DialogInner(props: DialogProps) {
getFloatingProps,
returnFocusRef,
modal,
isNested,
labelId,
descriptionId,
mounted,
Expand All@@ -121,10 +123,18 @@ export function DialogRoot(props: DialogProps) {
if (parentId === null) {
return (
<FloatingTree>
<DialogInner {...props} />
<DialogInner
{...props}
isNested={false}
/>
</FloatingTree>
);
}

return <DialogInner {...props} />;
return (
<DialogInner
{...props}
isNested
/>
);
}
5 changes: 3 additions & 2 deletions packages/headless/src/primitives/dialog/dialog-viewport.tsx
Original file line numberDiff line numberDiff line change
Expand Up@@ -23,9 +23,9 @@ export interface DialogViewportProps extends ComponentProps<'div'> {
export const DialogViewport = React.forwardRef<HTMLDivElement, DialogViewportProps>(
function DialogViewport(props, ref) {
const { render, lockScroll = true, ...otherProps } = props;
const { open, mounted, transitionProps, modal } = useDialogContext();
const { open, mounted, isNested, transitionProps, modal } = useDialogContext();

const state = { open };
const state = { open, nested: isNested };

const defaultProps = {
...transitionProps,
Expand All@@ -40,6 +40,7 @@ export const DialogViewport = React.forwardRef<HTMLDivElement, DialogViewportPro
state,
stateAttributesMapping: {
open: (v: boolean): Record<string, string> | null => (v ? { 'data-open': '' } : { 'data-closed': '' }),
nested: (v: boolean): Record<string, string> | null => (v ? { 'data-nested': '' } : null),
},
props: mergeProps<'div'>(defaultProps, otherProps),
});
Expand Down
2 changes: 0 additions & 2 deletions packages/headless/src/primitives/drawer/drawer-context.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -44,8 +44,6 @@ export interface DrawerContextValue extends DialogContextValue {
snapRestOffset: number | null;
/** Callbacks a nested child `Drawer.Root` invokes on this (parent) drawer. */
onNested: NestedDrawerCallbacks;
/** True when this drawer is itself nested inside another drawer. */
isNested: boolean;
/** How many direct nested child drawers are currently open. */
nestedOpenCount: number;
}
Expand Down
Loading
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default"); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .changeset/olive-doors-tell.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
---
---
Comment on lines +1 to +2

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🗄️ Data Integrity & Integration | 🟠 Major | 🏗️ Heavy lift

Restore a changeset entry for the @clerk/ui Dialog API change.

This changeset is now empty, so the release carries no version bump and no changelog entry. packages/ui is published and pinned by external consumers — clerk/dashboard pins @clerk/ui at 1.7.0, and both clerk/dashboard and clerk/clerk load @clerk/ui@1 from the CDN.

This PR replaces the Mosaic Dialog modules, moves size from the popup to Dialog.Root, and drops sx in favour of .cl-dialog-* classes. Consumers need a changelog entry and an appropriate semver bump for that.

Choose one path:

  • Keep deprecated compatibility shims for the removed Dialog props and publish a minor release with a changeset describing the new API.
  • Publish a major release with a changeset that documents the migration from sx and from popup-level size.

As per coding guidelines, "Maintain backward compatibility in packages/clerk-js and packages/ui with SDK versions already in the wild" and "Use Changesets for version management and changelogs".

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In @.changeset/olive-doors-tell.md around lines 1 - 2, Restore the changeset
entry in the empty `.changeset/olive-doors-tell.md` file for the `@clerk/ui`
Dialog API change. Choose either a minor bump with deprecated compatibility
shims for removed props, or a major bump documenting migration from `sx` and
popup-level `size`; include the corresponding changelog details and valid
Changesets frontmatter.

Sources: Coding guidelines, Linked repositories

13 changes: 9 additions & 4 deletions packages/headless/src/primitives/dialog/README.md
Original file line numberDiff line numberDiff line change
Expand Up@@ -120,17 +120,22 @@ No additional props beyond standard HTML attributes and the `render` prop.

## Data Attributes

| Attribute | Applies To | Description |
| --------------------------- | ---------------------------------- | ----------- |
| `data-open` / `data-closed` | Trigger, Backdrop, Viewport, Popup | Open state |
| Attribute | Applies To | Description |
| --------------------------- | ---------------------------------- | ------------------------------------------- |
| `data-open` / `data-closed` | Trigger, Backdrop, Viewport, Popup | Open state |
| `data-nested` | Backdrop, Viewport, Popup | Opened from inside another floating element |

`data-nested` is what a stacked overlay styles itself from — chiefly so backdrops don't composite
into an ever-darker scrim as the stack grows. It reflects any floating ancestor, not strictly a
dialog one: the `FloatingTree` a Menu or Popover establishes counts too.

The headless parts are unstyled. Target a part with your own className (or `render` prop) and combine it with the `data-*` state attributes above.

## Important Notes

- **`Dialog.Popup` should be a child of `Dialog.Viewport`** for centered, scroll-locked modal behavior. The viewport hosts the fixed overlay container; the popup alone does not handle positioning or scroll lock.
- **Title and Description are optional but recommended.** If omitted, `aria-labelledby` / `aria-describedby` are simply absent from the popup.
- **Nested dialogs are supported.** The `FloatingTree` pattern handles nesting automatically.
- **Nested dialogs are supported**, and covered by tests. The `FloatingTree` pattern handles it: `useDismiss` blocks both Escape and outside-press on a parent while any child is open, and `FloatingOverlay`'s scroll lock is refcounted, so the body stays locked until the last dialog closes.
- **No positioning middleware.** Dialogs are centered via CSS, not Floating UI positioning.

## Authoring rule for new primitives
Expand Down
5 changes: 3 additions & 2 deletions packages/headless/src/primitives/dialog/dialog-backdrop.tsx
Original file line numberDiff line numberDiff line change
Expand Up@@ -12,9 +12,9 @@ export type DialogBackdropProps = ComponentProps<'div'>;
export const DialogBackdrop = React.forwardRef<HTMLDivElement, DialogBackdropProps>(
function DialogBackdrop(props, ref) {
const { render, ...otherProps } = props;
const { open, mounted, transitionProps } = useDialogContext();
const { open, mounted, isNested, transitionProps } = useDialogContext();

const state = { open };
const state = { open, nested: isNested };

const defaultProps = {
...transitionProps,
Expand All@@ -28,6 +28,7 @@ export const DialogBackdrop = React.forwardRef<HTMLDivElement, DialogBackdropPro
state,
stateAttributesMapping: {
open: (v: boolean): Record<string, string> | null => (v ? { 'data-open': '' } : { 'data-closed': '' }),
nested: (v: boolean): Record<string, string> | null => (v ? { 'data-nested': '' } : null),
},
props: mergeProps<'div'>(defaultProps, otherProps),
});
Expand Down
10 changes: 10 additions & 0 deletions packages/headless/src/primitives/dialog/dialog-context.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -14,6 +14,16 @@ export interface DialogContextValue {
/** Where focus goes when the dialog closes, or `null` to leave focus alone. */
returnFocusRef: React.MutableRefObject<HTMLElement | null>;
modal: boolean;
/**
* Whether this dialog opened from inside another floating element, so a stacked overlay can
* style itself differently from the one beneath it — chiefly so backdrops don't composite into
* an ever-darker scrim as the stack grows.
*
* True for any floating ancestor, not strictly a dialog one: the `FloatingTree` a Menu or
* Popover establishes counts too. That is the honest reading of what is knowable here, and the
* cases coincide in practice.
*/
isNested: boolean;
labelId: string;
descriptionId: string;
mounted: boolean;
Expand Down
8 changes: 7 additions & 1 deletion packages/headless/src/primitives/dialog/dialog-popup.tsx
Original file line numberDiff line numberDiff line change
Expand Up@@ -18,6 +18,7 @@ export const DialogPopup = React.forwardRef<HTMLDivElement, DialogPopupProps>(fu
getFloatingProps,
floatingContext,
modal,
isNested,
returnFocusRef,
labelId,
descriptionId,
Expand All@@ -30,7 +31,12 @@ export const DialogPopup = React.forwardRef<HTMLDivElement, DialogPopupProps>(fu
'aria-describedby': descriptionId,
} satisfies DefaultProps<'div'>;

const defaultProps = { ...ownProps, ...getFloatingProps(), ...transitionProps };
const defaultProps = {
...ownProps,
...(isNested ? { 'data-nested': '' } : {}),
...getFloatingProps(),
...transitionProps,
};

const element = useRender({
defaultTagName: 'div',
Expand Down
18 changes: 14 additions & 4 deletions packages/headless/src/primitives/dialog/dialog-root.tsx
Original file line numberDiff line numberDiff line change
Expand Up@@ -42,9 +42,9 @@ export interface DialogProps {
children: ReactNode;
}

function DialogInner(props: DialogProps) {
function DialogInner(props: DialogProps & { isNested: boolean }) {
const nodeId = useFloatingNodeId();
const { modal = true, closedBy = 'any', children } = props;
const { modal = true, closedBy = 'any', isNested, children } = props;

const [open, setOpen] = useControllableState(props.open, props.defaultOpen ?? false, props.onOpenChange);

Expand DownExpand Up@@ -87,6 +87,7 @@ function DialogInner(props: DialogProps) {
popupRef,
returnFocusRef,
modal,
isNested,
labelId,
descriptionId,
mounted,
Expand All@@ -101,6 +102,7 @@ function DialogInner(props: DialogProps) {
getFloatingProps,
returnFocusRef,
modal,
isNested,
labelId,
descriptionId,
mounted,
Expand All@@ -121,10 +123,18 @@ export function DialogRoot(props: DialogProps) {
if (parentId === null) {
return (
<FloatingTree>
<DialogInner {...props} />
<DialogInner
{...props}
isNested={false}
/>
</FloatingTree>
);
}

return <DialogInner {...props} />;
return (
<DialogInner
{...props}
isNested
/>
);
}
5 changes: 3 additions & 2 deletions packages/headless/src/primitives/dialog/dialog-viewport.tsx
Original file line numberDiff line numberDiff line change
Expand Up@@ -23,9 +23,9 @@ export interface DialogViewportProps extends ComponentProps<'div'> {
export const DialogViewport = React.forwardRef<HTMLDivElement, DialogViewportProps>(
function DialogViewport(props, ref) {
const { render, lockScroll = true, ...otherProps } = props;
const { open, mounted, transitionProps, modal } = useDialogContext();
const { open, mounted, isNested, transitionProps, modal } = useDialogContext();

const state = { open };
const state = { open, nested: isNested };

const defaultProps = {
...transitionProps,
Expand All@@ -40,6 +40,7 @@ export const DialogViewport = React.forwardRef<HTMLDivElement, DialogViewportPro
state,
stateAttributesMapping: {
open: (v: boolean): Record<string, string> | null => (v ? { 'data-open': '' } : { 'data-closed': '' }),
nested: (v: boolean): Record<string, string> | null => (v ? { 'data-nested': '' } : null),
},
props: mergeProps<'div'>(defaultProps, otherProps),
});
Expand Down
2 changes: 0 additions & 2 deletions packages/headless/src/primitives/drawer/drawer-context.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -44,8 +44,6 @@ export interface DrawerContextValue extends DialogContextValue {
snapRestOffset: number | null;
/** Callbacks a nested child `Drawer.Root` invokes on this (parent) drawer. */
onNested: NestedDrawerCallbacks;
/** True when this drawer is itself nested inside another drawer. */
isNested: boolean;
/** How many direct nested child drawers are currently open. */
nestedOpenCount: number;
}
Expand Down
Loading
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers"); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .changeset/olive-doors-tell.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
---
---
Comment on lines +1 to +2

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🗄️ Data Integrity & Integration | 🟠 Major | 🏗️ Heavy lift

Restore a changeset entry for the @clerk/ui Dialog API change.

This changeset is now empty, so the release carries no version bump and no changelog entry. packages/ui is published and pinned by external consumers — clerk/dashboard pins @clerk/ui at 1.7.0, and both clerk/dashboard and clerk/clerk load @clerk/ui@1 from the CDN.

This PR replaces the Mosaic Dialog modules, moves size from the popup to Dialog.Root, and drops sx in favour of .cl-dialog-* classes. Consumers need a changelog entry and an appropriate semver bump for that.

Choose one path:

  • Keep deprecated compatibility shims for the removed Dialog props and publish a minor release with a changeset describing the new API.
  • Publish a major release with a changeset that documents the migration from sx and from popup-level size.

As per coding guidelines, "Maintain backward compatibility in packages/clerk-js and packages/ui with SDK versions already in the wild" and "Use Changesets for version management and changelogs".

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In @.changeset/olive-doors-tell.md around lines 1 - 2, Restore the changeset
entry in the empty `.changeset/olive-doors-tell.md` file for the `@clerk/ui`
Dialog API change. Choose either a minor bump with deprecated compatibility
shims for removed props, or a major bump documenting migration from `sx` and
popup-level `size`; include the corresponding changelog details and valid
Changesets frontmatter.

Sources: Coding guidelines, Linked repositories

13 changes: 9 additions & 4 deletions packages/headless/src/primitives/dialog/README.md
Original file line numberDiff line numberDiff line change
Expand Up@@ -120,17 +120,22 @@ No additional props beyond standard HTML attributes and the `render` prop.

## Data Attributes

| Attribute | Applies To | Description |
| --------------------------- | ---------------------------------- | ----------- |
| `data-open` / `data-closed` | Trigger, Backdrop, Viewport, Popup | Open state |
| Attribute | Applies To | Description |
| --------------------------- | ---------------------------------- | ------------------------------------------- |
| `data-open` / `data-closed` | Trigger, Backdrop, Viewport, Popup | Open state |
| `data-nested` | Backdrop, Viewport, Popup | Opened from inside another floating element |

`data-nested` is what a stacked overlay styles itself from — chiefly so backdrops don't composite
into an ever-darker scrim as the stack grows. It reflects any floating ancestor, not strictly a
dialog one: the `FloatingTree` a Menu or Popover establishes counts too.

The headless parts are unstyled. Target a part with your own className (or `render` prop) and combine it with the `data-*` state attributes above.

## Important Notes

- **`Dialog.Popup` should be a child of `Dialog.Viewport`** for centered, scroll-locked modal behavior. The viewport hosts the fixed overlay container; the popup alone does not handle positioning or scroll lock.
- **Title and Description are optional but recommended.** If omitted, `aria-labelledby` / `aria-describedby` are simply absent from the popup.
- **Nested dialogs are supported.** The `FloatingTree` pattern handles nesting automatically.
- **Nested dialogs are supported**, and covered by tests. The `FloatingTree` pattern handles it: `useDismiss` blocks both Escape and outside-press on a parent while any child is open, and `FloatingOverlay`'s scroll lock is refcounted, so the body stays locked until the last dialog closes.
- **No positioning middleware.** Dialogs are centered via CSS, not Floating UI positioning.

## Authoring rule for new primitives
Expand Down
5 changes: 3 additions & 2 deletions packages/headless/src/primitives/dialog/dialog-backdrop.tsx
Original file line numberDiff line numberDiff line change
Expand Up@@ -12,9 +12,9 @@ export type DialogBackdropProps = ComponentProps<'div'>;
export const DialogBackdrop = React.forwardRef<HTMLDivElement, DialogBackdropProps>(
function DialogBackdrop(props, ref) {
const { render, ...otherProps } = props;
const { open, mounted, transitionProps } = useDialogContext();
const { open, mounted, isNested, transitionProps } = useDialogContext();

const state = { open };
const state = { open, nested: isNested };

const defaultProps = {
...transitionProps,
Expand All@@ -28,6 +28,7 @@ export const DialogBackdrop = React.forwardRef<HTMLDivElement, DialogBackdropPro
state,
stateAttributesMapping: {
open: (v: boolean): Record<string, string> | null => (v ? { 'data-open': '' } : { 'data-closed': '' }),
nested: (v: boolean): Record<string, string> | null => (v ? { 'data-nested': '' } : null),
},
props: mergeProps<'div'>(defaultProps, otherProps),
});
Expand Down
10 changes: 10 additions & 0 deletions packages/headless/src/primitives/dialog/dialog-context.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -14,6 +14,16 @@ export interface DialogContextValue {
/** Where focus goes when the dialog closes, or `null` to leave focus alone. */
returnFocusRef: React.MutableRefObject<HTMLElement | null>;
modal: boolean;
/**
* Whether this dialog opened from inside another floating element, so a stacked overlay can
* style itself differently from the one beneath it — chiefly so backdrops don't composite into
* an ever-darker scrim as the stack grows.
*
* True for any floating ancestor, not strictly a dialog one: the `FloatingTree` a Menu or
* Popover establishes counts too. That is the honest reading of what is knowable here, and the
* cases coincide in practice.
*/
isNested: boolean;
labelId: string;
descriptionId: string;
mounted: boolean;
Expand Down
8 changes: 7 additions & 1 deletion packages/headless/src/primitives/dialog/dialog-popup.tsx
Original file line numberDiff line numberDiff line change
Expand Up@@ -18,6 +18,7 @@ export const DialogPopup = React.forwardRef<HTMLDivElement, DialogPopupProps>(fu
getFloatingProps,
floatingContext,
modal,
isNested,
returnFocusRef,
labelId,
descriptionId,
Expand All@@ -30,7 +31,12 @@ export const DialogPopup = React.forwardRef<HTMLDivElement, DialogPopupProps>(fu
'aria-describedby': descriptionId,
} satisfies DefaultProps<'div'>;

const defaultProps = { ...ownProps, ...getFloatingProps(), ...transitionProps };
const defaultProps = {
...ownProps,
...(isNested ? { 'data-nested': '' } : {}),
...getFloatingProps(),
...transitionProps,
};

const element = useRender({
defaultTagName: 'div',
Expand Down
18 changes: 14 additions & 4 deletions packages/headless/src/primitives/dialog/dialog-root.tsx
Original file line numberDiff line numberDiff line change
Expand Up@@ -42,9 +42,9 @@ export interface DialogProps {
children: ReactNode;
}

function DialogInner(props: DialogProps) {
function DialogInner(props: DialogProps & { isNested: boolean }) {
const nodeId = useFloatingNodeId();
const { modal = true, closedBy = 'any', children } = props;
const { modal = true, closedBy = 'any', isNested, children } = props;

const [open, setOpen] = useControllableState(props.open, props.defaultOpen ?? false, props.onOpenChange);

Expand DownExpand Up@@ -87,6 +87,7 @@ function DialogInner(props: DialogProps) {
popupRef,
returnFocusRef,
modal,
isNested,
labelId,
descriptionId,
mounted,
Expand All@@ -101,6 +102,7 @@ function DialogInner(props: DialogProps) {
getFloatingProps,
returnFocusRef,
modal,
isNested,
labelId,
descriptionId,
mounted,
Expand All@@ -121,10 +123,18 @@ export function DialogRoot(props: DialogProps) {
if (parentId === null) {
return (
<FloatingTree>
<DialogInner {...props} />
<DialogInner
{...props}
isNested={false}
/>
</FloatingTree>
);
}

return <DialogInner {...props} />;
return (
<DialogInner
{...props}
isNested
/>
);
}
5 changes: 3 additions & 2 deletions packages/headless/src/primitives/dialog/dialog-viewport.tsx
Original file line numberDiff line numberDiff line change
Expand Up@@ -23,9 +23,9 @@ export interface DialogViewportProps extends ComponentProps<'div'> {
export const DialogViewport = React.forwardRef<HTMLDivElement, DialogViewportProps>(
function DialogViewport(props, ref) {
const { render, lockScroll = true, ...otherProps } = props;
const { open, mounted, transitionProps, modal } = useDialogContext();
const { open, mounted, isNested, transitionProps, modal } = useDialogContext();

const state = { open };
const state = { open, nested: isNested };

const defaultProps = {
...transitionProps,
Expand All@@ -40,6 +40,7 @@ export const DialogViewport = React.forwardRef<HTMLDivElement, DialogViewportPro
state,
stateAttributesMapping: {
open: (v: boolean): Record<string, string> | null => (v ? { 'data-open': '' } : { 'data-closed': '' }),
nested: (v: boolean): Record<string, string> | null => (v ? { 'data-nested': '' } : null),
},
props: mergeProps<'div'>(defaultProps, otherProps),
});
Expand Down
2 changes: 0 additions & 2 deletions packages/headless/src/primitives/drawer/drawer-context.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -44,8 +44,6 @@ export interface DrawerContextValue extends DialogContextValue {
snapRestOffset: number | null;
/** Callbacks a nested child `Drawer.Root` invokes on this (parent) drawer. */
onNested: NestedDrawerCallbacks;
/** True when this drawer is itself nested inside another drawer. */
isNested: boolean;
/** How many direct nested child drawers are currently open. */
nestedOpenCount: number;
}
Expand Down
Loading
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode"); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })();
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .changeset/olive-doors-tell.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
---
---
Comment on lines +1 to +2

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🗄️ Data Integrity & Integration | 🟠 Major | 🏗️ Heavy lift

Restore a changeset entry for the @clerk/ui Dialog API change.

This changeset is now empty, so the release carries no version bump and no changelog entry. packages/ui is published and pinned by external consumers — clerk/dashboard pins @clerk/ui at 1.7.0, and both clerk/dashboard and clerk/clerk load @clerk/ui@1 from the CDN.

This PR replaces the Mosaic Dialog modules, moves size from the popup to Dialog.Root, and drops sx in favour of .cl-dialog-* classes. Consumers need a changelog entry and an appropriate semver bump for that.

Choose one path:

  • Keep deprecated compatibility shims for the removed Dialog props and publish a minor release with a changeset describing the new API.
  • Publish a major release with a changeset that documents the migration from sx and from popup-level size.

As per coding guidelines, "Maintain backward compatibility in packages/clerk-js and packages/ui with SDK versions already in the wild" and "Use Changesets for version management and changelogs".

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In @.changeset/olive-doors-tell.md around lines 1 - 2, Restore the changeset
entry in the empty `.changeset/olive-doors-tell.md` file for the `@clerk/ui`
Dialog API change. Choose either a minor bump with deprecated compatibility
shims for removed props, or a major bump documenting migration from `sx` and
popup-level `size`; include the corresponding changelog details and valid
Changesets frontmatter.

Sources: Coding guidelines, Linked repositories

13 changes: 9 additions & 4 deletions packages/headless/src/primitives/dialog/README.md
Original file line numberDiff line numberDiff line change
Expand Up@@ -120,17 +120,22 @@ No additional props beyond standard HTML attributes and the `render` prop.

## Data Attributes

| Attribute | Applies To | Description |
| --------------------------- | ---------------------------------- | ----------- |
| `data-open` / `data-closed` | Trigger, Backdrop, Viewport, Popup | Open state |
| Attribute | Applies To | Description |
| --------------------------- | ---------------------------------- | ------------------------------------------- |
| `data-open` / `data-closed` | Trigger, Backdrop, Viewport, Popup | Open state |
| `data-nested` | Backdrop, Viewport, Popup | Opened from inside another floating element |

`data-nested` is what a stacked overlay styles itself from — chiefly so backdrops don't composite
into an ever-darker scrim as the stack grows. It reflects any floating ancestor, not strictly a
dialog one: the `FloatingTree` a Menu or Popover establishes counts too.

The headless parts are unstyled. Target a part with your own className (or `render` prop) and combine it with the `data-*` state attributes above.

## Important Notes

- **`Dialog.Popup` should be a child of `Dialog.Viewport`** for centered, scroll-locked modal behavior. The viewport hosts the fixed overlay container; the popup alone does not handle positioning or scroll lock.
- **Title and Description are optional but recommended.** If omitted, `aria-labelledby` / `aria-describedby` are simply absent from the popup.
- **Nested dialogs are supported.** The `FloatingTree` pattern handles nesting automatically.
- **Nested dialogs are supported**, and covered by tests. The `FloatingTree` pattern handles it: `useDismiss` blocks both Escape and outside-press on a parent while any child is open, and `FloatingOverlay`'s scroll lock is refcounted, so the body stays locked until the last dialog closes.
- **No positioning middleware.** Dialogs are centered via CSS, not Floating UI positioning.

## Authoring rule for new primitives
Expand Down
5 changes: 3 additions & 2 deletions packages/headless/src/primitives/dialog/dialog-backdrop.tsx
Original file line numberDiff line numberDiff line change
Expand Up@@ -12,9 +12,9 @@ export type DialogBackdropProps = ComponentProps<'div'>;
export const DialogBackdrop = React.forwardRef<HTMLDivElement, DialogBackdropProps>(
function DialogBackdrop(props, ref) {
const { render, ...otherProps } = props;
const { open, mounted, transitionProps } = useDialogContext();
const { open, mounted, isNested, transitionProps } = useDialogContext();

const state = { open };
const state = { open, nested: isNested };

const defaultProps = {
...transitionProps,
Expand All@@ -28,6 +28,7 @@ export const DialogBackdrop = React.forwardRef<HTMLDivElement, DialogBackdropPro
state,
stateAttributesMapping: {
open: (v: boolean): Record<string, string> | null => (v ? { 'data-open': '' } : { 'data-closed': '' }),
nested: (v: boolean): Record<string, string> | null => (v ? { 'data-nested': '' } : null),
},
props: mergeProps<'div'>(defaultProps, otherProps),
});
Expand Down
10 changes: 10 additions & 0 deletions packages/headless/src/primitives/dialog/dialog-context.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -14,6 +14,16 @@ export interface DialogContextValue {
/** Where focus goes when the dialog closes, or `null` to leave focus alone. */
returnFocusRef: React.MutableRefObject<HTMLElement | null>;
modal: boolean;
/**
* Whether this dialog opened from inside another floating element, so a stacked overlay can
* style itself differently from the one beneath it — chiefly so backdrops don't composite into
* an ever-darker scrim as the stack grows.
*
* True for any floating ancestor, not strictly a dialog one: the `FloatingTree` a Menu or
* Popover establishes counts too. That is the honest reading of what is knowable here, and the
* cases coincide in practice.
*/
isNested: boolean;
labelId: string;
descriptionId: string;
mounted: boolean;
Expand Down
8 changes: 7 additions & 1 deletion packages/headless/src/primitives/dialog/dialog-popup.tsx
Original file line numberDiff line numberDiff line change
Expand Up@@ -18,6 +18,7 @@ export const DialogPopup = React.forwardRef<HTMLDivElement, DialogPopupProps>(fu
getFloatingProps,
floatingContext,
modal,
isNested,
returnFocusRef,
labelId,
descriptionId,
Expand All@@ -30,7 +31,12 @@ export const DialogPopup = React.forwardRef<HTMLDivElement, DialogPopupProps>(fu
'aria-describedby': descriptionId,
} satisfies DefaultProps<'div'>;

const defaultProps = { ...ownProps, ...getFloatingProps(), ...transitionProps };
const defaultProps = {
...ownProps,
...(isNested ? { 'data-nested': '' } : {}),
...getFloatingProps(),
...transitionProps,
};

const element = useRender({
defaultTagName: 'div',
Expand Down
18 changes: 14 additions & 4 deletions packages/headless/src/primitives/dialog/dialog-root.tsx
Original file line numberDiff line numberDiff line change
Expand Up@@ -42,9 +42,9 @@ export interface DialogProps {
children: ReactNode;
}

function DialogInner(props: DialogProps) {
function DialogInner(props: DialogProps & { isNested: boolean }) {
const nodeId = useFloatingNodeId();
const { modal = true, closedBy = 'any', children } = props;
const { modal = true, closedBy = 'any', isNested, children } = props;

const [open, setOpen] = useControllableState(props.open, props.defaultOpen ?? false, props.onOpenChange);

Expand DownExpand Up@@ -87,6 +87,7 @@ function DialogInner(props: DialogProps) {
popupRef,
returnFocusRef,
modal,
isNested,
labelId,
descriptionId,
mounted,
Expand All@@ -101,6 +102,7 @@ function DialogInner(props: DialogProps) {
getFloatingProps,
returnFocusRef,
modal,
isNested,
labelId,
descriptionId,
mounted,
Expand All@@ -121,10 +123,18 @@ export function DialogRoot(props: DialogProps) {
if (parentId === null) {
return (
<FloatingTree>
<DialogInner {...props} />
<DialogInner
{...props}
isNested={false}
/>
</FloatingTree>
);
}

return <DialogInner {...props} />;
return (
<DialogInner
{...props}
isNested
/>
);
}
5 changes: 3 additions & 2 deletions packages/headless/src/primitives/dialog/dialog-viewport.tsx
Original file line numberDiff line numberDiff line change
Expand Up@@ -23,9 +23,9 @@ export interface DialogViewportProps extends ComponentProps<'div'> {
export const DialogViewport = React.forwardRef<HTMLDivElement, DialogViewportProps>(
function DialogViewport(props, ref) {
const { render, lockScroll = true, ...otherProps } = props;
const { open, mounted, transitionProps, modal } = useDialogContext();
const { open, mounted, isNested, transitionProps, modal } = useDialogContext();

const state = { open };
const state = { open, nested: isNested };

const defaultProps = {
...transitionProps,
Expand All@@ -40,6 +40,7 @@ export const DialogViewport = React.forwardRef<HTMLDivElement, DialogViewportPro
state,
stateAttributesMapping: {
open: (v: boolean): Record<string, string> | null => (v ? { 'data-open': '' } : { 'data-closed': '' }),
nested: (v: boolean): Record<string, string> | null => (v ? { 'data-nested': '' } : null),
},
props: mergeProps<'div'>(defaultProps, otherProps),
});
Expand Down
2 changes: 0 additions & 2 deletions packages/headless/src/primitives/drawer/drawer-context.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -44,8 +44,6 @@ export interface DrawerContextValue extends DialogContextValue {
snapRestOffset: number | null;
/** Callbacks a nested child `Drawer.Root` invokes on this (parent) drawer. */
onNested: NestedDrawerCallbacks;
/** True when this drawer is itself nested inside another drawer. */
isNested: boolean;
/** How many direct nested child drawers are currently open. */
nestedOpenCount: number;
}
Expand Down
Loading
Loading