Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎯 Functional Correctness | 🟠 Major | ⚡ Quick win
Use
lightDarkinstead of rawlight-dark().The declaration bypasses the repository’s support-aware helper. Browsers without
light-dark()support can ignore the entireboxShadowdeclaration. ApplylightDarkto each color value so the style keeps the supported fallback.As per coding guidelines: “Use CSS
light-dark()function via thelightDarkutility ... for automatic light/dark mode support with fallbacks.” Repository context identifiespackages/ui/src/utils/lightDark.ts:14-18as the support-aware implementation.Proposed fix
📝 Committable suggestion
🤖 Prompt for AI Agents
Source: Coding guidelines