fix(backend): Reject JWT-template tokens on the acceptsToken any/array header path - #9511

Merged
dominic-clerk merged 1 commit into
mainfrom
dominic/sec-340-accepts-token-any-jwt-template
Aug 31, 2026
Merged

fix(backend): Reject JWT-template tokens on the acceptsToken any/array header path#9511
dominic-clerk merged 1 commit into
mainfrom
dominic/sec-340-accepts-token-any-jwt-template

Conversation

@dominic-clerk

@dominic-clerkdominic-clerk commented Aug 20, 2026

Copy link
Copy Markdown
Contributor

Description

Follow-up to #9469 (SEC-340). That PR rejects JWT-template tokens (cat=cl_B7d4PD222AAA) on the session-only header and cookie paths, but authenticateAnyRequestWithTokenInHeader — used when acceptsToken is 'any' or an array that includes 'session_token' — still fell through isMachineToken() → verifyToken() → signedIn, so a template token in the Authorization header was accepted as a session_token on those routes. Same consequence as the original report: the token has no sid and outlives revocation of the session that minted it, and it carries no sts, so a pending session presents as fully signed in.

This adds the same hasNonSessionJwtCategory check before the session-token branch of that path, returning signed-out / token-type-mismatch, and extends the SEC-340 regression tests to cover acceptsToken: 'any' and ['session_token', 'm2m_token'].

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

🤖 Generated with Claude Code

@dominic-clerk@claude
fix(backend): Reject JWT-template tokens on the acceptsToken any/arra…
3c605a6
…y header path
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@vercel

vercelBot commented Aug 20, 2026•
edited
Loading

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxReadyReadyPreviewAug 20, 2026 1:47pm
swingsetReadyReadyPreviewAug 20, 2026 1:47pm

Request Review

@github-actions

github-actionsBot commented Aug 20, 2026

Copy link
Copy Markdown
Contributor

API Changes Report

Generated by Break Check on 2026-08-20T13:47:59.934Z

Summary

MetricCount
Packages analyzed19
Packages with changes0
🔴 Breaking changes0
🟡 Non-breaking changes0
🟢 Additions0

No API Changes Detected

All packages have stable APIs with no detected changes.

Report generated by Break Check

Last ran on 3c605a6.

@pkg-pr-new

pkg-pr-newBot commented Aug 20, 2026

Copy link
Copy Markdown

Open in StackBlitz

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@9511

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@9511

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@9511

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@9511

@clerk/electron

npm i https://pkg.pr.new/@clerk/electron@9511

@clerk/electron-passkeys

npm i https://pkg.pr.new/@clerk/electron-passkeys@9511

@clerk/eslint-plugin

npm i https://pkg.pr.new/@clerk/eslint-plugin@9511

@clerk/expo

npm i https://pkg.pr.new/@clerk/expo@9511

@clerk/expo-google-signin

npm i https://pkg.pr.new/@clerk/expo-google-signin@9511

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@9511

@clerk/express

npm i https://pkg.pr.new/@clerk/express@9511

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@9511

@clerk/hono

npm i https://pkg.pr.new/@clerk/hono@9511

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@9511

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@9511

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@9511

@clerk/react

npm i https://pkg.pr.new/@clerk/react@9511

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@9511

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@9511

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@9511

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@9511

@clerk/ui

npm i https://pkg.pr.new/@clerk/ui@9511

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@9511

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@9511

commit: 3c605a6

@coderabbitai

coderabbitaiBot commented Aug 20, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: 0914e179-eb3b-421e-916e-b3e2f481ad19

📥 Commits

Reviewing files that changed from the base of the PR and between 99082cb and 3c605a6.

📒 Files selected for processing (3)
  • .changeset/reject-jwt-template-accepts-token-any.md
  • packages/backend/src/tokens/__tests__/request.test.ts
  • packages/backend/src/tokens/request.ts
🔗 Linked repositories identified

CodeRabbit considers these linked repositories for cross-repo context during reviews:

  • clerk/clerk_go(manual)
  • clerk/dashboard(manual)
  • clerk/accounts(manual)
  • clerk/backoffice(manual)
  • clerk/clerk(manual)
  • clerk/clerk-docs(manual)
  • clerk/cloudflare-workers(manual)
  • clerk/clerk-ios(auto-detected)
  • clerk/cli(auto-detected)
  • clerk/clerk-android(auto-detected)

Included review availability: 8 reviews are currently available. Your included PR review attempts over the past 7 days set your current allowance at 10 reviews per hour.

📝 Walkthrough

Walkthrough

The fallback session-token path now rejects JWT-template tokens with non-session categories before session-token verification. The regression tests cover header and cookie carriers, acceptsToken: 'any', and mixed session/M2M configurations. A patch changeset documents the token-type-mismatch signed-out state.

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk:⚪ Minimal · up to 3c605

This change rejects JWT-template tokens on the affected session-token header paths and adds regression coverage; no actionable merge-blocking risk remains beyond normal checks and review.

Suggested reviewers:jacekradko

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check nameStatusExplanation
Title check✅ PassedThe title clearly identifies the backend fix for rejecting JWT-template tokens on the acceptsToken any or array header path.
Description check✅ PassedThe description accurately explains the bug, the fix, the token-type-mismatch behavior, and the added regression tests.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.

Comment @coderabbitai help to get the list of available commands.

@dominic-clerk
dominic-clerk merged commit eef0ceb into mainAug 31, 2026
52 checks passed
@dominic-clerk
dominic-clerk deleted the dominic/sec-340-accepts-token-any-jwt-template branch August 31, 2026 16:46
@clerk-cookieclerk-cookie mentioned this pull request Aug 31, 2026
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wobsorianowobsorianowobsoriano approved these changes

Assignees

No one assigned

Labels

backend

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dominic-clerk@wobsoriano
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
fix(backend): Reject JWT-template tokens on the acceptsToken any/array header path - #9511
Merged
dominic-clerk merged 1 commit into
mainfrom 
dominic/sec-340-accepts-token-any-jwt-template
Aug 31, 2026
Merged
fix(backend): Reject JWT-template tokens on the acceptsToken any/array header path#9511
dominic-clerk merged 1 commit into
mainfrom 
dominic/sec-340-accepts-token-any-jwt-template
Conversation
@dominic-clerk
@dominic-clerkdominic-clerk
commented
Aug 20, 2026

Copy link


Copy Markdown

Contributor
Description
Follow-up to #9469 (SEC-340). That PR rejects JWT-template tokens (cat=cl_B7d4PD222AAA) on the session-only header and cookie paths, but authenticateAnyRequestWithTokenInHeader — used when acceptsToken is 'any' or an array that includes 'session_token' — still fell through isMachineToken() → verifyToken() → signedIn, so a template token in the Authorization header was accepted as a session_token on those routes. Same consequence as the original report: the token has no sid and outlives revocation of the session that minted it, and it carries no sts, so a pending session presents as fully signed in.
This adds the same hasNonSessionJwtCategory check before the session-token branch of that path, returning signed-out / token-type-mismatch, and extends the SEC-340 regression tests to cover acceptsToken: 'any' and ['session_token', 'm2m_token'].
Checklist
  • pnpm test runs as expected.
  • pnpm build runs as expected.
  •  (If applicable) JSDoc comments have been added or updated for any package exports
  •  (If applicable) Documentation has been updated
Type of change
  •  🐛 Bug fix
  •  🌟 New feature
  •  🔨 Breaking change
  •  📖 Refactoring / dependency upgrade / documentation
  •  other:
🤖 Generated with Claude Code
@dominic-clerk@claude
fix(backend): Reject JWT-template tokens on the acceptsToken any/arra…
3c605a6
…y header path
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@vercel
vercelBot
commented
Aug 20, 2026•

edited

Loading

Copy link


Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.
ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxReadyReadyPreviewAug 20, 2026 1:47pm
swingsetReadyReadyPreviewAug 20, 2026 1:47pm
Request Review
@github-actions
github-actionsBot
commented
Aug 20, 2026

Copy link


Copy Markdown

Contributor
API Changes Report
Generated by Break Check on 2026-08-20T13:47:59.934Z
Summary
MetricCount
Packages analyzed19
Packages with changes0
🔴 Breaking changes0
🟡 Non-breaking changes0
🟢 Additions0
No API Changes Detected
All packages have stable APIs with no detected changes.
Report generated by Break Check
Last ran on 3c605a6.
@pkg-pr-new
pkg-pr-newBot
commented
Aug 20, 2026

Copy link


Copy Markdown

Open in StackBlitz
@clerk/astro
npm i https://pkg.pr.new/@clerk/astro@9511

@clerk/backend
npm i https://pkg.pr.new/@clerk/backend@9511

@clerk/chrome-extension
npm i https://pkg.pr.new/@clerk/chrome-extension@9511

@clerk/clerk-js
npm i https://pkg.pr.new/@clerk/clerk-js@9511

@clerk/electron
npm i https://pkg.pr.new/@clerk/electron@9511

@clerk/electron-passkeys
npm i https://pkg.pr.new/@clerk/electron-passkeys@9511

@clerk/eslint-plugin
npm i https://pkg.pr.new/@clerk/eslint-plugin@9511

@clerk/expo
npm i https://pkg.pr.new/@clerk/expo@9511

@clerk/expo-google-signin
npm i https://pkg.pr.new/@clerk/expo-google-signin@9511

@clerk/expo-passkeys
npm i https://pkg.pr.new/@clerk/expo-passkeys@9511

@clerk/express
npm i https://pkg.pr.new/@clerk/express@9511

@clerk/fastify
npm i https://pkg.pr.new/@clerk/fastify@9511

@clerk/hono
npm i https://pkg.pr.new/@clerk/hono@9511

@clerk/localizations
npm i https://pkg.pr.new/@clerk/localizations@9511

@clerk/nextjs
npm i https://pkg.pr.new/@clerk/nextjs@9511

@clerk/nuxt
npm i https://pkg.pr.new/@clerk/nuxt@9511

@clerk/react
npm i https://pkg.pr.new/@clerk/react@9511

@clerk/react-router
npm i https://pkg.pr.new/@clerk/react-router@9511

@clerk/shared
npm i https://pkg.pr.new/@clerk/shared@9511

@clerk/tanstack-react-start
npm i https://pkg.pr.new/@clerk/tanstack-react-start@9511

@clerk/testing
npm i https://pkg.pr.new/@clerk/testing@9511

@clerk/ui
npm i https://pkg.pr.new/@clerk/ui@9511

@clerk/upgrade
npm i https://pkg.pr.new/@clerk/upgrade@9511

@clerk/vue
npm i https://pkg.pr.new/@clerk/vue@9511

commit: 3c605a6
@coderabbitai
coderabbitaiBot
commented
Aug 20, 2026

Copy link


Copy Markdown

Contributor
Review Change Stack
No actionable comments were generated in the recent review. 🎉
ℹ️ Recent review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Organization UI (inherited)
Review profile: CHILL
Plan: Pro Plus
Run ID: 0914e179-eb3b-421e-916e-b3e2f481ad19
📥 Commits
Reviewing files that changed from the base of the PR and between 99082cb and 3c605a6.
📒 Files selected for processing (3)
  • .changeset/reject-jwt-template-accepts-token-any.md
  • packages/backend/src/tokens/__tests__/request.test.ts
  • packages/backend/src/tokens/request.ts
🔗 Linked repositories identified
CodeRabbit considers these linked repositories for cross-repo context during reviews:
  • clerk/clerk_go(manual)
  • clerk/dashboard(manual)
  • clerk/accounts(manual)
  • clerk/backoffice(manual)
  • clerk/clerk(manual)
  • clerk/clerk-docs(manual)
  • clerk/cloudflare-workers(manual)
  • clerk/clerk-ios(auto-detected)
  • clerk/cli(auto-detected)
  • clerk/clerk-android(auto-detected)
Included review availability: 8 reviews are currently available. Your included PR review attempts over the past 7 days set your current allowance at 10 reviews per hour.
📝 Walkthrough
Walkthrough
The fallback session-token path now rejects JWT-template tokens with non-session categories before session-token verification. The regression tests cover header and cookie carriers, acceptsToken: 'any', and mixed session/M2M configurations. A patch changeset documents the token-type-mismatch signed-out state.
Estimated code review effort: 2 (Simple) | ~10 minutes
Merge Risk:⚪ Minimal · up to 3c605
This change rejects JWT-template tokens on the affected session-token header paths and adds regression coverage; no actionable merge-blocking risk remains beyond normal checks and review.
Suggested reviewers:jacekradko
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check nameStatusExplanation
Title check✅ PassedThe title clearly identifies the backend fix for rejecting JWT-template tokens on the acceptsToken any or array header path.
Description check✅ PassedThe description accurately explains the bug, the fix, the token-type-mismatch behavior, and the added regression tests.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
Comment @coderabbitai help to get the list of available commands.
@dominic-clerk
dominic-clerk
merged commit eef0ceb
into
mainAug 31, 2026

52 checks passed

@dominic-clerk
dominic-clerk
deleted the

dominic/sec-340-accepts-token-any-jwt-template

branch
August 31, 2026 16:46
@clerk-cookieclerk-cookie
mentioned this pull request
Aug 31, 2026
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@wobsorianowobsorianowobsoriano approved these changes

Assignees


No one assigned


Labels

backend

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@dominic-clerk@wobsoriano

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
fix(backend): Reject JWT-template tokens on the acceptsToken any/array header path - #9511
Merged
dominic-clerk merged 1 commit into
mainfrom 
dominic/sec-340-accepts-token-any-jwt-template
Aug 31, 2026
Merged
fix(backend): Reject JWT-template tokens on the acceptsToken any/array header path#9511
dominic-clerk merged 1 commit into
mainfrom 
dominic/sec-340-accepts-token-any-jwt-template
Conversation
@dominic-clerk
@dominic-clerkdominic-clerk
commented
Aug 20, 2026

Copy link


Copy Markdown

Contributor
Description
Follow-up to #9469 (SEC-340). That PR rejects JWT-template tokens (cat=cl_B7d4PD222AAA) on the session-only header and cookie paths, but authenticateAnyRequestWithTokenInHeader — used when acceptsToken is 'any' or an array that includes 'session_token' — still fell through isMachineToken() → verifyToken() → signedIn, so a template token in the Authorization header was accepted as a session_token on those routes. Same consequence as the original report: the token has no sid and outlives revocation of the session that minted it, and it carries no sts, so a pending session presents as fully signed in.
This adds the same hasNonSessionJwtCategory check before the session-token branch of that path, returning signed-out / token-type-mismatch, and extends the SEC-340 regression tests to cover acceptsToken: 'any' and ['session_token', 'm2m_token'].
Checklist
  • pnpm test runs as expected.
  • pnpm build runs as expected.
  •  (If applicable) JSDoc comments have been added or updated for any package exports
  •  (If applicable) Documentation has been updated
Type of change
  •  🐛 Bug fix
  •  🌟 New feature
  •  🔨 Breaking change
  •  📖 Refactoring / dependency upgrade / documentation
  •  other:
🤖 Generated with Claude Code
@dominic-clerk@claude
fix(backend): Reject JWT-template tokens on the acceptsToken any/arra…
3c605a6
…y header path
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@vercel
vercelBot
commented
Aug 20, 2026•

edited

Loading

Copy link


Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.
ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxReadyReadyPreviewAug 20, 2026 1:47pm
swingsetReadyReadyPreviewAug 20, 2026 1:47pm
Request Review
@github-actions
github-actionsBot
commented
Aug 20, 2026

Copy link


Copy Markdown

Contributor
API Changes Report
Generated by Break Check on 2026-08-20T13:47:59.934Z
Summary
MetricCount
Packages analyzed19
Packages with changes0
🔴 Breaking changes0
🟡 Non-breaking changes0
🟢 Additions0
No API Changes Detected
All packages have stable APIs with no detected changes.
Report generated by Break Check
Last ran on 3c605a6.
@pkg-pr-new
pkg-pr-newBot
commented
Aug 20, 2026

Copy link


Copy Markdown

Open in StackBlitz
@clerk/astro
npm i https://pkg.pr.new/@clerk/astro@9511

@clerk/backend
npm i https://pkg.pr.new/@clerk/backend@9511

@clerk/chrome-extension
npm i https://pkg.pr.new/@clerk/chrome-extension@9511

@clerk/clerk-js
npm i https://pkg.pr.new/@clerk/clerk-js@9511

@clerk/electron
npm i https://pkg.pr.new/@clerk/electron@9511

@clerk/electron-passkeys
npm i https://pkg.pr.new/@clerk/electron-passkeys@9511

@clerk/eslint-plugin
npm i https://pkg.pr.new/@clerk/eslint-plugin@9511

@clerk/expo
npm i https://pkg.pr.new/@clerk/expo@9511

@clerk/expo-google-signin
npm i https://pkg.pr.new/@clerk/expo-google-signin@9511

@clerk/expo-passkeys
npm i https://pkg.pr.new/@clerk/expo-passkeys@9511

@clerk/express
npm i https://pkg.pr.new/@clerk/express@9511

@clerk/fastify
npm i https://pkg.pr.new/@clerk/fastify@9511

@clerk/hono
npm i https://pkg.pr.new/@clerk/hono@9511

@clerk/localizations
npm i https://pkg.pr.new/@clerk/localizations@9511

@clerk/nextjs
npm i https://pkg.pr.new/@clerk/nextjs@9511

@clerk/nuxt
npm i https://pkg.pr.new/@clerk/nuxt@9511

@clerk/react
npm i https://pkg.pr.new/@clerk/react@9511

@clerk/react-router
npm i https://pkg.pr.new/@clerk/react-router@9511

@clerk/shared
npm i https://pkg.pr.new/@clerk/shared@9511

@clerk/tanstack-react-start
npm i https://pkg.pr.new/@clerk/tanstack-react-start@9511

@clerk/testing
npm i https://pkg.pr.new/@clerk/testing@9511

@clerk/ui
npm i https://pkg.pr.new/@clerk/ui@9511

@clerk/upgrade
npm i https://pkg.pr.new/@clerk/upgrade@9511

@clerk/vue
npm i https://pkg.pr.new/@clerk/vue@9511

commit: 3c605a6
@coderabbitai
coderabbitaiBot
commented
Aug 20, 2026

Copy link


Copy Markdown

Contributor
Review Change Stack
No actionable comments were generated in the recent review. 🎉
ℹ️ Recent review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Organization UI (inherited)
Review profile: CHILL
Plan: Pro Plus
Run ID: 0914e179-eb3b-421e-916e-b3e2f481ad19
📥 Commits
Reviewing files that changed from the base of the PR and between 99082cb and 3c605a6.
📒 Files selected for processing (3)
  • .changeset/reject-jwt-template-accepts-token-any.md
  • packages/backend/src/tokens/__tests__/request.test.ts
  • packages/backend/src/tokens/request.ts
🔗 Linked repositories identified
CodeRabbit considers these linked repositories for cross-repo context during reviews:
  • clerk/clerk_go(manual)
  • clerk/dashboard(manual)
  • clerk/accounts(manual)
  • clerk/backoffice(manual)
  • clerk/clerk(manual)
  • clerk/clerk-docs(manual)
  • clerk/cloudflare-workers(manual)
  • clerk/clerk-ios(auto-detected)
  • clerk/cli(auto-detected)
  • clerk/clerk-android(auto-detected)
Included review availability: 8 reviews are currently available. Your included PR review attempts over the past 7 days set your current allowance at 10 reviews per hour.
📝 Walkthrough
Walkthrough
The fallback session-token path now rejects JWT-template tokens with non-session categories before session-token verification. The regression tests cover header and cookie carriers, acceptsToken: 'any', and mixed session/M2M configurations. A patch changeset documents the token-type-mismatch signed-out state.
Estimated code review effort: 2 (Simple) | ~10 minutes
Merge Risk:⚪ Minimal · up to 3c605
This change rejects JWT-template tokens on the affected session-token header paths and adds regression coverage; no actionable merge-blocking risk remains beyond normal checks and review.
Suggested reviewers:jacekradko
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check nameStatusExplanation
Title check✅ PassedThe title clearly identifies the backend fix for rejecting JWT-template tokens on the acceptsToken any or array header path.
Description check✅ PassedThe description accurately explains the bug, the fix, the token-type-mismatch behavior, and the added regression tests.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
Comment @coderabbitai help to get the list of available commands.
@dominic-clerk
dominic-clerk
merged commit eef0ceb
into
mainAug 31, 2026

52 checks passed

@dominic-clerk
dominic-clerk
deleted the

dominic/sec-340-accepts-token-any-jwt-template

branch
August 31, 2026 16:46
@clerk-cookieclerk-cookie
mentioned this pull request
Aug 31, 2026
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@wobsorianowobsorianowobsoriano approved these changes

Assignees


No one assigned


Labels

backend

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@dominic-clerk@wobsoriano

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
fix(backend): Reject JWT-template tokens on the acceptsToken any/array header path - #9511
Merged
dominic-clerk merged 1 commit into
mainfrom 
dominic/sec-340-accepts-token-any-jwt-template
Aug 31, 2026
Merged
fix(backend): Reject JWT-template tokens on the acceptsToken any/array header path#9511
dominic-clerk merged 1 commit into
mainfrom 
dominic/sec-340-accepts-token-any-jwt-template
Conversation
@dominic-clerk
@dominic-clerkdominic-clerk
commented
Aug 20, 2026

Copy link


Copy Markdown

Contributor
Description
Follow-up to #9469 (SEC-340). That PR rejects JWT-template tokens (cat=cl_B7d4PD222AAA) on the session-only header and cookie paths, but authenticateAnyRequestWithTokenInHeader — used when acceptsToken is 'any' or an array that includes 'session_token' — still fell through isMachineToken() → verifyToken() → signedIn, so a template token in the Authorization header was accepted as a session_token on those routes. Same consequence as the original report: the token has no sid and outlives revocation of the session that minted it, and it carries no sts, so a pending session presents as fully signed in.
This adds the same hasNonSessionJwtCategory check before the session-token branch of that path, returning signed-out / token-type-mismatch, and extends the SEC-340 regression tests to cover acceptsToken: 'any' and ['session_token', 'm2m_token'].
Checklist
  • pnpm test runs as expected.
  • pnpm build runs as expected.
  •  (If applicable) JSDoc comments have been added or updated for any package exports
  •  (If applicable) Documentation has been updated
Type of change
  •  🐛 Bug fix
  •  🌟 New feature
  •  🔨 Breaking change
  •  📖 Refactoring / dependency upgrade / documentation
  •  other:
🤖 Generated with Claude Code
@dominic-clerk@claude
fix(backend): Reject JWT-template tokens on the acceptsToken any/arra…
3c605a6
…y header path
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@vercel
vercelBot
commented
Aug 20, 2026•

edited

Loading

Copy link


Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.
ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxReadyReadyPreviewAug 20, 2026 1:47pm
swingsetReadyReadyPreviewAug 20, 2026 1:47pm
Request Review
@github-actions
github-actionsBot
commented
Aug 20, 2026

Copy link


Copy Markdown

Contributor
API Changes Report
Generated by Break Check on 2026-08-20T13:47:59.934Z
Summary
MetricCount
Packages analyzed19
Packages with changes0
🔴 Breaking changes0
🟡 Non-breaking changes0
🟢 Additions0
No API Changes Detected
All packages have stable APIs with no detected changes.
Report generated by Break Check
Last ran on 3c605a6.
@pkg-pr-new
pkg-pr-newBot
commented
Aug 20, 2026

Copy link


Copy Markdown

Open in StackBlitz
@clerk/astro
npm i https://pkg.pr.new/@clerk/astro@9511

@clerk/backend
npm i https://pkg.pr.new/@clerk/backend@9511

@clerk/chrome-extension
npm i https://pkg.pr.new/@clerk/chrome-extension@9511

@clerk/clerk-js
npm i https://pkg.pr.new/@clerk/clerk-js@9511

@clerk/electron
npm i https://pkg.pr.new/@clerk/electron@9511

@clerk/electron-passkeys
npm i https://pkg.pr.new/@clerk/electron-passkeys@9511

@clerk/eslint-plugin
npm i https://pkg.pr.new/@clerk/eslint-plugin@9511

@clerk/expo
npm i https://pkg.pr.new/@clerk/expo@9511

@clerk/expo-google-signin
npm i https://pkg.pr.new/@clerk/expo-google-signin@9511

@clerk/expo-passkeys
npm i https://pkg.pr.new/@clerk/expo-passkeys@9511

@clerk/express
npm i https://pkg.pr.new/@clerk/express@9511

@clerk/fastify
npm i https://pkg.pr.new/@clerk/fastify@9511

@clerk/hono
npm i https://pkg.pr.new/@clerk/hono@9511

@clerk/localizations
npm i https://pkg.pr.new/@clerk/localizations@9511

@clerk/nextjs
npm i https://pkg.pr.new/@clerk/nextjs@9511

@clerk/nuxt
npm i https://pkg.pr.new/@clerk/nuxt@9511

@clerk/react
npm i https://pkg.pr.new/@clerk/react@9511

@clerk/react-router
npm i https://pkg.pr.new/@clerk/react-router@9511

@clerk/shared
npm i https://pkg.pr.new/@clerk/shared@9511

@clerk/tanstack-react-start
npm i https://pkg.pr.new/@clerk/tanstack-react-start@9511

@clerk/testing
npm i https://pkg.pr.new/@clerk/testing@9511

@clerk/ui
npm i https://pkg.pr.new/@clerk/ui@9511

@clerk/upgrade
npm i https://pkg.pr.new/@clerk/upgrade@9511

@clerk/vue
npm i https://pkg.pr.new/@clerk/vue@9511

commit: 3c605a6
@coderabbitai
coderabbitaiBot
commented
Aug 20, 2026

Copy link


Copy Markdown

Contributor
Review Change Stack
No actionable comments were generated in the recent review. 🎉
ℹ️ Recent review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Organization UI (inherited)
Review profile: CHILL
Plan: Pro Plus
Run ID: 0914e179-eb3b-421e-916e-b3e2f481ad19
📥 Commits
Reviewing files that changed from the base of the PR and between 99082cb and 3c605a6.
📒 Files selected for processing (3)
  • .changeset/reject-jwt-template-accepts-token-any.md
  • packages/backend/src/tokens/__tests__/request.test.ts
  • packages/backend/src/tokens/request.ts
🔗 Linked repositories identified
CodeRabbit considers these linked repositories for cross-repo context during reviews:
  • clerk/clerk_go(manual)
  • clerk/dashboard(manual)
  • clerk/accounts(manual)
  • clerk/backoffice(manual)
  • clerk/clerk(manual)
  • clerk/clerk-docs(manual)
  • clerk/cloudflare-workers(manual)
  • clerk/clerk-ios(auto-detected)
  • clerk/cli(auto-detected)
  • clerk/clerk-android(auto-detected)
Included review availability: 8 reviews are currently available. Your included PR review attempts over the past 7 days set your current allowance at 10 reviews per hour.
📝 Walkthrough
Walkthrough
The fallback session-token path now rejects JWT-template tokens with non-session categories before session-token verification. The regression tests cover header and cookie carriers, acceptsToken: 'any', and mixed session/M2M configurations. A patch changeset documents the token-type-mismatch signed-out state.
Estimated code review effort: 2 (Simple) | ~10 minutes
Merge Risk:⚪ Minimal · up to 3c605
This change rejects JWT-template tokens on the affected session-token header paths and adds regression coverage; no actionable merge-blocking risk remains beyond normal checks and review.
Suggested reviewers:jacekradko
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check nameStatusExplanation
Title check✅ PassedThe title clearly identifies the backend fix for rejecting JWT-template tokens on the acceptsToken any or array header path.
Description check✅ PassedThe description accurately explains the bug, the fix, the token-type-mismatch behavior, and the added regression tests.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
Comment @coderabbitai help to get the list of available commands.
@dominic-clerk
dominic-clerk
merged commit eef0ceb
into
mainAug 31, 2026

52 checks passed

@dominic-clerk
dominic-clerk
deleted the

dominic/sec-340-accepts-token-any-jwt-template

branch
August 31, 2026 16:46
@clerk-cookieclerk-cookie
mentioned this pull request
Aug 31, 2026
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@wobsorianowobsorianowobsoriano approved these changes

Assignees


No one assigned


Labels

backend

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@dominic-clerk@wobsoriano

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
fix(backend): Reject JWT-template tokens on the acceptsToken any/array header path - #9511
Merged
dominic-clerk merged 1 commit into
mainfrom 
dominic/sec-340-accepts-token-any-jwt-template
Aug 31, 2026
Merged
fix(backend): Reject JWT-template tokens on the acceptsToken any/array header path#9511
dominic-clerk merged 1 commit into
mainfrom 
dominic/sec-340-accepts-token-any-jwt-template
Conversation
@dominic-clerk
@dominic-clerkdominic-clerk
commented
Aug 20, 2026

Copy link


Copy Markdown

Contributor
Description
Follow-up to #9469 (SEC-340). That PR rejects JWT-template tokens (cat=cl_B7d4PD222AAA) on the session-only header and cookie paths, but authenticateAnyRequestWithTokenInHeader — used when acceptsToken is 'any' or an array that includes 'session_token' — still fell through isMachineToken() → verifyToken() → signedIn, so a template token in the Authorization header was accepted as a session_token on those routes. Same consequence as the original report: the token has no sid and outlives revocation of the session that minted it, and it carries no sts, so a pending session presents as fully signed in.
This adds the same hasNonSessionJwtCategory check before the session-token branch of that path, returning signed-out / token-type-mismatch, and extends the SEC-340 regression tests to cover acceptsToken: 'any' and ['session_token', 'm2m_token'].
Checklist
  • pnpm test runs as expected.
  • pnpm build runs as expected.
  •  (If applicable) JSDoc comments have been added or updated for any package exports
  •  (If applicable) Documentation has been updated
Type of change
  •  🐛 Bug fix
  •  🌟 New feature
  •  🔨 Breaking change
  •  📖 Refactoring / dependency upgrade / documentation
  •  other:
🤖 Generated with Claude Code
@dominic-clerk@claude
fix(backend): Reject JWT-template tokens on the acceptsToken any/arra…
3c605a6
…y header path
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@vercel
vercelBot
commented
Aug 20, 2026•

edited

Loading

Copy link


Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.
ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxReadyReadyPreviewAug 20, 2026 1:47pm
swingsetReadyReadyPreviewAug 20, 2026 1:47pm
Request Review
@github-actions
github-actionsBot
commented
Aug 20, 2026

Copy link


Copy Markdown

Contributor
API Changes Report
Generated by Break Check on 2026-08-20T13:47:59.934Z
Summary
MetricCount
Packages analyzed19
Packages with changes0
🔴 Breaking changes0
🟡 Non-breaking changes0
🟢 Additions0
No API Changes Detected
All packages have stable APIs with no detected changes.
Report generated by Break Check
Last ran on 3c605a6.
@pkg-pr-new
pkg-pr-newBot
commented
Aug 20, 2026

Copy link


Copy Markdown

Open in StackBlitz
@clerk/astro
npm i https://pkg.pr.new/@clerk/astro@9511

@clerk/backend
npm i https://pkg.pr.new/@clerk/backend@9511

@clerk/chrome-extension
npm i https://pkg.pr.new/@clerk/chrome-extension@9511

@clerk/clerk-js
npm i https://pkg.pr.new/@clerk/clerk-js@9511

@clerk/electron
npm i https://pkg.pr.new/@clerk/electron@9511

@clerk/electron-passkeys
npm i https://pkg.pr.new/@clerk/electron-passkeys@9511

@clerk/eslint-plugin
npm i https://pkg.pr.new/@clerk/eslint-plugin@9511

@clerk/expo
npm i https://pkg.pr.new/@clerk/expo@9511

@clerk/expo-google-signin
npm i https://pkg.pr.new/@clerk/expo-google-signin@9511

@clerk/expo-passkeys
npm i https://pkg.pr.new/@clerk/expo-passkeys@9511

@clerk/express
npm i https://pkg.pr.new/@clerk/express@9511

@clerk/fastify
npm i https://pkg.pr.new/@clerk/fastify@9511

@clerk/hono
npm i https://pkg.pr.new/@clerk/hono@9511

@clerk/localizations
npm i https://pkg.pr.new/@clerk/localizations@9511

@clerk/nextjs
npm i https://pkg.pr.new/@clerk/nextjs@9511

@clerk/nuxt
npm i https://pkg.pr.new/@clerk/nuxt@9511

@clerk/react
npm i https://pkg.pr.new/@clerk/react@9511

@clerk/react-router
npm i https://pkg.pr.new/@clerk/react-router@9511

@clerk/shared
npm i https://pkg.pr.new/@clerk/shared@9511

@clerk/tanstack-react-start
npm i https://pkg.pr.new/@clerk/tanstack-react-start@9511

@clerk/testing
npm i https://pkg.pr.new/@clerk/testing@9511

@clerk/ui
npm i https://pkg.pr.new/@clerk/ui@9511

@clerk/upgrade
npm i https://pkg.pr.new/@clerk/upgrade@9511

@clerk/vue
npm i https://pkg.pr.new/@clerk/vue@9511

commit: 3c605a6
@coderabbitai
coderabbitaiBot
commented
Aug 20, 2026

Copy link


Copy Markdown

Contributor
Review Change Stack
No actionable comments were generated in the recent review. 🎉
ℹ️ Recent review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Organization UI (inherited)
Review profile: CHILL
Plan: Pro Plus
Run ID: 0914e179-eb3b-421e-916e-b3e2f481ad19
📥 Commits
Reviewing files that changed from the base of the PR and between 99082cb and 3c605a6.
📒 Files selected for processing (3)
  • .changeset/reject-jwt-template-accepts-token-any.md
  • packages/backend/src/tokens/__tests__/request.test.ts
  • packages/backend/src/tokens/request.ts
🔗 Linked repositories identified
CodeRabbit considers these linked repositories for cross-repo context during reviews:
  • clerk/clerk_go(manual)
  • clerk/dashboard(manual)
  • clerk/accounts(manual)
  • clerk/backoffice(manual)
  • clerk/clerk(manual)
  • clerk/clerk-docs(manual)
  • clerk/cloudflare-workers(manual)
  • clerk/clerk-ios(auto-detected)
  • clerk/cli(auto-detected)
  • clerk/clerk-android(auto-detected)
Included review availability: 8 reviews are currently available. Your included PR review attempts over the past 7 days set your current allowance at 10 reviews per hour.
📝 Walkthrough
Walkthrough
The fallback session-token path now rejects JWT-template tokens with non-session categories before session-token verification. The regression tests cover header and cookie carriers, acceptsToken: 'any', and mixed session/M2M configurations. A patch changeset documents the token-type-mismatch signed-out state.
Estimated code review effort: 2 (Simple) | ~10 minutes
Merge Risk:⚪ Minimal · up to 3c605
This change rejects JWT-template tokens on the affected session-token header paths and adds regression coverage; no actionable merge-blocking risk remains beyond normal checks and review.
Suggested reviewers:jacekradko
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check nameStatusExplanation
Title check✅ PassedThe title clearly identifies the backend fix for rejecting JWT-template tokens on the acceptsToken any or array header path.
Description check✅ PassedThe description accurately explains the bug, the fix, the token-type-mismatch behavior, and the added regression tests.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
Comment @coderabbitai help to get the list of available commands.
@dominic-clerk
dominic-clerk
merged commit eef0ceb
into
mainAug 31, 2026

52 checks passed

@dominic-clerk
dominic-clerk
deleted the

dominic/sec-340-accepts-token-any-jwt-template

branch
August 31, 2026 16:46
@clerk-cookieclerk-cookie
mentioned this pull request
Aug 31, 2026
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@wobsorianowobsorianowobsoriano approved these changes

Assignees


No one assigned


Labels

backend

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@dominic-clerk@wobsoriano

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
fix(backend): Reject JWT-template tokens on the acceptsToken any/array header path - #9511
Merged
dominic-clerk merged 1 commit into
mainfrom 
dominic/sec-340-accepts-token-any-jwt-template
Aug 31, 2026
Merged
fix(backend): Reject JWT-template tokens on the acceptsToken any/array header path#9511
dominic-clerk merged 1 commit into
mainfrom 
dominic/sec-340-accepts-token-any-jwt-template
Conversation
@dominic-clerk
@dominic-clerkdominic-clerk
commented
Aug 20, 2026

Copy link


Copy Markdown

Contributor
Description
Follow-up to #9469 (SEC-340). That PR rejects JWT-template tokens (cat=cl_B7d4PD222AAA) on the session-only header and cookie paths, but authenticateAnyRequestWithTokenInHeader — used when acceptsToken is 'any' or an array that includes 'session_token' — still fell through isMachineToken() → verifyToken() → signedIn, so a template token in the Authorization header was accepted as a session_token on those routes. Same consequence as the original report: the token has no sid and outlives revocation of the session that minted it, and it carries no sts, so a pending session presents as fully signed in.
This adds the same hasNonSessionJwtCategory check before the session-token branch of that path, returning signed-out / token-type-mismatch, and extends the SEC-340 regression tests to cover acceptsToken: 'any' and ['session_token', 'm2m_token'].
Checklist
  • pnpm test runs as expected.
  • pnpm build runs as expected.
  •  (If applicable) JSDoc comments have been added or updated for any package exports
  •  (If applicable) Documentation has been updated
Type of change
  •  🐛 Bug fix
  •  🌟 New feature
  •  🔨 Breaking change
  •  📖 Refactoring / dependency upgrade / documentation
  •  other:
🤖 Generated with Claude Code
@dominic-clerk@claude
fix(backend): Reject JWT-template tokens on the acceptsToken any/arra…
3c605a6
…y header path
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@vercel
vercelBot
commented
Aug 20, 2026•

edited

Loading

Copy link


Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.
ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxReadyReadyPreviewAug 20, 2026 1:47pm
swingsetReadyReadyPreviewAug 20, 2026 1:47pm
Request Review
@github-actions
github-actionsBot
commented
Aug 20, 2026

Copy link


Copy Markdown

Contributor
API Changes Report
Generated by Break Check on 2026-08-20T13:47:59.934Z
Summary
MetricCount
Packages analyzed19
Packages with changes0
🔴 Breaking changes0
🟡 Non-breaking changes0
🟢 Additions0
No API Changes Detected
All packages have stable APIs with no detected changes.
Report generated by Break Check
Last ran on 3c605a6.
@pkg-pr-new
pkg-pr-newBot
commented
Aug 20, 2026

Copy link


Copy Markdown

Open in StackBlitz
@clerk/astro
npm i https://pkg.pr.new/@clerk/astro@9511

@clerk/backend
npm i https://pkg.pr.new/@clerk/backend@9511

@clerk/chrome-extension
npm i https://pkg.pr.new/@clerk/chrome-extension@9511

@clerk/clerk-js
npm i https://pkg.pr.new/@clerk/clerk-js@9511

@clerk/electron
npm i https://pkg.pr.new/@clerk/electron@9511

@clerk/electron-passkeys
npm i https://pkg.pr.new/@clerk/electron-passkeys@9511

@clerk/eslint-plugin
npm i https://pkg.pr.new/@clerk/eslint-plugin@9511

@clerk/expo
npm i https://pkg.pr.new/@clerk/expo@9511

@clerk/expo-google-signin
npm i https://pkg.pr.new/@clerk/expo-google-signin@9511

@clerk/expo-passkeys
npm i https://pkg.pr.new/@clerk/expo-passkeys@9511

@clerk/express
npm i https://pkg.pr.new/@clerk/express@9511

@clerk/fastify
npm i https://pkg.pr.new/@clerk/fastify@9511

@clerk/hono
npm i https://pkg.pr.new/@clerk/hono@9511

@clerk/localizations
npm i https://pkg.pr.new/@clerk/localizations@9511

@clerk/nextjs
npm i https://pkg.pr.new/@clerk/nextjs@9511

@clerk/nuxt
npm i https://pkg.pr.new/@clerk/nuxt@9511

@clerk/react
npm i https://pkg.pr.new/@clerk/react@9511

@clerk/react-router
npm i https://pkg.pr.new/@clerk/react-router@9511

@clerk/shared
npm i https://pkg.pr.new/@clerk/shared@9511

@clerk/tanstack-react-start
npm i https://pkg.pr.new/@clerk/tanstack-react-start@9511

@clerk/testing
npm i https://pkg.pr.new/@clerk/testing@9511

@clerk/ui
npm i https://pkg.pr.new/@clerk/ui@9511

@clerk/upgrade
npm i https://pkg.pr.new/@clerk/upgrade@9511

@clerk/vue
npm i https://pkg.pr.new/@clerk/vue@9511

commit: 3c605a6
@coderabbitai
coderabbitaiBot
commented
Aug 20, 2026

Copy link


Copy Markdown

Contributor
Review Change Stack
No actionable comments were generated in the recent review. 🎉
ℹ️ Recent review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Organization UI (inherited)
Review profile: CHILL
Plan: Pro Plus
Run ID: 0914e179-eb3b-421e-916e-b3e2f481ad19
📥 Commits
Reviewing files that changed from the base of the PR and between 99082cb and 3c605a6.
📒 Files selected for processing (3)
  • .changeset/reject-jwt-template-accepts-token-any.md
  • packages/backend/src/tokens/__tests__/request.test.ts
  • packages/backend/src/tokens/request.ts
🔗 Linked repositories identified
CodeRabbit considers these linked repositories for cross-repo context during reviews:
  • clerk/clerk_go(manual)
  • clerk/dashboard(manual)
  • clerk/accounts(manual)
  • clerk/backoffice(manual)
  • clerk/clerk(manual)
  • clerk/clerk-docs(manual)
  • clerk/cloudflare-workers(manual)
  • clerk/clerk-ios(auto-detected)
  • clerk/cli(auto-detected)
  • clerk/clerk-android(auto-detected)
Included review availability: 8 reviews are currently available. Your included PR review attempts over the past 7 days set your current allowance at 10 reviews per hour.
📝 Walkthrough
Walkthrough
The fallback session-token path now rejects JWT-template tokens with non-session categories before session-token verification. The regression tests cover header and cookie carriers, acceptsToken: 'any', and mixed session/M2M configurations. A patch changeset documents the token-type-mismatch signed-out state.
Estimated code review effort: 2 (Simple) | ~10 minutes
Merge Risk:⚪ Minimal · up to 3c605
This change rejects JWT-template tokens on the affected session-token header paths and adds regression coverage; no actionable merge-blocking risk remains beyond normal checks and review.
Suggested reviewers:jacekradko
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check nameStatusExplanation
Title check✅ PassedThe title clearly identifies the backend fix for rejecting JWT-template tokens on the acceptsToken any or array header path.
Description check✅ PassedThe description accurately explains the bug, the fix, the token-type-mismatch behavior, and the added regression tests.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
Comment @coderabbitai help to get the list of available commands.
@dominic-clerk
dominic-clerk
merged commit eef0ceb
into
mainAug 31, 2026

52 checks passed

@dominic-clerk
dominic-clerk
deleted the

dominic/sec-340-accepts-token-any-jwt-template

branch
August 31, 2026 16:46
@clerk-cookieclerk-cookie
mentioned this pull request
Aug 31, 2026
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@wobsorianowobsorianowobsoriano approved these changes

Assignees


No one assigned


Labels

backend

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@dominic-clerk@wobsoriano

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
fix(backend): Reject JWT-template tokens on the acceptsToken any/array header path - #9511
Merged
dominic-clerk merged 1 commit into
mainfrom 
dominic/sec-340-accepts-token-any-jwt-template
Aug 31, 2026
Merged
fix(backend): Reject JWT-template tokens on the acceptsToken any/array header path#9511
dominic-clerk merged 1 commit into
mainfrom 
dominic/sec-340-accepts-token-any-jwt-template
Conversation
@dominic-clerk
@dominic-clerkdominic-clerk
commented
Aug 20, 2026

Copy link


Copy Markdown

Contributor
Description
Follow-up to #9469 (SEC-340). That PR rejects JWT-template tokens (cat=cl_B7d4PD222AAA) on the session-only header and cookie paths, but authenticateAnyRequestWithTokenInHeader — used when acceptsToken is 'any' or an array that includes 'session_token' — still fell through isMachineToken() → verifyToken() → signedIn, so a template token in the Authorization header was accepted as a session_token on those routes. Same consequence as the original report: the token has no sid and outlives revocation of the session that minted it, and it carries no sts, so a pending session presents as fully signed in.
This adds the same hasNonSessionJwtCategory check before the session-token branch of that path, returning signed-out / token-type-mismatch, and extends the SEC-340 regression tests to cover acceptsToken: 'any' and ['session_token', 'm2m_token'].
Checklist
  • pnpm test runs as expected.
  • pnpm build runs as expected.
  •  (If applicable) JSDoc comments have been added or updated for any package exports
  •  (If applicable) Documentation has been updated
Type of change
  •  🐛 Bug fix
  •  🌟 New feature
  •  🔨 Breaking change
  •  📖 Refactoring / dependency upgrade / documentation
  •  other:
🤖 Generated with Claude Code
@dominic-clerk@claude
fix(backend): Reject JWT-template tokens on the acceptsToken any/arra…
3c605a6
…y header path
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@vercel
vercelBot
commented
Aug 20, 2026•

edited

Loading

Copy link


Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.
ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxReadyReadyPreviewAug 20, 2026 1:47pm
swingsetReadyReadyPreviewAug 20, 2026 1:47pm
Request Review
@github-actions
github-actionsBot
commented
Aug 20, 2026

Copy link


Copy Markdown

Contributor
API Changes Report
Generated by Break Check on 2026-08-20T13:47:59.934Z
Summary
MetricCount
Packages analyzed19
Packages with changes0
🔴 Breaking changes0
🟡 Non-breaking changes0
🟢 Additions0
No API Changes Detected
All packages have stable APIs with no detected changes.
Report generated by Break Check
Last ran on 3c605a6.
@pkg-pr-new
pkg-pr-newBot
commented
Aug 20, 2026

Copy link


Copy Markdown

Open in StackBlitz
@clerk/astro
npm i https://pkg.pr.new/@clerk/astro@9511

@clerk/backend
npm i https://pkg.pr.new/@clerk/backend@9511

@clerk/chrome-extension
npm i https://pkg.pr.new/@clerk/chrome-extension@9511

@clerk/clerk-js
npm i https://pkg.pr.new/@clerk/clerk-js@9511

@clerk/electron
npm i https://pkg.pr.new/@clerk/electron@9511

@clerk/electron-passkeys
npm i https://pkg.pr.new/@clerk/electron-passkeys@9511

@clerk/eslint-plugin
npm i https://pkg.pr.new/@clerk/eslint-plugin@9511

@clerk/expo
npm i https://pkg.pr.new/@clerk/expo@9511

@clerk/expo-google-signin
npm i https://pkg.pr.new/@clerk/expo-google-signin@9511

@clerk/expo-passkeys
npm i https://pkg.pr.new/@clerk/expo-passkeys@9511

@clerk/express
npm i https://pkg.pr.new/@clerk/express@9511

@clerk/fastify
npm i https://pkg.pr.new/@clerk/fastify@9511

@clerk/hono
npm i https://pkg.pr.new/@clerk/hono@9511

@clerk/localizations
npm i https://pkg.pr.new/@clerk/localizations@9511

@clerk/nextjs
npm i https://pkg.pr.new/@clerk/nextjs@9511

@clerk/nuxt
npm i https://pkg.pr.new/@clerk/nuxt@9511

@clerk/react
npm i https://pkg.pr.new/@clerk/react@9511

@clerk/react-router
npm i https://pkg.pr.new/@clerk/react-router@9511

@clerk/shared
npm i https://pkg.pr.new/@clerk/shared@9511

@clerk/tanstack-react-start
npm i https://pkg.pr.new/@clerk/tanstack-react-start@9511

@clerk/testing
npm i https://pkg.pr.new/@clerk/testing@9511

@clerk/ui
npm i https://pkg.pr.new/@clerk/ui@9511

@clerk/upgrade
npm i https://pkg.pr.new/@clerk/upgrade@9511

@clerk/vue
npm i https://pkg.pr.new/@clerk/vue@9511

commit: 3c605a6
@coderabbitai
coderabbitaiBot
commented
Aug 20, 2026

Copy link


Copy Markdown

Contributor
Review Change Stack
No actionable comments were generated in the recent review. 🎉
ℹ️ Recent review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Organization UI (inherited)
Review profile: CHILL
Plan: Pro Plus
Run ID: 0914e179-eb3b-421e-916e-b3e2f481ad19
📥 Commits
Reviewing files that changed from the base of the PR and between 99082cb and 3c605a6.
📒 Files selected for processing (3)
  • .changeset/reject-jwt-template-accepts-token-any.md
  • packages/backend/src/tokens/__tests__/request.test.ts
  • packages/backend/src/tokens/request.ts
🔗 Linked repositories identified
CodeRabbit considers these linked repositories for cross-repo context during reviews:
  • clerk/clerk_go(manual)
  • clerk/dashboard(manual)
  • clerk/accounts(manual)
  • clerk/backoffice(manual)
  • clerk/clerk(manual)
  • clerk/clerk-docs(manual)
  • clerk/cloudflare-workers(manual)
  • clerk/clerk-ios(auto-detected)
  • clerk/cli(auto-detected)
  • clerk/clerk-android(auto-detected)
Included review availability: 8 reviews are currently available. Your included PR review attempts over the past 7 days set your current allowance at 10 reviews per hour.
📝 Walkthrough
Walkthrough
The fallback session-token path now rejects JWT-template tokens with non-session categories before session-token verification. The regression tests cover header and cookie carriers, acceptsToken: 'any', and mixed session/M2M configurations. A patch changeset documents the token-type-mismatch signed-out state.
Estimated code review effort: 2 (Simple) | ~10 minutes
Merge Risk:⚪ Minimal · up to 3c605
This change rejects JWT-template tokens on the affected session-token header paths and adds regression coverage; no actionable merge-blocking risk remains beyond normal checks and review.
Suggested reviewers:jacekradko
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check nameStatusExplanation
Title check✅ PassedThe title clearly identifies the backend fix for rejecting JWT-template tokens on the acceptsToken any or array header path.
Description check✅ PassedThe description accurately explains the bug, the fix, the token-type-mismatch behavior, and the added regression tests.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
Comment @coderabbitai help to get the list of available commands.
@dominic-clerk
dominic-clerk
merged commit eef0ceb
into
mainAug 31, 2026

52 checks passed

@dominic-clerk
dominic-clerk
deleted the

dominic/sec-340-accepts-token-any-jwt-template

branch
August 31, 2026 16:46
@clerk-cookieclerk-cookie
mentioned this pull request
Aug 31, 2026
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@wobsorianowobsorianowobsoriano approved these changes

Assignees


No one assigned


Labels

backend

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@dominic-clerk@wobsoriano

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Universal Dark Mode - works on any site
(function() {
var enabled = true;
function applyDarkMode() {
if (!enabled) return;
// Create style element if it doesn't exist
var style = document.getElementById('universal-dark-mode-style');
if (!style) {
style = document.createElement('style');
style.id = 'universal-dark-mode-style';
document.head.appendChild(style);
}
// Dark mode CSS - inverts colors but preserves images/video
style.textContent = '
/* Invert everything except media */
html {
filter: invert(1) hue-rotate(180deg) !important;
background: #1a1a2e !important;
}
/* Restore images, videos, iframes, canvas */
img, video, iframe, canvas, svg, picture, [style*="background-image"] {
filter: invert(1) hue-rotate(180deg) !important;
}
/* Preserve specific elements that should not be inverted */
.no-dark-mode, .no-dark-mode *,
[data-theme="light"], [data-theme="light"],
.ace_editor, .ace_editor *,
.CodeMirror, .CodeMirror *,
.monaco-editor, .monaco-editor *,
.markdown-body pre, .markdown-body pre *,
.highlight, .highlight *,
pre code, pre code * {
filter: none !important;
}
/* Fix common UI elements */
.modal, .popup, .dropdown-menu, .tooltip, .popover {
filter: invert(1) hue-rotate(180deg) !important;
background: #2d2d44 !important;
border-color: #444 !important;
}
/* Scrollbars */
::-webkit-scrollbar { background: #1a1a2e !important; }
::-webkit-scrollbar-thumb { background: #444 !important; }
::-webkit-scrollbar-thumb:hover { background: #555 !important; }
/* Selection */
::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
';
}
function removeDarkMode() {
var style = document.getElementById('universal-dark-mode-style');
if (style) style.remove();
}
// Toggle with Alt+Shift+D
document.addEventListener('keydown', function(e) {
if (e.altKey && e.shiftKey && e.key === 'D') {
e.preventDefault();
enabled = !enabled;
if (enabled) {
applyDarkMode();
console.log('[Universal Dark Mode] Enabled');
} else {
removeDarkMode();
console.log('[Universal Dark Mode] Disabled');
}
}
});
// Apply on load
applyDarkMode();
// Re-apply on dynamic content
var observer = new MutationObserver(function(mutations) {
if (enabled && !document.getElementById('universal-dark-mode-style')) {
applyDarkMode();
}
});
observer.observe(document.head, { childList: true });
console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');
})();
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
fix(backend): Reject JWT-template tokens on the acceptsToken any/array header path - #9511
Merged
dominic-clerk merged 1 commit into
mainfrom 
dominic/sec-340-accepts-token-any-jwt-template
Aug 31, 2026
Merged
fix(backend): Reject JWT-template tokens on the acceptsToken any/array header path#9511
dominic-clerk merged 1 commit into
mainfrom 
dominic/sec-340-accepts-token-any-jwt-template
Conversation
@dominic-clerk
@dominic-clerkdominic-clerk
commented
Aug 20, 2026

Copy link


Copy Markdown

Contributor
Description
Follow-up to #9469 (SEC-340). That PR rejects JWT-template tokens (cat=cl_B7d4PD222AAA) on the session-only header and cookie paths, but authenticateAnyRequestWithTokenInHeader — used when acceptsToken is 'any' or an array that includes 'session_token' — still fell through isMachineToken() → verifyToken() → signedIn, so a template token in the Authorization header was accepted as a session_token on those routes. Same consequence as the original report: the token has no sid and outlives revocation of the session that minted it, and it carries no sts, so a pending session presents as fully signed in.
This adds the same hasNonSessionJwtCategory check before the session-token branch of that path, returning signed-out / token-type-mismatch, and extends the SEC-340 regression tests to cover acceptsToken: 'any' and ['session_token', 'm2m_token'].
Checklist
  • pnpm test runs as expected.
  • pnpm build runs as expected.
  •  (If applicable) JSDoc comments have been added or updated for any package exports
  •  (If applicable) Documentation has been updated
Type of change
  •  🐛 Bug fix
  •  🌟 New feature
  •  🔨 Breaking change
  •  📖 Refactoring / dependency upgrade / documentation
  •  other:
🤖 Generated with Claude Code
@dominic-clerk@claude
fix(backend): Reject JWT-template tokens on the acceptsToken any/arra…
3c605a6
…y header path
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@vercel
vercelBot
commented
Aug 20, 2026•

edited

Loading

Copy link


Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.
ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxReadyReadyPreviewAug 20, 2026 1:47pm
swingsetReadyReadyPreviewAug 20, 2026 1:47pm
Request Review
@github-actions
github-actionsBot
commented
Aug 20, 2026

Copy link


Copy Markdown

Contributor
API Changes Report
Generated by Break Check on 2026-08-20T13:47:59.934Z
Summary
MetricCount
Packages analyzed19
Packages with changes0
🔴 Breaking changes0
🟡 Non-breaking changes0
🟢 Additions0
No API Changes Detected
All packages have stable APIs with no detected changes.
Report generated by Break Check
Last ran on 3c605a6.
@pkg-pr-new
pkg-pr-newBot
commented
Aug 20, 2026

Copy link


Copy Markdown

Open in StackBlitz
@clerk/astro
npm i https://pkg.pr.new/@clerk/astro@9511

@clerk/backend
npm i https://pkg.pr.new/@clerk/backend@9511

@clerk/chrome-extension
npm i https://pkg.pr.new/@clerk/chrome-extension@9511

@clerk/clerk-js
npm i https://pkg.pr.new/@clerk/clerk-js@9511

@clerk/electron
npm i https://pkg.pr.new/@clerk/electron@9511

@clerk/electron-passkeys
npm i https://pkg.pr.new/@clerk/electron-passkeys@9511

@clerk/eslint-plugin
npm i https://pkg.pr.new/@clerk/eslint-plugin@9511

@clerk/expo
npm i https://pkg.pr.new/@clerk/expo@9511

@clerk/expo-google-signin
npm i https://pkg.pr.new/@clerk/expo-google-signin@9511

@clerk/expo-passkeys
npm i https://pkg.pr.new/@clerk/expo-passkeys@9511

@clerk/express
npm i https://pkg.pr.new/@clerk/express@9511

@clerk/fastify
npm i https://pkg.pr.new/@clerk/fastify@9511

@clerk/hono
npm i https://pkg.pr.new/@clerk/hono@9511

@clerk/localizations
npm i https://pkg.pr.new/@clerk/localizations@9511

@clerk/nextjs
npm i https://pkg.pr.new/@clerk/nextjs@9511

@clerk/nuxt
npm i https://pkg.pr.new/@clerk/nuxt@9511

@clerk/react
npm i https://pkg.pr.new/@clerk/react@9511

@clerk/react-router
npm i https://pkg.pr.new/@clerk/react-router@9511

@clerk/shared
npm i https://pkg.pr.new/@clerk/shared@9511

@clerk/tanstack-react-start
npm i https://pkg.pr.new/@clerk/tanstack-react-start@9511

@clerk/testing
npm i https://pkg.pr.new/@clerk/testing@9511

@clerk/ui
npm i https://pkg.pr.new/@clerk/ui@9511

@clerk/upgrade
npm i https://pkg.pr.new/@clerk/upgrade@9511

@clerk/vue
npm i https://pkg.pr.new/@clerk/vue@9511

commit: 3c605a6
@coderabbitai
coderabbitaiBot
commented
Aug 20, 2026

Copy link


Copy Markdown

Contributor
Review Change Stack
No actionable comments were generated in the recent review. 🎉
ℹ️ Recent review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Organization UI (inherited)
Review profile: CHILL
Plan: Pro Plus
Run ID: 0914e179-eb3b-421e-916e-b3e2f481ad19
📥 Commits
Reviewing files that changed from the base of the PR and between 99082cb and 3c605a6.
📒 Files selected for processing (3)
  • .changeset/reject-jwt-template-accepts-token-any.md
  • packages/backend/src/tokens/__tests__/request.test.ts
  • packages/backend/src/tokens/request.ts
🔗 Linked repositories identified
CodeRabbit considers these linked repositories for cross-repo context during reviews:
  • clerk/clerk_go(manual)
  • clerk/dashboard(manual)
  • clerk/accounts(manual)
  • clerk/backoffice(manual)
  • clerk/clerk(manual)
  • clerk/clerk-docs(manual)
  • clerk/cloudflare-workers(manual)
  • clerk/clerk-ios(auto-detected)
  • clerk/cli(auto-detected)
  • clerk/clerk-android(auto-detected)
Included review availability: 8 reviews are currently available. Your included PR review attempts over the past 7 days set your current allowance at 10 reviews per hour.
📝 Walkthrough
Walkthrough
The fallback session-token path now rejects JWT-template tokens with non-session categories before session-token verification. The regression tests cover header and cookie carriers, acceptsToken: 'any', and mixed session/M2M configurations. A patch changeset documents the token-type-mismatch signed-out state.
Estimated code review effort: 2 (Simple) | ~10 minutes
Merge Risk:⚪ Minimal · up to 3c605
This change rejects JWT-template tokens on the affected session-token header paths and adds regression coverage; no actionable merge-blocking risk remains beyond normal checks and review.
Suggested reviewers:jacekradko
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check nameStatusExplanation
Title check✅ PassedThe title clearly identifies the backend fix for rejecting JWT-template tokens on the acceptsToken any or array header path.
Description check✅ PassedThe description accurately explains the bug, the fix, the token-type-mismatch behavior, and the added regression tests.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
Comment @coderabbitai help to get the list of available commands.
@dominic-clerk
dominic-clerk
merged commit eef0ceb
into
mainAug 31, 2026

52 checks passed

@dominic-clerk
dominic-clerk
deleted the

dominic/sec-340-accepts-token-any-jwt-template

branch
August 31, 2026 16:46
@clerk-cookieclerk-cookie
mentioned this pull request
Aug 31, 2026
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@wobsorianowobsorianowobsoriano approved these changes

Assignees


No one assigned


Labels

backend

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@dominic-clerk@wobsoriano