Skip to content

docs(shared,ui): address the review comments from #9449 - #9522

Merged
zourzouvillys merged 1 commit into
mainfrom
theo/address-9449-review-comments
Aug 21, 2026
Merged

docs(shared,ui): address the review comments from #9449#9522
zourzouvillys merged 1 commit into
mainfrom
theo/address-9449-review-comments

Conversation

@zourzouvillys

@zourzouvillyszourzouvillys commented Aug 21, 2026

Copy link
Copy Markdown
Contributor

Follow-up to #9449, which merged before @dstaley's review suggestions were applied. This applies them, exactly as scoped:

  • .changeset/signup-enterprise-sso-redirect-urls.md — replaced with the one-line summary he suggested (the changeset had not been released yet, so the shorter text is what will ship).
  • packages/shared/src/internal/clerk-js/completeSignUpFlow.ts — dropped the comment above the redirect-url guard.
  • packages/ui/src/common/EmailLinkVerify.tsx — dropped the ssoCallbackUrl prop comment.
  • packages/ui/src/components/SignUp/useCompleteSignUpFlow.ts — dropped the hook's doc block.

Comment-only; no behaviour change, and no test or type surface moves with it.

@zourzouvillys@claude
docs(shared,ui): trim the review-flagged comments from#9449
75b96fe
Applies the review suggestions dstaley left on
#9449, which merged before they
were addressed: drop the three comments he marked and shorten the
changeset. Comment-only — no behaviour change.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_013a2R58ncemGjYAjLHKUpzb
@changeset-bot

changeset-botBot commented Aug 21, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 75b96fe

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes changesets to release 23 packages
NameType
@clerk/sharedPatch
@clerk/uiPatch
@clerk/astroPatch
@clerk/backendPatch
@clerk/chrome-extensionPatch
@clerk/clerk-jsPatch
@clerk/electronPatch
@clerk/expo-passkeysPatch
@clerk/expoPatch
@clerk/expressPatch
@clerk/fastifyPatch
@clerk/headlessPatch
@clerk/honoPatch
@clerk/localizationsPatch
@clerk/mswPatch
@clerk/nextjsPatch
@clerk/nuxtPatch
@clerk/react-routerPatch
@clerk/reactPatch
@clerk/tanstack-react-startPatch
@clerk/testingPatch
@clerk/vuePatch
@clerk/swingsetPatch

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel

vercelBot commented Aug 21, 2026•
edited
Loading

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxReadyReadyPreviewAug 21, 2026 3:27am
swingsetReadyReadyPreviewAug 21, 2026 3:27am

Request Review

@coderabbitai

coderabbitaiBot commented Aug 21, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: 3efc55ba-27ac-4efb-ab95-7ee7234db64b

📥 Commits

Reviewing files that changed from the base of the PR and between 17b865b and 75b96fe.

📒 Files selected for processing (4)
  • .changeset/signup-enterprise-sso-redirect-urls.md
  • packages/shared/src/internal/clerk-js/completeSignUpFlow.ts
  • packages/ui/src/common/EmailLinkVerify.tsx
  • packages/ui/src/components/SignUp/useCompleteSignUpFlow.ts
🔗 Linked repositories identified

CodeRabbit considers these linked repositories for cross-repo context during reviews:

  • clerk/clerk_go(manual)
  • clerk/dashboard(manual)
  • clerk/accounts(manual)
  • clerk/backoffice(manual)
  • clerk/clerk(manual)
  • clerk/clerk-docs(manual)
  • clerk/cloudflare-workers(manual)
  • clerk/clerk-ios(auto-detected)
  • clerk/cli(auto-detected)
  • clerk/clerk-android(auto-detected)
💤 Files with no reviewable changes (3)
  • packages/shared/src/internal/clerk-js/completeSignUpFlow.ts
  • packages/ui/src/common/EmailLinkVerify.tsx
  • packages/ui/src/components/SignUp/useCompleteSignUpFlow.ts

Included review availability: 8 reviews are currently available. Your included PR review attempts over the past 7 days set your current allowance at 10 reviews per hour.

📝 Walkthrough

Walkthrough

The changeset now states that enterprise SSO sign-ups correctly forward redirect URLs. Explanatory comments were removed from the sign-up flow validation and UI hook declarations. Runtime behavior and public entity declarations remain unchanged.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk:⚪ Minimal · up to 75b96

This PR only updates documentation and comments without changing product behavior, so no actionable merge-blocking risk remains after normal checks and review.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check nameStatusExplanation
Title check✅ PassedThe title clearly identifies this as a documentation follow-up applying review comments across the shared and UI packages.
Description check✅ PassedThe description accurately explains the review follow-up, the affected files, and the absence of behavior or type-surface changes.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.

Comment @coderabbitai help to get the list of available commands.

@pkg-pr-new

pkg-pr-newBot commented Aug 21, 2026

Copy link
Copy Markdown

Open in StackBlitz

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@9522

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@9522

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@9522

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@9522

@clerk/electron

npm i https://pkg.pr.new/@clerk/electron@9522

@clerk/electron-passkeys

npm i https://pkg.pr.new/@clerk/electron-passkeys@9522

@clerk/eslint-plugin

npm i https://pkg.pr.new/@clerk/eslint-plugin@9522

@clerk/expo

npm i https://pkg.pr.new/@clerk/expo@9522

@clerk/expo-google-signin

npm i https://pkg.pr.new/@clerk/expo-google-signin@9522

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@9522

@clerk/express

npm i https://pkg.pr.new/@clerk/express@9522

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@9522

@clerk/hono

npm i https://pkg.pr.new/@clerk/hono@9522

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@9522

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@9522

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@9522

@clerk/react

npm i https://pkg.pr.new/@clerk/react@9522

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@9522

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@9522

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@9522

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@9522

@clerk/ui

npm i https://pkg.pr.new/@clerk/ui@9522

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@9522

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@9522

commit: 75b96fe

@github-actions

github-actionsBot commented Aug 21, 2026

Copy link
Copy Markdown
Contributor

API Changes Report

Generated by Break Check on 2026-08-21T03:28:13.492Z

Summary

MetricCount
Packages analyzed19
Packages with changes0
🔴 Breaking changes0
🟡 Non-breaking changes0
🟢 Additions0

No API Changes Detected

All packages have stable APIs with no detected changes.

Report generated by Break Check

Last ran on 75b96fe.

@zourzouvillys
zourzouvillys enabled auto-merge (squash) August 21, 2026 03:35
@zourzouvillys
zourzouvillys merged commit e21ae9a into mainAug 21, 2026
52 checks passed
@zourzouvillys
zourzouvillys deleted the theo/address-9449-review-comments branch August 21, 2026 14:44
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dstaleydstaleydstaley approved these changes

Assignees

No one assigned

Labels

ui

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@zourzouvillys@dstaley
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
docs(shared,ui): address the review comments from #9449 by zourzouvillys · Pull Request #9522 · clerk/javascript · GitHub
Skip to content
docs(shared,ui): address the review comments from #9449 - #9522
Merged
zourzouvillys merged 1 commit into
mainfrom 
theo/address-9449-review-comments
Aug 21, 2026
Merged
docs(shared,ui): address the review comments from #9449#9522
zourzouvillys merged 1 commit into
mainfrom 
theo/address-9449-review-comments
Conversation
@zourzouvillys
@zourzouvillyszourzouvillys
commented
Aug 21, 2026

Copy link


Copy Markdown

Contributor
Follow-up to #9449, which merged before @dstaley's review suggestions were applied. This applies them, exactly as scoped:
  • .changeset/signup-enterprise-sso-redirect-urls.md — replaced with the one-line summary he suggested (the changeset had not been released yet, so the shorter text is what will ship).
  • packages/shared/src/internal/clerk-js/completeSignUpFlow.ts — dropped the comment above the redirect-url guard.
  • packages/ui/src/common/EmailLinkVerify.tsx — dropped the ssoCallbackUrl prop comment.
  • packages/ui/src/components/SignUp/useCompleteSignUpFlow.ts — dropped the hook's doc block.
Comment-only; no behaviour change, and no test or type surface moves with it.
@zourzouvillys@claude
docs(shared,ui): trim the review-flagged comments from#9449
75b96fe
Applies the review suggestions dstaley left on
#9449, which merged before they
were addressed: drop the three comments he marked and shorten the
changeset. Comment-only — no behaviour change.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_013a2R58ncemGjYAjLHKUpzb
@changeset-bot
changeset-botBot
commented
Aug 21, 2026

Copy link


Copy Markdown

⚠️ No Changeset found
Latest commit: 75b96fe
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes changesets to release 23 packages
NameType
@clerk/sharedPatch
@clerk/uiPatch
@clerk/astroPatch
@clerk/backendPatch
@clerk/chrome-extensionPatch
@clerk/clerk-jsPatch
@clerk/electronPatch
@clerk/expo-passkeysPatch
@clerk/expoPatch
@clerk/expressPatch
@clerk/fastifyPatch
@clerk/headlessPatch
@clerk/honoPatch
@clerk/localizationsPatch
@clerk/mswPatch
@clerk/nextjsPatch
@clerk/nuxtPatch
@clerk/react-routerPatch
@clerk/reactPatch
@clerk/tanstack-react-startPatch
@clerk/testingPatch
@clerk/vuePatch
@clerk/swingsetPatch
Click here to learn what changesets are, and how to add one.
Click here if you're a maintainer who wants to add a changeset to this PR
@vercel
vercelBot
commented
Aug 21, 2026•

edited

Loading

Copy link


Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.
ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxReadyReadyPreviewAug 21, 2026 3:27am
swingsetReadyReadyPreviewAug 21, 2026 3:27am
Request Review
@coderabbitai
coderabbitaiBot
commented
Aug 21, 2026

Copy link


Copy Markdown

Contributor
Review Change Stack
No actionable comments were generated in the recent review. 🎉
ℹ️ Recent review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Organization UI (inherited)
Review profile: CHILL
Plan: Pro Plus
Run ID: 3efc55ba-27ac-4efb-ab95-7ee7234db64b
📥 Commits
Reviewing files that changed from the base of the PR and between 17b865b and 75b96fe.
📒 Files selected for processing (4)
  • .changeset/signup-enterprise-sso-redirect-urls.md
  • packages/shared/src/internal/clerk-js/completeSignUpFlow.ts
  • packages/ui/src/common/EmailLinkVerify.tsx
  • packages/ui/src/components/SignUp/useCompleteSignUpFlow.ts
🔗 Linked repositories identified
CodeRabbit considers these linked repositories for cross-repo context during reviews:
  • clerk/clerk_go(manual)
  • clerk/dashboard(manual)
  • clerk/accounts(manual)
  • clerk/backoffice(manual)
  • clerk/clerk(manual)
  • clerk/clerk-docs(manual)
  • clerk/cloudflare-workers(manual)
  • clerk/clerk-ios(auto-detected)
  • clerk/cli(auto-detected)
  • clerk/clerk-android(auto-detected)
💤 Files with no reviewable changes (3)
  • packages/shared/src/internal/clerk-js/completeSignUpFlow.ts
  • packages/ui/src/common/EmailLinkVerify.tsx
  • packages/ui/src/components/SignUp/useCompleteSignUpFlow.ts
Included review availability: 8 reviews are currently available. Your included PR review attempts over the past 7 days set your current allowance at 10 reviews per hour.
📝 Walkthrough
Walkthrough
The changeset now states that enterprise SSO sign-ups correctly forward redirect URLs. Explanatory comments were removed from the sign-up flow validation and UI hook declarations. Runtime behavior and public entity declarations remain unchanged.
Estimated code review effort: 1 (Trivial) | ~2 minutes
Merge Risk:⚪ Minimal · up to 75b96
This PR only updates documentation and comments without changing product behavior, so no actionable merge-blocking risk remains after normal checks and review.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check nameStatusExplanation
Title check✅ PassedThe title clearly identifies this as a documentation follow-up applying review comments across the shared and UI packages.
Description check✅ PassedThe description accurately explains the review follow-up, the affected files, and the absence of behavior or type-surface changes.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
Comment @coderabbitai help to get the list of available commands.
@pkg-pr-new
pkg-pr-newBot
commented
Aug 21, 2026

Copy link


Copy Markdown

Open in StackBlitz
@clerk/astro
npm i https://pkg.pr.new/@clerk/astro@9522

@clerk/backend
npm i https://pkg.pr.new/@clerk/backend@9522

@clerk/chrome-extension
npm i https://pkg.pr.new/@clerk/chrome-extension@9522

@clerk/clerk-js
npm i https://pkg.pr.new/@clerk/clerk-js@9522

@clerk/electron
npm i https://pkg.pr.new/@clerk/electron@9522

@clerk/electron-passkeys
npm i https://pkg.pr.new/@clerk/electron-passkeys@9522

@clerk/eslint-plugin
npm i https://pkg.pr.new/@clerk/eslint-plugin@9522

@clerk/expo
npm i https://pkg.pr.new/@clerk/expo@9522

@clerk/expo-google-signin
npm i https://pkg.pr.new/@clerk/expo-google-signin@9522

@clerk/expo-passkeys
npm i https://pkg.pr.new/@clerk/expo-passkeys@9522

@clerk/express
npm i https://pkg.pr.new/@clerk/express@9522

@clerk/fastify
npm i https://pkg.pr.new/@clerk/fastify@9522

@clerk/hono
npm i https://pkg.pr.new/@clerk/hono@9522

@clerk/localizations
npm i https://pkg.pr.new/@clerk/localizations@9522

@clerk/nextjs
npm i https://pkg.pr.new/@clerk/nextjs@9522

@clerk/nuxt
npm i https://pkg.pr.new/@clerk/nuxt@9522

@clerk/react
npm i https://pkg.pr.new/@clerk/react@9522

@clerk/react-router
npm i https://pkg.pr.new/@clerk/react-router@9522

@clerk/shared
npm i https://pkg.pr.new/@clerk/shared@9522

@clerk/tanstack-react-start
npm i https://pkg.pr.new/@clerk/tanstack-react-start@9522

@clerk/testing
npm i https://pkg.pr.new/@clerk/testing@9522

@clerk/ui
npm i https://pkg.pr.new/@clerk/ui@9522

@clerk/upgrade
npm i https://pkg.pr.new/@clerk/upgrade@9522

@clerk/vue
npm i https://pkg.pr.new/@clerk/vue@9522

commit: 75b96fe
@github-actions
github-actionsBot
commented
Aug 21, 2026

Copy link


Copy Markdown

Contributor
API Changes Report
Generated by Break Check on 2026-08-21T03:28:13.492Z
Summary
MetricCount
Packages analyzed19
Packages with changes0
🔴 Breaking changes0
🟡 Non-breaking changes0
🟢 Additions0
No API Changes Detected
All packages have stable APIs with no detected changes.
Report generated by Break Check
Last ran on 75b96fe.
@zourzouvillys
zourzouvillys
enabled auto-merge (squash)
August 21, 2026 03:35
@zourzouvillys
zourzouvillys
merged commit e21ae9a
into
mainAug 21, 2026

52 checks passed

@zourzouvillys
zourzouvillys
deleted the

theo/address-9449-review-comments

branch
August 21, 2026 14:44
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@dstaleydstaleydstaley approved these changes

Assignees


No one assigned


Labels

ui

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@zourzouvillys@dstaley

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
docs(shared,ui): address the review comments from #9449 by zourzouvillys · Pull Request #9522 · clerk/javascript · GitHub
Skip to content
docs(shared,ui): address the review comments from #9449 - #9522
Merged
zourzouvillys merged 1 commit into
mainfrom 
theo/address-9449-review-comments
Aug 21, 2026
Merged
docs(shared,ui): address the review comments from #9449#9522
zourzouvillys merged 1 commit into
mainfrom 
theo/address-9449-review-comments
Conversation
@zourzouvillys
@zourzouvillyszourzouvillys
commented
Aug 21, 2026

Copy link


Copy Markdown

Contributor
Follow-up to #9449, which merged before @dstaley's review suggestions were applied. This applies them, exactly as scoped:
  • .changeset/signup-enterprise-sso-redirect-urls.md — replaced with the one-line summary he suggested (the changeset had not been released yet, so the shorter text is what will ship).
  • packages/shared/src/internal/clerk-js/completeSignUpFlow.ts — dropped the comment above the redirect-url guard.
  • packages/ui/src/common/EmailLinkVerify.tsx — dropped the ssoCallbackUrl prop comment.
  • packages/ui/src/components/SignUp/useCompleteSignUpFlow.ts — dropped the hook's doc block.
Comment-only; no behaviour change, and no test or type surface moves with it.
@zourzouvillys@claude
docs(shared,ui): trim the review-flagged comments from#9449
75b96fe
Applies the review suggestions dstaley left on
#9449, which merged before they
were addressed: drop the three comments he marked and shorten the
changeset. Comment-only — no behaviour change.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_013a2R58ncemGjYAjLHKUpzb
@changeset-bot
changeset-botBot
commented
Aug 21, 2026

Copy link


Copy Markdown

⚠️ No Changeset found
Latest commit: 75b96fe
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes changesets to release 23 packages
NameType
@clerk/sharedPatch
@clerk/uiPatch
@clerk/astroPatch
@clerk/backendPatch
@clerk/chrome-extensionPatch
@clerk/clerk-jsPatch
@clerk/electronPatch
@clerk/expo-passkeysPatch
@clerk/expoPatch
@clerk/expressPatch
@clerk/fastifyPatch
@clerk/headlessPatch
@clerk/honoPatch
@clerk/localizationsPatch
@clerk/mswPatch
@clerk/nextjsPatch
@clerk/nuxtPatch
@clerk/react-routerPatch
@clerk/reactPatch
@clerk/tanstack-react-startPatch
@clerk/testingPatch
@clerk/vuePatch
@clerk/swingsetPatch
Click here to learn what changesets are, and how to add one.
Click here if you're a maintainer who wants to add a changeset to this PR
@vercel
vercelBot
commented
Aug 21, 2026•

edited

Loading

Copy link


Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.
ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxReadyReadyPreviewAug 21, 2026 3:27am
swingsetReadyReadyPreviewAug 21, 2026 3:27am
Request Review
@coderabbitai
coderabbitaiBot
commented
Aug 21, 2026

Copy link


Copy Markdown

Contributor
Review Change Stack
No actionable comments were generated in the recent review. 🎉
ℹ️ Recent review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Organization UI (inherited)
Review profile: CHILL
Plan: Pro Plus
Run ID: 3efc55ba-27ac-4efb-ab95-7ee7234db64b
📥 Commits
Reviewing files that changed from the base of the PR and between 17b865b and 75b96fe.
📒 Files selected for processing (4)
  • .changeset/signup-enterprise-sso-redirect-urls.md
  • packages/shared/src/internal/clerk-js/completeSignUpFlow.ts
  • packages/ui/src/common/EmailLinkVerify.tsx
  • packages/ui/src/components/SignUp/useCompleteSignUpFlow.ts
🔗 Linked repositories identified
CodeRabbit considers these linked repositories for cross-repo context during reviews:
  • clerk/clerk_go(manual)
  • clerk/dashboard(manual)
  • clerk/accounts(manual)
  • clerk/backoffice(manual)
  • clerk/clerk(manual)
  • clerk/clerk-docs(manual)
  • clerk/cloudflare-workers(manual)
  • clerk/clerk-ios(auto-detected)
  • clerk/cli(auto-detected)
  • clerk/clerk-android(auto-detected)
💤 Files with no reviewable changes (3)
  • packages/shared/src/internal/clerk-js/completeSignUpFlow.ts
  • packages/ui/src/common/EmailLinkVerify.tsx
  • packages/ui/src/components/SignUp/useCompleteSignUpFlow.ts
Included review availability: 8 reviews are currently available. Your included PR review attempts over the past 7 days set your current allowance at 10 reviews per hour.
📝 Walkthrough
Walkthrough
The changeset now states that enterprise SSO sign-ups correctly forward redirect URLs. Explanatory comments were removed from the sign-up flow validation and UI hook declarations. Runtime behavior and public entity declarations remain unchanged.
Estimated code review effort: 1 (Trivial) | ~2 minutes
Merge Risk:⚪ Minimal · up to 75b96
This PR only updates documentation and comments without changing product behavior, so no actionable merge-blocking risk remains after normal checks and review.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check nameStatusExplanation
Title check✅ PassedThe title clearly identifies this as a documentation follow-up applying review comments across the shared and UI packages.
Description check✅ PassedThe description accurately explains the review follow-up, the affected files, and the absence of behavior or type-surface changes.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
Comment @coderabbitai help to get the list of available commands.
@pkg-pr-new
pkg-pr-newBot
commented
Aug 21, 2026

Copy link


Copy Markdown

Open in StackBlitz
@clerk/astro
npm i https://pkg.pr.new/@clerk/astro@9522

@clerk/backend
npm i https://pkg.pr.new/@clerk/backend@9522

@clerk/chrome-extension
npm i https://pkg.pr.new/@clerk/chrome-extension@9522

@clerk/clerk-js
npm i https://pkg.pr.new/@clerk/clerk-js@9522

@clerk/electron
npm i https://pkg.pr.new/@clerk/electron@9522

@clerk/electron-passkeys
npm i https://pkg.pr.new/@clerk/electron-passkeys@9522

@clerk/eslint-plugin
npm i https://pkg.pr.new/@clerk/eslint-plugin@9522

@clerk/expo
npm i https://pkg.pr.new/@clerk/expo@9522

@clerk/expo-google-signin
npm i https://pkg.pr.new/@clerk/expo-google-signin@9522

@clerk/expo-passkeys
npm i https://pkg.pr.new/@clerk/expo-passkeys@9522

@clerk/express
npm i https://pkg.pr.new/@clerk/express@9522

@clerk/fastify
npm i https://pkg.pr.new/@clerk/fastify@9522

@clerk/hono
npm i https://pkg.pr.new/@clerk/hono@9522

@clerk/localizations
npm i https://pkg.pr.new/@clerk/localizations@9522

@clerk/nextjs
npm i https://pkg.pr.new/@clerk/nextjs@9522

@clerk/nuxt
npm i https://pkg.pr.new/@clerk/nuxt@9522

@clerk/react
npm i https://pkg.pr.new/@clerk/react@9522

@clerk/react-router
npm i https://pkg.pr.new/@clerk/react-router@9522

@clerk/shared
npm i https://pkg.pr.new/@clerk/shared@9522

@clerk/tanstack-react-start
npm i https://pkg.pr.new/@clerk/tanstack-react-start@9522

@clerk/testing
npm i https://pkg.pr.new/@clerk/testing@9522

@clerk/ui
npm i https://pkg.pr.new/@clerk/ui@9522

@clerk/upgrade
npm i https://pkg.pr.new/@clerk/upgrade@9522

@clerk/vue
npm i https://pkg.pr.new/@clerk/vue@9522

commit: 75b96fe
@github-actions
github-actionsBot
commented
Aug 21, 2026

Copy link


Copy Markdown

Contributor
API Changes Report
Generated by Break Check on 2026-08-21T03:28:13.492Z
Summary
MetricCount
Packages analyzed19
Packages with changes0
🔴 Breaking changes0
🟡 Non-breaking changes0
🟢 Additions0
No API Changes Detected
All packages have stable APIs with no detected changes.
Report generated by Break Check
Last ran on 75b96fe.
@zourzouvillys
zourzouvillys
enabled auto-merge (squash)
August 21, 2026 03:35
@zourzouvillys
zourzouvillys
merged commit e21ae9a
into
mainAug 21, 2026

52 checks passed

@zourzouvillys
zourzouvillys
deleted the

theo/address-9449-review-comments

branch
August 21, 2026 14:44
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@dstaleydstaleydstaley approved these changes

Assignees


No one assigned


Labels

ui

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@zourzouvillys@dstaley

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
docs(shared,ui): address the review comments from #9449 by zourzouvillys · Pull Request #9522 · clerk/javascript · GitHub
Skip to content
docs(shared,ui): address the review comments from #9449 - #9522
Merged
zourzouvillys merged 1 commit into
mainfrom 
theo/address-9449-review-comments
Aug 21, 2026
Merged
docs(shared,ui): address the review comments from #9449#9522
zourzouvillys merged 1 commit into
mainfrom 
theo/address-9449-review-comments
Conversation
@zourzouvillys
@zourzouvillyszourzouvillys
commented
Aug 21, 2026

Copy link


Copy Markdown

Contributor
Follow-up to #9449, which merged before @dstaley's review suggestions were applied. This applies them, exactly as scoped:
  • .changeset/signup-enterprise-sso-redirect-urls.md — replaced with the one-line summary he suggested (the changeset had not been released yet, so the shorter text is what will ship).
  • packages/shared/src/internal/clerk-js/completeSignUpFlow.ts — dropped the comment above the redirect-url guard.
  • packages/ui/src/common/EmailLinkVerify.tsx — dropped the ssoCallbackUrl prop comment.
  • packages/ui/src/components/SignUp/useCompleteSignUpFlow.ts — dropped the hook's doc block.
Comment-only; no behaviour change, and no test or type surface moves with it.
@zourzouvillys@claude
docs(shared,ui): trim the review-flagged comments from#9449
75b96fe
Applies the review suggestions dstaley left on
#9449, which merged before they
were addressed: drop the three comments he marked and shorten the
changeset. Comment-only — no behaviour change.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_013a2R58ncemGjYAjLHKUpzb
@changeset-bot
changeset-botBot
commented
Aug 21, 2026

Copy link


Copy Markdown

⚠️ No Changeset found
Latest commit: 75b96fe
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes changesets to release 23 packages
NameType
@clerk/sharedPatch
@clerk/uiPatch
@clerk/astroPatch
@clerk/backendPatch
@clerk/chrome-extensionPatch
@clerk/clerk-jsPatch
@clerk/electronPatch
@clerk/expo-passkeysPatch
@clerk/expoPatch
@clerk/expressPatch
@clerk/fastifyPatch
@clerk/headlessPatch
@clerk/honoPatch
@clerk/localizationsPatch
@clerk/mswPatch
@clerk/nextjsPatch
@clerk/nuxtPatch
@clerk/react-routerPatch
@clerk/reactPatch
@clerk/tanstack-react-startPatch
@clerk/testingPatch
@clerk/vuePatch
@clerk/swingsetPatch
Click here to learn what changesets are, and how to add one.
Click here if you're a maintainer who wants to add a changeset to this PR
@vercel
vercelBot
commented
Aug 21, 2026•

edited

Loading

Copy link


Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.
ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxReadyReadyPreviewAug 21, 2026 3:27am
swingsetReadyReadyPreviewAug 21, 2026 3:27am
Request Review
@coderabbitai
coderabbitaiBot
commented
Aug 21, 2026

Copy link


Copy Markdown

Contributor
Review Change Stack
No actionable comments were generated in the recent review. 🎉
ℹ️ Recent review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Organization UI (inherited)
Review profile: CHILL
Plan: Pro Plus
Run ID: 3efc55ba-27ac-4efb-ab95-7ee7234db64b
📥 Commits
Reviewing files that changed from the base of the PR and between 17b865b and 75b96fe.
📒 Files selected for processing (4)
  • .changeset/signup-enterprise-sso-redirect-urls.md
  • packages/shared/src/internal/clerk-js/completeSignUpFlow.ts
  • packages/ui/src/common/EmailLinkVerify.tsx
  • packages/ui/src/components/SignUp/useCompleteSignUpFlow.ts
🔗 Linked repositories identified
CodeRabbit considers these linked repositories for cross-repo context during reviews:
  • clerk/clerk_go(manual)
  • clerk/dashboard(manual)
  • clerk/accounts(manual)
  • clerk/backoffice(manual)
  • clerk/clerk(manual)
  • clerk/clerk-docs(manual)
  • clerk/cloudflare-workers(manual)
  • clerk/clerk-ios(auto-detected)
  • clerk/cli(auto-detected)
  • clerk/clerk-android(auto-detected)
💤 Files with no reviewable changes (3)
  • packages/shared/src/internal/clerk-js/completeSignUpFlow.ts
  • packages/ui/src/common/EmailLinkVerify.tsx
  • packages/ui/src/components/SignUp/useCompleteSignUpFlow.ts
Included review availability: 8 reviews are currently available. Your included PR review attempts over the past 7 days set your current allowance at 10 reviews per hour.
📝 Walkthrough
Walkthrough
The changeset now states that enterprise SSO sign-ups correctly forward redirect URLs. Explanatory comments were removed from the sign-up flow validation and UI hook declarations. Runtime behavior and public entity declarations remain unchanged.
Estimated code review effort: 1 (Trivial) | ~2 minutes
Merge Risk:⚪ Minimal · up to 75b96
This PR only updates documentation and comments without changing product behavior, so no actionable merge-blocking risk remains after normal checks and review.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check nameStatusExplanation
Title check✅ PassedThe title clearly identifies this as a documentation follow-up applying review comments across the shared and UI packages.
Description check✅ PassedThe description accurately explains the review follow-up, the affected files, and the absence of behavior or type-surface changes.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
Comment @coderabbitai help to get the list of available commands.
@pkg-pr-new
pkg-pr-newBot
commented
Aug 21, 2026

Copy link


Copy Markdown

Open in StackBlitz
@clerk/astro
npm i https://pkg.pr.new/@clerk/astro@9522

@clerk/backend
npm i https://pkg.pr.new/@clerk/backend@9522

@clerk/chrome-extension
npm i https://pkg.pr.new/@clerk/chrome-extension@9522

@clerk/clerk-js
npm i https://pkg.pr.new/@clerk/clerk-js@9522

@clerk/electron
npm i https://pkg.pr.new/@clerk/electron@9522

@clerk/electron-passkeys
npm i https://pkg.pr.new/@clerk/electron-passkeys@9522

@clerk/eslint-plugin
npm i https://pkg.pr.new/@clerk/eslint-plugin@9522

@clerk/expo
npm i https://pkg.pr.new/@clerk/expo@9522

@clerk/expo-google-signin
npm i https://pkg.pr.new/@clerk/expo-google-signin@9522

@clerk/expo-passkeys
npm i https://pkg.pr.new/@clerk/expo-passkeys@9522

@clerk/express
npm i https://pkg.pr.new/@clerk/express@9522

@clerk/fastify
npm i https://pkg.pr.new/@clerk/fastify@9522

@clerk/hono
npm i https://pkg.pr.new/@clerk/hono@9522

@clerk/localizations
npm i https://pkg.pr.new/@clerk/localizations@9522

@clerk/nextjs
npm i https://pkg.pr.new/@clerk/nextjs@9522

@clerk/nuxt
npm i https://pkg.pr.new/@clerk/nuxt@9522

@clerk/react
npm i https://pkg.pr.new/@clerk/react@9522

@clerk/react-router
npm i https://pkg.pr.new/@clerk/react-router@9522

@clerk/shared
npm i https://pkg.pr.new/@clerk/shared@9522

@clerk/tanstack-react-start
npm i https://pkg.pr.new/@clerk/tanstack-react-start@9522

@clerk/testing
npm i https://pkg.pr.new/@clerk/testing@9522

@clerk/ui
npm i https://pkg.pr.new/@clerk/ui@9522

@clerk/upgrade
npm i https://pkg.pr.new/@clerk/upgrade@9522

@clerk/vue
npm i https://pkg.pr.new/@clerk/vue@9522

commit: 75b96fe
@github-actions
github-actionsBot
commented
Aug 21, 2026

Copy link


Copy Markdown

Contributor
API Changes Report
Generated by Break Check on 2026-08-21T03:28:13.492Z
Summary
MetricCount
Packages analyzed19
Packages with changes0
🔴 Breaking changes0
🟡 Non-breaking changes0
🟢 Additions0
No API Changes Detected
All packages have stable APIs with no detected changes.
Report generated by Break Check
Last ran on 75b96fe.
@zourzouvillys
zourzouvillys
enabled auto-merge (squash)
August 21, 2026 03:35
@zourzouvillys
zourzouvillys
merged commit e21ae9a
into
mainAug 21, 2026

52 checks passed

@zourzouvillys
zourzouvillys
deleted the

theo/address-9449-review-comments

branch
August 21, 2026 14:44
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@dstaleydstaleydstaley approved these changes

Assignees


No one assigned


Labels

ui

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@zourzouvillys@dstaley

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '
docs(shared,ui): address the review comments from #9449 by zourzouvillys · Pull Request #9522 · clerk/javascript · GitHub
Skip to content
docs(shared,ui): address the review comments from #9449 - #9522
Merged
zourzouvillys merged 1 commit into
mainfrom 
theo/address-9449-review-comments
Aug 21, 2026
Merged
docs(shared,ui): address the review comments from #9449#9522
zourzouvillys merged 1 commit into
mainfrom 
theo/address-9449-review-comments
Conversation
@zourzouvillys
@zourzouvillyszourzouvillys
commented
Aug 21, 2026

Copy link


Copy Markdown

Contributor
Follow-up to #9449, which merged before @dstaley's review suggestions were applied. This applies them, exactly as scoped:
  • .changeset/signup-enterprise-sso-redirect-urls.md — replaced with the one-line summary he suggested (the changeset had not been released yet, so the shorter text is what will ship).
  • packages/shared/src/internal/clerk-js/completeSignUpFlow.ts — dropped the comment above the redirect-url guard.
  • packages/ui/src/common/EmailLinkVerify.tsx — dropped the ssoCallbackUrl prop comment.
  • packages/ui/src/components/SignUp/useCompleteSignUpFlow.ts — dropped the hook's doc block.
Comment-only; no behaviour change, and no test or type surface moves with it.
@zourzouvillys@claude
docs(shared,ui): trim the review-flagged comments from#9449
75b96fe
Applies the review suggestions dstaley left on
#9449, which merged before they
were addressed: drop the three comments he marked and shorten the
changeset. Comment-only — no behaviour change.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_013a2R58ncemGjYAjLHKUpzb
@changeset-bot
changeset-botBot
commented
Aug 21, 2026

Copy link


Copy Markdown

⚠️ No Changeset found
Latest commit: 75b96fe
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes changesets to release 23 packages
NameType
@clerk/sharedPatch
@clerk/uiPatch
@clerk/astroPatch
@clerk/backendPatch
@clerk/chrome-extensionPatch
@clerk/clerk-jsPatch
@clerk/electronPatch
@clerk/expo-passkeysPatch
@clerk/expoPatch
@clerk/expressPatch
@clerk/fastifyPatch
@clerk/headlessPatch
@clerk/honoPatch
@clerk/localizationsPatch
@clerk/mswPatch
@clerk/nextjsPatch
@clerk/nuxtPatch
@clerk/react-routerPatch
@clerk/reactPatch
@clerk/tanstack-react-startPatch
@clerk/testingPatch
@clerk/vuePatch
@clerk/swingsetPatch
Click here to learn what changesets are, and how to add one.
Click here if you're a maintainer who wants to add a changeset to this PR
@vercel
vercelBot
commented
Aug 21, 2026•

edited

Loading

Copy link


Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.
ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxReadyReadyPreviewAug 21, 2026 3:27am
swingsetReadyReadyPreviewAug 21, 2026 3:27am
Request Review
@coderabbitai
coderabbitaiBot
commented
Aug 21, 2026

Copy link


Copy Markdown

Contributor
Review Change Stack
No actionable comments were generated in the recent review. 🎉
ℹ️ Recent review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Organization UI (inherited)
Review profile: CHILL
Plan: Pro Plus
Run ID: 3efc55ba-27ac-4efb-ab95-7ee7234db64b
📥 Commits
Reviewing files that changed from the base of the PR and between 17b865b and 75b96fe.
📒 Files selected for processing (4)
  • .changeset/signup-enterprise-sso-redirect-urls.md
  • packages/shared/src/internal/clerk-js/completeSignUpFlow.ts
  • packages/ui/src/common/EmailLinkVerify.tsx
  • packages/ui/src/components/SignUp/useCompleteSignUpFlow.ts
🔗 Linked repositories identified
CodeRabbit considers these linked repositories for cross-repo context during reviews:
  • clerk/clerk_go(manual)
  • clerk/dashboard(manual)
  • clerk/accounts(manual)
  • clerk/backoffice(manual)
  • clerk/clerk(manual)
  • clerk/clerk-docs(manual)
  • clerk/cloudflare-workers(manual)
  • clerk/clerk-ios(auto-detected)
  • clerk/cli(auto-detected)
  • clerk/clerk-android(auto-detected)
💤 Files with no reviewable changes (3)
  • packages/shared/src/internal/clerk-js/completeSignUpFlow.ts
  • packages/ui/src/common/EmailLinkVerify.tsx
  • packages/ui/src/components/SignUp/useCompleteSignUpFlow.ts
Included review availability: 8 reviews are currently available. Your included PR review attempts over the past 7 days set your current allowance at 10 reviews per hour.
📝 Walkthrough
Walkthrough
The changeset now states that enterprise SSO sign-ups correctly forward redirect URLs. Explanatory comments were removed from the sign-up flow validation and UI hook declarations. Runtime behavior and public entity declarations remain unchanged.
Estimated code review effort: 1 (Trivial) | ~2 minutes
Merge Risk:⚪ Minimal · up to 75b96
This PR only updates documentation and comments without changing product behavior, so no actionable merge-blocking risk remains after normal checks and review.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check nameStatusExplanation
Title check✅ PassedThe title clearly identifies this as a documentation follow-up applying review comments across the shared and UI packages.
Description check✅ PassedThe description accurately explains the review follow-up, the affected files, and the absence of behavior or type-surface changes.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
Comment @coderabbitai help to get the list of available commands.
@pkg-pr-new
pkg-pr-newBot
commented
Aug 21, 2026

Copy link


Copy Markdown

Open in StackBlitz
@clerk/astro
npm i https://pkg.pr.new/@clerk/astro@9522

@clerk/backend
npm i https://pkg.pr.new/@clerk/backend@9522

@clerk/chrome-extension
npm i https://pkg.pr.new/@clerk/chrome-extension@9522

@clerk/clerk-js
npm i https://pkg.pr.new/@clerk/clerk-js@9522

@clerk/electron
npm i https://pkg.pr.new/@clerk/electron@9522

@clerk/electron-passkeys
npm i https://pkg.pr.new/@clerk/electron-passkeys@9522

@clerk/eslint-plugin
npm i https://pkg.pr.new/@clerk/eslint-plugin@9522

@clerk/expo
npm i https://pkg.pr.new/@clerk/expo@9522

@clerk/expo-google-signin
npm i https://pkg.pr.new/@clerk/expo-google-signin@9522

@clerk/expo-passkeys
npm i https://pkg.pr.new/@clerk/expo-passkeys@9522

@clerk/express
npm i https://pkg.pr.new/@clerk/express@9522

@clerk/fastify
npm i https://pkg.pr.new/@clerk/fastify@9522

@clerk/hono
npm i https://pkg.pr.new/@clerk/hono@9522

@clerk/localizations
npm i https://pkg.pr.new/@clerk/localizations@9522

@clerk/nextjs
npm i https://pkg.pr.new/@clerk/nextjs@9522

@clerk/nuxt
npm i https://pkg.pr.new/@clerk/nuxt@9522

@clerk/react
npm i https://pkg.pr.new/@clerk/react@9522

@clerk/react-router
npm i https://pkg.pr.new/@clerk/react-router@9522

@clerk/shared
npm i https://pkg.pr.new/@clerk/shared@9522

@clerk/tanstack-react-start
npm i https://pkg.pr.new/@clerk/tanstack-react-start@9522

@clerk/testing
npm i https://pkg.pr.new/@clerk/testing@9522

@clerk/ui
npm i https://pkg.pr.new/@clerk/ui@9522

@clerk/upgrade
npm i https://pkg.pr.new/@clerk/upgrade@9522

@clerk/vue
npm i https://pkg.pr.new/@clerk/vue@9522

commit: 75b96fe
@github-actions
github-actionsBot
commented
Aug 21, 2026

Copy link


Copy Markdown

Contributor
API Changes Report
Generated by Break Check on 2026-08-21T03:28:13.492Z
Summary
MetricCount
Packages analyzed19
Packages with changes0
🔴 Breaking changes0
🟡 Non-breaking changes0
🟢 Additions0
No API Changes Detected
All packages have stable APIs with no detected changes.
Report generated by Break Check
Last ran on 75b96fe.
@zourzouvillys
zourzouvillys
enabled auto-merge (squash)
August 21, 2026 03:35
@zourzouvillys
zourzouvillys
merged commit e21ae9a
into
mainAug 21, 2026

52 checks passed

@zourzouvillys
zourzouvillys
deleted the

theo/address-9449-review-comments

branch
August 21, 2026 14:44
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@dstaleydstaleydstaley approved these changes

Assignees


No one assigned


Labels

ui

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@zourzouvillys@dstaley

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
docs(shared,ui): address the review comments from #9449 by zourzouvillys · Pull Request #9522 · clerk/javascript · GitHub
Skip to content
docs(shared,ui): address the review comments from #9449 - #9522
Merged
zourzouvillys merged 1 commit into
mainfrom 
theo/address-9449-review-comments
Aug 21, 2026
Merged
docs(shared,ui): address the review comments from #9449#9522
zourzouvillys merged 1 commit into
mainfrom 
theo/address-9449-review-comments
Conversation
@zourzouvillys
@zourzouvillyszourzouvillys
commented
Aug 21, 2026

Copy link


Copy Markdown

Contributor
Follow-up to #9449, which merged before @dstaley's review suggestions were applied. This applies them, exactly as scoped:
  • .changeset/signup-enterprise-sso-redirect-urls.md — replaced with the one-line summary he suggested (the changeset had not been released yet, so the shorter text is what will ship).
  • packages/shared/src/internal/clerk-js/completeSignUpFlow.ts — dropped the comment above the redirect-url guard.
  • packages/ui/src/common/EmailLinkVerify.tsx — dropped the ssoCallbackUrl prop comment.
  • packages/ui/src/components/SignUp/useCompleteSignUpFlow.ts — dropped the hook's doc block.
Comment-only; no behaviour change, and no test or type surface moves with it.
@zourzouvillys@claude
docs(shared,ui): trim the review-flagged comments from#9449
75b96fe
Applies the review suggestions dstaley left on
#9449, which merged before they
were addressed: drop the three comments he marked and shorten the
changeset. Comment-only — no behaviour change.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_013a2R58ncemGjYAjLHKUpzb
@changeset-bot
changeset-botBot
commented
Aug 21, 2026

Copy link


Copy Markdown

⚠️ No Changeset found
Latest commit: 75b96fe
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes changesets to release 23 packages
NameType
@clerk/sharedPatch
@clerk/uiPatch
@clerk/astroPatch
@clerk/backendPatch
@clerk/chrome-extensionPatch
@clerk/clerk-jsPatch
@clerk/electronPatch
@clerk/expo-passkeysPatch
@clerk/expoPatch
@clerk/expressPatch
@clerk/fastifyPatch
@clerk/headlessPatch
@clerk/honoPatch
@clerk/localizationsPatch
@clerk/mswPatch
@clerk/nextjsPatch
@clerk/nuxtPatch
@clerk/react-routerPatch
@clerk/reactPatch
@clerk/tanstack-react-startPatch
@clerk/testingPatch
@clerk/vuePatch
@clerk/swingsetPatch
Click here to learn what changesets are, and how to add one.
Click here if you're a maintainer who wants to add a changeset to this PR
@vercel
vercelBot
commented
Aug 21, 2026•

edited

Loading

Copy link


Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.
ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxReadyReadyPreviewAug 21, 2026 3:27am
swingsetReadyReadyPreviewAug 21, 2026 3:27am
Request Review
@coderabbitai
coderabbitaiBot
commented
Aug 21, 2026

Copy link


Copy Markdown

Contributor
Review Change Stack
No actionable comments were generated in the recent review. 🎉
ℹ️ Recent review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Organization UI (inherited)
Review profile: CHILL
Plan: Pro Plus
Run ID: 3efc55ba-27ac-4efb-ab95-7ee7234db64b
📥 Commits
Reviewing files that changed from the base of the PR and between 17b865b and 75b96fe.
📒 Files selected for processing (4)
  • .changeset/signup-enterprise-sso-redirect-urls.md
  • packages/shared/src/internal/clerk-js/completeSignUpFlow.ts
  • packages/ui/src/common/EmailLinkVerify.tsx
  • packages/ui/src/components/SignUp/useCompleteSignUpFlow.ts
🔗 Linked repositories identified
CodeRabbit considers these linked repositories for cross-repo context during reviews:
  • clerk/clerk_go(manual)
  • clerk/dashboard(manual)
  • clerk/accounts(manual)
  • clerk/backoffice(manual)
  • clerk/clerk(manual)
  • clerk/clerk-docs(manual)
  • clerk/cloudflare-workers(manual)
  • clerk/clerk-ios(auto-detected)
  • clerk/cli(auto-detected)
  • clerk/clerk-android(auto-detected)
💤 Files with no reviewable changes (3)
  • packages/shared/src/internal/clerk-js/completeSignUpFlow.ts
  • packages/ui/src/common/EmailLinkVerify.tsx
  • packages/ui/src/components/SignUp/useCompleteSignUpFlow.ts
Included review availability: 8 reviews are currently available. Your included PR review attempts over the past 7 days set your current allowance at 10 reviews per hour.
📝 Walkthrough
Walkthrough
The changeset now states that enterprise SSO sign-ups correctly forward redirect URLs. Explanatory comments were removed from the sign-up flow validation and UI hook declarations. Runtime behavior and public entity declarations remain unchanged.
Estimated code review effort: 1 (Trivial) | ~2 minutes
Merge Risk:⚪ Minimal · up to 75b96
This PR only updates documentation and comments without changing product behavior, so no actionable merge-blocking risk remains after normal checks and review.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check nameStatusExplanation
Title check✅ PassedThe title clearly identifies this as a documentation follow-up applying review comments across the shared and UI packages.
Description check✅ PassedThe description accurately explains the review follow-up, the affected files, and the absence of behavior or type-surface changes.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
Comment @coderabbitai help to get the list of available commands.
@pkg-pr-new
pkg-pr-newBot
commented
Aug 21, 2026

Copy link


Copy Markdown

Open in StackBlitz
@clerk/astro
npm i https://pkg.pr.new/@clerk/astro@9522

@clerk/backend
npm i https://pkg.pr.new/@clerk/backend@9522

@clerk/chrome-extension
npm i https://pkg.pr.new/@clerk/chrome-extension@9522

@clerk/clerk-js
npm i https://pkg.pr.new/@clerk/clerk-js@9522

@clerk/electron
npm i https://pkg.pr.new/@clerk/electron@9522

@clerk/electron-passkeys
npm i https://pkg.pr.new/@clerk/electron-passkeys@9522

@clerk/eslint-plugin
npm i https://pkg.pr.new/@clerk/eslint-plugin@9522

@clerk/expo
npm i https://pkg.pr.new/@clerk/expo@9522

@clerk/expo-google-signin
npm i https://pkg.pr.new/@clerk/expo-google-signin@9522

@clerk/expo-passkeys
npm i https://pkg.pr.new/@clerk/expo-passkeys@9522

@clerk/express
npm i https://pkg.pr.new/@clerk/express@9522

@clerk/fastify
npm i https://pkg.pr.new/@clerk/fastify@9522

@clerk/hono
npm i https://pkg.pr.new/@clerk/hono@9522

@clerk/localizations
npm i https://pkg.pr.new/@clerk/localizations@9522

@clerk/nextjs
npm i https://pkg.pr.new/@clerk/nextjs@9522

@clerk/nuxt
npm i https://pkg.pr.new/@clerk/nuxt@9522

@clerk/react
npm i https://pkg.pr.new/@clerk/react@9522

@clerk/react-router
npm i https://pkg.pr.new/@clerk/react-router@9522

@clerk/shared
npm i https://pkg.pr.new/@clerk/shared@9522

@clerk/tanstack-react-start
npm i https://pkg.pr.new/@clerk/tanstack-react-start@9522

@clerk/testing
npm i https://pkg.pr.new/@clerk/testing@9522

@clerk/ui
npm i https://pkg.pr.new/@clerk/ui@9522

@clerk/upgrade
npm i https://pkg.pr.new/@clerk/upgrade@9522

@clerk/vue
npm i https://pkg.pr.new/@clerk/vue@9522

commit: 75b96fe
@github-actions
github-actionsBot
commented
Aug 21, 2026

Copy link


Copy Markdown

Contributor
API Changes Report
Generated by Break Check on 2026-08-21T03:28:13.492Z
Summary
MetricCount
Packages analyzed19
Packages with changes0
🔴 Breaking changes0
🟡 Non-breaking changes0
🟢 Additions0
No API Changes Detected
All packages have stable APIs with no detected changes.
Report generated by Break Check
Last ran on 75b96fe.
@zourzouvillys
zourzouvillys
enabled auto-merge (squash)
August 21, 2026 03:35
@zourzouvillys
zourzouvillys
merged commit e21ae9a
into
mainAug 21, 2026

52 checks passed

@zourzouvillys
zourzouvillys
deleted the

theo/address-9449-review-comments

branch
August 21, 2026 14:44
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@dstaleydstaleydstaley approved these changes

Assignees


No one assigned


Labels

ui

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@zourzouvillys@dstaley

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
docs(shared,ui): address the review comments from #9449 by zourzouvillys · Pull Request #9522 · clerk/javascript · GitHub
Skip to content
docs(shared,ui): address the review comments from #9449 - #9522
Merged
zourzouvillys merged 1 commit into
mainfrom 
theo/address-9449-review-comments
Aug 21, 2026
Merged
docs(shared,ui): address the review comments from #9449#9522
zourzouvillys merged 1 commit into
mainfrom 
theo/address-9449-review-comments
Conversation
@zourzouvillys
@zourzouvillyszourzouvillys
commented
Aug 21, 2026

Copy link


Copy Markdown

Contributor
Follow-up to #9449, which merged before @dstaley's review suggestions were applied. This applies them, exactly as scoped:
  • .changeset/signup-enterprise-sso-redirect-urls.md — replaced with the one-line summary he suggested (the changeset had not been released yet, so the shorter text is what will ship).
  • packages/shared/src/internal/clerk-js/completeSignUpFlow.ts — dropped the comment above the redirect-url guard.
  • packages/ui/src/common/EmailLinkVerify.tsx — dropped the ssoCallbackUrl prop comment.
  • packages/ui/src/components/SignUp/useCompleteSignUpFlow.ts — dropped the hook's doc block.
Comment-only; no behaviour change, and no test or type surface moves with it.
@zourzouvillys@claude
docs(shared,ui): trim the review-flagged comments from#9449
75b96fe
Applies the review suggestions dstaley left on
#9449, which merged before they
were addressed: drop the three comments he marked and shorten the
changeset. Comment-only — no behaviour change.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_013a2R58ncemGjYAjLHKUpzb
@changeset-bot
changeset-botBot
commented
Aug 21, 2026

Copy link


Copy Markdown

⚠️ No Changeset found
Latest commit: 75b96fe
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes changesets to release 23 packages
NameType
@clerk/sharedPatch
@clerk/uiPatch
@clerk/astroPatch
@clerk/backendPatch
@clerk/chrome-extensionPatch
@clerk/clerk-jsPatch
@clerk/electronPatch
@clerk/expo-passkeysPatch
@clerk/expoPatch
@clerk/expressPatch
@clerk/fastifyPatch
@clerk/headlessPatch
@clerk/honoPatch
@clerk/localizationsPatch
@clerk/mswPatch
@clerk/nextjsPatch
@clerk/nuxtPatch
@clerk/react-routerPatch
@clerk/reactPatch
@clerk/tanstack-react-startPatch
@clerk/testingPatch
@clerk/vuePatch
@clerk/swingsetPatch
Click here to learn what changesets are, and how to add one.
Click here if you're a maintainer who wants to add a changeset to this PR
@vercel
vercelBot
commented
Aug 21, 2026•

edited

Loading

Copy link


Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.
ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxReadyReadyPreviewAug 21, 2026 3:27am
swingsetReadyReadyPreviewAug 21, 2026 3:27am
Request Review
@coderabbitai
coderabbitaiBot
commented
Aug 21, 2026

Copy link


Copy Markdown

Contributor
Review Change Stack
No actionable comments were generated in the recent review. 🎉
ℹ️ Recent review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Organization UI (inherited)
Review profile: CHILL
Plan: Pro Plus
Run ID: 3efc55ba-27ac-4efb-ab95-7ee7234db64b
📥 Commits
Reviewing files that changed from the base of the PR and between 17b865b and 75b96fe.
📒 Files selected for processing (4)
  • .changeset/signup-enterprise-sso-redirect-urls.md
  • packages/shared/src/internal/clerk-js/completeSignUpFlow.ts
  • packages/ui/src/common/EmailLinkVerify.tsx
  • packages/ui/src/components/SignUp/useCompleteSignUpFlow.ts
🔗 Linked repositories identified
CodeRabbit considers these linked repositories for cross-repo context during reviews:
  • clerk/clerk_go(manual)
  • clerk/dashboard(manual)
  • clerk/accounts(manual)
  • clerk/backoffice(manual)
  • clerk/clerk(manual)
  • clerk/clerk-docs(manual)
  • clerk/cloudflare-workers(manual)
  • clerk/clerk-ios(auto-detected)
  • clerk/cli(auto-detected)
  • clerk/clerk-android(auto-detected)
💤 Files with no reviewable changes (3)
  • packages/shared/src/internal/clerk-js/completeSignUpFlow.ts
  • packages/ui/src/common/EmailLinkVerify.tsx
  • packages/ui/src/components/SignUp/useCompleteSignUpFlow.ts
Included review availability: 8 reviews are currently available. Your included PR review attempts over the past 7 days set your current allowance at 10 reviews per hour.
📝 Walkthrough
Walkthrough
The changeset now states that enterprise SSO sign-ups correctly forward redirect URLs. Explanatory comments were removed from the sign-up flow validation and UI hook declarations. Runtime behavior and public entity declarations remain unchanged.
Estimated code review effort: 1 (Trivial) | ~2 minutes
Merge Risk:⚪ Minimal · up to 75b96
This PR only updates documentation and comments without changing product behavior, so no actionable merge-blocking risk remains after normal checks and review.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check nameStatusExplanation
Title check✅ PassedThe title clearly identifies this as a documentation follow-up applying review comments across the shared and UI packages.
Description check✅ PassedThe description accurately explains the review follow-up, the affected files, and the absence of behavior or type-surface changes.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
Comment @coderabbitai help to get the list of available commands.
@pkg-pr-new
pkg-pr-newBot
commented
Aug 21, 2026

Copy link


Copy Markdown

Open in StackBlitz
@clerk/astro
npm i https://pkg.pr.new/@clerk/astro@9522

@clerk/backend
npm i https://pkg.pr.new/@clerk/backend@9522

@clerk/chrome-extension
npm i https://pkg.pr.new/@clerk/chrome-extension@9522

@clerk/clerk-js
npm i https://pkg.pr.new/@clerk/clerk-js@9522

@clerk/electron
npm i https://pkg.pr.new/@clerk/electron@9522

@clerk/electron-passkeys
npm i https://pkg.pr.new/@clerk/electron-passkeys@9522

@clerk/eslint-plugin
npm i https://pkg.pr.new/@clerk/eslint-plugin@9522

@clerk/expo
npm i https://pkg.pr.new/@clerk/expo@9522

@clerk/expo-google-signin
npm i https://pkg.pr.new/@clerk/expo-google-signin@9522

@clerk/expo-passkeys
npm i https://pkg.pr.new/@clerk/expo-passkeys@9522

@clerk/express
npm i https://pkg.pr.new/@clerk/express@9522

@clerk/fastify
npm i https://pkg.pr.new/@clerk/fastify@9522

@clerk/hono
npm i https://pkg.pr.new/@clerk/hono@9522

@clerk/localizations
npm i https://pkg.pr.new/@clerk/localizations@9522

@clerk/nextjs
npm i https://pkg.pr.new/@clerk/nextjs@9522

@clerk/nuxt
npm i https://pkg.pr.new/@clerk/nuxt@9522

@clerk/react
npm i https://pkg.pr.new/@clerk/react@9522

@clerk/react-router
npm i https://pkg.pr.new/@clerk/react-router@9522

@clerk/shared
npm i https://pkg.pr.new/@clerk/shared@9522

@clerk/tanstack-react-start
npm i https://pkg.pr.new/@clerk/tanstack-react-start@9522

@clerk/testing
npm i https://pkg.pr.new/@clerk/testing@9522

@clerk/ui
npm i https://pkg.pr.new/@clerk/ui@9522

@clerk/upgrade
npm i https://pkg.pr.new/@clerk/upgrade@9522

@clerk/vue
npm i https://pkg.pr.new/@clerk/vue@9522

commit: 75b96fe
@github-actions
github-actionsBot
commented
Aug 21, 2026

Copy link


Copy Markdown

Contributor
API Changes Report
Generated by Break Check on 2026-08-21T03:28:13.492Z
Summary
MetricCount
Packages analyzed19
Packages with changes0
🔴 Breaking changes0
🟡 Non-breaking changes0
🟢 Additions0
No API Changes Detected
All packages have stable APIs with no detected changes.
Report generated by Break Check
Last ran on 75b96fe.
@zourzouvillys
zourzouvillys
enabled auto-merge (squash)
August 21, 2026 03:35
@zourzouvillys
zourzouvillys
merged commit e21ae9a
into
mainAug 21, 2026

52 checks passed

@zourzouvillys
zourzouvillys
deleted the

theo/address-9449-review-comments

branch
August 21, 2026 14:44
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@dstaleydstaleydstaley approved these changes

Assignees


No one assigned


Labels

ui

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@zourzouvillys@dstaley

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Universal Dark Mode - works on any site
(function() {
var enabled = true;
function applyDarkMode() {
if (!enabled) return;
// Create style element if it doesn't exist
var style = document.getElementById('universal-dark-mode-style');
if (!style) {
style = document.createElement('style');
style.id = 'universal-dark-mode-style';
document.head.appendChild(style);
}
// Dark mode CSS - inverts colors but preserves images/video
style.textContent = '
/* Invert everything except media */
html {
filter: invert(1) hue-rotate(180deg) !important;
background: #1a1a2e !important;
}
/* Restore images, videos, iframes, canvas */
img, video, iframe, canvas, svg, picture, [style*="background-image"] {
filter: invert(1) hue-rotate(180deg) !important;
}
/* Preserve specific elements that should not be inverted */
.no-dark-mode, .no-dark-mode *,
[data-theme="light"], [data-theme="light"],
.ace_editor, .ace_editor *,
.CodeMirror, .CodeMirror *,
.monaco-editor, .monaco-editor *,
.markdown-body pre, .markdown-body pre *,
.highlight, .highlight *,
pre code, pre code * {
filter: none !important;
}
/* Fix common UI elements */
.modal, .popup, .dropdown-menu, .tooltip, .popover {
filter: invert(1) hue-rotate(180deg) !important;
background: #2d2d44 !important;
border-color: #444 !important;
}
/* Scrollbars */
::-webkit-scrollbar { background: #1a1a2e !important; }
::-webkit-scrollbar-thumb { background: #444 !important; }
::-webkit-scrollbar-thumb:hover { background: #555 !important; }
/* Selection */
::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
';
}
function removeDarkMode() {
var style = document.getElementById('universal-dark-mode-style');
if (style) style.remove();
}
// Toggle with Alt+Shift+D
document.addEventListener('keydown', function(e) {
if (e.altKey && e.shiftKey && e.key === 'D') {
e.preventDefault();
enabled = !enabled;
if (enabled) {
applyDarkMode();
console.log('[Universal Dark Mode] Enabled');
} else {
removeDarkMode();
console.log('[Universal Dark Mode] Disabled');
}
}
});
// Apply on load
applyDarkMode();
// Re-apply on dynamic content
var observer = new MutationObserver(function(mutations) {
if (enabled && !document.getElementById('universal-dark-mode-style')) {
applyDarkMode();
}
});
observer.observe(document.head, { childList: true });
console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');
})();
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();
docs(shared,ui): address the review comments from #9449 by zourzouvillys · Pull Request #9522 · clerk/javascript · GitHub
Skip to content
docs(shared,ui): address the review comments from #9449 - #9522
Merged
zourzouvillys merged 1 commit into
mainfrom 
theo/address-9449-review-comments
Aug 21, 2026
Merged
docs(shared,ui): address the review comments from #9449#9522
zourzouvillys merged 1 commit into
mainfrom 
theo/address-9449-review-comments
Conversation
@zourzouvillys
@zourzouvillyszourzouvillys
commented
Aug 21, 2026

Copy link


Copy Markdown

Contributor
Follow-up to #9449, which merged before @dstaley's review suggestions were applied. This applies them, exactly as scoped:
  • .changeset/signup-enterprise-sso-redirect-urls.md — replaced with the one-line summary he suggested (the changeset had not been released yet, so the shorter text is what will ship).
  • packages/shared/src/internal/clerk-js/completeSignUpFlow.ts — dropped the comment above the redirect-url guard.
  • packages/ui/src/common/EmailLinkVerify.tsx — dropped the ssoCallbackUrl prop comment.
  • packages/ui/src/components/SignUp/useCompleteSignUpFlow.ts — dropped the hook's doc block.
Comment-only; no behaviour change, and no test or type surface moves with it.
@zourzouvillys@claude
docs(shared,ui): trim the review-flagged comments from#9449
75b96fe
Applies the review suggestions dstaley left on
#9449, which merged before they
were addressed: drop the three comments he marked and shorten the
changeset. Comment-only — no behaviour change.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_013a2R58ncemGjYAjLHKUpzb
@changeset-bot
changeset-botBot
commented
Aug 21, 2026

Copy link


Copy Markdown

⚠️ No Changeset found
Latest commit: 75b96fe
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes changesets to release 23 packages
NameType
@clerk/sharedPatch
@clerk/uiPatch
@clerk/astroPatch
@clerk/backendPatch
@clerk/chrome-extensionPatch
@clerk/clerk-jsPatch
@clerk/electronPatch
@clerk/expo-passkeysPatch
@clerk/expoPatch
@clerk/expressPatch
@clerk/fastifyPatch
@clerk/headlessPatch
@clerk/honoPatch
@clerk/localizationsPatch
@clerk/mswPatch
@clerk/nextjsPatch
@clerk/nuxtPatch
@clerk/react-routerPatch
@clerk/reactPatch
@clerk/tanstack-react-startPatch
@clerk/testingPatch
@clerk/vuePatch
@clerk/swingsetPatch
Click here to learn what changesets are, and how to add one.
Click here if you're a maintainer who wants to add a changeset to this PR
@vercel
vercelBot
commented
Aug 21, 2026•

edited

Loading

Copy link


Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.
ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxReadyReadyPreviewAug 21, 2026 3:27am
swingsetReadyReadyPreviewAug 21, 2026 3:27am
Request Review
@coderabbitai
coderabbitaiBot
commented
Aug 21, 2026

Copy link


Copy Markdown

Contributor
Review Change Stack
No actionable comments were generated in the recent review. 🎉
ℹ️ Recent review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Organization UI (inherited)
Review profile: CHILL
Plan: Pro Plus
Run ID: 3efc55ba-27ac-4efb-ab95-7ee7234db64b
📥 Commits
Reviewing files that changed from the base of the PR and between 17b865b and 75b96fe.
📒 Files selected for processing (4)
  • .changeset/signup-enterprise-sso-redirect-urls.md
  • packages/shared/src/internal/clerk-js/completeSignUpFlow.ts
  • packages/ui/src/common/EmailLinkVerify.tsx
  • packages/ui/src/components/SignUp/useCompleteSignUpFlow.ts
🔗 Linked repositories identified
CodeRabbit considers these linked repositories for cross-repo context during reviews:
  • clerk/clerk_go(manual)
  • clerk/dashboard(manual)
  • clerk/accounts(manual)
  • clerk/backoffice(manual)
  • clerk/clerk(manual)
  • clerk/clerk-docs(manual)
  • clerk/cloudflare-workers(manual)
  • clerk/clerk-ios(auto-detected)
  • clerk/cli(auto-detected)
  • clerk/clerk-android(auto-detected)
💤 Files with no reviewable changes (3)
  • packages/shared/src/internal/clerk-js/completeSignUpFlow.ts
  • packages/ui/src/common/EmailLinkVerify.tsx
  • packages/ui/src/components/SignUp/useCompleteSignUpFlow.ts
Included review availability: 8 reviews are currently available. Your included PR review attempts over the past 7 days set your current allowance at 10 reviews per hour.
📝 Walkthrough
Walkthrough
The changeset now states that enterprise SSO sign-ups correctly forward redirect URLs. Explanatory comments were removed from the sign-up flow validation and UI hook declarations. Runtime behavior and public entity declarations remain unchanged.
Estimated code review effort: 1 (Trivial) | ~2 minutes
Merge Risk:⚪ Minimal · up to 75b96
This PR only updates documentation and comments without changing product behavior, so no actionable merge-blocking risk remains after normal checks and review.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check nameStatusExplanation
Title check✅ PassedThe title clearly identifies this as a documentation follow-up applying review comments across the shared and UI packages.
Description check✅ PassedThe description accurately explains the review follow-up, the affected files, and the absence of behavior or type-surface changes.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
Comment @coderabbitai help to get the list of available commands.
@pkg-pr-new
pkg-pr-newBot
commented
Aug 21, 2026

Copy link


Copy Markdown

Open in StackBlitz
@clerk/astro
npm i https://pkg.pr.new/@clerk/astro@9522

@clerk/backend
npm i https://pkg.pr.new/@clerk/backend@9522

@clerk/chrome-extension
npm i https://pkg.pr.new/@clerk/chrome-extension@9522

@clerk/clerk-js
npm i https://pkg.pr.new/@clerk/clerk-js@9522

@clerk/electron
npm i https://pkg.pr.new/@clerk/electron@9522

@clerk/electron-passkeys
npm i https://pkg.pr.new/@clerk/electron-passkeys@9522

@clerk/eslint-plugin
npm i https://pkg.pr.new/@clerk/eslint-plugin@9522

@clerk/expo
npm i https://pkg.pr.new/@clerk/expo@9522

@clerk/expo-google-signin
npm i https://pkg.pr.new/@clerk/expo-google-signin@9522

@clerk/expo-passkeys
npm i https://pkg.pr.new/@clerk/expo-passkeys@9522

@clerk/express
npm i https://pkg.pr.new/@clerk/express@9522

@clerk/fastify
npm i https://pkg.pr.new/@clerk/fastify@9522

@clerk/hono
npm i https://pkg.pr.new/@clerk/hono@9522

@clerk/localizations
npm i https://pkg.pr.new/@clerk/localizations@9522

@clerk/nextjs
npm i https://pkg.pr.new/@clerk/nextjs@9522

@clerk/nuxt
npm i https://pkg.pr.new/@clerk/nuxt@9522

@clerk/react
npm i https://pkg.pr.new/@clerk/react@9522

@clerk/react-router
npm i https://pkg.pr.new/@clerk/react-router@9522

@clerk/shared
npm i https://pkg.pr.new/@clerk/shared@9522

@clerk/tanstack-react-start
npm i https://pkg.pr.new/@clerk/tanstack-react-start@9522

@clerk/testing
npm i https://pkg.pr.new/@clerk/testing@9522

@clerk/ui
npm i https://pkg.pr.new/@clerk/ui@9522

@clerk/upgrade
npm i https://pkg.pr.new/@clerk/upgrade@9522

@clerk/vue
npm i https://pkg.pr.new/@clerk/vue@9522

commit: 75b96fe
@github-actions
github-actionsBot
commented
Aug 21, 2026

Copy link


Copy Markdown

Contributor
API Changes Report
Generated by Break Check on 2026-08-21T03:28:13.492Z
Summary
MetricCount
Packages analyzed19
Packages with changes0
🔴 Breaking changes0
🟡 Non-breaking changes0
🟢 Additions0
No API Changes Detected
All packages have stable APIs with no detected changes.
Report generated by Break Check
Last ran on 75b96fe.
@zourzouvillys
zourzouvillys
enabled auto-merge (squash)
August 21, 2026 03:35
@zourzouvillys
zourzouvillys
merged commit e21ae9a
into
mainAug 21, 2026

52 checks passed

@zourzouvillys
zourzouvillys
deleted the

theo/address-9449-review-comments

branch
August 21, 2026 14:44
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@dstaleydstaleydstaley approved these changes

Assignees


No one assigned


Labels

ui

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@zourzouvillys@dstaley