Uh oh!
There was an error while loading. Please reload this page.
fix(shared): run a sign-up challenge before the enterprise hand-off - #9622
Draft
zourzouvillys wants to merge 1 commit into
Draft
fix(shared): run a sign-up challenge before the enterprise hand-off#9622zourzouvillys wants to merge 1 commit into
zourzouvillys wants to merge 1 commit into
Conversation
A sign-up can be missing `enterprise_sso` and `protect_check` at once. `completeSignUpFlow` took the hand-off first, so the challenge only ran after the round trip to the identity provider, while its sibling `navigateToNextStepSignUp` did the opposite. Both now take the challenge first, and the hand-off follows once it resolves. Callers that pass no challenge route are unaffected. Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
🦋 Changeset detectedLatest commit: e4c62f2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 23 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The latest updates on your projects. Learn more about Vercel for GitHub.
|
@clerk/astro@clerk/backend@clerk/chrome-extension@clerk/clerk-js@clerk/electron@clerk/electron-passkeys@clerk/eslint-plugin@clerk/expo@clerk/expo-google-signin@clerk/expo-passkeys@clerk/express@clerk/fastify@clerk/hono@clerk/localizations@clerk/nextjs@clerk/nuxt@clerk/react@clerk/react-router@clerk/shared@clerk/tanstack-react-start@clerk/testing@clerk/ui@clerk/upgrade@clerk/vuecommit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Independent of #9619 / #9620 / #9621 — merges on its own.
A sign-up can be missing
enterprise_ssoandprotect_checkat the same time.completeSignUpFlowtook the hand-off to the identity provider first, so the verification challenge only ran after the round trip had already happened. Its siblingnavigateToNextStepSignUpdoes the opposite and takes the challenge first, so the same state routed two different ways depending on which helper it reached.Both now take the challenge first. Resolving it returns to
completeSignUpFlowwith only the hand-off left to do, which is the behaviour #9449 already plumbed the redirect URLs for.Effects and risks
enterprise_ssois unaffected; also covered by a test.forwardClerkQueryParams()moves above the hand-off so it is defined before first use. It reads the current query string and builds aURLSearchParams, so running it on this path changes nothing.Checklist
pnpm testruns as expected.pnpm buildruns as expected.Type of change