Uh oh!
There was an error while loading. Please reload this page.
Issue 128 - Fix to incorrect table layout with rowSpan and colSpan - #187
Closed
speedytwenty wants to merge 1 commit into
Closed
Issue 128 - Fix to incorrect table layout with rowSpan and colSpan#187speedytwenty wants to merge 1 commit into
speedytwenty wants to merge 1 commit into
Conversation
Closed
nimit2801
commented
May 3, 2021
I'll surely try this thank you. |
Closed
nimit2801
commented
May 4, 2021
This solves #211. Thanks @speedytwenty. |
speedytwenty
marked this pull request as draft
May 4, 2021 12:06
speedytwenty
marked this pull request as ready for review
May 4, 2021 12:06
speedytwenty
commented
May 4, 2021
CollaboratorAuthor
Wanted to call this PR to your attention in case you may find time to review it @Turbo87@DanielRuf This resolves the 3 mentioned issues (#128#147#211) and includes an appropriate unit test. |
speedytwenty
marked this pull request as draft
May 4, 2021 12:12
speedytwenty
marked this pull request as ready for review
May 4, 2021 12:13
speedytwenty
commented
May 4, 2021
CollaboratorAuthor
I rebased the branch to make it an easy fast-forward. |
DanielRuf
approved these changes
May 4, 2021
This was
linked to
issues
May 5, 2021
Closed
Closed
speedytwenty
commented
May 5, 2021
CollaboratorAuthor
Fixed with: 6cfb6e0 |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was having a similar issue as that described in #128. This PR resolves the issue and adds a test that covers the use case.