Uh oh!
There was an error while loading. Please reload this page.
enable static network configuration via vmware guestinfo - #83
enable static network configuration via vmware guestinfo#83kimbernator wants to merge 2 commits into
Conversation
is this patch working ? I try to do the modification but I've got an error : |
ader1990
commented
Feb 8, 2022
Hello, Please make sure that you have the latest cloudbase-init version installed / cloned before trying to We are currently using OpenStack's review workflow for accepting patches, see this workflow: #62 (comment) Thank you, |
twalcari
commented
Feb 8, 2022
Hi Adrian, Thank you for commenting on this issue. Would it be possible to add the information about this OpenStack review workflow that you have adopted somewhere visible in this repository? ie. in the README or by mentioning it in the pull request template ? I would already have followed all steps in this workflow months ago if I had known about it. |
kimbernator
commented
Feb 17, 2022
The import should be fixed now. The codebase is on the current version. |
kimbernator
commented
Feb 17, 2022
I have submitted the patch as requested. As @twalcari said, this should be documented. Frustrating that it took two and a half months to be notified of this. |
jaymzmac
commented
Jun 7, 2022
@kimbernator did you see there were some minor lint issues that need fixing before your patch can be merged? https://review.opendev.org/c/x/cloudbase-init/+/829757 |
PrimordialLight
commented
Jun 30, 2022
@kimbernator you able to clean up those two small lint issues? Been wanting to use this patch for awhile |
kimbernator
commented
Sep 11, 2022
I no longer work for the employer whose email I used to log into opendev.org, and consequently I don't have a personal or professional need for this change. If someone else wants to make this contribution, they are free to do so. |
FlorianLaunay
commented
Dec 19, 2023
Feature will now be provided by #107 . Could you please close this one ? |
Resolves#78
This enables static networking configuration in the vmware guestinfo metadata source. I basically just have it parse the network data using the nocloud network config v1 parser since they follow the same spec.
I'm a bit green to this codebase so please let me know if there's more I need to add for this to have the intended effect.