Keep published runtime bundles ASCII-only - #239

Merged
teamchong merged 3 commits into
cloudflare:mainfrom
Maximo-Guk:ascii-only-dist
Aug 12, 2026
Merged

Keep published runtime bundles ASCII-only#239
teamchong merged 3 commits into
cloudflare:mainfrom
Maximo-Guk:ascii-only-dist

Conversation

@Maximo-Guk

@Maximo-GukMaximo-Guk commented Aug 12, 2026

Copy link
Copy Markdown
Member

0.11.0's dist bundles carry a U+2212 (typographic minus) from a websocket.ts doc comment (#209). Discovered in Cloudflare OS capnweb bump. Consumers that inline the bundle - e.g. into a data: URL via btoa(), which only accepts Latin-1 - throw on it, and anything in U+0080–U+00FF would corrupt silently instead.

This fixes the comment and adds a post-build check that fails if any non-ASCII byte reaches a runtime bundle in dist/. Runtime strings that legitimately need non-ASCII can use \u escapes in source.

@changeset-bot

changeset-botBot commented Aug 12, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: df539d2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
NameType
capnwebPatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@pkg-pr-new

pkg-pr-newBot commented Aug 12, 2026

Copy link
Copy Markdown

Open in StackBlitz

npm i https://pkg.pr.new/cloudflare/capnweb@239

commit: df539d2

A typographic minus in a websocket.ts doc comment (introduced in cloudflare#209)
survived bundling into every dist runtime bundle in 0.11.0. Consumers
that inline the bundle through Latin-1-only APIs like btoa() throw on
any character above U+00FF and silently corrupt anything above U+007F.
Fix the comment, and enforce the invariant where it actually holds: a
post-build check fails if any non-ASCII byte reaches a runtime bundle
in dist/, since which source comments survive bundling is bundler
implementation detail.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@Maximo-Guk
Maximo-Guk marked this pull request as ready for review August 12, 2026 19:47
Comment thread.changeset/ascii-only-dist.md
@teamchong

Copy link
Copy Markdown
Collaborator

/bonk review this

@ask-bonkask-bonkBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed. This is a clean, well-targeted fix and the enforcement approach (checking built output rather than source) is the right call — bundlers decide which comments survive, so guarding dist/ is the correct invariant. The .map and .d.ts exclusions look intentional and correct. A few non-blocking observations below.

Overall LGTM.

Notes:

  • The changeset attributes the byte to 0.11.0. Per git history the §5.5 doc comment was introduced in #209 (commit ee7ca6f), so 0.11.0 is accurate for this character. @ndisidore's point about an earlier version is about cfos jumping 0.8.0 → 0.11.0 catching it late — worth reconciling the wording but not blocking.
  • The check reads dist/ non-recursively, which matches the current flat tsdown output. If entry-splitting ever emits shared chunks into subdirs, the check would silently skip them. See inline note.
  • The comment says "non-ASCII bytes" but the regex matches by code point after UTF-8 decode. Functionally equivalent for the goal; minor wording.

Comment threadscripts/check-dist-ascii.mjs Outdated
Comment threadscripts/check-dist-ascii.mjs Outdated
@ask-bonk

ask-bonkBot commented Aug 12, 2026

Copy link
Copy Markdown

Review posted successfully. Here's a summary of my findings on PR #239:

Review Summary

Verdict: LGTM — clean, well-targeted fix.

The PR fixes a U+2212 (typographic minus) and § in a websocket.ts doc comment (introduced in #209) that leaked into published dist/ bundles, and adds a post-build guard against non-ASCII bytes in runtime output.

Strengths

  • Right enforcement layer: The check guards built output (dist/) rather than source. Since bundlers decide which comments survive, this is the correct invariant to enforce.
  • Correct exclusions for .map and .d.ts files.
  • Minimal, focused source change.
  • Verified: no other non-ASCII characters currently exist in src/.

Non-blocking notes (posted inline)

  1. readdirSync is non-recursive — matches current flat tsdown output, but the tsdown config itself warns about shared chunks appearing when entries bundle together. If chunks ever land in subdirs, the check silently skips them. Suggested using { recursive: true }.
  2. Wording nit — the comment says "non-ASCII bytes" but the regex matches by code point after UTF-8 decode (characters, not raw bytes). Functionally fine.
  3. Changeset version attribution — confirmed via git history that the §5.5 comment came from Tidy the error-type map and WebSocket close-reason limit #209, so "0.11.0" is accurate for this character; reconciled with @ndisidore's earlier-version point (cfos jumped 0.8.0 → 0.11.0, catching it late).

github run

Maximo-Gukand others added 2 commits August 12, 2026 16:02
… attribution
Scan dist/ recursively so shared chunks emitted into subdirectories
(possible per the tsdown config's own note when entries bundle
together) can't slip past the check; verified a planted subdir file
fails it. Say "characters" rather than "bytes" since the regex matches
code points after UTF-8 decode, and attribute the U+2212 to cloudflare#209,
which first shipped in 0.11.0.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@teamchong
teamchong merged commit 667958e into cloudflare:mainAug 12, 2026
5 checks passed
@github-actionsgithub-actionsBot mentioned this pull request Aug 12, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@Maximo-Guk@teamchong@ndisidore
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Skip to content

Keep published runtime bundles ASCII-only - #239

Merged
teamchong merged 3 commits into
cloudflare:mainfrom
Maximo-Guk:ascii-only-dist
Aug 12, 2026
Merged

Keep published runtime bundles ASCII-only#239
teamchong merged 3 commits into
cloudflare:mainfrom
Maximo-Guk:ascii-only-dist

Conversation

@Maximo-Guk

@Maximo-GukMaximo-Guk commented Aug 12, 2026

Copy link
Copy Markdown
Member

0.11.0's dist bundles carry a U+2212 (typographic minus) from a websocket.ts doc comment (#209). Discovered in Cloudflare OS capnweb bump. Consumers that inline the bundle - e.g. into a data: URL via btoa(), which only accepts Latin-1 - throw on it, and anything in U+0080–U+00FF would corrupt silently instead.

This fixes the comment and adds a post-build check that fails if any non-ASCII byte reaches a runtime bundle in dist/. Runtime strings that legitimately need non-ASCII can use \u escapes in source.

@changeset-bot

changeset-botBot commented Aug 12, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: df539d2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
NameType
capnwebPatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@pkg-pr-new

pkg-pr-newBot commented Aug 12, 2026

Copy link
Copy Markdown

Open in StackBlitz

npm i https://pkg.pr.new/cloudflare/capnweb@239

commit: df539d2

A typographic minus in a websocket.ts doc comment (introduced in cloudflare#209)
survived bundling into every dist runtime bundle in 0.11.0. Consumers
that inline the bundle through Latin-1-only APIs like btoa() throw on
any character above U+00FF and silently corrupt anything above U+007F.
Fix the comment, and enforce the invariant where it actually holds: a
post-build check fails if any non-ASCII byte reaches a runtime bundle
in dist/, since which source comments survive bundling is bundler
implementation detail.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@Maximo-Guk
Maximo-Guk marked this pull request as ready for review August 12, 2026 19:47
Comment thread.changeset/ascii-only-dist.md
@teamchong

Copy link
Copy Markdown
Collaborator

/bonk review this

@ask-bonkask-bonkBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed. This is a clean, well-targeted fix and the enforcement approach (checking built output rather than source) is the right call — bundlers decide which comments survive, so guarding dist/ is the correct invariant. The .map and .d.ts exclusions look intentional and correct. A few non-blocking observations below.

Overall LGTM.

Notes:

  • The changeset attributes the byte to 0.11.0. Per git history the §5.5 doc comment was introduced in #209 (commit ee7ca6f), so 0.11.0 is accurate for this character. @ndisidore's point about an earlier version is about cfos jumping 0.8.0 → 0.11.0 catching it late — worth reconciling the wording but not blocking.
  • The check reads dist/ non-recursively, which matches the current flat tsdown output. If entry-splitting ever emits shared chunks into subdirs, the check would silently skip them. See inline note.
  • The comment says "non-ASCII bytes" but the regex matches by code point after UTF-8 decode. Functionally equivalent for the goal; minor wording.

Comment threadscripts/check-dist-ascii.mjs Outdated
Comment threadscripts/check-dist-ascii.mjs Outdated
@ask-bonk

ask-bonkBot commented Aug 12, 2026

Copy link
Copy Markdown

Review posted successfully. Here's a summary of my findings on PR #239:

Review Summary

Verdict: LGTM — clean, well-targeted fix.

The PR fixes a U+2212 (typographic minus) and § in a websocket.ts doc comment (introduced in #209) that leaked into published dist/ bundles, and adds a post-build guard against non-ASCII bytes in runtime output.

Strengths

  • Right enforcement layer: The check guards built output (dist/) rather than source. Since bundlers decide which comments survive, this is the correct invariant to enforce.
  • Correct exclusions for .map and .d.ts files.
  • Minimal, focused source change.
  • Verified: no other non-ASCII characters currently exist in src/.

Non-blocking notes (posted inline)

  1. readdirSync is non-recursive — matches current flat tsdown output, but the tsdown config itself warns about shared chunks appearing when entries bundle together. If chunks ever land in subdirs, the check silently skips them. Suggested using { recursive: true }.
  2. Wording nit — the comment says "non-ASCII bytes" but the regex matches by code point after UTF-8 decode (characters, not raw bytes). Functionally fine.
  3. Changeset version attribution — confirmed via git history that the §5.5 comment came from Tidy the error-type map and WebSocket close-reason limit #209, so "0.11.0" is accurate for this character; reconciled with @ndisidore's earlier-version point (cfos jumped 0.8.0 → 0.11.0, catching it late).

github run

Maximo-Gukand others added 2 commits August 12, 2026 16:02
… attribution
Scan dist/ recursively so shared chunks emitted into subdirectories
(possible per the tsdown config's own note when entries bundle
together) can't slip past the check; verified a planted subdir file
fails it. Say "characters" rather than "bytes" since the regex matches
code points after UTF-8 decode, and attribute the U+2212 to cloudflare#209,
which first shipped in 0.11.0.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@teamchong
teamchong merged commit 667958e into cloudflare:mainAug 12, 2026
5 checks passed
@github-actionsgithub-actionsBot mentioned this pull request Aug 12, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@Maximo-Guk@teamchong@ndisidore
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix"); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

Keep published runtime bundles ASCII-only - #239

Merged
teamchong merged 3 commits into
cloudflare:mainfrom
Maximo-Guk:ascii-only-dist
Aug 12, 2026
Merged

Keep published runtime bundles ASCII-only#239
teamchong merged 3 commits into
cloudflare:mainfrom
Maximo-Guk:ascii-only-dist

Conversation

@Maximo-Guk

@Maximo-GukMaximo-Guk commented Aug 12, 2026

Copy link
Copy Markdown
Member

0.11.0's dist bundles carry a U+2212 (typographic minus) from a websocket.ts doc comment (#209). Discovered in Cloudflare OS capnweb bump. Consumers that inline the bundle - e.g. into a data: URL via btoa(), which only accepts Latin-1 - throw on it, and anything in U+0080–U+00FF would corrupt silently instead.

This fixes the comment and adds a post-build check that fails if any non-ASCII byte reaches a runtime bundle in dist/. Runtime strings that legitimately need non-ASCII can use \u escapes in source.

@changeset-bot

changeset-botBot commented Aug 12, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: df539d2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
NameType
capnwebPatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@pkg-pr-new

pkg-pr-newBot commented Aug 12, 2026

Copy link
Copy Markdown

Open in StackBlitz

npm i https://pkg.pr.new/cloudflare/capnweb@239

commit: df539d2

A typographic minus in a websocket.ts doc comment (introduced in cloudflare#209)
survived bundling into every dist runtime bundle in 0.11.0. Consumers
that inline the bundle through Latin-1-only APIs like btoa() throw on
any character above U+00FF and silently corrupt anything above U+007F.
Fix the comment, and enforce the invariant where it actually holds: a
post-build check fails if any non-ASCII byte reaches a runtime bundle
in dist/, since which source comments survive bundling is bundler
implementation detail.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@Maximo-Guk
Maximo-Guk marked this pull request as ready for review August 12, 2026 19:47
Comment thread.changeset/ascii-only-dist.md
@teamchong

Copy link
Copy Markdown
Collaborator

/bonk review this

@ask-bonkask-bonkBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed. This is a clean, well-targeted fix and the enforcement approach (checking built output rather than source) is the right call — bundlers decide which comments survive, so guarding dist/ is the correct invariant. The .map and .d.ts exclusions look intentional and correct. A few non-blocking observations below.

Overall LGTM.

Notes:

  • The changeset attributes the byte to 0.11.0. Per git history the §5.5 doc comment was introduced in #209 (commit ee7ca6f), so 0.11.0 is accurate for this character. @ndisidore's point about an earlier version is about cfos jumping 0.8.0 → 0.11.0 catching it late — worth reconciling the wording but not blocking.
  • The check reads dist/ non-recursively, which matches the current flat tsdown output. If entry-splitting ever emits shared chunks into subdirs, the check would silently skip them. See inline note.
  • The comment says "non-ASCII bytes" but the regex matches by code point after UTF-8 decode. Functionally equivalent for the goal; minor wording.

Comment threadscripts/check-dist-ascii.mjs Outdated
Comment threadscripts/check-dist-ascii.mjs Outdated
@ask-bonk

ask-bonkBot commented Aug 12, 2026

Copy link
Copy Markdown

Review posted successfully. Here's a summary of my findings on PR #239:

Review Summary

Verdict: LGTM — clean, well-targeted fix.

The PR fixes a U+2212 (typographic minus) and § in a websocket.ts doc comment (introduced in #209) that leaked into published dist/ bundles, and adds a post-build guard against non-ASCII bytes in runtime output.

Strengths

  • Right enforcement layer: The check guards built output (dist/) rather than source. Since bundlers decide which comments survive, this is the correct invariant to enforce.
  • Correct exclusions for .map and .d.ts files.
  • Minimal, focused source change.
  • Verified: no other non-ASCII characters currently exist in src/.

Non-blocking notes (posted inline)

  1. readdirSync is non-recursive — matches current flat tsdown output, but the tsdown config itself warns about shared chunks appearing when entries bundle together. If chunks ever land in subdirs, the check silently skips them. Suggested using { recursive: true }.
  2. Wording nit — the comment says "non-ASCII bytes" but the regex matches by code point after UTF-8 decode (characters, not raw bytes). Functionally fine.
  3. Changeset version attribution — confirmed via git history that the §5.5 comment came from Tidy the error-type map and WebSocket close-reason limit #209, so "0.11.0" is accurate for this character; reconciled with @ndisidore's earlier-version point (cfos jumped 0.8.0 → 0.11.0, catching it late).

github run

Maximo-Gukand others added 2 commits August 12, 2026 16:02
… attribution
Scan dist/ recursively so shared chunks emitted into subdirectories
(possible per the tsdown config's own note when entries bundle
together) can't slip past the check; verified a planted subdir file
fails it. Say "characters" rather than "bytes" since the regex matches
code points after UTF-8 decode, and attribute the U+2212 to cloudflare#209,
which first shipped in 0.11.0.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@teamchong
teamchong merged commit 667958e into cloudflare:mainAug 12, 2026
5 checks passed
@github-actionsgithub-actionsBot mentioned this pull request Aug 12, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@Maximo-Guk@teamchong@ndisidore
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms"); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

Keep published runtime bundles ASCII-only - #239

Merged
teamchong merged 3 commits into
cloudflare:mainfrom
Maximo-Guk:ascii-only-dist
Aug 12, 2026
Merged

Keep published runtime bundles ASCII-only#239
teamchong merged 3 commits into
cloudflare:mainfrom
Maximo-Guk:ascii-only-dist

Conversation

@Maximo-Guk

@Maximo-GukMaximo-Guk commented Aug 12, 2026

Copy link
Copy Markdown
Member

0.11.0's dist bundles carry a U+2212 (typographic minus) from a websocket.ts doc comment (#209). Discovered in Cloudflare OS capnweb bump. Consumers that inline the bundle - e.g. into a data: URL via btoa(), which only accepts Latin-1 - throw on it, and anything in U+0080–U+00FF would corrupt silently instead.

This fixes the comment and adds a post-build check that fails if any non-ASCII byte reaches a runtime bundle in dist/. Runtime strings that legitimately need non-ASCII can use \u escapes in source.

@changeset-bot

changeset-botBot commented Aug 12, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: df539d2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
NameType
capnwebPatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@pkg-pr-new

pkg-pr-newBot commented Aug 12, 2026

Copy link
Copy Markdown

Open in StackBlitz

npm i https://pkg.pr.new/cloudflare/capnweb@239

commit: df539d2

A typographic minus in a websocket.ts doc comment (introduced in cloudflare#209)
survived bundling into every dist runtime bundle in 0.11.0. Consumers
that inline the bundle through Latin-1-only APIs like btoa() throw on
any character above U+00FF and silently corrupt anything above U+007F.
Fix the comment, and enforce the invariant where it actually holds: a
post-build check fails if any non-ASCII byte reaches a runtime bundle
in dist/, since which source comments survive bundling is bundler
implementation detail.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@Maximo-Guk
Maximo-Guk marked this pull request as ready for review August 12, 2026 19:47
Comment thread.changeset/ascii-only-dist.md
@teamchong

Copy link
Copy Markdown
Collaborator

/bonk review this

@ask-bonkask-bonkBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed. This is a clean, well-targeted fix and the enforcement approach (checking built output rather than source) is the right call — bundlers decide which comments survive, so guarding dist/ is the correct invariant. The .map and .d.ts exclusions look intentional and correct. A few non-blocking observations below.

Overall LGTM.

Notes:

  • The changeset attributes the byte to 0.11.0. Per git history the §5.5 doc comment was introduced in #209 (commit ee7ca6f), so 0.11.0 is accurate for this character. @ndisidore's point about an earlier version is about cfos jumping 0.8.0 → 0.11.0 catching it late — worth reconciling the wording but not blocking.
  • The check reads dist/ non-recursively, which matches the current flat tsdown output. If entry-splitting ever emits shared chunks into subdirs, the check would silently skip them. See inline note.
  • The comment says "non-ASCII bytes" but the regex matches by code point after UTF-8 decode. Functionally equivalent for the goal; minor wording.

Comment threadscripts/check-dist-ascii.mjs Outdated
Comment threadscripts/check-dist-ascii.mjs Outdated
@ask-bonk

ask-bonkBot commented Aug 12, 2026

Copy link
Copy Markdown

Review posted successfully. Here's a summary of my findings on PR #239:

Review Summary

Verdict: LGTM — clean, well-targeted fix.

The PR fixes a U+2212 (typographic minus) and § in a websocket.ts doc comment (introduced in #209) that leaked into published dist/ bundles, and adds a post-build guard against non-ASCII bytes in runtime output.

Strengths

  • Right enforcement layer: The check guards built output (dist/) rather than source. Since bundlers decide which comments survive, this is the correct invariant to enforce.
  • Correct exclusions for .map and .d.ts files.
  • Minimal, focused source change.
  • Verified: no other non-ASCII characters currently exist in src/.

Non-blocking notes (posted inline)

  1. readdirSync is non-recursive — matches current flat tsdown output, but the tsdown config itself warns about shared chunks appearing when entries bundle together. If chunks ever land in subdirs, the check silently skips them. Suggested using { recursive: true }.
  2. Wording nit — the comment says "non-ASCII bytes" but the regex matches by code point after UTF-8 decode (characters, not raw bytes). Functionally fine.
  3. Changeset version attribution — confirmed via git history that the §5.5 comment came from Tidy the error-type map and WebSocket close-reason limit #209, so "0.11.0" is accurate for this character; reconciled with @ndisidore's earlier-version point (cfos jumped 0.8.0 → 0.11.0, catching it late).

github run

Maximo-Gukand others added 2 commits August 12, 2026 16:02
… attribution
Scan dist/ recursively so shared chunks emitted into subdirectories
(possible per the tsdown config's own note when entries bundle
together) can't slip past the check; verified a planted subdir file
fails it. Say "characters" rather than "bytes" since the regex matches
code points after UTF-8 decode, and attribute the U+2212 to cloudflare#209,
which first shipped in 0.11.0.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@teamchong
teamchong merged commit 667958e into cloudflare:mainAug 12, 2026
5 checks passed
@github-actionsgithub-actionsBot mentioned this pull request Aug 12, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@Maximo-Guk@teamchong@ndisidore
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links"); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + '
Skip to content

Keep published runtime bundles ASCII-only - #239

Merged
teamchong merged 3 commits into
cloudflare:mainfrom
Maximo-Guk:ascii-only-dist
Aug 12, 2026
Merged

Keep published runtime bundles ASCII-only#239
teamchong merged 3 commits into
cloudflare:mainfrom
Maximo-Guk:ascii-only-dist

Conversation

@Maximo-Guk

@Maximo-GukMaximo-Guk commented Aug 12, 2026

Copy link
Copy Markdown
Member

0.11.0's dist bundles carry a U+2212 (typographic minus) from a websocket.ts doc comment (#209). Discovered in Cloudflare OS capnweb bump. Consumers that inline the bundle - e.g. into a data: URL via btoa(), which only accepts Latin-1 - throw on it, and anything in U+0080–U+00FF would corrupt silently instead.

This fixes the comment and adds a post-build check that fails if any non-ASCII byte reaches a runtime bundle in dist/. Runtime strings that legitimately need non-ASCII can use \u escapes in source.

@changeset-bot

changeset-botBot commented Aug 12, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: df539d2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
NameType
capnwebPatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@pkg-pr-new

pkg-pr-newBot commented Aug 12, 2026

Copy link
Copy Markdown

Open in StackBlitz

npm i https://pkg.pr.new/cloudflare/capnweb@239

commit: df539d2

A typographic minus in a websocket.ts doc comment (introduced in cloudflare#209)
survived bundling into every dist runtime bundle in 0.11.0. Consumers
that inline the bundle through Latin-1-only APIs like btoa() throw on
any character above U+00FF and silently corrupt anything above U+007F.
Fix the comment, and enforce the invariant where it actually holds: a
post-build check fails if any non-ASCII byte reaches a runtime bundle
in dist/, since which source comments survive bundling is bundler
implementation detail.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@Maximo-Guk
Maximo-Guk marked this pull request as ready for review August 12, 2026 19:47
Comment thread.changeset/ascii-only-dist.md
@teamchong

Copy link
Copy Markdown
Collaborator

/bonk review this

@ask-bonkask-bonkBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed. This is a clean, well-targeted fix and the enforcement approach (checking built output rather than source) is the right call — bundlers decide which comments survive, so guarding dist/ is the correct invariant. The .map and .d.ts exclusions look intentional and correct. A few non-blocking observations below.

Overall LGTM.

Notes:

  • The changeset attributes the byte to 0.11.0. Per git history the §5.5 doc comment was introduced in #209 (commit ee7ca6f), so 0.11.0 is accurate for this character. @ndisidore's point about an earlier version is about cfos jumping 0.8.0 → 0.11.0 catching it late — worth reconciling the wording but not blocking.
  • The check reads dist/ non-recursively, which matches the current flat tsdown output. If entry-splitting ever emits shared chunks into subdirs, the check would silently skip them. See inline note.
  • The comment says "non-ASCII bytes" but the regex matches by code point after UTF-8 decode. Functionally equivalent for the goal; minor wording.

Comment threadscripts/check-dist-ascii.mjs Outdated
Comment threadscripts/check-dist-ascii.mjs Outdated
@ask-bonk

ask-bonkBot commented Aug 12, 2026

Copy link
Copy Markdown

Review posted successfully. Here's a summary of my findings on PR #239:

Review Summary

Verdict: LGTM — clean, well-targeted fix.

The PR fixes a U+2212 (typographic minus) and § in a websocket.ts doc comment (introduced in #209) that leaked into published dist/ bundles, and adds a post-build guard against non-ASCII bytes in runtime output.

Strengths

  • Right enforcement layer: The check guards built output (dist/) rather than source. Since bundlers decide which comments survive, this is the correct invariant to enforce.
  • Correct exclusions for .map and .d.ts files.
  • Minimal, focused source change.
  • Verified: no other non-ASCII characters currently exist in src/.

Non-blocking notes (posted inline)

  1. readdirSync is non-recursive — matches current flat tsdown output, but the tsdown config itself warns about shared chunks appearing when entries bundle together. If chunks ever land in subdirs, the check silently skips them. Suggested using { recursive: true }.
  2. Wording nit — the comment says "non-ASCII bytes" but the regex matches by code point after UTF-8 decode (characters, not raw bytes). Functionally fine.
  3. Changeset version attribution — confirmed via git history that the §5.5 comment came from Tidy the error-type map and WebSocket close-reason limit #209, so "0.11.0" is accurate for this character; reconciled with @ndisidore's earlier-version point (cfos jumped 0.8.0 → 0.11.0, catching it late).

github run

Maximo-Gukand others added 2 commits August 12, 2026 16:02
… attribution
Scan dist/ recursively so shared chunks emitted into subdirectories
(possible per the tsdown config's own note when entries bundle
together) can't slip past the check; verified a planted subdir file
fails it. Say "characters" rather than "bytes" since the regex matches
code points after UTF-8 decode, and attribute the U+2212 to cloudflare#209,
which first shipped in 0.11.0.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@teamchong
teamchong merged commit 667958e into cloudflare:mainAug 12, 2026
5 checks passed
@github-actionsgithub-actionsBot mentioned this pull request Aug 12, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@Maximo-Guk@teamchong@ndisidore
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default"); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

Keep published runtime bundles ASCII-only - #239

Merged
teamchong merged 3 commits into
cloudflare:mainfrom
Maximo-Guk:ascii-only-dist
Aug 12, 2026
Merged

Keep published runtime bundles ASCII-only#239
teamchong merged 3 commits into
cloudflare:mainfrom
Maximo-Guk:ascii-only-dist

Conversation

@Maximo-Guk

@Maximo-GukMaximo-Guk commented Aug 12, 2026

Copy link
Copy Markdown
Member

0.11.0's dist bundles carry a U+2212 (typographic minus) from a websocket.ts doc comment (#209). Discovered in Cloudflare OS capnweb bump. Consumers that inline the bundle - e.g. into a data: URL via btoa(), which only accepts Latin-1 - throw on it, and anything in U+0080–U+00FF would corrupt silently instead.

This fixes the comment and adds a post-build check that fails if any non-ASCII byte reaches a runtime bundle in dist/. Runtime strings that legitimately need non-ASCII can use \u escapes in source.

@changeset-bot

changeset-botBot commented Aug 12, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: df539d2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
NameType
capnwebPatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@pkg-pr-new

pkg-pr-newBot commented Aug 12, 2026

Copy link
Copy Markdown

Open in StackBlitz

npm i https://pkg.pr.new/cloudflare/capnweb@239

commit: df539d2

A typographic minus in a websocket.ts doc comment (introduced in cloudflare#209)
survived bundling into every dist runtime bundle in 0.11.0. Consumers
that inline the bundle through Latin-1-only APIs like btoa() throw on
any character above U+00FF and silently corrupt anything above U+007F.
Fix the comment, and enforce the invariant where it actually holds: a
post-build check fails if any non-ASCII byte reaches a runtime bundle
in dist/, since which source comments survive bundling is bundler
implementation detail.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@Maximo-Guk
Maximo-Guk marked this pull request as ready for review August 12, 2026 19:47
Comment thread.changeset/ascii-only-dist.md
@teamchong

Copy link
Copy Markdown
Collaborator

/bonk review this

@ask-bonkask-bonkBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed. This is a clean, well-targeted fix and the enforcement approach (checking built output rather than source) is the right call — bundlers decide which comments survive, so guarding dist/ is the correct invariant. The .map and .d.ts exclusions look intentional and correct. A few non-blocking observations below.

Overall LGTM.

Notes:

  • The changeset attributes the byte to 0.11.0. Per git history the §5.5 doc comment was introduced in #209 (commit ee7ca6f), so 0.11.0 is accurate for this character. @ndisidore's point about an earlier version is about cfos jumping 0.8.0 → 0.11.0 catching it late — worth reconciling the wording but not blocking.
  • The check reads dist/ non-recursively, which matches the current flat tsdown output. If entry-splitting ever emits shared chunks into subdirs, the check would silently skip them. See inline note.
  • The comment says "non-ASCII bytes" but the regex matches by code point after UTF-8 decode. Functionally equivalent for the goal; minor wording.

Comment threadscripts/check-dist-ascii.mjs Outdated
Comment threadscripts/check-dist-ascii.mjs Outdated
@ask-bonk

ask-bonkBot commented Aug 12, 2026

Copy link
Copy Markdown

Review posted successfully. Here's a summary of my findings on PR #239:

Review Summary

Verdict: LGTM — clean, well-targeted fix.

The PR fixes a U+2212 (typographic minus) and § in a websocket.ts doc comment (introduced in #209) that leaked into published dist/ bundles, and adds a post-build guard against non-ASCII bytes in runtime output.

Strengths

  • Right enforcement layer: The check guards built output (dist/) rather than source. Since bundlers decide which comments survive, this is the correct invariant to enforce.
  • Correct exclusions for .map and .d.ts files.
  • Minimal, focused source change.
  • Verified: no other non-ASCII characters currently exist in src/.

Non-blocking notes (posted inline)

  1. readdirSync is non-recursive — matches current flat tsdown output, but the tsdown config itself warns about shared chunks appearing when entries bundle together. If chunks ever land in subdirs, the check silently skips them. Suggested using { recursive: true }.
  2. Wording nit — the comment says "non-ASCII bytes" but the regex matches by code point after UTF-8 decode (characters, not raw bytes). Functionally fine.
  3. Changeset version attribution — confirmed via git history that the §5.5 comment came from Tidy the error-type map and WebSocket close-reason limit #209, so "0.11.0" is accurate for this character; reconciled with @ndisidore's earlier-version point (cfos jumped 0.8.0 → 0.11.0, catching it late).

github run

Maximo-Gukand others added 2 commits August 12, 2026 16:02
… attribution
Scan dist/ recursively so shared chunks emitted into subdirectories
(possible per the tsdown config's own note when entries bundle
together) can't slip past the check; verified a planted subdir file
fails it. Say "characters" rather than "bytes" since the regex matches
code points after UTF-8 decode, and attribute the U+2212 to cloudflare#209,
which first shipped in 0.11.0.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@teamchong
teamchong merged commit 667958e into cloudflare:mainAug 12, 2026
5 checks passed
@github-actionsgithub-actionsBot mentioned this pull request Aug 12, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@Maximo-Guk@teamchong@ndisidore
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers"); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

Keep published runtime bundles ASCII-only - #239

Merged
teamchong merged 3 commits into
cloudflare:mainfrom
Maximo-Guk:ascii-only-dist
Aug 12, 2026
Merged

Keep published runtime bundles ASCII-only#239
teamchong merged 3 commits into
cloudflare:mainfrom
Maximo-Guk:ascii-only-dist

Conversation

@Maximo-Guk

@Maximo-GukMaximo-Guk commented Aug 12, 2026

Copy link
Copy Markdown
Member

0.11.0's dist bundles carry a U+2212 (typographic minus) from a websocket.ts doc comment (#209). Discovered in Cloudflare OS capnweb bump. Consumers that inline the bundle - e.g. into a data: URL via btoa(), which only accepts Latin-1 - throw on it, and anything in U+0080–U+00FF would corrupt silently instead.

This fixes the comment and adds a post-build check that fails if any non-ASCII byte reaches a runtime bundle in dist/. Runtime strings that legitimately need non-ASCII can use \u escapes in source.

@changeset-bot

changeset-botBot commented Aug 12, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: df539d2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
NameType
capnwebPatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@pkg-pr-new

pkg-pr-newBot commented Aug 12, 2026

Copy link
Copy Markdown

Open in StackBlitz

npm i https://pkg.pr.new/cloudflare/capnweb@239

commit: df539d2

A typographic minus in a websocket.ts doc comment (introduced in cloudflare#209)
survived bundling into every dist runtime bundle in 0.11.0. Consumers
that inline the bundle through Latin-1-only APIs like btoa() throw on
any character above U+00FF and silently corrupt anything above U+007F.
Fix the comment, and enforce the invariant where it actually holds: a
post-build check fails if any non-ASCII byte reaches a runtime bundle
in dist/, since which source comments survive bundling is bundler
implementation detail.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@Maximo-Guk
Maximo-Guk marked this pull request as ready for review August 12, 2026 19:47
Comment thread.changeset/ascii-only-dist.md
@teamchong

Copy link
Copy Markdown
Collaborator

/bonk review this

@ask-bonkask-bonkBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed. This is a clean, well-targeted fix and the enforcement approach (checking built output rather than source) is the right call — bundlers decide which comments survive, so guarding dist/ is the correct invariant. The .map and .d.ts exclusions look intentional and correct. A few non-blocking observations below.

Overall LGTM.

Notes:

  • The changeset attributes the byte to 0.11.0. Per git history the §5.5 doc comment was introduced in #209 (commit ee7ca6f), so 0.11.0 is accurate for this character. @ndisidore's point about an earlier version is about cfos jumping 0.8.0 → 0.11.0 catching it late — worth reconciling the wording but not blocking.
  • The check reads dist/ non-recursively, which matches the current flat tsdown output. If entry-splitting ever emits shared chunks into subdirs, the check would silently skip them. See inline note.
  • The comment says "non-ASCII bytes" but the regex matches by code point after UTF-8 decode. Functionally equivalent for the goal; minor wording.

Comment threadscripts/check-dist-ascii.mjs Outdated
Comment threadscripts/check-dist-ascii.mjs Outdated
@ask-bonk

ask-bonkBot commented Aug 12, 2026

Copy link
Copy Markdown

Review posted successfully. Here's a summary of my findings on PR #239:

Review Summary

Verdict: LGTM — clean, well-targeted fix.

The PR fixes a U+2212 (typographic minus) and § in a websocket.ts doc comment (introduced in #209) that leaked into published dist/ bundles, and adds a post-build guard against non-ASCII bytes in runtime output.

Strengths

  • Right enforcement layer: The check guards built output (dist/) rather than source. Since bundlers decide which comments survive, this is the correct invariant to enforce.
  • Correct exclusions for .map and .d.ts files.
  • Minimal, focused source change.
  • Verified: no other non-ASCII characters currently exist in src/.

Non-blocking notes (posted inline)

  1. readdirSync is non-recursive — matches current flat tsdown output, but the tsdown config itself warns about shared chunks appearing when entries bundle together. If chunks ever land in subdirs, the check silently skips them. Suggested using { recursive: true }.
  2. Wording nit — the comment says "non-ASCII bytes" but the regex matches by code point after UTF-8 decode (characters, not raw bytes). Functionally fine.
  3. Changeset version attribution — confirmed via git history that the §5.5 comment came from Tidy the error-type map and WebSocket close-reason limit #209, so "0.11.0" is accurate for this character; reconciled with @ndisidore's earlier-version point (cfos jumped 0.8.0 → 0.11.0, catching it late).

github run

Maximo-Gukand others added 2 commits August 12, 2026 16:02
… attribution
Scan dist/ recursively so shared chunks emitted into subdirectories
(possible per the tsdown config's own note when entries bundle
together) can't slip past the check; verified a planted subdir file
fails it. Say "characters" rather than "bytes" since the regex matches
code points after UTF-8 decode, and attribute the U+2212 to cloudflare#209,
which first shipped in 0.11.0.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@teamchong
teamchong merged commit 667958e into cloudflare:mainAug 12, 2026
5 checks passed
@github-actionsgithub-actionsBot mentioned this pull request Aug 12, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@Maximo-Guk@teamchong@ndisidore
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode"); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })();
Skip to content

Keep published runtime bundles ASCII-only - #239

Merged
teamchong merged 3 commits into
cloudflare:mainfrom
Maximo-Guk:ascii-only-dist
Aug 12, 2026
Merged

Keep published runtime bundles ASCII-only#239
teamchong merged 3 commits into
cloudflare:mainfrom
Maximo-Guk:ascii-only-dist

Conversation

@Maximo-Guk

@Maximo-GukMaximo-Guk commented Aug 12, 2026

Copy link
Copy Markdown
Member

0.11.0's dist bundles carry a U+2212 (typographic minus) from a websocket.ts doc comment (#209). Discovered in Cloudflare OS capnweb bump. Consumers that inline the bundle - e.g. into a data: URL via btoa(), which only accepts Latin-1 - throw on it, and anything in U+0080–U+00FF would corrupt silently instead.

This fixes the comment and adds a post-build check that fails if any non-ASCII byte reaches a runtime bundle in dist/. Runtime strings that legitimately need non-ASCII can use \u escapes in source.

@changeset-bot

changeset-botBot commented Aug 12, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: df539d2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
NameType
capnwebPatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@pkg-pr-new

pkg-pr-newBot commented Aug 12, 2026

Copy link
Copy Markdown

Open in StackBlitz

npm i https://pkg.pr.new/cloudflare/capnweb@239

commit: df539d2

A typographic minus in a websocket.ts doc comment (introduced in cloudflare#209)
survived bundling into every dist runtime bundle in 0.11.0. Consumers
that inline the bundle through Latin-1-only APIs like btoa() throw on
any character above U+00FF and silently corrupt anything above U+007F.
Fix the comment, and enforce the invariant where it actually holds: a
post-build check fails if any non-ASCII byte reaches a runtime bundle
in dist/, since which source comments survive bundling is bundler
implementation detail.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@Maximo-Guk
Maximo-Guk marked this pull request as ready for review August 12, 2026 19:47
Comment thread.changeset/ascii-only-dist.md
@teamchong

Copy link
Copy Markdown
Collaborator

/bonk review this

@ask-bonkask-bonkBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed. This is a clean, well-targeted fix and the enforcement approach (checking built output rather than source) is the right call — bundlers decide which comments survive, so guarding dist/ is the correct invariant. The .map and .d.ts exclusions look intentional and correct. A few non-blocking observations below.

Overall LGTM.

Notes:

  • The changeset attributes the byte to 0.11.0. Per git history the §5.5 doc comment was introduced in #209 (commit ee7ca6f), so 0.11.0 is accurate for this character. @ndisidore's point about an earlier version is about cfos jumping 0.8.0 → 0.11.0 catching it late — worth reconciling the wording but not blocking.
  • The check reads dist/ non-recursively, which matches the current flat tsdown output. If entry-splitting ever emits shared chunks into subdirs, the check would silently skip them. See inline note.
  • The comment says "non-ASCII bytes" but the regex matches by code point after UTF-8 decode. Functionally equivalent for the goal; minor wording.

Comment threadscripts/check-dist-ascii.mjs Outdated
Comment threadscripts/check-dist-ascii.mjs Outdated
@ask-bonk

ask-bonkBot commented Aug 12, 2026

Copy link
Copy Markdown

Review posted successfully. Here's a summary of my findings on PR #239:

Review Summary

Verdict: LGTM — clean, well-targeted fix.

The PR fixes a U+2212 (typographic minus) and § in a websocket.ts doc comment (introduced in #209) that leaked into published dist/ bundles, and adds a post-build guard against non-ASCII bytes in runtime output.

Strengths

  • Right enforcement layer: The check guards built output (dist/) rather than source. Since bundlers decide which comments survive, this is the correct invariant to enforce.
  • Correct exclusions for .map and .d.ts files.
  • Minimal, focused source change.
  • Verified: no other non-ASCII characters currently exist in src/.

Non-blocking notes (posted inline)

  1. readdirSync is non-recursive — matches current flat tsdown output, but the tsdown config itself warns about shared chunks appearing when entries bundle together. If chunks ever land in subdirs, the check silently skips them. Suggested using { recursive: true }.
  2. Wording nit — the comment says "non-ASCII bytes" but the regex matches by code point after UTF-8 decode (characters, not raw bytes). Functionally fine.
  3. Changeset version attribution — confirmed via git history that the §5.5 comment came from Tidy the error-type map and WebSocket close-reason limit #209, so "0.11.0" is accurate for this character; reconciled with @ndisidore's earlier-version point (cfos jumped 0.8.0 → 0.11.0, catching it late).

github run

Maximo-Gukand others added 2 commits August 12, 2026 16:02
… attribution
Scan dist/ recursively so shared chunks emitted into subdirectories
(possible per the tsdown config's own note when entries bundle
together) can't slip past the check; verified a planted subdir file
fails it. Say "characters" rather than "bytes" since the regex matches
code points after UTF-8 decode, and attribute the U+2212 to cloudflare#209,
which first shipped in 0.11.0.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@teamchong
teamchong merged commit 667958e into cloudflare:mainAug 12, 2026
5 checks passed
@github-actionsgithub-actionsBot mentioned this pull request Aug 12, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@Maximo-Guk@teamchong@ndisidore