Uh oh!
There was an error while loading. Please reload this page.
Create typescript tests for apis - #2480
Conversation
hoodmane
left a comment
There was a problem hiding this comment.
Thanks @AdityaAtulTewari.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
| data = data + [src, "//src/workerd/server:workerd"] | ||
| data = data + [src, "//src/workerd/server:workerd"] + srcs | ||
| ts_srcs = [src for src in srcs if src.endswith(".ts")] |
There was a problem hiding this comment.
Is there a reason you need the new srcs argument at all? Why not just filter data for arguments that end in *.ts? It seems simpler to me.
There was a problem hiding this comment.
- Honestly it was cleaner to help me debug at first, I can collapse them.
There was a problem hiding this comment.
What does the failure look like if there is a type error? Would it be possible to add a test_ts_testing that forces a type error and asserts that it looks correct? Or did you manually verify this?
It looks to me like type errors generate build errors rather than test failures. Ideally we should probably use tsc --noCheck at build time and run tsc --noEmit as part of the test. But annoyingly, it looks like the --noCheck CLI option is only going to be released as part of typescript v5.6:
microsoft/TypeScript#58839
So maybe we can add this as a TODO for when typescript 5.6 comes out.
There was a problem hiding this comment.
- That makes sense I can add that todo
8ad05a6 to
0d67399Compare0d67399 to
05a6ecfCompare
No description provided.