Uh oh!
There was an error while loading. Please reload this page.
feat: Add IPv6 Compatible NLBs for AWS - #644
Merged
Merged
Conversation
* Adds NLB variants of existing classic load balancers * Adds dualstack support on the NLBs * CF TCP LB is now limited to 50 ports, instead of 100 Signed-off-by: Ismayil Mirzali <ismayil.mirzali@sap.com>
Signed-off-by: Ismayil Mirzali <ismayil.mirzali@sap.com>
beyhan
requested review from
a team, ramonskie and selzoc
and removed request for
a teamMay 22, 2025 14:55
aramprice
approved these changes
May 22, 2025
aramprice
left a comment
Member
There was a problem hiding this comment.
Seems reasonable since this is optional for consumers of bbl
ramonskie
approved these changes
May 29, 2025
Signed-off-by: Ismayil Mirzali <ismayil.mirzali@sap.com>
aramprice
commented
Jun 5, 2025
Member
@Volatus - could you please take a look at the unit test failures? |
Volatus
commented
Jun 5, 2025
ContributorAuthor
@aramprice yeah I'm trying to fix them |
beyhan
commented
Jun 12, 2025
Member
Waiting for the unit tests to be fixed |
peanball
commented
Jun 25, 2025
Contributor
Sorry for the delay with the unit tests. They're fixed now. |
peanballforce-pushed
the
feat/aws-ipv6-nlbs
branch
from
June 25, 2025 15:07
2392355 to
b088c06Compare
This was referenced Aug 18, 2025
beyhan
commented
Oct 29, 2025
Member
This introduced an issue which is currently discussed in https://cloudfoundry.slack.com/archives/C02HPPYQ2/p1761644101803199. |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, the CF LB and the Isolation Segments LBs are Classic Load Balancers, which only support IPv4. To add dualstack support for Ingress, we need to create NLBs instead.
This PR adds a new LB type,
nlbwhich create all the appropriate resources. There are no changes toconcourseorcflb types, these work as before.It also makes the further changes to OPs Generator to create an entry per for IPv4 and IPv6 when
dualstackis enabled.