Ipv6 validation for Javaspring apps - #1565
Conversation
| } | ||
|
|
||
| commandOptions := []string{"push", appName, "-m", memoryLimit, "-s", stack} | ||
| if manifestFile != "" { |
There was a problem hiding this comment.
Wouldn't it be easier to add the path to the Spring app to the list of assets here:
and then just use this folder for the
cf push -p parameter?
There was a problem hiding this comment.
Should this binary file really be changed?
There was a problem hiding this comment.
After additional testing, my conclusion is that this .jar file should be changed because of the functional changes in the .java file. I think new compilation is needed.
| "-s", stack, | ||
| ).Wait(Config.DetectTimeoutDuration())).To(Exit(0)) | ||
|
|
||
| if assetPath == "" { |
There was a problem hiding this comment.
The checks for assetPath == "" look a bit odd. As the Java Spring app requires a different logic, can you try to move that coding into a separate function? E.g. describeIPv6JavaSpring?
jochenehret
left a comment
There was a problem hiding this comment.
Just 2 small comments, looks good overall!
There was a problem hiding this comment.
Should this jar really be changed?
There was a problem hiding this comment.
The JAR file must be updated because the .java files have changed, adding new endpoints. Without updating the JAR file, it won't reflect these changes. This leads to errors when running the application and the tests afterwards:
[FAILED] Expected
<string>: {"timestamp":"2025-05-22T14:18:00.317+00:00","status":404,"error":"Not Found","path":"/ipv4-test"}
to contain substring
<string>: IPv4 validation resulted in success
Are you submitting this PR against the develop branch?
Yes.
What is this change about?
The change is part of the ipv6 egress validation cycle. We progressively extend all of the exciting buildpacks relevant to our ecosystem. In this PR we provide additional endpoints in the Java Spring application for testing IPv6 support. In case ipv6 validation is enabled, we verify that egress ipv6 call are possible with Java Spring applications.
Please provide contextual information.
https://github.com/cloudfoundry/community/blob/main/toc/rfc/rfc-0038-ipv6-dual-stack-for-cf.md
What version of cf-deployment have you run this cf-acceptance-test change against?
v48.9.0
Please check all that apply for this PR:
Did you update the README as appropriate for this change?
If you are introducing a new acceptance test, what is your rationale for including it CATs rather than your own acceptance test suite?
_CATs should validate IPv6 egress calls with JavaSpring application. We add changes regarding to this buildpack only. The test group for ipv6 was already created.
How many more (or fewer) seconds of runtime will this change introduce to CATs?
Around 90 seconds per test.
What is the level of urgency for publishing this change?
Tag your pair, your PM, and/or team!
@oliver-heinrich @iaftab-alam