Uh oh!
There was an error while loading. Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork 319
feat: Replace deprecated Doppler recentLogs with Log Cache client#1237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uh oh!
There was an error while loading. Please reload this page.
Changes from all commits
b6b52051afe7df61c556d7a4cb069f76d4403e1eb75ed6c0713aff7b8a8cdee5e0d918b39e64778d06ab5e78e8306d11f64ab560d7e7174bb236ad3f952c57e742f32File filter
Filter by extension
Conversations
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Uh oh!
There was an error while loading. Please reload this page.
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -17,6 +17,8 @@ | ||
| package org.cloudfoundry.operations.applications; | ||
| import org.cloudfoundry.doppler.LogMessage; | ||
| import org.cloudfoundry.logcache.v1.Log; | ||
| import org.cloudfoundry.logcache.v1.ReadRequest; | ||
| import reactor.core.publisher.Flux; | ||
| import reactor.core.publisher.Mono; | ||
| @@ -126,6 +128,15 @@ public interface Applications { | ||
| @Deprecated | ||
| Flux<LogMessage> logs(LogsRequest request); | ||
| /** | ||
| * List the applications logs from logCacheClient. | ||
| * If no messages are available, an empty Flux is returned. | ||
| * | ||
| * @param request the application logs request | ||
| * @return the applications logs | ||
| */ | ||
| Flux<Log> logsRecent(ReadRequest request); | ||
Comment on lines
+131
to
+138
Contributor There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. According to the original plan, we were to replace Maybe we should not introduce a new method, but update Author There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This would result in an incompatible change. I believe we should not release any incompatible changes in version 5.x.
| ||
| /** | ||
| * List the applications logs. | ||
| * Only works with {@code Loggregator < 107.0}, shipped in {@code CFD < 24.3} | ||
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.