Skip to content

Feature: handle rate limiting of UAA server. Fixes #1307 - #1332

Merged
Kehrlann merged 3 commits into
cloudfoundry:mainfrom
Lokowandtg:uaa_ratelimit
Dec 30, 2025
Merged

Feature: handle rate limiting of UAA server. Fixes #1307 #1332
Kehrlann merged 3 commits into
cloudfoundry:mainfrom
Lokowandtg:uaa_ratelimit

Conversation

@Lokowandtg

@LokowandtgLokowandtg commented Dec 17, 2025

Copy link
Copy Markdown
Contributor

Not tested on a system without ratelimiting...

@Lokowandtg
Lokowandtg requested review from Kehrlann, anthonydahanne, beyhan and s-yonkov-yonkov and removed request for KehrlannDecember 17, 2025 18:55
@LokowandtgLokowandtg mentioned this pull request Dec 17, 2025
Closed
This was referenced Dec 18, 2025
Closed
Closed
Kehrlann
Kehrlann requested changes Dec 18, 2025
View reviewed changes

@KehrlannKehrlann left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution!

[issue] the current implementation doesn't work when UAA_API_REQUEST_LIMIT is not set. See the suggestions in the IntegrationTestConfiguration class.

Comment threadintegration-test/src/test/resources/logback-test.xml Outdated
Comment threadintegration-test/src/test/java/org/cloudfoundry/ThrottlingUaaClient.java
Comment threadintegration-test/src/test/java/org/cloudfoundry/ThrottlingUaaClient.java Outdated
Comment threadintegration-test/src/test/java/org/cloudfoundry/ThrottlingUaaClient.java Outdated
Comment threadintegration-test/src/test/java/org/cloudfoundry/ThrottlingUaaClient.java Outdated
Comment threadintegration-test/pom.xml Outdated
Comment threadintegration-test/src/test/java/org/cloudfoundry/IntegrationTestConfiguration.java Outdated
Comment threadintegration-test/src/test/java/org/cloudfoundry/IntegrationTestConfiguration.java Outdated
Comment threadintegration-test/src/test/java/org/cloudfoundry/IntegrationTestConfiguration.java
@Kehrlann
Kehrlann self-requested a review December 30, 2025 09:49
Kehrlann
Kehrlann approved these changes Dec 30, 2025
View reviewed changes

@KehrlannKehrlann left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for your contribution 👍

@Kehrlann
Kehrlann merged commit 54dbf07 into cloudfoundry:mainDec 30, 2025
5 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@KehrlannKehrlannKehrlann approved these changes
@anthonydahanneanthonydahanneAwaiting requested review from anthonydahanne
@beyhanbeyhanAwaiting requested review from beyhan
@s-yonkov-yonkovs-yonkov-yonkovAwaiting requested review from s-yonkov-yonkov

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Lokowandtg@Kehrlann