Skip to content

Remove deprecated Doppler recentLogs for 6.x - #1350

Merged
Kehrlann merged 3 commits into
cloudfoundry:mainfrom
jorbaum:issue-1181-remove-recentlogs
Jun 29, 2026
Merged

Remove deprecated Doppler recentLogs for 6.x#1350
Kehrlann merged 3 commits into
cloudfoundry:mainfrom
jorbaum:issue-1181-remove-recentlogs

Conversation

@jorbaum

@jorbaumjorbaum commented Mar 30, 2026

Copy link
Copy Markdown
Contributor

Follows up on #1181 / #1348.

Note on default behavior

With recent changes in #1348logs(ApplicationLogsRequest) defaults to recent=true (LogCache) when recent is null. This differs from logs(LogsRequest), where null defaulted to recent=false (Doppler streaming).

┌──────────────┬────────────────────┬───────────────────┐
│ recent value │ Before #1348 │ After #1348. │
├──────────────┼────────────────────┼───────────────────┤
│ true │ Doppler recentlogs │ Log Cache │
├──────────────┼────────────────────┼───────────────────┤
│ null │ Doppler streaming │ Log Cache │
├──────────────┼────────────────────┼───────────────────┤
│ false │ Doppler streaming │ Doppler streaming │
└──────────────┴────────────────────┴───────────────────┘

This PR (code and description) was co-authored by Claude Opus 4 via Claude Code v2.1.87 and carefully reviewed and vetted by its human author.

@jorbaum

Copy link
Copy Markdown
ContributorAuthor

Added a PR to fix the regression: #1352

@jorbaum
jorbaumforce-pushed the issue-1181-remove-recentlogs branch from e3ecba3 to 3731bdeCompareMay 22, 2026 13:13
jorbaum added 2 commits May 22, 2026 15:20
Remove DopplerClient.recentLogs(), RecentLogsRequest,
Applications.logs(LogsRequest), and LogsRequest — all deprecated
in 5.x (cloudfoundry#1348). Inline the Doppler streaming path directly into
logs(ApplicationLogsRequest). Update README with breaking changes.
@jorbaum
jorbaumforce-pushed the issue-1181-remove-recentlogs branch from 3731bde to 0648948CompareMay 22, 2026 13:21
@jorbaum

Copy link
Copy Markdown
ContributorAuthor

Rebased and made sure the regression still has been fixed.

@jorbaum
jorbaum marked this pull request as ready for review May 22, 2026 13:22
@jorbaum

Copy link
Copy Markdown
ContributorAuthor

Ran the integration tests with kind-deployment.

I successfully ran the following tests:

  • org.cloudfoundry.logcache.v1.*Test (only LogCacheTest.readCounter and LogCacheTest.readEvent failing on kind-deployment, unrelated to my changes)
  • org.cloudfoundry.client.v3.*Test (only TasksTest, StacksTest, ProcessesTest, DeploymentsTest failing on kind-deployment, unrelated to my changes)
  • org.cloudfoundry.networking.v1.*Test

@Kehrlann
Kehrlann self-requested a review June 29, 2026 12:27
@Kehrlann
Kehrlann merged commit 356f550 into cloudfoundry:mainJun 29, 2026
5 checks passed
@jorbaum
jorbaum deleted the issue-1181-remove-recentlogs branch July 3, 2026 07:14
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@jorbaum@Kehrlann