Uh oh!
There was an error while loading. Please reload this page.
[PoC] Add --json flag to cli commands - #3249
Conversation
Signed-off-by: João Pereira <joao.pereira@broadcom.com>
a9954d8 to
9446280Compare
a-b
left a comment
There was a problem hiding this comment.
While it is debatable whether JSON belongs to UI, this is a good proof of concept.
Gerg
commented
Nov 19, 2024
I haven't reviewed this PR in detail, but a couple quick thoughts:
|
joaopapereira
commented
Nov 19, 2024
That was my first attempt but even when you look at the apps command you can see that the output is split into 3 different calls to the UI Writer, which makes it complicated to abstract out.
I do not have a strong opinion about that, are we planning on adding TOML or YAML support, or are we just covering our basis here? |
Description of the Change
This change adds the
--jsonflags to the commandsapps,app, andget-health-checkcommands as a PoC for us to understand how complicated this would be.