Add diego.executor.inject_workload_identity BOSH property - #1204
Conversation
Exposes the InjectWorkloadIdentity ExecutorConfig flag as a rep job property (default false). Operators set this to true on cells where all volume drivers accept the _workload_guid/_workload_type keys.
ead8138 to
4474400
Compare
|
hey @klapkov Thanks for the PR. Can this PR be merged? We need a new Diego release with the fix as our validation pipeline is blocked and unable to cut new cf release. Thanks |
ameowlia
left a comment
There was a problem hiding this comment.
AI reported a missing test.
[MINOR] — src/code.cloudfoundry.org/executor/depot/containerstore/containerstore_test.go / Missing false-path test for Workload Identity Injection — Testing The test suite verifies the injection behavior when injectWorkloadIdentity is true, but lacks an explicit test ensuring the keys are not injected when the flag is false (the default configuration). Fix: Add a test context in containerstore_test.go asserting that when injectWorkloadIdentity is false, the volume manager mount config does not contain the _workload_guid or _workload_type keys.
| description: "Experimental: arbitrary command to run after setup action" | ||
| diego.executor.post_setup_user: | ||
| description: "Experimental: user to run post setup hook command" | ||
| diego.executor.inject_workload_identity: |
There was a problem hiding this comment.
Can you update this description to include a bit of info about why someone might want to do this?
| config[:volman_driver_paths] = value | ||
| end | ||
|
|
||
| config[:inject_workload_identity] = p("diego.executor.inject_workload_identity") |
There was a problem hiding this comment.
Can you update the rspec tests for this new property?
Exposes the InjectWorkloadIdentity ExecutorConfig flag as a rep job property (default false). Operators set this to true on cells where all volume drivers accept the _workload_guid/_workload_type keys. This way the nfs-volume isn't obligated to support the new workload_identidy keys.
Fixes: #1203
Summary
Backward Compatibility
Breaking Change? Yes/No