Skip to content

Leverage markdown docs - #1220

Merged
tylersticka merged 4 commits into
v-nextfrom
feature/leverage-markdown-docs
May 14, 2021
Merged

Leverage markdown docs#1220
tylersticka merged 4 commits into
v-nextfrom
feature/leverage-markdown-docs

Conversation

@tylersticka

@tylerstickatylersticka commented May 14, 2021

Copy link
Copy Markdown
Member

Overview

Our previous "Getting started" page was pretty spartan, and it had a comment warning editors to manually sync its content with our README.md page. This PR uses a technique I stole from @Paul-Hebert for importing the Markdown and displaying it within a docs page.

The README had a few links in it that were specific to the GitHub repository, so I used .replace on the imported string to make them more relevant. I also removed a Renovate badge which seemed to no longer be functional since their acquisition.

Because that page now felt like a more general introduction to the project, I renamed it "Introduction." I also added our "Contributing" and "Changelog" docs, and put them all in a docs directory to clean up src a bit.

Screenshots

Screenshot_2021-05-14 Introduction - Page ⋅ Storybook

Screenshot_2021-05-14 Contributing - Page ⋅ Storybook

Screenshot_2021-05-14 Changelog - Page ⋅ Storybook

Testing

View documentation pages in deploy preview

@changeset-bot

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: d3ac784

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@tylersticka
tylersticka marked this pull request as ready for review May 14, 2021 23:08
@tylersticka
tylersticka requested a review from a teamMay 14, 2021 23:08

@Paul-HebertPaul-Hebert left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

Good call, I really like this approach (planning to write a micro blog post about it when I have some time)

.replace(
/\[(.+)]\(CONTRIBUTING\.md\)/g,
'<a href="../?path=/story/contributing--page">$1</a>'
)}

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is clever 👍

@tylersticka
tylersticka merged commit 8fedd41 into v-nextMay 14, 2021
@tylersticka
tylersticka deleted the feature/leverage-markdown-docs branch May 14, 2021 23:13
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@tylersticka@Paul-Hebert