Set a default form_id for the subscribe pattern for testing

[calebeby]

Conversation here: #1679 (comment)

@gerardo-rodriguez an alternate solution would be to make the twig file itself have its own default value for the form ID, but I don't know if that is the best because it would mean that the form id would be duplicated on the page if you included the subscribe component multiple times on the same page. Do you know if there is a way to make a twig prop required, so that it'll throw an error or something if the prop is missing?

[changeset-bot]

⚠️ No Changeset found

Latest commit: f89d83d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[netlify]

✅ Deploy Preview for cloudfour-patterns ready!

Name	Link
🔨 Latest commit	f89d83d
🔍 Latest deploy log	https://app.netlify.com/sites/cloudfour-patterns/deploys/6241e5f6c331ba0008f01212
😎 Deploy Preview	https://deploy-preview-1689--cloudfour-patterns.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site settings.

[gerardo-rodriguez]

an alternate solution would be to make the twig file itself have its own default value for the form ID, but I don't know if that is the best because it would mean that the form id would be duplicated on the page if you included the subscribe component multiple times on the same page.

@calebeby I agree, I'd be concerned the form ID would be duplicated on the page if the component existed multiple times on the same page.

Do you know if there is a way to make a twig prop required, so that it'll throw an error or something if the prop is missing?

I am not aware, but also Twig isn't my forte so there might be something I'm not aware of.

[gerardo-rodriguez]

Thanks, @calebeby!

[gerardo-rodriguez]

an alternate solution would be to make the twig file itself have its own default value for the form ID, but I don't know if that is the best because it would mean that the form id would be duplicated on the page if you included the subscribe component multiple times on the same page.

@calebeby I agree, I'd be concerned the form ID would be duplicated on the page if the component existed multiple times on the same page.

Do you know if there is a way to make a twig prop required, so that it'll throw an error or something if the prop is missing?

I am not aware, but also Twig isn't my forte so there might be something I'm not aware of.

@calebeby Maybe you could do something with defined? Maybe render a message instead of the component if a given prop is not defined? 🤔

[calebeby]

Oh yeah that might be helpful. IDK if it's worth it, but we could probably make a error pattern that is very visible/flashy and then go through all our patterns and make them render the error pattern if any of their required props are missing

[gerardo-rodriguez]

That's an interesting idea! I can create a GH issue and we can leave it in the backlog as a nice-to-have as I imagine it'll be a lower priority through this initial phase of work.