Skip to content

Design/error alert - #1937

Merged
AriannaChau merged 8 commits into
v-nextfrom
design/error-alert
Jul 19, 2022
Merged

Design/error alert#1937
AriannaChau merged 8 commits into
v-nextfrom
design/error-alert

Conversation

@AriannaChau

@AriannaChauAriannaChau commented Jul 12, 2022•
edited
Loading

Copy link
Copy Markdown
Contributor

Overview

This PR:

  • Add Error alert
  • Add sad-emoji to correspond with the Error alert
  • Add Status Color design section
  • Add 2 new red colors

I've added a TODO, I don't wanna bug a developer when we're so close to launch. I'm going to create an issue to make the icon and color change automatic, instead of just the color when the class is applied. I don't know how to do that. Or, I can convert this PR to a draft and come back to it when a dev is more available.

Screenshots

Color design tokens:
Screen Shot 2022-07-12 at 2 46 32 PM

Error alert:
Screen Shot 2022-07-12 at 2 48 03 PM

Icon:
Screen Shot 2022-07-12 at 2 48 30 PM

Testing

  1. Alert
  2. Design Tokens

@changeset-bot

changeset-botBot commented Jul 12, 2022•
edited
Loading

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 141bccf

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
NameType
@cloudfour/patternsMinor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@netlify

netlifyBot commented Jul 12, 2022•
edited
Loading

Copy link
Copy Markdown

✅ Deploy Preview for cloudfour-patterns ready!

NameLink
🔨 Latest commit141bccf
🔍 Latest deploy loghttps://app.netlify.com/sites/cloudfour-patterns/deploys/62d72179a7f34b000939c66f
😎 Deploy Previewhttps://deploy-preview-1937--cloudfour-patterns.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@AriannaChau
AriannaChau marked this pull request as ready for review July 12, 2022 21:51
tylersticka
tylersticka reviewed Jul 12, 2022
View reviewed changes
Comment thread.changeset/nervous-glasses-sparkle.md Outdated
Comment threadsrc/assets/icons/sad-emoji.svg Outdated
Comment threadsrc/assets/icons/sad-emoji.svg Outdated
Comment threadsrc/components/alert/alert.scss Outdated
Comment threadsrc/components/alert/alert.stories.mdx Outdated
Comment threadsrc/components/alert/alert.stories.mdx Outdated
Comment threadsrc/design/colors.stories.mdx Outdated
Comment threadsrc/design/colors.stories.mdx Outdated
tylersticka
tylersticka reviewed Jul 18, 2022
View reviewed changes
Comment thread.changeset/nervous-glasses-sparkle.md Outdated
Comment threadsrc/assets/icons/confused-face.svg
Comment threadsrc/assets/icons/confused-face.svg Outdated
Comment threadsrc/components/alert/alert.scss Outdated
Comment threadsrc/components/alert/alert.scss Outdated
Comment threadsrc/components/alert/alert.stories.mdx Outdated
Comment threadsrc/design/colors.stories.mdx Outdated
Comment threadsrc/tokens/color/status.json Outdated
AriannaChauand others added 3 commits July 18, 2022 13:34
@AriannaChau@tylersticka
Update src/design/colors.stories.mdx
785c256
Co-authored-by: Tyler Sticka <tyler@cloudfour.com>
@AriannaChau
Change size of icon
7e6aeb2
Edit changeset message
Move content around
Delete comments in json file
@AriannaChau
Change desription
6565aa7
tylersticka
tylersticka previously approved these changes Jul 19, 2022
View reviewed changes
Comment threadsrc/components/alert/alert.scss Outdated
@AriannaChau
AriannaChau merged commit 87f012d into v-nextJul 19, 2022
@AriannaChau
AriannaChau deleted the design/error-alert branch July 19, 2022 21:39
@tylerstickatylersticka mentioned this pull request Jul 19, 2022
Open
This was referenced Jul 19, 2022
Closed
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tylerstickatylerstickatylersticka approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add an Error pattern to help with required component props

2 participants

@AriannaChau@tylersticka