Skip to content

Remove the dead welcome.mdx entry from Storybook's stories globs - #2441

Merged
spaceninja merged 1 commit into
mainfrom
remove-dead-welcome-glob
Aug 24, 2026
Merged

Remove the dead welcome.mdx entry from Storybook's stories globs#2441
spaceninja merged 1 commit into
mainfrom
remove-dead-welcome-glob

Conversation

@spaceninja

@spaceninjaspaceninja commented Aug 24, 2026•
edited
Loading

Copy link
Copy Markdown
Member

Overview

Storybook has been printing No story files found for the specified pattern: ./src/welcome.mdx on every build. That file was removed a while ago, but the glob loading it stayed, along with a comment explaining that it was listed separately so it would sort to the top of the sidebar. src/docs/intro.mdx has been doing that job ever since, so the comment was the stale half rather than the glob — there is no welcome page to bring back.

Storybook does not fail on an unmatched glob, it just warns and moves on, which is why this survived as long as it did.

Screenshots

Testing

  • Open the deploy preview. The first item in the left sidebar should be Introduction, followed by Contributing and Changelog.
  • Click each of those three — every page should render its documentation the same as it does on the production library.
  • Spot-check a few component pages further down the sidebar to confirm nothing went missing. The sidebar should hold the same 337 entries as before.
  • Optionally, run npm run build-storybook locally. The output should no longer contain a "No story files found for the specified pattern" line.

@spaceninja
Remove the dead welcome.mdx entry from Storybook's stories globs
12ad260
src/welcome.mdx no longer exists, so Storybook printed 'No story files
found for the specified pattern' on every build. src/docs/intro.mdx
already sorts first and serves the purpose the entry's comment described,
so the sidebar order is unaffected.
@changeset-bot

changeset-botBot commented Aug 24, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 12ad260

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@netlify

netlifyBot commented Aug 24, 2026•
edited
Loading

Copy link
Copy Markdown

✅ Deploy Preview for cloudfour-patterns ready!

NameLink
🔨 Latest commit12ad260
🔍 Latest deploy loghttps://app.netlify.com/projects/cloudfour-patterns/deploys/6a8c74bfe9d3120008891e99
😎 Deploy Previewhttps://deploy-preview-2441--cloudfour-patterns.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@spaceninja
spaceninja merged commit e93c31c into mainAug 24, 2026
8 checks passed
@spaceninja
spaceninja deleted the remove-dead-welcome-glob branch August 24, 2026 16:49
@spaceninjaspaceninja mentioned this pull request Aug 24, 2026
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Storybook globs a nonexistent src/welcome.mdx

1 participant

@spaceninja