Uh oh!
There was an error while loading. Please reload this page.
Remove the engines.node field - #2443
Merged
Merged
Conversation
Nothing in the published files runs on Node, so the field only ever gated installation -- on a >=12.16.3 floor nobody chose. Its matching Renovate rule goes with it: that rule existed to stop Renovate pinning engines.node, and we declare no peerDependencies, so it now matches nothing. The eslint-plugin-n `version` setting stays, since that is where the Node version we develop on belongs; its comment no longer describes engines.node as something we declare.
🦋 Changeset detectedLatest commit: 9b006c0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for cloudfour-patterns ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
package.jsondeclaredengines.node: ">=12.16.3", which npm uses to warn on or refuse an install. Nothing we publish runs on Node — the package ships CSS, Sass, Twig templates, assets and a browser bundle — so the field never described a real requirement, and the floor it set was inherited rather than chosen. Dropping it can only loosen who is able to install us, so it lands as a patch.The matching
.renovaterc.jsonrule goes with it. That rule was added in the same PR (#689) that created the field, purely to stop Renovate from pinningengines.node; since we declare nopeerDependencieseither, withenginesgone it matches nothing at all..nvmrcand the pinnednode-versionin the CI workflows are what actually control our development and CI environment, and neither is affected. Theeslint-plugin-nversionsetting also stays — that is the right home for "what Node do we develop on" — but its comment no longer describesengines.nodeas a field we declare.Screenshots
Testing
Nothing here changes how the library renders, so the check is on the published metadata:
npm packand unpack the resulting tarball (or runnpm pack --dry-run).package.jsoninside it — there should be noenginesblock, and everything else about the packed file list should look the same as before.npm startand confirm Storybook still boots and serves the library normally. Nothing should have changed about local development.engines.nodeis for, or remove it #2423