Uh oh!
There was an error while loading. Please reload this page.
Restore the frame on Button Swap's Default story - #2448
Merged
Conversation
The pre-#2405 MDX set `inline={false}` on this story and the CSF migration did not carry it across -- the only `inline` attribute in the whole of the old MDX, and the one genuine drop the #2428 sweep found. No `iframeHeight` alongside it, matching the original: the component measures ~45px against Storybook's 100px default, so this cannot reproduce the clipping #2420 fixed. Part of #2428
✅ Deploy Preview for cloudfour-patterns ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
The #2428 sweep compared every
<Story>attribute in the pre-migration MDX against the CSF files, and this was the one genuine drop it found: Button Swap's Default story setinline={false}, and the CSF migration in #2405 did not carry it across. It was the onlyinlineattribute in the whole of the old MDX, which is presumably why it slipped — there was no pattern to notice.Restoring it returns the story to the rendering it had before the migration, the same conservative approach #2420 took with the thirty iframe heights. Deliberately no
iframeHeightto accompany it, matching the original, which had noheightattribute either — the component measures about 45px against Storybook's 100px default, so this cannot reproduce the clipping #2420 fixed. Verified by rendering the component against the published stylesheet rather than assumed.This does not settle whether the story should be framed — that is the per-story judgment in #2428's Part 2, which covers thirteen other locations and is unaffected by this. All this PR does is stop the setting being absent by accident rather than by decision, so Part 2 has a clean slate to work from.
Screenshots
Testing