Skip to content

Render the Logo and Input stories inline again#2449

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
spaceninja merged 1 commit into from
Aug 24, 2026
Merged

Render the Logo and Input stories inline again #2449

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions src/components/input/input.stories.js
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -19,13 +19,9 @@ const elasticTextAreaConfig = {
class: 'js-elastic-textarea',
};

// Inline stories disabled because when the same input element is rendered with
// different settings within the same file, React syncs all their properties.

/** @type {Meta} */
const meta = {
title: 'Components/Input',
parameters: { docs: { story: { inline: false } } },
};

export default meta;
Expand DownExpand Up@@ -82,7 +78,6 @@ export const ElasticTextarea = {
},
parameters: {
docs: {
story: { iframeHeight: '250px' },
source: {
code: makeTwigInclude(
'@cloudfour/components/input/input.twig',
Expand Down
7 changes: 0 additions & 7 deletions src/components/logo/logo.stories.js
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -4,16 +4,9 @@ import logoTemplate from './logo.twig';
import './demo/alignment.scss';
const alignOptions = ['start', 'center', 'end'];

// This component's options rely on CSS custom properties, which are currently
// broken in the library we use for inlining Storybook stories. Until that issue
// is resolved, we must fallback to iframes for these stories. 🙈️
//
// @see https://github.com/aknuds1/html-to-react/issues/144

/** @type {Meta} */
const meta = {
title: 'Components/Logo',
parameters: { docs: { story: { inline: false } } },
};

export default meta;
Expand Down