Uh oh!
There was an error while loading. Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork 3
Add Favicons and Logo#535
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uh oh!
There was an error while loading. Please reload this page.
Changes from all commits
5c7316955ff829dbd098c4d38c7e3d98ebad767dfeFile filter
Filter by extension
Conversations
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Uh oh!
There was an error while loading. Please reload this page.
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| import { create } from '@storybook/theming/create'; | ||
| export default create({ | ||
| base: 'light', | ||
| brandTitle: 'Cloud Four Patterns', | ||
| brandUrl: 'https://cloudfour.com', | ||
| brandImage: '/logo.svg' | ||
| }); |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| <link rel="shortcut icon" href="/favicon-%NODE_ENV%.ico" /> | ||
Member There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Nit: Self-closing tag not necessary in HTML5? MemberAuthor There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Looks like Prettier is adding it back in. I'll see if I can disable that. MemberAuthor There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Holy wow, this turns out to be a contentious topic in the Prettier community: prettier/prettier#5246 TL;DR: There's no option to disable it right now, and Prettier will always add the self-closing tag slash back in. | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| import { addons } from '@storybook/addons'; | ||
| import cloudFourTheme from './cloud-four-theme'; | ||
| addons.setConfig({ | ||
| theme: cloudFourTheme | ||
| }); |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| import { Meta } from '@storybook/addon-docs/blocks'; | ||
| <Meta title="Getting Started" /> | ||
| # Welcome! | ||
| This is the pattern library for Cloud Four. | ||
| Details coming soon. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add a comment explaining that this is intended to control the order? I'm aware of three methods for controlling the nav order so it would be helpful to know that is the intention here.