Skip to content

Pin Node.js to 14.3.0 - autoclosed - #690

Closed
renovate[bot] wants to merge 1 commit into
v-nextfrom
renovate/pin-dependencies
Closed

Pin Node.js to 14.3.0 - autoclosed#690
renovate[bot] wants to merge 1 commit into
v-nextfrom
renovate/pin-dependencies

Conversation

@renovate

@renovaterenovateBot commented May 7, 2020

Copy link
Copy Markdown
Contributor

This PR contains the following updates:

PackageTypeUpdateChange
nodeenginespin>=12.16.3 -> 14.3.0

📌 Important: Renovate will wait until you have merged this Pin PR before creating any upgrade PRs for the affected packages. Add the preset :preserveSemverRanges your config if you instead don't wish to pin dependencies.


Renovate configuration

📅 Schedule: At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻️ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by WhiteSource Renovate. View repository job log here.

@renovate
renovateBot requested a review from a teamMay 7, 2020 23:27
@calebeby

Copy link
Copy Markdown
Contributor

Noooooooooooo

@spaceninja

Copy link
Copy Markdown
Member

@calebeby why is this bad? Is our app not compatible with Node 14?

@renovate
renovateBotforce-pushed the renovate/pin-dependencies branch 3 times, most recently from 6d820de to b6cccf2CompareMay 11, 2020 18:03
@calebeby

Copy link
Copy Markdown
Contributor

#689

If we pin the engines version to node 14, we are saying that we only support node 14, meaning that all package consumers have to upgrade.

@renovate
renovateBotforce-pushed the renovate/pin-dependencies branch 11 times, most recently from 6b56717 to e1ba6f2CompareMay 18, 2020 17:40
@renovate
renovateBotforce-pushed the renovate/pin-dependencies branch 5 times, most recently from 16bcc32 to aa92de9CompareMay 19, 2020 16:55
@spaceninja

Copy link
Copy Markdown
Member

@calebeby is there any action we can take on this PR? If we don't want to merge it, is there some way we can indicate to renovate that we don't want to pin this? (If you don't know, I can research it, just asking in case you already know)

@calebeby

Copy link
Copy Markdown
Contributor

If we close this PR, it won't keep updating it (until 14.2.1 exists)

But I have a branch locally that disables this (I think), I'll submit a PR later today

I don't want to close this PR because then we won't be able to test that config change right away (once that config change gets merged, renovate should auto-close this)

@spaceninjaspaceninja added the ⚰️ won’t fix This will not be worked on label May 19, 2020
@renovate
renovateBotforce-pushed the renovate/pin-dependencies branch 2 times, most recently from 03dc9f5 to 9a429b0CompareMay 19, 2020 21:55
@renovaterenovateBot changed the title Pin Node.js to 14.2.0Pin Node.js to 14.3.0May 19, 2020
@renovate
renovateBotforce-pushed the renovate/pin-dependencies branch from 9a429b0 to 6e4923fCompareMay 19, 2020 22:52
@renovate
renovateBotforce-pushed the renovate/pin-dependencies branch 3 times, most recently from e5e2a87 to 6621478CompareMay 20, 2020 17:09
@renovate
renovateBotforce-pushed the renovate/pin-dependencies branch from 6621478 to ec21938CompareMay 21, 2020 17:36
@renovaterenovateBot changed the title Pin Node.js to 14.3.0Pin Node.js to 14.3.0 - autoclosedMay 21, 2020
@renovaterenovateBot closed this May 21, 2020
@renovate
renovateBot deleted the renovate/pin-dependencies branch May 21, 2020 19:59
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

⚰️ won’t fixThis will not be worked on

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@calebeby@spaceninja@renovate-bot