Uh oh!
There was an error while loading. Please reload this page.
Fix stale default configuration after removing a saved config - #118
Merged
Conversation
`__default__` could name a config that no longer exists, which suppressed the auto-default rule on the next save. - `load_config` drops a `__default__` naming no saved config; stale keys clear on the next write, since every mutation rebuilds the file from a load_config result. - Add `remove_named_config`, counterpart to `save_named_config`: one atomic write that deletes the config and re-points the default. Used by `logout` and `config -rm`. - Promote a lone survivor to default when the removed config held it, unless the environment configures Cloudinary - a stored default outranks the environment, so promoting would take precedence from CLOUDINARY_URL. `_is_sole_usable_config` holds that rule for the save and remove paths. - `cld logout` with a single saved login confirms it instead of showing a one-item menu. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
__default__could name a config that no longer exists, which suppressed the auto-default rule on the next save.load_configdrops a__default__naming no saved config; stale keys clear on the next write, since every mutation rebuilds the file from a load_config result.remove_named_config, counterpart tosave_named_config: one atomic write that deletes the config and re-points the default. Used bylogoutandconfig -rm._is_sole_usable_configholds that rule for the save and remove paths.cld logoutwith a single saved login confirms it instead of showing a one-item menu.Brief Summary of Changes
What does this PR address?
Are tests included?
Reviewer, please note:
Checklist: