Skip to content

Fix #129: do not silence RuntimeError in dump() - #140

Merged
ogrisel merged 1 commit into
cloudpipe:masterfrom
pitrou:reraise_pickle_exceptions
Dec 13, 2017
Merged

Fix #129: do not silence RuntimeError in dump()#140
ogrisel merged 1 commit into
cloudpipe:masterfrom
pitrou:reraise_pickle_exceptions

Conversation

@pitrou

Copy link
Copy Markdown
Member

No description provided.

@codecov-io

codecov-io commented Dec 13, 2017

Copy link
Copy Markdown

Codecov Report

Merging #140 into master will decrease coverage by 0.06%.
The diff coverage is 100%.

Impacted file tree graph

@@ Coverage Diff @@## master #140 +/- ##
==========================================
- Coverage 83.85% 83.79% -0.07% 
==========================================
Files 2 1 -1 Lines 539 537 -2 Branches 98 98 ==========================================
- Hits 452 450 -2 + Misses 64 63 -1 - Partials 23 24 +1
Impacted FilesCoverage Δ
cloudpickle/cloudpickle.py83.79% <100%> (+0.03%)⬆️
cloudpickle/__init__.py

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update abeb3fb...a62d920. Read the comment docs.

@ogrisel

Copy link
Copy Markdown
Contributor

LGTM!

@ogrisel
ogrisel merged commit 0c1fde1 into cloudpipe:masterDec 13, 2017
@pitrou
pitrou deleted the reraise_pickle_exceptions branch December 13, 2017 15:41
BryanCutler added a commit to BryanCutler/spark that referenced this pull request Jan 31, 2018
HyukjinKwon pushed a commit to HyukjinKwon/cloudpickle that referenced this pull request Feb 6, 2018
@colinc719colinc719 mentioned this pull request May 2, 2018
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@pitrou@codecov-io@ogrisel