Uh oh!
There was an error while loading. Please reload this page.
Remove annotations for python3.6 and below - #197
Conversation
ogrisel
commented
Sep 14, 2018
I have no strong opinion. I believe it's ok to remove a half broken half working feature. We should probably do it as part of 0.6 and document that well in the changelog. |
ogrisel
commented
Sep 19, 2018
I pinged several reviewers to get a second opinion on this change. |
pitrou
commented
Sep 19, 2018
Agreed with this. It's unfortunate that |
mrocklin
commented
Sep 19, 2018
No objection from me. I don't know this topic well though. I'm inclined to trust @pitrou . |
ogrisel
commented
Sep 19, 2018
@cicdw can you please add an entry to document this change to the change log file? |
cicdw
commented
Sep 19, 2018
@ogrisel yup, done. |
Codecov Report
@@ Coverage Diff @@## master #197 +/- ##
=======================================
Coverage 85.16% 85.16% =======================================
Files 1 1 Lines 573 573 Branches 111 111 =======================================
Hits 488 488 Misses 62 62 Partials 23 23
Continue to review full report at Codecov.
|
ogrisel
commented
Sep 19, 2018
Alright, let's merge then! Thanks @cicdw. |
Closes#193 and closes#196 with a heavy hand, by removing the ability to include
__annotations__in versions of python < 3.7.It seemed the ability to pickle arbitrary
typingclasses was a deep rabbit hole external tocloudpickle, and AFAIK the alternative would be some sort of check / try / except on annotations that would lead to inconsistent pickling of__annotations__.